efreet: fix memory leak
authorenglebass <englebass@7cbeb6ba-43b4-40fd-8cce-4c39aea84d33>
Mon, 2 Jul 2012 08:17:02 +0000 (08:17 +0000)
committerenglebass <englebass@7cbeb6ba-43b4-40fd-8cce-4c39aea84d33>
Mon, 2 Jul 2012 08:17:02 +0000 (08:17 +0000)
Don't allocate event structure unless we have a cache change.

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/efreet@73133 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

ChangeLog
src/lib/efreet_cache.c

index 9d31d4d..46f0995 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
 2012-06-25 Sebastian Dransfeld
 
         * Support XDG_DESKTOP_DIR and read user-dirs.dirs
+
+2012-07-02 Sebastian Dransfeld
+
+       * Fix minor memory leak in cache update handler
index 1bebed8..9e84fbc 100644 (file)
@@ -1113,10 +1113,11 @@ cache_update_cb(void *data __UNUSED__, Ecore_File_Monitor *em __UNUSED__,
     if (!file) return;
     if (!strcmp(file, "desktop_data.update"))
     {
-        ev = NEW(Efreet_Event_Cache_Update, 1);
-        if (!ev) goto error;
         if (cache_check_change(path))
         {
+            ev = NEW(Efreet_Event_Cache_Update, 1);
+            if (!ev) goto error;
+
             IF_RELEASE(util_cache_names_key);
             IF_RELEASE(util_cache_hash_key);