e_dbus/connman: remove wrong method

There's no Ethernet.Netmask property since ever. Remove wrong method.

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/e_dbus@65176 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

diff --git a/src/bin/e_dbus_connman_test.c b/src/bin/e_dbus_connman_test.c
index 99f35ea..89796e4 100644 (file)
--- a/src/bin/e_dbus_connman_test.c
+++ b/src/bin/e_dbus_connman_test.c
@@ -1619,29 +1619,6 @@ _on_cmd_service_get_ethernet_mtu(__UNUSED__ char *cmd, char *args)
 }
 
 static Eina_Bool
-_on_cmd_service_get_ethernet_netmask(__UNUSED__ char *cmd, char *args)
-{
-   const char *ethernet_netmask, *path;
-   E_Connman_Element *e;
-
-   if (!args)
-     {
-       fputs("ERROR: missing the service path\n", stderr);
-       return ECORE_CALLBACK_RENEW;
-     }
-   _tok(args);
-   path = args;
-
-   e = e_connman_service_get(path);
-   if (e_connman_service_ethernet_netmask_get(e, &ethernet_netmask))
-     printf(":::Service %s Ethernet Netmask = \"%s\"\n",
-           path, ethernet_netmask);
-   else
-     fputs("ERROR: can't get service ethernet netmask\n", stderr);
-   return ECORE_CALLBACK_RENEW;
-}
-
-static Eina_Bool
 _on_cmd_technology_get_state(__UNUSED__ char *cmd, char *args)
 {
    const char *state, *path;
@@ -1782,7 +1759,6 @@ _on_input(__UNUSED__ void *data, Ecore_Fd_Handler *fd_handler)
      {"service_get_ethernet_method", _on_cmd_service_get_ethernet_method},
      {"service_get_ethernet_address", _on_cmd_service_get_ethernet_address},
      {"service_get_ethernet_mtu", _on_cmd_service_get_ethernet_mtu},
-     {"service_get_ethernet_netmask", _on_cmd_service_get_ethernet_netmask},
      {"technology_get_state", _on_cmd_technology_get_state},
      {"technology_get_type", _on_cmd_technology_get_type},
      {"technology_get_name", _on_cmd_technology_get_name},

diff --git a/src/bin/e_dbus_connman_test_api.c b/src/bin/e_dbus_connman_test_api.c
index 5cfb78e..062b00e 100644 (file)
--- a/src/bin/e_dbus_connman_test_api.c
+++ b/src/bin/e_dbus_connman_test_api.c
@@ -446,7 +446,6 @@ static const struct test_desc test_desc_service[] = {
   TEST_DESC_STRING_GET(e_connman_service_ethernet_method_get, 1),
   TEST_DESC_STRING_GET(e_connman_service_ethernet_address_get, 1),
   TEST_DESC_USHORT_GET(e_connman_service_ethernet_mtu_get, 1),
-  TEST_DESC_STRING_GET(e_connman_service_ethernet_netmask_get, 1),
   TEST_DESC_SENTINEL
 };
 

diff --git a/src/lib/connman/E_Connman.h b/src/lib/connman/E_Connman.h
index 2c0e8cc..fec6190 100644 (file)
--- a/src/lib/connman/E_Connman.h
+++ b/src/lib/connman/E_Connman.h
@@ -172,7 +172,6 @@ EAPI Eina_Bool              e_connman_service_ipv4_configuration_netmask_get(con
 EAPI Eina_Bool              e_connman_service_ethernet_method_get(const E_Connman_Element *service, const char **method) EINA_ARG_NONNULL(1, 2) EINA_WARN_UNUSED_RESULT;
 EAPI Eina_Bool              e_connman_service_ethernet_address_get(const E_Connman_Element *service, const char **address) EINA_ARG_NONNULL(1, 2) EINA_WARN_UNUSED_RESULT;
 EAPI Eina_Bool              e_connman_service_ethernet_mtu_get(const E_Connman_Element *service, unsigned short *mtu) EINA_ARG_NONNULL(1, 2) EINA_WARN_UNUSED_RESULT;
-EAPI Eina_Bool              e_connman_service_ethernet_netmask_get(const E_Connman_Element *service, const char **netmask) EINA_ARG_NONNULL(1, 2) EINA_WARN_UNUSED_RESULT;
 
 /* Methods to configure IPv4 service */
 EAPI Eina_Bool              e_connman_service_ipv4_configure_dhcp(E_Connman_Element *service, E_DBus_Method_Return_Cb cb, const void *data) EINA_ARG_NONNULL(1) EINA_WARN_UNUSED_RESULT;

diff --git a/src/lib/connman/e_connman_service.c b/src/lib/connman/e_connman_service.c
index edf036e..ffd1eed 100644 (file)
--- a/src/lib/connman/e_connman_service.c
+++ b/src/lib/connman/e_connman_service.c
@@ -1253,30 +1253,3 @@ e_connman_service_ethernet_mtu_get(const E_Connman_Element *service, unsigned sh
    return e_connman_element_property_dict_get_stringshared
              (service, e_connman_prop_ethernet, e_connman_prop_mtu, NULL, mtu);
 }
-
-/**
- * Get property "Ethernet.Netmask" value.
- *
- * If this property isn't found then @c EINA_FALSE is returned.
- * If @c EINA_FALSE is returned, then this call failed and parameter-returned
- * values shall be considered invalid.
- *
- * The current configured Ethernet netmask.
- *
- * @param service path to get property.
- * @param netmask where to store the property value, must be a pointer
- *        to string (const char **), it will not be allocated or
- *        copied and references will be valid until element changes,
- *        so copy it if you want to use it later.
- *
- * @return @c EINA_TRUE on success, @c EINA_FALSE otherwise.
- */
-Eina_Bool
-e_connman_service_ethernet_netmask_get(const E_Connman_Element *service, const char **netmask)
-{
-   EINA_SAFETY_ON_NULL_RETURN_VAL(service, EINA_FALSE);
-   EINA_SAFETY_ON_NULL_RETURN_VAL(netmask, EINA_FALSE);
-   return e_connman_element_property_dict_get_stringshared
-             (service, e_connman_prop_ethernet, e_connman_prop_netmask, NULL, netmask);
-}
-