gdb/ChangeLog

   1 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
   2
   3         * version.in: Set GDB version number to 8.3.
   4
   5 2019-05-08  Tom Tromey  <tromey@adacore.com>
   6
   7         * utils.c (fputs_maybe_filtered): Reset style after paging, even
   8         when no wrap column is set.
   9
  10 2019-05-04  Tom Tromey  <tom@tromey.com>
  11
  12         * psymtab.c (psymbol_name_matches, match_partial_symbol)
  13         (lookup_partial_symbol, print_partial_symbols)
  14         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
  15         (psymbol_compare): Update.
  16         (add_psymbol_to_bcache): Clear the entire psymbol.
  17         (maintenance_check_psymtabs): Update.
  18         * psympriv.h (struct partial_symbol): Don't derive from
  19         general_symbol_info.
  20         <obj_section, unrelocated_address, address,
  21         set_unrelocated_address>: Update.
  22         <ginfo>: New member.
  23         * dwarf-index-write.c (write_psymbols, debug_names::insert)
  24         (debug_names::write_psymbols): Update.
  25
  26 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
  27
  28         * windows-nat.c [_WIN32_WINNT]: Define _WIN32_WINNT to Windows XP
  29         level, so that various Windows header files expose the necessary
  30         declarations and definitions.
  31
  32         * symfile.c (find_separate_debug_file): Remove colon from the
  33         drive spec of DOS/Windows file names of the target, so that the
  34         file name produced from DEBUGDIR and the target's directory will
  35         be valid on DOS/Windows systems.
  36
  37 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
  38
  39         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
  40         Use current_event.dwThreadId instead of main_thread_id.
  41
  42 2019-04-30  Tom Tromey  <tromey@adacore.com>
  43
  44         PR c++/24470:
  45         * dwarf2read.c (process_structure_scope): Handle case where type
  46         has template parameters but no symbol was created.
  47
  48 2019-04-19  Sergei Trofimovich <siarheit@google.com>
  49
  50         * configure.ac: add --enable-source-highlight switch.
  51         * configure: Regenerate.
  52         * top.c (print_gdb_version): plumb --enable-source-highlight
  53         status to "show configuration".
  54
  55 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
  56
  57         PR symtab/24423:
  58         * source.c (print_source_lines_base): Advance "iter" when a
  59         control character is seen.
  60
  61 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  62
  63         * inferior.h (struct infcall_suspend_state_deleter):
  64         Catch exception in destructor to avoid crash.
  65
  66 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
  67
  68         * utils.c (prompt_for_continue): Don't restore the styling at the
  69         end, as applied_style has the wrong value.  This fixes styling in
  70         long lists of file names that are interrupted by the "Continue?"
  71         prompt.
  72
  73 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
  74
  75         * version.in: Set GDB version number to 8.2.91.DATE-git.
  76
  77 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
  78
  79         GDB 8.2.91 released.
  80
  81 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
  82
  83         * version.in: Set GDB version number to 8.2.91.
  84
  85 2019-03-20  Tom Tromey  <tromey@adacore.com>
  86
  87         PR gdb/24391
  88         * infrun.c (handle_inferior_event): Rename from
  89         handle_inferior_event_1.  Create a scoped_value_mark.
  90         (handle_inferior_event): Remove.
  91
  92 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
  93
  94         * source-cache.c (source_cache::get_source_lines): Re-read
  95         fullname after calling open_source_file.
  96
  97 2019-03-18  Pedro Alves  <palves@redhat.com>
  98             Eli Zaretskii <eliz@gnu.org>
  99
 100         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
 101         m_line and m_start_of_line.
 102
 103 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
 104
 105         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
 106         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
 107         it returns a newline.  This fixes a regression in TU mode, whereby
 108         the next line is output on the same screen line as the user input.
 109
 110 2019-03-18  Pedro Alves  <palves@redhat.com>
 111
 112         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
 113         New globals.
 114         (apply_style): New, factored out from ...
 115         (apply_ansi_escape): ... this.  Handle reverse video mode.
 116         (tui_set_reverse_mode): New function.
 117         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
 118         * tui/tui-winsource.c (tui_show_source_line): Use
 119         tui_set_reverse_mode instead of setting A_STANDOUT.
 120         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
 121         New setter methods.
 122
 123 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
 124
 125         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
 126         Handle tabs.
 127
 128 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
 129
 130         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
 131         tui_refill_source_window instead of tui_refresh_win, to update the
 132         current execution line.  This fixes redisplay of the current line
 133         when stepping through the code with "next" or "step".
 134
 135 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 136
 137         * source-cache.c (source_cache::get_source_lines): Call
 138         find_source_lines to initialize s->nlines.  This fixes vertical
 139         scrolling of TUI source window when the DOWN arrow is pressed.
 140
 141 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 142
 143         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
 144         wclrtoeol in tui_show_source_line".  This reverts changes made in
 145         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
 146
 147 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 148
 149         * NEWS: Combine separate "New targets" sections for 8.3.
 150
 151 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
 152
 153         The MS-Windows port of ncurses fails to switch to a color pair if
 154         one or both of the colors are the implicit default colors.  This
 155         change records the default colors when TUI is initialized, and
 156         then specifies them explicitly when a color pair uses the default
 157         colors.  This allows color styling in TUI mode on MS-Windows.
 158
 159         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 160         ncurses_norm_attr.
 161         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 162         colors in ncurses_norm_attr.
 163         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 164         "none", replace it with the default color recorded in
 165         ncurses_norm_attr.
 166
 167 2019-03-14  Tom Tromey  <tromey@adacore.com>
 168
 169         * source-cache.h (class source_cache) <get_source_lines>: Return
 170         std::string.
 171         * source-cache.c (source_cache::extract_lines): Handle case where
 172         first_pos==npos.  Return std::string.
 173         (source_cache::get_source_lines): Update.
 174
 175 2019-03-14  Tom Tromey  <tromey@adacore.com>
 176
 177         * NEWS: Add item for "style sources" commands.
 178         * source-cache.c (source_cache::get_source_lines): Check
 179         source_styling.
 180         * cli/cli-style.c (source_styling): New global.
 181         (_initialize_cli_style): Add "style sources" commands.
 182         (show_style_sources): New function.
 183         * cli/cli-style.h (source_styling): Declare.
 184
 185 2019-03-14  Pedro Alves  <palves@redhat.com>
 186             Tom Tromey  <tromey@adacore.com>
 187
 188         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 189         * tui/tui-winsource.c (tui_refill_source_window): New function,
 190         from...
 191         (tui_horizontal_source_scroll): ... here.  Move some logic.
 192         * cli/cli-style.c (set_style_enabled): Notify new observable.
 193         * tui/tui-hooks.c (tui_redisplay_source): New function.
 194         (tui_attach_detach_observers): Attach or detach
 195         tui_redisplay_source.
 196         * observable.h (source_styling_changed): New observable.
 197         * observable.c: Define source_styling_changed observable.
 198
 199 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 200
 201         PR/24325
 202         * source-cache.c: #undef open and close, to avoid unresolved
 203         externals during linking.
 204
 205 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 206
 207         Support styling on native MS-Windows console
 208
 209         PR/24315
 210         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 211         on MS-Windows if $TERM is not defined.
 212
 213         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 214
 215         * posix-hdep.c (gdb_console_fputs):
 216         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 217         functions.
 218         * ui-file.h (gdb_console_fputs): Add prototype.
 219
 220         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 221         back to fputs only if the former returns zero.
 222
 223 2019-03-07  Brian Vandenberg  <phantall@gmail.com>
 224             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 225
 226         PR gdb/8527
 227         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
 228         set_sigint_trap, clear_sigint_trap.
 229
 230 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 231
 232         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
 233         for-loop range, to avoid compiler warnings.
 234
 235         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
 236         avoid compiler warnings about unused variables.
 237
 238 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 239
 240         * NEWS: Mention end of support for native debugging on MS-Windows
 241         before XP.
 242
 243 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 244
 245         PR gdb/24292
 246         * common/netstuff.c:
 247         * gdbserver/gdbreplay.c
 248         * gdbserver/remote-utils.c:
 249         * ser-tcp.c:
 250         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
 251         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
 252         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
 253         'getaddrinfo' and 'freeaddrinfo' were not available before
 254         Windows XP, and mingw.org's MinGW headers by default define
 255         _WIN32_WINNT to 0x500.
 256
 257 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
 258
 259         * NEWS: Note minimum Python version.
 260
 261 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 262
 263         * version.in: Set GDB version number to 8.2.90.DATE-git.
 264
 265 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 266
 267         GDB 8.2.90 released.
 268
 269 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 270
 271         * version.in: Set GDB version number to 8.2.90.
 272
 273 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 274
 275         * NEWS: Change "Changes since GDB 8.2" into "Changes in GDB 8.3".
 276
 277 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 278
 279         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
 280         * version.in: Bump version to 8.2.90.DATE-git.
 281
 282 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
 283
 284         * aix-thread.c (ptid_cmp): Remove unused variable.
 285         (get_signaled_thread): Likewise.
 286         (store_regs_user_thread): Likewise.
 287         (store_regs_kernel_thread): Likewise.
 288         (fetch_regs_kernel_thread): Remove shadowed variable.
 289
 290 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
 291
 292         * features/riscv/32bit-cpu.xml: Add register numbers.
 293         * features/riscv/32bit-fpu.c: Regenerate.
 294         * features/riscv/32bit-fpu.xml: Add register numbers.
 295         * features/riscv/64bit-cpu.xml: Add register numbers.
 296         * features/riscv/64bit-fpu.c: Regenerate.
 297         * features/riscv/64bit-fpu.xml: Add register numbers.
 298
 299 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
 300
 301         * NEWS: Mention two argument form of gdb.Value constructor.
 302         * python/py-value.c (convert_buffer_and_type_to_value): New
 303         function.
 304         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
 305         Add support for handling an optional second argument.  Call
 306         convert_buffer_and_type_to_value as appropriate.
 307         * python/python-internal.h (Py_buffer_deleter): New struct.
 308         (Py_buffer_up): New typedef.
 309
 310 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
 311
 312         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
 313         instead of releasing ownership.
 314
 315 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
 316
 317         * dwarf2read.c (open_and_init_dwp_file): Call
 318         elf_numsections instead of bfd_count_sections to initialize
 319         dwp_file->num_sections.
 320
 321 2019-02-25  Tom Tromey  <tromey@adacore.com>
 322
 323         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
 324
 325 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 326
 327         * gcore.in: Add '--readnever' option when invoking GDB.
 328
 329 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 330
 331         * MAINTAINERS: Update my email address.
 332
 333 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 334
 335         * build-id.c (build_id_to_debug_bfd_1): New function.
 336         (build_id_to_debug_bfd): Look for separate debug file in
 337         sysroot.
 338
 339 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 340
 341         * gdbarch.sh: Update the copyright year range that is placed into
 342         generated files.
 343
 344 2019-02-22  Keith Seitz  <keiths@redhat.com>
 345
 346         PR symtab/23853
 347         * linespec.c (create_sals_line_offset): Search for the default
 348         symtab's filename instead of its fullname.
 349
 350 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 351
 352         * NEWS: Update style defaults.
 353
 354 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 355
 356         * main.c (captured_main_1): Disable styling in batch mode.
 357
 358 2019-02-20  Tom Tromey  <tom@tromey.com>
 359
 360         * symtab.c (symtab_symbol_info): Fix typos.
 361
 362 2019-02-20  Tom Tromey  <tromey@adacore.com>
 363
 364         * findcmd.c (_initialize_mem_search): Use upper case for
 365         metasyntactic variables.
 366
 367 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
 368
 369         * aarch64-tdep.c (aarch64_add_reggroups): New function.
 370         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
 371
 372 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
 373
 374         * top.h (source_file_name): Change to std::string.
 375         * top.c (source_file_name): Likewise.
 376         (command_line_input): Adjust.
 377         * cli/cli-script.c (script_from_file): Adjust.
 378
 379 2019-02-19  Tom Tromey  <tromey@adacore.com>
 380
 381         * ravenscar-thread.c
 382         (ravenscar_thread_target::update_thread_list): Don't call
 383         ada_build_task_list.
 384         * ada-lang.h (ada_build_task_list): Don't declare.
 385         * ada-tasks.c (struct ada_tasks_inferior_data)
 386         <task_list_valid_p>: Now bool.
 387         (read_known_tasks, ada_task_list_changed)
 388         (ada_tasks_invalidate_inferior_data): Update.
 389         (read_known_tasks_array): Return bool.
 390         (read_known_tasks_list): Likewise.
 391         (read_known_tasks): Return void.
 392         (ada_build_task_list): Now static.
 393
 394 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 395
 396         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
 397         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
 398
 399 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 400
 401         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
 402         variant for ada_tasks_pspace_data_handle and
 403         ada_tasks_inferior_data_handle.
 404         (ada_tasks_pspace_data_cleanup): New function.
 405         (ada_tasks_inferior_data_cleanup): New function.
 406
 407 2019-02-17  Tom Tromey  <tom@tromey.com>
 408
 409         * macrotab.h (macro_source_fullname): Return a std::string.
 410         * macrotab.c (macro_include, check_for_redefinition)
 411         (macro_undef, macro_lookup_definition, foreach_macro)
 412         (foreach_macro_in_scope): Update.
 413         (macro_source_fullname): Return a std::string.
 414         * macrocmd.c (show_pp_source_pos): Update.
 415
 416 2019-02-17  Tom Tromey  <tom@tromey.com>
 417
 418         * macrocmd.c (show_pp_source_pos): Style the file names.
 419
 420 2019-02-17  Tom Tromey  <tom@tromey.com>
 421
 422         PR tui/24197:
 423         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
 424
 425 2019-02-17  Tom Tromey  <tom@tromey.com>
 426
 427         * ada-lang.c (user_select_syms): Use filtered printing.
 428         * utils.c (wrap_style): New global.
 429         (desired_style): Remove.
 430         (emit_style_escape): Add stream parameter.
 431         (set_output_style, reset_terminal_style, prompt_for_continue):
 432         Update.
 433         (flush_wrap_buffer): Only flush gdb_stdout.
 434         (wrap_here): Set wrap_style.
 435         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
 436         treat escape sequences as a character.  Change when wrap buffer is
 437         flushed.
 438         (fputs_styled): Do not set the output style when the default is
 439         requested.
 440         * ui-style.h (struct ui_file_style) <is_default>: New method.
 441         * source.c (print_source_lines_base): Emit escape sequences in one
 442         piece.
 443
 444 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 445
 446         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
 447         integers and enumeration types.
 448
 449 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 450
 451         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
 452         instead of lookup_symbol_in_language
 453         (do_exact_match): New function.
 454         (ada_get_symbol_name_matcher): Return do_exact_match when
 455         doing a verbatim match.
 456
 457 2019-02-15  Tom Tromey  <tromey@adacore.com>
 458
 459         * ravenscar-thread.c (ravenscar_thread_target::resume)
 460         (ravenscar_thread_target::wait): Special case wildcard requests.
 461
 462 2019-02-15  Tom Tromey  <tromey@adacore.com>
 463
 464         * ravenscar-thread.c (base_ptid): Remove.
 465         (struct ravenscar_thread_target) <close>: New method.
 466         <m_base_ptid>: New member.
 467         <update_inferior_ptid, active_task, task_is_currently_active,
 468         runtime_initialized>: Declare methods.
 469         <ravenscar_thread_target>: Add constructor.
 470         (ravenscar_thread_target::task_is_currently_active)
 471         (ravenscar_thread_target::update_inferior_ptid)
 472         (ravenscar_runtime_initialized): Rename.  Now methods.
 473         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
 474         (ravenscar_thread_target::update_thread_list): Update.
 475         (ravenscar_thread_target::active_task): Now method.
 476         (ravenscar_thread_target::store_registers)
 477         (ravenscar_thread_target::prepare_to_store)
 478         (ravenscar_thread_target::prepare_to_store)
 479         (ravenscar_thread_target::mourn_inferior): Update.
 480         (ravenscar_inferior_created): Use "new" to create target.
 481         (ravenscar_thread_target::get_ada_task_ptid): Update.
 482         (_initialize_ravenscar): Don't initialize base_ptid.
 483         (ravenscar_ops): Remove global.
 484
 485 2019-02-15  Tom Tromey  <tromey@adacore.com>
 486
 487         * target.h (push_target): Declare new overload.
 488         * target.c (push_target): New overload, taking an rvalue reference.
 489         * remote.c (remote_target::open_1): Use push_target overload.
 490         * corelow.c (core_target_open): Use push_target overload.
 491
 492 2019-02-15  Tom Tromey  <tromey@adacore.com>
 493
 494         * ravenscar-thread.c (is_ravenscar_task)
 495         (ravenscar_task_is_currently_active): Return bool.
 496         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
 497         (_initialize_ravenscar): Remove "(void)".
 498         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
 499         Return bool.
 500
 501 2019-02-15  Tom Tromey  <tromey@adacore.com>
 502
 503         * ravenscar-thread.c (ravenscar_runtime_initializer)
 504         (has_ravenscar_runtime, get_running_thread_id)
 505         (ravenscar_thread_target::resume): Fix indentation.
 506
 507 2019-02-15  Tom Tromey  <tromey@adacore.com>
 508
 509         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
 510         from ravenscar_arch_ops.
 511         (sparc_ravenscar_ops::fetch_registers)
 512         (sparc_ravenscar_ops::store_registers): Now methods.
 513         (sparc_ravenscar_prepare_to_store): Remove.
 514         (sparc_ravenscar_ops): Redefine.
 515         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
 516         methods and destructor.  Remove members.
 517         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
 518         (ravenscar_thread_target::store_registers)
 519         (ravenscar_thread_target::prepare_to_store): Update.
 520         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
 521         Remove.
 522         (struct ppc_ravenscar_powerpc_ops): Derive from
 523         ravenscar_arch_ops.
 524         (ppc_ravenscar_powerpc_ops::fetch_registers)
 525         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
 526         (ppc_ravenscar_powerpc_ops): Redefine.
 527         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
 528         (ppc_ravenscar_e500_ops::fetch_registers)
 529         (ppc_ravenscar_e500_ops::store_registers): Now methods.
 530         (ppc_ravenscar_e500_ops): Redefine.
 531         * aarch64-ravenscar-thread.c
 532         (aarch64_ravenscar_generic_prepare_to_store): Remove.
 533         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
 534         (aarch64_ravenscar_fetch_registers)
 535         (aarch64_ravenscar_store_registers): Now methods.
 536         (aarch64_ravenscar_ops): Redefine.
 537
 538 2019-02-15  Tom Tromey  <tromey@adacore.com>
 539
 540         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
 541         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 542         (ravenscar_thread_target::stopped_by_watchpoint)
 543         (ravenscar_thread_target::stopped_data_address)
 544         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
 545
 546 2019-02-15  Tom Tromey  <tromey@adacore.com>
 547
 548         * ravenscar-thread.c: Fix some typos.
 549
 550 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 551             Tom Tromey  <tromey@adacore.com>
 552
 553         * ada-lang.c (ada_exception_sal): Change addr_string to a
 554         std::string.
 555         (create_ada_exception_catchpoint): Update.
 556
 557 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 558             Tom Tromey  <tromey@adacore.com>
 559
 560         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 561         (bp_location_ops): Remove.
 562         (base_breakpoint_allocate_location): Update.
 563         (free_bp_location): Update.
 564         * ada-lang.c (class ada_catchpoint_location)
 565         <ada_catchpoint_location>: Remove ops parameter.
 566         (ada_catchpoint_location_dtor): Remove.
 567         (ada_catchpoint_location_ops): Remove.
 568         (allocate_location_exception): Update.
 569         * breakpoint.h (struct bp_location_ops): Remove.
 570         (class bp_location) <bp_location>: Remove bp_location_ops
 571         parameter.
 572         <~bp_location>: Add destructor.
 573         <ops>: Remove.
 574
 575 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 576             Pedro Alves  <palves@redhat.com>
 577
 578         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 579         'PATH_MAX'.
 580
 581 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 582             Samuel Thibault  <samuel.thibault@gnu.org>
 583             Thomas Schwinge  <thomas@codesourcery.com>
 584
 585         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 586         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 587
 588 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 589
 590         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 591         (check_empty): Use "const char *".
 592
 593         * gnu-nat.c (gnu_nat_target::detach): Instead of
 594         'detach_inferior (pid)' call
 595         'detach_inferior (find_inferior_pid (pid))'.
 596
 597         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 598         'nat/fork-inferior.o'.
 599         * gnu-nat.c: #include "nat/fork-inferior.h".
 600
 601         * gnu-nat.c (gnu_nat_target::detach): Instead of
 602         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 603         * gnu-nat.h: #include "inf-child.h".
 604         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 605         'i386_gnu_nat_target::fetch_registers'.
 606         (gnu_store_registers): Rename/move to
 607         'i386_gnu_nat_target::store_registers'.
 608
 609         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 610         * gnu-nat.h (mach_thread_info): New function.
 611         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 612
 613         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 614
 615 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 616
 617         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 618
 619 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 620
 621         * windows-nat.c (windows_add_thread): Add new parameter
 622         "main_thread_p" with default value set to false.  Update
 623         function documentation as well as all callers.
 624         (windows_delete_thread): Likewise.
 625         (fake_create_process): Update call to windows_add_thread.
 626         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 627         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 628         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 629         call to windows_delete_thread.
 630
 631 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 632
 633         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 634
 635 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 636
 637         * symfile.c (find_separate_debug_file): Use canonical path of
 638         sysroot with child_path instead of gdb_sysroot if it is valid.
 639
 640 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 641
 642         * symfile.c (find_separate_debug_file): Use child_path to
 643         determine if an object file is under a sysroot.
 644
 645 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 646
 647         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 648         unittests/child-path-selftests.c.
 649         * common/pathstuff.c (child_path): New function.
 650         * common/pathstuff.h (child_path): New prototype.
 651         * unittests/child-path-selftests.c: New file.
 652
 653 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 654
 655         * symfile.c (find_separate_debug_file): Look for separate debug
 656         files in debug directories under the sysroot.
 657
 658 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 659
 660         * symtab.h (struct minimal_symbol data_p): New const method.
 661         (struct minimal_symbol text_p): Likewise.
 662         * symtab.c (output_source_filename): Use file name style
 663         to print file name.
 664         (print_symbol_info): Likewise.
 665         (print_msymbol_info): Use address style to print addresses.
 666         Use function name style to print executable text symbols.
 667         (expand_symtab_containing_pc): Use data_p.
 668         (find_pc_sect_compunit_symtab): Likewise.
 669
 670 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 671
 672         * breakpoint.c (describe_other_breakpoints): Use address style
 673         to print addresses.
 674         (say_where): Likewise.
 675
 676 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 677
 678         * ada-typeprint.c (print_func_type): Print function name
 679         style to print function name.
 680         * c-typeprint.c (c_print_type_1): Likewise.
 681
 682 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 683
 684         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 685         for execve.
 686
 687 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 688
 689         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 690         type_stack.
 691
 692 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 693
 694         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 695         TYPE_CODE_REF types.
 696
 697 2019-02-08  Jim Wilson  <jimw@sifive.com>
 698
 699         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 700         (riscv_linux_fregset): New.
 701         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 702
 703 2019-02-07  Tom Tromey  <tom@tromey.com>
 704
 705         * thread.c (thread_cancel_execution_command): Update.
 706         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 707         methods.
 708         (struct thread_fsm_ops): Remove.
 709         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 710         (thread_fsm_should_stop, thread_fsm_return_value)
 711         (thread_fsm_set_finished, thread_fsm_finished_p)
 712         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 713         Don't declare.
 714         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 715         * infrun.c (clear_proceed_status_thread)
 716         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 717         (print_stop_event): Update.
 718         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 719         Add constructor.
 720         (step_command_fsm_ops): Remove.
 721         (new_step_command_fsm): Remove.
 722         (step_1): Update.
 723         (step_command_fsm::should_stop): Rename from
 724         step_command_fsm_should_stop.
 725         (step_command_fsm::clean_up): Rename from
 726         step_command_fsm_clean_up.
 727         (step_command_fsm::do_async_reply_reason): Rename from
 728         step_command_fsm_async_reply_reason.
 729         (struct until_next_fsm): Inherit from thread_fsm.  Add
 730         constructor.
 731         (until_next_fsm_ops): Remove.
 732         (new_until_next_fsm): Remove.
 733         (until_next_fsm::should_stop): Rename from
 734         until_next_fsm_should_stop.
 735         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 736         (until_next_fsm::do_async_reply_reason): Rename from
 737         until_next_fsm_async_reply_reason.
 738         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 739         constructor.  Change type of breakpoint.
 740         (finish_command_fsm_ops): Remove.
 741         (new_finish_command_fsm): Remove.
 742         (finish_command_fsm::should_stop): Rename from
 743         finish_command_fsm_should_stop.
 744         (finish_command_fsm::clean_up): Rename from
 745         finish_command_fsm_clean_up.
 746         (finish_command_fsm::return_value): Rename from
 747         finish_command_fsm_return_value.
 748         (finish_command_fsm::do_async_reply_reason): Rename from
 749         finish_command_fsm_async_reply_reason.
 750         (finish_command): Update.
 751         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 752         Add constructor.
 753         (call_thread_fsm_ops): Remove.
 754         (call_thread_fsm::call_thread_fsm): Rename from
 755         new_call_thread_fsm.
 756         (call_thread_fsm::should_stop): Rename from
 757         call_thread_fsm_should_stop.
 758         (call_thread_fsm::should_notify_stop): Rename from
 759         call_thread_fsm_should_notify_stop.
 760         (run_inferior_call, call_function_by_hand_dummy): Update.
 761         * cli/cli-interp.c (should_print_stop_to_console): Update.
 762         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 763         Add constructor.  Change type of location_breakpoint,
 764         caller_breakpoint.
 765         (until_break_fsm_ops): Remove.
 766         (new_until_break_fsm): Remove.
 767         (until_break_fsm::should_stop): Rename from
 768         until_break_fsm_should_stop.
 769         (until_break_fsm::clean_up): Rename from
 770         until_break_fsm_clean_up.
 771         (until_break_fsm::do_async_reply_reason): Rename from
 772         until_break_fsm_async_reply_reason.
 773         (until_break_command): Update.
 774         * thread-fsm.c: Remove.
 775         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 776
 777 2019-02-07  Tom Tromey  <tom@tromey.com>
 778
 779         * yy-remap.h: Add include guard.
 780         * xtensa-tdep.h: Add include guard.
 781         * xcoffread.h: Rename include guard.
 782         * varobj-iter.h: Add include guard.
 783         * tui/tui.h: Rename include guard.
 784         * tui/tui-winsource.h: Rename include guard.
 785         * tui/tui-wingeneral.h: Rename include guard.
 786         * tui/tui-windata.h: Rename include guard.
 787         * tui/tui-win.h: Rename include guard.
 788         * tui/tui-stack.h: Rename include guard.
 789         * tui/tui-source.h: Rename include guard.
 790         * tui/tui-regs.h: Rename include guard.
 791         * tui/tui-out.h: Rename include guard.
 792         * tui/tui-layout.h: Rename include guard.
 793         * tui/tui-io.h: Rename include guard.
 794         * tui/tui-hooks.h: Rename include guard.
 795         * tui/tui-file.h: Rename include guard.
 796         * tui/tui-disasm.h: Rename include guard.
 797         * tui/tui-data.h: Rename include guard.
 798         * tui/tui-command.h: Rename include guard.
 799         * tic6x-tdep.h: Add include guard.
 800         * target/waitstatus.h: Rename include guard.
 801         * target/wait.h: Rename include guard.
 802         * target/target.h: Rename include guard.
 803         * target/resume.h: Rename include guard.
 804         * target-float.h: Rename include guard.
 805         * stabsread.h: Add include guard.
 806         * rs6000-tdep.h: Add include guard.
 807         * riscv-fbsd-tdep.h: Add include guard.
 808         * regformats/regdef.h: Rename include guard.
 809         * record.h: Rename include guard.
 810         * python/python.h: Rename include guard.
 811         * python/python-internal.h: Rename include guard.
 812         * python/py-stopevent.h: Rename include guard.
 813         * python/py-ref.h: Rename include guard.
 814         * python/py-record.h: Rename include guard.
 815         * python/py-record-full.h: Rename include guard.
 816         * python/py-record-btrace.h: Rename include guard.
 817         * python/py-instruction.h: Rename include guard.
 818         * python/py-events.h: Rename include guard.
 819         * python/py-event.h: Rename include guard.
 820         * procfs.h: Add include guard.
 821         * proc-utils.h: Add include guard.
 822         * p-lang.h: Add include guard.
 823         * or1k-tdep.h: Rename include guard.
 824         * observable.h: Rename include guard.
 825         * nto-tdep.h: Rename include guard.
 826         * nat/x86-linux.h: Rename include guard.
 827         * nat/x86-linux-dregs.h: Rename include guard.
 828         * nat/x86-gcc-cpuid.h: Add include guard.
 829         * nat/x86-dregs.h: Rename include guard.
 830         * nat/x86-cpuid.h: Rename include guard.
 831         * nat/ppc-linux.h: Rename include guard.
 832         * nat/mips-linux-watch.h: Rename include guard.
 833         * nat/linux-waitpid.h: Rename include guard.
 834         * nat/linux-ptrace.h: Rename include guard.
 835         * nat/linux-procfs.h: Rename include guard.
 836         * nat/linux-osdata.h: Rename include guard.
 837         * nat/linux-nat.h: Rename include guard.
 838         * nat/linux-namespaces.h: Rename include guard.
 839         * nat/linux-btrace.h: Rename include guard.
 840         * nat/glibc_thread_db.h: Rename include guard.
 841         * nat/gdb_thread_db.h: Rename include guard.
 842         * nat/gdb_ptrace.h: Rename include guard.
 843         * nat/fork-inferior.h: Rename include guard.
 844         * nat/amd64-linux-siginfo.h: Rename include guard.
 845         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 846         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 847         * nat/aarch64-linux.h: Rename include guard.
 848         * nat/aarch64-linux-hw-point.h: Rename include guard.
 849         * mn10300-tdep.h: Add include guard.
 850         * mips-linux-tdep.h: Add include guard.
 851         * mi/mi-parse.h: Rename include guard.
 852         * mi/mi-out.h: Rename include guard.
 853         * mi/mi-main.h: Rename include guard.
 854         * mi/mi-interp.h: Rename include guard.
 855         * mi/mi-getopt.h: Rename include guard.
 856         * mi/mi-console.h: Rename include guard.
 857         * mi/mi-common.h: Rename include guard.
 858         * mi/mi-cmds.h: Rename include guard.
 859         * mi/mi-cmd-break.h: Rename include guard.
 860         * m2-lang.h: Add include guard.
 861         * location.h: Rename include guard.
 862         * linux-record.h: Rename include guard.
 863         * linux-nat.h: Add include guard.
 864         * linux-fork.h: Add include guard.
 865         * i386-darwin-tdep.h: Rename include guard.
 866         * hppa-linux-offsets.h: Add include guard.
 867         * guile/guile.h: Rename include guard.
 868         * guile/guile-internal.h: Rename include guard.
 869         * gnu-nat.h: Rename include guard.
 870         * gdb-stabs.h: Rename include guard.
 871         * frv-tdep.h: Add include guard.
 872         * f-lang.h: Add include guard.
 873         * event-loop.h: Add include guard.
 874         * darwin-nat.h: Rename include guard.
 875         * cp-abi.h: Rename include guard.
 876         * config/sparc/nm-sol2.h: Rename include guard.
 877         * config/nm-nto.h: Rename include guard.
 878         * config/nm-linux.h: Add include guard.
 879         * config/i386/nm-i386gnu.h: Rename include guard.
 880         * config/djgpp/nl_types.h: Rename include guard.
 881         * config/djgpp/langinfo.h: Rename include guard.
 882         * compile/gcc-cp-plugin.h: Add include guard.
 883         * compile/gcc-c-plugin.h: Add include guard.
 884         * compile/compile.h: Rename include guard.
 885         * compile/compile-object-run.h: Rename include guard.
 886         * compile/compile-object-load.h: Rename include guard.
 887         * compile/compile-internal.h: Rename include guard.
 888         * compile/compile-cplus.h: Rename include guard.
 889         * compile/compile-c.h: Rename include guard.
 890         * common/xml-utils.h: Rename include guard.
 891         * common/x86-xstate.h: Rename include guard.
 892         * common/version.h: Rename include guard.
 893         * common/vec.h: Rename include guard.
 894         * common/tdesc.h: Rename include guard.
 895         * common/selftest.h: Rename include guard.
 896         * common/scoped_restore.h: Rename include guard.
 897         * common/scoped_mmap.h: Rename include guard.
 898         * common/scoped_fd.h: Rename include guard.
 899         * common/safe-iterator.h: Rename include guard.
 900         * common/run-time-clock.h: Rename include guard.
 901         * common/refcounted-object.h: Rename include guard.
 902         * common/queue.h: Rename include guard.
 903         * common/ptid.h: Rename include guard.
 904         * common/print-utils.h: Rename include guard.
 905         * common/preprocessor.h: Rename include guard.
 906         * common/pathstuff.h: Rename include guard.
 907         * common/observable.h: Rename include guard.
 908         * common/netstuff.h: Rename include guard.
 909         * common/job-control.h: Rename include guard.
 910         * common/host-defs.h: Rename include guard.
 911         * common/gdb_wait.h: Rename include guard.
 912         * common/gdb_vecs.h: Rename include guard.
 913         * common/gdb_unlinker.h: Rename include guard.
 914         * common/gdb_unique_ptr.h: Rename include guard.
 915         * common/gdb_tilde_expand.h: Rename include guard.
 916         * common/gdb_sys_time.h: Rename include guard.
 917         * common/gdb_string_view.h: Rename include guard.
 918         * common/gdb_splay_tree.h: Rename include guard.
 919         * common/gdb_setjmp.h: Rename include guard.
 920         * common/gdb_ref_ptr.h: Rename include guard.
 921         * common/gdb_optional.h: Rename include guard.
 922         * common/gdb_locale.h: Rename include guard.
 923         * common/gdb_assert.h: Rename include guard.
 924         * common/filtered-iterator.h: Rename include guard.
 925         * common/filestuff.h: Rename include guard.
 926         * common/fileio.h: Rename include guard.
 927         * common/environ.h: Rename include guard.
 928         * common/common-utils.h: Rename include guard.
 929         * common/common-types.h: Rename include guard.
 930         * common/common-regcache.h: Rename include guard.
 931         * common/common-inferior.h: Rename include guard.
 932         * common/common-gdbthread.h: Rename include guard.
 933         * common/common-exceptions.h: Rename include guard.
 934         * common/common-defs.h: Rename include guard.
 935         * common/common-debug.h: Rename include guard.
 936         * common/cleanups.h: Rename include guard.
 937         * common/buffer.h: Rename include guard.
 938         * common/btrace-common.h: Rename include guard.
 939         * common/break-common.h: Rename include guard.
 940         * cli/cli-utils.h: Rename include guard.
 941         * cli/cli-style.h: Rename include guard.
 942         * cli/cli-setshow.h: Rename include guard.
 943         * cli/cli-script.h: Rename include guard.
 944         * cli/cli-interp.h: Rename include guard.
 945         * cli/cli-decode.h: Rename include guard.
 946         * cli/cli-cmds.h: Rename include guard.
 947         * charset-list.h: Add include guard.
 948         * buildsym-legacy.h: Rename include guard.
 949         * bfin-tdep.h: Add include guard.
 950         * ax.h: Rename include guard.
 951         * arm-linux-tdep.h: Add include guard.
 952         * arm-fbsd-tdep.h: Add include guard.
 953         * arch/xtensa.h: Rename include guard.
 954         * arch/tic6x.h: Add include guard.
 955         * arch/i386.h: Add include guard.
 956         * arch/arm.h: Rename include guard.
 957         * arch/arm-linux.h: Rename include guard.
 958         * arch/arm-get-next-pcs.h: Rename include guard.
 959         * arch/amd64.h: Add include guard.
 960         * arch/aarch64-insn.h: Rename include guard.
 961         * arch-utils.h: Rename include guard.
 962         * annotate.h: Add include guard.
 963         * amd64-darwin-tdep.h: Rename include guard.
 964         * aarch64-linux-tdep.h: Add include guard.
 965         * aarch64-fbsd-tdep.h: Add include guard.
 966         * aarch32-linux-nat.h: Add include guard.
 967
 968 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 969
 970         * macrotab.c (macro_define_internal): New function that
 971         factorizes macro_define_object_internal and macro_define_function
 972         code.
 973         (macro_define_object_internal): Use macro_define_internal.
 974         (macro_define_function): Likewise.
 975
 976 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 977
 978         * macrocmd.c (extract_identifier): Return
 979         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 980         callers.
 981
 982 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 983
 984         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 985
 986 2019-02-05  Tom Tromey  <tom@tromey.com>
 987
 988         * target.c (target_stack::unpush): Move assertion earlier.
 989
 990 2019-01-30  Tom Tromey  <tom@tromey.com>
 991
 992         PR python/23615:
 993         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 994         (gdbpy_parse_and_eval): Likewise.
 995         * python/python-internal.h (gdbpy_allow_threads): New class.
 996
 997 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 998
 999         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
1000         (aarch64_fbsd_fpregmap): Move earlier.
1001         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
1002         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1003         instead of individual calls to trad_frame_set_reg_addr.
1004         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
1005         earlier.
1006         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
1007         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1008         instead of individual calls to trad_frame_set_reg_addr.
1009
1010 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
1011
1012         * CONTRIBUTE: Replace contribution list with wiki link.
1013
1014 2019-01-25  Tom Tromey  <tom@tromey.com>
1015
1016         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
1017
1018 2019-01-25  Tom Tromey  <tom@tromey.com>
1019
1020         * xtensa-linux-nat.c: Fix common/ includes.
1021         * xml-support.h: Fix common/ includes.
1022         * xml-support.c: Fix common/ includes.
1023         * x86-linux-nat.c: Fix common/ includes.
1024         * windows-nat.c: Fix common/ includes.
1025         * varobj.h: Fix common/ includes.
1026         * varobj.c: Fix common/ includes.
1027         * value.c: Fix common/ includes.
1028         * valops.c: Fix common/ includes.
1029         * utils.c: Fix common/ includes.
1030         * unittests/xml-utils-selftests.c: Fix common/ includes.
1031         * unittests/utils-selftests.c: Fix common/ includes.
1032         * unittests/unpack-selftests.c: Fix common/ includes.
1033         * unittests/tracepoint-selftests.c: Fix common/ includes.
1034         * unittests/style-selftests.c: Fix common/ includes.
1035         * unittests/string_view-selftests.c: Fix common/ includes.
1036         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1037         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1038         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1039         * unittests/rsp-low-selftests.c: Fix common/ includes.
1040         * unittests/parse-connection-spec-selftests.c: Fix common/
1041         includes.
1042         * unittests/optional-selftests.c: Fix common/ includes.
1043         * unittests/offset-type-selftests.c: Fix common/ includes.
1044         * unittests/observable-selftests.c: Fix common/ includes.
1045         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1046         * unittests/memrange-selftests.c: Fix common/ includes.
1047         * unittests/memory-map-selftests.c: Fix common/ includes.
1048         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1049         * unittests/function-view-selftests.c: Fix common/ includes.
1050         * unittests/environ-selftests.c: Fix common/ includes.
1051         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1052         * unittests/common-utils-selftests.c: Fix common/ includes.
1053         * unittests/cli-utils-selftests.c: Fix common/ includes.
1054         * unittests/array-view-selftests.c: Fix common/ includes.
1055         * ui-file.c: Fix common/ includes.
1056         * tui/tui-io.c: Fix common/ includes.
1057         * tracepoint.h: Fix common/ includes.
1058         * tracepoint.c: Fix common/ includes.
1059         * tracefile-tfile.c: Fix common/ includes.
1060         * top.h: Fix common/ includes.
1061         * top.c: Fix common/ includes.
1062         * thread.c: Fix common/ includes.
1063         * target/waitstatus.h: Fix common/ includes.
1064         * target/waitstatus.c: Fix common/ includes.
1065         * target.h: Fix common/ includes.
1066         * target.c: Fix common/ includes.
1067         * target-memory.c: Fix common/ includes.
1068         * target-descriptions.c: Fix common/ includes.
1069         * symtab.h: Fix common/ includes.
1070         * symfile.c: Fix common/ includes.
1071         * stap-probe.c: Fix common/ includes.
1072         * spu-linux-nat.c: Fix common/ includes.
1073         * sparc-nat.c: Fix common/ includes.
1074         * source.c: Fix common/ includes.
1075         * solib.c: Fix common/ includes.
1076         * solib-target.c: Fix common/ includes.
1077         * ser-unix.c: Fix common/ includes.
1078         * ser-tcp.c: Fix common/ includes.
1079         * ser-pipe.c: Fix common/ includes.
1080         * ser-base.c: Fix common/ includes.
1081         * selftest-arch.c: Fix common/ includes.
1082         * s12z-tdep.c: Fix common/ includes.
1083         * rust-exp.y: Fix common/ includes.
1084         * rs6000-aix-tdep.c: Fix common/ includes.
1085         * riscv-tdep.c: Fix common/ includes.
1086         * remote.c: Fix common/ includes.
1087         * remote-notif.h: Fix common/ includes.
1088         * remote-fileio.h: Fix common/ includes.
1089         * remote-fileio.c: Fix common/ includes.
1090         * regcache.h: Fix common/ includes.
1091         * regcache.c: Fix common/ includes.
1092         * record-btrace.c: Fix common/ includes.
1093         * python/python.c: Fix common/ includes.
1094         * python/py-type.c: Fix common/ includes.
1095         * python/py-inferior.c: Fix common/ includes.
1096         * progspace.h: Fix common/ includes.
1097         * producer.c: Fix common/ includes.
1098         * procfs.c: Fix common/ includes.
1099         * proc-api.c: Fix common/ includes.
1100         * printcmd.c: Fix common/ includes.
1101         * ppc-linux-nat.c: Fix common/ includes.
1102         * parser-defs.h: Fix common/ includes.
1103         * osdata.c: Fix common/ includes.
1104         * obsd-nat.c: Fix common/ includes.
1105         * nat/x86-linux.c: Fix common/ includes.
1106         * nat/x86-linux-dregs.c: Fix common/ includes.
1107         * nat/x86-dregs.h: Fix common/ includes.
1108         * nat/x86-dregs.c: Fix common/ includes.
1109         * nat/ppc-linux.c: Fix common/ includes.
1110         * nat/mips-linux-watch.h: Fix common/ includes.
1111         * nat/mips-linux-watch.c: Fix common/ includes.
1112         * nat/linux-waitpid.c: Fix common/ includes.
1113         * nat/linux-ptrace.h: Fix common/ includes.
1114         * nat/linux-ptrace.c: Fix common/ includes.
1115         * nat/linux-procfs.c: Fix common/ includes.
1116         * nat/linux-personality.c: Fix common/ includes.
1117         * nat/linux-osdata.c: Fix common/ includes.
1118         * nat/linux-namespaces.c: Fix common/ includes.
1119         * nat/linux-btrace.h: Fix common/ includes.
1120         * nat/linux-btrace.c: Fix common/ includes.
1121         * nat/fork-inferior.c: Fix common/ includes.
1122         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1123         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1124         * nat/aarch64-linux.c: Fix common/ includes.
1125         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1126         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1127         * namespace.h: Fix common/ includes.
1128         * mips-linux-tdep.c: Fix common/ includes.
1129         * minsyms.c: Fix common/ includes.
1130         * mi/mi-parse.h: Fix common/ includes.
1131         * mi/mi-main.c: Fix common/ includes.
1132         * mi/mi-cmd-env.c: Fix common/ includes.
1133         * memrange.h: Fix common/ includes.
1134         * memattr.c: Fix common/ includes.
1135         * maint.h: Fix common/ includes.
1136         * maint.c: Fix common/ includes.
1137         * main.c: Fix common/ includes.
1138         * machoread.c: Fix common/ includes.
1139         * location.c: Fix common/ includes.
1140         * linux-thread-db.c: Fix common/ includes.
1141         * linux-nat.c: Fix common/ includes.
1142         * linux-fork.c: Fix common/ includes.
1143         * inline-frame.c: Fix common/ includes.
1144         * infrun.c: Fix common/ includes.
1145         * inflow.c: Fix common/ includes.
1146         * inferior.h: Fix common/ includes.
1147         * inferior.c: Fix common/ includes.
1148         * infcmd.c: Fix common/ includes.
1149         * inf-ptrace.c: Fix common/ includes.
1150         * inf-child.c: Fix common/ includes.
1151         * ia64-linux-nat.c: Fix common/ includes.
1152         * i387-tdep.c: Fix common/ includes.
1153         * i386-tdep.c: Fix common/ includes.
1154         * i386-linux-tdep.c: Fix common/ includes.
1155         * i386-linux-nat.c: Fix common/ includes.
1156         * i386-go32-tdep.c: Fix common/ includes.
1157         * i386-fbsd-tdep.c: Fix common/ includes.
1158         * i386-fbsd-nat.c: Fix common/ includes.
1159         * guile/scm-type.c: Fix common/ includes.
1160         * guile/guile.c: Fix common/ includes.
1161         * go32-nat.c: Fix common/ includes.
1162         * gnu-nat.c: Fix common/ includes.
1163         * gdbthread.h: Fix common/ includes.
1164         * gdbarch-selftests.c: Fix common/ includes.
1165         * gdb_usleep.c: Fix common/ includes.
1166         * gdb_select.h: Fix common/ includes.
1167         * gdb_bfd.c: Fix common/ includes.
1168         * gcore.c: Fix common/ includes.
1169         * fork-child.c: Fix common/ includes.
1170         * findvar.c: Fix common/ includes.
1171         * fbsd-nat.c: Fix common/ includes.
1172         * event-top.c: Fix common/ includes.
1173         * event-loop.c: Fix common/ includes.
1174         * dwarf2read.c: Fix common/ includes.
1175         * dwarf2loc.c: Fix common/ includes.
1176         * dwarf2-frame.c: Fix common/ includes.
1177         * dwarf-index-cache.c: Fix common/ includes.
1178         * dtrace-probe.c: Fix common/ includes.
1179         * disasm-selftests.c: Fix common/ includes.
1180         * defs.h: Fix common/ includes.
1181         * csky-tdep.c: Fix common/ includes.
1182         * cp-valprint.c: Fix common/ includes.
1183         * cp-support.h: Fix common/ includes.
1184         * cp-support.c: Fix common/ includes.
1185         * corelow.c: Fix common/ includes.
1186         * completer.h: Fix common/ includes.
1187         * completer.c: Fix common/ includes.
1188         * compile/compile.c: Fix common/ includes.
1189         * compile/compile-loc2c.c: Fix common/ includes.
1190         * compile/compile-cplus-types.c: Fix common/ includes.
1191         * compile/compile-cplus-symbols.c: Fix common/ includes.
1192         * command.h: Fix common/ includes.
1193         * cli/cli-dump.c: Fix common/ includes.
1194         * cli/cli-cmds.c: Fix common/ includes.
1195         * charset.c: Fix common/ includes.
1196         * build-id.c: Fix common/ includes.
1197         * btrace.h: Fix common/ includes.
1198         * btrace.c: Fix common/ includes.
1199         * breakpoint.h: Fix common/ includes.
1200         * breakpoint.c: Fix common/ includes.
1201         * ax.h:
1202         (enum agent_op): Fix common/ includes.
1203         * ax-general.c (struct aop_map): Fix common/ includes.
1204         * ax-gdb.c: Fix common/ includes.
1205         * auxv.c: Fix common/ includes.
1206         * auto-load.c: Fix common/ includes.
1207         * arm-tdep.c: Fix common/ includes.
1208         * arch/riscv.c: Fix common/ includes.
1209         * arch/ppc-linux-common.c: Fix common/ includes.
1210         * arch/i386.c: Fix common/ includes.
1211         * arch/arm.c: Fix common/ includes.
1212         * arch/arm-linux.c: Fix common/ includes.
1213         * arch/arm-get-next-pcs.c: Fix common/ includes.
1214         * arch/amd64.c: Fix common/ includes.
1215         * arch/aarch64.c: Fix common/ includes.
1216         * arch/aarch64-insn.c: Fix common/ includes.
1217         * arch-utils.c: Fix common/ includes.
1218         * amd64-windows-tdep.c: Fix common/ includes.
1219         * amd64-tdep.c: Fix common/ includes.
1220         * amd64-sol2-tdep.c: Fix common/ includes.
1221         * amd64-obsd-tdep.c: Fix common/ includes.
1222         * amd64-nbsd-tdep.c: Fix common/ includes.
1223         * amd64-linux-tdep.c: Fix common/ includes.
1224         * amd64-linux-nat.c: Fix common/ includes.
1225         * amd64-fbsd-tdep.c: Fix common/ includes.
1226         * amd64-fbsd-nat.c: Fix common/ includes.
1227         * amd64-dicos-tdep.c: Fix common/ includes.
1228         * amd64-darwin-tdep.c: Fix common/ includes.
1229         * agent.c: Fix common/ includes.
1230         * ada-lang.h: Fix common/ includes.
1231         * ada-lang.c: Fix common/ includes.
1232         * aarch64-tdep.c: Fix common/ includes.
1233
1234 2019-01-25  Tom Tromey  <tom@tromey.com>
1235
1236         * common/create-version.sh: Use common/version.h.
1237
1238 2019-01-24  Pedro Alves  <palves@redhat.com>
1239
1240         * infrun.c (signal_stop, signal_print, signal_program)
1241         (signal_catch, signal_pass): Now arrays instead of pointers.
1242         (update_signals_program_target, do_target_resume)
1243         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1244         * linux-nat.c (linux_nat_target::pass_signals)
1245         (linux_nat_target::create_inferior, linux_nat_target::attach):
1246         Adjust.
1247         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1248         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1249         * procfs.c (procfs_target::pass_signals): Adjust.
1250         * record-full.c (record_full_target::resume): Adjust.
1251         * remote.c (remote_target::pass_signals)
1252         (remote_target::program_signals): Adjust.
1253         * target-debug.h (target_debug_print_signals): Now takes a
1254         gdb::array_view as parameter.  Adjust.
1255         * target.h (target_ops) <pass_signals, program_signals>: Replace
1256         pointer and length parameters with gdb::array_view.
1257         (target_pass_signals, target_program_signals): Likewise.
1258         * target-delegates.c: Regenerate.
1259
1260 2019-01-24  Pedro Alves  <palves@redhat.com>
1261
1262         * common/forward-scope-exit.h
1263         (forward_scope_exit::forward_scope_exit): Pass arguments to
1264         m_bind_function directly, instead of creating a std::bind and
1265         copying that.
1266
1267 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1268
1269         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1270         for static members.
1271         (pass_in_v_vfp_candidate): Likewise.
1272
1273 2019-01-23  Tom Tromey  <tom@tromey.com>
1274             Pedro Alves  <palves@redhat.com>
1275
1276         * regcache.c (class regcache_invalidator): Remove.
1277         (regcache::raw_write): Use make_scope_exit.
1278
1279 2019-01-23  Tom Tromey  <tom@tromey.com>
1280
1281         * ui-out.h (class ui_out_emit_type): Update comment.
1282
1283 2019-01-23  Tom Tromey  <tom@tromey.com>
1284
1285         * infrun.c (fetch_inferior_event): Update comment.
1286
1287 2019-01-23  Tom Tromey  <tom@tromey.com>
1288             Pedro Alves  <palves@redhat.com>
1289
1290         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1291         parameter.
1292         (fetch_inferior_event): Use SCOPE_EXIT.
1293
1294
1295 2019-01-23  Tom Tromey  <tom@tromey.com>
1296             Pedro Alves  <palves@redhat.com>
1297
1298         * infrun.c (disable_thread_events): Delete.
1299         (stop_all_threads): Use SCOPE_EXIT.
1300
1301 2019-01-23  Tom Tromey  <tom@tromey.com>
1302             Pedro Alves  <palves@redhat.com>
1303
1304         * symfile.c: Include forward-scope-exit.h.
1305         (clear_symtab_users_cleanup): Replace forward declaration with
1306         a FORWARD_SCOPE_EXIT.
1307         (syms_from_objfile_1): Use the forward_scope_exit and
1308         gdb::optional instead of cleanup_function.
1309         (reread_symbols): Use the forward_scope_exit instead of
1310         cleanup_function.
1311         (clear_symtab_users_cleanup): Remove function.
1312
1313 2019-01-23  Tom Tromey  <tom@tromey.com>
1314             Pedro Alves  <palves@redhat.com>
1315
1316         * linux-nat.c: Include scope-exit.h.
1317         (cleanup_target_stop): Remove.
1318         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1319         SCOPE_EXIT.
1320
1321 2019-01-23  Tom Tromey  <tom@tromey.com>
1322             Pedro Alves  <palves@redhat.com>
1323
1324         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1325         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1326
1327 2019-01-23  Tom Tromey  <tom@tromey.com>
1328             Andrew Burgess  <andrew.burgess@embecosm.com>
1329             Pedro Alves  <palves@redhat.com>
1330
1331         * infrun.c (fetch_inferior_event): Use scope_exit.
1332         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1333         * top.c (execute_command): Use scope_exit.
1334         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1335         * utils.c (do_bpstat_clear_actions_cleanup)
1336         (make_bpstat_clear_actions_cleanup): Remove.
1337
1338 2019-01-23  Tom Tromey  <tom@tromey.com>
1339             Pedro Alves  <palves@redhat.com>
1340
1341         * infrun.c: Include "common/scope-exit.h"
1342         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1343         (wait_for_inferior): Use SCOPE_EXIT.
1344         (fetch_inferior_event): Use scope_exit.
1345
1346 2019-01-23  Tom Tromey  <tom@tromey.com>
1347             Pedro Alves  <palves@redhat.com>
1348
1349         * breakpoint.c (create_breakpoint): Remove cleanup.
1350
1351 2019-01-23  Tom Tromey  <tom@tromey.com>
1352             Andrew Burgess  <andrew.burgess@embecosm.com>
1353             Pedro Alves  <palves@redhat.com>
1354
1355 2019-01-23  Pedro Alves  <palves@redhat.com>
1356
1357         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1358
1359 2019-01-23  Pedro Alves  <palves@redhat.com>
1360             Andrew Burgess  <andrew.burgess@embecosm.com>
1361
1362         * gdbthread.h: Include "common/forward-scope-exit.h".
1363         (scoped_finish_thread_state): Redefine custom class in terms of
1364         forward_scope_exit.
1365
1366 2019-01-23  Pedro Alves  <palves@redhat.com>
1367             Andrew Burgess  <andrew.burgess@embecosm.com>
1368
1369         * common/forward-scope-exit.h: New file.
1370
1371 2019-01-23  Pedro Alves  <palves@redhat.com>
1372             Andrew Burgess  <andrew.burgess@embecosm.com>
1373             Tom Tromey  <tom@tromey.com>
1374
1375         * common/scope-exit.h: New file.
1376
1377 2019-01-23  Pedro Alves  <palves@redhat.com>
1378
1379         * common/preprocessor.h (ESC): Rename to ...
1380         (ESC_PARENS): ... this.
1381         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1382         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1383
1384 2019-01-23  Tom Tromey  <tom@tromey.com>
1385
1386         * language.h (class scoped_switch_to_sym_language_if_auto):
1387         Initialize m_lang in both cases.
1388
1389 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1390
1391         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1392         with XCNEW.
1393
1394 2019-01-22  Tom Tromey  <tom@tromey.com>
1395
1396         * corelow.c: Do not include sys/file.h.
1397
1398 2019-01-22  Tom Tromey  <tom@tromey.com>
1399
1400         * tui/tui-wingeneral.h: Include gdb_curses.h.
1401
1402 2019-01-22  Tom Tromey  <tom@tromey.com>
1403
1404         * source-cache.h (class source_cache) <get_source_lines,
1405         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1406
1407 2019-01-22  Tom Tromey  <tom@tromey.com>
1408
1409         * remote-fileio.h (struct remote_target): Declare.
1410
1411 2019-01-22  Tom Tromey  <tom@tromey.com>
1412
1413         * python/py-arch.c: Do not include py-ref.h.
1414         * python/py-bpevent.c: Do not include py-ref.h.
1415         * python/py-cmd.c: Do not include py-ref.h.
1416         * python/py-continueevent.c: Do not include py-ref.h.
1417         * python/py-event.h: Do not include py-ref.h.
1418         * python/py-evtregistry.c: Do not include py-ref.h.
1419         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1420         * python/py-frame.c: Do not include py-ref.h.
1421         * python/py-framefilter.c: Do not include py-ref.h.
1422         * python/py-function.c: Do not include py-ref.h.
1423         * python/py-infevents.c: Do not include py-ref.h.
1424         * python/py-linetable.c: Do not include py-ref.h.
1425         * python/py-objfile.c: Do not include py-ref.h.
1426         * python/py-param.c: Do not include py-ref.h.
1427         * python/py-prettyprint.c: Do not include py-ref.h.
1428         * python/py-progspace.c: Do not include py-ref.h.
1429         * python/py-symbol.c: Do not include py-ref.h.
1430         * python/py-symtab.c: Do not include py-ref.h.
1431         * python/py-type.c: Do not include py-ref.h.
1432         * python/py-unwind.c: Do not include py-ref.h.
1433         * python/py-utils.c: Do not include py-ref.h.
1434         * python/py-value.c: Do not include py-ref.h.
1435         * python/py-varobj.c: Do not include py-ref.h.
1436         * python/py-xmethods.c: Do not include py-ref.h.
1437         * python/python.c: Do not include py-ref.h.
1438         * varobj.c: Do not include py-ref.h.
1439
1440 2019-01-22  Tom Tromey  <tom@tromey.com>
1441
1442         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1443         keyword for bcache.
1444
1445 2019-01-22  Tom Tromey  <tom@tromey.com>
1446
1447         * compile/compile-cplus-types.c: Remove a comment by #include.
1448
1449 2019-01-22  Tom Tromey  <tom@tromey.com>
1450
1451         * compile/gcc-c-plugin.h: Include compile-internal.h.
1452
1453 2019-01-22  Tom Tromey  <tom@tromey.com>
1454
1455         * stabsread.c (EXTERN): Do not define.
1456         (symnum, next_symbol_text_func, processing_gcc_compilation)
1457         (within_function, global_sym_chain, global_stabs)
1458         (previous_stab_code, this_object_header_files)
1459         (n_this_object_header_files)
1460         (n_allocated_this_object_header_files): Define.
1461         * stabsread.h (EXTERN): Never define.  Use "extern".
1462
1463 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1464
1465         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1466         history_value.
1467
1468 2019-01-21  Tom Tromey  <tom@tromey.com>
1469
1470         * ui-out.c: Fix includes.
1471         * tui/tui-source.c: Fix includes.
1472         * target.c: Fix includes.
1473         * remote.c: Fix includes.
1474         * regcache.c: Fix includes.
1475         * python/py-block.c: Fix includes.
1476         * printcmd.c: Fix includes.
1477         * or1k-tdep.c: Fix includes.
1478         * mi/mi-main.c: Fix includes.
1479         * m32r-tdep.c: Fix includes.
1480         * csky-tdep.c: Fix includes.
1481         * compile/compile-cplus-types.c: Fix includes.
1482         * cli/cli-interp.c: Fix includes.
1483
1484 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1485
1486         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1487         for padding.
1488
1489 2019-01-16  Tom Tromey  <tom@tromey.com>
1490
1491         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1492         earlier.
1493         (struct objfile) <msymbols_range>: Move from top level.
1494         <msymbols>: New method.
1495         (class objfile_msymbols): Remove.
1496         * symtab.c (default_collect_symbol_completion_matches_break_on):
1497         Update.
1498         * symmisc.c (dump_msymbols): Update.
1499         * stabsread.c (scan_file_globals): Update.
1500         * objc-lang.c (info_selectors_command, info_classes_command)
1501         (find_methods): Update.
1502         * minsyms.c (find_solib_trampoline_target): Update.
1503         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1504         * coffread.c (coff_symfile_read): Update.
1505         * ada-lang.c (ada_lookup_simple_minsym)
1506         (ada_collect_symbol_completion_matches): Update.
1507
1508 2019-01-16  Tom Tromey  <tom@tromey.com>
1509
1510         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1511         type.  Remove no-argument constructor.
1512         <iterator::operator++>: Simplify.
1513         <begin>: Update.
1514         <end>: Use minimal_symbol_count.
1515
1516 2019-01-16  Tom Tromey  <tom@tromey.com>
1517
1518         * objfiles.h (struct objfile) <psymtabs>: New method.
1519         (class objfile_psymtabs): Remove.
1520         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1521         typedef.
1522         <range>: New method.
1523         (require_partial_symbols): Change return type.
1524         * psymtab.c (require_partial_symbols)
1525         (psym_expand_symtabs_matching): Update.
1526         * mdebugread.c (parse_partial_symbols): Update.
1527         * dbxread.c (dbx_end_psymtab): Update.
1528
1529 2019-01-15  Tom Tromey  <tom@tromey.com>
1530
1531         * symtab.c (lookup_objfile_from_block)
1532         (lookup_symbol_in_objfile_symtabs)
1533         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1534         (find_line_symtab, info_sources_command)
1535         (default_collect_symbol_completion_matches_break_on)
1536         (make_source_files_completion_list): Update.
1537         * symmisc.c (print_objfile_statistics, dump_objfile)
1538         (maintenance_print_symbols, maintenance_info_symtabs)
1539         (maintenance_check_symtabs, maintenance_info_line_tables):
1540         Update.
1541         * source.c (select_source_symtab)
1542         (forget_cached_source_info_for_objfile): Update.
1543         * objfiles.h (class objfile_compunits): Remove.
1544         (struct objfile) <compunits_range>: New typedef.
1545         (compunits): New method.
1546         * objfiles.c (objfile_relocate1): Update.
1547         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1548         * maint.c (count_symtabs_and_blocks): Update.
1549         * linespec.c (iterate_over_all_matching_symtabs): Update.
1550         * cp-support.c (add_symbol_overload_list_qualified): Update.
1551         * coffread.c (coff_symtab_read): Update.
1552         * ada-lang.c (add_nonlocal_symbols)
1553         (ada_collect_symbol_completion_matches)
1554         (ada_add_global_exceptions): Update.
1555
1556 2019-01-15  Tom Tromey  <tom@tromey.com>
1557
1558         * progspace.h (program_space) <objfiles_safe_range>: New
1559         typedef.
1560         <objfiles_safe>: New method.
1561         * objfiles.h (class all_objfiles_safe): Remove.
1562         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1563         * jit.c (jit_inferior_exit_hook): Update.
1564
1565 2019-01-17  Tom Tromey  <tom@tromey.com>
1566
1567         * progspace.h (program_space) <objfiles_range>: New typedef.
1568         <objfiles>: New method.
1569         <objfiles_head>: Rename from objfiles.
1570         (object_files): Update.
1571         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1572         * guile/scm-pretty-print.c
1573         (ppscm_find_pretty_printer_from_objfiles): Update.
1574         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1575         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1576         Update.
1577         * python/py-progspace.c (pspy_get_objfiles): Update.
1578         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1579         Update.
1580         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1581         (objfpy_lookup_objfile_by_build_id): Update.
1582         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1583         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1584         Update.
1585         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1586         (expand_symtab_containing_pc, lookup_objfile_from_block)
1587         (lookup_static_symbol, basic_lookup_transparent_type)
1588         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1589         (find_line_symtab, info_sources_command)
1590         (default_collect_symbol_completion_matches_break_on)
1591         (make_source_files_completion_list, find_main_name): Update.
1592         * symmisc.c (print_symbol_bcache_statistics)
1593         (print_objfile_statistics, maintenance_print_symbols)
1594         (maintenance_print_msymbols, maintenance_print_objfiles)
1595         (maintenance_info_symtabs, maintenance_check_symtabs)
1596         (maintenance_expand_symtabs, maintenance_info_line_tables):
1597         Update.
1598         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1599         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1600         (map_overlay_command, unmap_overlay_command)
1601         (simple_overlay_update, expand_symtabs_matching)
1602         (map_symbol_filenames): Update.
1603         * symfile-debug.c (set_debug_symfile): Update.
1604         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1605         Update.
1606         * source.c (select_source_symtab, forget_cached_source_info):
1607         Update.
1608         * solib.c (solib_read_symbols): Update.
1609         * solib-spu.c (append_ocl_sos): Update.
1610         * psymtab.c (maintenance_print_psymbols)
1611         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1612         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1613         * printcmd.c (info_symbol_command): Update.
1614         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1615         Update.
1616         * objfiles.h (class all_objfiles): Remove.
1617         * objfiles.c (have_partial_symbols, have_full_symbols)
1618         (have_minimal_symbols, qsort_cmp, update_section_map)
1619         (shared_objfile_contains_address_p)
1620         (default_iterate_over_objfiles_in_search_order): Update.
1621         * objc-lang.c (info_selectors_command, info_classes_command)
1622         (find_methods): Update.
1623         * minsyms.c (find_solib_trampoline_target): Update.
1624         * maint.c (maintenance_info_sections)
1625         (maintenance_translate_address, count_symtabs_and_blocks):
1626         Update.
1627         * main.c (captured_main_1): Update.
1628         * linux-thread-db.c (try_thread_db_load_from_pdir)
1629         (has_libpthread): Update.
1630         * linespec.c (iterate_over_all_matching_symtabs)
1631         (search_minsyms_for_name): Update.
1632         * jit.c (jit_find_objf_with_entry_addr): Update.
1633         * hppa-tdep.c (find_unwind_entry)
1634         (hppa_lookup_stub_minimal_symbol): Update.
1635         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1636         Update.
1637         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1638         (elf_gnu_ifunc_resolve_by_got): Update.
1639         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1640         * dwarf-index-write.c (save_gdb_index_command): Update.
1641         * cp-support.c (add_symbol_overload_list_qualified): Update.
1642         * breakpoint.c (create_overlay_event_breakpoint)
1643         (create_longjmp_master_breakpoint)
1644         (create_std_terminate_master_breakpoint)
1645         (create_exception_master_breakpoint): Update.
1646         * blockframe.c (find_pc_partial_function): Update.
1647         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1648         (ada_collect_symbol_completion_matches)
1649         (ada_add_global_exceptions): Update.
1650
1651 2019-01-17  Tom Tromey  <tom@tromey.com>
1652
1653         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1654         declare VEC.
1655         (solib_target_parse_libraries): Change return type.
1656         (library_list_start_segment, library_list_start_section)
1657         (library_list_end_library, library_list_start_library); Update.
1658         (solib_target_free_library_list): Remove.
1659         (solib_target_parse_libraries): Remove cleanup.  Change return
1660         type.
1661         (solib_target_current_sos): Update.
1662
1663 2019-01-17  Tom Tromey  <tromey@bapiya>
1664
1665         * valprint.c: Replace "the the" with "the".
1666         * symtab.c: Replace "the the" with "the".
1667         * solib.c: Replace "the the" with "the".
1668         * solib-dsbt.c: Replace "the the" with "the".
1669         * linespec.c: Replace "the the" with "the".
1670         * dwarf2loc.h: Replace "the the" with "the".
1671         * amd64-windows-tdep.c: Replace "the the" with "the".
1672         * aarch64-tdep.c: Replace "the the" with "the".
1673
1674 2019-01-16  Keith Seitz  <keiths@redhat.com>
1675
1676         PR gdb/23773
1677         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1678         <builder>: Rename to ..
1679         <m_builder>: ... this and make private.
1680         (dwarf2_cu::get_builder): New method.  Change all users of
1681         `builder' to use this method.
1682         (dwarf2_start_symtab): Move to ...
1683         (dwarf2_cu::start_symtab): ... here.  Update all callers
1684         (setup_type_unit_groups): Move to ...
1685         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1686         callers.
1687         (dwarf2_cu::reset_builder): New method.
1688         (process_full_compunit, process_full_type_unit): Use
1689         dwarf2_cu::reset_builder.
1690         (follow_die_offset): Record the ancestor CU if it is different
1691         from the followed DIE's CU.
1692         (follow_die_sig_1): Likewise.
1693
1694 2019-01-15  Tom Tromey  <tom@tromey.com>
1695
1696         * remote.c (class remote_state) <buf>: Now a char_vector.
1697         <buf_size>: Remove.
1698         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1699         parameter.
1700         (remote_target::getpkt_or_notif_sane_1)
1701         (remote_target::getpkt_sane)
1702         (remote_target::getpkt_or_notif_sane): Likewise.
1703         (class remote_target) <putpkt>: New overload.
1704         (remote_target::read_frame): Change type of "buf_p".  Remove
1705         sizeof_p parameter.
1706         (packet_ok): New overload.
1707         (packet_check_result): New overload.
1708         Update all uses.
1709
1710 2019-01-14  Tom Tromey  <tom@tromey.com>
1711
1712         * remote-notif.c (handle_notification, remote_notif_ack)
1713         (remote_notif_parse): Make "buf" const.
1714         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1715         const.
1716         (remote_notif_parse, remote_notif_ack, handle_notification):
1717         Likewise.
1718         * remote.c (remote_notif_stop_parse): Make "buf" const.
1719         (remote_target::remote_parse_stop_reply): Make "buf" const.
1720         (remote_notif_stop_ack): Make "buf" const.
1721
1722 2019-01-14  Tom Tromey  <tom@tromey.com>
1723
1724         * remote.c (remote_console_output): Make parameter const.
1725
1726 2019-01-14  Tom Tromey  <tom@tromey.com>
1727
1728         * target-debug.h (target_debug_print_signals): Constify.
1729         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1730         * procfs.c (procfs_target::pass_signals): Update.
1731         * linux-nat.c (linux_nat_target::pass_signals): Update.
1732         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1733         * target-delegates.c: Rebuild.
1734         * remote.c (remote_target::program_signals): Update.
1735         (remote_target::pass_signals): Update.
1736         * target.c (target_pass_signals): Constify argument.
1737         (target_program_signals): Likewise.
1738         * target.h (struct target_ops) <pass_signals, program_signals>:
1739         Constify argument.
1740         (target_pass_signals, target_program_signals): Constify argument.
1741
1742 2019-01-14  Tom Tromey  <tom@tromey.com>
1743
1744         PR tui/28819:
1745         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1746
1747 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1748
1749         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1750         field.
1751         * rs6000-tdep.c: Include reggroups.h.
1752         (IS_V_ALIAS_PSEUDOREG): Define.
1753         (rs6000_register_name): Return names for the "vX" aliases.
1754         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1755         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1756         aliases.  Call default_register_reggroup_p for all other
1757         pseudo-registers.
1758         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1759         New functions.
1760         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1761         Handle "vX" aliases.
1762         (v_alias_pseudo_register_collect): New function.
1763         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1764         (rs6000_gdbarch_init): Initialize "vX" aliases as
1765         pseudo-registers.  Restore registration of
1766         rs6000_pseudo_register_reggroup_p with
1767         set_tdesc_pseudo_register_reggroup_p.
1768
1769 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1770
1771         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1772         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1773         set_gdbarch_num_pseudo_regs.
1774
1775 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1776
1777         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1778         Remove arg prefixname, add do_set and do_show.
1779         Add member functions set_list and show_list.
1780         * cli/cli-style.c (class cli_style_option): Update accordingly.
1781         (style_set_list): Move to file scope.
1782         (style_show_list): Likewise.
1783         (set_style): Call help_list.
1784         (show_style): Call cmd_show_list.
1785         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1786         Update to use the new macro.
1787
1788 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1789
1790         * ada-lang.c (_initialize_ada_language): Expand the help text
1791         for the "catch exception" command.
1792
1793 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1794
1795         * symtab.c (matching_obj_sections): Initialize obj,
1796         declare it closer to its usage.
1797
1798 2019-01-10  Tom Tromey  <tom@tromey.com>
1799
1800         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1801         (basic_inf_threads_range): Remove.
1802         (inf_threads_range, inf_non_exited_threads_range)
1803         (safe_inf_threads_range): Use next_adapter.
1804
1805 2019-01-10  Keith Seitz  <keiths@redhat.com>
1806
1807         PR gdb/23712
1808         PR symtab/23010
1809         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1810         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1811
1812 2019-01-10  Keith Seitz  <keiths@redhat.com>
1813
1814         PR gdb/23712
1815         PR symtab/23010
1816         * dictionary.c (pending_to_vector): Remove.
1817         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1818         Remove _1 suffix, replacing functions of the same name.  Update
1819         all callers.
1820         (dict_create_hashed, dict_create_hashed_expandable)
1821         (dict_create_linear, dict_create_linear_expandable, dict_free)
1822         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1823         Make functions static.
1824
1825 2019-01-10  Keith Seitz  <keiths@redhat.com>
1826
1827         PR gdb/23712
1828         PR symtab/23010
1829         * dictionary.h (struct dictionary): Replace declaration with
1830         multidictionary.
1831         (dict_create_hashed, dict_create_hashed_expandable)
1832         (dict_create_linear, dict_create_linear_expandable)
1833         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1834         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1835         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1836         taking multidictionary argument.
1837         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1838         * block.h (struct block) <dict>: Change to multidictionary
1839         and rename `multidict'.
1840         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1841         symmisc.c: Update all dictionary references to multidictionary.
1842
1843 2019-01-10  Keith Seitz  <keiths@redhat.com>
1844
1845         PR gdb/23712
1846         PR symtab/23010
1847         * dictionary.c: Include unordered_map.
1848         (pending_to_vector): New function.
1849         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1850         Rewrite the non-"_1" functions to take vector instead
1851         of linked list.
1852         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1853         "new" _1 versions of the same name.
1854         (multidictionary): Define.
1855         (std::hash<enum language): New definition.
1856         (collate_pending_symbols_by_language, mdict_create_hashed)
1857         (mdict_create_hashed_expandable, mdict_create_linear)
1858         (mdict_create_linear_expandable, mdict_free)
1859         (find_language_dictionary, create_new_language_dictionary)
1860         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1861         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1862         (mdict_size, mdict_empty): New functions.
1863         * dictionary.h (mdict_iterator): Define.
1864
1865 2019-01-10  Pedro Alves  <palves@redhat.com>
1866
1867         * breakpoint.c (read_uploaded_action)
1868         (create_tracepoint_from_upload): Adjust to use
1869         gdb::unique_xmalloc_ptr.
1870         * ctf.c (ctf_write_uploaded_tp):
1871         (SET_ARRAY_FIELD): Use emplace_back.
1872         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1873         * tracefile-tfile.c (tfile_write_uploaded_tp):
1874         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1875         gdb::unique_xmalloc_ptr.
1876         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1877         at_string, cond_string, cmd_strings>: Replace char pointers
1878         with gdb::unique_xmalloc_ptr.
1879
1880 2019-01-10  Pedro Alves  <palves@redhat.com>
1881
1882         * solib-target.c (library_list_start_library): Don't xstrdup name.
1883
1884 2019-01-10  Pedro Alves  <palves@redhat.com>
1885
1886         * mdebugread.c (parse_partial_symbols): Use
1887         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1888
1889 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1890
1891         * linux-fork.c (scoped_switch_fork_info)
1892         <~scoped_switch_fork_info>: Fix incorrect variable name.
1893
1894 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1895
1896         * linux-fork.c (scoped_switch_fork_info)
1897         <scoped_switch_fork_info>: Make explicit.
1898         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1899
1900 2019-01-10  Tom Tromey  <tom@tromey.com>
1901
1902         * objfiles.h (objfile::reset_psymtabs): Update.
1903         * objfiles.c (objfile::objfile): Update.
1904         * psymtab.h (psymtab_storage::obstack): Update.
1905         (psymtab_storage::m_obstack): Use gdb::optional.
1906         (class psymtab_storage): Update comment.  Remove objfile
1907         parameter.
1908         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1909
1910 2019-01-10  Tom Tromey  <tom@tromey.com>
1911
1912         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1913         <free_psymtabs>: Now private.
1914         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1915         (allocate_psymtab): Use new method.
1916
1917 2019-01-10  Tom Tromey  <tom@tromey.com>
1918
1919         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1920         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1921         * mdebugread.c (parse_partial_symbols): Use
1922         allocate_dependencies.
1923         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1924         allocate_dependencies.
1925         (process_psymtab_comp_unit_reader)
1926         (build_type_psymtab_dependencies): Likewise.
1927         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1928
1929 2019-01-10  Tom Tromey  <tom@tromey.com>
1930
1931         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1932         PSYMBOL_SET_LANGUAGE.
1933         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1934
1935 2019-01-10  Tom Tromey  <tom@tromey.com>
1936
1937         * psymtab.h (psymtab_storage::obstack): New method.
1938         <m_obstack>: Rename from obstack; now private.
1939         * psymtab.c (psymtab_storage): Update.
1940         * dwarf2read.c (create_addrmap_from_index)
1941         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1942         Update.
1943
1944 2019-01-10  Tom Tromey  <tom@tromey.com>
1945
1946         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1947         * objfiles.h (objfile::reset_psymtabs): New method.
1948
1949 2019-01-10  Tom Tromey  <tom@tromey.com>
1950
1951         * symmisc.c (print_symbol_bcache_statistics): Update.
1952         (print_objfile_statistics): Update.
1953         * symfile.c (reread_symbols): Update.
1954         * psymtab.h (class psymtab_storage): New.
1955         * psymtab.c (psymtab_storage): New constructor.
1956         (~psymtab_storage): New destructor.
1957         (require_partial_symbols): Update.
1958         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1959         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1960         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1961         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1962         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1963         (start_psymtab_common, end_psymtab_common)
1964         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1965         (allocate_psymtab): Update.
1966         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1967         Update.
1968         (dump_psymtab_addrmap, maintenance_print_psymbols)
1969         (maintenance_check_psymtabs): Update.
1970         (class objfile_psymtabs): Move to objfiles.h.
1971         * psympriv.h (discard_psymtab): Now inline.
1972         (psymtab_discarder::psymtab_discarder): Update.
1973         (psymtab_discarder::~psymtab_discarder): Update.
1974         (ALL_OBJFILE_PSYMTABS): Rewrite.
1975         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1976         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1977         Remove fields.
1978         <partial_symtabs>: New field.
1979         (class objfile_psymtabs): Move from psymtab.h.  Update.
1980         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1981         psymbol_cache.
1982         (objfile::~objfile): Don't destroy psymbol_cache.
1983         * mdebugread.c (parse_partial_symbols): Update.
1984         * dwarf2read.c (create_addrmap_from_index)
1985         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1986         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1987         (add_partial_subprogram, dwarf2_ranges_read): Update.
1988         * dwarf-index-write.c (write_address_map)
1989         (write_one_signatured_type, recursively_write_psymbols)
1990         (class debug_names, class debug_names, write_psymtabs_to_index):
1991         Update.
1992
1993 2019-01-10  Tom Tromey  <tom@tromey.com>
1994
1995         * symtab.h (SYMBOL_SET_NAMES): Update.
1996         (symbol_set_names): Update.
1997         (MSYMBOL_SET_NAMES): Update.
1998         * symtab.c (symbol_set_names): Change argument to be an
1999         objfile_per_bfd_storage.
2000         * psymtab.c (add_psymbol_to_bcache): Update.
2001         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
2002
2003 2019-01-10  Tom Tromey  <tom@tromey.com>
2004
2005         * symtab.c (create_demangled_names_hash): Change argument to be an
2006         objfile_per_bfd_storage.
2007         (symbol_set_names): Update.
2008
2009 2019-01-10  Tom Tromey  <tom@tromey.com>
2010
2011         * xcoffread.c (xcoff_initial_scan): Unconditionally call
2012         init_psymbol_list.
2013         * psymtab.c (init_psymbol_list): Do nothing if already called.
2014         * psympriv.h (init_psymbol_list): Add comment.
2015         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
2016         init_psymbol_list.
2017         * dbxread.c (dbx_symfile_read): Unconditionally call
2018         init_psymbol_list.
2019
2020 2019-01-10  Tom Tromey  <tom@tromey.com>
2021
2022         * xcoffread.c (scan_xcoff_symtab): Update.
2023         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
2024         "where".
2025         * mdebugread.c (parse_partial_symbols)
2026         (handle_psymbol_enumerators): Update.
2027         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
2028         * dbxread.c (read_dbx_symtab): Update.
2029         * psympriv.h (psymbol_placement): New enum.
2030         (add_psymbol_to_list): Update.
2031
2032 2019-01-10  Tom Tromey  <tom@tromey.com>
2033
2034         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
2035         static_psymbols parameters.
2036         (scan_xcoff_symtab): Update.
2037         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2038         static_psymbols parameters.
2039         * psympriv.h (start_psymtab_common): Update.
2040         * mdebugread.c (parse_partial_symbols): Update.
2041         * dwarf2read.c (create_partial_symtab): Update.
2042         * dbxread.c (read_dbx_symtab): Update.
2043         (start_psymtab): Remove global_psymbols and static_psymbols
2044         parameters.
2045
2046 2019-01-10  Tom Tromey  <tom@tromey.com>
2047
2048         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2049         * psymtab.c (allocate_psymtab): Add comment.
2050         * psympriv.h (allocate_psymtab): Add comment.
2051         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2052         initializations.
2053         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2054
2055 2019-01-10  Tom Tromey  <tom@tromey.com>
2056
2057         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2058         Don't declare.
2059         * mipsread.c: Include mdebugread.h.
2060         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2061         Declare.
2062         * elfread.c: Include mdebugread.h.
2063
2064 2019-01-09  Tom Tromey  <tom@tromey.com>
2065
2066         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2067         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2068         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2069         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2070         (psym_lookup_symbol, psym_find_last_source_symtab)
2071         (psym_forget_cached_source_info, psym_print_stats)
2072         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2073         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2074         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2075         (psym_find_compunit_symtab_by_address)
2076         (maintenance_print_psymbols, maintenance_info_psymtabs)
2077         (maintenance_check_psymtabs): Use ranged for.
2078         * psymtab.h (class objfile_psymtabs): New.
2079         (require_partial_symbols): Return objfile_psymtabs.
2080         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2081
2082 2019-01-09  Tom Tromey  <tom@tromey.com>
2083
2084         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2085         (find_pc_mapped_section, list_overlays_command)
2086         (map_overlay_command, unmap_overlay_command)
2087         (simple_overlay_update): Use all_objfiles.
2088         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2089         * printcmd.c (info_symbol_command): Use all_objfiles.
2090         * objfiles.h (ALL_OBJSECTIONS): Remove.
2091         * maint.c (maintenance_translate_address): Use all_objfiles.
2092         * gcore.c (gcore_create_callback): Use all_objfiles.
2093         (objfile_find_memory_regions): Likewise.
2094
2095 2019-01-09  Tom Tromey  <tom@tromey.com>
2096
2097         * symtab.c (find_line_symtab, info_sources_command)
2098         (make_source_files_completion_list): Use objfile_compunits.
2099         * source.c (select_source_symtab): Use objfile_compunits.
2100         * objfiles.h (struct objfile): Update comment.
2101         (ALL_OBJFILES): Remove.
2102         (ALL_FILETABS): Remove.
2103         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2104         objfile_compunits.
2105
2106 2019-01-09  Tom Tromey  <tom@tromey.com>
2107
2108         * symmisc.c (print_objfile_statistics, dump_objfile)
2109         (maintenance_print_symbols): Use compunit_filetabs.
2110         * source.c (forget_cached_source_info_for_objfile): Use
2111         compunit_filetabs.
2112         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2113         (ALL_FILETABS): Use compunit_filetabs.
2114         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2115         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2116
2117 2019-01-09  Tom Tromey  <tom@tromey.com>
2118
2119         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2120         (compunit_filetabs): New.
2121         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2122         compunit_filetabs.
2123         (info_sources_command, make_source_files_completion_list): Remove
2124         declaration.
2125         * symmisc.c (print_objfile_statistics, dump_objfile)
2126         (maintenance_print_symbols): Remove declaration.
2127         (maintenance_info_symtabs): Use compunit_filetabs.
2128         (maintenance_info_line_tables): Likewise.
2129         * source.c (select_source_symtab): Change local variable name.
2130         (forget_cached_source_info_for_objfile): Remove declaration.
2131         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2132         * objfiles.c (objfile_relocate1): Remove declaration.
2133         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2134         declaration.
2135         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2136         * coffread.c (coff_symtab_read): Remove declaration.
2137         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2138         compunit_filetabs.
2139
2140 2019-01-09  Tom Tromey  <tom@tromey.com>
2141
2142         * symtab.c (lookup_objfile_from_block)
2143         (find_pc_sect_compunit_symtab, search_symbols)
2144         (default_collect_symbol_completion_matches_break_on): Use
2145         objfile_compunits.
2146         * objfiles.h (ALL_COMPUNITS): Remove.
2147         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2148         * cp-support.c (add_symbol_overload_list_qualified): Use
2149         objfile_compunits.
2150         * ada-lang.c (ada_collect_symbol_completion_matches)
2151         (ada_add_global_exceptions): Use objfile_compunits.
2152
2153 2019-01-09  Tom Tromey  <tom@tromey.com>
2154
2155         * source.c (select_source_symtab)
2156         (forget_cached_source_info_for_objfile): Remove declaration.
2157         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2158         declaration.
2159         * maint.c (count_symtabs_and_blocks): Remove declaration.
2160         * cp-support.c (add_symbol_overload_list_qualified): Remove
2161         declaration.
2162         * coffread.c (coff_symtab_read): Remove declaration.
2163         * symtab.c (lookup_symbol_in_objfile_symtabs)
2164         (basic_lookup_transparent_type_1): Use objfile_compunits.
2165         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2166         (info_sources_command, search_symbols)
2167         (default_collect_symbol_completion_matches_break_on)
2168         (make_source_files_completion_list): Remove declaration.
2169         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2170         (ada_collect_symbol_completion_matches)
2171         (ada_add_global_exceptions): Remove declaration.
2172         * linespec.c (iterate_over_all_matching_symtabs): Use
2173         objfile_compunits.
2174         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2175         (class objfile_compunits): New.
2176         (ALL_COMPUNITS): Use objfile_compunits.
2177         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2178         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2179         objfile_compunits.
2180         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2181
2182 2019-01-09  Tom Tromey  <tom@tromey.com>
2183
2184         * symtab.c (search_symbols)
2185         (default_collect_symbol_completion_matches_break_on): Use
2186         objfile_msymbols.
2187         * ada-lang.c (ada_lookup_simple_minsym)
2188         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2189         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2190         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2191         objfile_msymbols.
2192         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2193         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2194         * objc-lang.c (find_methods): Use objfile_msymbols.
2195         (info_selectors_command, info_classes_command): Likewise.
2196         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2197         * objfiles.h (class objfile_msymbols): New.
2198         (ALL_OBJFILE_MSYMBOLS): Remove.
2199         (ALL_MSYMBOLS): Remove.
2200
2201 2019-01-09  Tom Tromey  <tom@tromey.com>
2202
2203         * common/next-iterator.h (next_adapter): Add Iterator template
2204         parameter.
2205         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2206         (class all_objfiles_safe): New.
2207         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2208         * objfiles.c (put_objfile_before): Update comment.
2209         (add_separate_debug_objfile): Likewise.
2210         (free_all_objfiles): Use all_objfiles_safe.
2211         (objfile_purge_solibs): Likewise.
2212
2213 2019-01-09  Tom Tromey  <tom@tromey.com>
2214
2215         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2216         (expand_symtab_containing_pc, lookup_static_symbol)
2217         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2218         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2219         all_objfiles.
2220         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2221         * breakpoint.c (create_overlay_event_breakpoint)
2222         (create_longjmp_master_breakpoint)
2223         (create_std_terminate_master_breakpoint)
2224         (create_exception_master_breakpoint): Use all_objfiles.
2225         * linux-thread-db.c (try_thread_db_load_from_pdir)
2226         (has_libpthread): Use all_objfiles.
2227         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2228         * linespec.c (iterate_over_all_matching_symtabs)
2229         (search_minsyms_for_name): Use all_objfiles.
2230         * maint.c (maintenance_info_sections): Use all_objfiles.
2231         * main.c (captured_main_1): Use all_objfiles.
2232         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2233         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2234         * guile/scm-pretty-print.c
2235         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2236         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2237         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2238         (maintenance_print_msymbols): Use all_objfiles.
2239         * source.c (select_source_symtab): Use all_objfiles.
2240         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2241         * symfile.c (remove_symbol_file_command)
2242         (expand_symtabs_matching, map_symbol_filenames): Use
2243         all_objfiles.
2244         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2245         all_objfiles.
2246         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2247         * objc-lang.c (find_methods): Use all_objfiles.
2248         * objfiles.c (have_partial_symbols, have_full_symbols)
2249         (have_minimal_symbols, qsort_cmp)
2250         (default_iterate_over_objfiles_in_search_order): Use
2251         all_objfiles.
2252         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2253         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2254         (maintenance_check_psymtabs): Use all_objfiles.
2255         (ALL_PSYMTABS): Remove.
2256         * compile/compile-object-run.c (do_module_cleanup): Use
2257         all_objfiles.
2258         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2259         * cp-support.c (add_symbol_overload_list_qualified): Use
2260         all_objfiles.
2261         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2262         Use all_objfiles.
2263         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2264         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2265         all_objfiles.
2266         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2267         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2268         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2269         Uses all_objfiles.
2270         * solib.c (solib_read_symbols): Use all_objfiles
2271
2272 2019-01-09  Tom Tromey  <tom@tromey.com>
2273
2274         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2275         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2276         all_objfiles.
2277         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2278         * symmisc.c (print_symbol_bcache_statistics)
2279         (print_objfile_statistics, maintenance_print_objfiles)
2280         (maintenance_info_symtabs, maintenance_check_symtabs)
2281         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2282         all_objfiles.
2283         * source.c (forget_cached_source_info): Use all_objfiles.
2284         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2285         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2286         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2287         * objfiles.c (update_section_map): Use all_objfiles.
2288         (shared_objfile_contains_address_p): Likewise.
2289         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2290         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2291
2292 2019-01-09  Tom Tromey  <tom@tromey.com>
2293
2294         * common/next-iterator.h: New file.
2295         * objfiles.h (class all_objfiles): New.
2296         (struct objfile_iterator): New.
2297
2298 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2299
2300         * NEWS: Move the description of the changed "frame", "select-frame",
2301          and "info frame" commands to the Changed commands section.
2302
2303 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2304
2305         * gdbtypes.c (check_stub_method_group): Remove handling of old
2306         mangling schemes.
2307         * linespec.c (find_methods): Likewise.
2308         * stabsread.c (read_member_functions): Likewise.
2309         * valops.c (search_struct_method): Likewise.
2310         (value_struct_elt_for_reference): Likewise.
2311         * NEWS: Mention this change.
2312
2313 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2314
2315         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2316         print_source_lines.
2317         * source.c (print_source_lines_base): Update line number check.
2318         (print_source_lines): New function.
2319         (source_lines_range::source_lines_range): New function.
2320         * source.h (class source_lines_range): New class.
2321         (print_source_lines): New declaration.
2322
2323 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2324
2325         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2326
2327 2019-01-08  Tom Tromey  <tom@tromey.com>
2328             Simon Marchi  <simon.marchi@ericsson.com>
2329
2330         PR gdb/24060
2331         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2332         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2333         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2334         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2335         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2336         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2337
2338 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2339
2340         * source.c (select_source_symtab): Move header comment to
2341         declaration in source.h.
2342         (forget_cached_source_info_for_objfile): Likewise.
2343         (forget_cached_source_info): Likewise.
2344         (identify_source_line): Likewise.
2345         * source.h (identify_source_line): Move declaration from symtab.h
2346         and add comment from source.c
2347         (print_source_lines): Likewise.
2348         (forget_cached_source_info_for_objfile): Likewise.
2349         (forget_cached_source_info): Likewise.
2350         (select_source_symtab): Likewise.
2351         (enum print_source_lines_flag): Move definition from symtab.h.
2352         * symtab.h (identify_source_line): Move declaration to source.h.
2353         (print_source_lines): Likewise.
2354         (forget_cached_source_info_for_objfile): Likewise.
2355         (forget_cached_source_info): Likewise.
2356         (select_source_symtab): Likewise.
2357         (enum print_source_lines_flag): Move definition to source.h.
2358         * tui/tui-hooks.c: Add 'source.h' include.
2359
2360 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2361
2362         * source.c (print_source_lines_base): Handle requests to print
2363         reverse line number sequences, and guard against empty lines
2364         string.
2365
2366 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2367
2368         * source.c (print_source_lines_base): Fix skip of '\r' if next
2369         character is '\n'.
2370
2371 2019-01-06  Tom Tromey  <tom@tromey.com>
2372
2373         * c-exp.y (struct c_parse_state) <macro_original_text,
2374         expansion_obstack>: New member.
2375         (macro_original_text, expansion_obstack): Remove globals.
2376         (scan_macro_expansion, scanning_macro_expansion)
2377         (finished_macro_expansion): Update.
2378         (scan_macro_cleanup): Remove.
2379         (yylex, c_parse): Update.
2380
2381 2019-01-06  Tom Tromey  <tom@tromey.com>
2382
2383         * c-exp.y (struct c_parse_state) <strings>: New member.
2384         (operator_stoken): Update.
2385
2386 2019-01-06  Tom Tromey  <tom@tromey.com>
2387
2388         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2389         (union type_stack_elt) <typelist_val>: Now a pointer to
2390         std::vector.
2391         (type_stack_cleanup): Don't declare.
2392         (push_typelist): Update.
2393         * parse.c (pop_typelist): Return a std::vector.
2394         (push_typelist): Take a std::vector.
2395         (follow_types): Update.  Do not free args.
2396         (type_stack_cleanup): Remove.
2397         * c-exp.y (struct c_parse_state): New.
2398         (cpstate): New global.
2399         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2400         (nonempty_typelist): Update.
2401         (func_mod): Create a new vector.
2402         (c_parse): Create a c_parse_state.
2403         (check_parameter_typelist): Do not delete params.
2404         (function_method): Update.  Do not delete type_list.
2405
2406 2019-01-06  Tom Tromey  <tom@tromey.com>
2407
2408         PR gdb/28155:
2409         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2410         check_typedef.
2411         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2412         (print_return_value): Likewise.
2413
2414 2019-01-05  Tom Tromey  <tom@tromey.com>
2415
2416         * contrib/cleanup_check.py: Remove.
2417         * contrib/gcc-with-excheck: Remove.
2418         * contrib/exsummary.py: Remove.
2419         * contrib/excheck.py: Remove.
2420
2421 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2422
2423         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2424         NULL. Initialize tpprev to NULL instead of assigning it
2425         to NULL on the next statement.
2426         * windows-nat.c (windows_delete_thread): Remove check for
2427         main_thread_id before printing thread exit notifications.
2428         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2429         Remove thread ID check against main_thread_id.
2430         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2431         windows_delete_thread.
2432         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2433
2434 2019-01-04  Tom Tromey  <tom@tromey.com>
2435
2436         * compile/compile.c (_initialize_compile): Use upper case for
2437         metasyntactic variables.
2438         * symmisc.c (_initialize_symmisc): Use upper case for
2439         metasyntactic variables.
2440         * psymtab.c (_initialize_psymtab): Use upper case for
2441         metasyntactic variables.
2442         * demangle.c (demangle_command): Use upper case for metasyntactic
2443         variables.
2444         (_initialize_demangler): Likewise.
2445         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2446         variables.
2447
2448 2019-01-03  Tom Tromey  <tom@tromey.com>
2449
2450         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2451
2452 2019-01-03  Tom Tromey  <tom@tromey.com>
2453
2454         * python/py-symtab.c (salpy_str): Update.
2455         (struct salpy_sal_object) <symtab>: Now a PyObject.
2456         (salpy_dealloc): Update.
2457         (del_objfile_sal): Use gdbpy_ref.
2458
2459 2019-01-03  Tom Tromey  <tom@tromey.com>
2460
2461         * python/py-type.c (convert_field): Use new_reference.  Return
2462         gdbpy_ref.
2463         (make_fielditem): Return gdbpy_ref.
2464         (typy_fields): Update.
2465         (typy_getitem): Update.
2466         (field_name): Return gdbpy_ref.  Use new_reference.
2467         (typy_iterator_iternext): Update.
2468
2469 2019-01-03  Tom Tromey  <tom@tromey.com>
2470
2471         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2472
2473 2019-01-03  Tom Tromey  <tom@tromey.com>
2474
2475         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2476         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2477         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2478         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2479         (pspy_set_type_printers): Likewise.
2480         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2481         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2482         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2483         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2484         (objfpy_set_type_printers): Likewise.
2485
2486 2019-01-03  Tom Tromey  <tom@tromey.com>
2487
2488         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2489         (gdbpy_print_stack): Use gdbpy_err_fetch.
2490         * python/python-internal.h (class gdbpy_err_fetch): New class.
2491         (class gdbpy_enter) <m_error_type, m_error_value,
2492         m_error_traceback>: Remove.
2493         <m_error>: New member.
2494         (gdbpy_exception_to_string): Don't declare.
2495         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2496         * python/py-value.c (convert_value_from_python): Use
2497         gdbpy_err_fetch.
2498         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2499         gdbpy_exception_to_string.
2500         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2501         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2502         gdbpy_err_fetch.
2503
2504 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2505
2506         * linux-nat.c (delete_lwp_cleanup): Delete.
2507         (struct lwp_deleter): New struct.
2508         (lwp_info_up): New typedef.
2509         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2510         lwp_info_up.
2511
2512 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2513
2514         * linux-fork.c (class scoped_switch_fork_info): New class.
2515         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2516
2517 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2518
2519         * valops.c (find_overload_match): Remove use of null_cleanup, and
2520         calls to do_cleanups.
2521
2522 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2523
2524         * compile/compile-cplus-types.c
2525         (compile_cplus_instance::decl_name): Handle changes to
2526         cp_func_name.
2527         * cp-support.c (cp_func_name): Update header comment, update
2528         return type.
2529         * cp-support.h (cp_func_name): Update return type in declaration.
2530         * valops.c (find_overload_match): Move temp_func local to top
2531         level of function and change its type.  Use temp_func to hold and
2532         delete temporary string obtained from cp_func_name.
2533
2534 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2535
2536         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2537         gdb::char_vector, remove cleanup, and update uses of `msg`.
2538
2539 2019-01-03  Jim Wilson  <jimw@sifive.com>
2540
2541         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2542
2543 2019-01-02  Tom Tromey  <tom@tromey.com>
2544
2545         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2546         (tdesc_parse_xml): Remove cleanups.
2547         * target-descriptions.h (make_cleanup_free_target_description):
2548         Don't declare.
2549         (target_desc_deleter): New struct.
2550         (target_desc_up): New typedef.
2551         * target-descriptions.c (target_desc_deleter::operator()): Rename
2552         from free_target_description.
2553         (make_cleanup_free_target_description): Remove.
2554
2555 2019-01-02  Tom Tromey  <tom@tromey.com>
2556
2557         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2558         constructor, destructor.
2559         (linespec_parser): Remove typedef.
2560         (~linespec_parser): Rename from linespec_parser_delete.
2561         (linespec_lex_to_end, linespec_complete_label)
2562         (linespec_complete): Update.
2563         (decode_line_full): Remove cleanups.
2564         (decode_line_1): Update.
2565
2566 2019-01-02  Tom Tromey  <tom@tromey.com>
2567
2568         * python/python-internal.h (inferior_to_inferior_object): Change
2569         return type.
2570         * python/py-exitedevent.c (create_exited_event_object): Update.
2571         * python/py-inferior.c (inferior_to_inferior_object): Return
2572         gdbpy_ref.
2573         (python_new_inferior, python_inferior_deleted)
2574         (thread_to_thread_object, delete_thread_object)
2575         (build_inferior_list, gdbpy_selected_inferior): Update.
2576         * python/py-infthread.c (create_thread_object): Update.  Also fail
2577         if inferior_to_inferior_object fails.
2578
2579 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2580
2581         * inferior.h (class inferior) <displaced_step_state>: New field.
2582         * infrun.h (struct displaced_step_state): Move here from
2583         infrun.c.  Initialize fields, add constructor.
2584         <inf>: Remove field.
2585         <reset>: New method.
2586         * infrun.c (struct displaced_step_inferior_state): Move to
2587         infrun.h.
2588         (displaced_step_inferior_states): Remove.
2589         (get_displaced_stepping_state): Adust.
2590         (displaced_step_in_progress_any_inferior): Adjust.
2591         (displaced_step_in_progress_thread): Adjust.
2592         (displaced_step_in_progress): Adjust.
2593         (add_displaced_stepping_state): Remove.
2594         (get_displaced_step_closure_by_addr): Adjust.
2595         (remove_displaced_stepping_state): Remove.
2596         (infrun_inferior_exit): Call displaced_step_state.reset.
2597         (use_displaced_stepping): Don't check for NULL.
2598         (displaced_step_prepare_throw): Call
2599         get_displaced_stepping_state.
2600         (displaced_step_fixup): Don't check for NULL.
2601         (prepare_for_detach): Don't check for NULL.
2602
2603 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2604
2605         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2606          in case of call that did not complete.
2607
2608 2019-01-02  Andrey Utkin  <autkin@undo.io>
2609
2610         * symfile.c (find_separate_debug_file): Fix search of debug files for
2611         remote debuggee.
2612
2613 2019-01-02  Tom Tromey  <tom@tromey.com>
2614
2615         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2616         indentation.
2617         * python/py-frame.c (frapy_older): Remove cast.
2618         (frapy_newer): Likewise.
2619         * python/py-breakpoint.c (local_setattro): Remove cast.
2620         * python/py-arch.c (archpy_name): Remove local variable.
2621         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2622
2623 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2624
2625         * unittests/basic_string_view/element_access/char/empty.cc:
2626         Fix year range in copyright header.
2627
2628 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2629
2630         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2631         Delete.
2632         <operator==>: Update with for removed field.
2633         <hash>: Likewise.
2634         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2635         <isa_features>: ...this.
2636         <abi_features>: New field.
2637         (riscv_isa_flen): Update comment.
2638         (riscv_abi_xlen): New declaration.
2639         (riscv_abi_flen): New declaration.
2640         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2641         isa_features.
2642         (riscv_abi_xlen): New function.
2643         (riscv_isa_flen): Update to get answer from isa_features.
2644         (riscv_abi_flen): New function.
2645         (riscv_has_fp_abi): Update to get answer from abi_features.
2646         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2647         xlen and flen.
2648         (riscv_call_info) <xlen, flen>: Update comment.
2649         (riscv_call_arg_struct): Remove invalid assertions
2650         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2651         is removed.
2652         (riscv_gdbarch_init): Gather isa features and abi features
2653         separately, ensure both match on the gdbarch when reusing an old
2654         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2655         a target with 64-bit float hardware.
2656
2657 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2658
2659         * source.c (search_command_helper): Stop reverse search
2660         when line 1 has been searched.
2661
2662 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2663
2664         * record-full.c (record_full_base_target::close): Rewrite
2665         record_full_core_buf_list free logic.
2666
2667 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2668
2669         * break-catch-syscall.c (print_one_catch_syscall): xfree
2670         the last text.
2671
2672 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2673
2674         * top.c (print_gdb_version): Update Copyright year in version
2675         message.
2676
2677 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2678
2679         Update copyright year range in all GDB files.
2680
2681 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2682
2683         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2684
2685 For older changes see ChangeLog-2018.
2686 \f
2687 Local Variables:
2688 mode: change-log
2689 left-margin: 8
2690 fill-column: 74
2691 version-control: never
2692 coding: utf-8
2693 End:
2694