Fixed SVACE issues and Code cleanup 21/126421/2 accepted/tizen/unified/20170427.015607 submit/tizen/20170424.014832 submit/tizen/20170426.084841
authorMilind Ramesh Murhekar <m.murhekar@samsung.com>
Fri, 21 Apr 2017 09:27:33 +0000 (14:57 +0530)
committerMilind Ramesh Murhekar <m.murhekar@samsung.com>
Fri, 21 Apr 2017 09:30:24 +0000 (15:00 +0530)
Description: This patch fixes the SVACE bugs
Below are the GWID which are fixed under this patch
207062, 207075

Change-Id: Iece0ca22ce61f3991082f4cdb807c7db9fc45da7
Signed-off-by: Milind Ramesh Murhekar <m.murhekar@samsung.com>
packaging/wifi-efl-ug.spec
sources/libraries/Common/common_utils.c

index 2d0514d..215512f 100644 (file)
@@ -1,6 +1,6 @@
 Name:          wifi-efl-ug
 Summary:       Wi-Fi UI Gadget for TIZEN
-Version:       1.0.230
+Version:       1.0.231
 Release:       1
 Group:         App/Network
 License:       Flora-1.1
index 9343d99..4c89624 100755 (executable)
@@ -833,11 +833,6 @@ static inline int __get_model_from_model_config_xml(const char *field, char **va
                        break;
        }
 
-       if (cur_ptr == NULL) {
-               xmlFreeDoc(xml_doc);
-               return -1;
-       }
-
        cur_ptr = cur_ptr->xmlChildrenNode;
        for (cur_node = cur_ptr; cur_node; cur_node = cur_node->next) {
                if (!xmlStrcmp(cur_node->name, (const xmlChar*)FEATURE_TAG)) {
@@ -857,6 +852,10 @@ static inline int __get_model_from_model_config_xml(const char *field, char **va
                for (cur_node = cur_ptr; cur_node; cur_node = cur_node->next) {
                        if (cur_node->type == XML_ELEMENT_NODE) {
                                node_name = (char *)xmlGetProp(cur_node, (const xmlChar*)"name");
+                               if (node_name == NULL) {
+                                       xmlFreeDoc(xml_doc);
+                                       return -1;
+                               }
 
                                if (!strncmp(node_name, field, strlen(node_name))) {
                                        node_value = (char *)xmlNodeListGetString(xml_doc, cur_node->xmlChildrenNode, 1);