Fix static analysis issues 48/138648/4
authorcskim <charles0.kim@samsung.com>
Thu, 13 Jul 2017 06:05:10 +0000 (15:05 +0900)
committercskim <charles0.kim@samsung.com>
Thu, 13 Jul 2017 06:34:12 +0000 (15:34 +0900)
Change-Id: Ic51e32111b4172714909ead56917c89837becd3d

src/mouse.c
src/popup.c

index 0348f3a..3ee0348 100644 (file)
@@ -137,7 +137,7 @@ static Eina_Bool _move_cb(void *data, int type, void *event)
        mouse_info.move_y = move->root.y;
 
        if (mouse_info.pressed == false) {
-               return ECORE_CALLBACK_RENEW;
+               return ECORE_CALLBACK_CANCEL;
        }
 
        return ECORE_CALLBACK_RENEW;
index b0c97e6..0ded9cc 100644 (file)
@@ -177,9 +177,13 @@ static char *_popup_set_name(Evas_Object *item)
        if (strlen(name) > STRSZE) {
                char *temp, *ellipsis = ELLIPSIS;
 
-               name = realloc(name, (STRSZE + strlen(ellipsis) + 1)*sizeof(char));
-               retv_if(NULL == name, NULL);
-
+               char *newly_alloc_name = realloc(name, (STRSZE + strlen(ellipsis) + 1)*sizeof(char));
+               if(NULL == newly_alloc_name)
+               {
+                       free(name);
+                       return NULL;
+               }
+               name = newly_alloc_name;
                temp = name + STRSZE;
 
                while (*ellipsis) *temp++ = *ellipsis++;