fix potential buffer overflow

diff --git a/device_engine.c b/device_engine.c
index 766df4b..919915f 100644 (file)
--- a/device_engine.c
+++ b/device_engine.c
@@ -160,7 +160,6 @@ static int sys_read_buf(char *file, char *buf)
        }
 
        r = read(fd, buf, BUFF_MAX);
-       DBG("!@#read[%s], value[%s], line[%d]", file, buf, __LINE__);
        if ((r >= 0) && (r <= BUFF_MAX))
                buf[r] = '\0';
        else {
@@ -170,7 +169,6 @@ static int sys_read_buf(char *file, char *buf)
 
        close(fd);
        INFO("read %s, value= %s", file, buf);
-       DBG("read[%s], value[%s], line[%d]", file, buf, __LINE__);
        return 0;
 }
 
@@ -198,7 +196,7 @@ static int sys_write_buf(char *file, char *buf)
 
 int sys_get_int(char *fname, int *val)
 {
-       char buf[BUFF_MAX];
+       char buf[BUFF_MAX+1];
 
        if (sys_read_buf(fname, buf) == 0) {
                *val = atoi(buf);
@@ -211,7 +209,7 @@ int sys_get_int(char *fname, int *val)
 
 char *sys_get_str(char *fname)
 {
-       char buf[BUFF_MAX];
+       char buf[BUFF_MAX+1];
        char *r = NULL;
 
        if (sys_read_buf(fname, buf) == 0)
@@ -222,7 +220,7 @@ char *sys_get_str(char *fname)
 
 int sys_set_int(char *fname, int val)
 {
-       char buf[BUFF_MAX];
+       char buf[BUFF_MAX+1];
        int r = -1;
        snprintf(buf, sizeof(buf), "%d", val);
 

diff --git a/packaging/device-manager-plugin-pinetrail.changes b/packaging/device-manager-plugin-pinetrail.changes
index 40fbdc2..0f22b25 100644 (file)
--- a/packaging/device-manager-plugin-pinetrail.changes
+++ b/packaging/device-manager-plugin-pinetrail.changes
@@ -1,2 +1,5 @@
+* Thu Aug 02 2012 Yan Yin <yan.yin@intel.com> build/2012-07-24.074803@797e50a
+- fix potential buffer overflow
+
 * Tue Jul 24 2012 Yan Yin <yan.yin@intel.com> e2ab75d
 - Initial device manager plugin for Pinetrail platform