Jaehyun Kim [Mon, 12 Dec 2022 06:18:05 +0000 (15:18 +0900)]
DA: Modify DHCP request retries count
Change-Id: Ib8a332412a954992d20d5f9db3fcd9d0f23eb9e4
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Jaehyun Kim [Mon, 12 Dec 2022 06:00:59 +0000 (15:00 +0900)]
DA: Fix build warnings
Change-Id: I7034b55da0b5c364ec5dbbc0395465e700dc3f75
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Jaehyun Kim [Mon, 12 Dec 2022 01:44:25 +0000 (10:44 +0900)]
Add exception handling for null best_bss
Change-Id: Idfed20c90265d4e3df4cd2011a46ff52a72f2872
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Jaehyun Kim [Wed, 7 Dec 2022 04:25:30 +0000 (13:25 +0900)]
Support PSK_SHA256 for ieee80211w
Change-Id: I4017d2b245a9a5a65fcbbd4ca6c31f45e98b77f2
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Jaehyun Kim [Mon, 31 Oct 2022 14:10:18 +0000 (23:10 +0900)]
DA: Reduce debug log
Don't print service sorting.
Change-Id: I23eab48c293b850a710596b220997afee54bca3d
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Jaehyun Kim [Mon, 31 Oct 2022 14:00:17 +0000 (23:00 +0900)]
DA: Skip initializing failed_bssids list when eapol failure case
This modification is to prevent attempts to connect to only one bssid continuously
during an eapol failure in a multi bssid environment.
Change-Id: I2f5d0dea895f0f3b39bd0e0b15c59db391973b10
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Jaehyun Kim [Mon, 31 Oct 2022 13:32:57 +0000 (22:32 +0900)]
DA: Fix crash issue
Change-Id: Ic46cbf033a7f9ff1b5149b9fceb08bb3cfe2a97a
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Jaehyun Kim [Mon, 31 Oct 2022 13:28:44 +0000 (22:28 +0900)]
DA: Standard error for customer self-diagnosis
Change-Id: Ie222bb43c0128362324db57554fb9bba3fa7f140
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Jaehyun Kim [Mon, 31 Oct 2022 13:03:14 +0000 (22:03 +0900)]
DA: Modify INS score source code
1. Modify wrong INS source code & add debug log
2. If INS score is same, align according to the signal strength.
Change-Id: I7dc469ab13c5dbf6bbae020ba711e5f15acd1fb4
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Jaehyun Kim [Mon, 31 Oct 2022 12:19:41 +0000 (21:19 +0900)]
DA: Change connection error type AUTH_FAILED to INVALID_KEY in case of SAE
Change connman_service_error type from CONNMAN_SERVICE_ERROR_AUTH_FAILED
to CONNMAN_SERVICE_ERROR_INVALID_KEY in case of SAE security type.
Change-Id: Ia276f8da2d83e845b7431a1b89d27fe939d01536
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Jaehyun Kim [Mon, 31 Oct 2022 12:14:22 +0000 (21:14 +0900)]
DA: Set ignore field as true when assoc fails
Change-Id: Icec37d4758a2637acb8b1c3586c1900747d806f4
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Jaehyun Kim [Mon, 31 Oct 2022 11:46:26 +0000 (20:46 +0900)]
DA: Add exception check for time logic
1. Ignore next time server if current time server string is empty.
2. Check time_updates_config before set time.
Change-Id: Ifd617686b9eb25d75350d0af3a0f592c7d85ffed
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Jaehyun Kim [Mon, 31 Oct 2022 11:07:34 +0000 (20:07 +0900)]
DA: Add DHCP state notify function
Change-Id: Ie4408b5db690133c74f05dcf3fb94b5dd8eee4df
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Jaehyun Kim [Sat, 29 Oct 2022 05:33:50 +0000 (14:33 +0900)]
Remove useless network path of the wifi interface when removing network
When removing a network, if the network path of the interface is not NULL
and has the same information as the network to be removed, it need to be removed.
Otherwise, when a connection to the same network is attempted later,
the connection may not work normally.
Change-Id: Ia1702c05bb19c581b31070fbc7741a846d87a6ee
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Jaehyun Kim [Fri, 30 Sep 2022 09:01:12 +0000 (18:01 +0900)]
Check dbus path before constructing AddNetwork message
>0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
>1 0xb6bf0788 in __GI_abort () at abort.c:79
>2 0xb6e63a9c in _dbus_abort () at dbus-sysdeps.c:93
>3 0xb6e58278 in _dbus_warn_check_failed (format=0xb6e69e1c "arguments to %s() were incorrect, assertion \"%s\" failed in file %s line %d.\nThis is normally a bug in some application using the D-Bus library.\n") at dbus-internals.c:281
>4 0xb6e58980 in _dbus_warn_return_if_fail (function=<optimized out>, assertion=<optimized out>, file=<optimized out>, line=line@entry=1582) at dbus-internals.c:936
>5 0xb6e47c7c in dbus_message_new_method_call (destination=0x51a004 "fi.w1.wpa_supplicant1", path=path@entry=0x6bebf8 "", iface=iface@entry=0x519fa8 "fi.w1.wpa_supplicant1.Interface", method=method@entry=0x51a4c8 "AddNetwork") at dbus-message.c:1582
>6 0x004bdbda in supplicant_dbus_method_call (path=0x6bebf8 "", interface=0x519fa8 "fi.w1.wpa_supplicant1.Interface", method=0x51a4c8 "AddNetwork", setup=0x4baf7d <interface_add_network_params>, function=0x4b985d <interface_add_network_result>, user_data=user_data@entry=0x6d05f0, caller=0x6d9900) at gsupplicant/dbus.c:508
>7 0x004b64d8 in decryption_request_reply (call=0x6b25c0, user_data=0x6d05f0) at gsupplicant/supplicant.c:7653
...
Change-Id: Ib65368a6a43c81376ae65bd5338d796bc7ad755c
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Jaehyun Kim [Mon, 19 Sep 2022 12:49:30 +0000 (21:49 +0900)]
Support ft-psk and ft-sae connection
Change-Id: I05d8d3934a8a75c874b41cb44654b7bc61b34060
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Jaehyun Kim [Fri, 16 Sep 2022 14:13:01 +0000 (23:13 +0900)]
Fix dereferencing issues
Change-Id: I8ec97355b5ebf673d792339a7d0a2911392d6a89
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Jaehyun Kim [Mon, 5 Sep 2022 12:39:51 +0000 (21:39 +0900)]
Fix crash when disabling connected wifi
This issue is caused by trying to access invalid
connman_network when wifi is disabled.
In this case, there is no need to reset the value.
Change-Id: I3137ba91a11086ae5e8f8f976dc52f84d62d4975
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Jaehyun Kim [Mon, 22 Aug 2022 17:15:07 +0000 (02:15 +0900)]
Maintain connection status when wifi roaming
When wifi roaming, the current connection status is maintained.
If the network is changed, the connection status is reset.
Change-Id: I2680030c849c712b7d7dc68f70397514484a7fc3
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Jaehyun Kim [Mon, 1 Aug 2022 11:34:24 +0000 (20:34 +0900)]
Check dbus path before constructing a new message
>0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50 --> glibc (rpm)
>1 0xf7248780 in __GI_abort () at abort.c:79 --> glibc (rpm)
>2 0xf74ba7ac in _dbus_abort () at dbus-sysdeps.c:93 --> dbus-libs (rpm)
>3 0xf74af0d0 in _dbus_warn_check_failed (format=0xf74c05fc "arguments to %s() were incorrect, assertion \"%s\" failed in file %s line %d.\nThis is normally a bug in some application using the D-Bus library.\n") at dbus-internals.c:281 --> dbus-libs (rpm)
>4 0xf74af7d8 in _dbus_warn_return_if_fail (function=<optimized out>, assertion=<optimized out>, file=<optimized out>, line=line@entry=1582) at dbus-internals.c:936 --> dbus-libs (rpm)
>5 0xf749eba0 in dbus_message_new_method_call (destination=0xaacc16a4 "fi.w1.wpa_supplicant1", path=path@entry=0xac126b78 "", iface=iface@entry=0xaacc1648 "fi.w1.wpa_supplicant1.Interface", method=method@entry=0xaacc1b40 "AddNetwork") at dbus-message.c:1582 --> dbus-libs (rpm)
>6 0xaac671d8 in supplicant_dbus_method_call (path=0xac126b78 "", interface=0xaacc1648 "fi.w1.wpa_supplicant1.Interface", method=0xaacc1b40 "AddNetwork", setup=0xaac64605 <interface_add_network_params>, function=0xaac62fb1 <interface_add_network_result>, user_data=user_data@entry=0xac125138, caller=0xac13ef30) at gsupplicant/dbus.c:505 --> connman (rpm)
>7 0xaac5faee in decryption_request_reply (call=0xac12b080, user_data=0xac125138) at gsupplicant/supplicant.c:7629 --> connman (rpm)
Change-Id: I87558f1894607bea53ecf7b3602f16d1e5aae5ac
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Jaehyun Kim [Sun, 5 Jun 2022 11:39:41 +0000 (20:39 +0900)]
Fix derefrencing of invalid pointer
Change-Id: I1414eb584a0644423aef07511f68c0be4b63c911
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Jaehyun Kim [Sat, 4 Jun 2022 14:55:17 +0000 (23:55 +0900)]
Try to connect to another bssid in AUTH or ASSOCICATED failure case
When attempting to connect to an AP with multiple bssids,
if it fails in the AUTHENTICATING or ASSOCIATED state,
the connection continues to be attempted with the same bssid.
In this case, it has been modified to try to connect to another bssid.
Change-Id: Ied521e01c71e8c6c916d56dc825578d8edd20e0c
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Seung-Woo Kim [Tue, 24 May 2022 09:59:21 +0000 (18:59 +0900)]
wispr: Prevent use-after-free from __connman_wispr_stop()
From __connman_wispr_stop(), list element wispr_portal freed by
g_hash_table_remove() is accessed. Prevent the use-after-free by
accessing the list element before free.
Change-Id: I17fdb38c1d9a0f8dd2980c33d3f78f319f504ed6
Jaehyun Kim [Wed, 25 May 2022 04:24:41 +0000 (13:24 +0900)]
Fix memory leak when loading global settings
Change-Id: Ie7d00c2f856d2d6d8e7ea86d17c013e787259680
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Jaehyun Kim [Thu, 12 May 2022 07:59:13 +0000 (16:59 +0900)]
Reinitialize the va_list when reusing it
Change-Id: I4ae7c752c09f328cba522b25f8acb05e80425cef
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Jaehyun Kim [Thu, 14 Apr 2022 04:25:20 +0000 (13:25 +0900)]
Add main.conf for robot profile
Change-Id: Ifa2f0c8ab1bbb5925bc468206ed0fe0c8b743489
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Niraj Kumar Goit [Thu, 17 Mar 2022 06:48:56 +0000 (12:18 +0530)]
Fix EAP-TLS Wi-Fi connection issue
Change-Id: I70fd374d89488e1d30f489356a5d8a4041c5f491
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
Anjali Nijhara [Mon, 14 Mar 2022 11:10:24 +0000 (16:40 +0530)]
Fix wifi connection issue post invalid-key error occurs.
Change-Id: I7a9c7184502a3a74a8be6e92be7c08d41b878612
Anjali Nijhara [Thu, 3 Mar 2022 06:33:03 +0000 (12:03 +0530)]
Modified vpn/vpn-dbus.conf file
Change-Id: Ic2dbd5445cf89d8ad7e54787d14f4ff690b9c89c
Signed-off-by: Anjali Nijhara <a.nijhara@samsung.com>
Niraj Kumar Goit [Thu, 17 Feb 2022 16:13:13 +0000 (21:43 +0530)]
Merge tag 'upstream/1.40' into tizen.
Change-Id: I4ed89827d776db6eeec11878bc1cd0cd6c5e1e80
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
Signed-off-by: Anjali Nijhara <a.nijhara@samsung.com>
Niraj Kumar Goit [Tue, 15 Feb 2022 04:53:07 +0000 (10:23 +0530)]
Imported Upstream version 1.40
Change-Id: Id3e405d088ee3fb19fd0ca049e1cb7f812b40fca
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
Jaehyun Kim [Mon, 14 Feb 2022 10:16:29 +0000 (19:16 +0900)]
Add support to get PMF information
Change-Id: I7286c346750504175e24cbb569404e586b309a85
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Jaehyun Kim [Fri, 21 Jan 2022 08:38:39 +0000 (17:38 +0900)]
Fix NULL dereferencing
Change-Id: I7d49d35c42e7550f42007935859609adbb938d51
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Jaehyun Kim [Thu, 13 Jan 2022 07:12:30 +0000 (16:12 +0900)]
Add support for handling wifi authentication failure
Change-Id: I770e67fa3ed17758c745469cc51ecdc08d591708
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Jaehyun Kim [Fri, 7 Jan 2022 03:12:15 +0000 (12:12 +0900)]
Fix dereference after null check
Change-Id: If0c7f97ce58436c6cce1debf92f2fafb407ff9fe
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Jaehyun Kim [Thu, 6 Jan 2022 05:38:04 +0000 (05:38 +0000)]
Merge "Remove libbpf code from connMan" into tizen
Seonah Moon [Wed, 5 Jan 2022 01:36:03 +0000 (10:36 +0900)]
Enable ipv6 again after removing autoconfigured address
Until now, ipv6 has been disabled to remove autoconfigured addresses quickly
when wifi disconnecting.
However, as a result, the ipv6 link local address of wlan0 was erased,
which later affected the operation of using wlan0 like softap.
This patch restores ipv6 for consistency.
Change-Id: I7cf2790d39f62579b59083d6abb136763202b2bd
Niraj Kumar Goit [Tue, 4 Jan 2022 05:56:41 +0000 (11:26 +0530)]
Remove libbpf code from connMan
Change-Id: I63ce1f9f574b53b93da5dac9ff34031e409c8a98
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
Anjali Nijhara [Thu, 30 Dec 2021 06:46:10 +0000 (12:16 +0530)]
Fix WPA3 Multi-bssid Issue
Change-Id: I30167b693493e4a2b260b44cac4819bc40aefd80
Jaehyun Kim [Tue, 28 Dec 2021 13:41:31 +0000 (22:41 +0900)]
Change the roaming scan interval
If no AP is found to roam, change the scan interval
to minimize performance degradation due to frequent scans.
Change-Id: I1d655fa0d2215358531f772b6d697e537ed3a2d5
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Jaehyun Kim [Mon, 20 Dec 2021 03:11:43 +0000 (12:11 +0900)]
Start wifi roaming when better BSS is found
If better BSS is found after roaming scan, roaming starts.
Change-Id: I9812f3a0205021e1cecb9696ebc29947fd44dae4
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Jaehyun Kim [Sun, 19 Dec 2021 11:32:46 +0000 (11:32 +0000)]
Merge "Start scan for wifi roaming when SNR and signal are weakened" into tizen
Niraj Kumar Goit [Thu, 16 Dec 2021 05:41:50 +0000 (11:11 +0530)]
gdhcp: Avoid reading invalid data in dhcp_get_option
Reference:
https://git.kernel.org/pub/scm/network/connman/connman.git/commit/?id=
58d397ba74873384aee449690a9070bacd5676fa
Change-Id: I44c6e1f0448ed8fb5b1955da6458fe67c8ff56cb
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
Jaehyun Kim [Wed, 8 Dec 2021 01:41:05 +0000 (01:41 +0000)]
Merge "service: Add a new property 'SecurityList'" into tizen
Jaehyun Kim [Wed, 8 Dec 2021 01:40:56 +0000 (01:40 +0000)]
Merge "Use the default logic when not using INS" into tizen
Jaehyun Kim [Tue, 7 Dec 2021 07:39:34 +0000 (07:39 +0000)]
Merge "Fix an incorrect value being used for signal score calculation" into tizen
Jaehyun Kim [Mon, 6 Dec 2021 17:30:13 +0000 (02:30 +0900)]
service: Add a new property 'SecurityList'
A property has been added
to get the list of supported security methods
Change-Id: I8dda00ae4cbb924436cec53acbf8693a6ef630fb
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Jaehyun Kim [Fri, 3 Dec 2021 09:48:15 +0000 (18:48 +0900)]
Use the default logic when not using INS
1. Use signal strength for bssid sorting
2. Send a signal when service->connect_reason is changed
Change-Id: Ia7b1598f9de34440ae1cad5b773784ca769603e4
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Jaehyun Kim [Thu, 2 Dec 2021 05:26:41 +0000 (05:26 +0000)]
Merge "Use TIZEN_EXT_INS for INS related code" into tizen
Jaehyun Kim [Mon, 18 Oct 2021 10:24:51 +0000 (19:24 +0900)]
Fix an incorrect value being used for signal score calculation
Change-Id: Ie09830257b804efdfb6990b9ea7030ba497ac542
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Jaehyun Kim [Fri, 12 Nov 2021 06:15:06 +0000 (15:15 +0900)]
Register with system bus in container environment
Change-Id: I5fe36fdce42ffca6f3f6587923b42d4b5fec61d4
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Jaehyun Kim [Thu, 11 Nov 2021 09:03:50 +0000 (09:03 +0000)]
Merge "Disabled in container environment" into tizen
cheoleun moon [Tue, 9 Nov 2021 07:56:05 +0000 (16:56 +0900)]
Add dbus configuration for robot profile
Change-Id: If05b36fbbbb58a428d9c5b2c01da8a4d4892e3e5
Jaehyun Kim [Fri, 29 Oct 2021 10:16:39 +0000 (19:16 +0900)]
Disabled in container environment
Disable the container's network daemons to avoid conflicts
because they use the same network namespace.
Change-Id: I0e19fc7df608df39f5936f3082858f6f16415f3d
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Jaehyun Kim [Fri, 29 Oct 2021 07:08:46 +0000 (16:08 +0900)]
Remove net-config dependency
Change-Id: I28e301a36dbf59cf529fe9c945a4c6278357d77b
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Jaehyun Kim [Fri, 29 Oct 2021 06:56:00 +0000 (06:56 +0000)]
Merge "Update settings when device information in device_list is changed" into tizen
Nishant Chaprana [Mon, 25 Oct 2021 11:39:59 +0000 (17:09 +0530)]
Use TIZEN_EXT_INS for INS related code
Change-Id: I70f6722e1dcd8898eab2c504e377c65f425461e1
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
Nishant Chaprana [Mon, 18 Oct 2021 07:35:42 +0000 (13:05 +0530)]
Updated libbpf.so to link with libelf.so.1
Change-Id: Id2328db95c05e74cfdd7baaa4ff5476181b3a601
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
Jaehyun Kim [Mon, 18 Oct 2021 07:30:41 +0000 (16:30 +0900)]
Update settings when device information in device_list is changed
Modified to update enabled device information in settings
when the powered value of each device in device_list is changed.
Change-Id: I3ed4f236d747b9f979b23da19edbe1c248783f54
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Jaehyun Kim [Fri, 15 Oct 2021 11:59:35 +0000 (20:59 +0900)]
Fix incorrect handling in multi-interface environment
1. Modified to save enabled device information
in settings after device_list is updated.
2. Modified to save enabled device information
in settings only for wifi technology.
Change-Id: I1b05319adcd3fa7796e764912c9369a5ac28ab7e
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Jaehyun Kim [Mon, 4 Oct 2021 16:09:08 +0000 (01:09 +0900)]
Start scan for wifi roaming when SNR and signal are weakened
If SNR is less than 20 or RSSI level is less than 3,
scan for BSS transition is started.
Change-Id: I69c1e3e9a42ddb5f6087d580ff2c15c7086317d2
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Jaehyun Kim [Mon, 27 Sep 2021 06:47:38 +0000 (06:47 +0000)]
Merge "Reply all multiple/simultaenous SetDevicePower method call" into tizen
Nishant Chaprana [Fri, 24 Sep 2021 13:05:37 +0000 (18:35 +0530)]
Reply all multiple/simultaenous SetDevicePower method call
This patch fixes an issue where Multiple/Simultaenous SetDevicePower
method calls are made and reply is sent to only last dbus caller.
Change-Id: I61e1f5e5b8645dee41910a1b6ea51a405e6024a4
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
Niraj Kumar Goit [Thu, 23 Sep 2021 08:01:50 +0000 (13:31 +0530)]
Update connman settings for single device as well
Change-Id: Ic1ee92050bebd631d1738b9b68152052589e3e77
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
Nishant Chaprana [Mon, 20 Sep 2021 07:26:32 +0000 (12:56 +0530)]
Fix: Memory leak issue when tokenizing string
Change-Id: I71e88bb35384cf919263fa5dda8c4f0f06be6ef2
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
Jaehyun Kim [Thu, 9 Sep 2021 09:07:45 +0000 (18:07 +0900)]
Add support of bpf
Change-Id: Iaa5566a1be143ede38832cdd8639111fc26b4586
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Niraj Kumar Goit [Thu, 9 Sep 2021 09:34:10 +0000 (15:04 +0530)]
Enable Downgrade dbus method.
When offline is detected in device, downgrade service state to ready
and start online check in connman.
Change-Id: Ic5abf9050c51b853ee36fa8067b221c3e9c63eec
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
Jaehyun Kim [Wed, 8 Sep 2021 12:44:57 +0000 (21:44 +0900)]
Fix resource leak
Change-Id: Ic3c9199d0dac7e614743043cdeb5ad1616eb1aa1
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Jaehyun Kim [Wed, 8 Sep 2021 06:51:07 +0000 (06:51 +0000)]
Merge "Fix build failure when tizen-maintain-online feature is enabled" into tizen
Niraj Kumar Goit [Mon, 16 Aug 2021 12:15:49 +0000 (17:45 +0530)]
Fix Crash in connman-vpnd in reboot scenario when config file is present
Change-Id: I3cfccf9f53bfbd92974e1dbba65a6952f21f6c19
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
Jaehyun Kim [Wed, 8 Sep 2021 06:45:19 +0000 (06:45 +0000)]
Merge "wireguard: Add routes for allowedIPs" into tizen
Jaehyun Kim [Wed, 8 Sep 2021 06:45:07 +0000 (06:45 +0000)]
Merge "wireguard: Save plugin related settings in config file" into tizen
Jaehyun Kim [Wed, 8 Sep 2021 06:44:53 +0000 (06:44 +0000)]
Merge "vpn: Make domain parameter optional" into tizen
Jaehyun Kim [Wed, 8 Sep 2021 06:44:35 +0000 (06:44 +0000)]
Merge "Enable Wireguard VPN Plugin" into tizen
Jaehyun Kim [Wed, 8 Sep 2021 06:44:16 +0000 (06:44 +0000)]
Merge "wireguard: Copy interfance names obeying lengths rules" into tizen
Jaehyun Kim [Wed, 8 Sep 2021 06:44:05 +0000 (06:44 +0000)]
Merge "vpn: Export vpn_ipconfig_foreach as linker symbol" into tizen
Jaehyun Kim [Wed, 8 Sep 2021 06:43:51 +0000 (06:43 +0000)]
Merge "wireguard: Fix struct sockaddr usage" into tizen
Jaehyun Kim [Wed, 8 Sep 2021 06:43:40 +0000 (06:43 +0000)]
Merge "wireguard: Regular reresolve endpoint address" into tizen
Nishant Chaprana [Wed, 4 Aug 2021 11:45:01 +0000 (17:15 +0530)]
wireguard: Add routes for allowedIPs
Change-Id: Iad4c994dc7e40589f17db7c1b590cf7673b21bc0
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
Nishant Chaprana [Mon, 6 Sep 2021 11:10:36 +0000 (16:40 +0530)]
Fix build failure when tizen-maintain-online feature is enabled
Below are the build fail logs when tizen-maintain-online feature is enabled in spec file.
======================================================================================
[ 37s] src/service.c: At top level:
[ 37s] src/service.c:9432:17: error: redefinition of 'redo_wispr_ipv4'
[ 37s] 9432 | static gboolean redo_wispr_ipv4(gpointer user_data)
[ 37s] | ^~~~~~~~~~~~~~~
[ 37s] src/service.c:9413:17: note: previous definition of 'redo_wispr_ipv4' was here
[ 37s] 9413 | static gboolean redo_wispr_ipv4(gpointer user_data)
[ 37s] | ^~~~~~~~~~~~~~~
[ 37s] src/service.c: In function 'service_connect':
=====================================================================================
Change-Id: I1516358e55bba73af6383a8f7c8cc29c74f736fc
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
Jaehyun Kim [Thu, 2 Sep 2021 02:51:56 +0000 (11:51 +0900)]
Fix referencing incorrect bssid_list
Change-Id: Ie8cc971deb699250f9d6fbbbb1d37ed4ecf3fbf1
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Jaehyun Kim [Thu, 2 Sep 2021 01:26:57 +0000 (10:26 +0900)]
Fix NULL pointer dereference
Thread 1 (LWP 13957):
>0 count_assoc_reject (key=0x0, value=0x0, user_data=0xbe0a3928) at src/service.c:843 --> connman (rpm)
>1 0xb6654674 in g_hash_table_foreach (hash_table=0x533200, func=0x4700ad <count_assoc_reject>, user_data=user_data@entry=0xbe0a3928) at ../glib/ghash.c:2056 --> libglib (rpm)
>2 0x0047bf9a in update_assoc_reject (service=0x4fb2a0, service=0x4fb2a0) at src/service.c:857 --> connman (rpm)
>3 __connman_service_update_from_network (network=network@entry=0x50d6a0) at src/service.c:11004 --> connman (rpm)
>4 0x0046a9f4 in connman_network_set_group (network=network@entry=0x50d6a0, group=group@entry=0x560ff8 "") at src/network.c:1587 --> connman (rpm)
>5 0x0044f12c in network_added (supplicant_network=0x51d430) at plugins/wifi.c:5031 --> connman (rpm)
>6 0x004516ba in callback_network_added (network=<optimized out>) at gsupplicant/supplicant.c:828 --> connman (rpm)
>7 scan_network_update (iter=<optimized out>, user_data=0x4f0380) at gsupplicant/supplicant.c:3790 --> connman (rpm)
Change-Id: I2f6e86c492dbc621b1c9f48506e8a89326568664
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Jaehyun Kim [Wed, 18 Aug 2021 08:02:06 +0000 (17:02 +0900)]
Use SNR and estimated throughput for BSS scoring
Change-Id: Ie80ad47361166cd3b22a430111dda5c91791dca2
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Nishant Chaprana [Wed, 4 Aug 2021 08:08:44 +0000 (13:38 +0530)]
wireguard: Save plugin related settings in config file
Change-Id: I76d12fa347d1211958463ccf38a043a0c6272ece
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
Jaehyun Kim [Mon, 19 Jul 2021 07:36:36 +0000 (16:36 +0900)]
Added a dbus property 'TimeUpdated'
A property has been added to indicate
whether the time has been updated by NTP.
Change-Id: I86b8a0c2df377168f98656618efd82bb7da91800
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Nishant Chaprana [Thu, 15 Jul 2021 06:04:16 +0000 (11:34 +0530)]
vpn: Make domain parameter optional
There is no technical requirement to provide the domain name. Thus,
make the domain paremeter optional.
Reported by Christian Hewitt
Upstream Patch: https://git.kernel.org/pub/scm/network/connman/connman.git/patch/?id=
82699007fa89e26206771047d8cbb7c160fd2990
Change-Id: Iac21532e3e310d67c633874a95566413beb4b3a4
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
Nishant Chaprana [Tue, 6 Jul 2021 12:15:42 +0000 (17:45 +0530)]
Enable Wireguard VPN Plugin
Change-Id: Ic1edd8f5ea13e965ecd57499b51b8652604f5f71
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
Daniel Wagner [Mon, 5 Apr 2021 15:25:27 +0000 (17:25 +0200)]
wireguard: Copy interfance names obeying lengths rules
gcc points out the destination buffer has the same size the specified
bound for the string.
warning: ‘__builtin_strncpy’ specified bound 16 equals destination size [-Wstringop-truncation]
Let's make sure we do not overflow the buffer (should not happen as
the names are provide by the kernel and hence should fit).
Change-Id: I1e8818f0820ffb32083e14cb88e4919fd8b12798
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
Daniel Wagner [Fri, 11 Dec 2020 17:02:41 +0000 (18:02 +0100)]
vpn: Export vpn_ipconfig_foreach as linker symbol
Commit
95b25140bec7 ("vpn: Add WireGuard support") introduced
a plugin dependency to __vpn_ipconfig_foreach. Because the linker does
not export the prefixed functions, we need to rename it to
vpn_ipconfig_foreach in order to export the linker symbol.
Change-Id: I105159739dece4a675fa074ef304c6fd4d7b88bf
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
Daniel Wagner [Fri, 9 Oct 2020 07:28:00 +0000 (09:28 +0200)]
wireguard: Fix struct sockaddr usage
wg_dns_reresolve_cb() tries to read 16 bytes from the addr variable in
case of IPv6 but struct sockaddr has size of 8 bytes. Introduce a
helper struct containing IPv4 and IPv6 sockaddr as superset of all IP
based sockaddr.
This helper struct is identically to the 'union endpoint' in
wireguard.h. But we don't want to touch this header file as it is 100%
copy from the upstream WireGuard project.
Fixes:
90592f7a5835 ("wireguard: Regular reresolve endpoint address")
Change-Id: I2b262e61e52c795ab0cab4b206bd25df8ae57738
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
Daniel Wagner [Sun, 22 Mar 2020 19:50:52 +0000 (20:50 +0100)]
wireguard: Regular reresolve endpoint address
In case the WireGuard endpoint is hosted on a dynamic IP address, the
endpoint might change during runtime. Reresolve the endpoint on a
regular basis and update the WireGuard device when it IP address has
changed.
Reported by Christian Hewitt
Change-Id: Ice3b554a064585fb03ae8a7a89baccbe53e8576b
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
Jaehyun Kim [Mon, 5 Jul 2021 13:46:19 +0000 (22:46 +0900)]
Use the last updated MAC address before turning on wifi
MAC randomization does not work properly when there are multiple wifi interfaces
or in some devices that do not create a .mac.info file.
So, to solve this problem, a permanent MAC address that is set before wifi up is used.
If a permanent MAC address is in built-in physical device,
it's hardly get it at an initial creation.
So, if there is a MAC address updated from netlink before wifi is on, it is used.
* MAC randomization works only when wifi is turned on.
Change-Id: Ia7a9ad0affaa6deca974199100a56e7378b6c195
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Jaehyun Kim [Thu, 10 Jun 2021 09:20:00 +0000 (18:20 +0900)]
Fix memory leaks and dereference without null check
Change-Id: I7accd1386302c26e5bdfa8aee224fe60defc50af
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Jaehyun Kim [Thu, 10 Jun 2021 09:17:25 +0000 (18:17 +0900)]
Check the reply of SignalPoll method correctly
Change-Id: Id48cb699743e62484fac775c7348c34f1e80ac8f
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Jaehyun Kim [Mon, 17 May 2021 07:20:43 +0000 (16:20 +0900)]
Added dbus method 'GetConnectedService'
CAPI is fetching the full list of services
and looking for the service that is connected,
but this is an inefficient way,
so a dbus method to provide that information is added in connman.
Change-Id: I825682b3a1c01de3926145df499321ef161c4af7
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
Nishant Chaprana [Tue, 18 May 2021 09:39:46 +0000 (15:09 +0530)]
Remove wrong rules from connman dbus conf
MacPolicy, PreassocMacPolicy and RandomMacLifetime are properties
of technology interface and method rules cannot be applied for them.
Change-Id: I5dd381d1fac44f23f62f5cf1a1b9cccf859ffec8
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
Nishant Chaprana [Tue, 18 May 2021 09:38:42 +0000 (15:08 +0530)]
Add TIZEN_EXT macro to Tizen specific code
Change-Id: I322c8866eee025d868593a5110186fe581b3d939
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
Niraj Kumar Goit [Tue, 18 May 2021 07:54:27 +0000 (13:24 +0530)]
Added support to get country-code.
Change-Id: I880450f406c48490f5952452f0e586ca4d0d3c9e
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
Niraj Kumar Goit [Wed, 12 May 2021 14:26:20 +0000 (19:56 +0530)]
Added support to set country-code.
Change-Id: I6919f3ca4a794eeee7d75a3824c0fc3a22031d06
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
Jaehyun Kim [Fri, 7 May 2021 13:39:18 +0000 (22:39 +0900)]
Modified to handle WPA3/WPA2 mixed mode as WPA3-SAE
Change-Id: Ib9d5240a4673f08f65dd13db3eb59bbb1b4da80d
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>