Fix dereference after null check 40/269040/2 accepted/tizen/unified/20220114.130209 submit/tizen/20220111.044041
authorJaehyun Kim <jeik01.kim@samsung.com>
Fri, 7 Jan 2022 03:12:15 +0000 (12:12 +0900)
committerJaehyun Kim <jeik01.kim@samsung.com>
Fri, 7 Jan 2022 03:20:30 +0000 (12:20 +0900)
Change-Id: If0c7f97ce58436c6cce1debf92f2fafb407ff9fe
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
plugins/wifi.c

index 7c15996..3b709d8 100755 (executable)
@@ -2282,7 +2282,10 @@ static void scan_callback(int result, GSupplicantInterface *interface,
                connman_device_unref(device);
 
 #if defined TIZEN_EXT
-       if (wifi && wifi->scan_pending_network && result != -EIO) {
+       if (!wifi)
+               goto done;
+
+       if (wifi->scan_pending_network && result != -EIO) {
                network_connect(wifi->scan_pending_network);
                wifi->scan_pending_network = NULL;
                connman_network_set_connecting(wifi->network);
@@ -4156,9 +4159,10 @@ static void signalpoll_callback(int result, int maxspeed, int strength,
 
        if (need_bss_transition(freq, snr, strength)) {
                device = connman_network_get_device(network);
-               if (device)
-                       interface = connman_device_get_string(device, "Interface");
+               if (!device)
+                       goto done;
 
+               interface = connman_device_get_string(device, "Interface");
                bssid = connman_network_get_bssid(network);
                snprintf(bssid_str, WIFI_BSSID_STR_LEN, MACSTR, MAC2STR(bssid));
                __connman_technology_notify_roaming_state(interface, "required", bssid_str, NULL);