Eunki, Hong [Tue, 18 Jul 2023 05:29:39 +0000 (14:29 +0900)]
Fix coverity issues (uint32_t overflow + size_t to int32_t)
Change-Id: I51fb4a98a5cdb4f93cf3939ede02d576cff2bc36
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Heeyong Song [Tue, 18 Jul 2023 05:13:29 +0000 (05:13 +0000)]
Merge "Fix coverity issue" into devel/master
jmm [Fri, 14 Jul 2023 09:02:44 +0000 (18:02 +0900)]
Remove external resources lazy.
Since we don't increase & decrease the reference count of ExternalResources during
LoadTexture() API, It can be happened that some TextureId validation failed.
For example of dali://2,
ImageUrl::New() // refcount : 1
ImageVisual::Initialize() // refcount : 2
~ImageVisual
- RemoveExternalTexture("dali://2"); // refcount : 1
- RequestRemove(2) // still refcount : 1
~ImageUrl // now, refcount : 0
ImageVisual()
LoadTexture() //< New generated texture will use TextureId as 2, with refcount 1
== Process() ==
Remove(2) // Now, TextureId 2's refcount is 0! load cancel.
This patch make we only remove normal texture cache, instead of ExternalResource
Change-Id: Ia735770a02c231fa79af40a1e5926aab11358b71
Signed-off-by: jmm <j0064423.lee@samsung.com>
Richard Huang [Fri, 14 Jul 2023 11:35:48 +0000 (12:35 +0100)]
DALi Version 2.2.35
Change-Id: I9a69b415abd9fa45345a3a65354b489624251db0
Heeyong Song [Fri, 14 Jul 2023 09:29:41 +0000 (18:29 +0900)]
Fix coverity issue
Change-Id: I162997b9d8841fe11d85545b87c63fbfbfce9ca7
Heeyong Song [Thu, 13 Jul 2023 07:49:31 +0000 (16:49 +0900)]
(Vector) Fix invalid callback issue
Do not execute a callback with lock
Reset callback pointers after removing
Change-Id: I1f617af4ee89e43c8ab891efbd0beaea14feaea1
Eunki Hong [Thu, 13 Jul 2023 00:07:14 +0000 (00:07 +0000)]
Merge "Fix more compile error/warnings for gcc-13" into devel/master
Seungho Baek [Tue, 11 Jul 2023 09:20:35 +0000 (18:20 +0900)]
Change some precision of shader variables to highp
- There are some visual artifact to render 3D object in case of adding Directional Light.
- Some variable's precision is too low.
- This patch changes minimum number of variable's precision to highp
Change-Id: I0ff1c30bb3f0eb837434f0dc61d2a461383dfbd2
Signed-off-by: Seungho Baek <sbsh.baek@samsung.com>
Adeel Kazmi [Mon, 10 Jul 2023 16:05:31 +0000 (17:05 +0100)]
Fix SVACE error in scene-definition.cpp
Change-Id: Ia8eab4a10711d0d18221a5212b799dbd7adfb7d5
Seungho BAEK [Mon, 10 Jul 2023 01:15:12 +0000 (01:15 +0000)]
Merge "Apply Light using Shader Manager" into devel/master
Eunki Hong [Fri, 7 Jul 2023 00:13:59 +0000 (09:13 +0900)]
Fix more compile error/warnings for gcc-13
Change-Id: Iee4002a0e2007daf281400ec07a3ffc776e46468
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
David Steele [Fri, 7 Jul 2023 11:13:55 +0000 (11:13 +0000)]
Merge "DALi Version 2.2.34" into devel/master
David Steele [Fri, 7 Jul 2023 11:00:59 +0000 (12:00 +0100)]
DALi Version 2.2.34
Change-Id: I4ec226a069b349124b148b771aa292c7ab1b96cc
seungho baek [Wed, 28 Jun 2023 13:23:07 +0000 (22:23 +0900)]
Apply Light using Shader Manager
Change-Id: I007842c1e6e1c46dc680acbb1306c70d1defb148
Signed-off-by: seungho baek <sbsh.baek@samsung.com>
Eunki Hong [Fri, 7 Jul 2023 08:13:32 +0000 (08:13 +0000)]
Merge "Fix comments for MotionData" into devel/master
Seungho BAEK [Fri, 7 Jul 2023 06:15:39 +0000 (06:15 +0000)]
Merge "Makes Models use common shader manager" into devel/master
David Steele [Thu, 6 Jul 2023 16:19:17 +0000 (16:19 +0000)]
Merge "Updated FrameCallback to return value to specify whether we should keep rendering" into devel/master
Richard [Thu, 6 Jul 2023 09:41:37 +0000 (10:41 +0100)]
Updated FrameCallback to return value to specify whether we should keep rendering
Change-Id: I687adaaa23cf5a211a64e74585ae3075824baa75
seungho baek [Mon, 19 Jun 2023 13:43:00 +0000 (22:43 +0900)]
Makes Models use common shader manager
- In Scene3D, the responsibility for modifying the shader code or setting the shader's uniform variables was scattered across many classes.
- When a uniform variable is added or the name of a uniform variable is changed in the shader code, there was a problem of repeating the same modification in multiple codes.
- In this patch, one class is responsible for creating or managing Shader code, and the class name is changed to ShaderManager.
- And by using one ShaderManager per SceneView, it is easy to manage properties that should be applied in common within SceneView.
- Although there is no difference in use in terms of Model/SceneView API, it is helpful for code management, and performance can be improved when many Renderers share a small number of Shaders.
Change-Id: I0975921a1a7e40c453156cf9bd0b1890fc8e6526
Signed-off-by: seungho baek <sbsh.baek@samsung.com>
Eunki Hong [Thu, 6 Jul 2023 06:13:35 +0000 (06:13 +0000)]
Merge "Make CreateSolidColorTexture upload pixel data" into devel/master
Eunki Hong [Wed, 5 Jul 2023 15:58:19 +0000 (00:58 +0900)]
Fix comments for MotionData
Change-Id: I87b9e98de2a5ef690d85029996bbafdad7a9c554
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
Bowon Ryu [Wed, 5 Jul 2023 05:15:05 +0000 (05:15 +0000)]
Merge "Update approval test for text" into devel/master
Heeyong Song [Wed, 5 Jul 2023 05:04:33 +0000 (05:04 +0000)]
Merge "Fix build error for toolchain upgrade" into devel/master
Heeyong Song [Mon, 3 Jul 2023 06:44:55 +0000 (15:44 +0900)]
Fix build error for toolchain upgrade
model-loader.cpp
[ 61s] /home/abuild/rpmbuild/BUILD/dali2-toolkit-2.2.33/dali-scene3d/public-api/loader/model-loader.cpp:136:72: error: moving a temporary object prevents copy elision [-Werror=pessimizing-move]
[ 61s] 136 | Dali::Scene3D::Loader::ResourceRefCounts resourceRefCount = std::move(mLoadResult.mResources.CreateRefCounter());
[ 61s] | ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Change-Id: I0d4f08938e9f96918ba7407aacd59f7975fde264
Eunki Hong [Wed, 7 Jun 2023 12:53:06 +0000 (21:53 +0900)]
Add MotionData class and generate Animation
This patch is implement NUI API by dali side
https://github.com/Samsung/TizenFX/pull/5227
Let we make APP developer use this API instead of using animation-definition.
Change-Id: Ifca479535500aeea49bf644160c23c5f3fc26665
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
Eunki, Hong [Mon, 8 May 2023 06:13:03 +0000 (15:13 +0900)]
Parse gltf mesh extra and extensions + Get BlendShape index by name
Let we parse extra / extensions information from gltf2 mesh.
It will be used when we apply blendshape informations by string.
Since we are store the blendshape name, now we can get the index of
blendshape by name per each ModelNode.
Change-Id: I4e2030901b87c76b5fb205208c13184ae6ebd7b0
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Bowon Ryu [Mon, 3 Jul 2023 02:41:44 +0000 (11:41 +0900)]
Update approval test for text
Due to the patch below, there are some changes to the text placement position.
https://review.tizen.org/gerrit/#/c/platform/core/uifw/dali-adaptor/+/294254/
Change-Id: Ia1c79209405beedd6c26a63ebcbfee9928b31725
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
Eunki, Hong [Mon, 3 Jul 2023 01:01:37 +0000 (10:01 +0900)]
Make CreateSolidColorTexture upload pixel data
To avoid case when we skip rendering for non-upload texture, make sure
that we upload texture.
Change-Id: Ieea21bf09d84ff43fbff6673ba7dfc8e299cdf45
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Adeel Kazmi [Fri, 30 Jun 2023 13:17:03 +0000 (14:17 +0100)]
DALi Version 2.2.33
Change-Id: I29837ebf3df52c3734bcbaf12fa85bcb8d338fe1
Bowon Ryu [Wed, 28 Jun 2023 04:52:39 +0000 (04:52 +0000)]
Merge "Move Clipboard to TextClipboard" into devel/master
Bowon Ryu [Tue, 27 Jun 2023 05:44:47 +0000 (14:44 +0900)]
Move Clipboard to TextClipboard
We plan to create a new Clipboard class and
remove the dependency on Text and the legacy clipboard.
Change-Id: I87eeb622e4ea524d5c2d9b38c5a16e958b89c52c
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
Seungho BAEK [Tue, 27 Jun 2023 04:48:39 +0000 (04:48 +0000)]
Merge "Shader Factory refactoring" into devel/master
seungho baek [Wed, 21 Jun 2023 04:27:32 +0000 (13:27 +0900)]
Shader Factory refactoring
Change-Id: I814de35cd21600eb5370401a60755630d6aa4dc0
Signed-off-by: seungho baek <sbsh.baek@samsung.com>
Jeongmin Lee [Mon, 26 Jun 2023 04:51:53 +0000 (04:51 +0000)]
Merge "Detach skybox on setting an empty url" into devel/master
Heeyong Song [Thu, 22 Jun 2023 04:48:57 +0000 (13:48 +0900)]
Sync test harness
Change-Id: Ib89a365dae26ff2db51d40d4bebdf5bb140e9a92
Adeel Kazmi [Sat, 24 Jun 2023 14:02:58 +0000 (14:02 +0000)]
Merge "Test harness sync" into devel/master
David Steele [Thu, 6 Apr 2023 11:19:54 +0000 (12:19 +0100)]
Test harness sync
Change-Id: Ib91bad483649170eedb76ac6a4e1755517d29b1a
Adam Bialogonski [Fri, 23 Jun 2023 10:03:22 +0000 (11:03 +0100)]
DALi Version 2.2.32
Change-Id: Idb353d258df42fa8dca2ec90975b6e3d8fb44a5a
jmm [Thu, 22 Jun 2023 11:13:28 +0000 (20:13 +0900)]
Detach skybox on setting an empty url
Change-Id: I8cfc89b802fe625046e98a97e15551de9285ff82
Eunki, Hong [Tue, 20 Jun 2023 02:23:08 +0000 (11:23 +0900)]
Load remote svg image as low priority
Since we can load svg file as remote, make remote svg image load task as low priority
Change-Id: Ib0604ef8cda045641c331f367bb02e85c8304e35
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Adeel Kazmi [Wed, 21 Jun 2023 11:27:16 +0000 (11:27 +0000)]
Merge "Particle emitter makes sure the renderer clears vertex update callback upon destruction." into devel/master
Eunki Hong [Wed, 21 Jun 2023 01:10:28 +0000 (01:10 +0000)]
Merge "FocusFinder use CalculateCurrentScreenExtents" into devel/master
Adam Bialogonski [Tue, 20 Jun 2023 11:55:57 +0000 (12:55 +0100)]
Particle emitter makes sure the renderer clears vertex update callback upon destruction.
Change-Id: I27ede3879ef8e6d510118b6c872bb333275bc782
Signed-off-by: Adam Bialogonski <adam.b@samsung.com>
Bowon Ryu [Tue, 20 Jun 2023 01:20:22 +0000 (01:20 +0000)]
Merge "Change trace tag for text dorelayout" into devel/master
Seungho BAEK [Mon, 19 Jun 2023 09:06:16 +0000 (09:06 +0000)]
Merge "Add Light for Scene3D" into devel/master
Bowon Ryu [Mon, 19 Jun 2023 05:46:39 +0000 (14:46 +0900)]
Change trace tag for text dorelayout
Change the tag of DALI_TEXT_DORELAYOUT log to DALI_TRACE_PERFORMANCE_MARKER.
This will output DoRelayout's trace log by default.
Change-Id: I1f75505e172fdb7ab18c5314cd950681d3d4f483
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
seungho baek [Wed, 24 May 2023 09:35:28 +0000 (18:35 +0900)]
Add Light for Scene3D
Change-Id: If21ef89a2254dd835c80449da575d301124f8fcc
Signed-off-by: seungho baek <sbsh.baek@samsung.com>
seungho baek [Mon, 19 Jun 2023 05:07:14 +0000 (14:07 +0900)]
Fix constants' type in gradient visual.
Change-Id: I3f7844a7e5bec4c734621b1fbf784da826187363
Signed-off-by: seungho baek <sbsh.baek@samsung.com>
Seungho BAEK [Mon, 19 Jun 2023 04:54:53 +0000 (04:54 +0000)]
Merge "Fix Gradient Visual texturing issue" into devel/master
Heeyong Song [Mon, 19 Jun 2023 00:38:20 +0000 (00:38 +0000)]
Merge "(Vector) Use one EventThreadCallback" into devel/master
Richard Huang [Fri, 16 Jun 2023 13:48:40 +0000 (14:48 +0100)]
DALi Version 2.2.31
Change-Id: I07d7460b8a61ad3ed45ced58763790f3a4137f96
seungho baek [Fri, 16 Jun 2023 11:57:21 +0000 (20:57 +0900)]
Fix Gradient Visual texturing issue
Change-Id: I6b0318cfb8716f5a8a08e1e96e4ca256f00af12e
Signed-off-by: seungho baek <sbsh.baek@samsung.com>
Heeyong Song [Tue, 13 Jun 2023 07:33:48 +0000 (16:33 +0900)]
(Vector) Use one EventThreadCallback
EventThreadCallback uses an fd internally and some systems have a limit on the number of fd.
So reduce the number of fd
Change-Id: I55f6e7f5211d0bc567a1b2362c782e9fc2a74b90
Eunki Hong [Mon, 15 May 2023 15:14:48 +0000 (00:14 +0900)]
FocusFinder use CalculateCurrentScreenExtents
Let we use CalculateCurrentScreenExtents instead of CalculateScreenExtents
during find next focusable actor.
Since CalculateScreenExtents is heavy job, we'd better use
CalculateCurrentScreenExtents, what we were used until now.
Change-Id: Ic59f23869c549457ce622899876cef178dabb63b
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
Eunki Hong [Fri, 9 Jun 2023 15:58:14 +0000 (00:58 +0900)]
Fix logical error for dli animation duration
There was some code mistakes for dli loader parsing of animation duration.
Change-Id: I877cb44369a5f72b2a1064c7b8ea816bdbe806f1
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
Eunki Hong [Wed, 14 Jun 2023 00:56:12 +0000 (00:56 +0000)]
Merge "Clear cached font data if appended too much" into devel/master
Eunki, Hong [Fri, 19 May 2023 02:49:09 +0000 (11:49 +0900)]
Clear cached font data if appended too much
Until found the reason of cache size appending, just keep this removal logic.
Change-Id: I9a1e6c2db486af9c711c80ab65bb03435719c3f9
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Heeyong Song [Tue, 30 May 2023 01:38:30 +0000 (10:38 +0900)]
Sync native image test harness
Change-Id: I45deaaa3ca96468ae08488fc54aea469134564fa
Bowon Ryu [Fri, 9 Jun 2023 10:26:27 +0000 (10:26 +0000)]
Merge "Apply font size scale to markup text" into devel/master
David Steele [Fri, 9 Jun 2023 09:50:16 +0000 (10:50 +0100)]
DALi Version 2.2.30
Change-Id: Idaf8f5bea74b26a14384a960a4c6e8a563ce1b92
Bowon Ryu [Fri, 9 Jun 2023 05:00:14 +0000 (14:00 +0900)]
Apply font size scale to markup text
Change-Id: I1c6467a1ebb42b4604497db12b12052fc7deba80
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
Eunki Hong [Mon, 22 May 2023 14:32:59 +0000 (23:32 +0900)]
Lock model cache manager access for thread safety
Since we can access to mModelCache by ModelCacheManager,
and also we can create new items (== change container itself)
Add a global mutex lock for cache manager API.
And also, add some comment why we use std::map for cache.
And also, do not open conditional wait object out of cache.
And also, increase reference count of model so we can run this function
more thread safety.
TODO : We MUST not access into model cache manager from worker thread.
(Since worker thread can Process even main thread shutdown.)
MUST be refactorize.
Change-Id: I81e95a5f5df8c16dbaf6b84b6ddd3cd4809121d0
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
Adeel Kazmi [Tue, 6 Jun 2023 15:29:56 +0000 (15:29 +0000)]
Merge "Do not observe when Reload" into devel/master
Adam Bialogonski [Mon, 5 Jun 2023 15:14:10 +0000 (16:14 +0100)]
Particle System: Fixes
- Fixed anaylysis hub error
- making sure only one renderer is being added
Change-Id: I82e13306621787200d48d5fa102328980a087d7c
Signed-off-by: Adam Bialogonski <adam.b@samsung.com>
Heeyong Song [Mon, 5 Jun 2023 08:53:11 +0000 (17:53 +0900)]
Use SceneHolder::Get() instead of Window::Get()
To support off-screen window
Change-Id: I5d12ab14190a98b90904637a6b2d1c89d8a70c09
Adam Bialogonski [Fri, 2 Jun 2023 14:01:42 +0000 (15:01 +0100)]
Particle System
- added base lifetime stream
- fixed default particle color
- fixed freelist management
Change-Id: I7ef1ef03200420b3db4e9877bbdeeb1e876ba101
David Steele [Fri, 2 Jun 2023 17:18:29 +0000 (17:18 +0000)]
Merge changes I89471ca9,I866ffdec into devel/master
* changes:
Test sync with adaptor
Test sync for vertex range
David Steele [Fri, 2 Jun 2023 10:59:18 +0000 (10:59 +0000)]
Merge "DALi Version 2.2.29" into devel/master
Richard Huang [Fri, 2 Jun 2023 10:37:06 +0000 (11:37 +0100)]
DALi Version 2.2.29
Change-Id: I21ddb585decd1412ad1e6ac347d418fabd85dd93
Heeyong Song [Fri, 2 Jun 2023 02:22:31 +0000 (11:22 +0900)]
(SceneView) Reset the removed RenderTask
Change-Id: I29a1d8ae306f49d0dd9b13842ba2f1d95190690d
Heeyong Song [Thu, 1 Jun 2023 13:14:40 +0000 (13:14 +0000)]
Merge "Fix SVG crash issue" into devel/master
Heeyong Song [Thu, 1 Jun 2023 04:49:08 +0000 (13:49 +0900)]
Fix SVG crash issue
Remove previous task before create a new task
Change-Id: I77ef7d92e48d1ad256f9d2b07b6423e7b572ff5f
Eunki, Hong [Wed, 31 May 2023 23:56:45 +0000 (08:56 +0900)]
Add dali-scene3d.h for increase app developer convenience
Follow dali/dali.h, dali-toolkit/dali-toolkit.h,
Let we make dali-scene3d/dali-scene3d.h which contain all kind of
public-api of dali-scene3d.
So even if we refactorize dali-scene3d directory system,
let other application didn't got effort.
Change-Id: I22b8bca67177280d04f6d5c2db7ecdec6b0b9484
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
David Steele [Thu, 27 Apr 2023 11:11:01 +0000 (12:11 +0100)]
Test sync with adaptor
Adaptor changes for integer attribute
Change-Id: I89471ca98179d1ca9a9e19db6110585d7231378a
David Steele [Fri, 26 May 2023 13:23:28 +0000 (14:23 +0100)]
Test sync for vertex range
Change-Id: I866ffdec46f66574becfda16a150992226a8247a
Eunki, Hong [Thu, 25 May 2023 09:51:20 +0000 (18:51 +0900)]
Do not observe when Reload
Previously, we add same observer multiple times when image is loading state
and user do Reload action multiple times.
In that case, there might be problem if visual destroyed.
TODO : We should consider when we call Reload during ResourceReady()
TODO : We should consider when reload visual has mask texture id
Change-Id: Iab8b193281649783b80a6e9fb89e86c625b4388a
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki, Hong [Tue, 30 May 2023 03:54:26 +0000 (12:54 +0900)]
Let we use integer uniform for shader
Since we cannot believe float to integer convertor,
Let we use integer uniform value register without float conversion
Change-Id: Idf740687b51b73a00db77eb4a784f0acef73f5df
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Heeyong Song [Thu, 25 May 2023 09:16:19 +0000 (18:16 +0900)]
Sync test harness
Change-Id: Ia4081494e429aa3674402fb8b39f7e7f8c83a417
David Steele [Fri, 26 May 2023 11:42:25 +0000 (11:42 +0000)]
Merge "DALi Version 2.2.28" into devel/master
Adeel Kazmi [Fri, 26 May 2023 11:39:53 +0000 (12:39 +0100)]
DALi Version 2.2.28
Change-Id: Ie68bdc2f2e17a1cf1906382c58fedb9dcc982b0e
Artur Świgoń [Thu, 25 May 2023 12:59:41 +0000 (14:59 +0200)]
[AT-SPI] Remove Text{Editor,Field}::mStencil from the tree
These objects are not interesting to the Screen Reader.
Change-Id: I764ca04999114ca7f14a3e9a04442c1971b79ad7
David Steele [Wed, 24 May 2023 09:55:47 +0000 (09:55 +0000)]
Merge "Sync test harness" into devel/master
Eunki, Hong [Wed, 24 May 2023 01:58:08 +0000 (10:58 +0900)]
Sync test harness
Sync test harness for ttrace
Change-Id: I501505ff721168212cda2eba5d4ebf51e9ce3e76
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
sunghyun kim [Thu, 18 May 2023 07:35:28 +0000 (16:35 +0900)]
Skip call resourceReady() for disabled visual
for disabled visuals, ResourceReady is not called.
Change-Id: I9864cde4bffeb1eab5c11812f6911c1772692a4a
Adeel Kazmi [Mon, 22 May 2023 13:32:14 +0000 (13:32 +0000)]
Merge "Let ModelCache use std::map instead of unordered_map" into devel/master
seungho baek [Mon, 22 May 2023 05:17:51 +0000 (14:17 +0900)]
Add comment for gradient visual
Change-Id: I41b226479eaef61cff387c81d4532664ec961bce
Signed-off-by: seungho baek <sbsh.baek@samsung.com>
Heeyong Song [Thu, 18 May 2023 08:38:24 +0000 (17:38 +0900)]
Sync test harness
Change-Id: I1bb2bd71ae9133e165cace85e6e8da283b47b6e8
Adeel Kazmi [Fri, 19 May 2023 14:32:30 +0000 (14:32 +0000)]
Merge "DALi Version 2.2.27" into devel/master
David Steele [Fri, 19 May 2023 14:26:38 +0000 (15:26 +0100)]
DALi Version 2.2.27
Change-Id: I78db66fb7d915727e2797179b3e1fc993938c635
Adeel Kazmi [Fri, 19 May 2023 12:49:19 +0000 (12:49 +0000)]
Merge "Fix the normalization factor calculation for blendshapes" into devel/master
Bowon Ryu [Fri, 19 May 2023 07:38:40 +0000 (16:38 +0900)]
Fix initial white space issue in text
Current logic does not send text and cursor position for initial white space to IME.
I don't know the exact history of this logic.
But in case of efl, it is sending information about initial white space to IME.
Change behavior for consistency.
Change-Id: I86bc7ecfece9f02c2eb670c3359efc31d79daabb
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
Eunki, Hong [Wed, 17 May 2023 08:14:38 +0000 (17:14 +0900)]
Let ModelCache use std::map instead of unordered_map
If mModelCache become rehashed during some model-load-task lock the process,
It might make some crash.
To keep the validation of ModelCacheManager::ModelCache data, let we use
the cache container as std::map, instead of std::unordered_map
Change-Id: Ied52a7cd8fcf805eb18d5563df1da821f4d3c655
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Richard [Thu, 18 May 2023 14:09:13 +0000 (15:09 +0100)]
Fix the normalization factor calculation for blendshapes
This patch fixes two issue:
1. Fix the calculation of the blendshape normalization factor so that it can
handle smaller maximum distance between the original mesh and the deformed
mesh.
2. Apply the min and max properties of the accessor to all the elements in the
accessor, not just the elements in the sparse storage.
Change-Id: Iea90cbacf91fc7311242d9a47454b06afee82200
Eunki Hong [Thu, 18 May 2023 13:09:21 +0000 (22:09 +0900)]
Fix build error
mesh-definition.cpp:557:119: error: the address of ‘sparseIndices’ will never be NULL [-Werror=address]
There was some coding mistakes exist.
Change-Id: Id327965bebf6d1f4132499ff674d863f772ad6f9
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
Adeel Kazmi [Wed, 17 May 2023 17:18:06 +0000 (17:18 +0000)]
Merge "Blendshapes fix (still missing tests)" into devel/master
Adam Bialogonski [Tue, 16 May 2023 15:53:24 +0000 (16:53 +0100)]
Blendshapes fix (still missing tests)
When using sparse accessors, the gltf loader loads data correctly
but the blendshapes generator (texture and data) always assumes that
morph targets contain all the vertices which isn't a case.
Fix makes sure that for sparse access only indexed vertices are
affected by the blendshape. It still generate full vertex data
(for whole mesh) so it's compatible with current shader.
Change-Id: I1f36c1d9d24dec0eb194d0aaf1b93488b61b1d58
Signed-off-by: Adam Bialogonski <adam.b@samsung.com>
David Steele [Wed, 17 May 2023 13:22:00 +0000 (13:22 +0000)]
Merge "Added build dependencies on shader source" into devel/master
Adeel Kazmi [Wed, 17 May 2023 12:29:17 +0000 (12:29 +0000)]
Merge "Fixed vector and list includes to use wrappers" into devel/master
sunghyun kim [Wed, 17 May 2023 06:29:28 +0000 (06:29 +0000)]
Merge "Modified to use the appropriate TextureSet in external texture" into devel/master
sunghyun kim [Tue, 16 May 2023 06:26:14 +0000 (15:26 +0900)]
Modified to use the appropriate TextureSet in external texture
Change-Id: Id3b81f769fad02e90a5b5fd311e13bbe9692d200