platform/core/uifw/dali-toolkit.git
2 years ago[Tizen] 1. Add Timer at TapGestureRecognizer 15/267615/1
Joogab Yun [Mon, 5 Jul 2021 03:05:23 +0000 (12:05 +0900)]
[Tizen] 1. Add Timer at TapGestureRecognizer

2. The field and editor receive all tap events

Change-Id: I2aa73f4f16899fb07b70bfdc2ccdc9e8631a9d2f

2 years ago[Tizen] Add TOUCH_FOCUSABLE property 99/267499/1
Joogab Yun [Thu, 3 Jun 2021 06:42:30 +0000 (15:42 +0900)]
[Tizen] Add TOUCH_FOCUSABLE property

This is a property that allows you to have focus even when touched.

It works only when KEYBOARD_FOCUSABLE is set to true.

KEYBOARD_FOCUSABLE :  whether the view can have focus or not
TOUCH_FOCUSABLE    :  Whether the user can focus by touch

Change-Id: Ie308c75931df2cf74f45d851bc76e662c055635a

2 years agoMerge "[Tizen] 1. Implement FocusFinder" into tizen_6.0
joogab yun [Mon, 6 Dec 2021 07:01:20 +0000 (07:01 +0000)]
Merge "[Tizen] 1. Implement FocusFinder" into tizen_6.0

2 years ago[Tizen] 1. Implement FocusFinder 87/267487/1
Joogab Yun [Fri, 16 Apr 2021 07:19:35 +0000 (16:19 +0900)]
[Tizen] 1. Implement FocusFinder

The class used for finding the next focusable actor in a given direction
from a actor that currently has focus.

2. Change FocusFinder to a method

3. Add Tab key focus movement.

If the focus group is not changed, Move the focus towards right, "Shift-Tap" key moves the focus towards left.
Still if the focus is not moved, Move the focus towards down, "Shift-Tap" key moves the focus towards up.

4. Users can implement focus movement by SetCustomAlgorithm.
So User implemented focus movement by SetCustomAlgorithm(AutoFocusAlgorithm.Instance);
And if user do SetCustomAlgorithm(null), the user expects the focus not to move.
this is for backward-compatibility.
Add EnableDefaultAlgorithm() and IsDefaultAlgorithmEnabled() for enable/disable the default algorithm

5. Fixed bug

6. Fixed IsCandidate bug

7. Check if actor can be focused.

8. If parent is hidden, the child cannot be focused.

Change-Id: Ieebaafc31fe5e943a63b8e2a079335eb578ab0cd

2 years ago[Tizen] Fixed an issue where the multi-tap did not work properly. 77/267477/1
Joogab Yun [Tue, 18 May 2021 08:16:25 +0000 (17:16 +0900)]
[Tizen] Fixed an issue where the multi-tap did not work properly.
(https://review.tizen.org/gerrit/#/c/platform/core/uifw/dali-core/+/258466/)

Due to this bug, using multi-tap in automated-tests worked fine.

Modify not to be multi-tap.

Change-Id: I459520faf346da7aa380773ebf04c6b85c3e4e87

3 years ago[Tizen] Fix alignment issues in backgroundActor. 58/266158/1 accepted/tizen/6.0/unified/20211109.075205 submit/tizen_6.0/20211109.015223
joogab.yun [Mon, 8 Nov 2021 10:31:36 +0000 (19:31 +0900)]
[Tizen] Fix alignment issues in backgroundActor.

Change-Id: I8030da6e91f2d5183503079093593159e8200865

3 years ago[Tizen] Enable background color in TextEditor 86/265986/5 accepted/tizen/6.0/unified/20211104.123341 submit/tizen_6.0/20211104.034658
joogab.yun [Thu, 4 Nov 2021 01:52:15 +0000 (10:52 +0900)]
[Tizen] Enable background color in TextEditor

Change-Id: I867f3e5c38c40923f959a04fdff7a9ac58755171

3 years ago[Tizen] Fix behaviour when PreeditStyle is REVERSE 62/265562/2 accepted/tizen/6.0/unified/20211026.160138 submit/tizen_6.0/20211026.003623
Bowon Ryu [Mon, 28 Jun 2021 05:31:57 +0000 (14:31 +0900)]
[Tizen] Fix behaviour when PreeditStyle is REVERSE

In REVERSE case, TextColor uses text's background color.
but in most cases, there is no text's background color
and the the default alpha value is 0.
So in this case, the text is not visible. (text color's alpah value becomes 0)

To solve this, if there is no text's background, the control's color is used.
And if there is no control's color, set white or black according to the contrast.
In this case, the color is determined based on W3C recommendations.
(https://www.w3.org/TR/WCAG20/)

Change-Id: I251ec3283d761e08bb8214f4e53b0da05ad9ba4f
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
3 years ago[Tizen] Fix doxygen error 67/263867/1 accepted/tizen/6.0/unified/20210924.132546 submit/tizen_6.0/20210923.045321
Eunki, Hong [Mon, 13 Sep 2021 05:18:25 +0000 (14:18 +0900)]
[Tizen] Fix doxygen error

Change-Id: Ic9f37dc4d283c518d382896472369fd01148231c

3 years ago[Tizen] Implement WebView::GetPlainTextAsynchronously 28/261928/1 accepted/tizen/6.0/unified/20210908.124451 submit/tizen_6.0/20210908.054804
Jiyun Yang [Thu, 22 Jul 2021 13:07:20 +0000 (22:07 +0900)]
[Tizen] Implement WebView::GetPlainTextAsynchronously

Change-Id: I6691a877ec987dc9971216a43a34bb6daa2ba95d
Signed-off-by: Jiyun Yang <ji.yang@samsung.com>
3 years ago[Tizen] Add WebView SetTtsFocus 00/261100/1
Jiyun Yang [Wed, 7 Jul 2021 12:28:10 +0000 (21:28 +0900)]
[Tizen] Add WebView SetTtsFocus

Change-Id: I94888109d21797fcf00fefd68843234f19379148
Signed-off-by: Jiyun Yang <ji.yang@samsung.com>
3 years ago[Tizen] Fix invalid update to TextUpdateInfo in SELECTING state. 36/260136/1
Bowon Ryu [Fri, 18 Jun 2021 07:42:57 +0000 (16:42 +0900)]
[Tizen] Fix invalid update to TextUpdateInfo in SELECTING state.

mTextUpdateInfo is updated even if no selecting state in SetInputColor().
This causes a crash in some cases.
(When TextColor, InputColor is changed by the user in TextChanged callback)

This patch prevents invalid update of TextUpdateInfo.
Most of the known Text Crash issues are fixed by this patch.

Change-Id: I16488d3a9f9f063c441834f622afbe33b3ea7a74
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
3 years agoAdd SpaceEvenly to flex justification 54/259554/2 accepted/tizen/6.0/unified/20210629.212506 submit/tizen_6.0/20210616.095852 submit/tizen_6.0/20210629.055321
Jaehyun Cho [Thu, 3 Jun 2021 06:05:10 +0000 (15:05 +0900)]
Add SpaceEvenly to flex justification

Flex justification uses Yoga Layout's justify-content.
Up to now, SpaceEvenly of Yoga Layout's justify-content has not been
added to flex justification.

SpaceAround distributes the equal space to before, and after each item.
Therefore, the space between adjacent items is twice bigger than the
space between the beginning edge and the first item.

To distribute the equal space to before, between, and after each item,
SpaceEvenly is added to flex justification.

Change-Id: Icb4e1f1aa74f52a5cfe8f1399e9f42457c8c081f

3 years ago[Tizen] Fix TextChanged signal. 63/258563/1 accepted/tizen/6.0/unified/20210520.123333 submit/tizen_6.0/20210520.083010
Bowon Ryu [Thu, 20 May 2021 07:17:13 +0000 (16:17 +0900)]
[Tizen] Fix TextChanged signal.

Due to the previous patches (below patches),
cef89858f1d7ca38d2db7aecb934ceada5439e09
2a386a32eadd81f8f7483f408d06db0d3c15f40e

the sequence of Signal emit and Render has been different.
This caused a compatibility issue.
This patch fixes a compatibility issue by change the timing of the signal emit.

Change-Id: I76633936fb32e91d685f4bc6042c69ebd663c08d
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
3 years ago[Tizen] Fix texture manager crash 69/258469/1 accepted/tizen/6.0/unified/20210520.091802 submit/tizen_6.0/20210520.022521
Heeyong Song [Tue, 18 May 2021 05:42:26 +0000 (14:42 +0900)]
[Tizen] Fix texture manager crash

mLoadQueue should not be changed in the range based loop.

Change-Id: I7d469a650c78c4f1dfd3c7aa2bc01d0b432daa06

3 years ago[Tizen] Fix the build error 76/258376/1 accepted/tizen/6.0/unified/20210517.132246 submit/tizen_6.0/20210517.063916
Seoyeon Kim [Fri, 14 May 2021 07:59:16 +0000 (16:59 +0900)]
[Tizen] Fix the build error

- The method name of dali-adaptor was incorrect.
 Fixed the right one.

Change-Id: I8e809df9e5444b69967c9e5c0b86c901716a718d
Signed-off-by: Seoyeon Kim <seoyeon2.kim@samsung.com>
3 years agoMerge "[Tizen] Send the position of the focused actor" into tizen_6.0
Seoyeon Kim [Fri, 14 May 2021 02:13:30 +0000 (02:13 +0000)]
Merge "[Tizen] Send the position of the focused actor" into tizen_6.0

3 years ago[Tizen] Send the position of the focused actor 13/258313/1
Seoyeon Kim [Thu, 13 May 2021 08:42:03 +0000 (17:42 +0900)]
[Tizen] Send the position of the focused actor

- Set the current position of the focused actor.
- The position is based on how far away it is from the top-left of window.

Change-Id: Ib614f8df883d80e53dc731d1b8c2b1fda107b1df
Signed-off-by: Seoyeon Kim <seoyeon2.kim@samsung.com>
3 years ago[Tizen] Fix crash issue when favicon is null. 89/258089/4
huayong.xu [Mon, 10 May 2021 10:21:10 +0000 (18:21 +0800)]
[Tizen] Fix crash issue when favicon is null.

When favicon of web page is null, it would cause crash.
This patch is to add a check if pixel data is null or not.

Change-Id: I2c3d1f90a8195affa92a76a47b1228dad43c78a4

3 years ago[Tizen] Waiting until texture is loaded in animated image visual 02/257302/1 accepted/tizen/6.0/unified/20210422.132231 submit/tizen_6.0/20210422.101220
seungho [Thu, 22 Apr 2021 07:10:05 +0000 (16:10 +0900)]
[Tizen] Waiting until texture is loaded in animated image visual

Change-Id: I5a05d05270ffa1dc68f98044bbd3fc7f53af7f5e
Signed-off-by: seungho <sbsh.baek@samsung.com>
3 years ago[Tizen] Add parameter (bool immediate) to TextChanged signal in interface 42/256042/3 accepted/tizen/6.0/unified/20210329.215611 submit/tizen_6.0/20210329.035131
Bowon Ryu [Wed, 24 Mar 2021 10:17:05 +0000 (19:17 +0900)]
[Tizen] Add parameter (bool immediate) to TextChanged signal in interface

virtual void TextChanged(bool immediate) = 0;
using immediate, can decide whether we only emit the signal when OnRelayout() is called next time,
otherwise emits it immediately.

* there is a issue that the timing of callback calls has been delayed
due to a recent patch that limits unnecessary callbacks.
(33ccee79d16a90d5f7ab427de1503ccc5bee4324)

Because of this, there is a problem that the TC like example below fails.
This patch can prevents the following issues.

/* example */

bool textChanged;

...

static void OnTextChanged(TextField control)
{
  textChanged = true;
}

...

field.TextChangedSignal().Connect(&OnTextChanged);
textChanged = false;
field.SetProperty(TextField::Property::TEXT, "hello");
DALI_TEST_CHECK(textChanged); // At this point, textChanged is false, so TC Fail occurs.

/* example */

Change-Id: If0a331c56f35eae931b34d128b4fe4282fc686b6
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
3 years agoUnnecessary TextChanged callbacks are being called. 83/255583/1 submit/tizen_6.0/20210323.091331 submit/tizen_6.0/20210324.025032
Joogab Yun [Fri, 19 Mar 2021 08:57:34 +0000 (17:57 +0900)]
Unnecessary TextChanged callbacks are being called.
Change it to be called only once at the end.

example)

Typing "호두" on the keyboard
Whenever COMMIT/PREEDIT in OnInputMethodContextEvent(), TextChanged callback is called

 OnTextFieldTextChanged(159) >  [ㅎ]   // PRE_EDIT
 OnTextFieldTextChanged(159) >  [호]   // PRE_EDIT
 OnTextFieldTextChanged(159) >  [혿]   // PRE_EDIT
 OnTextFieldTextChanged(159) >  []     // PRE_EDIT
 OnTextFieldTextChanged(159) >  [호]   // COMMIT
 OnTextFieldTextChanged(159) >  [호두] // PRE_EDIT

If you change the text to call the TextChanged callback only once at the end of the change,
 OnTextFieldTextChanged(159) >  [ㅎ]
 OnTextFieldTextChanged(159) >  [호]
 OnTextFieldTextChanged(159) >  [혿]
 OnTextFieldTextChanged(159) >  [호두]

Change-Id: I9b81d4ca703eeb92bb0ddd771dbf083374ac4202

3 years ago[Tizen] fix wrong cursor position in TextField 97/254597/1 accepted/tizen/6.0/unified/20210307.214530 submit/tizen_6.0/20210305.052634
Bowon Ryu [Fri, 5 Mar 2021 03:53:44 +0000 (12:53 +0900)]
[Tizen] fix wrong cursor position in TextField

When the placeholder font size is bigger/smaller than default font size,
the cursor is positioned incorrectly.

this is because mScrollPosition.y is calculated based on layoutSize.height at CalculateVerticalOffset().
(this is not based on cursor height.
in issue situation, layoutSize.height is bigger/smaller than defaultFontLineHeight.)

This patch prevents the wrong positioning of cursor when the layoutSize.height is bigger/smaller than defaultFontLineHeight.
And update the glyphPositions using recalculated offset.

This issue only occurs with placeholder + single line text control. (vertical alignment)

I hope this modification does not affect the calculation of other texts.
So, update the glyphPositions in CalculateVerticalOffset().

Change-Id: I05847bbe5dcce6451c6b24649f80ea945e1ed7ea
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
3 years ago[Tizen] Update position & size of web view. 86/252886/1 accepted/tizen/6.0/unified/20210205.032623 submit/tizen_6.0/20210204.105950
huayong.xu [Mon, 9 Nov 2020 10:20:07 +0000 (18:20 +0800)]
[Tizen] Update position & size of web view.

Originally position of web engine is not updated when position of
web view is changed.
This patch is to update position & size of web view.

Change-Id: I84ff062363ff0d20c8e60c26d57a9f00d47c7305

3 years ago[Tizen] Implement some new ewk apis in web view. 06/252306/1 accepted/tizen/6.0/unified/20210129.124040 submit/tizen_6.0/20210129.175201
huayong.xu [Thu, 10 Dec 2020 10:33:27 +0000 (18:33 +0800)]
[Tizen] Implement some new ewk apis in web view.

* Support some new APIs, e.g. BackForwardList, Context, CookieManager, Settings.
* Create, GetTitle, GetFavicon, etc are added.

Change-Id: Ied1ef6cda0f34b521be76187e12cc083e01390a5

3 years agoMerge "[Tizen] Support scroll in web view." into tizen_6.0
JIYUN YANG [Thu, 21 Jan 2021 06:27:28 +0000 (06:27 +0000)]
Merge "[Tizen] Support scroll in web view." into tizen_6.0

3 years ago[Tizen] Add DeleteAccessibilityAttribute 89/251889/4 accepted/tizen/6.0/unified/20210121.212559 submit/tizen_6.0/20210121.135448
huiyu.eun [Wed, 20 Jan 2021 09:09:26 +0000 (18:09 +0900)]
[Tizen] Add DeleteAccessibilityAttribute

Change-Id: Ic766fe8acaa8dd12fe6e9962d60828850795c975
Signed-off-by: huiyu.eun <huiyu.eun@samsung.com>
3 years ago[Tizen] Support scroll in web view. 61/251661/1
huayong.xu [Tue, 5 Jan 2021 07:02:50 +0000 (15:02 +0800)]
[Tizen] Support scroll in web view.

Some APIs related to scroll are supported.

Change-Id: I6f4f4430ea236f437196398b4c14a29375a91495

3 years ago[Tizen] Fix a texture manager crash 58/251458/1 accepted/tizen/6.0/unified/20210114.121919 submit/tizen_6.0/20210114.052723
Heeyong Song [Thu, 22 Oct 2020 07:52:59 +0000 (16:52 +0900)]
[Tizen] Fix a texture manager crash

In case of ReleasePolicy::NEVER,
Load an image in the UploadComplete callback, then it is inserted to the mLoadQueue
Delete the image visual before the queue is processed.
Then mObserver of LoadQueueElement has an invalid reference.

So reset the mObserver when the visual is deleted

Change-Id: Ie90e6374d419f614a1c08579b7591a7e21b43197

3 years ago[Tizen] Set focus to web engine. 45/250945/1
huayong.xu [Thu, 12 Nov 2020 06:54:28 +0000 (14:54 +0800)]
[Tizen] Set focus to web engine.

When web view focus is gained, it is delivered to web engine.

Change-Id: I0ffdd895eab36390d4ad74bf38d5398153284a67

3 years agoFix SVACE error in animated-image-visual.cpp 09/249909/1 accepted/tizen/6.0/unified/20201218.134802 submit/tizen_6.0/20201217.103517 submit/tizen_6.0/20201218.003345
Adeel Kazmi [Tue, 15 Dec 2020 21:24:45 +0000 (21:24 +0000)]
Fix SVACE error in animated-image-visual.cpp

Change-Id: I688715d694f5a726cebb95c1a69bf051177b4085

3 years agoMerge "[Tizen] Add AccessibilityManager logs" into tizen_6.0 accepted/tizen/6.0/unified/20201213.214021 submit/tizen_6.0/20201211.074400
Seoyeon Kim [Fri, 11 Dec 2020 07:43:51 +0000 (07:43 +0000)]
Merge "[Tizen] Add AccessibilityManager logs" into tizen_6.0

3 years ago[Tizen] Add AccessibilityManager logs 17/249417/1
Seoyeon Kim [Fri, 11 Dec 2020 07:29:50 +0000 (16:29 +0900)]
[Tizen] Add AccessibilityManager logs

Change-Id: I743698966179ef7d1d803415db5accac99a8c190
Signed-off-by: Seoyeon Kim <seoyeon2.kim@samsung.com>
3 years ago[Tizen] Check renderer when call DisplayNextFrame() 15/249315/3 accepted/tizen/6.0/unified/20201210.223947 submit/tizen_6.0/20201210.091119
Sunghyun Kim [Thu, 10 Dec 2020 05:55:06 +0000 (14:55 +0900)]
[Tizen] Check renderer when call DisplayNextFrame()

Sometimes DisplayNextFrame() is called even if animatedImageVisual is
disposed.
for avoid this issue, i added this patch.

Change-Id: I4912dbc38e2c911bc7bbfe7815a8fc8f6b9f4d37

3 years ago[Tizen] Add AnimatedVectorImageVisual property 24/249124/1
Heeyong Song [Wed, 2 Dec 2020 06:02:06 +0000 (15:02 +0900)]
[Tizen] Add AnimatedVectorImageVisual property

A property not to render again when the visual is scaled down.

Change-Id: I53d1e78d1376a24318055fa787ea8ee16e4fa0f2

3 years ago[Tizen] add Padding parameter at RendererParameters 10/249010/1 accepted/tizen/6.0/unified/20201207.044452 submit/tizen_6.0/20201204.091145
Joogab Yun [Fri, 4 Dec 2020 06:30:12 +0000 (15:30 +0900)]
[Tizen] add Padding parameter at RendererParameters

Change-Id: If8d78e1363bc02b5f872119af59f6d3b89550b90

3 years ago[Tizen] Add NextFrame method at ImageCache 13/248413/7 accepted/tizen/6.0/unified/20201202.212221 submit/tizen_6.0/20201201.081346
Seungho Baek [Mon, 23 Nov 2020 04:01:58 +0000 (13:01 +0900)]
[Tizen] Add NextFrame method at ImageCache

 - Load next frame without frame index

Change-Id: I7725ba0b9e931a6748b4e8019c65d5d3572aad6b
Signed-off-by: Seungho Baek <sbsh.baek@samsung.com>
3 years ago[Tizen] Add some APIs to make Accessibility enabled / disabled 16/248416/1 accepted/tizen/6.0/unified/20201128.020321 submit/tizen_6.0/20201127.133124 submit/tizen_6.0/20201127.164604
Seoyeon Kim [Thu, 26 Nov 2020 07:38:28 +0000 (16:38 +0900)]
[Tizen] Add some APIs to make Accessibility enabled / disabled

- Added EnableAccessibility and IsEnabled to AccessibilityManager

Change-Id: Ib107c3cb31c4954df90d0eb2426916f32404ba8e
Signed-off-by: Seoyeon Kim <seoyeon2.kim@samsung.com>
4 years ago[Tizen] Stop observing visuals when a control is destroyed accepted/tizen/6.0/unified/20201111.064923 accepted/tizen/unified/20201110.230601 submit/tizen/20201110.094917 submit/tizen_6.0/20201110.110443 submit/tizen_6.0/20201110.230218 submit/tizen_6.0/20201110.230946
Wonsik Jung [Tue, 10 Nov 2020 06:44:56 +0000 (15:44 +0900)]
[Tizen] Stop observing visuals when a control is destroyed

This reverts commit 1305cdf19da57fad70e3b88b674610aa0349c689.

4 years ago[Tizen] Fix Animated Image Visual issue of using same file in multiple visual
Wonsik Jung [Tue, 10 Nov 2020 06:44:34 +0000 (15:44 +0900)]
[Tizen] Fix Animated Image Visual issue of using same file in multiple visual

This reverts commit 25a8ed21a6a6333d5ffb3b785ac6c41f7014cbb0.

4 years ago[Tizen] Set custom fragment shader to the visual used in WebView
Wonsik Jung [Tue, 10 Nov 2020 06:44:07 +0000 (15:44 +0900)]
[Tizen] Set custom fragment shader to the visual used in WebView

This reverts commit c0a9100a905af181cead1ac3884ad9d8ff925390.

4 years ago[Tizen] Add AutofillContainer class and autofill implementation
Wonsik Jung [Tue, 10 Nov 2020 06:43:43 +0000 (15:43 +0900)]
[Tizen] Add AutofillContainer class and autofill implementation

This reverts commit e1252758509d9c829eea22158f0310f59706039a.

4 years agoMerge branch 'devel/master' into tizen
Wonsik Jung [Tue, 10 Nov 2020 06:43:08 +0000 (15:43 +0900)]
Merge branch 'devel/master' into tizen

4 years agoRevert "[Tizen] Add AutofillContainer class and autofill implementation"
Wonsik Jung [Tue, 10 Nov 2020 06:42:52 +0000 (15:42 +0900)]
Revert "[Tizen] Add AutofillContainer class and autofill implementation"

This reverts commit 494bbf1face6e886db708a45a850650f7a28a3cb.

4 years agoRevert "[Tizen] Set custom fragment shader to the visual used in WebView"
Wonsik Jung [Tue, 10 Nov 2020 06:42:49 +0000 (15:42 +0900)]
Revert "[Tizen] Set custom fragment shader to the visual used in WebView"

This reverts commit 993b1e31db1771b2ebc0eb17b5e5ca37030b1f82.

4 years agoRevert "[Tizen] Fix Animated Image Visual issue of using same file in multiple visual"
Wonsik Jung [Tue, 10 Nov 2020 06:42:46 +0000 (15:42 +0900)]
Revert "[Tizen] Fix Animated Image Visual issue of using same file in multiple visual"

This reverts commit 7d031a7b10e373f27b1093f47f7c93ab33255bdf.

4 years agoRevert "[Tizen] Stop observing visuals when a control is destroyed"
Wonsik Jung [Tue, 10 Nov 2020 06:42:43 +0000 (15:42 +0900)]
Revert "[Tizen] Stop observing visuals when a control is destroyed"

This reverts commit 4f58faf22aca8b73194a558886ca85e140ba651e.

4 years ago[Tizen] Stop observing visuals when a control is destroyed 43/247243/1
Heeyong Song [Mon, 9 Nov 2020 07:30:18 +0000 (16:30 +0900)]
[Tizen] Stop observing visuals when a control is destroyed

Change-Id: I6c46f3090cfb8235ed0a081ab328d48c410f039e

4 years agoDALi Version 1.9.36 31/246531/1 dali_1.9.36
David Steele [Fri, 30 Oct 2020 14:33:36 +0000 (14:33 +0000)]
DALi Version 1.9.36

Change-Id: I50556cfb50fae6c6987d79d4fe88923b0e0ea968

4 years agoEnsure AnimatedVectorImageVisual doesn't hang app 62/246462/1
David Steele [Thu, 29 Oct 2020 16:58:41 +0000 (16:58 +0000)]
Ensure AnimatedVectorImageVisual doesn't hang app

Currently, if the AnimatedVectorImageVisual is not destroyed
on Application::Terminate, e.g. if it's actor is kept alive,
then the shutdown order is undefined, and may end up
trying to pend on a mutex which has already been destroyed,
in the dali-extension plugin.

(TizenVectorAnimationManager, which creates the mutex, is a
singleton that is created when first needed, but stays alive
until main() completes)

Prevented the destructor from finalizing in the plugin if
core has already been shutdown.

Change-Id: I9fe547eab4dc3f3e5a4655f5c8dcf96bf664d7e3

4 years agoMerge "Dali-Text: Keyboard Shortcut (language layout independent)" into devel/master
joogab yun [Thu, 29 Oct 2020 03:30:49 +0000 (03:30 +0000)]
Merge "Dali-Text: Keyboard Shortcut (language layout independent)" into devel/master

4 years ago[Tizen] Fix Animated Image Visual issue of using same file in multiple visual accepted/tizen/unified/20201103.123407 submit/tizen/20201030.020452 submit/tizen/20201030.161430
seungho [Thu, 29 Oct 2020 01:40:10 +0000 (10:40 +0900)]
[Tizen] Fix Animated Image Visual issue of using same file in multiple visual

This reverts commit 05cb591f1bb95e227237691d74e6d3fb3306ed48.

Change-Id: I6fc8d9653aea6d36c86d9b687b2e1f2d6025b273

4 years ago[Tizen] Set custom fragment shader to the visual used in WebView
seungho [Thu, 29 Oct 2020 01:39:51 +0000 (10:39 +0900)]
[Tizen] Set custom fragment shader to the visual used in WebView

This reverts commit 46e03835e2cee2ce22a924204346a75ffe06a45b.

Change-Id: Ia2978464e8b5188f628548ea30dd151a7b1db5c6

4 years ago[Tizen] Add AutofillContainer class and autofill implementation
seungho [Wed, 28 Oct 2020 12:38:52 +0000 (21:38 +0900)]
[Tizen] Add AutofillContainer class and autofill implementation

This reverts commit 2534fdca51d6143d068f4172e118b724ecab14d1.

Change-Id: I629a3d563e48864ac233b40abc69117fb857c50f

4 years agoMerge branch 'devel/master' into tizen
seungho [Wed, 28 Oct 2020 12:26:47 +0000 (21:26 +0900)]
Merge branch 'devel/master' into tizen

Change-Id: I803d836915a0025af0b5e4e173b9055948af28cd

4 years agoRevert "[Tizen] Add AutofillContainer class and autofill implementation"
seungho [Wed, 28 Oct 2020 12:26:41 +0000 (21:26 +0900)]
Revert "[Tizen] Add AutofillContainer class and autofill implementation"

This reverts commit aa9863fcaaf25beecb077ab63dfd2136aa20d755.

4 years agoRevert "[Tizen] Revert "Changes after touch consumed behaviour change""
seungho [Wed, 28 Oct 2020 12:26:39 +0000 (21:26 +0900)]
Revert "[Tizen] Revert "Changes after touch consumed behaviour change""

This reverts commit 746ebfed348c504b732dcb3f55c92a39b5643414.

4 years agoRevert "Tizen] Set custom fragment shader to the visual used in WebView"
seungho [Wed, 28 Oct 2020 12:26:35 +0000 (21:26 +0900)]
Revert "Tizen] Set custom fragment shader to the visual used in WebView"

This reverts commit cc7e3a18683f184fd9b392b081c83b7963cfc60e.

4 years agoRevert "[Tizen] Fix Animated Image Visual issue of using same file in multiple visual"
seungho [Wed, 28 Oct 2020 12:26:34 +0000 (21:26 +0900)]
Revert "[Tizen] Fix Animated Image Visual issue of using same file in multiple visual"

This reverts commit 6feedf506f712d61c0e57097dfbb1acd429c0e8c.

4 years ago[Tizen] Fix Animated Image Visual issue of using same file in multiple visual 42/246342/1
seungho [Wed, 28 Oct 2020 09:00:59 +0000 (18:00 +0900)]
[Tizen] Fix Animated Image Visual issue of using same file in multiple visual

Change-Id: I92c44cede1d595fd3c278bf71e5200a6b6d70c2e
Signed-off-by: seungho <seungho@seungho.tn.corp.samsungelectronics.net>
4 years agoDali-Text: Keyboard Shortcut (language layout independent) 39/244639/9
Ali Alzyod [Tue, 22 Sep 2020 16:37:38 +0000 (19:37 +0300)]
Dali-Text: Keyboard Shortcut (language layout independent)

Keyboard shortcuts like (CTRL+A) to select all text, will work regardless of keyboard language layout.

Before Change:
If keyboard language layout is Arabic, (CTRL+A) will not work.

After Change:
(CTRL+A) will work, regardless of language layout for keyboard.

Change-Id: I44708a85c9499dc54e0d36758f039c0907ee70a2

4 years agoUpdated patch-coverage.pl script 26/246126/1
David Steele [Fri, 23 Oct 2020 14:36:24 +0000 (15:36 +0100)]
Updated patch-coverage.pl script

Change-Id: If8394b2ababc4d6769b3ce04420c855778e0c4b5

4 years agoDALi Version 1.9.35 05/246105/1 dali_1.9.35
adam.b [Fri, 23 Oct 2020 10:45:12 +0000 (11:45 +0100)]
DALi Version 1.9.35

Change-Id: Iabc8524442885da5491f1d1d57de887698ae9aca

4 years agoMerge "(Text Controller Impl) Moved event handling related methods into a separate...
Adeel Kazmi [Thu, 22 Oct 2020 19:09:20 +0000 (19:09 +0000)]
Merge "(Text Controller Impl) Moved event handling related methods into a separate struct" into devel/master

4 years ago(Text Controller Impl) Moved event handling related methods into a separate struct 51/245751/5
Adeel Kazmi [Thu, 15 Oct 2020 08:57:27 +0000 (09:57 +0100)]
(Text Controller Impl) Moved event handling related methods into a separate struct

Change-Id: I0e9f942f7dce110467dd283c08859f6c97e2b4e6

4 years agoAdding new patch-coverage script 47/246047/1
David Steele [Thu, 22 Oct 2020 17:05:44 +0000 (18:05 +0100)]
Adding new patch-coverage script

Change-Id: I5e83b4d480f247247ae4348717b01cac2459ee9c

4 years agoReduce Cyclomatic Complexity of some methods in text-typesetter, transtion-data ... 52/245852/6
Adeel Kazmi [Fri, 16 Oct 2020 11:06:40 +0000 (12:06 +0100)]
Reduce Cyclomatic Complexity of some methods in text-typesetter, transtion-data & text-label

Change-Id: I7c9a5b8c2ffc59837b0e8bcf85f78fe96df1bf9c

4 years agoMerge "dali-toolkit: update text selection UI handles with selection properties"...
Adeel Kazmi [Wed, 21 Oct 2020 10:55:04 +0000 (10:55 +0000)]
Merge "dali-toolkit: update text selection UI handles with selection properties" into devel/master

4 years agoEnsure not to emit the resource ready signal during the callback 54/245354/4
Heeyong Song [Wed, 7 Oct 2020 11:58:26 +0000 (20:58 +0900)]
Ensure not to emit the resource ready signal during the callback

Change-Id: Icc496c34a11df14aae8b99affe846c14bca308fa

4 years agodali-toolkit: update text selection UI handles with selection properties 09/245709/2
Ali Alzyod [Wed, 14 Oct 2020 12:28:58 +0000 (15:28 +0300)]
dali-toolkit: update text selection UI handles with selection properties

sample code to produce the issue :

```
#include <dali-toolkit/dali-toolkit.h>
#include <dali-toolkit/devel-api/controls/text-controls/text-editor-devel.h>
#include <dali-toolkit/devel-api/controls/text-controls/text-field-devel.h>
#include <iostream>

using namespace Dali;
using namespace Dali::Toolkit;

class SimpleApp : public ConnectionTracker
{
public:
  SimpleApp(Application& application)
  : mApplication(application)
  {
    mApplication.InitSignal().Connect(this, &SimpleApp::Create);
  }

  void Create(Application& application)
  {
    window = application.GetWindow();
    window.SetBackgroundColor(Vector4(0.04f, 0.345f, 0.392f, 1.0f));

    mTextEditor = TextEditor::New();
    mTextEditor.SetProperty(TextEditor::Property::TEXT, "Tex1\nTex2");
    mTextEditor.SetProperty(Actor::Property::PARENT_ORIGIN, ParentOrigin::TOP_CENTER);
    mTextEditor.SetProperty(Actor::Property::ANCHOR_POINT, AnchorPoint::TOP_CENTER);
    mTextEditor.SetProperty(Actor::Property::SIZE, Vector2(60.0f, 60.0f));
    mTextEditor.SetProperty(Actor::Property::POSITION, Vector3(0.f, 0.f, 0.f));
    window.Add(mTextEditor);

    mBtnEditable = PushButton::New();
    mTextEditor.SetProperty(Actor::Property::PARENT_ORIGIN, ParentOrigin::TOP_CENTER);
    mTextEditor.SetProperty(Actor::Property::ANCHOR_POINT, AnchorPoint::TOP_CENTER);
    mBtnEditable.SetProperty(Actor::Property::SIZE, Vector2(120.f, 80.f));
    mBtnEditable.SetProperty(Actor::Property::POSITION, Vector2(100, 220.f));
    mBtnEditable.SetBackgroundColor(Color::RED);
    mBtnEditable.SetProperty(Button::Property::LABEL, "select");
    mBtnEditable.ClickedSignal().Connect(this, &SimpleApp::OnButtonClicked);
    window.Add(mBtnEditable);
  }

  bool OnButtonClicked(Button button)
  {
    mTextEditor.SetProperty(DevelTextField::Property::SELECTED_TEXT_START, 0);
    mTextEditor.SetProperty(DevelTextField::Property::SELECTED_TEXT_END, 10);
    return true;
  }

private:
  Application& mApplication;
  TextEditor mTextEditor;
  PushButton mBtnEditable;
  Window window;
};

int DALI_EXPORT_API main(int argc, char** argv)
{
  Application application = Application::New(&argc, &argv);
  SimpleApp test(application);
  application.MainLoop();

  return 0;
}
```

Change-Id: I9f29db01d60a53e578ee2b584caceb9c94b2e0ea

4 years agoDALi Version 1.9.34 38/245838/1 dali_1.9.34
Richard Huang [Fri, 16 Oct 2020 10:31:32 +0000 (11:31 +0100)]
DALi Version 1.9.34

Change-Id: I3b2a4aedddd0748b69634aa1a84759c0c7f675ac

4 years ago(Text Controller) Moved event handling, InputFont & Placeholder related methods into... 21/245221/4
Adeel Kazmi [Mon, 5 Oct 2020 10:41:15 +0000 (11:41 +0100)]
(Text Controller) Moved event handling, InputFont & Placeholder related methods into separate structs

Change-Id: If7b2eb2bde0bbb9a9bf04bd37d1d679c7038f5e0

4 years agoMerge "Text selection refactoring" into devel/master
Adeel Kazmi [Tue, 13 Oct 2020 15:12:40 +0000 (15:12 +0000)]
Merge "Text selection refactoring" into devel/master

4 years agoFix doxygen comments 87/245587/1
Adeel Kazmi [Mon, 12 Oct 2020 19:47:34 +0000 (20:47 +0100)]
Fix doxygen comments

Change-Id: I465620e3dcce309ccd6aa4e00895dac81fcf9c05

4 years agoText selection refactoring 77/244477/13
ali198724 [Fri, 18 Sep 2020 16:16:53 +0000 (19:16 +0300)]
Text selection refactoring

1- Move all of selection text functionality into SelectableControlInterface
2- Support (SelectWholeText, SelectNone, GetSelectedText) in TextEditor

Change-Id: I4da66433a09e99be09f6bd027761c3ea49cfc9f5

4 years agoMerge "Dali-toolkit: Text controls crash fix" into devel/master
joogab yun [Mon, 12 Oct 2020 09:47:17 +0000 (09:47 +0000)]
Merge "Dali-toolkit: Text controls crash fix" into devel/master

4 years agoDALi Version 1.9.33 65/245465/1 dali_1.9.33
György Straub [Fri, 9 Oct 2020 13:06:01 +0000 (14:06 +0100)]
DALi Version 1.9.33

Change-Id: I7b3f6ebb89cfbf8ffe8bf20899af8f81df8dbc55

4 years agoMerge "Fix documentation for Text::EditableControlInterface interface override functi...
joogab yun [Thu, 8 Oct 2020 02:57:17 +0000 (02:57 +0000)]
Merge "Fix documentation for Text::EditableControlInterface interface override functions" into devel/master

4 years agoDali-toolkit: Text controls crash fix 50/245350/1
ali198724 [Wed, 7 Oct 2020 11:42:41 +0000 (14:42 +0300)]
Dali-toolkit: Text controls crash fix

Fix crash when delete characters after change text color

Run demo, then press backspace
```
//g++ -g -O0 main.cpp -o app `pkg-config --cflags --libs dali2-core dali2-adaptor dali2-adaptor-integration  dali2-toolkit`

using namespace Dali;
using namespace Dali::Toolkit;

class SimpleApp : public ConnectionTracker
{
public:
  SimpleApp(Application& application)
  : mApplication(application)
  {
    mApplication.InitSignal().Connect(this, &SimpleApp::Create);
  }

  void Create(Application& application)
  {
    Window window = application.GetWindow();
    window.SetBackgroundColor(Vector4(0.04f, 0.345f, 0.392f, 1.0f));

    TextField field = TextField::New();
    field.SetProperty(TextField::Property::TEXT, "Erase");
    field.SetProperty(TextField::Property::TEXT_COLOR, Vector4(0.0f, 1.0f, 1.0f, 1.0f)); // CYAN
    field.SetProperty(Actor::Property::PARENT_ORIGIN, ParentOrigin::CENTER);
    field.SetProperty(Actor::Property::SIZE, Vector2(300.f, 60.f));
    window.Add(field);
    field.SetKeyInputFocus();
  }

private:
  Application& mApplication;
};

int DALI_EXPORT_API main(int argc, char** argv)
{
  Application application = Application::New(&argc, &argv);
  SimpleApp test(application);
  application.MainLoop();

  return 0;
}

```

Change-Id: I2c13330f92746c73d32da71cced15c3b297126dc

4 years agoMerge "Refactor SvgVisual" into devel/master
Heeyong Song [Wed, 7 Oct 2020 06:48:50 +0000 (06:48 +0000)]
Merge "Refactor SvgVisual" into devel/master

4 years agoRefactor SvgVisual 28/244728/6
Heeyong Song [Wed, 23 Sep 2020 15:05:06 +0000 (00:05 +0900)]
Refactor SvgVisual

Change-Id: I34399172bbb20220cbca031004f3e3bd805d006c

4 years agoMerge "use string_view to avoid temporary string allocation." into devel/master
Adeel Kazmi [Tue, 6 Oct 2020 09:04:45 +0000 (09:04 +0000)]
Merge "use string_view to avoid temporary string allocation." into devel/master

4 years agoTizen] Set custom fragment shader to the visual used in WebView accepted/tizen_6.0_unified_hotfix tizen_6.0_hotfix accepted/tizen/6.0/unified/20201030.113840 accepted/tizen/6.0/unified/hotfix/20201103.001935 accepted/tizen/unified/20201007.090630 submit/tizen/20201006.153948 submit/tizen_6.0/20201029.205105 submit/tizen_6.0_hotfix/20201102.192505 submit/tizen_6.0_hotfix/20201103.114805 tizen_6.0.m2_release
Daekwang Ryu [Tue, 6 Oct 2020 04:12:53 +0000 (13:12 +0900)]
Tizen] Set custom fragment shader to the visual used in WebView

This reverts commit 7a54226e11bb314ac4f03db8f3a7598395ccb66b.

4 years ago[Tizen] Revert "Changes after touch consumed behaviour change"
Daekwang Ryu [Tue, 6 Oct 2020 04:12:49 +0000 (13:12 +0900)]
[Tizen] Revert "Changes after touch consumed behaviour change"

This reverts commit 1642a4474eb7a3bfdfcef7b6eada308e5d287533.

4 years ago[Tizen] Add AutofillContainer class and autofill implementation
Daekwang Ryu [Tue, 6 Oct 2020 04:12:41 +0000 (13:12 +0900)]
[Tizen] Add AutofillContainer class and autofill implementation

This reverts commit c44a070dbb38c63e2a95e72e5c1afe7fda163f23.

4 years agoMerge branch 'devel/master' into tizen
Daekwang Ryu [Tue, 6 Oct 2020 04:04:10 +0000 (13:04 +0900)]
Merge branch 'devel/master' into tizen

4 years agoRevert "[Tizen] Add AutofillContainer class and autofill implementation"
Daekwang Ryu [Tue, 6 Oct 2020 04:03:35 +0000 (13:03 +0900)]
Revert "[Tizen] Add AutofillContainer class and autofill implementation"

This reverts commit e0d7338c49b3cbc4e6b4f8ae5eb104e3d0e1d34e.

4 years agoRevert "[Tizen] Revert "Changes after touch consumed behaviour change""
Daekwang Ryu [Tue, 6 Oct 2020 04:03:30 +0000 (13:03 +0900)]
Revert "[Tizen] Revert "Changes after touch consumed behaviour change""

This reverts commit 4b6e68d1df075ead5c35eaa36c8bd2ede20ddb92.

4 years agoRevert "[Tizen] Set custom fragment shader to the visual used in WebView"
Daekwang Ryu [Tue, 6 Oct 2020 04:03:28 +0000 (13:03 +0900)]
Revert "[Tizen] Set custom fragment shader to the visual used in WebView"

This reverts commit 795e5f18131d95ec0003e282e9b4e5097f397841.

4 years agoRevert "[Tizen] Ensuring Control behaviour flags retain their original values"
Daekwang Ryu [Tue, 6 Oct 2020 04:03:25 +0000 (13:03 +0900)]
Revert "[Tizen] Ensuring Control behaviour flags retain their original values"

This reverts commit 837e141082b7cdd8f961f37cf7e75935790c74cf.

4 years agoRevert "[Tizen] There is no need to call mOverlayRenderer's AddRenderer() in play()."
Daekwang Ryu [Tue, 6 Oct 2020 04:03:21 +0000 (13:03 +0900)]
Revert "[Tizen] There is no need to call mOverlayRenderer's AddRenderer() in play()."

This reverts commit 36e0fc16439e369be279d1fc8625cf35fa8cf374.

4 years ago[Tizen] There is no need to call mOverlayRenderer's AddRenderer() in play(). 37/245237/1
Joogab Yun [Tue, 29 Sep 2020 06:41:10 +0000 (15:41 +0900)]
[Tizen] There is no need to call mOverlayRenderer's AddRenderer() in play().

Change-Id: I37c2709e45d9e5a97f5801258e6ebee377e1337a

4 years agoDALi Version 1.9.32 12/245112/1 dali_1.9.32
Cheng-Shiun Tsai [Fri, 2 Oct 2020 09:46:42 +0000 (10:46 +0100)]
DALi Version 1.9.32

Change-Id: I65304e6e46868ad3e34994dde80e74970ddbbd31

4 years ago(JSON Parser State) Reduce Cyclomatic Complexity of ParseJson 70/245070/4
Adeel Kazmi [Wed, 30 Sep 2020 10:47:46 +0000 (11:47 +0100)]
(JSON Parser State) Reduce Cyclomatic Complexity of ParseJson

Change-Id: Iba20de994253d3dfaac8f92b9381c18aaeb76861

4 years agoMerge "Const correctness improvements for Property::Value." into devel/master
Adeel Kazmi [Tue, 29 Sep 2020 10:35:03 +0000 (10:35 +0000)]
Merge "Const correctness improvements for Property::Value." into devel/master

4 years agoThere is no need to call mOverlayRenderer's AddRenderer() in play(). 19/245019/1
Joogab Yun [Tue, 29 Sep 2020 06:41:10 +0000 (15:41 +0900)]
There is no need to call mOverlayRenderer's AddRenderer() in play().

Change-Id: I37c2709e45d9e5a97f5801258e6ebee377e1337a

4 years agoMerge "Text Editing (enable) property in text controls" into devel/master
Adeel Kazmi [Mon, 28 Sep 2020 15:53:38 +0000 (15:53 +0000)]
Merge "Text Editing (enable) property in text controls" into devel/master

4 years agoConst correctness improvements for Property::Value. 75/244975/2
György Straub [Mon, 28 Sep 2020 12:28:53 +0000 (13:28 +0100)]
Const correctness improvements for Property::Value.

- instead of using its parameter as in-out (and perhaps erroneously
  modifying the original), TextVisual returns the new map, which is then
  merged with the existing properties in ButtonImpl::SetProperty();

Change-Id: I974535fd017416dc60225a1f511e71d81a2a86de
Signed-off-by: György Straub <g.straub@partner.samsung.com>
4 years ago[Tizen] Ensuring Control behaviour flags retain their original values accepted/tizen/unified/20200927.212954 submit/tizen/20200926.031005
David Steele [Fri, 25 Sep 2020 15:17:46 +0000 (16:17 +0100)]
[Tizen] Ensuring Control behaviour flags retain their original values

Change-Id: Iafa9a7450a093fad0719c0ac51bbf2c04970948b

4 years agoEnsuring Control behaviour flags retain their original values 06/244906/2
David Steele [Fri, 25 Sep 2020 15:17:46 +0000 (16:17 +0100)]
Ensuring Control behaviour flags retain their original values

Change-Id: Iafa9a7450a093fad0719c0ac51bbf2c04970948b