Piers Daniell [Thu, 15 Feb 2018 19:33:15 +0000 (12:33 -0700)]
Account for differences in nan with fp16 comparison
When comparing fp16 values it's not possible to use a bitwise
comparison because there can be many different bit patterns
representing nan values, and all nans are equal. This CL updates
the computeCheckBuffersFloats function which compares two
buffers of fp16 values to take into account different forms
of nan.
Affects:
dEQP-VK.spirv_assembly.instruction.compute.16bit_storage.uniform_16_to_16.stress_test
Components: Vulkan
VK-GL-CTS issue: 1018
Change-Id: I77013b49ce070d9615b287eae24dd32731b314b1
(cherry picked from commit
92d5909ab99bc97dc2ae4dd67e1cfa592dafb246)
Alexander Galazin [Wed, 14 Mar 2018 08:46:16 +0000 (09:46 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-1.1.1
Change-Id: Id0a9cedc7822a3b3206e162f217f790d087c3392
Caio Marcelo de Oliveira Filho [Mon, 12 Mar 2018 17:25:58 +0000 (10:25 -0700)]
Fetch new tags when fetching new Git sources
Change-Id: I1a906ebf2698eac33c3acbf1da74df9642b775a2
Component: Framework
(cherry picked from commit
204d597504c94fa52ed0f5a2c21895482236d5cc)
Alexander Galazin [Mon, 12 Mar 2018 09:58:09 +0000 (10:58 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-1.1.1
Change-Id: I25a00d37394a47b90d7cdf0f51738e71f151f4f2
Alexander Galazin [Wed, 7 Mar 2018 15:45:21 +0000 (16:45 +0100)]
Update glslang, SPIR-V commits
Components: Framework
Affects: dEQP-VK.*
Change-Id: If5830108278597a28f8043dd947bed3c20c9688d
Alexander Galazin [Fri, 2 Mar 2018 13:15:50 +0000 (14:15 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-1.1.1
Change-Id: Ibf8696558e773e47e04e0f14e7b0deb566eaa5ce
Alexander Galazin [Fri, 2 Mar 2018 11:17:24 +0000 (12:17 +0100)]
Add a note to the README
Explain that the verification scrpt will report a warning
for a correctly generated git-log
Components: Vulkan
Change-Id: Ie8e0ab090f50c776150f9a7f4ce7d69583186953
Alexander Galazin [Fri, 2 Mar 2018 10:47:38 +0000 (11:47 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.0 vk-gl-cts/vulkan-cts-1.1.1
Change-Id: Ia75241c78980e6bac6358ade016d4849090f8444
Marcin Rogucki [Thu, 18 Jan 2018 09:55:07 +0000 (10:55 +0100)]
Validation errors fix in copying 3d images
A minor chages to fix validation errors.
Two tests are not passing currently!
Affected tests:
dEQP-VK.api.copy_and_blit.dedicated_allocation.image_to_image.3d_images.*
Components: Vulkan
VK-GL-CTS issue: 208
Change-Id: Id3c5ec869d52db6b1229f45bbeacf24e35e75e48
(cherry picked from commit
c23ba94d7978ba84f9ffd2e75b6afbf8e3395633)
Arkadiusz Sarwa [Tue, 27 Feb 2018 11:38:31 +0000 (12:38 +0100)]
Fix: Memory alignment
Affects:
dEQP-VK.memory.mapping*
Components: Vulkan
VK-GL-CTS issue: 1039
Change-Id: Ia5093148fa145c9eecc03fe3b76102cdf77ad472
Panagiotis Apostolou [Thu, 22 Feb 2018 15:28:54 +0000 (16:28 +0100)]
Spec relaxation for protected YCbCr Implicit chroma reconstruction
Incorporates spec relaxation in the protected memory YCbCr tests which
describes that when doing implicit reconstruction with nearest chroma
filtering, an implementation may behave as if both xChromaOffset and
yChromaOffset were VK_CHROMA_LOCATION_MIDPOINT.
Tests affected:
dEQP-VK.protected_memory.interaction.ycbcr.*
Components: Vulkan
VK-GL-CTS issue: 1032
Change-Id: I25ef589ed05b1b167475eb5b6d782b261b1b3532
Slawomir Cygan [Wed, 28 Feb 2018 18:11:21 +0000 (19:11 +0100)]
Set usable instance version in external memory tests
These tests were using vkEnumerateInstanceVersion() to get
instance version. This failed, when Vulkan 1.1 Loader is used with
Vulkan 1.0 ICD: the function was returning version 1.1,
so test was not requesting any needed instance extensions, as these
were assumed to be already in core.
This is out of sync with dispatch code dispatching to
1.0 + KHR extension functions, when calling entrypoints like
vkGetPhysicalDeviceExternalBufferProperties(). As no KHR extensions
were requested during instance creation, the behavior is undefined.
The dispatch code is using context.getUsedApiVersion() utility
to guess Vulkan version, so same utility should be used for instance
creation, avoiding raw calls to vkEnumerateInstanceVersion().
Components: Vulkan
VK-GL-CTS Issue: 1047, 854
Affects:
dEQP-VK.api.external.memory.*
dEQP-VK.api.external.fence.*
dEQP-VK.api.external.semaphore.*
Change-Id: Iecf9bb086e04c6d88118fee9c4867ac5647d1ab7
Panagiotis Apostolou [Thu, 22 Feb 2018 15:04:24 +0000 (16:04 +0100)]
Remove vertex stage variants from dEQP-VK.protected_memory.interaction.ycbcr.*
"Except for framebuffer-space pipeline stages, compute shader stage, and
transfer stage, any read from or write to protected memory during protected
queue operations results in undefined behavior"
The existing dEQP-VK.protected_memory.interaction.ycbcr.* group include
tests that sample the protected texture from inside the vertex shader. This
commit removes these tests.
Tests affected:
dEQP-VK.protected_memory.interaction.ycbcr.*
Components: Vulkan
VK-GL-CTS issue: 1031
Change-Id: I459da0f3028e418c90285e55fb17ac1fda8d8467
Alexander Galazin [Thu, 1 Mar 2018 14:12:16 +0000 (15:12 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-1.1.1
Change-Id: Id333c16da0ab9db53d16b15ca068c1232d093f58
Alexander Galazin [Thu, 1 Mar 2018 13:24:31 +0000 (14:24 +0100)]
Merge vk-gl-cts/vulkan-cts-1.0.2 into vk-gl-cts/vulkan-cts-1.1.0
Change-Id: I8c2317b97955bbee922af624b91287071fbc7661
Dae Kim [Fri, 23 Feb 2018 08:39:12 +0000 (08:39 +0000)]
Added missing gl_PointSizes when drawing points
Some tests using point list primitive topology were not specifying point
sizes with the gl_PointSize built-in.
Affects:
dEQP-VK.subgroups.*
dEQP-VK.synchronization.*
Components: Vulkan
VK-GL-CTS issue: 1035
Change-Id: I8588e26ee47c58f6ec4e9ee5fdce70546ec28903
Slawomir Cygan [Thu, 22 Feb 2018 17:55:01 +0000 (18:55 +0100)]
Do not access temporary C++ object members by reference
Fix undefined C++ behavior (resulting in errors when doing runtime memory checks),
where a temporary object returned by getInputAspects() method is used by a reference
to a member after the temporary is destructed.
It seems getInputAspects should just return reference.
Affects: dEQP-VK.renderpass.*.input*
Component: Vulkan
VK-GL-CTS Issue: 1033
Change-Id: I71edabed71ea63f46cdbc45c966d57cd020565ab
Peter Quayle [Wed, 21 Feb 2018 15:34:55 +0000 (15:34 +0000)]
Ensure sync_fd tests use valid file descriptors
The external.*.sync_fd.* tests fail on some implementations
because vkGet*FdKHR may return -1 (meaning pre-signalled) instead
of a valid file descriptor.
Affects:
dEQP-VK.api.external.semaphore.sync_fd*
dEQP-VK.api.external.fence.sync_fd*
Components: Vulkan
VK-GL-CTS issue: 957
Change-Id: I91087db1595a19605956dad460caa344e850491e
Dae Kim [Tue, 20 Feb 2018 13:37:39 +0000 (13:37 +0000)]
Fix verification in robust buffer access tests
Some buffer accesses to addresses less than 16 bytes away from the out
of bounds address where not considered potentially out of bounds, even
when there were out of bounds accesses in the same SPIR-V block.
Affects:
dEQP-VK.robustness.buffer_access.*:
Components: Vulkan
VK-GL-CTS issue: 1025
Change-Id: Ibcb61fb84cecc360d753ba5d3acc1f9d48169651
Dae Kim [Thu, 22 Feb 2018 15:43:54 +0000 (15:43 +0000)]
Added missing gl_PointSizes when drawing points
Some tests using point list primitive topology were not specifying
point sizes with the gl_PointSize built-in.
Affects:
dEQP-VK.subgroups.*
dEQP-VK.synchronization.*
Components: Vulkan
VK-GL-CTS issue: 1035
Change-Id: I6f1690adef24ac76103bc22a86405ceec77865f4
Alexander Galazin [Thu, 22 Feb 2018 13:03:32 +0000 (14:03 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-1.1.1
Change-Id: I8cb0743b2ee95da2aecc89a20310b735aeff36eb
Alexander Galazin [Thu, 22 Feb 2018 11:45:50 +0000 (12:45 +0100)]
Merge vk-gl-cts/vulkan-cts-1.0.2 into vk-gl-cts/vulkan-cts-1.1.0
Change-Id: I115b3e16d7282ef5f9abeb5bd382f744d891b5e3
Tom Cooper [Mon, 12 Feb 2018 16:20:58 +0000 (16:20 +0000)]
Fix low memory in dedicated_alloc buffer tests
Observe platform memory limits to avoid low memory conditions.
Components: Vulkan
VK-GL-CTS issue: 1008
Affects: dEQP-VK.api.buffer.dedicated_alloc.create_buffer_*
Change-Id: Ib184b648126e8cb6e1acff533447a86be9a1a612
Alexander Galazin [Wed, 14 Feb 2018 09:17:22 +0000 (10:17 +0100)]
Update glslang/spir-v headers tags
Components: Framework
Affects: dEQP-VK.*
Change-Id: I1282fe5924abfb86fba7d32d3c67b94993a252fe
Juan A. Suarez Romero [Fri, 10 Nov 2017 11:20:36 +0000 (11:20 +0000)]
Do not use depthClampEnable unconditionally.
Depth clamping is not needed by these tests, so
do not rely on the optional feature when creating
the pipeline object.
Affects:
dEQP-VK.spirv_assembly.*
Components: Vulkan
VK-GL-CTS issue: 846
Change-Id: I248759e6ac209ccbd7661068c3ef5f1dfb8ca501
(cherry picked from commit
d33f62c935d51b4ecba0b6b97ea1baafe67ea3f4)
Lionel Landwerlin [Fri, 9 Feb 2018 15:20:25 +0000 (15:20 +0000)]
YCbCr: go through the correct location ranges when sampling
Affects: dEQP-VK.ycbcr.conversion.*
Components: Vulkan
VK-GL-CTS issue: 1005
Change-Id: Ifac1026e82e1bb48195fc7ab5429951a15324042
Slawomir Cygan [Fri, 19 Jan 2018 13:20:47 +0000 (14:20 +0100)]
dEQP-VK.renderpass.sparserendertarget: bind metadata
Memory was not bound to METADATA aspect, when COLOR aspect
mip tail size was 0. METADATA requirements are not related
to mip tails in other aspects - memory must be always and
unconditionally bound to METADATA.
Additionally, change VK_SPARSE_IMAGE_FORMAT_SINGLE_MIPTAIL_BIT
condition to layerNdx == 0, as imageMipTailMemoryBinds vector
is now used both for metadata and other mip tails.
Affects: dEQP-VK.renderpass.sparserendertarget.*
Components: Vulkan
VK-GL-CTS issue: 958
Change-Id: I34661c82e0d9829448ac85546055c72151bfe85e
(cherry picked from commit
d04c2b650db561fb28f5888ae3de244fc70e6748)
Alexander Galazin [Mon, 5 Feb 2018 13:29:26 +0000 (14:29 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-1.1.1
Change-Id: I477feb14b24a78b12cd6cf72adbdfa4d997dbaf9
Alexander Galazin [Mon, 5 Feb 2018 12:13:44 +0000 (13:13 +0100)]
Merge vk-gl-cts/vulkan-cts-1.0.2 into vk-gl-cts/vulkan-cts-1.1.0
Change-Id: I36a59b8e50449e1788779380d6dc1dc4668b78fc
Vamsidhar Gaddam [Wed, 31 Jan 2018 10:23:48 +0000 (11:23 +0100)]
Pass in proper pWaitDstStageMask in vktWsiSharedPresentableImageTests
One of the submitInfos for a queue submit had
a semaphore passed in without passing in any stage mask. This is a
spec violation.
Affects:
dEQP-VK.wsi.android.shared_presentable_image.*
Components: Vulkan
VK-GL-CTS issue: 974
Change-Id: Iee2ea838e971a3610f44b8c1f765869a8a21fedb
Panagiotis Apostolou [Wed, 17 Jan 2018 09:01:58 +0000 (10:01 +0100)]
Spec relaxation for YCbCr Implicit chroma reconstruction
Incorporates spec relaxation in the YCbCr tests which describes that when
doing implicit reconstruction with nearest chroma filtering, an
implementation may behave as if both xChromaOffset and yChromaOffset were
VK_CHROMA_LOCATION_MIDPOINT.
Tests affected:
dEQP-VK.ycbcr.conversion.*
Components: Vulkan
VK-GL-CTS issue: 979
Change-Id: I10e83d2f5845c3e74673aa9e42fc4f0950f9e6cd
Boris Zanin [Mon, 22 Jan 2018 13:40:23 +0000 (14:40 +0100)]
Test only specified device in api group
Test does not require loop on devices which has not been requested.
Updates tests:
* dEQP-VK.api.info.get_physical_device_properties2.*
* dEQP-VK.api.info.sparse_image_format_properties2.*
* dEQP-VK.api.info.image_format_properties2.*
VK-GL-CTS issue: 942
Change-Id: If9f546ec7b98cafb1c8dc48664b76c3c9ab6c6b4
Components: Vulkan
Chris Forbes [Fri, 19 Jan 2018 00:58:18 +0000 (16:58 -0800)]
BC3-5: Remove potentially misaligned uint64 read
ARMv7 is fussy about this and explodes if src+2 isn't properly aligned,
which is likely to be the case.
VK-GL-CTS Issue: 954
Affects: dEQP-VK.texture.compressed.bc{3,4,5}*
Components: Framework
Change-Id: Idf0846603f4bf5d569a4084b8f399dd8da99221e
(cherry picked from commit
f87519fd1d59e2c9beb06feeeae08c58fd8b9a51)
Alexander Galazin [Thu, 1 Feb 2018 09:29:38 +0000 (10:29 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-1.1.1
Change-Id: I350e7704a0448e25ff4502659f8e6032adb78426
Noah Fredriks [Mon, 15 Jan 2018 21:09:55 +0000 (16:09 -0500)]
Fix illegal memory access for robustness test
Don't subtract 3 from buffer pointer for VK_FORMAT_A2B10G10R10_UNORM_PACK32
alpha channel because this format is a deUint32 instead of Vec4.
Affects: dEQP-VK.robustness.vertex_access.a2b10g10r10_unorm_pack32.*
Components: Vulkan
VK-GL-CTS issue: 946
Change-Id: I2a5241191e01252ce071658b8dbd79d3e424aa41
Slawomir Cygan [Fri, 29 Dec 2017 17:18:20 +0000 (18:18 +0100)]
Emit defined positions from tessellation shader in subgroups tests.
Use only defined components of gl_in[] in tessellation evaluation shader:
the tessellation control shader emits only one vertex in patch, so the value
of gl_in[1] is undefined. The code is changed to use only gl_in[0].
Additionally fix geometry shader input primitive topology, when tessellation
shaders are used: tessellation outputs isolines, so geometry input should
be lines, not points.
Affects: dEQP-VK.subgroups.*graphic
Components: Vulkan
VK-GL-CTS issue: 924
Change-Id: Id1984a387a32c50e0f86638bf3d6b0273a7633d8
(cherry picked from commit
36a60de573f65194c50271fc5b9d9a137fba0bb5)
Alexander Galazin [Fri, 19 Jan 2018 10:37:36 +0000 (11:37 +0100)]
Remove 1.0.4 mustpass
Components: Vulkan
Change-Id: I75fc3abc5019333c737f5ee4c1f0690931311ec0
Alexander Galazin [Fri, 19 Jan 2018 10:29:40 +0000 (11:29 +0100)]
Merge vk-gl-cts/master into vk-gl-cts/vulkan-cts-next-dev
Change-Id: Ifd7bec720796fbd7006b44107d5c76e1c0c5f3d4
Alexander Galazin [Fri, 19 Jan 2018 10:13:42 +0000 (11:13 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-next-dev
Change-Id: Ia06040e7f84f8386c066321a4dae3551cc3a4ee6
Alexander Galazin [Fri, 19 Jan 2018 10:12:43 +0000 (11:12 +0100)]
Merge vk-gl-cts/vulkan-cts-1.0.3 into vk-gl-cts/master
Change-Id: I2de5195522bb42f25a2eb7181b366c8284ef7fec
Alexander Galazin [Fri, 19 Jan 2018 09:08:43 +0000 (10:08 +0100)]
Merge vk-gl-cts/vulkan-cts-1.0.2 into vk-gl-cts/vulkan-cts-1.1.0
Change-Id: I8db9696a5f7b9bafdf20e76afc8d1d42b96cfe1c
Alexander Galazin [Fri, 19 Jan 2018 08:22:31 +0000 (09:22 +0100)]
Merge vk-gl-cts/vulkan-cts-1.0.2 into vk-gl-cts/vulkan-cts-1.0.3
Change-Id: Ie1eb632fc4601acfc34db84410e04e06cc2da243
Yanjun Zhang [Wed, 10 Jan 2018 00:12:47 +0000 (16:12 -0800)]
Check GS support before testing adjacent primitives
Affects: dEQP-VK.draw.basic_draw.draw.*
Components: Vulkan
VK-GL-CTS issue: 926
Change-Id: I02569b1944eed52f641966f9206d44983d1ff165
Chris Forbes [Wed, 10 Jan 2018 02:13:15 +0000 (18:13 -0800)]
Fix buffer usage flags for index and indirect buffers
Previously, createAndUploadBuffer would provide
VK_BUFFER_USAGE_VERTEX_BUFFER_BIT for all buffers. This is no good for
index buffers and indirect buffers.
VK-GL-CTS: 930
Change-Id: I774beef7c7226f4fbd5670591eb66475300ee208
Components: Vulkan
Affects: dEQP-VK.draw.instanced.*
Alexander Galazin [Thu, 18 Jan 2018 18:08:45 +0000 (19:08 +0100)]
Merge vk-gl-cts/master into vk-gl-cts/vulkan-cts-next-dev
Change-Id: I393180401a87496592f4b43ca217484b3b26f462
Alexander Galazin [Thu, 18 Jan 2018 17:17:45 +0000 (18:17 +0100)]
Freeze 1.0.3 mustpass, add 1.0.4 mustpass
Components: Vulkan
Change-Id: I163d9767ad526b4a0f040a24fd5f5af86f6ef7c5
Alexander Galazin [Mon, 15 Jan 2018 12:40:19 +0000 (13:40 +0100)]
Create vulkan-cts-1.1.1 mustpass
Components: Vulkan
Change-Id: Ib7b5d3122043af4c15fa61c24f4534343766d0ce
Alexander Galazin [Thu, 18 Jan 2018 11:45:57 +0000 (12:45 +0100)]
Merge vk-gl-cts/master into vk-gl-cts/vulkan-cts-next-dev
Change-Id: I8464376bd5521a932cda7757dda02bdad6c3d302
Alexander Galazin [Thu, 18 Jan 2018 11:07:31 +0000 (12:07 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-next-dev
Change-Id: I208568cce771d2cb51be811ca4bc9bf500b95f28
Alexander Galazin [Thu, 18 Jan 2018 09:51:33 +0000 (10:51 +0100)]
Merge vk-gl-cts/vulkan-cts-1.0.2 into vk-gl-cts/master
Change-Id: Ibf30bd51afce5e0e6363eb94ea2cd9293cbb35d9
Alexander Galazin [Thu, 18 Jan 2018 09:51:31 +0000 (10:51 +0100)]
Merge vk-gl-cts/vulkan-cts-1.0.2 into vk-gl-cts/vulkan-cts-1.1.0
Change-Id: I79e2e20649232a7ebd78088981f06ade6c5e6323
Piers Daniell [Fri, 5 Jan 2018 21:04:29 +0000 (14:04 -0700)]
Add VK_ACCESS_SHADER_READ_BIT barrier access bit
The dEQP-VK.query_pool.statistics_query.compute_shader_invocations.secondary*
tests were missing a VK_ACCESS_SHADER_READ_BIT bit in the
pipeline barrier between compute dispatch calls. Each dispatch
was doing a read-modify-write of the same SSBO locations, but
the test only used the VK_ACCESS_SHADER_WRITE_BIT access bit.
This may cause the compute shader to read stale cache data
since the dependency between each dispatch was not expressed
correctly.
This fix simple adds the missing VK_ACCESS_SHADER_READ_BIT
access bit.
Affects:
dEQP-VK.query_pool.statistics_query.compute_shader_invocations.secondary*
Components: Vulkan
VK-GL-CTS issue: 927
Change-Id: I946d6113c897a03116db7a93a182e27497adfe6f
Alexander Galazin [Mon, 15 Jan 2018 13:18:51 +0000 (14:18 +0100)]
Properly iterate over pNext in VkSamplerCreateInfo
Iterate over all pNext elements in VkSamplerCreateInfo.
Skip VkSamplerYcbcrConversionInfoKHR, retrieve
reduction mode from VkSamplerReductionModeCreateInfoEXT
VK-GL-CTS issue: 945
Components: Vulkan
Affects:
dEQP-VK.ycbcr.*
dEQP-VK.api.info.format_properties.*
dEQP-VK.pipeline.sampler.view_type.*.format.(any color format).min_reduce.*
dEQP-VK.pipeline.sampler.view_type.*.format.(any color format).mag_reduce.*
dEQP-VK.pipeline.sampler.view_type.*.format.(any depth format)
Change-Id: Iaba8678f2fa13b5545cec7f903f21aa01c5c13f3
Arkadiusz Sarwa [Wed, 20 Dec 2017 16:09:03 +0000 (17:09 +0100)]
Fix: Validation errors dEQP-VK.synchronization.op.multi_queue
Affects:
dEQP-VK.synchronization.op.multi_queue*
Components: Vulkan
VK-GL-CTS issue: 220
Change-Id: Iba71d1d3e9e8ce0e0698b71af44bdcc3b8ae502c
Arkadiusz Sarwa [Thu, 21 Dec 2017 11:13:17 +0000 (12:13 +0100)]
Fix: Validation errors in dEQP-VK.api.image_clear*
Affects:
dEQP-VK.api.image_clearing*
Components: Vulkan
VK-GL-CTS issue: 209
Change-Id: Ib66683d75360d023497f7cd5387eeca7342e36b6
Yanjun Zhang [Thu, 11 Jan 2018 19:44:54 +0000 (11:44 -0800)]
Set maxDescriptorSet* limit table based on shader stages
Re-submit the patch based on WG review and feedback.
Affects: dEQP-VK.api.info.device.properties
Components: Vulkan
VK-GL-CTS issue: 923
Change-Id: Ie627b52cfae099d87f5b6183118d42bcccd313ca
Piers Daniell [Tue, 8 Aug 2017 22:03:35 +0000 (16:03 -0600)]
Avoid out-of-range depth values
The "d32_sfloat_large_depth" variants of the
dEQP-VK.glsl.builtin_var.fragdepth.* tests rely on undefined behavior
because it uses an out-of-range depth value. The unextended Vulkan spec
requires depth values to be in the range of 0.0..1.0. The test was using
a depth value of 20.0..21.0 and expecting the implementation to clamp.
Instead of disabling this part of the test entirely, only run it if the
implementation exposes the VK_EXT_depth_range_unrestricted device
extension, which does have defined behavior with depth values outside
the range of 0.0..1.0.
Affects:
dEQP-VK.glsl.builtin_var.fragdepth.*d32_sfloat_large_depth
Components: Vulkan
VK-GL-CTS issue: 623
Change-Id: I436b8b98bebe3ef37bd306d93da2bf8c40eee6c8
Alexander Galazin [Mon, 15 Jan 2018 12:47:05 +0000 (13:47 +0100)]
vk-default-no-waivers mustpass
Components: Vulkan
Change-Id: Iec7c2a45663cc318a67614c9e28b8631f1bd1faf
Boris Zanin [Wed, 10 Jan 2018 12:15:36 +0000 (13:15 +0100)]
Add INTxx_MAX checks into check_all.py
The mentioned consts are not defined in Windows, but are defined in linux.
Presence of this consts breaks Windows builds. To make it easyily detectable
under linux additional check for [U]INT[8,16,32,64]_MAX consts is added
into check_all.py script.
Components: Framework
VK-GL-CTS Issue: 934
Change-Id: I1882c0cd283a63a623972cb69ffb292531e37d10
Boris Zanin [Wed, 10 Jan 2018 12:15:36 +0000 (13:15 +0100)]
Add INTxx_MAX checks into check_all.py
The mentioned consts are not defined in Windows, but are defined in linux.
Presence of this consts breaks Windows builds. To make it easyily detectable
under linux additional check for [U]INT[8,16,32,64]_MAX consts is added
into check_all.py script.
Components: Framework
VK-GL-CTS Issue: 934
Change-Id: I1882c0cd283a63a623972cb69ffb292531e37d10
Alexander Galazin [Mon, 15 Jan 2018 11:15:02 +0000 (12:15 +0100)]
Update GL mustpass
Components: OpenGL
Change-Id: I378bf119d71b2e8b9785458bb9972452ebbadd58
Alexander Galazin [Mon, 15 Jan 2018 11:09:02 +0000 (12:09 +0100)]
Update GL mustpass
Components: OpenGL
Change-Id: Ie2d64d15337e36947ac265a4c0a733440ceeefa0
Alexander Galazin [Fri, 12 Jan 2018 16:19:55 +0000 (17:19 +0100)]
Merge vk-gl-cts/master into vk-gl-cts/vulkan-cts-next-dev
Change-Id: Iace4a50e10d78067beecb94411081c10e9cef548
Alexander Galazin [Fri, 12 Jan 2018 16:02:58 +0000 (17:02 +0100)]
Merge vk-gl-cts/opengl-cts-4.6.0 into vk-gl-cts/master
Change-Id: If8425e73545dec10d8501eb6fb75be5200332e65
Alexander Galazin [Fri, 12 Jan 2018 15:52:48 +0000 (16:52 +0100)]
Merge vk-gl-cts/opengl-es-cts-3.2.4 into vk-gl-cts/master
Change-Id: Ie914b0dd7b4facbfa83b89e7d41c8390446843c6
Alexander Galazin [Fri, 12 Jan 2018 15:22:08 +0000 (16:22 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-next-dev
Change-Id: Ib38b622a59b949722abdf41760f2ff8ed7d4787c
Alexander Galazin [Fri, 12 Jan 2018 14:45:22 +0000 (15:45 +0100)]
Merge vk-gl-cts/master into vk-gl-cts/vulkan-cts-next-dev
Change-Id: I21ee4ea4482cec0be95befa2603c3ab9453e0027
Alexander Galazin [Fri, 12 Jan 2018 14:03:32 +0000 (15:03 +0100)]
Merge vk-gl-cts/vulkan-cts-1.0.2 into vk-gl-cts/vulkan-cts-1.1.0
Change-Id: I02ba5bcb0273934d93d91e2375f9d272c6c69904
Alexander Galazin [Fri, 12 Jan 2018 14:02:07 +0000 (15:02 +0100)]
Merge vk-gl-cts/vulkan-cts-1.0.2 into vk-gl-cts/master
Change-Id: I9dc9a99346b7d4079166b53ecbc847568291864e
Maciej Jesionowski [Thu, 5 Oct 2017 12:40:53 +0000 (14:40 +0200)]
Fix instance-rate vertex attribute verification
There was a bug in the test where it expected instance-rate vertex
attribute data at incorrect offsets in the input buffer. As a result
these attributes were always treated as out of bounds.
Affects: dEQP-VK.robustness.vertex_access.*
VK-GL-CTS issue: 752
Components: Vulkan
Change-Id: Ied900ab4174d4e8c25fd07c95e90d3c8228d5a26
Maciej Jesionowski [Mon, 23 Oct 2017 10:14:36 +0000 (12:14 +0200)]
Add missing barrier to texel_view_compatible tests
There was no GPU to Host barrier. GPU writes are not automatically
visible to the Host.
Affected tests: dEQP-VK.image.texel_view_compatible.compute.*
VK-GL-CTS issue: 786
Components: Vulkan
Change-Id: I47797add1c5e48dfa1a7c7be8897e822091c2044
Andrey Tuganov [Thu, 28 Sep 2017 21:18:51 +0000 (17:18 -0400)]
Remove OpUConvert to signed integer tests
OpUConvert only convers to unsigned integers.
Affects: dEQP-VK.spirv_assembly.instruction.
compute.uconvert.*
Components: Vulkan
VK-GL-CTS issue: 720
Change-Id: I68b13c8584d64359e52910091347de03b933ba42
Marcin Rogucki [Wed, 25 Oct 2017 11:33:44 +0000 (13:33 +0200)]
gl_PrimitiveIDIn tests have sketchy loop bounds.
Components: Vulkan
VK-GL-CTS issue: 778
Updates:
dEQP-VK.geometry.basic.primitive_id_in
dEQP-VK.geometry.basic.primitive_id_in_restarted
Change-Id: Icd2be56814de18067ce058a5f2a1da80338f80d6
(cherry picked from commit
52b7de31e0bccf62ca28d820f4dc2d0d52793aa8)
Tom Cooper [Wed, 25 Oct 2017 06:26:39 +0000 (08:26 +0200)]
YCbCr image views need a VkSamplerYcbcrConversionInfo
Ensure the image views are created using the
VkSamplerYcbcrConversionInfo object via the pNext
chaining, as this is mandated by the Spec.
Affects:
dEQP-VK.ycbcr.query.*
Components: Vulkan
VK-GL-CTS issue: 788
Change-Id: If641b08432c26ca5b32c084c4c0b9c7f935bcb94
(cherry picked from commit
9a9419aa130a51b6e24a564e6a3997a88af2504e)
Yanjun Zhang [Wed, 10 Jan 2018 00:26:50 +0000 (16:26 -0800)]
Check sampleRateShading for sample_qualifier_distinct_values.* tests
Affects: dEQP-VK.pipeline.*.sample_qualifier_distinct_values.*
Components: Vulkan
VK-GL-CTS issue: 925
Change-Id: Ife1166e8ed88699c67ee6acde79857f34c013398
Chris Forbes [Tue, 9 Jan 2018 23:26:34 +0000 (15:26 -0800)]
Use unique indices for each binding in out_of_pool_memory test
Previously, all the layout bindings would use binding=0, which is
invalid. Give them their own binding indices.
VK-GL-CTS: 929
Change-Id: I28e62db6c257ed0843dd9b77b2d8cb01d02e3eba
Components: Vulkan
Affects: dEQP-VK.api.descriptor_pool.out_of_pool_memory
Piers Daniell [Wed, 18 Oct 2017 17:01:13 +0000 (11:01 -0600)]
Avoid hitting fp16 NaN values
Modify the test references values to avoid situations where
they hit NaN values when viewed as fp16. This can happen
when uploading {0.1, 0.5, 0.9, 0.2} to r8g8b8a8_unorm which,
depending on the rounding of the 0.5, could end up as a 0x7F
value which when viewed as the MSB of a fp16 value is a NaN.
Affects:
dEQP-VK.image.mutable.*
Components: Vulkan
VK-GL-CTS Issue: 784
Change-Id: I2adbd27aa7d94254c9f19d788eacace2ea95d10c
(cherry picked from commit
d51c248f04b980406d9b767064170b77b682cac7)
Alex Walters [Wed, 13 Dec 2017 15:47:23 +0000 (15:47 +0000)]
Invalid handle in create_display_plane_surface
This test attempts to create a display plane surface but incorrectly
fills in the VkDisplaySurfaceCreateInfo with an index into dEQP's array
of display modes instead of the VkDisplayModeKHR handle itself.
The app is required to specify a valid handle.
An invalid handle results in undefined behaviour.
Affects:
dEQP-VK.wsi.display.create_display_plane_surface
Components: Vulkan
VK-GL-CTS issue: 906
Change-Id: I9fbbd40926e26bf82ed11dc1b5e807922cbc4e73
(cherry picked from commit
3e6306a1f1abba17d9b3f4e36913576fa33ac13d)
Piers Daniell [Wed, 22 Nov 2017 20:23:12 +0000 (13:23 -0700)]
Fix some CTS bugs that cause validation failures
Most of these are misuse of the dstStageMask parameter to
vkCmdPipelineBarrier. The dstStageMask has to be compatible
with the destination access type of the buffer or image.
The other large source of validation errors is a bug
in the CTS framework when calling vkCreateDevice. The
wrong pNext member was used for setting the enabled
features. The effect is that all features were disabled.
Affects:
dEQP-VK.pipeline.push_constant.graphics_pipeline.*
dEQP-VK.pipeline.multisample_shader_builtin.sample_mask.pattern.*
dEQP-VK.*
Components: Vulkan
VK-GL-CTS issue: 862
Change-Id: I58ca4e033d7d66b52c6726a635808b9b747546d8
(cherry picked from commit
23336be1abda90e87d9bbaf5e0398ca489f0cbc6)
Alexander Galazin [Fri, 6 Oct 2017 20:07:30 +0000 (22:07 +0200)]
Add StorageImageExtendedFormats cap check
dEQP-VK.image.texel_view_compatible.compute.* didn't check
for shaderStorageImageExtendedFormats
Component: Vulkan
VK-GL-CTS issue: 753
Affects:
dEQP-VK.image.texel_view_compatible.compute.*
Change-Id: I957329a66d2f4bedb950a597a702ec29680418de
(cherry picked from commit
1a42786b8dba4e091e1012a458d3ad17457a6b66)
Noah Fredriks [Thu, 9 Nov 2017 21:00:29 +0000 (16:00 -0500)]
Enforce OOB requirements for binding with multiple attributes
The spec states that, if any vertex input attribute using a specific
vertex input binding is out of bounds, then all vertex input attributes
using that vertex input binding for that vertex shader invocation are
considered out of bounds.
Affects: dEQP-VK.robustness.vertex_access.*.vertex_incomplete
Components: Vulkan
VK-GL-CTS issue: 848
Change-Id: I6a9222a0b2a53368af361419105793a5301a6bf6
(cherry picked from commit
65df12f839cea43333b11a4da900f838d5f44150)
Tom Cooper [Wed, 22 Nov 2017 15:57:37 +0000 (15:57 +0000)]
Pipeline must be bound before calling vkCmdSetViewport/Scissor etc
Affects:
dEQP-VK.dynamic_state.*
Components: Vulkan
VK-GL-CTS issue: 861
Change-Id: I0f5312c83096cebebfa4ab01987c2ab9ede7306b
(cherry picked from commit
f156345ea872a2913b09b076373bea715f89e3c9)
Alexander Galazin [Mon, 2 Oct 2017 07:13:02 +0000 (09:13 +0200)]
Remove check for depthBounds support in frag depth tests
The tests validate gl_FragDepth. This builtin should not
require any extra feature to be supported.
Components: Vulkan
VK-GL-CTS: 690
Affects: dEQP-VK.glsl.builtin_var.fragdepth.*
Change-Id: I7df775d074e5b9e6dd01f573f5a8545f3db72550
(cherry picked from commit
822f7251791c8b75ad1733c5fc6b4ec3240000ea)
Alexander Galazin [Tue, 3 Oct 2017 19:29:50 +0000 (21:29 +0200)]
Invalidate memory in draw tests
The test group writes to non-coherent device memory with device,
but fails to call the required invalidate on the region before
reading mapped memory with host.
Components: Vulkan
VK-GL-CTS issue: 529
Affects: dEQP-VK.draw.*
Change-Id: Icf4aa6ea80c8c046e41b37402457b7f094d7ae50
(cherry picked from commit
1ce6e233a6245a1cf81a2a4e88b87c5d381a119a)
Slawomir Cygan [Fri, 22 Sep 2017 15:23:05 +0000 (17:23 +0200)]
Avoid assert in dEQP-VK.tessellation.fractional_spacing
The test code dereferences first element of empty std::vector, what
may cause an assert in debug builds (depending on toolchain and it's
settings).
Addects: dEQP-VK.tessellation.*
Components: Vulkan
VK-GL-CTS issue: 710
Change-Id: I2b94a0d03c3523ebf1380a9371765c616fd21b82
(cherry picked from commit
b81810d2446bac26ea0d5fb017250934842eb643)
Petros Bantolas [Mon, 18 Sep 2017 16:07:22 +0000 (17:07 +0100)]
Fix depth & stencil passOp for pipeline.render_to_image tests
Affects:
dEQP-VK.pipeline.render_to_image.*_array* with stencil attachments
Those tests render to each layer of the texture in consecutive
subpasses. With a depth/stencil passOp of VK_STENCIL_OP_ZERO, subpasses
after the first one fail the stencil test and skip the render.
Components: Vulkan
VK-GL-CTS issue: 678
Change-Id: Ia704192b8d7e316dacaa7549faa5cb5aa0def60e
(cherry picked from commit
09c67dc11c94f48a03a91c5be920fb940cdc792c)
Arkadiusz Sarwa [Tue, 12 Sep 2017 11:28:39 +0000 (13:28 +0200)]
Fix unreasonable memory expectations in pipeline.render_to_image
Affects:
dEQP-VK.pipeline.render_to_image.*
Components: Vulkan
VK-GL-CTS issue: 526
Change-Id: I71ea0381663c39786b227ed712e1111ec3c71cfb
(cherry picked from commit
069aa0ad097f543438b39a260eea52278867ffa8)
Alexander Galazin [Thu, 11 Jan 2018 17:13:22 +0000 (18:13 +0100)]
Merge vk-gl-cts/master into vk-gl-cts/vulkan-cts-next-dev
Change-Id: I95cda6e257642011069b0f6a85f138a4c2cd2e7c
Piers Daniell [Wed, 4 Oct 2017 16:51:12 +0000 (10:51 -0600)]
Fix imageExtent to use correct destination size
This fixes an issue with using imageParms to specify the
imageExtent for the cases where the test has done scaling
between the source and destination surfaces.
VK-GL-CTS issue: 729
Affects:
dEQP-VK.api.copy_and_blit.*
Change-Id: I4053496dfa1fdedd9edb7e108e554cb988559bcf
Components: Vulkan
(cherry picked from commit
16986d105c5af4c4ef6f8f54df5c42ec5c357bb5)
Alexander Galazin [Thu, 11 Jan 2018 14:50:08 +0000 (15:50 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-next-dev
Change-Id: I191f96b23d496c05d52f24b759952fd091885c21
Alexander Galazin [Thu, 11 Jan 2018 12:40:43 +0000 (13:40 +0100)]
Merge vk-gl-cts/vulkan-cts-1.0.2 into vk-gl-cts/master
Change-Id: Iff4b07d342db175706efd91f3197b93cb51b520d
Alexander Galazin [Thu, 11 Jan 2018 12:40:39 +0000 (13:40 +0100)]
Merge vk-gl-cts/vulkan-cts-1.0.2 into vk-gl-cts/vulkan-cts-1.1.0
Change-Id: I918575ed59c764d988fb98b718745605c5285b06
Alexander Galazin [Thu, 11 Jan 2018 09:09:54 +0000 (10:09 +0100)]
Merge vk-gl-cts/aosp-deqp-dev into vk-gl-cts/master
Change-Id: I89462b96db4a611bd2e5fc6727b42b3d6c6d7d5c
Chris Forbes [Wed, 10 Jan 2018 19:42:41 +0000 (11:42 -0800)]
Build prebuilts for HLSL shaders
Previously these prebuilts would be missing, causing all the HLSL tests
to fail when run via the Android CTS integration which relies on them.
VK-GL-CTS Issue: 939
Change-Id: Ib69f884818ea24692222cc74d8b69b0e0bcb465d
Components: Vulkan
Affects: dEQP-VK.*hlsl*
Ari Suonpaa [Wed, 29 Nov 2017 05:25:08 +0000 (07:25 +0200)]
Add compressed BC format support for TCU.
Added support for BC1-7 formats into TCU and extended Vulkan
compressed texture test to include these new formats.
Affects: dEQP-VK.texture.compressed.bc*
Components: Vulkan
VK-GL-CTS issue: 787
Change-Id: Ice0e6472987984e26c3cb8a5efd733944de870a9
Piers Daniell [Thu, 30 Nov 2017 21:40:00 +0000 (14:40 -0700)]
Skip allocation subtests that allocate too much VA
For 32-bit builds of CTS we can't allocate more host visible
memory than there is virtual address space for the process
since the allocation will fail and cause a false negative
result.
This CL skips over host visible allocations that would add
up to more than 1.5GB of virtual address space. This can
happen on platforms that expose very large heaps that
support memory types that include host visible memory.
The implementation can't cap the available memory size
since the heap can support allocations of memory other
than host visible and it doesn't want to restrict those
that don't consume CPU virtual address space. Its up
to CTS to limit how much virtual address space it
chooses to allocate.
Affects:
dEQP-VK.memory.allocation.basic.percent_1.*.count_12
Components: Vulkan
VK-GL-CTS issue: 859
Change-Id: I321f5cad567245571722f53397df26e23a4cee97
Alexander Galazin [Wed, 10 Jan 2018 10:34:00 +0000 (11:34 +0100)]
Update gl.xml revision
Change-Id: I7cb16bd139e801df2d2090ad5dd5d6267a6d19f9
Component: Framework
Marcin Rogucki [Wed, 13 Dec 2017 14:07:32 +0000 (15:07 +0100)]
Fix for #895 - physical_device_groups testing
For 1.1 version instances we do not require physical devices groups extension to be supported. Instead on 1.1 instances we just assume it's now a part of core implementation.
Components: Vulkan
VK-GL-CTS issue: 895
Affects: All tests using createInstanceWithExtension function
Change-Id: Ib11999498c28156e1e5d0c5e9025cb6ca4ba75a0
Noah Fredriks [Fri, 3 Nov 2017 18:20:06 +0000 (14:20 -0400)]
Round up vertex buffer size to stride multiple to fix OOB attribute reads
Partial stride multiple vertex buffer elements are now considered OOB
to accomodate implementations that fetch stride-sized elements
Affects: dEQP-VK.texture.*
Components: Vulkan
VK-GL-CTS issue: 812
Change-Id: I72a2143146b4ea0d893d70d41b7ca2c84c34542a
(cherry picked from commit
50c0544ec8c2e99158bf8a375eacfc9baf364a91)
Piotr Byszewski [Wed, 27 Sep 2017 09:29:27 +0000 (11:29 +0200)]
Test OES_texture_3D
Test functions added to ES2 by GL_OES_texture_3D.
Components: OpenGL
VK-GL-CTS issue: 8, 139
Affects:
KHR-GLES2.texture_3d.*
Change-Id: I652cfc9dc4cfb02cf653f557f7fdd0219e5b90ac