platform/upstream/VK-GL-CTS.git
2 years agoImprove checkSupport in memoryRequirements tests
Ilkka Saarelainen [Thu, 23 Dec 2021 13:05:42 +0000 (15:05 +0200)]
Improve checkSupport in memoryRequirements tests

checkSupport Function in dEQP-VK.api.buffer_memory_requirements.*
tests were incomplete and didn't check for VK_KHR_video_queue
extension.

This CL improves the checkSupport function of those tests by adding
the extension check. This CL includes also some other minor improvements
for the checkSupport function.

Components: Vulkan

VK-GL-CTS issue: 3424

Affects:

dEQP-VK.api.buffer_memory_requirements.*

Change-Id: Ie7ca94e3f56a270d981d5538516212cbc688d801

2 years agoFix validation errors in buffer memory requirement tests
Ilkka Saarelainen [Wed, 12 Jan 2022 09:49:26 +0000 (11:49 +0200)]
Fix validation errors in buffer memory requirement tests

Some of the buffer memory requirement tests were causing a lot
of validation errors related to invalid videoCodecOperation value.
The tests were using VK_VIDEO_CODEC_OPERATION_INVALID_BIT_KHR while
creating the buffers and that is not allowed.
This CL changes the tests to include one encode and one decode video
profile in VkBufferCreateInfo.pNext chain when the buffer usage flags
contain any decode or encode bits.

Components: Vulkan

Affects:

dEQP-VK.api.buffer_memory_requirements.*video_usage_bits

VK-GL-CTS Issue: 3423

Change-Id: I40f981db0a53b622c5abfb58f58ce3b36772b175

2 years agoMerge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Matthew Netsch [Sun, 23 Jan 2022 01:56:51 +0000 (01:56 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1

Change-Id: I262c53439a37757a2b000b0529f74f5da064b84c

2 years agoAdditions to VARYING_SUBGROUP_SIZE and FULL_SUBGROUPS_BIT tests
Antto Mäkinen [Tue, 14 Dec 2021 14:29:28 +0000 (16:29 +0200)]
Additions to VARYING_SUBGROUP_SIZE and FULL_SUBGROUPS_BIT tests

The behavior in VK_EXT_subgroup_size_control is assumed by default when
using SPIR-V 1.6. This CL adds variants of the existing tests for
subgroup_size_control where instead of adding these flags, a SPIR-V 1.6
module is used.

VK-GL-CTS issue: 3072

New Tests:
dEQP-VK.subgroups.size_control.*_spirv16

Components: Vulkan
Change-Id: I374f56e4ff8f6d971785a53e50667214cc536689

2 years agoUpdate vulkan-docs to main
Matthew Netsch [Sat, 22 Jan 2022 18:30:18 +0000 (13:30 -0500)]
Update vulkan-docs to main

Components: Framework, Vulkan
Affects:
dEQP-VK.*

Change-Id: I930c36d5c7bc50cb62f130cac58731c294b6f687

2 years agoMerge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Matthew Netsch [Sat, 22 Jan 2022 18:18:42 +0000 (13:18 -0500)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0

Change-Id: I6be2d3495b8e5badf3441ba4a40b4b1f8163f2de

2 years agoRelax precision for matrix precision tests
James Fitzpatrick [Wed, 19 Jan 2022 11:46:20 +0000 (11:46 +0000)]
Relax precision for matrix precision tests

The Vulkan spec does not specify the precision for inverse and
determinant built in functions, however newly added tests effecitively
adds a precision requirement for them.

The precision required in these tests is too high for some valid
implementations of these builtin functions.

Relax the precision required in the tests to allow valid
implementations to pass.

Affects:
dEQP-VK.glsl.builtin.precision*.determinant.*
dEQP-VK.glsl.builtin.precision*.inverse.*

Compontents: vulkan

VK-GL-CTS issue: 3182

Change-Id: Ib4c5b9d04578732456b8f981bc82a2c86ad877fa

2 years agoSkip the "two_draw" variants of zero_stride_with_offset tests
Shih-hsin Li [Mon, 17 Jan 2022 04:33:09 +0000 (04:33 +0000)]
Skip the "two_draw" variants of zero_stride_with_offset tests

There's only one vertex in vertex array for singleVertex config.
Non-zero stride can cause out of bound memory access error since
vkd.cmdDraw draws 6(singleVertexDrawCount) vertices in singleVertex
config.

Affects:
dEQP-VK.pipeline.extended_dynamic_state.*.zero_stride_with_offset

Components: Vulkan

VK-GL-CTS issue: 3463

Change-Id: I77baa395c40f74f518bc9c7e8daf32c87686868a

2 years agoMerge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Matthew Netsch [Sat, 22 Jan 2022 16:26:06 +0000 (11:26 -0500)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8

Change-Id: I4e8734003d9e689045fd25601bc521a4fb119f0b

2 years agoMerge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7
Matthew Netsch [Fri, 21 Jan 2022 21:36:09 +0000 (16:36 -0500)]
Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7

Change-Id: Iab61e615b3f7d5b108d925150255a73171e3d438

2 years agoMerge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6
Matthew Netsch [Fri, 21 Jan 2022 17:33:04 +0000 (12:33 -0500)]
Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6

Change-Id: If56557dcb21ca8bfd90acbb2fffbd3f8ceed16f2

2 years agoRe-enable Clang warning for Amber
Mika Väinölä [Tue, 11 Jan 2022 07:45:02 +0000 (09:45 +0200)]
Re-enable Clang warning for Amber

The Amber version used by vulkan-cts-1.2.5 and later includes 4d0115c
which should fix all suggest-destructor-override warnings.

Components: Framework, Vulkan

VK-GL-CTS issue: 3361

Change-Id: I36437c797c067521e1444d20cfece33babfe435a

2 years agoGCC 11 build fixes
Mika Väinölä [Thu, 13 Jan 2022 08:00:09 +0000 (10:00 +0200)]
GCC 11 build fixes

Some files used std::numeric_limits without including <limits> and
failed to compile.

VK-GL-CTS issue: 2842

Change-Id: I21e37ce38db08c7c7041f4628ac852588a788852

2 years agoMerge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5
Matthew Netsch [Thu, 20 Jan 2022 21:10:44 +0000 (21:10 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5

Change-Id: I790e54266657e91c84b9e40f6eb7385914d569c6

2 years agoDecrease required subgroup size
Ilkka Saarelainen [Wed, 17 Feb 2021 11:33:22 +0000 (13:33 +0200)]
Decrease required subgroup size

dEQP-VK.spirv_assembly.instruction.spirv1p4.entrypoint.comp_workgroup_entry_point
test assumed that the subgroupSize is >= 8. The test failed if the
supported subgroupSize is less than 8.

This CL lowers the required subgroup size to 4.

Affects:
dEQP-VK.spirv_assembly.instruction.spirv1p4.entrypoint.comp_workgroup_entry_point

Components: Vulkan

VK-GL-CTS issue: 2698

Change-Id: I9931dab7a57c0b6b73530e72bca0c0d9cc90f87d
(cherry picked from commit 8f9b9137470ed5b0cd0b38edd9e9c28ccf565731)

2 years agoFix for potentially uninitialized variables
Jari Komppa [Tue, 11 Jan 2022 14:58:31 +0000 (16:58 +0200)]
Fix for potentially uninitialized variables

This change adds a constructor for a struct which sets the members that
do not have a constructor of their own to known values.

This potentially affects anything that uses the reference rasterizer,
but should not change any test results.

Affects:
*

Components: Framework
VK-GL-CTS issue: 3434

Change-Id: Ie874b4baa4d2ff5a8aa66f9ea2c3cd11b37edb64

2 years agoMerge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/vulkan-cts-1.2.4
Matthew Netsch [Thu, 20 Jan 2022 17:01:38 +0000 (17:01 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/vulkan-cts-1.2.4

Change-Id: I3080cbdc60602f0faea714502bbc5461cac257e0

2 years agoFix NULL/False to std::string conversion errors
Mika Väinölä [Fri, 17 Dec 2021 07:10:19 +0000 (09:10 +0200)]
Fix NULL/False to std::string conversion errors

Newer versions of GCC reject std::string(DE_NULL). Previously this
didn't cause any errors or warnings when compiling, but should produce
an error at runtime. This change replaces invalid values with empty
string literals and adds deFatalStr for cases that potentially
relied on the string constructor throwing an exception.

Components: Framework, OpenGL, Vulkan
VK-GL-CTS issue: 3419

Change-Id: I68ec7d1447d1e96f5d7841e0684687cdd294fe39

2 years agoRequire geometry shaders for adjacency topologies
Sean Risser [Fri, 30 Apr 2021 17:02:57 +0000 (13:02 -0400)]
Require geometry shaders for adjacency topologies

Clipping tests would use adjacency topologies with drivers that didn't
support geometry shaders.

Components: Vulkan

Affects: dEQP-VK.clipping.clip_volume.depth_clip.*
VK-GL-CTS Issue: 2906

Change-Id: I7a41e62dcbcdcab46ce4f8b04bfe322c688fbcac

2 years agoRemove api.tooling_info.validate_instance_layers
Marcin Kańtoch [Fri, 14 Jan 2022 23:49:16 +0000 (00:49 +0100)]
Remove api.tooling_info.validate_instance_layers

Remove:
dEQP-VK.api.tooling_info.validate_instance_layers

Components: Vulkan
VK-GL-CTS issue: 3395

This reverts commit 7628909f404f665eb54c6a5019386747fb631134.

Change-Id: I68de938e73c10fed80d4e9bb3698b513a1b44315
(cherry picked from commit 9f4d02658c354eef36e42edd69a50a3bb34639ec)

2 years agoAdd missing feature check
Ilkka Saarelainen [Thu, 23 Dec 2021 06:39:55 +0000 (08:39 +0200)]
Add missing feature check

Some of the buffer memory requirement tests were using
vkGetBufferMemoryRequirements2 function and not checking
if the required feature/extension is enabled.

This CL adds the feature check.

Components: Vulkan

Affects:

dEQP-VK.api.buffer_memory_requirements.*.method2.*

VK-GL-CTS Issue: 3301

Change-Id: Ic99ab4d39a03cd3ec035a17a1c27aceeafa1e69a

2 years agoFix vkAttachmentRateTests
Mohankumar Nekkarakalaya [Mon, 10 Jan 2022 22:36:17 +0000 (14:36 -0800)]
Fix vkAttachmentRateTests

The VkRenderingFragmentShadingRateAttachmentInfoKHR struct has its
shadingRateAttachmentTexelSize member set to the dimension of FSR
attachment, instead of attachmentTexelSize provided by the test.

A graphics pipeline used to draw FSR attachment, which is then used to
draw another color attachment. But the VkPipelineRenderingCreateInfoKHR
used by this pipeline sets the color format to that of the color
attachment, instead of FSR attachment

Affects:
dEQP-VK.fragment_shading_rate.dynamic_rendering.attachment_rate.*

Components: Vulkan

VK-GL-CTS issue: 3439

Change-Id: I36dad0f7dfa267c702fb611cd3b1b285fe0bb339

2 years agoMerge "Merge vk-gl-cts/dev/VK_KHR_global_priority into vk-gl-cts/vulkan-cts-1.3.1...
Matthew Netsch [Sun, 16 Jan 2022 00:11:00 +0000 (00:11 +0000)]
Merge "Merge vk-gl-cts/dev/VK_KHR_global_priority into vk-gl-cts/vulkan-cts-1.3.1" into vulkan-cts-1.3.1

2 years agoMerge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Matthew Netsch [Sat, 15 Jan 2022 05:53:52 +0000 (05:53 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1

Change-Id: I348041254e129d38fd3c434945263f93f1582093

2 years agoRemove repeated struct in writeDeviceFeatures2
John Anthony [Thu, 6 Jan 2022 23:30:56 +0000 (00:30 +0100)]
Remove repeated struct in writeDeviceFeatures2

Remove VkPhysicalDeviceShaderIntegerDotProductFeaturesKHR from list of
feature structs in writeDeviceFeatures2, as it is an alias for
VkPhysicalDeviceShaderIntegerDotProductFeatures which is also in the
list.

Affects:
dEQP-VK.api.info.get_physical_device_properties2.features

Components: Vulkan
VK-GL-CTS issue: 3437

Change-Id: Ibb0b6b655887c1452f55c730245941afb7dc108b

2 years agoUpdate vulkan-docs version
Piotr Byszewski [Tue, 11 Jan 2022 20:04:56 +0000 (21:04 +0100)]
Update vulkan-docs version

Recent changes to vulkan video include generating video extension
'Std' header files from video.xml and addition of *_INVALID enum
values that have same value as *_MAX_ENUM values.
This change updates vulkan-docs to version 1.2.203 and updates
gen_framework.py script to properly handle changes in vulkan video.

Affects: *

Components: Framework, Vulkan

VK-GL-CTS issue: 3431

Change-Id: Ibdb4bc8ace9572da920fa02649fcab7bc563841d

2 years agoMerge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Matthew Netsch [Sat, 15 Jan 2022 01:39:49 +0000 (20:39 -0500)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0

Change-Id: Ie7b28e84ceb9de28964db02e7744a01ea52b7c50

2 years agoRemove redundant load/store op none tests
Ari Suonpaa [Tue, 4 Jan 2022 13:04:12 +0000 (15:04 +0200)]
Remove redundant load/store op none tests

Load/store op none tests had originally a hard coded
depth stencil format, but was later changed to iterate
on multiple formats. The depth tests were accidentally
left there (as a duplicate) outside a format loop, and
the depth format parameter was uninitialized in these
tests.

This change removes these old tests and also fixes
the dynamic rendering tests to use correct depth
stencil formats.

VK-GL-CTS Issue: 3426

Affects:

dEQP-VK.*.suballocation.load_store_op_none.*

Components: Vulkan
Change-Id: I5c1e0a6d95bb1dbc88364f6e99f84e47619c285d

2 years agoFix vktFragmentShadingRateBasic tests
Mohankumar Nekkarakalaya [Tue, 11 Jan 2022 00:27:09 +0000 (16:27 -0800)]
Fix vktFragmentShadingRateBasic tests

Many graphics pipelines are used in dynamic render pass which uses
fragment shading attachment, but these pipelines don't have
VK_PIPELINE_CREATE_RENDERING_FRAGMENT_SHADING_RATE_ATTACHMENT_BIT_KHR
flags when they are created. Adding those flags.

Affects: dEQP-VK.fragment_shading_rate.dynamic_rendering.*

Components: Vulkan

VK-GL-CTS issue: 3440

Change-Id: I3dd0aae9d6e9f2fc0bb5266f4f4ba442ebc0317b

2 years agoMerge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Matthew Netsch [Fri, 14 Jan 2022 22:52:07 +0000 (17:52 -0500)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8

Change-Id: Ic1cf8fed8e0713c216ff31212334cb53acbbf72d

2 years agoFix getting capture address in RT capture replay tests
Slawomir Cygan [Fri, 10 Dec 2021 10:34:37 +0000 (11:34 +0100)]
Fix getting capture address in RT capture replay tests

Use vkGetBufferOpaqueCaptureAddress to retreive address
used in opaqueCaptureAddress

Components: Vulkan

VK-GL-CTS Issue: 3420

Affects: dEQP-VK.ray_tracing_pipeline.capture_replay.shader_binding_tables
Change-Id: Ifaa2fe92d6517fa75a29ad21c06365efd7857de4

2 years agoRemove time measurement on deferred host build tests
Sławomir Cygan [Mon, 10 Jan 2022 15:16:38 +0000 (16:16 +0100)]
Remove time measurement on deferred host build tests

The time measurement is wrongly implemented in this test
- it measures also thread creation, allocations and VK setup time, additionally
to AS build.  It is not easily fixable.

Moreover, the spec says that offloading the work to background threads
is 'desirable', however it never says it is faster.

VK-GL-CTS Issue: 3435

Components: vulkan

Affects:
dEQP-VK.ray_tracing_pipeline.acceleration_structures.*
dEQP-VK.ray_query.acceleration_structures.*

Change-Id: I41d836e2e454b9fb9bb46109edddd4eda19370e9

2 years agoMerge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7
Matthew Netsch [Fri, 14 Jan 2022 17:36:58 +0000 (17:36 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7

Change-Id: I1d7510b4e0626392ff35aa1f38c1bd193b8ce319

2 years agoMerge vk-gl-cts/dev/VK_KHR_global_priority into vk-gl-cts/vulkan-cts-1.3.1
Matthew Netsch [Fri, 14 Jan 2022 16:04:35 +0000 (11:04 -0500)]
Merge vk-gl-cts/dev/VK_KHR_global_priority into vk-gl-cts/vulkan-cts-1.3.1

Change-Id: I62eb79b47a281c3d240f5567c1b85c7c42dadea8

2 years agoMerge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/dev/VK_KHR_global_priority
Matthew Netsch [Fri, 14 Jan 2022 16:01:23 +0000 (11:01 -0500)]
Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/dev/VK_KHR_global_priority

Change-Id: Icba0010f8d5d655a23414d28f46a6536d0af52ea

2 years agoRemove api.tooling_info.validate_instance_layers
Arkadiusz Sarwa [Tue, 7 Dec 2021 17:22:32 +0000 (18:22 +0100)]
Remove api.tooling_info.validate_instance_layers

Remove:
dEQP-VK.api.tooling_info.validate_instance_layers

Components: Vulkan
VK-GL-CTS issue: 3395

This reverts commit 7628909f404f665eb54c6a5019386747fb631134.

Change-Id: I68de938e73c10fed80d4e9bb3698b513a1b44315

2 years agoMerge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6
Matthew Netsch [Fri, 14 Jan 2022 06:54:19 +0000 (06:54 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6

Change-Id: Ic336acbf09ed630cc1b20ea82796f20369b1a5dc

2 years agoMerge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5
Matthew Netsch [Fri, 14 Jan 2022 05:19:30 +0000 (05:19 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5

Change-Id: I7ec0667baf95d997230a8befced3ca4f2cda4876

2 years agoFix sType Tooling Info tests
Mohankumar Nekkarakalaya [Wed, 12 Jan 2022 21:23:25 +0000 (13:23 -0800)]
Fix sType Tooling Info tests

Tooling Info tests were not setting the sType correctly. This goes
against spec
where "sType must be
VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_TOOL_PROPERTIES_EXT". These
tests also check this sType to validate functionality.

Components: Vulkan

Affects:
dEQP-VK.api.tooling_info.*

VK-GL-CTS issue: 3444

Change-Id: Ic72104261a577d7d767742d4b2828296eba3922c

2 years agoDeqpTestRunner: fix deqpLogFilename
Paul Thomson [Fri, 3 Dec 2021 16:48:36 +0000 (16:48 +0000)]
DeqpTestRunner: fix deqpLogFilename

Fix capitalization of shell argument "deqpLogFilename" in
DeqpTestRunner.java. The code still worked fine in most cases because
the default filename matches the filename passed in DeqpTestRunner.java.

Components: Android
Google bug: b/206657494

Change-Id: I857fa3994ada72aa96d199569704a46034255309
(cherry picked from commit 42017ff7072dcc7e7a7d51dd5611be05abf5460f)

2 years agoAdd format check to SharedPresentableImageTest
Mikolaj Chadzynski [Thu, 23 Dec 2021 08:38:54 +0000 (09:38 +0100)]
Add format check to SharedPresentableImageTest

The SharedPresentableImageTest does not follow Vulkan spec.
The SurfaceFormats got by getPhysicalDeviceSurfaceFormats ->
getPhysicalDeviceSurfaceFormatsKHR should be checked by
vkGetPhysicalDeviceImageFormatProperties. This is according to:
www.khronos.org/registry/vulkan/specs/1.2-extensions/html/chap33.html
"33.5. Surface Queries
In addition to the surface capabilities as obtained by surface queries
below, swapchain images are also subject to ordinary image creation
limits as reported by vkGetPhysicalDeviceImageFormatProperties. As an
application is instructed by the appropriate Valid Usage sections, both
the surface capabilities and the image creation limits have to be
satisfied whenever swapchain images are created."

Unsupported format can lead to non-deterministic behavior e.g.
a segmentation fault, a null pointer dereference in a test or a driver.

VK-GL-CTS issue: 3422

Affects:
dEQP-VK.wsi.android.shared_presentable_image.*

Components: Vulkan

Change-Id: Id4bb4d1c81e090ed1d7f34a76f3cfafc464d8cf8

2 years agoFix inl files
Matthew Netsch [Thu, 13 Jan 2022 21:38:03 +0000 (16:38 -0500)]
Fix inl files

Change-Id: I6468dff8d75e73dbd23a0a1b1b1314ea80ef954b
Components: Vulkan, Framework

2 years agoAdd VK_KHR_global_priority to extensions_data.txt
Charles Johnston [Thu, 13 Jan 2022 17:05:37 +0000 (12:05 -0500)]
Add VK_KHR_global_priority to extensions_data.txt

dEQP-VK.info.device_extensions fails without this.

Affected test:
dEQP-VK.info.device_extensions

Components: Vulkan
VK-GL-CTS issue: 3446

Change-Id: I4a0924754f085eccabe1dd08d0020621773cddb6

2 years agoMerge vk-gl-cts/dev/VK_KHR_roadmap_2022 into vk-gl-cts/vulkan-cts-1.3.1
Matthew Netsch [Mon, 10 Jan 2022 20:36:43 +0000 (15:36 -0500)]
Merge vk-gl-cts/dev/VK_KHR_roadmap_2022 into vk-gl-cts/vulkan-cts-1.3.1

Change-Id: I564944f8a1fe42a969063a40f7ecf689549bab59

2 years agoMerge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/dev/VK_KHR_roadmap_2022
Matthew Netsch [Mon, 10 Jan 2022 16:42:51 +0000 (11:42 -0500)]
Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/dev/VK_KHR_roadmap_2022

Change-Id: Iff63540ee97f97d9e860d655439f0f85ca5ee00d

2 years agoMerge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Matthew Netsch [Sun, 9 Jan 2022 20:33:32 +0000 (15:33 -0500)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1

Change-Id: Iab3bf6dc70b7f8b1f29556a1394b2821f718ca0c

2 years agoFix for issues in dynamic rendering tests
Marcin Kańtoch [Sun, 12 Dec 2021 22:39:11 +0000 (23:39 +0100)]
Fix for issues in dynamic rendering tests

Missing barrier before begin rendering to transition image from
VK_IMAGE_LAYOUT_UNDEFINED to VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL

Components: Vulkan

VK-GL-CTS issue: 3383

Affects:
dEQP-VK.dynamic_rendering.suballocation.sparserendertarget*

Change-Id: Ied286e31282d56e8221e327e3d02a5d9333cf499

2 years agoMerge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Matthew Netsch [Sun, 9 Jan 2022 15:39:46 +0000 (10:39 -0500)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0

Change-Id: Iba40a0634a1de5fde930a2f469b5c9bc31d8c4d9

2 years agoFix stencil layout transitions in samplemask tests
Jari Komppa [Wed, 1 Dec 2021 15:00:14 +0000 (17:00 +0200)]
Fix stencil layout transitions in samplemask tests

This change fixes the validation layer errors for the _samplemask cases.

affects:
dEQP-VK.renderpass2.depth_stencil_resolve.*_samplemask

Components: Vulkan
VK-GL-CTS issue: 3362

Change-Id: I0e1d9a44c3ed127fbde3765725243fae722ad938

2 years agoFix RGBA10x6 feature check
Vidar Lilleboe [Tue, 30 Nov 2021 13:31:36 +0000 (14:31 +0100)]
Fix RGBA10x6 feature check

Verify that the extension is available before quering for support.

Affects:
dEQP-VK.api.info.format_properties.r10x6g10x6b10x6a10x6_unorm_4pack16

Components: Vulkan
VK-GL-CTS issue: 3370

Change-Id: Ib8cbbbe1f8c36b5022de1c04e623d49f5fb2b4c4

2 years agoRename some waived tests for dynamic rendering
Graeme Leese [Tue, 4 Jan 2022 14:20:13 +0000 (14:20 +0000)]
Rename some waived tests for dynamic rendering

These tests were renamed in commit 90835b7 "Rename dynamic_rendering
tests", but the waivers file was not updated. (The Android waiver file
was updated, so is not changed here).

Component: Vulkan
VK-GL-CTS issue: 757

Change-Id: I0beae9cd0e6b4e33e8c8f717b0eae44797104844

2 years agoFix barrier for initializing resolve attachment image to use proper level
Sławomir Cygan [Thu, 9 Dec 2021 15:50:53 +0000 (16:50 +0100)]
Fix barrier for initializing resolve attachment image to use proper level

This changes the level in the barrier to match level used by image view
used as resolve attachment in renderpass.

VK-GL-CTS Issue: 3407

Components: Vulkan

Change-Id: I500dfdbf15c4b7cd9943d3b063122107e1890688
Affects: dEQP-VK.dynamic_rendering.*.multisample_resolve.*_resolve_level_*

2 years agoMerge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Matthew Netsch [Fri, 7 Jan 2022 19:26:26 +0000 (14:26 -0500)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8

Change-Id: Ib63fd21efc3a2a3e4896a212d51e3ab1f12e56d4

2 years agoChecked .inl files back into the repo
Piotr Byszewski [Mon, 13 Dec 2021 14:08:09 +0000 (15:08 +0100)]
Checked .inl files back into the repo

By default .inl files won't be generated at build time but
this functionality is still present and to activate it
value of DEQP_VULKAN_INL_GEN_OUTPUTS_DIR should be changed
to point to PROJECT_BINARY_DIR.

VK-GL-CTS issue: 3197

Components: Framework, Vulkan

Affects:
dEQP-VK.*

Change-Id: I6ba5932aa51740048c8dcc0c0222e8f7553ac4b3

2 years agoPass force to fetch_sources
Piotr Byszewski [Fri, 10 Dec 2021 12:32:27 +0000 (13:32 +0100)]
Pass force to fetch_sources

Switching vulkan-docs folders between gitlab and github branches
results in errors on the server (clobbering the tags). Using
fetch sources with --force param resolves the issue.

Components: Vulkan

VK-GL-CTS issue: 3197

Change-Id: I913d5803836e9f7a59494e5ebf6e6261ede52948

2 years agoFix strided device address regions in RT misc tests
Ricardo Garcia [Thu, 11 Nov 2021 17:18:38 +0000 (18:18 +0100)]
Fix strided device address regions in RT misc tests

Some strided device address regions in ray tracing misc tests were being
created with the wrong size, not taking into account some tests were
storing several shader group handles in the binding tables.

In addition, this commit also fixes several validation errors in these
tests, related to bad sizes when flusing allocations and unaligned
strides in strided device address regions, which needed to be rounded
up.

Affected tests:
dEQP-VK.ray_tracing_pipeline.misc.*

Components: Vulkan
VK-GL-CTS issue: 3280

Change-Id: I7d20c347ff44b455547115d1a6b94c5d69a46c2c

2 years agoFix ray tracing closedFan2 tests
Ricardo Garcia [Tue, 9 Nov 2021 16:26:37 +0000 (17:26 +0100)]
Fix ray tracing closedFan2 tests

The watertightness tests for ray tracing include a closedFan2 variant
that had several issues.

These tests create a circle made of a variable number of triangles, all
of them sharing a central vertex and all of them sharing two edges with
neighboring triangles.

With that composition, closedFan2 variants created one geometry, BLAS
and instance per triangle, and tried to verify certain rules regarding
closed fans and watertightness. This had several problems:

- By having each triangle belong to a different instance, the set up
  does not meet the requirements for watertight geometry as laid out in
  the spec.

- Ray tracing shaders were increasing atomic counters, indexing them per
  ray and primitive id, in the any-hit shader. If a counter was
  increased more than once, this was considered a failure. However, in
  the closedFan2 variants all triangles have primitive id zero due to
  all of them belonging to different geometries. If a ray was found to
  hit two geometries/BLAS, it would result in a failure because the same
  counter would be increased twice, but that result is legal according
  to the spec.

This commit fixes closedFan2 tests by addressing both issues:

- The tests now create one geometry per triangle, but groups all
  geometries in a single BLAS and instance, meeting the spec
  requirements regarding closed fans.

- When increasing atomic counters, they are indexed per ray and per
  geometry index, so it is illegal to hit the same geometry twice with
  the same ray, following the rules of
  VK_GEOMETRY_NO_DUPLICATE_ANY_HIT_INVOCATION_BIT_KHR, but they allow
  the same ray to hit two triangles (geometries) as the spec allows.

In addition, it also removes some dead code and fixes angle calculation
so they fall in the [-pi, pi] range.

Affected tests:
dEQP-VK.ray_tracing_pipeline.watertightness.*

Components: Vulkan
VK-GL-CTS issue: 3150

Change-Id: I430be3a1830592d37b75031b8506a194c862a0d7

2 years agoReduce framebuffer size of dEQP-VK.graphicsfuzz.spv-stable-pillars-volatile-nontempor...
Jörg Wagner [Mon, 6 Dec 2021 08:57:51 +0000 (09:57 +0100)]
Reduce framebuffer size of dEQP-VK.graphicsfuzz.spv-stable-pillars-volatile-nontemporal-store

Reduce the size to 32x16 to avoid avoid timeouts on low-end platforms.
This shouldn't affect the ability to find compiler bugs because the
shader itself is the same.

Affects: dEQP-VK.graphicsfuzz.spv-stable-pillars-volatile-nontemporal-store

Components: Vulkan

VK-GL-CTS Issue: 3411

Change-Id: If4fac83d04723ab16e987a2f7d1495bf1a8f055f

2 years agoFix validation errors in renderpass tests
Ilkka Saarelainen [Fri, 17 Dec 2021 05:36:16 +0000 (07:36 +0200)]
Fix validation errors in renderpass tests

This CL fixes the validation errors in some of the renderpass
tests. The tests incorrectly defined subpass dependency access
scopes for depth/stencil attachments in some cases.

Affects:

dEQP-VK.renderpass*.attachment_allocation.*

Components: Vulkan

VK-GL-CTS Issue: 3385

Change-Id: Ia9cc78bd28dde5b9cdbf4e28ba759e3bde44a9d0

2 years agoPick correct memoryTypeIndex for AHB
Shih-Hsin Li [Wed, 24 Nov 2021 00:32:38 +0000 (16:32 -0800)]
Pick correct memoryTypeIndex for AHB

Pick the right memoryTypeIndex for protected allocations so that
protected memory is allocated when createFlag has protected bit
set. This fixed some bindImageMemory failure caused by binding
non-protected memory in testAndroidHardwareBufferImageFormat.

Affects:
dEQP-VK.api.external.memory.android_hardware_buffer.image_formats.*

Components: Vulkan
Change-Id: Ib50a97d248930b6cc6538d1c7b84e84cddfde40e

2 years agoAllow rounding error when reading back Z buffer
Iago Toral Quiroga [Mon, 22 Nov 2021 07:29:50 +0000 (08:29 +0100)]
Allow rounding error when reading back Z buffer

The early fragment test produces Z values <= 0.5 and uses a shader
to write 0.75 that it expects to be ignored due to early fragment
tests, which it verifies by reading back the Z buffer and testing
that all values are <= 0.5.

On our platform, we observe that on storing 0.5 we retrieve
0.500008, which makes us fail the test incorrectly. Fix this
by adding a small room for rounding error, like we do for
other verification paths in these tests.

While we are doing this, lower the tolerance admited for
the late fragment test case as well.

Components: Vulkan
VK-GL-CTS Issue: 3340
Affects:
dEQP-VK.fragment_operations.early_fragment.discard_early_fragment_tests_depth
dEQP-VK.fragment_operations.early_fragment.discard_no_early_fragment_tests_depth

Change-Id: I8e1782b81d0e74a4a5af3e3cac40c9679f543ac6

2 years agoFix amber vs cts device feature requirements
Jari Komppa [Mon, 15 Nov 2021 08:25:36 +0000 (10:25 +0200)]
Fix amber vs cts device feature requirements

This change unifies the device requirements between cts and amber for
the affected tests.

Affects:
dEQP-VK.glsl.builtin.precision_fp16_storage16b.*

Components: Vulkan
VK-GL-CTS issue: 3304

Change-Id: I93f840751b40d145f89f847612e36733a18ac971

2 years agoFix extended_dynamic_state tests
Piotr Byszewski [Mon, 22 Nov 2021 14:38:35 +0000 (15:38 +0100)]
Fix extended_dynamic_state tests

On vulkan-cts-1.2.8 branch extended_dynamic_state tests were
extended compared to the same group but in vulkan-cts-1.2.6 branch
(new tests were added). After updates to vulkan-cts-1.2.6 were
merged back to vulkan-cts-1.2.8 some of those new tests started
to fail as they did not have required changes.
This change makes sure that triangle strips are used in
the new tests to.

Components: Vulkan

VK-GL-CTS issue: 3327

Affects:
dEQP-VK.pipeline.extended_dynamic_state.*

Change-Id: I4fc19e40f6938d39be4428e8d9d98db4a74c0a5d

2 years agoMerge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts-1.2.7
Matthew Netsch [Fri, 7 Jan 2022 17:55:19 +0000 (12:55 -0500)]
Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts-1.2.7

Change-Id: I05420f73334f6aee2729ea2e8f76a079de896617

2 years agoUpdate kc-cts version
Piotr Byszewski [Wed, 8 Dec 2021 16:07:35 +0000 (17:07 +0100)]
Update kc-cts version

Version of kc-cts was updated to include fix for inl dependency.

Components: OpenGL

VK-GL-CTS issue: 3400

Change-Id: Ic28275604849506de4139c0bbda20278a2431ca1

2 years agoCreate command pool with command buffer reset in RT tests
Mohankumar Nekkarakalaya [Tue, 9 Nov 2021 17:56:08 +0000 (09:56 -0800)]
Create command pool with command buffer reset in RT tests

-When command pool was created either command buffer reset
 bit should have been set or command buffer should have
 reset pool before using for VU.
-Fix is to create command pool with reset bit set.

Components: Vulkan

VK-GL-CTS Issue: 3288

Affected tests: dEQP-VK.ray_tracing_pipeline.acceleration_structures.device_compability_khr.*

Change-Id: Ie21926cd53c505e46da0d03a6082e689d45d5d2a

2 years agoSuppress GCC 11 conversion warning
Mika Väinölä [Tue, 30 Nov 2021 11:13:52 +0000 (13:13 +0200)]
Suppress GCC 11 conversion warning

On GCC 11 with UBSan enabled deHalfIsIEEENaN produces warnings due to
right shift promoting the result of an expression to an int, which is
then assigned to a deUint16.

Components: Framework

VK-GL-CTS issue: 3371

Change-Id: I48526b61ead69ee14b3253fa29737499253e62bc

2 years agoFix allocation of system memory.
Arkadiusz Sarwa [Wed, 17 Nov 2021 15:43:24 +0000 (16:43 +0100)]
Fix allocation of system memory.

Allocation of system memory which have been used as reference data can fail.

VK-GL-CTS issue: 3319
Components: Vulkan

Affects:
dEQP-VK.reconvergence.*

Change-Id: Icf9e6a2ad15912109aee2b6ea693a17650579087

2 years agoGenerate inl files at build time
Piotr Byszewski [Wed, 13 Oct 2021 12:17:14 +0000 (14:17 +0200)]
Generate inl files at build time

Inl files are no longer checked into the repo instead they are
generation at build time.

VK-GL-CTS issue: 3197

Components: Framework, Vulkan

Affects:
dEQP-VK.*

Change-Id: I526ed3d8dc8cc54860e44937a5048e499248a3c6

2 years agoAdd Vulkan-Docs to fetch sources
Piotr Byszewski [Tue, 19 Oct 2021 09:19:58 +0000 (11:19 +0200)]
Add Vulkan-Docs to fetch sources

Header files that are used to generate inl files are no longer
checked into the repo. Headers are now generated in Vulkan-Docs
which are now fetched from the gitlab. Generation is done
by gen_framework.py.

VK-GL-CTS issue: 3197

Components: Framework, Vulkan

Affects:
dEQP-VK.*

Change-Id: I4291848910b03180d4dc5514f8d8e5943c36e9b2

2 years agoMirror ANGLE Khronos waiver for Android
Paul Thomson [Mon, 20 Dec 2021 12:39:21 +0000 (12:39 +0000)]
Mirror ANGLE Khronos waiver for Android

Components: Android
VK-GL-CTS issue: 3255

Excluded:

dEQP-GLES3.functional.transform_feedback.array_element.*
dEQP-GLES3.functional.transform_feedback.random.*
dEQP-GLES31.functional.program_interface_query.transform_feedback_varying.*_array_element
dEQP-GLES31.functional.program_interface_query.transform_feedback_varying.type.*.array.*

Change-Id: I670c1e71d60dced06229520bca6244e87fa4ea1a

2 years agoFix requirements tests for multiplane images
James Fitzpatrick [Wed, 8 Dec 2021 12:17:29 +0000 (12:17 +0000)]
Fix requirements tests for multiplane images

The memory requirements tests for multiplane images would previously
assume that bits were not sparsely set in memoryTypeBits.

This could lead to the tests assuming that an implementation was
returning a lazily allocated memory type for an image without
transient attachment set.

Affects: dEQP-VK.memory.requirements.*multiplane_image*

Components: Vulkan

VK-GL-CTS issue: 3405

Change-Id: Ic1e56d7412ac413da907059c79b3f7064b3c664b

2 years agoReduce framebuffer size of spv-stable-pillars-O-op-select-to-op-phi
Jörg Wagner [Mon, 6 Dec 2021 08:57:51 +0000 (09:57 +0100)]
Reduce framebuffer size of spv-stable-pillars-O-op-select-to-op-phi

Reduce the size to 32x16 to avoid avoid timeouts on low-end platforms.
This shouldn't affect the ability to find compiler bugs because the
shader itself is the same.

Affects: dEQP-VK.graphicsfuzz.spv-stable-pillars-O-op-select-to-op-phi

Components: Vulkan

VK-GL-CTS Issue: 3367

Change-Id: I2eacbc75df29b8dc44c8744bc13e140d6ef7c0cb

2 years agoMerge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6
Matthew Netsch [Fri, 7 Jan 2022 16:02:38 +0000 (11:02 -0500)]
Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6

Change-Id: I8e4fb16c3f82b6cc42af849e201d50ad2f053d6e

2 years agoAdditional warning fix for Clang 13
Ricardo Garcia [Thu, 9 Dec 2021 14:23:57 +0000 (15:23 +0100)]
Additional warning fix for Clang 13

Fixes warning about unused variable. No test results should be affected
by this change.

Components: Vulkan
VK-GL-CTS issue: 3147

Change-Id: Ib7c0425891e33e65e22ed90668aa3d0d7eae85df

2 years agoFix mismatched ray payload in descriptor set random tests
Ricardo Garcia [Tue, 14 Dec 2021 10:08:16 +0000 (11:08 +0100)]
Fix mismatched ray payload in descriptor set random tests

Miss shaders had a ray payload declaration that didn't match other
shading stages.

Affected tests:
dEQP-VK.binding_model.descriptorset_random.*.miss.*

Components: Vulkan
VK-GL-CTS issue: 3412

Change-Id: I4473a883248bc9d572e6112da82bc4c774689071

2 years agoAdd Samsung Driver ID
s.fricke [Fri, 12 Nov 2021 21:54:10 +0000 (13:54 -0800)]
Add Samsung Driver ID

The enum value was added in the 1.2.199 Vulkan Headers

VK-GL-CTS issue: 3384
Components: Vulkan

Affects:
dEQP-VK.api.driver_properties.driver_id_match

Change-Id: Id04c20b5fe8ad90350a588fd0e7de0c498ebe5b6

2 years agoUpdate Android test lists for Broadcom waiver
Paul Thomson [Fri, 3 Dec 2021 17:53:24 +0000 (17:53 +0000)]
Update Android test lists for Broadcom waiver

VK-GL-CTS issue: 2804

Components: Vulkan, Android
Google bug: b/206833783

Change-Id: I51fcc3ce1617dc5a980e893bfc5915e8fc789c74

2 years agoRemove few EGL robustness tests
Brandon Schade [Tue, 28 Sep 2021 19:28:20 +0000 (12:28 -0700)]
Remove few EGL robustness tests

Components: EGL

Affects:
dEQP-EGL.functional.robustness.reset_context.shaders.infinite_loop.*

VK-GL-CTS issue: 257

Change-Id: I9edb2e577fb14b98d83bb16dc31188d3a901606d
(cherry picked from commit 39c99a7ece4b6618cde30c6c621bd3036801bd4b)

2 years agoFix use a device with protected memory enabled
Mohd Faisal [Mon, 22 Nov 2021 14:58:37 +0000 (14:58 +0000)]
Fix use a device with protected memory enabled

Test is trying to allocate memory from protected memory heap using
default device which doesn't have protected memory enabled. Change
checks if the protected memory supported, if it is create a custom
device with protected memory enabled.

Affects:

dEQP-VK.memory.mapping.*.full.variable.implicit_unmap

Components: Vulkan

VK-GL-CTS issue: 3292

Change-Id: I74897e3dd7f1cada0044036ba27ad8764754ed23

2 years agoThrottling CTS producing frame speed
YiHsing Shen [Tue, 9 Nov 2021 02:03:40 +0000 (02:03 +0000)]
Throttling CTS producing frame speed

CTS checks the present time of the frame 6 frames ago. However, if
the default buffer count of BufferQueue is more than 7, CTS could
produce frames continuously in a short time. In this case, the frame
6 frames ago might be not presented yet then CTS fails. To prevent
this situation, CTS produces frames at the speed according to
compositeInterval.

Component: EGL

Affected tests:
dEQP-EGL.functional.get_frame_timestamps.*

Change-Id: I1ac15974a6c4147ee2546ad21dea1fb3e6bf38f9

2 years agoMerge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5
Matthew Netsch [Fri, 7 Jan 2022 06:07:01 +0000 (01:07 -0500)]
Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5

Change-Id: I85eab03afdf24359556917617b56856b51b7eb07

2 years agoMerge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/vulkan-cts-1.2.4
Matthew Netsch [Thu, 6 Jan 2022 22:45:47 +0000 (17:45 -0500)]
Merge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/vulkan-cts-1.2.4

Change-Id: Id711f3ba5558c490c3629051677c7f41ec2da2d6

2 years agoFix warnings reported by clang 13
Ricardo Garcia [Fri, 10 Dec 2021 13:54:01 +0000 (14:54 +0100)]
Fix warnings reported by clang 13

This commit fixes code that was producing warnings when built using
clang 13. They are mostly about unused variables and null pointer
substractions, but the new code should be semantically the same.

No test results should be affected by these changes.

Components: Framework, Vulkan, OpenGL
VK-GL-CTS issue: 3147

Change-Id: I0eb87c17270a610c8b29ec27ae8e10009053f8e1

2 years agoRename various things for more inclusive language
Jari Komppa [Fri, 19 Nov 2021 13:16:54 +0000 (15:16 +0200)]
Rename various things for more inclusive language

This change renames various things to avoid gender-specific or degatory
terms.

Khronos inclusive language policy:
https://www.khronos.org/about/inclusive-language

Majority of the changes are due to the term 'dummy', as in mannequin or
placeholder, which in programming may mean any of empty, placeholder,
unused, minimal, busywork, ignored or irrelevant.

Changes not included are file names (gluDummyRenderContext), test names
(dummy_instruction_set) or branch names (master).

Affects:
*

Components: Framework, Vulkan, OpenGL
VK-GL-CTS issue: 2509

Change-Id: I3837477a1b3de1142e8d97c503890ccbce9138f8

2 years agoRemove vkDestroyBuffer
Ari Suonpaa [Tue, 14 Dec 2021 05:27:53 +0000 (07:27 +0200)]
Remove vkDestroyBuffer

A buffer allocation test that is supposed to fail a large
allocation still tried to destroy the buffer even when an
error was returned from the allocation. This is now removed.

VK-GL-CTS Issue: 3192

Affects:

dEQP-VK.api.buffer.basic.size_max_uint64

Components: Vulkan
Change-Id: Ic36cb548ab2796b41e2a0b44d023e644b02a6d8c

2 years agoAvoid querying non-supported hardware features
Jari Komppa [Tue, 23 Nov 2021 10:53:00 +0000 (12:53 +0200)]
Avoid querying non-supported hardware features

Change the feature query test to avoid querying information on hardware
features that are not supported. This is done by querying non-existing
feature (max_enum) instead, which must be ignored by implementations.

The change also adds comment to all generated files stating what script
generates the files.

Affects:
dEQP-VK.api.info.get_physical_device_properties2.features

Components: Vulkan
VK-GL-CTS issue: 2853

Change-Id: I24a3832abc0721e649edbb112bd7f776c2b5d7f4

2 years agoDisable two warnings for old Amber versions
Mika Väinölä [Mon, 13 Dec 2021 11:00:05 +0000 (13:00 +0200)]
Disable two warnings for old Amber versions

Older versions of Amber fail to build with Clang >= 11 and GCC >=11 due
-Werror and warnings that have been fixed in later versions. Upgrading
Amber in older CTS branches risks accidental downgrades during fix
propagation. This change disables -Wsuggest-destructor-override for
Clang and -Wuninitialized for GCC when building libamber. These
should be re-enabled in newer Vulkan CTS releases.

Components: Framework, Vulkan

VK-GL-CTS issue: 3361

Change-Id: Ifc2ed69584d8ad179042b80212e02ceb9956d110

2 years agoZero initialize array in internal tests
Mika Väinölä [Wed, 1 Dec 2021 10:24:52 +0000 (12:24 +0200)]
Zero initialize array in internal tests

This suppresses a -Wmaybe-uninitialized warning in GCC 11 release
builds.

Affects: dE-IT.delibs.decpp.block_buffer

Components: Framework

VK-GL-CTS issue: 3378

Change-Id: I2315b5cdeecb6e9a54dd419c88134f30a3335029

2 years agoAdd 1.3.1.0 conformance version
Matthew Netsch [Sat, 11 Dec 2021 16:35:55 +0000 (11:35 -0500)]
Add 1.3.1.0 conformance version

Change-Id: I584405ca88368f1a873b3d889d9ce3317c7dbc05
Components: Vulkan
Affects: dEQP-VK.api.driver_properties.conformance_version

2 years agoMerge vk-gl-cts/master into vk-gl-cts/vulkan-cts-1.3.1
Matthew Netsch [Sat, 11 Dec 2021 16:34:18 +0000 (11:34 -0500)]
Merge vk-gl-cts/master into vk-gl-cts/vulkan-cts-1.3.1

Change-Id: I851afbc7c49096c4a2e088335bf504eddea773ad

2 years agoAdd a batch of GraphicsFuzz coverage tests
Antto Mäkinen [Fri, 26 Nov 2021 15:12:06 +0000 (17:12 +0200)]
Add a batch of GraphicsFuzz coverage tests

This commit adds a batch of GraphicsFuzz coverage tests.

Components: Vulkan

New Tests:

dEQP-VK.graphicsfuzz.cov-do-while-negative-iterator-nested-loops-increment-array-element
dEQP-VK.graphicsfuzz.cov-fragcoord-conditions-never-return-index-array-using-uniform
dEQP-VK.graphicsfuzz.cov-function-loop-condition-uniform-shift-right
dEQP-VK.graphicsfuzz.cov-function-nested-loops-break-early-never-discard
dEQP-VK.graphicsfuzz.cov-function-two-loops-limit-using-arguments-array-element-copies
dEQP-VK.graphicsfuzz.cov-global-loop-counter-set-array-element-once-index-using-findmsb
dEQP-VK.graphicsfuzz.cov-integer-minus-one-increased-before-indexing-array
dEQP-VK.graphicsfuzz.cov-loop-array-element-copy-index-clamp-sign
dEQP-VK.graphicsfuzz.cov-loop-start-from-one-switch-case-never-executed
dEQP-VK.graphicsfuzz.cov-loop-two-iterators-increment-array-empty-do-while
dEQP-VK.graphicsfuzz.cov-nested-functions-compare-fragcood-length-zero-vector
dEQP-VK.graphicsfuzz.cov-nested-loops-decrease-vector-component-by-matrix-element-global-loop-counter
dEQP-VK.graphicsfuzz.cov-nested-loops-global-counter-func-set-struct-field
dEQP-VK.graphicsfuzz.cov-repeating-conditions-fract-unused

Change-Id: I6e6377a60a134b59d3afd40015d282821b429a2a

2 years agoFix dot product with saturation tests
Ricardo Garcia [Tue, 30 Nov 2021 18:30:04 +0000 (19:30 +0100)]
Fix dot product with saturation tests

This commit fixes an issue that prevented some valid results from being
verified in a variety of cases, and fixes the in-software dot-product
calculation so it will not rely on undefined truncation of signed
integers.

Also, it adjusts the pseudorandom numeric range in some tests to more
easily test cases of saturating and non-saturating operations.

Finally, the unsigned dot product operations have been separated in
saturating and non-saturating cases to more easily check both
conditions.

Affected and new tests:
dEQP-VK.spirv_assembly.instruction.compute.opudot*
dEQP-VK.spirv_assembly.instruction.compute.opsdot*
dEQP-VK.spirv_assembly.instruction.compute.opsudot*

Components: Vulkan
VK-GL-CTS issue: 3366

Change-Id: If058fd13705290472eef369167506a35cf7bba91

2 years agoAdd dynamic rendering to attachment rate tests
Piotr Byszewski [Tue, 9 Nov 2021 13:43:40 +0000 (14:43 +0100)]
Add dynamic rendering to attachment rate tests

Affects:
dEQP-VK.fragment_shading_rate.*.attachment_rate.*

Components: Vulkan

VK-GL-CTS issue: 3283

Change-Id: Id2cf3d17c076c58b13f84b9ecf9b238f4989dcb3

2 years agoFurther VK_NV_mesh_shader test variants and fixes
Ricardo Garcia [Thu, 4 Nov 2021 15:58:22 +0000 (16:58 +0100)]
Further VK_NV_mesh_shader test variants and fixes

* Add local_size/vertices/primitives maximization cases.

* Add task, mesh and fragment interface variable tests.

* Increase glslang NV mesh shader built-in limits (they need to be as
  big as exposed by other interesting implementations like RADV and used
  in some tests).

* Replace tcu::nothing<T> with tcu::Nothing in misc tests.

New and affected tests:
dEQP-VK.mesh_shader.nv.*

Components: Vulkan
VK-GL-CTS issue: 2991

Change-Id: I5eead8177b6315a44bb95c820af4549028ba5572

2 years agoFix and enable dynamic rendering multivew coverage
Piers Daniell [Thu, 28 Oct 2021 21:48:19 +0000 (15:48 -0600)]
Fix and enable dynamic rendering multivew coverage

Coverage for dynamic rendering multi-draw multiview was
disabled in CL 8340 because it was broken, and also disabled
in vulkan-cts-1.3.0.

This CL reenables the coverage and fixes a couple of bugs
to make it work.

New tests:

dEQP-VK.draw.dynamic_rendering.multi_draw.*.multiview.*

Affects:

dEQP-VK.draw.dynamic_rendering.multi_draw.*

Components: Vulkan

VK-GL-CTS issue: 3258

Change-Id: Iacdc11ca0d8bbc5d0b706236ae31ad8afe30bb46

2 years agoMerge "Merge dev/VK_EXT_depth_clip_control into master"
Matthew Netsch [Sat, 11 Dec 2021 08:28:22 +0000 (08:28 +0000)]
Merge "Merge dev/VK_EXT_depth_clip_control into master"

2 years agoFix integer overflow in Random::getInt()
Ari Suonpaa [Fri, 26 Nov 2021 09:00:58 +0000 (11:00 +0200)]
Fix integer overflow in Random::getInt()

Random integer generation was having a signed integer overflow
when calculating a range between min and max values.

When casting an overflowed value to unsigned int the result
by most (if not all) implementations would produce expected
results due to modulo wraparound. However, this is not guaranteed
to happen as signed integer overflow is regarded as undefined
behavior.

This change casts the min and max values to unsigned int which
has defined under- and overflow behavior.

VK-GL-CTS Issue: 3353
VK-GL-CTS Issue: 3355
VK-GL-CTS Issue: 3356

Affects: *

Components: Framework, Vulkan, OpenGL
Change-Id: I8dff7bf9517433e1699acfe1f6973ea8fb25e4f7

2 years agoTRANSIENT_ATTACHMENT_BIT store/load op test
Juha Heiskanen [Mon, 22 Nov 2021 13:15:31 +0000 (15:15 +0200)]
TRANSIENT_ATTACHMENT_BIT store/load op test

Series of tests covering the load and store operations when
VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT is enabled. Color, depth and
stencil values are tested separately.

Components: Vulkan

VK-GL-CTS Issue: 3204

New Tests: dEQP-VK.fragment_operations.transient*

Change-Id: I499ff68d243b2fc76660545d12e9b0c64a9d9906

2 years agoMerge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/master
Matthew Netsch [Sat, 11 Dec 2021 07:10:20 +0000 (07:10 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/master

Change-Id: Idd1ae81cc934e52485f2a79745c9ffa46951390a