Michal Michalski [Mon, 2 Dec 2019 16:34:10 +0000 (17:34 +0100)]
[messaging] MessageFolderType as string.
+ Remove getType() and getId() methods from MessageFolder.
+ Replace MessageFolderType enum with strings everywhere.
+ Remove unused messageFolderTypeToString() function.
+ Add MessageFolderTypeStr string array of folder type values.
+ Align code using old folder type implementation.
+ Inline MessageFolder::toJSON() calls and remove this method.
[Verification] tct-messaging-*-tizen-tests 100% pass.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I96b8a76508c9e6b1a807e773ab08dca3da851585
Michal Michalski [Mon, 2 Dec 2019 11:35:18 +0000 (12:35 +0100)]
[messaging] Replacing MessageFolder with picojson part 2.
+ FilterUtils::isMatching() overload for picojson::value.
+ Removed some getters/setters from MeessageFolder.
+ Removed unused FoldersChangeCallback::getFilter() method.
+ Simplified implementation of MessageFolder::isMatchingAttribute().
+ Removed stringToMessageFolderType() unused function.
[Verification] tct-messaging-*-tizen-tests 100% pass.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I578dcbd7b9d4fb5650f0eca1ecb264a78aff8962
Michal Michalski [Fri, 29 Nov 2019 14:01:02 +0000 (15:01 +0100)]
[messaging] Move folder-related code to message_folder.
+ Moved FindFolderTaskParams to message_folder.h
+ Moved filterFolders() from folders_changed_callback to message_folder.
+ Moved MESSAGE_FOLDER_ATTRTIBUTE_* constants to message_folder.cc
+ Remove FolderPtr typedef.
+ Remove unneccessary extern declarations.
[Verification] Code compiles.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I5289f7f0e9e84ec71bf92031e5c5c56b2cb65df6
Michal Michalski [Fri, 29 Nov 2019 08:34:43 +0000 (09:34 +0100)]
[messaging] Replace MessageFolder class with plain json part 1.
+ MessageFolder::filterFolders() method converted to function and removed from the header.
+ Replace MessageUtils::folderToJson() with MessageFolder::toJSON() method.
+ Replace all MessageFolder attributes with single picojson object.
+ Move folder-related methods and types from messaging_util to message_folder module.
+ Replace jsonToFolder() method with MessageFolder(picojson::value) constructor.
[Verification] tct-messaging-*-tizen-tests 100% pass.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I08143e5fa65978a6979b4a9a1753cfba8adaa3ed
Michal Michalski [Wed, 27 Nov 2019 15:13:10 +0000 (16:13 +0100)]
[messaging] Get rid of FoldersDataCallback structure.
[Verification] tct-messaging-*-tizen-tests 100% pass.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: If63afc96ff26cbd820aad8781e233eee8b3c4e26
Michal Michalski [Wed, 4 Dec 2019 07:59:42 +0000 (08:59 +0100)]
[messaging] MessageStorageFindFolders simplified implementation.
+ reimplement MessageStorageFindFolders without using PostQueue
+ replace FoldersCallbackData with simpler FindFoldersTaskParams
+ improve code readability in other minor ways
[Verification] tct-messaging-*-tizen-tests 100% pass rate.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I4842fc6e43971960f591b86b30d9d4d6720620a4
Michal Michalski [Wed, 4 Dec 2019 07:58:26 +0000 (08:58 +0100)]
[common] MessageStorageFindFolders simplified implementation.
+ add default constructor to PlatformResult
+ add tools::PostMessage overload for json message
[Verification] code compiles.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: Iafed8da9ebc6519f84f3341324f7ef4908ac9e61
Piotr Kosko [Mon, 2 Dec 2019 11:29:59 +0000 (11:29 +0000)]
Merge "[ham] Fixed sleep recorder, returned value" into tizen
[ham] Fixed sleep recorder, returned value
[Bug] there was missing conversion from numerical value from database to string value used in Web API
[Verification] TCT passrate 100% on wearable TW3.
Below code works when activity added manually to database.
var data = [];
date = new Date(), startTime = date.getTime(), endTime = date.setDate(date.getDate() + 1),
query = {
startTime: startTime/1000,
endTime: endTime/1000,
interval: 1440
};
tizen.humanactivitymonitor.readRecorderData("SLEEP_MONITOR", query, (s) => console.log(data = s), (s) => console.log(s))
returns one of values of "ASLEEP", "AWAKE", or "UNKNOWN"
Change-Id: I86b6bead534638bafcb5abcb16512bb462c79374
Pawel Wasowski [Thu, 22 Aug 2019 10:46:35 +0000 (12:46 +0200)]
[messaging] Remove unused code
Some class methods and fields were never used. This commit removes them.
[Verification] Code compiles
Change-Id: I978bc8e7ffc70f6ddb9c88ddb3dad33cdddd51ee
Signed-off-by: Pawel Wasowski <p.wasowski2@samsung.com>
Piotr Kosko [Tue, 26 Nov 2019 08:07:13 +0000 (08:07 +0000)]
Merge "[messaging] Fixed AttributeFilter for TO attribute." into tizen
Piotr Kosko [Tue, 26 Nov 2019 06:29:13 +0000 (06:29 +0000)]
Merge "[HAM] Adding accumulative pedometer data to HumanActivityPedometerData" into tizen
Piotr Kosko [Fri, 22 Nov 2019 11:01:39 +0000 (11:01 +0000)]
Merge "[tizen] Remove unused _filter() methods." into tizen
Piotr Kosko [Fri, 22 Nov 2019 10:59:02 +0000 (10:59 +0000)]
Merge "[tizen] Remove unused function." into tizen
Piotr Kosko [Fri, 22 Nov 2019 10:58:15 +0000 (10:58 +0000)]
Merge "[common] JsonFilter prototype implementation." into tizen
Merge branch 'tizen_5.5' into tizen
Change-Id: I3a58e60aa1c56fc0716a54e38d9dead62621292e
Merge branch 'tizen_5.0' into tizen_5.5
Change-Id: I39e4601ffb169013301568e4b1631f1b5234664e
Rafal Walczyna [Thu, 21 Nov 2019 08:31:42 +0000 (09:31 +0100)]
[MediaController] Fix removing invalid listener
CommandListener was removed instead of ChangeRequestPlaybackInfoListener.
It was impossible to add ChangeRequestPlaybackInfoListener again.
Verification: tct passrate 100%.
Tested in GoogleChrome console on TM1 and KantM2.
Change-Id: Iefec897b80c611421c9a7592df571ffe75588576
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Merge branch 'tizen_4.0' into tizen_5.0
Change-Id: I0e0154add6a286b1fb259a2d973210d3887c3a94
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: I19c718eb38545fda3bf0b49403e1cbd88960ec4f
[version] 2.38
Change-Id: Id74d1d21292bd36c33771009e5a6fac0bd50537b
Rafal Walczyna [Thu, 21 Nov 2019 08:31:42 +0000 (09:31 +0100)]
[MediaController] Fix removing invalid listener
CommandListener was removed instead of ChangeRequestPlaybackInfoListener.
It was impossible to add ChangeRequestPlaybackInfoListener again.
Verification: tct passrate 100%.
Tested in GoogleChrome console on TM1 and KantM2.
Change-Id: Iefec897b80c611421c9a7592df571ffe75588576
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Rafal Walczyna [Thu, 21 Nov 2019 10:46:10 +0000 (11:46 +0100)]
[MediaController] Fix removing invalid listener
CommandListener was removed instead of ChangeRequestPlaybackInfoListener.
It was impossible to add ChangeRequestPlaybackInfoListener again.
Verification: tct passrate 100%.
Tested in GoogleChrome console on TM1 and KantM2.
Change-Id: Iff0ea6026581b3649592ee5bde3bfb625ceb35e4
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Michal Michalski [Fri, 15 Nov 2019 09:46:24 +0000 (10:46 +0100)]
[tizen] Remove unused _filter() methods.
AttributeFilter, AttributeRangeFilter and CompositeFilter
classes had undocumented _filter method which was not used
anywhere within WebAPI.
[Verification] grep.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I4708d308be73ef619e63317c7fe9ba7aa974b067
Michal Michalski [Fri, 15 Nov 2019 09:21:53 +0000 (10:21 +0100)]
[tizen] Remove unused function.
Function _is_tizen_filter() was not used anywhere in the API.
[Verification] grep
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: Ia2e460264e46a1120d75e463f8102d5787caefcd
Michal Michalski [Thu, 14 Nov 2019 16:54:50 +0000 (17:54 +0100)]
[common] JsonFilter prototype implementation.
In present WebAPI implementation, several modules implement their own
data filtering algorithms. This commit is an attempt to provide a common,
unified way to perform data filtering across entire API.
Design goal for this change was simplicity. I was not looking for ways
to optimize the performance, as this will require in-depth performance
testing in specific use cases.
[Verification] Unit tests for JsonFilter class has been implemented which validate
main logic.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I6cfb9fc98f6a1be8d6364a9dfff2bf07ba239dfa
Piotr Kosko [Tue, 19 Nov 2019 10:27:15 +0000 (10:27 +0000)]
Merge "[messaging] Support new filtering options in findFolders (SMS/MMS)" into tizen
Piotr Kosko [Tue, 19 Nov 2019 10:12:29 +0000 (10:12 +0000)]
Merge "[Tizen] Remove unused PERMISSION_DENIED_ERR from code" into tizen
Piotr Kosko [Tue, 19 Nov 2019 10:10:15 +0000 (10:10 +0000)]
Merge "[Tizen] Remove unused DATABASE_ERROR from code" into tizen
Lukasz Bardeli [Mon, 18 Nov 2019 08:48:25 +0000 (09:48 +0100)]
[Tizen] Remove unused PERMISSION_DENIED_ERR from code
[Verification] Code compiles without error
Change-Id: Ib2a7bc19d493c7498ec9a03f11d6835d17fc8194
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Pawel Wasowski [Tue, 5 Mar 2019 16:38:11 +0000 (17:38 +0100)]
[messaging] Support new filtering options in findFolders (email)
Related ACR: TWDAPI-205
[Verification] tct-messaging-email-tests: pass rate
did not change after applying the commit
This commit has already been reviewed:
https://review.tizen.org/gerrit/#/c/platform/core/api/webapi-plugins/+/200909/
Change-Id of the original change was:
I911d1631d879fd805367f0837eec03e004b7167d
Change-Id: I75d057ba1ad12c760b455e040c41f0e143941e48
Signed-off-by: Pawel Wasowski <p.wasowski2@samsung.com>
Pawel Wasowski [Wed, 6 Mar 2019 17:11:57 +0000 (18:11 +0100)]
[messaging] Support new filtering options in findFolders (SMS/MMS)
Related ACR: TWDAPI-205
[Verification] tct-messaging-sms-tests & tct-messaging-mms-tests:
pass rate did not change after applying the commit
This commit has already been reviewed:
https://review.tizen.org/gerrit/#/c/platform/core/api/webapi-plugins/+/200975/
Change-Id of the original change was:
I8cea3b5cb0a0a19a827446c5bb34bce0e2710d7e
Change-Id: I88e7720dcbc6dd500d8bb27ae8aca4cd5d429655
Signed-off-by: Pawel Wasowski <p.wasowski2@samsung.com>
Lukasz Bardeli [Fri, 15 Nov 2019 11:38:30 +0000 (12:38 +0100)]
[Tizen] Remove unused DATABASE_ERROR from code
[Verification] Code compiles without error
Change-Id: Ic79afa711a55c9a50790242c5727a9a68f107c4f
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Arkadiusz Pietraszek [Thu, 14 Nov 2019 10:57:04 +0000 (11:57 +0100)]
[HAM] Adding accumulative pedometer data to HumanActivityPedometerData
[acr]
http://suprem.sec.samsung.net/jira/browse/TWDAPI-251
[verification]
100% tct pass rate.
Correctness of added data tested manually from console.
Change-Id: Ifad719572f4a20cef4f15a21a2e3e1bd918d1cce
Signed-off-by: Arkadiusz Pietraszek <a.pietraszek@partner.samsung.com>
Michal Michalski [Tue, 12 Nov 2019 12:57:27 +0000 (13:57 +0100)]
[messaging] Fixed AttributeFilter for TO attribute.
AttributeFilter in case of TO attribute accepts an array
of recipients instead of a single string, as was previously
incorrectly assumed in the implementation.
[Verification]
tct-messaging-email-tizen-tests 100%
tct-messaging-sms-tizen-tests 100%
tct-messaging-mms-tizen-tests 100%
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: If20589614ecd920a01a8afa1b987699fdf919ad2
Michal Michalski [Tue, 12 Nov 2019 07:31:21 +0000 (08:31 +0100)]
[messaging] Remove unnecessary assignment.
Related to SDL-83.
Change-Id: Ida4ef88c145e7d4a4e1a7cec5ba8f73b5a4b90c1
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Michal Michalski [Fri, 8 Nov 2019 10:07:13 +0000 (11:07 +0100)]
[messaging] Autoformat changes in messaging.
Change-Id: I84cf3cc8c1a5b6d32c3d1b6f8f9eadc739960be8
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Michal Michalski [Thu, 7 Nov 2019 14:48:03 +0000 (15:48 +0100)]
[messaging] Remove unused class MessageInit.
[Verification] tct-messaging-*-tizen-tests on tm1
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: Iba06a2a88b2d5ddec8a4b1f15ffa78e584dcf638
Michal Michalski [Thu, 7 Nov 2019 10:23:03 +0000 (11:23 +0100)]
[messaging] Full names for Property' properties.
Change-Id: I3ab213ba72f379e9870a7b53b8f7c3ff021b798c
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Michal Michalski [Thu, 7 Nov 2019 10:17:53 +0000 (11:17 +0100)]
[messaging] Remove useless comments.
Change-Id: I3b74b456b2a32a51fce8962c10edd60c1421749f
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Michal Michalski [Thu, 7 Nov 2019 10:13:46 +0000 (11:13 +0100)]
[messaging] Remove unused throwException() function.
Change-Id: Ica78a9bb1d2fc04576638262dd7cf9a7d82b64f8
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Merge branch 'tizen_5.5' into tizen
Change-Id: Ib997566539925f328fd3475d0cdfeff85287e394
Merge branch 'tizen_5.0' into tizen_5.5
Change-Id: Idf6d2c38e14c84cdc16f79e33f2055f4e490e735
Merge branch 'tizen_4.0' into tizen_5.0
Change-Id: I2b03c54dc49d3de0aafbf08bd5f037ce97ecd2ec
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: Icba6eb40bb40a300befb71d01aa07320ea68b069
[version] 2.37
Change-Id: Ib1de6d53a704c6321d70c5202b5a5fcc3b055ead
Piotr Kosko [Tue, 5 Nov 2019 09:34:28 +0000 (09:34 +0000)]
Merge "[filesystem] Fix getAllStorages" into tizen
Rafal Walczyna [Tue, 29 Oct 2019 12:58:14 +0000 (13:58 +0100)]
[filesystem] Fix getAllStorages
Fixed bug which causes to show duplicated values of internal
and external storages
[verification] Filesystem and Archive tct - 100% pass.
Change-Id: Ic087583a906eecfa040d97cb903f4c99838c6591
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Rafal Walczyna [Tue, 29 Oct 2019 12:58:14 +0000 (13:58 +0100)]
[filesystem] Fix getAllStorages
Fixed bug which causes to show duplicated values of internal
and external storages
[verification] Filesystem and Archive tct - 100% pass.
Change-Id: Ic087583a906eecfa040d97cb903f4c99838c6591
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Rafal Walczyna [Tue, 29 Oct 2019 12:58:14 +0000 (13:58 +0100)]
[filesystem] Fix getAllStorages
Fixed bug which causes to show duplicated values of internal
and external storages
[verification] Filesystem and Archive tct - 100% pass.
Change-Id: Ic087583a906eecfa040d97cb903f4c99838c6591
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Rafal Walczyna [Tue, 29 Oct 2019 12:58:14 +0000 (13:58 +0100)]
[filesystem] Fix getAllStorages
Fixed bug which causes to show duplicated values of internal
and external storages
[verification] Filesystem and Archive tct - 100% pass.
Change-Id: Ic087583a906eecfa040d97cb903f4c99838c6591
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Piotr Kosko [Tue, 5 Nov 2019 09:25:26 +0000 (09:25 +0000)]
Merge "[common] Check if external storage is supported." into tizen
Michal Michalski [Mon, 4 Nov 2019 16:19:47 +0000 (17:19 +0100)]
[common] Check if external storage is supported.
If external.storage feature is not supported on the device,
we shouldn't try to fetch external storage devices list.
[Verification]
On mobile devices external storages are fetched.
On wearable devices only internal storages are returned.
+ tct-filesystem-tizen-tests 100% pass rate (mobile, wearable)
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I965c91c278ec85adbb81e7ca98b4b98604011b23
Michal Michalski [Mon, 4 Nov 2019 18:04:22 +0000 (19:04 +0100)]
[mergejs] Restore disabled js minification.
My previous change in mergejs.py and generate_api.py scripts
accidentally disabled javascript source minification, which resulted
in larger rpm packages sizes. This commit enables the minification.
[Verification] Packages contain minified sources.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I43d46aca083806885939aee296391eec3ecc0b5b
Rafal Walczyna [Tue, 29 Oct 2019 12:58:14 +0000 (13:58 +0100)]
[filesystem] Fix getAllStorages
Fixed bug which causes to show duplicated values of internal
and external storages
[verification] Filesystem and Archive tct - 100% pass.
Change-Id: Ic087583a906eecfa040d97cb903f4c99838c6591
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Piotr Kosko [Thu, 31 Oct 2019 10:55:00 +0000 (10:55 +0000)]
Merge "[common] Simplify instance methods registration (5)" into tizen
Piotr Kosko [Thu, 31 Oct 2019 10:42:27 +0000 (10:42 +0000)]
Merge "[common] Simplify instance methods registration (4)" into tizen
Piotr Kosko [Thu, 31 Oct 2019 10:36:51 +0000 (10:36 +0000)]
Merge "[mediacontroller] Register Custom Events methods." into tizen
Michal Michalski [Wed, 30 Oct 2019 17:14:54 +0000 (18:14 +0100)]
[common] Simplify instance methods registration (5)
+ Macros REGISTER_(A)SYNC have been replaced with new macro
REGISTER_METHOD, which takes only the method name.
The string parameter is now created from the method name.
[Verification]
+ tct-sensor-tizen-tests 100% pass (mobile)
+ tct-sound-tizen-tests 100% pass (mobile)
+ tct-systeminfo-tizen-tests 100% pass (mobile)
+ tct-systemsetting-tizen-tests 100% pass (mobile)
+ tct-time-tizen-tests 100% pass (mobile)
+ !!! utils module has no tests !!!
+ tct-voicecontrol-tizen-tests 100% pass (mobile)
+ tct-widgetservice-tizen-tests 100% pass (tw3)
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I41180f982002e547080f9c311e82cf468fadbd05
Michal Michalski [Wed, 30 Oct 2019 16:56:00 +0000 (17:56 +0100)]
[mediacontroller] Register Custom Events methods.
Due to the conflict with recent refactoring efforts,
all MediaControllerInstance methods related to the
custom server events feature have not been registered
and thus inaccessible from JS API.
Recently TCT tests for this feature have been added,
uncovering this issue. This commit fixes the problem.
http://suprem.sec.samsung.net/jira/browse/TWDAPI-209
[Verification]
tct-mediacontroller-tizen-tests 100% pass rate
including custom events test cases.
Change-Id: I0a15848e1299ad8a07f6ff4e96d4062a69351026
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Michal Michalski [Wed, 30 Oct 2019 11:28:49 +0000 (12:28 +0100)]
[common] Simplify instance methods registration (4)
+ Macros REGISTER_(A)SYNC have been replaced with new macro
REGISTER_METHOD, which takes only the method name.
The string parameter is now created from the method name.
[Verification] + tct-notification-tizen-tests 100% pass (mobile)
+ tct-package-tizen-tests 100% pass (mobile)
+ tct-playerutil-tizen-tests 100% pass (mobile)
+ tct-power-tizen-tests 100% pass (mobile)
+ tct-privacyprivilege-tizen-tests 100% pass (mobile)
+ tct-preference-tizen-tests 100% pass (mobile)
+ tct-push-tizen-tests 100% pass (mobile)
+ tct-fmradio-tizen-tests 100% pass (mobile)
+ tct-secureelement-tizen-tests 100% pass (mobile)
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: Ie3e5b6f88c283dce6a6703980a1e8d597b3e4d41
Michal Michalski [Mon, 28 Oct 2019 12:53:26 +0000 (13:53 +0100)]
[common] Simplify instance methods registration (3)
+ Macros REGISTER_(A)SYNC have been replaced with new macro
REGISTER_METHOD, which takes only the method name.
The string parameter is now created from the method name.
+ Fixed SVACE detected missing break at the end of the case
in iotcon_instance.cc:1317
+ removed declaration-only method from NFCInstance class.
[Verification]
+ tct-iotcon-tizen-tests 100% pass rate (mobile)
+ tct-keymanager-tizen-tests 100% pass rate (mobile)
+ tct-mediakey-tizen-tests 100% pass rate (mobile)
+ tct-messageport-tizen-tests 100% pass rate (mobile)
+ tct-networkbearerselection-tizen-tests (mobile)
+ tct-messaging-tizen-tests (mobile SMS auto)
+ tct-nfc-tizen-tests (mobile, auto) 98% pass rate
3 tests failed: NFCAdapter_setPreferredApp
Even without this change.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I3f6c6fadd8e5fe78f64a728c4de5fa11dc1191d0
Michal Michalski [Fri, 4 Oct 2019 09:58:33 +0000 (11:58 +0200)]
[datacontrol][common] Simplify instance methods registration (2)
Macros REGISTER_(A)SYNC have been replaced with new macro
REGISTER_METHOD, which takes only the method name.
The string parameter is now created from the method name.
[Verification] + tct-datacontrol-tizen-tests 100% pass rate.
+ tct-download-tizen-tests 100% pass rate.
+ tct-exif-tizen-tests 100% pass rate.
+ tct-feedback-tizen-tests 100% pass rate.
+ tct-filesystem-tizen-tests 100% pass rate.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: Idb2ce6c9aa15743822aed405a3be5d2156102d60
Piotr Kosko [Mon, 28 Oct 2019 12:20:14 +0000 (12:20 +0000)]
Merge "[tools] Rewritten mergejs.py and generate_api.py scripts." into tizen
Michal Michalski [Mon, 30 Sep 2019 15:48:27 +0000 (17:48 +0200)]
[common] Simplify instance methods registration.
Macros REGISTER_(A)SYNC have been replaced with new macro
REGISTER_METHOD, which takes only the method name.
The string parameter is now created from the method name.
[Verification] + tct-mediacontroller-tizen-tests 100% pass rate.
+ tct-account-tizen-tests 100% pass rate.
+ tct-alarm-tizen-tests 100% pass rate.
+ tct-application-tizen-tests 100% pass rate (requires screen always on).
+ tct-archive-tizen-tests 100% pass rate.
+ tct-badge-tizen-tests 100% pass rate.
+ tct-bluetooth-tizen-tests 100% pass rate.
+ tct-bookmark-tizen-tests 100% pass rate.
+ tct-calendar-tizen-tests 100% pass rate.
+ tct-callhistory-tizen-tests 100% pass rate.
+ tct-contact-tizen-tests 100% pass rate.
+ tct-content-tizen-tests 100% pass rate.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I9be38c2946b2ebb8ea5d1bfbb99ab16a637a3977
[Spec] Fixed build fail for non arm and i586 architectures
Related projects:
github.sec.samsung.net:tizen/webapi-plugins-teec.git
review.tizen.org:29418/platform/core/api/cordova-plugins
fails during the build in case of architectures: x86_64,aarch64,x86_64
[verification] With this fix, related projects are buildable for 64-bit
architectures
Change-Id: I36759e460cb68dc94da0c6843f2995c33795ba03
Michal Michalski [Tue, 22 Oct 2019 14:48:15 +0000 (16:48 +0200)]
[tools] Rewritten mergejs.py and generate_api.py scripts.
+ tools/generate_api.py has been rewritten to be more readable.
+ tools/mergejs.py has been rewritten to work more like C++ include directive,\
to be more of a in-place copy-paste mechanism.
Previously the only way to use //=require() was to create a file in which no code
other than the require() directives was allowed to be. If there was some code it
was removed during the preprocessing phase. After this change it is possible to
mix code and require() commands in the same file.
[Verification] I've tested this change by running TCTs for all modules that use require() directive
(all modules with js/ subdir).
tct-filesystem-tizen-tests 100% pass
tct-calendar-tizen-tests 100% pass
tct-contact-tizen-tests 100% pass
tct-content-tizen-tests 100% pass
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I71436797b78a1746b9ea105bc466a75d42d26ddb
Merge branch 'tizen_5.0' into tizen
Change-Id: I2d06bd464e969ded8967bfbdc3b3df8646384ad0
Merge branch 'tizen_4.0' into tizen_5.0
Change-Id: I486c2595028dc8e9cf7555aa13ae114fe8af7be3
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: I99c57c205dd95970412c98430b9998c773a94917
[version] 2.36
Change-Id: I99c7c0258b677468f6a163e03a7807411dbbde56
[Bluetooth] Fixed issues related to BLE
[Bug/Fix]
1. Prevent possible crash in case of invalid data passed from native
2. Prevent type mismatch exception in JS in case of LE devices advertising
serviceData.
[Verification] tct passrate 100%
Checked in chrome console and le device with serviceData.
Change-Id: Iecc9929a77a1acfd1b33eb325ea287011b9a6096
Pawel Wasowski [Wed, 27 Feb 2019 19:14:19 +0000 (20:14 +0100)]
[messaging] Fix bugs occurring when filtering by strings or value ranges
The following bugs have been fixed:
- daylight saving time was not taken into account when filtering by
timestamp attribute with AttributeRangeFilter
- AttributeRangeFilter did not work with null/undefined range limits
- isBetweenTimeRange did not work properly with lower limit close to the
minimal value of time_t type variables
- filter with an empty string matchValue never matched other strings
[Verification] Subtestcases from TCT tests added in
https://review.tizen.org/gerrit/#/c/test/tct/web/api/+/199159/
that used to fail due to the described bugs now pass.
tct-messaging-sms-tizen-tests pass rate: 100%
This commit has already been reviewed:
https://review.tizen.org/gerrit/#/c/platform/core/api/webapi-plugins/+/200662/
Change-Id of the original change was:
Ia6c2074408e8f4fadd10605d6986b5a2d2d4c93b
Change-Id: I6d28a8d153a34cf54084dae5585cbd7d0e771e4a
Signed-off-by: Pawel Wasowski <p.wasowski2@samsung.com>
Piotr Kosko [Fri, 18 Oct 2019 11:37:12 +0000 (11:37 +0000)]
Merge "[messaging][bugfix] Don't convert filter's matchValue to String" into tizen
Pawel Wasowski [Wed, 27 Feb 2019 16:06:45 +0000 (17:06 +0100)]
[messaging][bugfix] Don't convert filter's matchValue to String
Due to a conversion of matchValue to String, filters with boolean
matchValues did not match objects.
[Verification] All subtest cases, dealing with boolean attributes,
introduced in TCT in commit
https://review.tizen.org/gerrit/#/c/test/tct/web/api/+/199159/
passed.
This commit has already been reviewed:
https://review.tizen.org/gerrit/#/c/platform/core/api/webapi-plugins/+/200661/
Change-Id of the original change was:
I72fc83328e92529455460469c5dbc1aadc6ce07e
Signed-off-by: Pawel Wasowski <p.wasowski2@samsung.com>
Change-Id: Ia8d769b1a9694defdcb403761cff9c2565f5f52b
Piotr Kosko [Fri, 18 Oct 2019 11:32:39 +0000 (11:32 +0000)]
Merge "[mediacontroller][fix] fix small issues" into tizen
Dawid Juszczak [Wed, 16 Oct 2019 09:37:11 +0000 (11:37 +0200)]
[mediacontroller][fix] fix small issues
issues:
- startup state of server's repeat state was REPEAT_OFF,
should be REPEAT_ALL
- if client sent request to change attribute to
currently set value, callback was not invoked. Now
it is fixed.
- add repeatState to playbackInfo returned by
playbackInfo getter
[Verification]
tct-mediacontroller-tizen-tests 100% PASS
Change-Id: Iebdbf2ca3af1d395c2ba10753e0ef7efcdc11953
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
Dawid Juszczak [Thu, 17 Oct 2019 09:02:32 +0000 (11:02 +0200)]
[mediacontroller][5.5] fix method to update playback item
[ACR]
http://suprem.sec.samsung.net/jira/browse/TWDAPI-240
[description]
removed checking if playlist exists on device, because
some 3rd party application can get the playlist
from the 3rd party server(such as cloud) directly and we
don't have any information about its name and index
[verification]
MediaControllerServer_updatePlaybackItem_invalid.html - only
this testcase fails (from tct-mediacontroller-tizen-tests).
It needs to be changed/removed
Change-Id: I7809b662a2eb9b99af3690892133e85ed9b41865
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
Michal Michalski [Fri, 11 Oct 2019 09:15:08 +0000 (11:15 +0200)]
[mediacontroller] Autoformatting changes in mediacontroller.
Autoformatting of changes in mediacontroller.
Change-Id: I8e576444123cdc98766c41ae014073964757fc0e
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Michal Michalski [Wed, 9 Oct 2019 08:26:10 +0000 (10:26 +0200)]
[mediacontroller] SendEvent() js tests fixed + code autoformat.
+ Executed ./code_format script on mediacontroller source code.
+ Fixed invalid tests for MediaControllerClientInfo::sendEvent() method.
+ Fixed minor issues from earlier reviews.
+ initialized all JsonCallbacks to nullptr in constructors of MediaControllerClient/Server
[Verification] tests from test_custom_event.js 100% pass.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I9514897908e8221ed6f1c8eb1c1ed0083bad0996
[version] 2.53
Change-Id: I91b439ad78c3c11da5ed5622ce55d0e84a3253fb
Michal Michalski [Tue, 8 Oct 2019 15:10:04 +0000 (17:10 +0200)]
[utils][mediacontroller] SendEvent() method implementation.
[ACR] http://suprem.sec.samsung.net/jira/browse/TWDAPI-209
SendEvent()
SendReply()
[Verification] TCT: mediacontroller and deprecated API 100% pass.
New features tested in chrome console.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: If2230979c33f253fbd80171937ac64a8d90d4215
Michal Michalski [Tue, 8 Oct 2019 13:45:45 +0000 (15:45 +0200)]
[mediacontroller] Add UnsetCustomEventListener() method.
[ACR] http://suprem.sec.samsung.net/jira/browse/TWDAPI-209
MediaControllerClient::UnsetCustomEventListener() method implementation.
[Verification] Will be done later with SendEvent().
Change-Id: I7c92243b0abe211dfa11735a11dc29b1fa0496dd
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Michal Michalski [Tue, 8 Oct 2019 13:10:50 +0000 (15:10 +0200)]
[mediacontroller] Add MediaControllerClient::SetCustomEventListener()
[ACR] http://suprem.sec.samsung.net/jira/browse/TWDAPI-209
MediaControllerClient::SetCustomEventListener() method implementation.
[Verification] Will be verified later with SendEvent().
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: Id30be750edc940e331053c353dc0944ef7d2f18a
Michal Michalski [Tue, 8 Oct 2019 11:19:00 +0000 (13:19 +0200)]
[mediacontroller] Add MediaControllerClientInfo interface.
[ACR] http://suprem.sec.samsung.net/jira/browse/TWDAPI-209
+ MediaControllerClientInfo:
+ attribute name: string
MediaControllerServer:
+ getAllClientsInfo()
[Verification] Unit tests for MediaControllerClientInfo pass.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I321865c99059a21b02f6bdf9f48f9f001fbf2642
Michal Michalski [Tue, 8 Oct 2019 09:53:19 +0000 (11:53 +0200)]
[mediacontroller][ut] Custom events tests.
[ACR] http://suprem.sec.samsung.net/jira/browse/TWDAPI-209
Tests for custom events feature of media controller.
[Verification] none.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I5069f64fc9ff6514ebe830eec30c1777b99bdffe
Lukasz Bardeli [Thu, 3 Oct 2019 11:37:03 +0000 (13:37 +0200)]
[version] 2.52
Change-Id: Ic95f124aaf9c015dc6f17d528d88ab32d2ea14b6
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Dawid Juszczak [Wed, 2 Oct 2019 14:25:12 +0000 (16:25 +0200)]
[mediacontroller][fix] fix metadata issue
Problem was connected to PlaybackInfo.metadata.
It was throwing an error while null value was set as encoded attributes
like resolution, episode and season. Now it is fixed by checking if
value is null before decoding it.
[Verification]
tested manually on chrome console
tct-deprecatedapi-tizen-tests 100% PASS
tct-mediacontroller-tizen-tests 100% PASS
Change-Id: Ibc0f44591b75dd53348ff1db2900e3da581534a0
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
Piotr Kosko [Mon, 30 Sep 2019 14:03:03 +0000 (14:03 +0000)]
Merge "[fix][mediacontroller] fix error with new metadata features" into tizen
Dawid Juszczak [Mon, 30 Sep 2019 14:01:35 +0000 (16:01 +0200)]
[fix][mediacontroller] fix error with new metadata features
Change-Id: I957a41a84d1a8382c060ea615485c0c0f4d18602
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
Piotr Kosko [Mon, 30 Sep 2019 13:44:44 +0000 (13:44 +0000)]
Merge "[mediacontroller] add api for new metadata features" into tizen
Dawid Juszczak [Thu, 26 Sep 2019 14:23:22 +0000 (16:23 +0200)]
[mediacontroller] add api for new metadata features
[ACR]
http://suprem.sec.samsung.net/jira/browse/TWDAPI-238
[Verification]
tested manually on chrome console
tct-mediacontroller-tizen-tests 100% PASS
Change-Id: I459724bfa88ab9a37a97be55eda0bd2e01e83add
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
Piotr Kosko [Mon, 30 Sep 2019 10:46:50 +0000 (10:46 +0000)]
Merge changes I5e7e74fa,Icc3aa5bb into tizen
* changes:
[mediacontroller] Check for errors added.
[mediacontroller] Magic strings to constants.
Michal Michalski [Fri, 27 Sep 2019 10:48:45 +0000 (12:48 +0200)]
[mediacontroller] Check for errors added.
+ Result of native call to SendCommand was not checked for failure.
This commit adds this validation.
+ Added return after error occured in AddPlaybackInfoChangeList().
[Verification] All tests pass.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I5e7e74faa1c8902f35e45278c7c05778094867c4
Michal Michalski [Mon, 23 Sep 2019 13:35:42 +0000 (15:35 +0200)]
[mediacontroller] Magic strings to constants.
Keys of args passed from JS to instance methods were used
as inline strings, rather than constants.
[Verification] MediaController TCT tests
20190920 100% pass.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: Icc3aa5bb5bd947cf6bb680d15f4edc077901361b
Merge branch 'tizen_5.0' into tizen
Change-Id: I02a3c6d93c0924a0cf313110a3f79c4b67a7def8
Merge branch 'tizen_4.0' into tizen_5.0
Change-Id: I6307aead894899f049bacde9cb8af54febe91251
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: Iea1a8a0914572301a28c53d54bf64c795237ce44
[version] 2.35
Change-Id: Ifc5a4e534e395579031af9d3d115389b7545ab77
Rafal Walczyna [Fri, 27 Sep 2019 08:33:30 +0000 (10:33 +0200)]
[Filesystem] Source code auto-formatting
Used: ./code_format src/ -c -js
Change-Id: I1a27efa220445342ec42ef5327d06ac7bdd40ca9
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
projects / platform / core / api / webapi-plugins.git / log