Pawel Wasowski [Tue, 5 Mar 2019 16:38:11 +0000 (17:38 +0100)]
[messaging] Support new filtering options in findFolders (email)
Related ACR: TWDAPI-205
[Verification] tct-messaging-email-tests: pass rate
did not change after applying the commit
This commit has already been reviewed:
https://review.tizen.org/gerrit/#/c/platform/core/api/webapi-plugins/+/200909/
Change-Id of the original change was:
I911d1631d879fd805367f0837eec03e004b7167d
Change-Id: I75d057ba1ad12c760b455e040c41f0e143941e48
Signed-off-by: Pawel Wasowski <p.wasowski2@samsung.com>
Michal Michalski [Fri, 8 Nov 2019 10:07:13 +0000 (11:07 +0100)]
[messaging] Autoformat changes in messaging.
Change-Id: I84cf3cc8c1a5b6d32c3d1b6f8f9eadc739960be8
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Michal Michalski [Thu, 7 Nov 2019 14:48:03 +0000 (15:48 +0100)]
[messaging] Remove unused class MessageInit.
[Verification] tct-messaging-*-tizen-tests on tm1
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: Iba06a2a88b2d5ddec8a4b1f15ffa78e584dcf638
Michal Michalski [Thu, 7 Nov 2019 10:23:03 +0000 (11:23 +0100)]
[messaging] Full names for Property' properties.
Change-Id: I3ab213ba72f379e9870a7b53b8f7c3ff021b798c
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Michal Michalski [Thu, 7 Nov 2019 10:17:53 +0000 (11:17 +0100)]
[messaging] Remove useless comments.
Change-Id: I3b74b456b2a32a51fce8962c10edd60c1421749f
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Michal Michalski [Thu, 7 Nov 2019 10:13:46 +0000 (11:13 +0100)]
[messaging] Remove unused throwException() function.
Change-Id: Ica78a9bb1d2fc04576638262dd7cf9a7d82b64f8
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Merge branch 'tizen_5.5' into tizen
Change-Id: Ib997566539925f328fd3475d0cdfeff85287e394
Merge branch 'tizen_5.0' into tizen_5.5
Change-Id: Idf6d2c38e14c84cdc16f79e33f2055f4e490e735
Merge branch 'tizen_4.0' into tizen_5.0
Change-Id: I2b03c54dc49d3de0aafbf08bd5f037ce97ecd2ec
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: Icba6eb40bb40a300befb71d01aa07320ea68b069
[version] 2.37
Change-Id: Ib1de6d53a704c6321d70c5202b5a5fcc3b055ead
Piotr Kosko [Tue, 5 Nov 2019 09:34:28 +0000 (09:34 +0000)]
Merge "[filesystem] Fix getAllStorages" into tizen
Rafal Walczyna [Tue, 29 Oct 2019 12:58:14 +0000 (13:58 +0100)]
[filesystem] Fix getAllStorages
Fixed bug which causes to show duplicated values of internal
and external storages
[verification] Filesystem and Archive tct - 100% pass.
Change-Id: Ic087583a906eecfa040d97cb903f4c99838c6591
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Rafal Walczyna [Tue, 29 Oct 2019 12:58:14 +0000 (13:58 +0100)]
[filesystem] Fix getAllStorages
Fixed bug which causes to show duplicated values of internal
and external storages
[verification] Filesystem and Archive tct - 100% pass.
Change-Id: Ic087583a906eecfa040d97cb903f4c99838c6591
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Rafal Walczyna [Tue, 29 Oct 2019 12:58:14 +0000 (13:58 +0100)]
[filesystem] Fix getAllStorages
Fixed bug which causes to show duplicated values of internal
and external storages
[verification] Filesystem and Archive tct - 100% pass.
Change-Id: Ic087583a906eecfa040d97cb903f4c99838c6591
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Rafal Walczyna [Tue, 29 Oct 2019 12:58:14 +0000 (13:58 +0100)]
[filesystem] Fix getAllStorages
Fixed bug which causes to show duplicated values of internal
and external storages
[verification] Filesystem and Archive tct - 100% pass.
Change-Id: Ic087583a906eecfa040d97cb903f4c99838c6591
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Piotr Kosko [Tue, 5 Nov 2019 09:25:26 +0000 (09:25 +0000)]
Merge "[common] Check if external storage is supported." into tizen
Michal Michalski [Mon, 4 Nov 2019 16:19:47 +0000 (17:19 +0100)]
[common] Check if external storage is supported.
If external.storage feature is not supported on the device,
we shouldn't try to fetch external storage devices list.
[Verification]
On mobile devices external storages are fetched.
On wearable devices only internal storages are returned.
+ tct-filesystem-tizen-tests 100% pass rate (mobile, wearable)
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I965c91c278ec85adbb81e7ca98b4b98604011b23
Michal Michalski [Mon, 4 Nov 2019 18:04:22 +0000 (19:04 +0100)]
[mergejs] Restore disabled js minification.
My previous change in mergejs.py and generate_api.py scripts
accidentally disabled javascript source minification, which resulted
in larger rpm packages sizes. This commit enables the minification.
[Verification] Packages contain minified sources.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I43d46aca083806885939aee296391eec3ecc0b5b
Rafal Walczyna [Tue, 29 Oct 2019 12:58:14 +0000 (13:58 +0100)]
[filesystem] Fix getAllStorages
Fixed bug which causes to show duplicated values of internal
and external storages
[verification] Filesystem and Archive tct - 100% pass.
Change-Id: Ic087583a906eecfa040d97cb903f4c99838c6591
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Piotr Kosko [Thu, 31 Oct 2019 10:55:00 +0000 (10:55 +0000)]
Merge "[common] Simplify instance methods registration (5)" into tizen
Piotr Kosko [Thu, 31 Oct 2019 10:42:27 +0000 (10:42 +0000)]
Merge "[common] Simplify instance methods registration (4)" into tizen
Piotr Kosko [Thu, 31 Oct 2019 10:36:51 +0000 (10:36 +0000)]
Merge "[mediacontroller] Register Custom Events methods." into tizen
Michal Michalski [Wed, 30 Oct 2019 17:14:54 +0000 (18:14 +0100)]
[common] Simplify instance methods registration (5)
+ Macros REGISTER_(A)SYNC have been replaced with new macro
REGISTER_METHOD, which takes only the method name.
The string parameter is now created from the method name.
[Verification]
+ tct-sensor-tizen-tests 100% pass (mobile)
+ tct-sound-tizen-tests 100% pass (mobile)
+ tct-systeminfo-tizen-tests 100% pass (mobile)
+ tct-systemsetting-tizen-tests 100% pass (mobile)
+ tct-time-tizen-tests 100% pass (mobile)
+ !!! utils module has no tests !!!
+ tct-voicecontrol-tizen-tests 100% pass (mobile)
+ tct-widgetservice-tizen-tests 100% pass (tw3)
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I41180f982002e547080f9c311e82cf468fadbd05
Michal Michalski [Wed, 30 Oct 2019 16:56:00 +0000 (17:56 +0100)]
[mediacontroller] Register Custom Events methods.
Due to the conflict with recent refactoring efforts,
all MediaControllerInstance methods related to the
custom server events feature have not been registered
and thus inaccessible from JS API.
Recently TCT tests for this feature have been added,
uncovering this issue. This commit fixes the problem.
http://suprem.sec.samsung.net/jira/browse/TWDAPI-209
[Verification]
tct-mediacontroller-tizen-tests 100% pass rate
including custom events test cases.
Change-Id: I0a15848e1299ad8a07f6ff4e96d4062a69351026
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Michal Michalski [Wed, 30 Oct 2019 11:28:49 +0000 (12:28 +0100)]
[common] Simplify instance methods registration (4)
+ Macros REGISTER_(A)SYNC have been replaced with new macro
REGISTER_METHOD, which takes only the method name.
The string parameter is now created from the method name.
[Verification] + tct-notification-tizen-tests 100% pass (mobile)
+ tct-package-tizen-tests 100% pass (mobile)
+ tct-playerutil-tizen-tests 100% pass (mobile)
+ tct-power-tizen-tests 100% pass (mobile)
+ tct-privacyprivilege-tizen-tests 100% pass (mobile)
+ tct-preference-tizen-tests 100% pass (mobile)
+ tct-push-tizen-tests 100% pass (mobile)
+ tct-fmradio-tizen-tests 100% pass (mobile)
+ tct-secureelement-tizen-tests 100% pass (mobile)
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: Ie3e5b6f88c283dce6a6703980a1e8d597b3e4d41
Michal Michalski [Mon, 28 Oct 2019 12:53:26 +0000 (13:53 +0100)]
[common] Simplify instance methods registration (3)
+ Macros REGISTER_(A)SYNC have been replaced with new macro
REGISTER_METHOD, which takes only the method name.
The string parameter is now created from the method name.
+ Fixed SVACE detected missing break at the end of the case
in iotcon_instance.cc:1317
+ removed declaration-only method from NFCInstance class.
[Verification]
+ tct-iotcon-tizen-tests 100% pass rate (mobile)
+ tct-keymanager-tizen-tests 100% pass rate (mobile)
+ tct-mediakey-tizen-tests 100% pass rate (mobile)
+ tct-messageport-tizen-tests 100% pass rate (mobile)
+ tct-networkbearerselection-tizen-tests (mobile)
+ tct-messaging-tizen-tests (mobile SMS auto)
+ tct-nfc-tizen-tests (mobile, auto) 98% pass rate
3 tests failed: NFCAdapter_setPreferredApp
Even without this change.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I3f6c6fadd8e5fe78f64a728c4de5fa11dc1191d0
Michal Michalski [Fri, 4 Oct 2019 09:58:33 +0000 (11:58 +0200)]
[datacontrol][common] Simplify instance methods registration (2)
Macros REGISTER_(A)SYNC have been replaced with new macro
REGISTER_METHOD, which takes only the method name.
The string parameter is now created from the method name.
[Verification] + tct-datacontrol-tizen-tests 100% pass rate.
+ tct-download-tizen-tests 100% pass rate.
+ tct-exif-tizen-tests 100% pass rate.
+ tct-feedback-tizen-tests 100% pass rate.
+ tct-filesystem-tizen-tests 100% pass rate.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: Idb2ce6c9aa15743822aed405a3be5d2156102d60
Piotr Kosko [Mon, 28 Oct 2019 12:20:14 +0000 (12:20 +0000)]
Merge "[tools] Rewritten mergejs.py and generate_api.py scripts." into tizen
Michal Michalski [Mon, 30 Sep 2019 15:48:27 +0000 (17:48 +0200)]
[common] Simplify instance methods registration.
Macros REGISTER_(A)SYNC have been replaced with new macro
REGISTER_METHOD, which takes only the method name.
The string parameter is now created from the method name.
[Verification] + tct-mediacontroller-tizen-tests 100% pass rate.
+ tct-account-tizen-tests 100% pass rate.
+ tct-alarm-tizen-tests 100% pass rate.
+ tct-application-tizen-tests 100% pass rate (requires screen always on).
+ tct-archive-tizen-tests 100% pass rate.
+ tct-badge-tizen-tests 100% pass rate.
+ tct-bluetooth-tizen-tests 100% pass rate.
+ tct-bookmark-tizen-tests 100% pass rate.
+ tct-calendar-tizen-tests 100% pass rate.
+ tct-callhistory-tizen-tests 100% pass rate.
+ tct-contact-tizen-tests 100% pass rate.
+ tct-content-tizen-tests 100% pass rate.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I9be38c2946b2ebb8ea5d1bfbb99ab16a637a3977
[Spec] Fixed build fail for non arm and i586 architectures
Related projects:
github.sec.samsung.net:tizen/webapi-plugins-teec.git
review.tizen.org:29418/platform/core/api/cordova-plugins
fails during the build in case of architectures: x86_64,aarch64,x86_64
[verification] With this fix, related projects are buildable for 64-bit
architectures
Change-Id: I36759e460cb68dc94da0c6843f2995c33795ba03
Michal Michalski [Tue, 22 Oct 2019 14:48:15 +0000 (16:48 +0200)]
[tools] Rewritten mergejs.py and generate_api.py scripts.
+ tools/generate_api.py has been rewritten to be more readable.
+ tools/mergejs.py has been rewritten to work more like C++ include directive,\
to be more of a in-place copy-paste mechanism.
Previously the only way to use //=require() was to create a file in which no code
other than the require() directives was allowed to be. If there was some code it
was removed during the preprocessing phase. After this change it is possible to
mix code and require() commands in the same file.
[Verification] I've tested this change by running TCTs for all modules that use require() directive
(all modules with js/ subdir).
tct-filesystem-tizen-tests 100% pass
tct-calendar-tizen-tests 100% pass
tct-contact-tizen-tests 100% pass
tct-content-tizen-tests 100% pass
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I71436797b78a1746b9ea105bc466a75d42d26ddb
Merge branch 'tizen_5.0' into tizen
Change-Id: I2d06bd464e969ded8967bfbdc3b3df8646384ad0
Merge branch 'tizen_4.0' into tizen_5.0
Change-Id: I486c2595028dc8e9cf7555aa13ae114fe8af7be3
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: I99c57c205dd95970412c98430b9998c773a94917
[version] 2.36
Change-Id: I99c7c0258b677468f6a163e03a7807411dbbde56
[Bluetooth] Fixed issues related to BLE
[Bug/Fix]
1. Prevent possible crash in case of invalid data passed from native
2. Prevent type mismatch exception in JS in case of LE devices advertising
serviceData.
[Verification] tct passrate 100%
Checked in chrome console and le device with serviceData.
Change-Id: Iecc9929a77a1acfd1b33eb325ea287011b9a6096
Pawel Wasowski [Wed, 27 Feb 2019 19:14:19 +0000 (20:14 +0100)]
[messaging] Fix bugs occurring when filtering by strings or value ranges
The following bugs have been fixed:
- daylight saving time was not taken into account when filtering by
timestamp attribute with AttributeRangeFilter
- AttributeRangeFilter did not work with null/undefined range limits
- isBetweenTimeRange did not work properly with lower limit close to the
minimal value of time_t type variables
- filter with an empty string matchValue never matched other strings
[Verification] Subtestcases from TCT tests added in
https://review.tizen.org/gerrit/#/c/test/tct/web/api/+/199159/
that used to fail due to the described bugs now pass.
tct-messaging-sms-tizen-tests pass rate: 100%
This commit has already been reviewed:
https://review.tizen.org/gerrit/#/c/platform/core/api/webapi-plugins/+/200662/
Change-Id of the original change was:
Ia6c2074408e8f4fadd10605d6986b5a2d2d4c93b
Change-Id: I6d28a8d153a34cf54084dae5585cbd7d0e771e4a
Signed-off-by: Pawel Wasowski <p.wasowski2@samsung.com>
Piotr Kosko [Fri, 18 Oct 2019 11:37:12 +0000 (11:37 +0000)]
Merge "[messaging][bugfix] Don't convert filter's matchValue to String" into tizen
Pawel Wasowski [Wed, 27 Feb 2019 16:06:45 +0000 (17:06 +0100)]
[messaging][bugfix] Don't convert filter's matchValue to String
Due to a conversion of matchValue to String, filters with boolean
matchValues did not match objects.
[Verification] All subtest cases, dealing with boolean attributes,
introduced in TCT in commit
https://review.tizen.org/gerrit/#/c/test/tct/web/api/+/199159/
passed.
This commit has already been reviewed:
https://review.tizen.org/gerrit/#/c/platform/core/api/webapi-plugins/+/200661/
Change-Id of the original change was:
I72fc83328e92529455460469c5dbc1aadc6ce07e
Signed-off-by: Pawel Wasowski <p.wasowski2@samsung.com>
Change-Id: Ia8d769b1a9694defdcb403761cff9c2565f5f52b
Piotr Kosko [Fri, 18 Oct 2019 11:32:39 +0000 (11:32 +0000)]
Merge "[mediacontroller][fix] fix small issues" into tizen
Dawid Juszczak [Wed, 16 Oct 2019 09:37:11 +0000 (11:37 +0200)]
[mediacontroller][fix] fix small issues
issues:
- startup state of server's repeat state was REPEAT_OFF,
should be REPEAT_ALL
- if client sent request to change attribute to
currently set value, callback was not invoked. Now
it is fixed.
- add repeatState to playbackInfo returned by
playbackInfo getter
[Verification]
tct-mediacontroller-tizen-tests 100% PASS
Change-Id: Iebdbf2ca3af1d395c2ba10753e0ef7efcdc11953
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
Dawid Juszczak [Thu, 17 Oct 2019 09:02:32 +0000 (11:02 +0200)]
[mediacontroller][5.5] fix method to update playback item
[ACR]
http://suprem.sec.samsung.net/jira/browse/TWDAPI-240
[description]
removed checking if playlist exists on device, because
some 3rd party application can get the playlist
from the 3rd party server(such as cloud) directly and we
don't have any information about its name and index
[verification]
MediaControllerServer_updatePlaybackItem_invalid.html - only
this testcase fails (from tct-mediacontroller-tizen-tests).
It needs to be changed/removed
Change-Id: I7809b662a2eb9b99af3690892133e85ed9b41865
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
Michal Michalski [Fri, 11 Oct 2019 09:15:08 +0000 (11:15 +0200)]
[mediacontroller] Autoformatting changes in mediacontroller.
Autoformatting of changes in mediacontroller.
Change-Id: I8e576444123cdc98766c41ae014073964757fc0e
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Michal Michalski [Wed, 9 Oct 2019 08:26:10 +0000 (10:26 +0200)]
[mediacontroller] SendEvent() js tests fixed + code autoformat.
+ Executed ./code_format script on mediacontroller source code.
+ Fixed invalid tests for MediaControllerClientInfo::sendEvent() method.
+ Fixed minor issues from earlier reviews.
+ initialized all JsonCallbacks to nullptr in constructors of MediaControllerClient/Server
[Verification] tests from test_custom_event.js 100% pass.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I9514897908e8221ed6f1c8eb1c1ed0083bad0996
[version] 2.53
Change-Id: I91b439ad78c3c11da5ed5622ce55d0e84a3253fb
Michal Michalski [Tue, 8 Oct 2019 15:10:04 +0000 (17:10 +0200)]
[utils][mediacontroller] SendEvent() method implementation.
[ACR] http://suprem.sec.samsung.net/jira/browse/TWDAPI-209
SendEvent()
SendReply()
[Verification] TCT: mediacontroller and deprecated API 100% pass.
New features tested in chrome console.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: If2230979c33f253fbd80171937ac64a8d90d4215
Michal Michalski [Tue, 8 Oct 2019 13:45:45 +0000 (15:45 +0200)]
[mediacontroller] Add UnsetCustomEventListener() method.
[ACR] http://suprem.sec.samsung.net/jira/browse/TWDAPI-209
MediaControllerClient::UnsetCustomEventListener() method implementation.
[Verification] Will be done later with SendEvent().
Change-Id: I7c92243b0abe211dfa11735a11dc29b1fa0496dd
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Michal Michalski [Tue, 8 Oct 2019 13:10:50 +0000 (15:10 +0200)]
[mediacontroller] Add MediaControllerClient::SetCustomEventListener()
[ACR] http://suprem.sec.samsung.net/jira/browse/TWDAPI-209
MediaControllerClient::SetCustomEventListener() method implementation.
[Verification] Will be verified later with SendEvent().
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: Id30be750edc940e331053c353dc0944ef7d2f18a
Michal Michalski [Tue, 8 Oct 2019 11:19:00 +0000 (13:19 +0200)]
[mediacontroller] Add MediaControllerClientInfo interface.
[ACR] http://suprem.sec.samsung.net/jira/browse/TWDAPI-209
+ MediaControllerClientInfo:
+ attribute name: string
MediaControllerServer:
+ getAllClientsInfo()
[Verification] Unit tests for MediaControllerClientInfo pass.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I321865c99059a21b02f6bdf9f48f9f001fbf2642
Michal Michalski [Tue, 8 Oct 2019 09:53:19 +0000 (11:53 +0200)]
[mediacontroller][ut] Custom events tests.
[ACR] http://suprem.sec.samsung.net/jira/browse/TWDAPI-209
Tests for custom events feature of media controller.
[Verification] none.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I5069f64fc9ff6514ebe830eec30c1777b99bdffe
Lukasz Bardeli [Thu, 3 Oct 2019 11:37:03 +0000 (13:37 +0200)]
[version] 2.52
Change-Id: Ic95f124aaf9c015dc6f17d528d88ab32d2ea14b6
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Dawid Juszczak [Wed, 2 Oct 2019 14:25:12 +0000 (16:25 +0200)]
[mediacontroller][fix] fix metadata issue
Problem was connected to PlaybackInfo.metadata.
It was throwing an error while null value was set as encoded attributes
like resolution, episode and season. Now it is fixed by checking if
value is null before decoding it.
[Verification]
tested manually on chrome console
tct-deprecatedapi-tizen-tests 100% PASS
tct-mediacontroller-tizen-tests 100% PASS
Change-Id: Ibc0f44591b75dd53348ff1db2900e3da581534a0
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
Piotr Kosko [Mon, 30 Sep 2019 14:03:03 +0000 (14:03 +0000)]
Merge "[fix][mediacontroller] fix error with new metadata features" into tizen
Dawid Juszczak [Mon, 30 Sep 2019 14:01:35 +0000 (16:01 +0200)]
[fix][mediacontroller] fix error with new metadata features
Change-Id: I957a41a84d1a8382c060ea615485c0c0f4d18602
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
Piotr Kosko [Mon, 30 Sep 2019 13:44:44 +0000 (13:44 +0000)]
Merge "[mediacontroller] add api for new metadata features" into tizen
Dawid Juszczak [Thu, 26 Sep 2019 14:23:22 +0000 (16:23 +0200)]
[mediacontroller] add api for new metadata features
[ACR]
http://suprem.sec.samsung.net/jira/browse/TWDAPI-238
[Verification]
tested manually on chrome console
tct-mediacontroller-tizen-tests 100% PASS
Change-Id: I459724bfa88ab9a37a97be55eda0bd2e01e83add
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
Piotr Kosko [Mon, 30 Sep 2019 10:46:50 +0000 (10:46 +0000)]
Merge changes I5e7e74fa,Icc3aa5bb into tizen
* changes:
[mediacontroller] Check for errors added.
[mediacontroller] Magic strings to constants.
Michal Michalski [Fri, 27 Sep 2019 10:48:45 +0000 (12:48 +0200)]
[mediacontroller] Check for errors added.
+ Result of native call to SendCommand was not checked for failure.
This commit adds this validation.
+ Added return after error occured in AddPlaybackInfoChangeList().
[Verification] All tests pass.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I5e7e74faa1c8902f35e45278c7c05778094867c4
Michal Michalski [Mon, 23 Sep 2019 13:35:42 +0000 (15:35 +0200)]
[mediacontroller] Magic strings to constants.
Keys of args passed from JS to instance methods were used
as inline strings, rather than constants.
[Verification] MediaController TCT tests
20190920 100% pass.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: Icc3aa5bb5bd947cf6bb680d15f4edc077901361b
Merge branch 'tizen_5.0' into tizen
Change-Id: I02a3c6d93c0924a0cf313110a3f79c4b67a7def8
Merge branch 'tizen_4.0' into tizen_5.0
Change-Id: I6307aead894899f049bacde9cb8af54febe91251
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: Iea1a8a0914572301a28c53d54bf64c795237ce44
[version] 2.35
Change-Id: Ifc5a4e534e395579031af9d3d115389b7545ab77
Rafal Walczyna [Fri, 27 Sep 2019 08:33:30 +0000 (10:33 +0200)]
[Filesystem] Source code auto-formatting
Used: ./code_format src/ -c -js
Change-Id: I1a27efa220445342ec42ef5327d06ac7bdd40ca9
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Szymon Jastrzebski [Fri, 12 Jan 2018 10:07:53 +0000 (11:07 +0100)]
[Archive] Fix for retrieving virtual roots
Current implmentation gets only internal virtual roots. This change adds
getting external roots as well.
[Verification] TCT Archive passed with 100% p.r.
Change-Id: Ia961dd276901ed31d42b22d93148d51066276163
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Rafal Walczyna [Tue, 24 Sep 2019 14:23:38 +0000 (16:23 +0200)]
[Filesystem] List of virtual roots for resolve function fixed.
Current implementation of virtual roots list did not include internal0 or
external memory i.e. SDCard or USBDrive. It results in not working resolve()
function, when location to resolve was on external memory.
Verification: TCT - 100 % pass.
Change-Id: I11c2537a7f5643f8c9ccfe2f45be9f3bce3edf00
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Dawid Juszczak [Mon, 23 Sep 2019 09:58:34 +0000 (11:58 +0200)]
[mediacontroller][fix] fixed error with subscribe method
before that commit, if subscribed method was executed
on already subscribed server then unknown error was thrown
Now it is fixed.
[verification]
tested manually on chrome console
Change-Id: I7d5fe3d0d09eb95d6542ebfb2e163ca32c5d01a0
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
[version] 2.50
Change-Id: I397c4edbc48cebaf72582a9a60d547256bcd6d6d
Lukasz Bardeli [Wed, 18 Sep 2019 10:17:51 +0000 (12:17 +0200)]
[mediacontroller] Add display rotation abilities
[ACR] http://suprem.sec.samsung.net/jira/browse/TWDAPI-234
[Verification]
tested manually on chrome console
Change-Id: I226a84bcb17757e900bfce64058180dec812af95
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Dawid Juszczak [Fri, 6 Sep 2019 11:18:46 +0000 (13:18 +0200)]
[mediacontroller] Add display mode abilities
[ACR]
http://suprem.sec.samsung.net/jira/browse/TWDAPI-233
[Verification]
tct-mediacontroller-tizen-tests 100% PASS
tested manually on chrome console
Change-Id: I816d97c38f0ce4fe2f894da1672b748a491cc913
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
Rafal Walczyna [Fri, 13 Sep 2019 13:23:21 +0000 (15:23 +0200)]
[Mediacontroller] added display rotation feature
[Verification] Code compiles without errors.
Basic test in chrome console works properly.
/// 1. adding command listener
var mcServer = tizen.mediacontroller.createServer();
mcServer.updatePlaybackState("PLAY");
var changeListener = function(clientName, rotation)
{
console.log("Display rotation change requested to: " + rotation + " by " + clientName);
return new tizen.mediacontroller.RequestReply(new tizen.Bundle({"message": "Success"}), 0);
};
watcherId = mcServer.displayRotation.addChangeRequestListener(changeListener);
/// 2. checking NotSupportedError when sending without enabled ability
var mcClient = tizen.mediacontroller.getClient();
var mcServerInfo = mcClient.getLatestServerInfo()
var rotation = "ROTATION_180";
mcServerInfo.displayRotation.sendRequest(rotation,
function(data, code)
{
console.log(
"Server replied with return data: " + JSON.stringify(data) + " and code: " + code);
});
/// 3. register listener for mode changes (client side)
watcherId = mcServerInfo.displayRotation.addDisplayRotationChangeListener(function(rotation)
{
console.log(mcServerInfo.name + " server display rotation changed to " + rotation);
});
/// 4. change the value of mode 360 (should trigger listener from point 3)
mcServer.displayRotation.displayRotation = "ROTATION_180"
/// 5. enable ability of server
// TODO: mcServer.abilities.displayRotation = "?"
/// sendRequest again (should trigger listener from point 1)
mcServerInfo.displayRotation.sendRequest(rotation,
function(data, code)
{
console.log(
"Server replied with return data: " + JSON.stringify(data) + " and code: " + code);
});
Change-Id: I9c497dbaaf5e7f491c2d57c568e52581c980951d
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
[Mediacontroller] added display mode feature
[ACR] http://suprem.sec.samsung.net/jira/browse/TWDAPI-231
[Verification] Code compiles without errors.
Basic test in chrome console works properly.
/// 1. adding command listener
var mcServer = tizen.mediacontroller.createServer();
mcServer.updatePlaybackState("PLAY");
var changeListener = function(type, clientName)
{
console.log("Display mode change requested to: " + type + " by " + clientName);
return new tizen.mediacontroller.RequestReply(new tizen.Bundle({"message": "Not allowed"}), 13);
};
watcherId = mcServer.displayMode.addChangeRequestListener(changeListener);
/// 2. checking NotSupportedError when sending without enabled ability
var mcClient = tizen.mediacontroller.getClient();
var mcServerInfo = mcClient.getLatestServerInfo()
var type = "ORIGIN_SIZE";
mcServerInfo.displayMode.sendRequest(type,
function(data, code)
{
console.log(
"Server replied with return data: " + JSON.stringify(data) + " and code: " + code);
},
function(e)
{
console.log("Error executing command: " + e.message);
});
/// 3. register listener for mode changes (client side)
watcherId = mcServerInfo.displayMode.addModeChangeListener(function(type)
{
console.log(mcServerInfo.name + " server display mode changed to " + type);
});
/// 4. change the value of display mode (should trigger listener from point 3)
mcServer.displayMode.type = "FULL_SCREEN"
/// 4. enable ability of server
// TODO support: mcServer.abilities.displayMode.originSize = "YES"
/// sendRequest again (should trigger listener from point 1)
mcServerInfo.displayMode.sendRequest(type,
function(data, code)
{
console.log(
"Server replied with return data: " + JSON.stringify(data) + " and code: " + code);
},
function(e)
{
console.log("Error executing command: " + e.message);
});
Change-Id: Icbc98513372d8da8e111a44d873c6559dede89e9
[Mediacontroller] added subtitles feature and related ability
[ACR] http://suprem.sec.samsung.net/jira/browse/TWDAPI-230
[Verification] Code compiles without errors.
Basic test in chrome console works properly.
/// 1. adding command listener
var mcServer = tizen.mediacontroller.createServer();
mcServer.updatePlaybackState("PLAY");
var changeListener = function(enabled, clientName)
{
console.log("Subtitles mode change requested to: " + enabled + " by " + clientName);
return new tizen.mediacontroller.RequestReply(new tizen.Bundle({"message": "Not allowed"}), 13);
};
watcherId = mcServer.subtitles.addChangeRequestListener(changeListener);
/// 2. checking NotSupportedError when sending without enabled ability
var mcClient = tizen.mediacontroller.getClient();
var mcServerInfo = mcClient.getLatestServerInfo()
var enabled = true;
mcServerInfo.subtitles.sendRequest(enabled,
function(data, code)
{
console.log(
"Server replied with return data: " + JSON.stringify(data) + " and code: " + code);
});
/// 3. register listener for mode changes (client side)
watcherId = mcServerInfo.subtitles.addModeChangeListener(function(status)
{
console.log(mcServerInfo.name + " server subtitles mode changed to " + status);
});
/// 4. change the value of subtitles (should trigger listener from point 3)
mcServer.subtitles.enabled = true
/// 5. enable ability of server
mcServer.abilities.subtitles = "YES"
/// sendRequest again (should trigger listener from point 1)
mcServerInfo.subtitles.sendRequest(enabled,
function(data, code)
{
console.log(
"Server replied with return data: " + JSON.stringify(data) + " and code: " + code);
});
/// 6. register ability change listener and trigger the update
var listener =
{
onsimpleabilitychanged: function(server, type, ability)
{
console.log(type + " ability changed, server name: " + server.name + ", ability: " + ability);
}
};
mcClient.addAbilityChangeListener(listener);
/// call updates to trigger listener
mcServer.abilities.subtitles = "NO"
mcServer.abilities.subtitles = "NO"
/// Listener should be triggered once
Change-Id: I00ad78a44b696a7d885d13499af77cf762e54c7e
Piotr Kosko [Thu, 19 Sep 2019 09:22:50 +0000 (09:22 +0000)]
Merge "[Tools] SAM script added" into tizen
Piotr Kosko [Thu, 19 Sep 2019 09:16:31 +0000 (09:16 +0000)]
Merge "[Mediacontroller] added mode 360 feature" into tizen
[Mediacontroller] added mode 360 feature
[ACR] http://suprem.sec.samsung.net/jira/browse/TWDAPI-229
[Verification] Code compiles without errors.
Basic test in chrome console works properly.
/// 1. adding command listener
var mcServer = tizen.mediacontroller.createServer();
mcServer.updatePlaybackState("PLAY");
var changeListener = function(enabled, clientName)
{
console.log("Spherical mode change requested to: " + enabled + " by " + clientName);
return new tizen.mediacontroller.RequestReply(new tizen.Bundle({"message": "Not allowed"}), 13);
};
watcherId = mcServer.mode360.addChangeRequestListener(changeListener);
/// 2. checking NotSupportedError when sending without enabled ability
var mcClient = tizen.mediacontroller.getClient();
var mcServerInfo = mcClient.getLatestServerInfo()
var enabled = true;
mcServerInfo.mode360.sendRequest(enabled,
function(data, code)
{
console.log(
"Server replied with return data: " + JSON.stringify(data) + " and code: " + code);
},
function(e)
{
console.log("Error executing command: " + e.message);
});
/// 3. register listener for mode changes (client side)
watcherId = mcServerInfo.mode360.addModeChangeListener(function(status)
{
console.log(mcServerInfo.name + " server spherical mode changed to " + status);
});
/// 4. change the value of mode 360 (should trigger listener from point 3)
mcServer.mode360.enabled = true
/// 5. enable ability of server
mcServer.abilities.mode360 = "YES"
/// sendRequest again (should trigger listener from point 1)
mcServerInfo.mode360.sendRequest(enabled,
function(data, code)
{
console.log(
"Server replied with return data: " + JSON.stringify(data) + " and code: " + code);
},
function(e)
{
console.log("Error executing command: " + e.message);
});
/// 6. register ability change listener and trigger the update
var listener =
{
onsimpleabilitychanged: function(server, type, ability)
{
console.log(type + " ability changed, server name: " + server.name + ", ability: " + ability);
}
};
mcClient.addAbilityChangeListener(listener);
/// call updates to trigger listener
mcServer.abilities.mode360 = "NO"
mcServer.abilities.mode360 = "NO"
/// Listener should be triggered once
Change-Id: I8170d56f6d5b18f053047d48d55e68d3ebbe7719
Piotr Kosko [Thu, 19 Sep 2019 08:36:57 +0000 (08:36 +0000)]
Merge "[download] Download module exception correction" into tizen
[Mediacontroller] Prepared templates for new features
This commit is prepared as a parent for several features introduced with
related native ACR http://suprem.sec.samsung.net/jira/browse/ACR-1444
Related ACRs:
http://suprem.sec.samsung.net/jira/browse/TWDAPI-229
http://suprem.sec.samsung.net/jira/browse/TWDAPI-230
http://suprem.sec.samsung.net/jira/browse/TWDAPI-231
http://suprem.sec.samsung.net/jira/browse/TWDAPI-232
Change-Id: Id23a4b53a5f9b9232224f942a2bde18940680abf
Piotr Kosko [Wed, 18 Sep 2019 09:00:24 +0000 (09:00 +0000)]
Merge "[mediacontroller] abilities and subscriptions" into tizen
Dawid Juszczak [Mon, 22 Jul 2019 15:17:19 +0000 (17:17 +0200)]
[mediacontroller] abilities and subscriptions
[ACR]
http://suprem.sec.samsung.net/jira/browse/TWDAPI-227
[Verification]
tested manually on chrome console
tct-mediacontroller-tizen-tests 100% PASS
Change-Id: I839c1f825e61caa828ad06d2c6b4a779ee3da320
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
Rafal Walczyna [Thu, 12 Sep 2019 10:53:26 +0000 (12:53 +0200)]
[build] Fix for incremental build
Some file were created and changed while using incremental build.
This commit makes these files invisible to git status.
Change-Id: Ic10286bc786f35644b4b9736f73ac788200a8c0b
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Rafal Walczyna [Fri, 23 Aug 2019 10:04:02 +0000 (12:04 +0200)]
[Tools] SAM script added
Added script for S/W Architecture Maturity checking
Change-Id: I87e1836e77197740935c4252699e3f4aee08f66e
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Arkadiusz Pietraszek [Wed, 22 May 2019 13:00:41 +0000 (15:00 +0200)]
[download] Download module exception correction
NotFoundError and TypeMismatchError exceptions removed from methods:
void cancel(long);
void pause(long);
void resume(long);
Change that enables resuming canceled or failed download job.
abandon() method added, to destroy download job, abandoned download can not be resumed.
ABANDONED state added to differentiate from CANCELED, which can be resumed.
[Verification] Download TCT pass rate is 100%.
New behaviour was tested manually from console.
ACR: http://suprem.sec.samsung.net/jira/browse/TWDAPI-222
Change-Id: I52f5e7fa1875f49354178b8979c92e0d20011bc2
Signed-off-by: Arkadiusz Pietraszek <a.pietraszek@partner.samsung.com>
Dawid Juszczak [Tue, 20 Aug 2019 14:19:05 +0000 (16:19 +0200)]
[fix][mediacontroller] add callIfPossible to listeners
This commit adds callIfPossible functions to listeners to
avoid calling not set callbacks.
Change-Id: I91b36177eac0286d644fd298d9ad253e3586badb
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
[Mediacontroller] Fixed issue with invalid name of enum
[Bug]
1. wrong value of enum NONE instead of NO_CATEGORY
2. invalid parsing of empty keyword, which caused crash
[Verification] Code compiles without errors.
Tested in chrome console with code:
var server = tizen.mediacontroller.createServer();
function searchRequestListener(clientName, request)
{
console.log("search command received");
return new tizen.mediacontroller.RequestReply(new tizen.Bundle({"key": "value"}), 5);
}
server.setSearchRequestListener(searchRequestListener);
server.updatePlaybackState("PLAY");
/* Client-side code */
var client = tizen.mediacontroller.getClient();
var sinfo = client.getLatestServerInfo();
var query = [
new tizen.mediacontroller.SearchFilter("MUSIC")
];
sinfo.sendSearchRequest(query, function(reply)
{
console.log("reply status: " + reply.code);
console.log("reply data: " + reply.data);
});
Change-Id: Ie522f07286bf4604fe43428b716d6d808abbea07
[version] 2.49
Change-Id: I87d61cdefe4c22a85147329cb14e698cee59308e
Michal Michalski [Tue, 13 Aug 2019 09:46:43 +0000 (11:46 +0200)]
[formatting] Code auto-formatting.
Executed ./code_format script on the repository to fix invalid formatting.
Change-Id: Ieb8d825c4525dedc740319a3729ffd54280fef71
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Piotr Kosko [Tue, 13 Aug 2019 09:21:14 +0000 (09:21 +0000)]
Merge "[mediacontroller] New implementation for sendCommand()," into tizen
Piotr Kosko [Tue, 13 Aug 2019 05:47:28 +0000 (05:47 +0000)]
Merge "Use bundle_init_byte_array instead of bundle_add_byte_array" into tizen
Hwankyu Jhun [Tue, 6 Aug 2019 23:14:26 +0000 (08:14 +0900)]
Use bundle_init_byte_array instead of bundle_add_byte_array
The bundle_add_byte_array function will be changed.
Requires:
- https://review.tizen.org/gerrit/#/c/platform/core/base/bundle/+/211570/
Change-Id: I1465f336564da1fe3081dc02e09637422849ca7e
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Michal Michalski [Wed, 31 Jul 2019 11:09:35 +0000 (13:09 +0200)]
[mediacontroller] New implementation for sendCommand(),
http://suprem.sec.samsung.net/jira/browse/TWDAPI-226
+ sendCommand() accepts both object and tizen.Bundle as data argument.
+ Command listener can now return both RequestReply object, tizen.Bundle and object.
[Verification] Tested with custom javascript test cases.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I357e5b398724bdfada48684fb5bbc8f11be52f20
Michal Michalski [Wed, 3 Apr 2019 10:49:20 +0000 (12:49 +0200)]
[mediacontroller][common][webapi-plugins.spec][tizen] Implementation for search API.
http://suprem.sec.samsung.net/jira/browse/TWDAPI-208
Implementation for search API.
[Verification] Manual API testing.
tct-mediacontroller-tizen-tests 100% pass
tct-messageport-tizen-tests 100% pass
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I47cb4b3234e212db77ed20c4f899f4b5bed2d662
Michal Michalski [Wed, 31 Jul 2019 11:00:36 +0000 (13:00 +0200)]
[tests][mediacontroller] tests for new sendCommand implementation.
This testcases define expected behavior of sendCommand() method
after implementation is changed.
[Verification] Tests are passing with working version of new implementation.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I5923e45bb0ddc2013b1fe81951a3966413a3e4b6
Michal Michalski [Mon, 22 Jul 2019 10:59:36 +0000 (12:59 +0200)]
[tizen][utils][mediacontroller] Rewrite js tests using mochajs.
JS tests for the implementation of search API.
Tests for mediacontroller search api and tizen.Bundle have
been rewritten using mochajs library.
[Verification] Tests pass.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I22d5b5bd518b709f8d4aa94149906439390b4e28
[version] 2.48
Change-Id: I7a5c9eb27b5c115f9c5c1b29c9720a9883b26408
[Alarm] Fixed the behaviour change introduced during SVACE issues fixing
[Bug] Issue was introduced in commit
1b4d5c8e8e760140c3e5c93e59ff23bde99f9862
https://review.tizen.org/gerrit/#/c/platform/core/api/webapi-plugins/+/207226/
Alarm TCT - 12 fails
[Verification] Alarm TCT after fix - 100% (tizen-unified_20190804.1_mobile-wayland-armv7l-tm1)
Change-Id: I343bf2d20d2f88f6d3ac37eb2631a0db395daecb
Piotr Kosko [Thu, 1 Aug 2019 10:03:07 +0000 (10:03 +0000)]
Merge "[tests][common][webapi-plugins.spec] Changed common unit tests files structure." into tizen
Michal Michalski [Tue, 30 Jul 2019 09:30:12 +0000 (11:30 +0200)]
[tests][common][webapi-plugins.spec] Changed common unit tests files structure.
New structure allows better modularization of unit tests.
[Verification] webapi_common_tests are built successfully and pass.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: Icad5cca7739716bde7c09092f4d1d73fca1972a0
Michal Michalski [Wed, 31 Jul 2019 10:56:48 +0000 (12:56 +0200)]
[utils][tests] Add mochajs and chaijs libraries sources.
They can be used to write tests for js code.
It is required to add them to the debugging application.
After you have application with this libraries, you can
than run tests from chrome snippets in remote debugger.
[Verification] I have tested this setup in my test application
and it seems to be working.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: Ide535ee8ce29b4a735351f2fb9cbde36cc7c935e
projects / platform / core / api / webapi-plugins.git / log