platform/upstream/VK-GL-CTS.git
7 years agoMap buffers for writing in atomic counter tests
Graeme Leese [Fri, 20 Jan 2017 13:44:51 +0000 (13:44 +0000)]
Map buffers for writing in atomic counter tests

These tests attempt to sort the values in the returned buffers in place,
so the buffers must be mapped for writing. See VK-GL-CTS issue: 39.

Components: OpenGL

Affects: KHR-GLES31.core.shader_atomic_counters.*

Change-Id: Icda40fe8d27c86ecd9912767c34ec81e7fa3a35a

7 years agoMake RGB16F/RGB32F not color-renderable in ES 3.2
Alexander Galazin [Thu, 19 Jan 2017 20:00:10 +0000 (21:00 +0100)]
Make RGB16F/RGB32F not color-renderable in ES 3.2

GL_RGB16F is color-renderable only if
GL_EXT_color_buffer_half_float is supported.

GL_RGB32F is color-renderable only if
GL_EXT_color_buffer_float is supported.

Affects: dEQP-GLES31.functional.fbo.color.texcubearray.rgb16f

VK-GL-CTS issue: 40

Components: AOSP

Change-Id: I2cf3eb7e8d5c361ac23a64128b0d27958dc48438

7 years agoUpdate README.md in response to feedback
Alexander Galazin [Thu, 19 Jan 2017 09:42:20 +0000 (10:42 +0100)]
Update README.md in response to feedback

- Add more details about GLCTS_GTF_TARGET
- Clarify that KC CTS is necessary only for conformance submissions
- Clarify that GTF builds and conformance runs must use matching
  API versions

Components: OpenGL

Change-Id: I76a015e66918cf074823e6ab139c140369f7a073

7 years agoUpdate zlib dependency to zlib 1.2.11
Alexander Galazin [Mon, 16 Jan 2017 08:15:59 +0000 (09:15 +0100)]
Update zlib dependency to zlib 1.2.11

Fixes Vulkan CTS issue: #579

Change-Id: Ib0cd05616cbb4759d63bcf15ba8e8f6f374e291d
(cherry picked from commit 1be44d17818bd119885ad24bd9665ab3db933834)

7 years agoUpdate GL CTS README to point to GitHub VK GL CTS wiki
Alexander Galazin [Fri, 13 Jan 2017 21:41:32 +0000 (22:41 +0100)]
Update GL CTS README to point to GitHub VK GL CTS wiki

Change-Id: Ia06ec8801cb840e25dbe6012de34ce38ffd79467
(cherry picked from commit 41833f93fa1a551affefa71a16fc73e7afdf2ef8)

7 years agoRun GTF EGL tests only in 'window' configs
Alexander Galazin [Wed, 11 Jan 2017 06:51:53 +0000 (07:51 +0100)]
Run GTF EGL tests only in 'window' configs

Fixes OSS CTS #40

Change-Id: I6967bb63fb58863bcf143a27c01e84ccf536ccf8

7 years agoCorrect expected error to INVALID_OPERATION
Weiwan Liu [Fri, 23 Dec 2016 00:25:19 +0000 (16:25 -0800)]
Correct expected error to INVALID_OPERATION

Correct error code per ES 3.2 spec:
"An INVALID_OPERATION error is generated if attachment is
COLOR_ATTACHMENTm where m is greater than or equal to the
value of MAX_COLOR_ATTACHMENTS."

Change-Id: I5ee47fbb5d1f099d62cee9e20fd8ae0b55d766b3

7 years agoES{2,3}: Clamp the x, y location of the viewport's bottom-left corner
Anuj Phogat [Fri, 30 Sep 2016 17:46:49 +0000 (10:46 -0700)]
ES{2,3}: Clamp the x, y location of the viewport's bottom-left corner

Affected tests:
dEQP-GLES2.functional.state_query.integers.viewport_getfloat
dEQP-GLES2.functional.state_query.integers.viewport_getinteger
dEQP-GLES3.functional.state_query.integers.viewport_getfloat
dEQP-GLES3.functional.state_query.integers.viewport_getinteger
dEQP-GLES3.functional.state_query.integers.viewport_getinteger64

Above CTS tests are not clamping the x, y location of the viewport's
bottom-left corner as recommended by ARB_viewport_array and
OES_viewport_array.
Tests later compare the clamped x, y values read back from the driver
with reference unclamped  x, y values resulting in to false failures.

From OES_viewport_array:
"The location of the viewport's bottom-left corner, given by (x,y), are
clamped to be within the implementation-dependent viewport bounds range.
The viewport bounds range [min, max] tuple may be determined by calling
GetFloatv with the symbolic constant VIEWPORT_BOUNDS_RANGE_OES"

Change-Id: I380e0d03291d3b4b8cbc698ff80624860b0f2f05
(cherry picked from commit 555ed53736072fc9b50993cbc0550a70902a0bf9)

7 years agoUpdate zlib and libpng dependencies
Maciej Jesionowski [Thu, 5 Jan 2017 10:21:40 +0000 (11:21 +0100)]
Update zlib and libpng dependencies

Fixes #568

Change-Id: I8ee890a2176bf6d42d3dd8b119b7263034127960
(cherry picked from commit 8744b7d393cbdba8a2c356e9d4e4d625b9468f9a)

7 years agoSmarter verification of configs to be tested for ES
Alexander Galazin [Fri, 16 Dec 2016 09:50:58 +0000 (10:50 +0100)]
Smarter verification of configs to be tested for ES

Change-Id: I153cdd317228574bece32b87525e20acb52e16ab

7 years agoMove GLES mustpass to external/openglcts/data/mustpass/gles
Alexander Galazin [Fri, 16 Dec 2016 07:39:34 +0000 (08:39 +0100)]
Move GLES mustpass to external/openglcts/data/mustpass/gles

Change-Id: I4d1ec0d32504adb59e513e3bec5445283fb530e9

7 years agoUpdate GL CTS README
Alexander Galazin [Thu, 15 Dec 2016 18:36:36 +0000 (19:36 +0100)]
Update GL CTS README

Passing Criteria
* Remove duplicate sub-item in item 4
* Replace spelled numbers with digits

Running the tests on Android
* Enumerate available acitivites

Creating a submission package
* Typos

Change-Id: I76afa20a257ef91357ca0ad0d135964d9fbf94ec

7 years agoReformatting glcViewportArrayTests.cpp
Alexander Galazin [Thu, 15 Dec 2016 16:49:17 +0000 (17:49 +0100)]
Reformatting glcViewportArrayTests.cpp

Change-Id: Ic5d6ca4dc5a0016592bb5fb492880c6cbb1ea037

7 years agoDocumentation updates in preparation for the new release.
Alexander Galazin [Mon, 12 Dec 2016 13:03:36 +0000 (14:03 +0100)]
Documentation updates in preparation for the new release.

README restructuring, more detailed process
of creating a submission package.

Change-Id: Ie20291d3dafdbffda990a010d7fe85a04f6571c3

7 years agoUpdates to submission verification script
Alexander Galazin [Wed, 14 Dec 2016 16:35:11 +0000 (17:35 +0100)]
Updates to submission verification script

Change-Id: I4c2a3c897ceeecdcac586fad022a34ca18041b0d

7 years agoDo not run against EGL_EXT_yuv_surface configs
james.glanville [Thu, 15 Dec 2016 09:49:12 +0000 (09:49 +0000)]
Do not run against EGL_EXT_yuv_surface configs

Change-Id: I95750b2318c00d7d47d23076ee812dc33ad6445f

7 years agoFix uninitialized char arrays in ProgramInterfaceQueryTests.
Shane del Solar [Fri, 11 Nov 2016 02:32:05 +0000 (18:32 -0800)]
Fix uninitialized char arrays in ProgramInterfaceQueryTests.

Replicated from OpenGL/CTS Merge Request 432.

This patch initializes all of the char arrays in
the ProgramInterfaceQueryTests in the OpenGL and OpenGL ES versions of
conformance. Since they are char arrays
we should initialize them to the null terminator.

The motivation here is to prevent the verification script from
encountering unparsable tokens in the qpa result files from conformance.

This patch fixesOpengGL OSS-CTS issue 4.

Change-Id: Ia95742db876520d911b91039402dee46bbc6ebfe

7 years agoAvoid double registering of dEQP modules on Android
Alexander Galazin [Wed, 14 Dec 2016 14:23:02 +0000 (15:23 +0100)]
Avoid double registering of dEQP modules on Android

Change-Id: I0a5fad29f1bb831f891cdae0459779f513c7d282

7 years agoMerge gerrit/vulkan-cts-1.0-dev into gerrit/opengl-cts-dev
Pyry Haulos [Thu, 15 Dec 2016 14:42:59 +0000 (06:42 -0800)]
Merge gerrit/vulkan-cts-1.0-dev into gerrit/opengl-cts-dev

Change-Id: I061ec26cc7b0e645a5c226659d051e7e12857d90

7 years agoMerge gerrit/vulkan-cts-1.0.2 into gerrit/vulkan-cts-1.0-dev
Pyry Haulos [Thu, 15 Dec 2016 14:42:56 +0000 (06:42 -0800)]
Merge gerrit/vulkan-cts-1.0.2 into gerrit/vulkan-cts-1.0-dev

Change-Id: I92ebeef47df62646fb9fd2743991c43cd8893bda

7 years agoAlloc callbacks: don't report a quality warning for pooled objects
Maciej Jesionowski [Wed, 7 Dec 2016 09:55:36 +0000 (10:55 +0100)]
Alloc callbacks: don't report a quality warning for pooled objects

Modified tests:
- dEQP-VK.api.object_management.alloc_callback_fail_multiple.descriptor_set
- dEQP-VK.api.object_management.alloc_callback_fail_multiple.command_buffer_primary
- dEQP-VK.api.object_management.alloc_callback_fail_multiple.command_buffer_secondary

Change-Id: I0daea167c4b0c1e0a00039286b85af8c02e410f5
(cherry picked from commit ca634a5ac0b5278736e012f43a59bb25a5234e6f)

7 years agoMerge gerrit/vulkan-cts-1.0-dev into gerrit/opengl-cts-dev
Pyry Haulos [Thu, 15 Dec 2016 14:14:31 +0000 (06:14 -0800)]
Merge gerrit/vulkan-cts-1.0-dev into gerrit/opengl-cts-dev

Change-Id: Idb21386b1b14b3a7302028f556da63bec86427ae

7 years agoMerge gerrit/vulkan-cts-1.0.2 into gerrit/vulkan-cts-1.0-dev
Pyry Haulos [Thu, 15 Dec 2016 14:14:28 +0000 (06:14 -0800)]
Merge gerrit/vulkan-cts-1.0.2 into gerrit/vulkan-cts-1.0-dev

Change-Id: If83e62fdad4430038ba6318b99997a128f2c6c30

7 years agoFix image memory barriers for depth/stencil formats
iostrows [Tue, 13 Dec 2016 10:34:22 +0000 (11:34 +0100)]
Fix image memory barriers for depth/stencil formats

Affected tests:
- dEQP-VK.api.copy_and_blit.image_to_image.all_formats.depth_stencil*

Fixes #562

Change-Id: I59a851d2748f7ae0c2b56fdcd879978de4755ddf

7 years agoSparse resources: create correct device interface
Maciej Jesionowski [Wed, 14 Dec 2016 13:44:19 +0000 (14:44 +0100)]
Sparse resources: create correct device interface

Make sure correct function pointers are used with the a VkDevice.
This should make no actual difference on most implementations.

Affected tests:
- dEQP-VK.sparse_resources.*

Change-Id: Id39cf318c4ae24b47135e1f27308985bd20a0009

7 years agoMerge gerrit/vulkan-cts-1.0-dev into gerrit/opengl-cts-dev
Pyry Haulos [Thu, 15 Dec 2016 13:55:34 +0000 (05:55 -0800)]
Merge gerrit/vulkan-cts-1.0-dev into gerrit/opengl-cts-dev

Change-Id: I76f3c7db1863fe3fe69a114ff835968bdc3ea6d1

7 years agoMerge gerrit/vulkan-cts-1.0.2 into gerrit/vulkan-cts-1.0-dev
Pyry Haulos [Thu, 15 Dec 2016 12:24:08 +0000 (04:24 -0800)]
Merge gerrit/vulkan-cts-1.0.2 into gerrit/vulkan-cts-1.0-dev

Change-Id: I3151d603fa37a323629d83d27b7b687d3fe3693e

7 years agoMerge gerrit/vulkan-cts-1.0.1 into gerrit/vulkan-cts-1.0.2
Pyry Haulos [Thu, 15 Dec 2016 12:24:03 +0000 (04:24 -0800)]
Merge gerrit/vulkan-cts-1.0.1 into gerrit/vulkan-cts-1.0.2

Change-Id: I5ee52225ed76297caba6ae717e897d7290c20684

7 years agoMerge gerrit/vulkan-cts-1.0.0 into gerrit/vulkan-cts-1.0.1
Pyry Haulos [Thu, 15 Dec 2016 12:24:01 +0000 (04:24 -0800)]
Merge gerrit/vulkan-cts-1.0.0 into gerrit/vulkan-cts-1.0.1

Change-Id: I82eb4eb290e5d85b44ac2f1f2efb1eb88aef062a

7 years agoAdd -Wno-delete-non-virtual-dtor to default cxxflags
Pyry Haulos [Thu, 15 Dec 2016 12:11:43 +0000 (14:11 +0200)]
Add -Wno-delete-non-virtual-dtor to default cxxflags

That warning generates some false negatives that are hard to work
around.

Change-Id: Ib451eca3af7bf2a6bfd24aa966f89496257b9f0d

7 years agoMerge gerrit/vulkan-cts-1.0.1 into gerrit/vulkan-cts-1.0.2
Pyry Haulos [Thu, 15 Dec 2016 12:02:11 +0000 (04:02 -0800)]
Merge gerrit/vulkan-cts-1.0.1 into gerrit/vulkan-cts-1.0.2

7 years agoMerge gerrit/vulkan-cts-1.0.0 into gerrit/vulkan-cts-1.0.1
Pyry Haulos [Thu, 15 Dec 2016 12:01:22 +0000 (04:01 -0800)]
Merge gerrit/vulkan-cts-1.0.0 into gerrit/vulkan-cts-1.0.1

7 years agoSynchronization: use the correct device interface
Maciej Jesionowski [Wed, 14 Dec 2016 10:42:03 +0000 (11:42 +0100)]
Synchronization: use the correct device interface

This is a correctness change, likely has no impact
on most implementations.

Affected tests:
- dEQP-VK.synchronization.op.multi_queue.*

Change-Id: Ic2687f60c1ef2c468908c6c7240205b9e77e944c

7 years agoSynchronization: use the correct device interface
Maciej Jesionowski [Wed, 14 Dec 2016 10:42:03 +0000 (11:42 +0100)]
Synchronization: use the correct device interface

This is a correctness change, likely has no impact
on most implementations.

Affected tests:
- dEQP-VK.synchronization.op.multi_queue.*

Change-Id: I3eee09c13626e23261a7d0496aacab259265c3b9

7 years agoadd the viewport_array.* tests
Daniel Koch [Sat, 10 Dec 2016 20:12:28 +0000 (15:12 -0500)]
add the viewport_array.* tests

to the KHR-GLES32.core and KHR-GLESEXT test groups.
This adds the following 16 tests which can all be run with the
KHR-GLESEXT.viewport_array.* or KHR-GLES31.core.viewport_array.*
wildcards:

viewport_array.api_errors
viewport_array.queries
viewport_array.viewport_api
viewport_array.scissor_api
viewport_array.depth_range_api
viewport_array.scissor_test_state_api
viewport_array.draw_to_single_layer_with_multiple_viewports
viewport_array.dynamic_viewport_index
viewport_array.draw_mulitple_viewports_with_single_invocation
viewport_array.draw_multiple_layers
viewport_array.scissor
viewport_array.scissor_zero_dimension
viewport_array.scissor_clear
viewport_array.depth_range
viewport_array.depth_range_depth_test
viewport_array.provoking_vertex

Change-Id: I864cd57b70900db7ec6712919e7282960ccc0686

7 years agoReformatting with clang-format
Alexander Galazin [Thu, 15 Dec 2016 07:42:24 +0000 (08:42 +0100)]
Reformatting with clang-format

Change-Id: Ibdec4cf1cbb77f9d48787bcbbc770d9cf789f2c8

7 years agoUpdate viewport array tests to work in GLES
Daniel Koch [Mon, 12 Dec 2016 14:23:23 +0000 (09:23 -0500)]
Update viewport array tests to work in GLES

- Use shader specialization to enable the correct extensions and version.
- add supported functionality check to all tests
- Use runtime selection to determine Core vs ES functionality
  - use readpixels from a fbo attached texture in ES instead of getTexImage
  - disable provoking vertex calls for ES, and just assume LAST_CONVENTION
  - skip the subroutine tests in ES
  - Use templatized helper functions and an overloaded DepthFuncWrapper class
    to select the appropriate version of depth functionality as GL depth
    functions use GLdouble data types and ES uses GLfloat data types.

Change-Id: I9b37213acbdf41b93447741cfa097bb734ed4099

7 years agoes31: complete check for rgba32f internalformat
Alejandro Piñeiro [Wed, 23 Nov 2016 21:28:06 +0000 (19:28 -0200)]
es31: complete check for rgba32f internalformat

Right now several tests check for the extension
EXT_color_texture_buffer to know if that internalformat is
supported. But at this moment that internalformat is also supported on
core profiles, or if ARB_color_texture_buffer is available.

Note that it is not possible to just add a check for
ARB_color_texture_buffer. On core profiles, most of the functionality
got included on the spec, but deprecating some of the enums. As an
outcome, some drivers decide to not expose the extension, even if the
internalformat and other functionality is exposed.

For more info, take a look to the following commits on mesa:
3264c3e99700389f0a3958db7c9c19673107d67a
bd850cb4f2c77e2eb6716c865c40b9976633fc23

This commit gets 72 tests going from skipped to pass on
Intel Skylake and Broadwell:
GL45-CTS.sample_variables.mask.rgba32f.*
GL45-CTS.shader_multisample_interpolation.render.*.rgba32f.*

Also move es31cSampleVariableTests and es31cShaderMultisampleInterpolationTests
to common.

Tests defined on those files are used on both GLES and GL test case lists,
so it makes sense to move them to the common module.

Change-Id: I0ed09e9897f9f2a1b4efd1a40c22da00ec70bfdc

7 years agoSkip non-testable float EGLconfigs exposed via EGL_EXT_pixel_format_float
Weiwan Liu [Thu, 1 Dec 2016 22:05:30 +0000 (14:05 -0800)]
Skip non-testable float EGLconfigs exposed via EGL_EXT_pixel_format_float

OpenGL CTS issue #13

Change-Id: I6e68b03df7e823dfcba56e19c55b4618d0e41589

7 years agoAdd viewport_array support to glcts::TestCaseBase
Daniel Koch [Sat, 10 Dec 2016 22:13:09 +0000 (17:13 -0500)]
Add viewport_array support to glcts::TestCaseBase

Detect viewport_array functionality for GL 4.1 core (or later)
and for OES_viewport_array extension in ES.
Streamline code for detection of other extensions.
Add support for specialization of viewport_array shader functionality.

Change-Id: Ie07186163cfcc94988a1d83e91897812b27e59ae

7 years agoFix existing viewport_array bugs
Daniel Koch [Mon, 12 Dec 2016 07:34:26 +0000 (02:34 -0500)]
Fix existing viewport_array bugs

- was querying viewport instead of scissor box
- was requiring upper viewport bounds range of 32768

(these were pointed out by jputsman in previous review)

Affects tests: *.viewport_array.queries

Change-Id: I1914fd51cad1870ba91ef3380088aa20757ce29d

7 years agoRemove unused utility functions from ViewportArray
Daniel Koch [Sat, 10 Dec 2016 21:23:35 +0000 (16:23 -0500)]
Remove unused utility functions from ViewportArray

Change-Id: I8525051e3eb1b5518def586d4d8a3b620ee3346b

7 years agoRebase ViewportArray classes and add extParams
Daniel Koch [Sat, 10 Dec 2016 20:47:41 +0000 (15:47 -0500)]
Rebase ViewportArray classes and add extParams

Rebase the ViewportArray classes onto TestCaseBase (which supports shader specialization)
and add the extParams so that we know which type of functionality to test and can
specialize different versions of shaders.

Change-Id: I38f07580a2ee71957565a2a7f93f97fcf3073bdf

7 years agoMove Viewport array tests from gl/ to common/
Daniel Koch [Fri, 9 Dec 2016 22:23:12 +0000 (17:23 -0500)]
Move Viewport array tests from gl/ to common/

Move gl/gl4cViewportArrayTests.* to common/glcViewportArrayTests.*
Adjust relevant makefiles, namespaces, and include guards.
No other code changes were made.

Change-Id: I2d0245717cd2c507025ba256b48c7ad545e483f1

7 years agoEnable GL_OES_viewport_array in GL generation scripts
Daniel Koch [Sun, 11 Dec 2016 21:30:19 +0000 (16:30 -0500)]
Enable GL_OES_viewport_array in GL generation scripts

The actual change was in scripts/opengl/src_util.py
everything else was auto-generated.

Change-Id: Id9a18188f0e3f0d4eb7c6495adc50b6ae439582a

7 years agoGet rid of invalid buffer create flags combinations
Maciej Jesionowski [Mon, 12 Dec 2016 15:24:30 +0000 (16:24 +0100)]
Get rid of invalid buffer create flags combinations

Removed tests:
- dEQP-VK.api.buffer.createBuffer_*_2
- dEQP-VK.api.buffer.createBuffer_*_6

(cherry picked from commit bdd0a62ee565d0e7e07f05ddb95217d532e407cb)

Change-Id: I6cc6ed365de9d710f07fbfd2dde9db7edaecd007

7 years agoAdd explicit OS to some configs
Alexander Galazin [Tue, 13 Dec 2016 15:21:21 +0000 (16:21 +0100)]
Add explicit OS to some configs

Change-Id: I9176062420f3dd122456f9cf73c5e2aa12df5ec5

7 years agoGet rid of invalid buffer create flags combinations
Maciej Jesionowski [Mon, 12 Dec 2016 15:24:30 +0000 (16:24 +0100)]
Get rid of invalid buffer create flags combinations

Removed tests:
- dEQP-VK.api.buffer.createBuffer_*_2
- dEQP-VK.api.buffer.createBuffer_*_6

(cherry picked from commit bdd0a62ee565d0e7e07f05ddb95217d532e407cb)

Change-Id: I6cc6ed365de9d710f07fbfd2dde9db7edaecd007

7 years agoMove common submission verification functions to scripts/verify
Alexander Galazin [Mon, 12 Dec 2016 14:59:42 +0000 (15:59 +0100)]
Move common submission verification functions to scripts/verify

VulkanCTS submission verification functionality will be
signifcantly reused by OpenGL CTS.
It's nice to have commonly used functions in one place.

Change-Id: I61cd83556c6f961b50d1c27953dd57614c4f417a

7 years agoGet rid of invalid buffer create flags combinations
Maciej Jesionowski [Mon, 12 Dec 2016 15:24:30 +0000 (16:24 +0100)]
Get rid of invalid buffer create flags combinations

Removed tests:
- dEQP-VK.api.buffer.createBuffer_*_2
- dEQP-VK.api.buffer.createBuffer_*_6

Change-Id: I6cc6ed365de9d710f07fbfd2dde9db7edaecd007

7 years agoMerge "direct-state-access/texture-tests: Use a type compatible with the format"...
Alexander Galazin [Mon, 12 Dec 2016 12:54:01 +0000 (07:54 -0500)]
Merge "direct-state-access/texture-tests: Use a type compatible with the format" into opengl-cts-dev

7 years agoMerge "esextcTessellationShaderXFB: use individual out varyings instead of trying...
Alexander Galazin [Mon, 12 Dec 2016 12:53:33 +0000 (07:53 -0500)]
Merge "esextcTessellationShaderXFB: use individual out varyings instead of trying to get the array" into opengl-cts-dev

7 years agoesextcTessellationShaderXFB: use individual out varyings instead of trying to get...
Alejandro Piñeiro [Thu, 24 Nov 2016 17:17:35 +0000 (15:17 -0200)]
esextcTessellationShaderXFB: use individual out varyings instead of trying to get the array

Fixes:
GL45-CTS.tessellation_shader.single.xfb_captures_data_from_correct_stage

The test has a tessellation shader with a out varying like this:
          "out BLOCK_INOUT { vec4 value; } user_out[];\n"

The test uses transform feedback to get the content of user_out.

But the test is trying to use BLOCK_INOUT.value, instead of the
individual (4 in this case) elements of the array.

Additionally, this commit adds an OUT_PER_VERTEX_TCS_DECL, needed
as the out gl_PerVertex on tessellation control shaders is slightly
different compared with other stages.

From the GLSL 4.40 spec, page 123 (page 129 on the pdf):

   "In the tessellation control language, built-in variables are
    intrinsically declared as:

    <skip>
    out gl_PerVertex {
        vec4 gl_Position;
        float gl_PointSize;
        float gl_ClipDistance[];
    } gl_out[];"

Change-Id: I185aa456c4a802d71650b710d939bd749793942b

7 years agoMerge branch 'wip/apinheiro/memory-barriers' into 'master'
Alejandro Piñeiro [Tue, 22 Nov 2016 14:13:23 +0000 (12:13 -0200)]
Merge branch 'wip/apinheiro/memory-barriers' into 'master'

    Extra memory barriers needed on different tests

    We found several tests to consistently fail or to be flaky (not always failing/passing) on Intel Skylake GT2 model. Those get solved adding memory barriers. Those memory barriers are convenient as could prevent the tests failing on other hw.

    The branch includes 4 new commits, to make easier the review, but I think that they can be squashed without problems.

    See merge request !108

Change-Id: I4ec91df6c1d8721eee18f9aa0223d3c5ba6465ef

7 years agodirect-state-access/texture-tests: Use a type compatible with the format
Eduardo Lima Mitev [Wed, 23 Nov 2016 15:05:08 +0000 (16:05 +0100)]
direct-state-access/texture-tests: Use a type compatible with the format

One of the test sub-cases in ImageQueryErrorsTest family of tests is using
an incompatible format/type, when it is just checking for format and
internal-format compatibility. This is adding another failure point to the
test, making it dependent of the order of validation of the arguments in
the OpenGL driver.

Specifically, the sub-case that checks that "format is DEPTH_STENCIL and the
base internal format is not DEPTH_STENCIL" is passing GL_DEPTH_STENCIL with
type GL_UNSIGNED_INT, which would fail with INVALID_ENUM:

From OpenGL 4.5, section '18.2 Reading Pixels', page 506 of the PDF states:

    "An INVALID_ENUM error is generated if format is DEPTH_STENCIL and
     type is not UNSIGNED_INT_24_8 or FLOAT_32_UNSIGNED_INT_24_8_REV."

This is for ReadPixels, but the same pixel storage modes apply for
GetTextureImage:

From OpenGL 4.5, section '8.11 Texture Queries', page 234 of the PDF states:

    "Pixel storage modes that are applicable to ReadPixels are applied, as
     described in table 18.1 and section 18.2.9."

This patch changes the type to GL_UNSIGNED_INT_24_8, which is compatible with
the format, and will allow the subcase to unambiguosly fail if format and
internal-format are incompatible.

Change-Id: I979e007aef6e09b1707605bf4b94aebaa2d21b1c

7 years agoFix protocol auto-detection for ssh
Daniel Koch [Fri, 9 Dec 2016 21:38:50 +0000 (16:38 -0500)]
Fix protocol auto-detection for ssh

oss-cts issue 21

Change-Id: Id0bf39fc6d9eb64ef9415e5101a9a8bd042848aa

7 years agoMerge "Update KC CTS ref" into opengl-cts-dev
Alexander Galazin [Sun, 11 Dec 2016 18:35:53 +0000 (13:35 -0500)]
Merge "Update KC CTS ref" into opengl-cts-dev

7 years agoMerge gerrit/vulkan-cts-1.0-dev into gerrit/opengl-cts-dev
Pyry Haulos [Sat, 10 Dec 2016 18:40:12 +0000 (10:40 -0800)]
Merge gerrit/vulkan-cts-1.0-dev into gerrit/opengl-cts-dev

Change-Id: I4d2ef04a4c3bb44a40888cc859d9288f8b4949ef

7 years agoMerge gerrit/vulkan-cts-1.0.2 into gerrit/vulkan-cts-1.0-dev
Pyry Haulos [Sat, 10 Dec 2016 18:39:38 +0000 (10:39 -0800)]
Merge gerrit/vulkan-cts-1.0.2 into gerrit/vulkan-cts-1.0-dev

Change-Id: Ic0f43c179a3d81f5d3046b6945051d07ed86691a

7 years agoUpdate synchronization multi queue extended tests
Arkadiusz Sarwa [Thu, 6 Oct 2016 13:30:03 +0000 (15:30 +0200)]
Update synchronization multi queue extended tests

Tests now use all available queue families.

Updated tests:
- dEQP-VK.synchronization.op.multi_queue.*

Fixes #499

Change-Id: I7ec4cedc16e61addd07b85768c68410b7777bfcc

7 years agoUpdate KC CTS ref
Alexander Galazin [Sat, 10 Dec 2016 05:13:57 +0000 (06:13 +0100)]
Update KC CTS ref

Change-Id: I7f89aeac28209274c5f4d95bb99d669d50f05ef6

7 years agoMerge "Make KC CTS checkout protocol selectable." into opengl-cts-dev
Alexander Galazin [Fri, 9 Dec 2016 20:03:12 +0000 (15:03 -0500)]
Merge "Make KC CTS checkout protocol selectable." into opengl-cts-dev

7 years agoMerge gerrit/vulkan-cts-1.0-dev into gerrit/opengl-cts-dev
Pyry Haulos [Fri, 9 Dec 2016 19:22:21 +0000 (11:22 -0800)]
Merge gerrit/vulkan-cts-1.0-dev into gerrit/opengl-cts-dev

Change-Id: Id52aef66f13e1c37f331c3459ae7224bffafc5c9

7 years agoMerge gerrit/vulkan-cts-1.0.2 into gerrit/vulkan-cts-1.0-dev
Pyry Haulos [Fri, 9 Dec 2016 19:22:18 +0000 (11:22 -0800)]
Merge gerrit/vulkan-cts-1.0.2 into gerrit/vulkan-cts-1.0-dev

Change-Id: Id9582382bc20ce7bddeffef15884532be99364ef

7 years agoMerge gerrit/vulkan-cts-1.0.1 into gerrit/vulkan-cts-1.0.2
Pyry Haulos [Fri, 9 Dec 2016 19:21:40 +0000 (11:21 -0800)]
Merge gerrit/vulkan-cts-1.0.1 into gerrit/vulkan-cts-1.0.2

Change-Id: I3ac10a34c6169dccad99dc99346f178470c26056

7 years agoMake KC CTS checkout protocol selectable.
Alexander Galazin [Thu, 8 Dec 2016 08:34:17 +0000 (09:34 +0100)]
Make KC CTS checkout protocol selectable.

The script will use the parent repo protocol by default.
SSH or HTPPS can be explicitly request from the command line.

Allowed alternatives:
* python external/fetch_kc_cts.py - checkout via parent repo protocol.
* python external/fetch_kc_cts.py --protocol=ssh - checkout via SSH.
* python external/fetch_kc_cts.py --protocol=https - checkout via HTTPS.

Fixes OpenGL OSS-CTS issue #21

Change-Id: Ie30bfc08abb0ddbfa4e381c261e18f9758d36950

7 years agoUse mipmapPrecisionBits when calculating LOD error
Maciej Jesionowski [Wed, 7 Dec 2016 12:37:15 +0000 (13:37 +0100)]
Use mipmapPrecisionBits when calculating LOD error

Affected tests:
- dEQP-VK.pipeline.image.sampling_type.*
- dEQP-VK.pipeline.image_view.view_type.*
- dEQP-VK.pipeline.sampler.view_type.*

Khronos issue: #554

Change-Id: I7cb3bedd8df6b033dd6e7ae2d1631e5e2f25673e

7 years agoCorrect a typo in if statement in synchronization module
Maciej Jesionowski [Fri, 9 Dec 2016 17:05:54 +0000 (18:05 +0100)]
Correct a typo in if statement in synchronization module

Change-Id: I13635c1c078456adb6af8e8689d809d7ef72ebb4

7 years agoMerge "Use 'default' instead of 'null' in some examples" into opengl-cts-dev
Alexander Galazin [Fri, 9 Dec 2016 16:07:16 +0000 (11:07 -0500)]
Merge "Use 'default' instead of 'null' in some examples" into opengl-cts-dev

7 years agoUse 'default' instead of 'null' in some examples
Alexander Galazin [Fri, 9 Dec 2016 09:12:53 +0000 (10:12 +0100)]
Use 'default' instead of 'null' in some examples

Change-Id: Ia819d7696fc23ddf4066eb48b5a5a53fabfb38b2

7 years agoMerge gerrit/vulkan-cts-1.0-dev into gerrit/opengl-cts-dev
Pyry Haulos [Thu, 8 Dec 2016 19:56:26 +0000 (11:56 -0800)]
Merge gerrit/vulkan-cts-1.0-dev into gerrit/opengl-cts-dev

Change-Id: Ic004e8f199538e1d22dded2b41b62f44d1e47e39

7 years agoMerge gerrit/vulkan-cts-1.0.2 into gerrit/vulkan-cts-1.0-dev
Pyry Haulos [Thu, 8 Dec 2016 19:56:23 +0000 (11:56 -0800)]
Merge gerrit/vulkan-cts-1.0.2 into gerrit/vulkan-cts-1.0-dev

Change-Id: I6acdd3808c3f911f9c343a026fbf147c5559ce40

7 years agoMerge gerrit/vulkan-cts-1.0.1 into gerrit/vulkan-cts-1.0.2
Pyry Haulos [Thu, 8 Dec 2016 19:56:21 +0000 (11:56 -0800)]
Merge gerrit/vulkan-cts-1.0.1 into gerrit/vulkan-cts-1.0.2

Change-Id: Id05a662016ed60805a17dc96614967db899e095e

7 years agoMerge gerrit/vulkan-cts-1.0-dev into gerrit/opengl-cts-dev
Pyry Haulos [Thu, 8 Dec 2016 19:19:25 +0000 (11:19 -0800)]
Merge gerrit/vulkan-cts-1.0-dev into gerrit/opengl-cts-dev

Change-Id: I2385941b94be82955fb39482abece33d7f90798e

7 years agoMerge gerrit/vulkan-cts-1.0.1 into gerrit/vulkan-cts-1.0-dev
Pyry Haulos [Thu, 8 Dec 2016 19:19:05 +0000 (11:19 -0800)]
Merge gerrit/vulkan-cts-1.0.1 into gerrit/vulkan-cts-1.0-dev

Change-Id: Id4737fe97bb1880757a443e0ad97d0edbc9a1546

7 years agoRemove CMAKE Compiler settings from GL CTS build mustpass script
Alexander Galazin [Thu, 8 Dec 2016 14:31:12 +0000 (15:31 +0100)]
Remove CMAKE Compiler settings from GL CTS build mustpass script

Change-Id: I08bff386b40f8643388a888d5af5aab115c9cdb2

7 years agoAlloc callbacks: don't report a quality warning for pooled objects
Maciej Jesionowski [Wed, 7 Dec 2016 09:55:36 +0000 (10:55 +0100)]
Alloc callbacks: don't report a quality warning for pooled objects

Modified tests:
- dEQP-VK.api.object_management.alloc_callback_fail_multiple.descriptor_set
- dEQP-VK.api.object_management.alloc_callback_fail_multiple.command_buffer_primary
- dEQP-VK.api.object_management.alloc_callback_fail_multiple.command_buffer_secondary

Change-Id: I0daea167c4b0c1e0a00039286b85af8c02e410f5

7 years agoUpdate the verification script to reflect git 2.9.1 changes
Alexander Galazin [Tue, 6 Dec 2016 20:54:57 +0000 (21:54 +0100)]
Update the verification script to reflect git 2.9.1 changes

git 2.9.1 changed the "working directory" message to "working
 tree". Accept both statements in the verification script.

Ref:
https://raw.githubusercontent.com/git/git/master/Documentation/RelNotes/2.9.1.txt

Fixes #559

Change-Id: Ie90097d39e1f09c1796bb1238ee92bf19aff93bf

7 years agoMerge "Update KC CTS reference" into opengl-cts-dev
Alexander Galazin [Tue, 6 Dec 2016 11:56:54 +0000 (06:56 -0500)]
Merge "Update KC CTS reference" into opengl-cts-dev

7 years agoUpdate KC CTS reference
Alexander Galazin [Tue, 6 Dec 2016 08:14:07 +0000 (09:14 +0100)]
Update KC CTS reference

Change-Id: I502ace8ea0a26595ce13101fe3a1b3140dba253e

7 years agoMerge "GL_ARB_gpu_shader_fp64: Forces UBOs to use the std140 layout" into opengl...
Alexander Galazin [Mon, 5 Dec 2016 09:53:47 +0000 (04:53 -0500)]
Merge "GL_ARB_gpu_shader_fp64: Forces UBOs to use the std140 layout" into opengl-cts-dev

7 years agoMerge "GL_ARB_shading_language_420pack: component names sets mix is forbidden" into...
Alexander Galazin [Mon, 5 Dec 2016 09:53:15 +0000 (04:53 -0500)]
Merge "GL_ARB_shading_language_420pack: component names sets mix is forbidden" into opengl-cts-dev

7 years agoGL_ARB_shading_language_420pack: component names sets mix is forbidden
Andres Gomez [Thu, 17 Nov 2016 15:57:00 +0000 (17:57 +0200)]
GL_ARB_shading_language_420pack: component names sets mix is forbidden

When refering to component names we can use xywz, rgba or stpq but not
mix them when refering to the components of a specific resulting vector
or scalar.

For example, this is illegal; float(1.5).xr, but this is legal;
float(1.5).xxxx.rgba.stpq.xywz

GL_ARB_shading_language_420pack doesn't explicitly forbid it but we can
find the following in the specs:

From The OpenGL® Shading Language 4.40, page 104:

  "  v4.xgba;   // is illegal - the component names do not come from
                                the same set."

Added another case for the following test:
    GL44-CTS.shading_language_420pack.scalar_swizzlers_invalid

Change-Id: I31889598ccf88850c44eeb0e267f43f2d89bbcf2

7 years agoGL_ARB_gpu_shader_fp64: Forces UBOs to use the std140 layout
Andres Gomez [Mon, 11 Jul 2016 20:24:53 +0000 (23:24 +0300)]
GL_ARB_gpu_shader_fp64: Forces UBOs to use the std140 layout

The max_uniform_components test for the FP64 extension was asuming
UBOs were stored in a tightly packed fashion. The way this is done is
implementation dependent; for example, mesa uses std140. The only way
of making any assumption on how an implementation is packing the data
for UBOs is, actually, by specifying the std140 layout.

Unfortunately, this also involves that the available used space for a
single UBO may be exhausted much before we get to use the maximum
uniform components. Hence, this patch also adds a check for
GL_MAX_UNIFORM_BLOCK_SIZE and limits the generated test to use the
amount of uniforms that fit in whichever limit gets exhausted first.

Fixes the following test (from fail to pass):
     GL44-CTS.gpu_shader_fp64.max_uniform_components

Change-Id: I734b090dbded4899e4db48c969754ab0a67c5245

7 years agoAdded CTS ARB_texture_filter_minmax specification proposal
Alexander Galazin [Mon, 5 Dec 2016 09:46:55 +0000 (10:46 +0100)]
Added CTS ARB_texture_filter_minmax specification proposal

Here is test specification proposal for ARB_texture_filter_minmax

See merge request !99

Change-Id: Ibb8d8f8506ab8dabd5dc00927b36f44697e1c174

7 years agoMerge "Documentation updates" into opengl-cts-dev
Alexander Galazin [Mon, 5 Dec 2016 09:41:51 +0000 (04:41 -0500)]
Merge "Documentation updates" into opengl-cts-dev

7 years agoDocumentation updates
Alexander Galazin [Fri, 2 Dec 2016 10:48:11 +0000 (11:48 +0100)]
Documentation updates

- Update README.md (typos, CTS folder structure, build instructions)
- Add CONTRIBUTING.md (moved Tips for developing new tests into this file)

Change-Id: Ia893e0cb6bc0cdd166a6f055e3951eac89788042

7 years agoRename OpenGL CTS mustpass folders.
Alexander Galazin [Mon, 5 Dec 2016 08:37:09 +0000 (09:37 +0100)]
Rename OpenGL CTS mustpass folders.

Remove explicit patch version

Change-Id: I19ae7039f8803ac668849ad9fdd5e708e40e20ce

7 years agoMerge "Reformat file with clang-format-4.0" into opengl-cts-dev
Alexander Galazin [Mon, 5 Dec 2016 08:12:23 +0000 (03:12 -0500)]
Merge "Reformat file with clang-format-4.0" into opengl-cts-dev

7 years agoMerge gerrit/vulkan-cts-1.0-dev into gerrit/opengl-cts-dev
Pyry Haulos [Fri, 2 Dec 2016 23:51:20 +0000 (15:51 -0800)]
Merge gerrit/vulkan-cts-1.0-dev into gerrit/opengl-cts-dev

Change-Id: Ife68d86ffa96d9f9462565175e637e28c24989f6

7 years agoMerge gerrit/vulkan-cts-1.0.1 into gerrit/vulkan-cts-1.0-dev
Pyry Haulos [Fri, 2 Dec 2016 23:51:17 +0000 (15:51 -0800)]
Merge gerrit/vulkan-cts-1.0.1 into gerrit/vulkan-cts-1.0-dev

Change-Id: Ib54e6e75d11508c1ee4194ae90815666088c79d7

7 years agoMerge gerrit/vulkan-cts-1.0.0 into gerrit/vulkan-cts-1.0.1
Pyry Haulos [Fri, 2 Dec 2016 23:51:14 +0000 (15:51 -0800)]
Merge gerrit/vulkan-cts-1.0.0 into gerrit/vulkan-cts-1.0.1

Change-Id: I4f62b1e39978bea366e0b7e2f745b0f7a25a0f66

7 years agoMerge aosp/master into gerrit/vulkan-cts-1.0-dev
Pyry Haulos [Fri, 2 Dec 2016 23:48:21 +0000 (15:48 -0800)]
Merge aosp/master into gerrit/vulkan-cts-1.0-dev

Change-Id: Ic50054c78a4bb736f9fcfa2768968ea8bbc1bd41

7 years agoClarify --deqp-log-filename usage in README.md
Pyry Haulos [Fri, 2 Dec 2016 22:29:24 +0000 (14:29 -0800)]
Clarify --deqp-log-filename usage in README.md

Vulkan CTS issue: #525

Change-Id: Idb0f23cd13e548aaea21682ec02d89e52adee579

7 years agoMerge gerrit/vulkan-cts-1.0-dev into gerrit/opengl-cts-dev
Pyry Haulos [Fri, 2 Dec 2016 22:26:33 +0000 (14:26 -0800)]
Merge gerrit/vulkan-cts-1.0-dev into gerrit/opengl-cts-dev

Change-Id: I4a04b54b92d507303ccf09b20b1fd643fe13e134

7 years agoMerge gerrit/vulkan-cts-1.0.1 into gerrit/vulkan-cts-1.0-dev
Pyry Haulos [Fri, 2 Dec 2016 22:26:30 +0000 (14:26 -0800)]
Merge gerrit/vulkan-cts-1.0.1 into gerrit/vulkan-cts-1.0-dev

Change-Id: Ida8369e7d121c8282069fd3a70a64efb4490bddd

7 years agoFix VkPipelineLayout overwriting
Arkadiusz Sarwa [Tue, 29 Nov 2016 10:43:38 +0000 (11:43 +0100)]
Fix VkPipelineLayout overwriting

Fixes #527

Change-Id: Ia053e9ead201f62fc1310d07e7dafd76139ba173

7 years agoMerge gerrit/vulkan-cts-1.0-dev into aosp/master
Pyry Haulos [Fri, 2 Dec 2016 21:38:22 +0000 (13:38 -0800)]
Merge gerrit/vulkan-cts-1.0-dev into aosp/master

Change-Id: Ic9e43c0554d8976766507fab6916be6a037505a7

7 years agoAdd new files to Android.mk
Pyry Haulos [Fri, 2 Dec 2016 21:36:36 +0000 (13:36 -0800)]
Add new files to Android.mk

Change-Id: I75be28ac1a62e9ee3f797e8eb4adaffc75486826

7 years agoMerge gerrit/vulkan-cts-1.0-dev into gerrit/opengl-cts-dev
Pyry Haulos [Fri, 2 Dec 2016 19:45:59 +0000 (11:45 -0800)]
Merge gerrit/vulkan-cts-1.0-dev into gerrit/opengl-cts-dev

Change-Id: I3228680996ef34bbc824b4e38d26da0597ff22b7