platform/core/multimedia/libmm-fileinfo.git
2 years agoRemove unused 'dStatus' and code cleanup 50/281350/10 accepted/tizen/unified/20220922.114002
jiyong.min [Fri, 16 Sep 2022 00:21:18 +0000 (09:21 +0900)]
Remove unused 'dStatus' and code cleanup

Change-Id: I182c2004483825be92adaacddb0f4af9071dba47

2 years agoFix the wrong pointer typecast 95/281295/6
jiyong.min [Thu, 15 Sep 2022 08:24:15 +0000 (17:24 +0900)]
Fix the wrong pointer typecast

Change-Id: I3ff8561a7dcdf34fe2b45a27a7b07349b1a0971a

2 years agoModify incompability code in 64bit 91/281291/6
jiyong.min [Thu, 15 Sep 2022 08:03:35 +0000 (17:03 +0900)]
Modify incompability code in 64bit

In 64bit build, a pointer and a 32-bit integer should not mixed in union.
https://pvs-studio.com/en/blog/posts/cpp/a0004/ (7. Memsize types in unions)

Change-Id: I53646a6e56b2d187493ff7d46fc07c7f80ece676

2 years agoFix type mismatch 84/281284/4
jiyong.min [Thu, 15 Sep 2022 06:53:03 +0000 (15:53 +0900)]
Fix type mismatch

Change-Id: Ifcb49ce2401bd399c510f27288b69950ab410839

2 years agoFix coverity issue 49/279749/7 accepted/tizen/unified/20220819.122454 submit/tizen/20220818.080117
minje.ahn [Wed, 17 Aug 2022 06:53:03 +0000 (15:53 +0900)]
Fix coverity issue

1. Fixed PW.BRANCH_PAST_INITIALIZATION in mm_file_format_ffmpeg.c
2. Fixed CHECKED_RETURN related to g_strlcpy

Change-Id: Ibcdf56eb91b89de8409061a5677abfa8e3bedf72
Signed-off-by: minje.ahn <minje.ahn@samsung.com>
2 years agoRemove unnecessary parameters 30/279530/2 accepted/tizen/unified/20220816.130750 submit/tizen/20220812.021136
minje.ahn [Thu, 11 Aug 2022 02:36:22 +0000 (11:36 +0900)]
Remove unnecessary parameters

This package only needs metadata including duration.
Therefore, it is modified to ignore unnecessary information.

Change-Id: Ic84455b836f145e0c0c20bbb6fbdd21d331715ce
Signed-off-by: minje.ahn <minje.ahn@samsung.com>
2 years agoID3v2 tag parser refactoring 76/279476/5
minje.ahn [Wed, 10 Aug 2022 05:02:59 +0000 (14:02 +0900)]
ID3v2 tag parser refactoring

ID3v2.3, v2.4 tag parser refactoring to reduce code complexity.

Change-Id: I185c715cd45af9c6b725f2543595195a84c9ecde
Signed-off-by: minje.ahn <minje.ahn@samsung.com>
2 years agoChange to copy only the specified frame length 75/279475/2
minje.ahn [Wed, 10 Aug 2022 04:50:13 +0000 (13:50 +0900)]
Change to copy only the specified frame length

Change-Id: Ie75fe4eed6bb96f30ab6be549370526b68de7372
Signed-off-by: minje.ahn <minje.ahn@samsung.com>
2 years agoid3v2.2 parser refactoring 88/279388/3 accepted/tizen/unified/20220810.135844 submit/tizen/20220809.032739
minje.ahn [Mon, 8 Aug 2022 09:31:19 +0000 (18:31 +0900)]
id3v2.2 parser refactoring

Change-Id: I5164f6c654757bbc71c44d0f94212ac5948b3135
Signed-off-by: minje.ahn <minje.ahn@samsung.com>
2 years agoRemove unused tags 86/278786/7
minje.ahn [Tue, 26 Jul 2022 06:52:52 +0000 (15:52 +0900)]
Remove unused tags

Change-Id: Ib0e3b338e1d87e05c5b5d24c83966b915a4b4e57
Signed-off-by: minje.ahn <minje.ahn@samsung.com>
2 years agoImprove imelody related code 57/278757/14
minje.ahn [Tue, 26 Jul 2022 01:52:34 +0000 (10:52 +0900)]
Improve imelody related code

Modified to calculate the duration of imelody directly without converting it to midi format.

Change-Id: Id656ebebbeb4191fbe676b35346efc44b1f055f8
Signed-off-by: minje.ahn <minje.ahn@samsung.com>
2 years agoID3tag parser refactoring 52/278652/9
minje.ahn [Mon, 25 Jul 2022 00:00:11 +0000 (09:00 +0900)]
ID3tag parser refactoring

Change-Id: I19213dfb2b9421d2d271a65612ea81ac5d417389
Signed-off-by: minje.ahn <minje.ahn@samsung.com>
2 years agoImprove _get_first_good_video_frame complexity 44/278544/5
minje.ahn [Fri, 22 Jul 2022 00:07:21 +0000 (09:07 +0900)]
Improve _get_first_good_video_frame complexity

Change-Id: Ib6b0cf9337fe958a416b5703104557735679ed38
Signed-off-by: minje.ahn <minje.ahn@samsung.com>
2 years agoAdd static to global variable 92/278492/1
minje.ahn [Thu, 21 Jul 2022 06:19:23 +0000 (15:19 +0900)]
Add static to global variable

Change-Id: I969dcdaa59917b37b608e9e6fd37afbca71e5ac1
Signed-off-by: minje.ahn <minje.ahn@samsung.com>
2 years agoRemove unused parameter 78/278478/1
minje.ahn [Thu, 21 Jul 2022 05:16:34 +0000 (14:16 +0900)]
Remove unused parameter

Change-Id: Icaab9bc39b3efd7c54e535bdb61f1f1bc707ce13
Signed-off-by: minje.ahn <minje.ahn@samsung.com>
2 years agoreplace g_memdup() to g_memdup2() 90/267890/2 accepted/tizen/unified/20211222.230449 submit/tizen/20211212.233427
Jiyong Min [Mon, 13 Dec 2021 04:15:25 +0000 (13:15 +0900)]
replace g_memdup() to g_memdup2()

  - g_memdup() was removed in glib2

Change-Id: Ie7926df9ab37b70ba6ee7fafa7de865a8198e1bc

2 years agoreplace 'av_init_packet' to 'av_packet_alloc' 83/267783/5 accepted/tizen/unified/20211213.133601 submit/tizen/20211209.083747
Jiyong Min [Fri, 10 Dec 2021 00:17:07 +0000 (09:17 +0900)]
replace 'av_init_packet' to 'av_packet_alloc'

 - 'av_init_packet' function was deplicated since ffmpeg 4.4.1

Change-Id: If7a7aa1329b0ed95172eeb5fe080ed73e665b544

2 years agoincrease 'probesize' to 50000 15/267715/4 accepted/tizen/unified/20211210.115151 submit/tizen/20211209.083928
Jiyong Min [Thu, 9 Dec 2021 06:27:53 +0000 (15:27 +0900)]
increase 'probesize' to 50000

[Problem]
 - For '65265_VID_H264_HP_1280P_120fps_MP3_48kHz_2ch.mpg' and '65270_VID_H264_HP_1920P_120fps_MP3_48kHz_2ch.mpg',
   libmm-fileinfo can't get the stream information such as width, height.

[Cause]
 - The reduced 'probesize' affects the number of packets.
   So a few packets are detected and they don't have stream information.

[Solution]
 - We increase 'probesize' to 50000.
  It can get the stream information for these contents.
  Also it does not occur crash for the previous tested contents([8K]Frame-Counter Video8K_50FPS_10sec.mp4).

Change-Id: I205f599d5e5e747b16cb4dedb3c66ee6ed182f58

2 years agoreduced 'probesize' to 10000 with getting configurable values from ini 46/266746/6 accepted/tizen/unified/20211123.015910 submit/tizen/20211122.073257
Jiyong Min [Thu, 18 Nov 2021 06:29:15 +0000 (15:29 +0900)]
reduced 'probesize' to 10000 with getting configurable values from ini

[Problem]
 - 'media-scanner' was killed by 'stability-mnonitor' on TV.

[Cause]
 - 'media-scanner' still use a lot of memory usage for few 8k contents.

[Solution]
 - reduced 'probesize' to get stream information in ffmpeg
  'probesize' is a breakthrough in reducing memory usage
  because it affects the number of packets and decoding buffers.

Change-Id: I73887dc617b7774bb265d992d67bea58e91a99a4

3 years agoAdd to limit 'probesize' for getting stream information. 77/266177/7 accepted/tizen/unified/20211115.141625 submit/tizen/20211112.015536
Jiyong Min [Tue, 9 Nov 2021 02:40:16 +0000 (11:40 +0900)]
Add to limit 'probesize' for getting stream information.

[Problem]
Crash occurred for 8k contents due to mem-usage limitation on TV.
[Cause]
After getting stream information, 'ffmpeg' decode frames to probe it.
Decoding 8k video need lots of memory. About 33MB is used for each video frame.
[Solution]
Prevent probing stream information by 'probesize' limitation.

- The 'analyzeduration' and 'probesize' options affect the accuracy of stream information.
 If it could not find some parameters for stream info, we consider increasing the values.

Change-Id: Ice2917732ce6148597a7cb6cc7186e0ac06a0b05

3 years agoFix heap buffer overflow 12/255012/3 accepted/tizen/6.5/unified/20211028.115620 accepted/tizen/unified/20210316.151432 submit/tizen/20210312.013632 submit/tizen_6.5/20211028.162401 tizen_6.5.m2_release
Minje Ahn [Thu, 11 Mar 2021 08:21:30 +0000 (17:21 +0900)]
Fix heap buffer overflow

Change-Id: I3fb0f4762c979a54f2d990f3696c4f66f2383383
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
3 years agofix an integer underflow due to unsigned subtraction 00/253700/5 accepted/tizen/unified/20210219.041142 submit/tizen/20210218.011240
jiyong.min [Tue, 16 Feb 2021 23:36:50 +0000 (08:36 +0900)]
fix an integer underflow due to unsigned subtraction

 - An integer underflow may occur due to unsigned subtraction.
   Unsigned subtraction was changed to the comparison between
    'purelyFramelen' and 'encodingOffSet'.

Change-Id: I6973c56ce1d143e297aac9040ff2238e8af93574

3 years agofix potential crash issue due to sws_scale() 37/251337/6 accepted/tizen/unified/20210115.004550 submit/tizen/20210114.023654
jiyong.min [Wed, 13 Jan 2021 00:13:12 +0000 (09:13 +0900)]
fix potential crash issue due to sws_scale()

 - av_malloc() align size and allocate memory for different architecture.
   and sws_scale() use memory without checking.
   so if we use g_malloc(), sws_scale() make crash sometimes.
   we should allocate memory with av_malloc() before using sws_scale().

 - ref. https://trac.ffmpeg.org/ticket/5886/

Change-Id: I893578f2c82ed881de1bbcb92595a3e57d5e3c1e

3 years agoVersion up (1.0.2 -> 1.0.3) 59/251059/1 accepted/tizen/unified/20210108.125919 submit/tizen/20210107.083906
Minje Ahn [Thu, 7 Jan 2021 08:15:22 +0000 (17:15 +0900)]
Version up (1.0.2 -> 1.0.3)

Change-Id: I52bcb069cfe1c144a7f48b1dbd0e425e411dbbd0
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
3 years agoImprove initializers readability 29/251029/3
Minje Ahn [Thu, 7 Jan 2021 04:31:39 +0000 (13:31 +0900)]
Improve initializers readability

Change-Id: I75baae1a7c1e0dde981cb2462ce5857d1c1f2092
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
3 years agoMerge get_mime_type into get_format 26/251026/4
Minje Ahn [Thu, 7 Jan 2021 04:10:40 +0000 (13:10 +0900)]
Merge get_mime_type into get_format

Change-Id: I268030db389d9410c3cab7a09be65ac9814c7fe7
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
3 years agoAdd missing mime type:matroska(mkv), quicktime(mov) 24/251024/3
Minje Ahn [Thu, 7 Jan 2021 03:52:27 +0000 (12:52 +0900)]
Add missing mime type:matroska(mkv), quicktime(mov)

Change-Id: If5406dcd89e682a25f60474e5aa8a08d39c5bbc8
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
3 years agoRemove CP932 from locale_map 13/251013/2
Minje Ahn [Thu, 7 Jan 2021 00:53:28 +0000 (09:53 +0900)]
Remove CP932 from locale_map

Change-Id: If641746f60ead7e45688d68e782d6d792eabe792
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
3 years agoRemove unused code 11/251011/1
Minje Ahn [Wed, 6 Jan 2021 23:39:00 +0000 (08:39 +0900)]
Remove unused code

Change-Id: I94a193c001f961c4f200af3d67541f8b42ecbaee
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
3 years agoSeparate album art extraction 12/248712/4 accepted/tizen/unified/20201209.124852 submit/tizen/20201208.235402
Minje Ahn [Tue, 1 Dec 2020 23:12:18 +0000 (08:12 +0900)]
Separate album art extraction

Changed to extract album art only on request.

Change-Id: I0ad6da0da25905535d5aec94ec74a3069d0d0e11
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
3 years agoBug fix of wrong video frame rate with FFmpeg 82/247882/8 accepted/tizen/unified/20201208.043851 submit/tizen/20201208.031841
hj kim [Wed, 18 Nov 2020 04:24:43 +0000 (13:24 +0900)]
Bug fix of wrong video frame rate with FFmpeg

Change-Id: Iff3f19a062aedad56a4c28bf9ac2036cf792ae1e

3 years agoFix build errors after applying FFmpeg 85/246485/14
hj kim [Fri, 30 Oct 2020 02:52:56 +0000 (11:52 +0900)]
Fix build errors after applying FFmpeg

multimedia library has been changed from libav(12.3) to FFmpeg(4.3.1)

Change-Id: I642115a30e4848b7205e02df6ab2794fcc2296d7

3 years agoRemove size limit for album art extraction 01/248301/2 accepted/tizen/unified/20201126.022722 submit/tizen/20201125.073424
Minje Ahn [Wed, 25 Nov 2020 06:46:59 +0000 (15:46 +0900)]
Remove size limit for album art extraction

Modified to extract regardless of the size of album art.

Change-Id: I80aafd3d528d1a36b8a9dcdf5d7dc44c4241b106
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
3 years agoRemove useless codes 81/247881/3 accepted/tizen/unified/20201120.125415 submit/tizen/20201120.020306
hj kim [Wed, 18 Nov 2020 03:59:12 +0000 (12:59 +0900)]
Remove useless codes

Change-Id: I493ca9a5784d1fe65acdc6dc176b0ffe70308479

3 years agoAAC: Optimize to read tag size only instead of whole file 91/247991/3
Minje Ahn [Thu, 19 Nov 2020 04:37:12 +0000 (13:37 +0900)]
AAC: Optimize to read tag size only instead of whole file

Change-Id: Ic6ad54bd501efdc7700e6cc0ef1d235d06ef8e97
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
3 years agoRemove unreachable code 82/247982/2
Minje Ahn [Thu, 19 Nov 2020 04:27:19 +0000 (13:27 +0900)]
Remove unreachable code

Remove the unreachable code when parsing the ID3v1 tag in AAC format.

Change-Id: I556cd6950f71bff6e57222775ae61a31f2d0e45e
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
3 years agoRemove duplicated line 53/247953/2
Minje Ahn [Thu, 19 Nov 2020 00:43:16 +0000 (09:43 +0900)]
Remove duplicated line

Change-Id: I678236d7875bd2e27a620ea5a99114cdc0c86661
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoapply 'MM_VIDEO_CODEC_AV1' enum for AV1 codec 48/247448/4 accepted/tizen/unified/20201117.124135 submit/tizen/20201112.054726 submit/tizen/20201116.031718
jiyong.min [Wed, 11 Nov 2020 04:20:22 +0000 (13:20 +0900)]
apply 'MM_VIDEO_CODEC_AV1' enum for AV1 codec

Change-Id: I0f896299ff8f9e4179cb6ff0a9dcea837dbab61b

4 years agoAdd bulk test codes 28/246828/10 accepted/tizen/unified/20201111.124726 submit/tizen/20201110.072449
hj kim [Wed, 4 Nov 2020 09:58:15 +0000 (18:58 +0900)]
Add bulk test codes

Change-Id: I9204150e7603f84793911be42296e8be34d833ae

4 years agoAdd return value check in ID3v1 75/246875/7
Minje Ahn [Thu, 5 Nov 2020 00:47:54 +0000 (09:47 +0900)]
Add return value check in ID3v1

If there is no tag value, an empty string or space character is returned.
Modify function to ignore this case.

Change-Id: I357e1f825699e2cd8e271f0c90e8462758cb96f1
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoFix stream info extraction bug 74/246874/4
Minje Ahn [Thu, 5 Nov 2020 00:06:14 +0000 (09:06 +0900)]
Fix stream info extraction bug

'headerPos' can be 0 if there is no ID3v2 tag in the mp3 file.

Change-Id: Id9ca894bfc8d9fb21cb74972cc78c3691d03b25e
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agominor change. rename 'readed' to 'readn'
jiyong.min [Thu, 5 Nov 2020 07:06:14 +0000 (16:06 +0900)]
minor change. rename 'readed' to 'readn'

Change-Id: I2c43c769efb437ea29d97117900bd9405a1bcbd6

4 years agoFix 64bit build error 73/246673/3 submit/tizen/20201103.020205
Minje Ahn [Tue, 3 Nov 2020 03:50:42 +0000 (12:50 +0900)]
Fix 64bit build error

Change-Id: I116271cabe7832f108c1bba2032a24117c1c5a70
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoVersion up(0.6.92 -> 0.6.93) 30/246630/1
hj kim [Tue, 3 Nov 2020 01:30:01 +0000 (10:30 +0900)]
Version up(0.6.92 -> 0.6.93)

Change-Id: I546db3449f085a4636f5d67b99c922a43772d2d1

4 years agoImprove readability 07/246307/2
Minje Ahn [Wed, 28 Oct 2020 04:52:38 +0000 (13:52 +0900)]
Improve readability

Change-Id: Icac389e9ff1e124b593f6e6eb084f53aca8babcb
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoUpdated broken description 99/246299/7
Minje Ahn [Wed, 28 Oct 2020 00:13:18 +0000 (09:13 +0900)]
Updated broken description

Change-Id: Ic463609b934fdff600e0bc362221da6491b89486
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoImprove function to get stream info 95/246295/9
Minje Ahn [Wed, 28 Oct 2020 00:05:00 +0000 (09:05 +0900)]
Improve function to get stream info

The patch contents are as follows:
1. Instead of reading the first 50KB, it finds only normal header. (For reduce memory usage)
2. If the header information found is normal, it no longer searches for other headers.
3. Code optimization for readability.
4. Remove values that are no longer used.

Change-Id: Ic0be9eec1ba1902558be0a5150a00fd41bcbb924
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoImprove function to find ID3v2 last offset 93/246293/4
Minje Ahn [Tue, 27 Oct 2020 23:42:40 +0000 (08:42 +0900)]
Improve function to find ID3v2 last offset

Change-Id: I7303450a3783de29c813f3644ce9ccd15cadd1fe
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoChange to reuse buffer 25/246225/6
Minje Ahn [Tue, 27 Oct 2020 05:42:42 +0000 (14:42 +0900)]
Change to reuse buffer

Change-Id: Icc27818747b5fcb8ae707ab8151a3a8a1a76f9a5
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoMerge same logic 16/246216/3
Minje Ahn [Tue, 27 Oct 2020 04:11:35 +0000 (13:11 +0900)]
Merge same logic

Merge AV_ID3TAG_COMMENT and AV_ID3TAG_URL.

Change-Id: I5b2f8f9121846f096a4277c6cba8592e2e0b5f6b
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoUse g_list_free_full() instead 14/246214/2
Minje Ahn [Tue, 27 Oct 2020 04:05:18 +0000 (13:05 +0900)]
Use g_list_free_full() instead

Change-Id: Icc79163cef871034a2ee33579f61176f1de34e0c
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoUse g_ascii_isalnum() instead 13/246213/1
Minje Ahn [Tue, 27 Oct 2020 04:00:52 +0000 (13:00 +0900)]
Use g_ascii_isalnum() instead

Change-Id: I86b8361718448d8fec4eb292945400655c735632
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoRemove unused info 12/246212/1
Minje Ahn [Tue, 27 Oct 2020 03:51:40 +0000 (12:51 +0900)]
Remove unused info

This package does not use TOC(Table of Contents) information in MP3.

Change-Id: I3a3eef2ce9a34c2d134f53e4e8062038f1f475d1
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoSupport extracting stream information of AV1 97/245597/2 submit/tizen/20201013.060431
hj kim [Tue, 13 Oct 2020 02:46:26 +0000 (11:46 +0900)]
Support extracting stream information of AV1

and modify libav log level for debugging

Change-Id: Ifd2f2c13248880915f5b7ef75d09f68ca032455c

4 years agoFix .wav file header not found 17/245517/3 submit/tizen/20201012.053205
jiyong.min [Mon, 12 Oct 2020 01:57:16 +0000 (10:57 +0900)]
Fix .wav file header not found

 - Problem
  Metadata of wav files was not extracted
 - Cause
  The wav file header was not found because of incorrect condition
 - Solution
  The condition was modified to if_fail(readed == 4)

Change-Id: I42f20d6d478e3003da3b5f28489c3ad7f39b4907

4 years agoFix memory leak 66/244766/1 accepted/tizen_6.0_unified_hotfix tizen_6.0_hotfix accepted/tizen/6.0/unified/20201030.114425 accepted/tizen/6.0/unified/hotfix/20201103.002746 accepted/tizen/unified/20200925.140234 submit/tizen/20200924.055537 submit/tizen_6.0/20201029.205104 submit/tizen_6.0_hotfix/20201102.192504 submit/tizen_6.0_hotfix/20201103.114804 tizen_6.0.m2_release
jiyong.min [Thu, 24 Sep 2020 05:34:06 +0000 (14:34 +0900)]
Fix memory leak

Change-Id: I22152d538cb34358c5ca30285bc17ab3fc68324d

4 years agoFix coverity issue 45/244145/1 accepted/tizen/unified/20200918.123654 submit/tizen/20200916.012329 submit/tizen/20200917.011100 submit/tizen/20200917.223734
Minje Ahn [Tue, 15 Sep 2020 08:34:22 +0000 (17:34 +0900)]
Fix coverity issue

Change-Id: I5cd002b47ea317c7943cdafb94eb33c02598da17
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoFix a bug in mmfile_format_open_ffmpg() 10/240610/1 accepted/tizen/unified/20200811.050345 submit/tizen/20200810.055506
Minje Ahn [Mon, 10 Aug 2020 05:34:32 +0000 (14:34 +0900)]
Fix a bug in mmfile_format_open_ffmpg()

Fixed exception handling error.

Change-Id: I888604685c3de075a14077197f83d952dd7009db
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoBuffer 'VideoCodecTypeString' can overflow when index>28 09/239209/2 accepted/tizen/unified/20200724.124243 submit/tizen/20200722.015458
chengyj1985 [Wed, 22 Jul 2020 11:40:51 +0000 (19:40 +0800)]
Buffer 'VideoCodecTypeString' can overflow when index>28

Change-Id: Ifb8f0f6f468e3d66cb49391a9e883812c385a4e3

4 years agoBuffer 'gPi->TrackInfo' accessed by index 'sdTr' can overflow 09/237409/2 accepted/tizen/unified/20200702.141759 submit/tizen/20200701.023736
chengyj1985 [Tue, 30 Jun 2020 06:12:32 +0000 (14:12 +0800)]
Buffer 'gPi->TrackInfo' accessed by index 'sdTr' can overflow

Change-Id: I24dc045f8439c5ea64caadd327d3ba67f7a7d057

4 years agoFix 64bit build error 96/235096/2 accepted/tizen/unified/20200603.150226 submit/tizen/20200602.003220
Minje Ahn [Tue, 2 Jun 2020 06:23:53 +0000 (15:23 +0900)]
Fix 64bit build error

Change-Id: I5e814ccb609909785b9936455eade6fff21684aa
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoVersion up(0.6.88 -> 0.6.89) 28/235028/1
hj kim [Tue, 2 Jun 2020 00:26:28 +0000 (09:26 +0900)]
Version up(0.6.88 -> 0.6.89)

Change-Id: I67692b3954184afb5896860d8147f44376d531d1

4 years agoFix memory leak on failure 90/233490/2
Minje Ahn [Fri, 15 May 2020 04:53:00 +0000 (13:53 +0900)]
Fix memory leak on failure

Change-Id: I0812a2d3c5ba4fa09e90bd5b5bdb0d5e3feb6284
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoImprove validity function for MPEG-TS 04/234704/2
Minje Ahn [Thu, 28 May 2020 06:05:06 +0000 (15:05 +0900)]
Improve validity function for MPEG-TS

Change-Id: I076f59e39d966cbf6ed8cb326cf0cd863a3616e4
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoFormat validity related code cleanup 98/234698/2
Minje Ahn [Thu, 28 May 2020 05:23:11 +0000 (14:23 +0900)]
Format validity related code cleanup

Change-Id: I49beec2d64346b9ec0d04a0cfadd563a2c81e2fc
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoMerge the same macro 76/234376/3
Minje Ahn [Tue, 26 May 2020 02:15:44 +0000 (11:15 +0900)]
Merge the same macro

Change-Id: I400949e2b6a548b334cd3579ec9c995a32642c56
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoCode cleanup in mm_file_format_ffmpeg.c 53/234353/2
Minje Ahn [Tue, 26 May 2020 00:21:56 +0000 (09:21 +0900)]
Code cleanup in mm_file_format_ffmpeg.c

Change-Id: Ic722fe6e6d91f738edc9a9bdce3cfde33db5b7c8
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoFormat mp3 cleanup 22/234022/4
Minje Ahn [Thu, 21 May 2020 06:42:35 +0000 (15:42 +0900)]
Format mp3 cleanup

Change-Id: I200a97ef3434058a10097c13f51cd782ddaea2e2
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agotag related code cleanup 78/233878/6
Minje Ahn [Wed, 20 May 2020 04:18:11 +0000 (13:18 +0900)]
tag related code cleanup

Change-Id: Iacd82e62e9771abf872fb6fdb3448db238651e64
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoFrame related code cleanup 80/233480/3
Minje Ahn [Fri, 15 May 2020 04:11:33 +0000 (13:11 +0900)]
Frame related code cleanup

Change-Id: Ic9a410660cf7ae9a349b811ece339df23e7a5fc9
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoVersion up(0.6.87 -> 0.6.88) 93/234693/2 accepted/tizen/unified/20200529.124312 submit/tizen/20200528.061116
hj kim [Thu, 28 May 2020 04:49:20 +0000 (13:49 +0900)]
Version up(0.6.87 -> 0.6.88)

Change-Id: Iedbe0d4ef65d7bd5013c916dbf181b08c89a9ba5

4 years agoRemove unnecessary define 32/233332/4
Minje Ahn [Thu, 14 May 2020 02:51:47 +0000 (11:51 +0900)]
Remove unnecessary define

Change-Id: Ifbd4d89cfa0e14e29b4d5e688cd07834899195b1
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoformat IMELODY cleanup 22/233222/2
Minje Ahn [Wed, 13 May 2020 06:08:46 +0000 (15:08 +0900)]
format IMELODY cleanup

Change-Id: I581d81b7b4b7043adadbf9759535721ba39c4712
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoFormat MMF cleanup 82/232982/2
Minje Ahn [Mon, 11 May 2020 06:18:28 +0000 (15:18 +0900)]
Format MMF cleanup

Change-Id: I59f5636051b3c0606204e00859e0c7388c63e2c6
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoFormat MIDI cleanup 84/232884/3
Minje Ahn [Fri, 8 May 2020 06:26:23 +0000 (15:26 +0900)]
Format MIDI cleanup

Change-Id: I14f8bc26ebe25f94841e9b6fe9b444e89ba0b386
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoRemove unused files 28/232828/4
Minje Ahn [Fri, 8 May 2020 01:09:42 +0000 (10:09 +0900)]
Remove unused files

Change-Id: I2df45ccb64285f8fffac9543efdaa51adae37d11
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoFormat WAV cleanup 27/232827/2
Minje Ahn [Fri, 8 May 2020 00:40:20 +0000 (09:40 +0900)]
Format WAV cleanup

Change-Id: I9d22133e4dc7f49bb4cbc227cf56ab9132b35345
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoRemove test code for directory support 23/232823/1
Minje Ahn [Thu, 7 May 2020 23:26:17 +0000 (08:26 +0900)]
Remove test code for directory support

Change-Id: I176b6b188bacc38591a1c8ee7257d045eb13b87d
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoRemove memtrace 15/232715/1
Minje Ahn [Thu, 7 May 2020 08:20:52 +0000 (17:20 +0900)]
Remove memtrace

Change-Id: I674cc520cada75203dbdf58f3b2ab42e0d4f9bd5
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoRemove format dummy 03/232703/1
Minje Ahn [Thu, 7 May 2020 07:36:55 +0000 (16:36 +0900)]
Remove format dummy

Change-Id: I1105b369d120b12051091cfa74ce0e9c9963879e
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoFormat AMR cleanup 99/232699/1
Minje Ahn [Thu, 7 May 2020 07:27:42 +0000 (16:27 +0900)]
Format AMR cleanup

Change-Id: If3f3a99f621f9119a22ca7a05758708aaab8cd63
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoFormat AAC cleanup 58/232658/2
Minje Ahn [Thu, 7 May 2020 05:53:07 +0000 (14:53 +0900)]
Format AAC cleanup

Change-Id: I41aff76fbc3fe6232ced2a086c8cebd0688355ab
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoInternal functions cleanup 57/232657/2
Minje Ahn [Thu, 7 May 2020 05:51:18 +0000 (14:51 +0900)]
Internal functions cleanup

Change-Id: I6383006f55209ac298bbf6cffacba371a8d497ac
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoChange image buf type 00/232600/2
Minje Ahn [Thu, 7 May 2020 00:39:53 +0000 (09:39 +0900)]
Change image buf type

Change-Id: I0dcebf05e1517855785d6dc8f8f019844eb06657
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoRemove timestamp 39/232539/4
Minje Ahn [Wed, 6 May 2020 07:24:07 +0000 (16:24 +0900)]
Remove timestamp

Change-Id: I3c98f7da11f5a460333f3403e96d0dbfc5f37b15
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoRemove codec related code 03/232503/5
Minje Ahn [Wed, 6 May 2020 05:03:31 +0000 (14:03 +0900)]
Remove codec related code

'bCompressed' is false always.
So, codec related code are never called.

Change-Id: I014e6ee44e317d8fc575d2b750ba40b558a6a526
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoRemove EXPORT_API 79/232479/3
Minje Ahn [Wed, 6 May 2020 00:41:50 +0000 (09:41 +0900)]
Remove EXPORT_API

Change-Id: I9fcbab71b378ae58d2fa434dcffc3349c9bed8e6
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoImprove allocation related code 78/232478/3
Minje Ahn [Wed, 6 May 2020 00:24:09 +0000 (09:24 +0900)]
Improve allocation related code

Change-Id: I1c296b0d36420c47edf27ae232f4026b26f70292
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agofunction in mm_file_util_string cleanup 80/232380/2 submit/tizen/20200506.061601
Minje Ahn [Mon, 4 May 2020 01:44:10 +0000 (10:44 +0900)]
function in mm_file_util_string cleanup

Change-Id: I2e9fe3ad4113dec5feb2ec98f56157c8b8db0a25
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoChange return value 77/232377/2
Minje Ahn [Mon, 4 May 2020 01:06:10 +0000 (10:06 +0900)]
Change return value

Change-Id: If166672ee78e765b2b1831de1c3aa9f3ab4b9cd2
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoUse macro instead 89/232089/3
Minje Ahn [Tue, 28 Apr 2020 06:44:32 +0000 (15:44 +0900)]
Use macro instead

Change-Id: Icc7875387e0cd21eebca93b6b8ced1414e2c47e2
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoCheck file before dlopen 45/232045/4
Minje Ahn [Tue, 28 Apr 2020 01:22:32 +0000 (10:22 +0900)]
Check file before dlopen

Change-Id: Ie5691150dc0ee7bd76d138a417726ad20b1af307
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoRemove duplicated condition for checking the frame length 58/229858/2
jiyong.min [Mon, 6 Apr 2020 05:28:27 +0000 (14:28 +0900)]
Remove duplicated condition for checking the frame length

Change-Id: I1be9feb05291cbd12719d8b7fef6270caf35a88c

4 years agoFix crash issue due to garbage value 07/227307/1 accepted/tizen/unified/20200407.043020 submit/tizen/20200406.033132
jiyong.min [Wed, 11 Mar 2020 06:17:09 +0000 (15:17 +0900)]
Fix crash issue due to garbage value

  - If the result of g_convert() is empty string, the written_len is 0.
    Then (unsigned int)'written_len - 1' became garbage value and
    checking carriage return make crash.

(gdb)bt full
mmfile_string_convert ...mm_file_util_string.c:189
        i = 1395696
        result = 0xae45a410 ""
        err = 0x0
        written_len = 0

Change-Id: I61b4c3e4a6b938ce549844e163dc46f47398aa98

4 years agoUnify duplicated codes regarding getting file size 17/226117/7
hj kim [Thu, 27 Feb 2020 04:05:12 +0000 (13:05 +0900)]
Unify duplicated codes regarding getting file size

Change-Id: I357be69f82a03b9e8ac6d7ba94cc9341d40a4e0a

4 years agoUnify duplicate codes regarding content attribute 87/225987/3
hj kim [Wed, 26 Feb 2020 04:44:17 +0000 (13:44 +0900)]
Unify duplicate codes regarding content attribute

Change-Id: I9bc54faeb45eed7ea86275d5ceb990f61781b5fe

4 years agoFix typo 14/226014/2 submit/tizen/20200226.080940
hj kim [Wed, 26 Feb 2020 06:52:59 +0000 (15:52 +0900)]
Fix typo

Change-Id: Ifac06fd27ff239f23444b99fff7bef1407b71d10

4 years agoReplace return value to define instead of hardcoded number 47/224747/1
jiyong.min [Thu, 13 Feb 2020 00:10:30 +0000 (09:10 +0900)]
Replace return value to define instead of hardcoded number

Change-Id: Ia58d2d95a717fc962ef32f6e1c70698f60c35bb8

4 years agodefine enum for ID3tag to make codes simple 55/223855/26 accepted/tizen/unified/20200213.121600 submit/tizen/20200212.003832
hj kim [Tue, 4 Feb 2020 09:10:17 +0000 (18:10 +0900)]
define enum for ID3tag to make codes simple

Change-Id: If2ebbfd36565d8878ad0f11da1e18742db4373d6

4 years agoBump to 0.6.85 82/224182/1
jiyong.min [Fri, 7 Feb 2020 02:59:35 +0000 (11:59 +0900)]
Bump to 0.6.85

Change-Id: Ia88c259d3110e21eb206cadb5951af5f3bf0590e