Minje Ahn [Thu, 7 Jan 2021 04:31:39 +0000 (13:31 +0900)]
Improve initializers readability
Change-Id: I75baae1a7c1e0dde981cb2462ce5857d1c1f2092
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Minje Ahn [Thu, 7 Jan 2021 04:10:40 +0000 (13:10 +0900)]
Merge get_mime_type into get_format
Change-Id: I268030db389d9410c3cab7a09be65ac9814c7fe7
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Minje Ahn [Thu, 7 Jan 2021 03:52:27 +0000 (12:52 +0900)]
Add missing mime type:matroska(mkv), quicktime(mov)
Change-Id: If5406dcd89e682a25f60474e5aa8a08d39c5bbc8
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Minje Ahn [Thu, 7 Jan 2021 00:53:28 +0000 (09:53 +0900)]
Remove CP932 from locale_map
Change-Id: If641746f60ead7e45688d68e782d6d792eabe792
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Minje Ahn [Wed, 6 Jan 2021 23:39:00 +0000 (08:39 +0900)]
Remove unused code
Change-Id: I94a193c001f961c4f200af3d67541f8b42ecbaee
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Minje Ahn [Tue, 1 Dec 2020 23:12:18 +0000 (08:12 +0900)]
Separate album art extraction
Changed to extract album art only on request.
Change-Id: I0ad6da0da25905535d5aec94ec74a3069d0d0e11
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
hj kim [Wed, 18 Nov 2020 04:24:43 +0000 (13:24 +0900)]
Bug fix of wrong video frame rate with FFmpeg
Change-Id: Iff3f19a062aedad56a4c28bf9ac2036cf792ae1e
hj kim [Fri, 30 Oct 2020 02:52:56 +0000 (11:52 +0900)]
Fix build errors after applying FFmpeg
multimedia library has been changed from libav(12.3) to FFmpeg(4.3.1)
Change-Id: I642115a30e4848b7205e02df6ab2794fcc2296d7
Minje Ahn [Wed, 25 Nov 2020 06:46:59 +0000 (15:46 +0900)]
Remove size limit for album art extraction
Modified to extract regardless of the size of album art.
Change-Id: I80aafd3d528d1a36b8a9dcdf5d7dc44c4241b106
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
hj kim [Wed, 18 Nov 2020 03:59:12 +0000 (12:59 +0900)]
Remove useless codes
Change-Id: I493ca9a5784d1fe65acdc6dc176b0ffe70308479
Minje Ahn [Thu, 19 Nov 2020 04:37:12 +0000 (13:37 +0900)]
AAC: Optimize to read tag size only instead of whole file
Change-Id: Ic6ad54bd501efdc7700e6cc0ef1d235d06ef8e97
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Minje Ahn [Thu, 19 Nov 2020 04:27:19 +0000 (13:27 +0900)]
Remove unreachable code
Remove the unreachable code when parsing the ID3v1 tag in AAC format.
Change-Id: I556cd6950f71bff6e57222775ae61a31f2d0e45e
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Minje Ahn [Thu, 19 Nov 2020 00:43:16 +0000 (09:43 +0900)]
Remove duplicated line
Change-Id: I678236d7875bd2e27a620ea5a99114cdc0c86661
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
jiyong.min [Wed, 11 Nov 2020 04:20:22 +0000 (13:20 +0900)]
apply 'MM_VIDEO_CODEC_AV1' enum for AV1 codec
Change-Id: I0f896299ff8f9e4179cb6ff0a9dcea837dbab61b
hj kim [Wed, 4 Nov 2020 09:58:15 +0000 (18:58 +0900)]
Add bulk test codes
Change-Id: I9204150e7603f84793911be42296e8be34d833ae
Minje Ahn [Thu, 5 Nov 2020 00:47:54 +0000 (09:47 +0900)]
Add return value check in ID3v1
If there is no tag value, an empty string or space character is returned.
Modify function to ignore this case.
Change-Id: I357e1f825699e2cd8e271f0c90e8462758cb96f1
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Minje Ahn [Thu, 5 Nov 2020 00:06:14 +0000 (09:06 +0900)]
Fix stream info extraction bug
'headerPos' can be 0 if there is no ID3v2 tag in the mp3 file.
Change-Id: Id9ca894bfc8d9fb21cb74972cc78c3691d03b25e
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
jiyong.min [Thu, 5 Nov 2020 07:06:14 +0000 (16:06 +0900)]
minor change. rename 'readed' to 'readn'
Change-Id: I2c43c769efb437ea29d97117900bd9405a1bcbd6
Minje Ahn [Tue, 3 Nov 2020 03:50:42 +0000 (12:50 +0900)]
Fix 64bit build error
Change-Id: I116271cabe7832f108c1bba2032a24117c1c5a70
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
hj kim [Tue, 3 Nov 2020 01:30:01 +0000 (10:30 +0900)]
Version up(0.6.92 -> 0.6.93)
Change-Id: I546db3449f085a4636f5d67b99c922a43772d2d1
Minje Ahn [Wed, 28 Oct 2020 04:52:38 +0000 (13:52 +0900)]
Improve readability
Change-Id: Icac389e9ff1e124b593f6e6eb084f53aca8babcb
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Minje Ahn [Wed, 28 Oct 2020 00:13:18 +0000 (09:13 +0900)]
Updated broken description
Change-Id: Ic463609b934fdff600e0bc362221da6491b89486
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Minje Ahn [Wed, 28 Oct 2020 00:05:00 +0000 (09:05 +0900)]
Improve function to get stream info
The patch contents are as follows:
1. Instead of reading the first 50KB, it finds only normal header. (For reduce memory usage)
2. If the header information found is normal, it no longer searches for other headers.
3. Code optimization for readability.
4. Remove values that are no longer used.
Change-Id: Ic0be9eec1ba1902558be0a5150a00fd41bcbb924
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Minje Ahn [Tue, 27 Oct 2020 23:42:40 +0000 (08:42 +0900)]
Improve function to find ID3v2 last offset
Change-Id: I7303450a3783de29c813f3644ce9ccd15cadd1fe
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Minje Ahn [Tue, 27 Oct 2020 05:42:42 +0000 (14:42 +0900)]
Change to reuse buffer
Change-Id: Icc27818747b5fcb8ae707ab8151a3a8a1a76f9a5
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Minje Ahn [Tue, 27 Oct 2020 04:11:35 +0000 (13:11 +0900)]
Merge same logic
Merge AV_ID3TAG_COMMENT and AV_ID3TAG_URL.
Change-Id: I5b2f8f9121846f096a4277c6cba8592e2e0b5f6b
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Minje Ahn [Tue, 27 Oct 2020 04:05:18 +0000 (13:05 +0900)]
Use g_list_free_full() instead
Change-Id: Icc79163cef871034a2ee33579f61176f1de34e0c
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Minje Ahn [Tue, 27 Oct 2020 04:00:52 +0000 (13:00 +0900)]
Use g_ascii_isalnum() instead
Change-Id: I86b8361718448d8fec4eb292945400655c735632
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Minje Ahn [Tue, 27 Oct 2020 03:51:40 +0000 (12:51 +0900)]
Remove unused info
This package does not use TOC(Table of Contents) information in MP3.
Change-Id: I3a3eef2ce9a34c2d134f53e4e8062038f1f475d1
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
hj kim [Tue, 13 Oct 2020 02:46:26 +0000 (11:46 +0900)]
Support extracting stream information of AV1
and modify libav log level for debugging
Change-Id: Ifd2f2c13248880915f5b7ef75d09f68ca032455c
jiyong.min [Mon, 12 Oct 2020 01:57:16 +0000 (10:57 +0900)]
Fix .wav file header not found
- Problem
Metadata of wav files was not extracted
- Cause
The wav file header was not found because of incorrect condition
- Solution
The condition was modified to if_fail(readed == 4)
Change-Id: I42f20d6d478e3003da3b5f28489c3ad7f39b4907
jiyong.min [Thu, 24 Sep 2020 05:34:06 +0000 (14:34 +0900)]
Fix memory leak
Change-Id: I22152d538cb34358c5ca30285bc17ab3fc68324d
Minje Ahn [Tue, 15 Sep 2020 08:34:22 +0000 (17:34 +0900)]
Fix coverity issue
Change-Id: I5cd002b47ea317c7943cdafb94eb33c02598da17
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Minje Ahn [Mon, 10 Aug 2020 05:34:32 +0000 (14:34 +0900)]
Fix a bug in mmfile_format_open_ffmpg()
Fixed exception handling error.
Change-Id: I888604685c3de075a14077197f83d952dd7009db
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
chengyj1985 [Wed, 22 Jul 2020 11:40:51 +0000 (19:40 +0800)]
Buffer 'VideoCodecTypeString' can overflow when index>28
Change-Id: Ifb8f0f6f468e3d66cb49391a9e883812c385a4e3
chengyj1985 [Tue, 30 Jun 2020 06:12:32 +0000 (14:12 +0800)]
Buffer 'gPi->TrackInfo' accessed by index 'sdTr' can overflow
Change-Id: I24dc045f8439c5ea64caadd327d3ba67f7a7d057
Minje Ahn [Tue, 2 Jun 2020 06:23:53 +0000 (15:23 +0900)]
Fix 64bit build error
Change-Id: I5e814ccb609909785b9936455eade6fff21684aa
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
hj kim [Tue, 2 Jun 2020 00:26:28 +0000 (09:26 +0900)]
Version up(0.6.88 -> 0.6.89)
Change-Id: I67692b3954184afb5896860d8147f44376d531d1
Minje Ahn [Fri, 15 May 2020 04:53:00 +0000 (13:53 +0900)]
Fix memory leak on failure
Change-Id: I0812a2d3c5ba4fa09e90bd5b5bdb0d5e3feb6284
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Minje Ahn [Thu, 28 May 2020 06:05:06 +0000 (15:05 +0900)]
Improve validity function for MPEG-TS
Change-Id: I076f59e39d966cbf6ed8cb326cf0cd863a3616e4
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Minje Ahn [Thu, 28 May 2020 05:23:11 +0000 (14:23 +0900)]
Format validity related code cleanup
Change-Id: I49beec2d64346b9ec0d04a0cfadd563a2c81e2fc
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Minje Ahn [Tue, 26 May 2020 02:15:44 +0000 (11:15 +0900)]
Merge the same macro
Change-Id: I400949e2b6a548b334cd3579ec9c995a32642c56
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Minje Ahn [Tue, 26 May 2020 00:21:56 +0000 (09:21 +0900)]
Code cleanup in mm_file_format_ffmpeg.c
Change-Id: Ic722fe6e6d91f738edc9a9bdce3cfde33db5b7c8
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Minje Ahn [Thu, 21 May 2020 06:42:35 +0000 (15:42 +0900)]
Format mp3 cleanup
Change-Id: I200a97ef3434058a10097c13f51cd782ddaea2e2
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Minje Ahn [Wed, 20 May 2020 04:18:11 +0000 (13:18 +0900)]
tag related code cleanup
Change-Id: Iacd82e62e9771abf872fb6fdb3448db238651e64
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Minje Ahn [Fri, 15 May 2020 04:11:33 +0000 (13:11 +0900)]
Frame related code cleanup
Change-Id: Ic9a410660cf7ae9a349b811ece339df23e7a5fc9
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
hj kim [Thu, 28 May 2020 04:49:20 +0000 (13:49 +0900)]
Version up(0.6.87 -> 0.6.88)
Change-Id: Iedbe0d4ef65d7bd5013c916dbf181b08c89a9ba5
Minje Ahn [Thu, 14 May 2020 02:51:47 +0000 (11:51 +0900)]
Remove unnecessary define
Change-Id: Ifbd4d89cfa0e14e29b4d5e688cd07834899195b1
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Minje Ahn [Wed, 13 May 2020 06:08:46 +0000 (15:08 +0900)]
format IMELODY cleanup
Change-Id: I581d81b7b4b7043adadbf9759535721ba39c4712
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Minje Ahn [Mon, 11 May 2020 06:18:28 +0000 (15:18 +0900)]
Format MMF cleanup
Change-Id: I59f5636051b3c0606204e00859e0c7388c63e2c6
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Minje Ahn [Fri, 8 May 2020 06:26:23 +0000 (15:26 +0900)]
Format MIDI cleanup
Change-Id: I14f8bc26ebe25f94841e9b6fe9b444e89ba0b386
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Minje Ahn [Fri, 8 May 2020 01:09:42 +0000 (10:09 +0900)]
Remove unused files
Change-Id: I2df45ccb64285f8fffac9543efdaa51adae37d11
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Minje Ahn [Fri, 8 May 2020 00:40:20 +0000 (09:40 +0900)]
Format WAV cleanup
Change-Id: I9d22133e4dc7f49bb4cbc227cf56ab9132b35345
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Minje Ahn [Thu, 7 May 2020 23:26:17 +0000 (08:26 +0900)]
Remove test code for directory support
Change-Id: I176b6b188bacc38591a1c8ee7257d045eb13b87d
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Minje Ahn [Thu, 7 May 2020 08:20:52 +0000 (17:20 +0900)]
Remove memtrace
Change-Id: I674cc520cada75203dbdf58f3b2ab42e0d4f9bd5
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Minje Ahn [Thu, 7 May 2020 07:36:55 +0000 (16:36 +0900)]
Remove format dummy
Change-Id: I1105b369d120b12051091cfa74ce0e9c9963879e
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Minje Ahn [Thu, 7 May 2020 07:27:42 +0000 (16:27 +0900)]
Format AMR cleanup
Change-Id: If3f3a99f621f9119a22ca7a05758708aaab8cd63
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Minje Ahn [Thu, 7 May 2020 05:53:07 +0000 (14:53 +0900)]
Format AAC cleanup
Change-Id: I41aff76fbc3fe6232ced2a086c8cebd0688355ab
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Minje Ahn [Thu, 7 May 2020 05:51:18 +0000 (14:51 +0900)]
Internal functions cleanup
Change-Id: I6383006f55209ac298bbf6cffacba371a8d497ac
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Minje Ahn [Thu, 7 May 2020 00:39:53 +0000 (09:39 +0900)]
Change image buf type
Change-Id: I0dcebf05e1517855785d6dc8f8f019844eb06657
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Minje Ahn [Wed, 6 May 2020 07:24:07 +0000 (16:24 +0900)]
Remove timestamp
Change-Id: I3c98f7da11f5a460333f3403e96d0dbfc5f37b15
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Minje Ahn [Wed, 6 May 2020 05:03:31 +0000 (14:03 +0900)]
Remove codec related code
'bCompressed' is false always.
So, codec related code are never called.
Change-Id: I014e6ee44e317d8fc575d2b750ba40b558a6a526
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Minje Ahn [Wed, 6 May 2020 00:41:50 +0000 (09:41 +0900)]
Remove EXPORT_API
Change-Id: I9fcbab71b378ae58d2fa434dcffc3349c9bed8e6
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Minje Ahn [Wed, 6 May 2020 00:24:09 +0000 (09:24 +0900)]
Improve allocation related code
Change-Id: I1c296b0d36420c47edf27ae232f4026b26f70292
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Minje Ahn [Mon, 4 May 2020 01:44:10 +0000 (10:44 +0900)]
function in mm_file_util_string cleanup
Change-Id: I2e9fe3ad4113dec5feb2ec98f56157c8b8db0a25
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Minje Ahn [Mon, 4 May 2020 01:06:10 +0000 (10:06 +0900)]
Change return value
Change-Id: If166672ee78e765b2b1831de1c3aa9f3ab4b9cd2
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Minje Ahn [Tue, 28 Apr 2020 06:44:32 +0000 (15:44 +0900)]
Use macro instead
Change-Id: Icc7875387e0cd21eebca93b6b8ced1414e2c47e2
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Minje Ahn [Tue, 28 Apr 2020 01:22:32 +0000 (10:22 +0900)]
Check file before dlopen
Change-Id: Ie5691150dc0ee7bd76d138a417726ad20b1af307
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
jiyong.min [Mon, 6 Apr 2020 05:28:27 +0000 (14:28 +0900)]
Remove duplicated condition for checking the frame length
Change-Id: I1be9feb05291cbd12719d8b7fef6270caf35a88c
jiyong.min [Wed, 11 Mar 2020 06:17:09 +0000 (15:17 +0900)]
Fix crash issue due to garbage value
- If the result of g_convert() is empty string, the written_len is 0.
Then (unsigned int)'written_len - 1' became garbage value and
checking carriage return make crash.
(gdb)bt full
mmfile_string_convert ...mm_file_util_string.c:189
i = 1395696
result = 0xae45a410 ""
err = 0x0
written_len = 0
Change-Id: I61b4c3e4a6b938ce549844e163dc46f47398aa98
hj kim [Thu, 27 Feb 2020 04:05:12 +0000 (13:05 +0900)]
Unify duplicated codes regarding getting file size
Change-Id: I357be69f82a03b9e8ac6d7ba94cc9341d40a4e0a
hj kim [Wed, 26 Feb 2020 04:44:17 +0000 (13:44 +0900)]
Unify duplicate codes regarding content attribute
Change-Id: I9bc54faeb45eed7ea86275d5ceb990f61781b5fe
hj kim [Wed, 26 Feb 2020 06:52:59 +0000 (15:52 +0900)]
Fix typo
Change-Id: Ifac06fd27ff239f23444b99fff7bef1407b71d10
jiyong.min [Thu, 13 Feb 2020 00:10:30 +0000 (09:10 +0900)]
Replace return value to define instead of hardcoded number
Change-Id: Ia58d2d95a717fc962ef32f6e1c70698f60c35bb8
hj kim [Tue, 4 Feb 2020 09:10:17 +0000 (18:10 +0900)]
define enum for ID3tag to make codes simple
Change-Id: If2ebbfd36565d8878ad0f11da1e18742db4373d6
jiyong.min [Fri, 7 Feb 2020 02:59:35 +0000 (11:59 +0900)]
Bump to 0.6.85
Change-Id: Ia88c259d3110e21eb206cadb5951af5f3bf0590e
jiyong.min [Fri, 7 Feb 2020 02:17:48 +0000 (11:17 +0900)]
Remove unused code and apply coding rule
Change-Id: I13287f489082df64e03fb06208b60b588a3f4d5c
jiyong.min [Fri, 7 Feb 2020 00:54:37 +0000 (09:54 +0900)]
Reinforce comment and '__AvGetLastID3v2Offset' function
Change-Id: I8fc9af5c7003715aa8968a56203047a251d68c10
jiyong.min [Thu, 6 Feb 2020 06:28:30 +0000 (15:28 +0900)]
[code cleanup] Add to check hard return value for file_read
Change-Id: I329980a09b6be133d374376a6bbe7b833afcf271
jiyong.min [Thu, 6 Feb 2020 05:27:04 +0000 (14:27 +0900)]
[code cleanup] Remove duplicated buffer allocation & file read
and remove unnecessary code
Change-Id: I57ec5316e4bd26d14d83ded18007bb5d209c33cb
jiyong.min [Wed, 5 Feb 2020 08:33:44 +0000 (17:33 +0900)]
Seperate getting mp3 information into getting mp3_tag_info and mp3_stream_info
- When 'mmfile_format_open' function is called, it read mp3 file
to get mp3 information. Because scanning mp3 file call the function
2~3 times, there was a loss in performance.
So we changed the function call from open to read and
seperated into two sub_function.
Change-Id: Ica77bed739c89e41e3643889e29ada6eadb7fd28
jiyong.min [Wed, 5 Feb 2020 07:36:17 +0000 (16:36 +0900)]
[code cleanup] Improved code readability for getting ID3Tag
Change-Id: I1be3ab6b95a7e0c75e349b6de365769ef8e3944e
jiyong.min [Wed, 5 Feb 2020 06:13:16 +0000 (15:13 +0900)]
Unify duplicated ID3v2header getting code
Change-Id: Ib875c1e2421632dfb69f864df037a9e2f82d6258
hj kim [Wed, 5 Feb 2020 08:17:07 +0000 (17:17 +0900)]
Remove redundant condition check code
Change-Id: I774056be4f064d0a6cc0f5160aba6f5cacc12fd9
hj kim [Wed, 5 Feb 2020 06:46:02 +0000 (15:46 +0900)]
Remove useless parameter v2numOfFrames
Change-Id: I6967a9637c370a884247104b93a89ff8d2272b73
hj kim [Wed, 5 Feb 2020 05:39:46 +0000 (14:39 +0900)]
Unify duplicated ID3tag extracting code
Change-Id: Idde219a2231733c90e70cd55c90d6b6f9325ab86
jiyong.min [Wed, 5 Feb 2020 01:00:15 +0000 (10:00 +0900)]
Remove id3 version specific 'mmfile_string_convert_v224' function and unreachable code
Change-Id: Ib528a6811d8197b51bb990e655e07a06062e4b4f
hj kim [Wed, 5 Feb 2020 02:07:02 +0000 (11:07 +0900)]
Remove duplicated code and unused parameter pre_checked
Change-Id: I6118f7dabce399f4fd731ac4bede1fef4462de50
hj kim [Tue, 4 Feb 2020 09:18:01 +0000 (18:18 +0900)]
Remove unused parameter pAuthor
Change-Id: I0ce1a7838763f26576c048035322752c835f221e
jiyong.min [Thu, 30 Jan 2020 00:38:36 +0000 (09:38 +0900)]
Remove unreachable code
- Fix svace WGID 425086
Varaible 'pForamtCtx' can't be null because of
'NULL == formatContext->privateFormatData' checker.
Change-Id: I6e18ffad655bb3de10a8379257e65d473226dbb3
jiyong.min [Wed, 22 Jan 2020 01:20:21 +0000 (10:20 +0900)]
Update test code for macro refactoring
Change-Id: I4bc0fd5b84d0f97fdf924722477bb505cd7bdeb5
jiyong.min [Tue, 21 Jan 2020 01:20:20 +0000 (10:20 +0900)]
Fix coverity issue
- Argument cannot be negative
'ftell' returns signed long and it can be negative(-1).
Unsigned int 'file_size(size)' can get tainted value.
So signed long for ftell has been added and check if it is below zero.
Change-Id: Ibe651c19465acc57b2e4e31b705644887c18a623
jiyong.min [Mon, 20 Jan 2020 23:58:07 +0000 (08:58 +0900)]
Fix coverity issue
- Resource leak
Variable 'err_attr_name' should be freed by caller, but it is not used and freed.
So, remove unused(useless) 'err_attr_name'.
Change-Id: I201c216828a05a0e620799145960de925c9ce524
jiyong.min [Thu, 2 Jan 2020 05:25:20 +0000 (14:25 +0900)]
Fix wrong duration for mpeg-ts
Generally, mpegts has wrong start time(positive large value).
So duration do not use start time for mpeg-ts.
Change-Id: I97ddc31860bdeb489abe41f4fbc7e9b61d2572d5
jiyong.min [Thu, 26 Dec 2019 05:59:15 +0000 (14:59 +0900)]
Fix build error due to toolchain upgrade (gcc6->gcc9)
error: output trucated before the last format character [-Werror=format-truncation=]
Change-Id: I9a0c7460e1afc81e46d14a4190c89a644943bf64
jiyong.min [Thu, 5 Dec 2019 05:00:50 +0000 (14:00 +0900)]
Remove unused functions
Change-Id: Ib7ccc1e9da5c9793d0b2169c502e3df82e79a947
jiyong.min [Wed, 13 Nov 2019 05:05:43 +0000 (14:05 +0900)]
Replace SAFE_STRLCPY to mmfile_strdup
Change-Id: I81a8687b35b6066a7c6454e0af8242ec357b4f20
jiyong.min [Wed, 13 Nov 2019 03:22:07 +0000 (12:22 +0900)]
Remove unused variables
- descriptionLen
- pDescription
- pRating
- bTagVer2Found
- bGenreUTF16
Change-Id: Id0ae4c97533d7a466686eacaf35af919d157e9f1
jiyong.min [Thu, 7 Nov 2019 05:01:52 +0000 (14:01 +0900)]
Code Cleanup for duplicated code of getting text encoding type
- Add new funtion to get text encoding type
Change-Id: I33d11fa4f59c52f25b20b221bfe02a8a0bb5231d
jiyong.min [Mon, 11 Nov 2019 01:21:08 +0000 (10:21 +0900)]
Code Cleanup for duplicated code of getting synclyric
Change-Id: I20ab23c9cb0b3ad99121397cc402695f7961ee12
projects / platform / core / multimedia / libmm-fileinfo.git / log