Mark Adams [Wed, 6 Dec 2017 18:28:29 +0000 (18:28 +0000)]
Don't assume rendering complete before buffer latch
am:
9e0214cf61
Change-Id: Iee3ccf2afef375ac45e60133537a141d685d607f
Mark Adams [Mon, 4 Dec 2017 22:26:54 +0000 (17:26 -0500)]
Don't assume rendering complete before buffer latch
It's valid for the buffer to latch before rendering is completed, and
this is causing intermittent failures.
Bug: b/
69981429
Test: --deqp-case=dEQP-EGL*get_frame_timestamps*
Change-Id: Ia9f1d0e4ffa7f3e16a46fc4566157a651d1b0601
Gurchetan Singh [Tue, 7 Nov 2017 20:45:44 +0000 (20:45 +0000)]
Lower correlation threshold in flush-finish tests again am:
6455e6f987 am:
2e18b48b04 am:
b31b60abe6 am:
da172c6afd am:
ed080cc354
am:
4d5a25b142
Change-Id: Iece967058049e50e63f7cc4235bf6468eddffc97
Gurchetan Singh [Tue, 7 Nov 2017 20:42:12 +0000 (20:42 +0000)]
Lower correlation threshold in flush-finish tests again am:
6455e6f987 am:
2e18b48b04 am:
b31b60abe6 am:
da172c6afd
am:
ed080cc354
Change-Id: I3c63098007f8634c51ecd9fbf8844b5c5f2f2c26
Gurchetan Singh [Tue, 7 Nov 2017 20:38:43 +0000 (20:38 +0000)]
Lower correlation threshold in flush-finish tests again am:
6455e6f987 am:
2e18b48b04 am:
b31b60abe6
am:
da172c6afd
Change-Id: Iecdc967997849e2377fb480454f89a75e072c298
Gurchetan Singh [Tue, 7 Nov 2017 20:36:05 +0000 (20:36 +0000)]
Lower correlation threshold in flush-finish tests again am:
6455e6f987 am:
2e18b48b04
am:
b31b60abe6
Change-Id: I0c83a1932bb47c1b295cf2f0f19447b7c7950557
Gurchetan Singh [Tue, 7 Nov 2017 20:34:09 +0000 (20:34 +0000)]
Lower correlation threshold in flush-finish tests again am:
6455e6f987 am:
84373d7748 am:
7776db1369
am:
83cec0e56e
Change-Id: Ie4217eb2aa68077a3fc53820c8de2931eac705c8
Gurchetan Singh [Tue, 7 Nov 2017 20:34:04 +0000 (20:34 +0000)]
Lower correlation threshold in flush-finish tests again am:
6455e6f987
am:
2e18b48b04
Change-Id: Id0dd6ef88d6a9f1a53a0b72e7fc6912ade51878d
Gurchetan Singh [Tue, 7 Nov 2017 20:31:07 +0000 (20:31 +0000)]
Lower correlation threshold in flush-finish tests again am:
6455e6f987 am:
84373d7748
am:
7776db1369
Change-Id: I8ab737ed4a43886a1ecc7656ef84b265c1b2f7bc
Gurchetan Singh [Tue, 7 Nov 2017 20:29:56 +0000 (20:29 +0000)]
Lower correlation threshold in flush-finish tests again
am:
6455e6f987
Change-Id: I06395cdc2b3b19e7426f35e80981d0547309ede4
Gurchetan Singh [Tue, 7 Nov 2017 20:29:09 +0000 (20:29 +0000)]
Lower correlation threshold in flush-finish tests again am:
6455e6f987
am:
84373d7748
Change-Id: I0bda19c76be8c905ce711c089e5576fd7bfee09e
Gurchetan Singh [Tue, 7 Nov 2017 20:24:36 +0000 (20:24 +0000)]
Lower correlation threshold in flush-finish tests again
am:
6455e6f987
Change-Id: I11a62d5d0af3612ed1cdcbedee1ba53d5b0e57ae
Brian Anderson [Tue, 7 Nov 2017 20:02:39 +0000 (20:02 +0000)]
Merge changes I5f7e56e3,I7f88e1da into oreo-cts-dev am:
67694b5635 am:
aa425927d0
am:
efb1ae2ab9
Change-Id: I5623468a2c31d7e265e89f5d860e61fe911e225b
Brian Anderson [Tue, 7 Nov 2017 19:59:37 +0000 (19:59 +0000)]
Merge changes I5f7e56e3,I7f88e1da into oreo-cts-dev am:
67694b5635
am:
aa425927d0
Change-Id: I4a353896ae1d58cfa206c37b4081010f7577899b
Brian Anderson [Tue, 7 Nov 2017 19:57:39 +0000 (19:57 +0000)]
Merge changes I5f7e56e3,I7f88e1da into oreo-cts-dev
am:
67694b5635
Change-Id: I202b9be2b529cc3ba80a96f66a31b42252b47234
Treehugger Robot [Tue, 7 Nov 2017 19:49:35 +0000 (19:49 +0000)]
Merge changes I5f7e56e3,I7f88e1da into oreo-cts-dev
* changes:
eglGetFrameTimestamps: Consider timestamps of 0 as invalid.
eglGetFrameTimestamps: Allow reads done to equal rendering complete.
Chris Forbes [Tue, 7 Nov 2017 03:07:01 +0000 (03:07 +0000)]
Exclude incremental_present scale down from Android CTS am:
da253a4fe0 am:
3d03b52e1f
am:
b2185cdcbb
Change-Id: I9047deda4c47d482d7e29c7c866a0cfa8321d9f1
Chris Forbes [Tue, 7 Nov 2017 03:06:37 +0000 (03:06 +0000)]
Exclude shared_presentable_image scale down from Android CTS am:
4e9d89ac4a am:
8192b7059e
am:
b3e8cd74fe -s ours
Change-Id: I0429832d24cdd31462dd229b821b0a29e1c90dbe
Chris Forbes [Tue, 7 Nov 2017 02:57:37 +0000 (02:57 +0000)]
Exclude incremental_present scale down from Android CTS am:
da253a4fe0
am:
3d03b52e1f
Change-Id: I55883fde5f84a8e332b4fea8ae5a8859b52ef9cb
Chris Forbes [Tue, 7 Nov 2017 02:55:34 +0000 (02:55 +0000)]
Exclude incremental_present scale down from Android CTS
am:
da253a4fe0
Change-Id: I9097d2fdf2783464974888010bb89b654b7e0e8b
Chris Forbes [Tue, 7 Nov 2017 02:40:06 +0000 (02:40 +0000)]
Exclude shared_presentable_image scale down from Android CTS am:
4e9d89ac4a
am:
8192b7059e
Change-Id: I04fc2b48d6830403add863a62e9cbfc65fd75899
Chris Forbes [Tue, 7 Nov 2017 02:37:04 +0000 (02:37 +0000)]
Exclude shared_presentable_image scale down from Android CTS
am:
4e9d89ac4a
Change-Id: I5a4c71c270694fa27cd8686b7baa7e31f3d39ca1
Brian Anderson [Thu, 19 Oct 2017 21:59:28 +0000 (14:59 -0700)]
eglGetFrameTimestamps: Consider timestamps of 0 as invalid.
There's a bug in the kernel that doesn't merge fences properly,
resulting in "reads done" timestamps of 0 when the fences being
merged have already signaled.
This is a temporary relaxation of the test requirements until
the kernel fix is required.
Bug:
68811985
Test: --deqp-case=dEQP-EGL*get_frame_timestamps*
Change-Id: I5f7e56e3a0c9808237a1ebc3787cf788feef1a79
Brian Anderson [Tue, 17 Oct 2017 19:17:40 +0000 (12:17 -0700)]
eglGetFrameTimestamps: Allow reads done to equal rendering complete.
If there are no reads performed by the compositor, it is possible
for reads done timestamp to be the same as the rendering complete
timestamp.
Also add and use check_lt and check_le, to print out more detailed
debug info in the results.
Bug:
68811985
Test: --deqp-case=dEQP-EGL*get_frame_timestamps*
Change-Id: I7f88e1da98be97101e8b0d6cd130b75bda8d88ca
Brian Anderson [Thu, 19 Oct 2017 21:59:28 +0000 (14:59 -0700)]
eglGetFrameTimestamps: Consider timestamps of 0 as invalid.
There's a bug in the kernel that doesn't merge fences properly,
resulting in "reads done" timestamps of 0 when the fences being
merged have already signaled.
This is a temporary relaxation of the test requirements until
the kernel fix is required.
Bug:
66916041
Test: Test: --deqp-case=dEQP-EGL*get_frame_timestamps*
Change-Id: I0b2a65303c425a74a48d6ae8c971c16652d727a3
Chris Forbes [Fri, 29 Sep 2017 16:51:49 +0000 (09:51 -0700)]
Exclude incremental_present scale down from Android CTS
Bug: b/
67022169
Bug: b/
67295411
Test: check_build_sanity
Change-Id: I4be889f0bf64251069e829924faf4e8c113baa86
Chris Forbes [Fri, 29 Sep 2017 16:51:49 +0000 (09:51 -0700)]
Exclude shared_presentable_image scale down from Android CTS
Bug: b/
66464066
Test: check_build_sanity
Change-Id: If815b53b8e998e720aca4fc1994e0151eef971a5
Brian Anderson [Tue, 17 Oct 2017 19:17:40 +0000 (12:17 -0700)]
eglGetFrameTimestamps: Allow reads done to equal rendering complete.
If there are no reads performed by the compositor, it is possible
for reads done timestamp to be the same as the rendering complete
timestamp.
Also add and use check_lt and check_le, to print out more detailed
debug info in the results.
Bug:
66916041
Test: --deqp-case=dEQP-EGL*get_frame_timestamps*
Change-Id: Ic77fb3871bfcd2ec2298b20db7247b6782088399
Gurchetan Singh [Fri, 6 Oct 2017 16:06:21 +0000 (09:06 -0700)]
Lower correlation threshold in flush-finish tests again
This test expects predictability from glFlush/glFinish timing.
In particular, the code from FlushFinishCase::analyzeResults()
checks that the result falls within specific timing thresholds.
Notice that in the GLES3 specification, there is no requirement for
timing, just a guarantee that "commands [...] complete in finite time".
This is a problem because it makes the test very flaky, for example
if the CPU/GPU clocks are not ramping up fast enough.
BUG=b:
67331095
TEST=Ran dEQP-GLES3.functional.flush_finish.finish on Elm for over 3+ hours
Observed 1.5% to 2% flakiness without this patch. Observed no flakiness
with this patch.
(cherry picked from commit
59f4fcde5ac1402ab3b911cf6a9f66b886c10464)
Signed-off-by: Gurchetan Singh <gurchetansingh@google.com>
Chris Forbes [Fri, 29 Sep 2017 16:51:49 +0000 (09:51 -0700)]
Exclude incremental_present scale down from Android CTS
Bug: b/
65643778
Bug: b/
67022169
Bug: b/
67295411
Test: check_build_sanity
Change-Id: I4be889f0bf64251069e829924faf4e8c113baa86
Chris Forbes [Fri, 29 Sep 2017 16:51:49 +0000 (09:51 -0700)]
Exclude shared_presentable_image scale down from Android CTS
Bug: b/
65643778
Bug: b/
66464066
Test: check_build_sanity
Change-Id: If815b53b8e998e720aca4fc1994e0151eef971a5
Chris Forbes [Tue, 3 Oct 2017 22:46:18 +0000 (22:46 +0000)]
Disable some UBO tests which got broken by recent glslang change am:
d81d8e2af7 am:
188944cfd1
am:
0f95f68482
Change-Id: Ia49724d1cf3fade59f71e39d6f321398e042e5f6
Chris Forbes [Tue, 3 Oct 2017 22:41:02 +0000 (22:41 +0000)]
Disable some UBO tests which got broken by recent glslang change am:
d81d8e2af7
am:
188944cfd1
Change-Id: Iab4679d945588de21bf329f114074d3bd0f92765
Chris Forbes [Tue, 3 Oct 2017 22:37:51 +0000 (22:37 +0000)]
Disable some UBO tests which got broken by recent glslang change
am:
d81d8e2af7
Change-Id: Ic275c1ec2efeaf191a4537ca78a8b0109b8ac9fc
Chris Forbes [Tue, 3 Oct 2017 17:17:59 +0000 (10:17 -0700)]
Disable some UBO tests which got broken by recent glslang change
Bug: b/
67013571
Change-Id: I54c3f9aba636381a57e398de603b09dad4d14188
Mika Isojrvi [Sat, 23 Sep 2017 00:11:36 +0000 (00:11 +0000)]
Fix missing SSBO binding in EGL robustness tests am:
645b470b61 am:
bbed3afad3
am:
f1a0604dbe
Change-Id: I596f90b5511c7d1aed73df7d4873b567e2ebe1d9
Mika Isojrvi [Sat, 23 Sep 2017 00:11:07 +0000 (00:11 +0000)]
Fix unused uniform bug in EGL robustness tests am:
cd1ec788ec am:
ec1e89a3f8
am:
49f47fb792
Change-Id: Icdd22cf024147de11d31655d3ae6ecdc49ff3ac5
Michael Chock [Sat, 23 Sep 2017 00:10:52 +0000 (00:10 +0000)]
Do not use degenerate frames in EGL tests am:
8adce77ee5 am:
5ec562c6e2
am:
364dfab9e2
Change-Id: I356c95efe1e508f07bfcc2608efb4ddbc0804d06
Mika Isojrvi [Sat, 23 Sep 2017 00:10:35 +0000 (00:10 +0000)]
Exclude mutable image tests from Android CTS am:
ae838ac1c9 am:
6b3b1310a6
am:
2d9bb5fce7
Change-Id: Ieeb616146390d71e9d6d43a3dd72c63075c3d140
Mika Isojärvi [Fri, 22 Sep 2017 18:44:23 +0000 (11:44 -0700)]
resolve merge conflicts of
037808f59 to oc-mr1-dev
Bug:
65677277
Test: Ran scripts/check_build_sanity.py build Android CTS.
Change-Id: I0befb24161cddbe1d94ec60ce5a0438907986f31
Mika Isojrvi [Fri, 22 Sep 2017 17:12:29 +0000 (17:12 +0000)]
Fix missing SSBO binding in EGL robustness tests am:
645b470b61
am:
bbed3afad3
Change-Id: I78533856c5be779460686f81da510c13cf21fe8f
Mika Isojrvi [Fri, 22 Sep 2017 17:12:02 +0000 (17:12 +0000)]
Fix unused uniform bug in EGL robustness tests am:
cd1ec788ec
am:
ec1e89a3f8
Change-Id: I6a666ba715c0548223d1884d205fab39952713e4
Michael Chock [Fri, 22 Sep 2017 17:10:37 +0000 (17:10 +0000)]
Do not use degenerate frames in EGL tests am:
8adce77ee5
am:
5ec562c6e2
Change-Id: If409f5cd9f766f7cd9fc125fb0167c3f0ca4f67a
Mika Isojrvi [Fri, 22 Sep 2017 17:10:20 +0000 (17:10 +0000)]
Exclude mutable image tests from Android CTS am:
ae838ac1c9
am:
6b3b1310a6
Change-Id: I1d0bbbaf2eefd5a28976e20ecd11ebe16016fa38
Mika Isojärvi [Fri, 22 Sep 2017 17:09:58 +0000 (17:09 +0000)]
Merge Vulkan CTS 1.0.2.6 into aosp/oreo-cts-dev am:
9b726ab801
am:
32d048a372
Change-Id: I6d38d737b6e7919d2af54f99eb7137771a8a826f
Mika Isojrvi [Fri, 22 Sep 2017 17:09:53 +0000 (17:09 +0000)]
Fix missing SSBO binding in EGL robustness tests
am:
645b470b61
Change-Id: I3ec70aaea8a1ac682f979325fc15640021128dcc
Mika Isojrvi [Fri, 22 Sep 2017 17:09:35 +0000 (17:09 +0000)]
Fix unused uniform bug in EGL robustness tests
am:
cd1ec788ec
Change-Id: I87cad598704f810cbc2e13936f059581f4d26f7e
Michael Chock [Fri, 22 Sep 2017 17:09:17 +0000 (17:09 +0000)]
Do not use degenerate frames in EGL tests
am:
8adce77ee5
Change-Id: I37c6dbd436c20bf57d258ef3bb434e54df487530
Mika Isojrvi [Fri, 22 Sep 2017 17:08:57 +0000 (17:08 +0000)]
Exclude mutable image tests from Android CTS
am:
ae838ac1c9
Change-Id: Iddd882fec13052e94b9a4e30e6391188378ddb35
Mika Isojärvi [Fri, 22 Sep 2017 17:08:32 +0000 (17:08 +0000)]
Merge Vulkan CTS 1.0.2.6 into aosp/oreo-cts-dev
am:
9b726ab801
Change-Id: Iadafad339c5e51081e184d976d0f4bf04feb875e
Mika Isojärvi [Thu, 31 Aug 2017 18:54:48 +0000 (11:54 -0700)]
Fix missing SSBO binding in EGL robustness tests
Bug:
64845581
Bug:
65175642
Test: Ran the tests on couple of Google devices
Change-Id: I3a98fe12802e6951483499e800cd3fe7412e37f0
Mika Isojärvi [Thu, 31 Aug 2017 19:13:05 +0000 (12:13 -0700)]
Fix unused uniform bug in EGL robustness tests
Bug:
64845766
Bug:
65175554
Test: Ran tests on couple of Google devices
Change-Id: Iee2918c1e45ad305dd9ca30f1b81998bdac06127
Michael Chock [Mon, 14 Aug 2017 18:55:14 +0000 (11:55 -0700)]
Do not use degenerate frames in EGL tests
The dEQP-EGL.functional.buffer_age.* and
dEQP-EGL.functional.partial_update.* tests use randomly-generated frames
for rendering. The test allows the generation of frames with a width or
height of 0, but the tcu::PixelBufferAccess interface does not permit
0-sized subregions (see assertions inside getSubregion overloads in
tcuTextureUtil.cpp).
Skip the rendering of degenerate frames in the reference renderer, as
they are unsupported but would not affect the rendering if they were.
Bug:
65317274
Test: Ran tests on couple of Google devices
Change-Id: I3977c3c293715db633dde74132e56b5d9303ab28
Mika Isojärvi [Mon, 18 Sep 2017 20:27:19 +0000 (13:27 -0700)]
Exclude mutable image tests from Android CTS
Bug:
65844886
Test: Ran scripts/check_build_sanity.py
Change-Id: Ia779ed1e9c3339f0e4ddb599647284c15f1aeaaf
Mika Isojärvi [Fri, 15 Sep 2017 21:15:20 +0000 (14:15 -0700)]
Merge Vulkan CTS 1.0.2.6 into aosp/oreo-cts-dev
Bug:
65677277
Test: Run Android CTS deqp tests
Change-Id: I2ffb7d3929448e721f8097f323eaab011b445d8b
Courtney Goeltzenleuchter [Tue, 12 Sep 2017 23:11:21 +0000 (17:11 -0600)]
Catch BAD_MATCH from createWindowSurface
On some platforms, it's possible to fail createWindowSurface
for some attribute combinations. Catch that case and return
NotSupported rather than a test failure.
Test: adb -d shell am start \
-n com.drawelements.deqp/android.app.NativeActivity \
-e cmdLine '"deqp --deqp-case=dEQP-EGL.functional.wide_color.* \
--deqp-log-filename=/sdcard/dEQP-Log.qpa"'
Bug:
65376495
Change-Id: I6546cbdfc011c7d26cfa3cdad7cc6f0df1b67122
(cherry picked from commit
c35781eb8d47be8ab51b0891d1ab9bb62665488b)
Tony Wasserka [Tue, 12 Sep 2017 11:03:13 +0000 (12:03 +0100)]
Check for depthBounds support in shader builtin frag depth tests
Depth bounds testing was enabled without checking for feature support
in a couple of tests. With this change, tests that don't need this
feature leave it disabled, whereas other tests (currently only
dEQP-VK.glsl.builtin_var.fragdepth.*) now throw NotSupported when
the device doesn't support it.
Affects:
dEQP-VK.clipping.*
dEQP-VK.glsl.builtin_var.*
Components: Vulkan
VK-GL-CTS issue: 685
Change-Id: I44d94142e295ff135ad1a55d0d6e212b65994257
Courtney Goeltzenleuchter [Mon, 11 Sep 2017 19:06:48 +0000 (13:06 -0600)]
Fix handling of EGL_NONE as color space
Color space of EGL_NONE was getting passed down and
driver threw EGL_BAD_ATTRIBUTE in response.
Issue was caused when changing the colorspace from nullptr
to EGL_NONE, missed a couple of places that needed to
test against EGL_NONE instead of nullptr.
Bug:
65376495
Test: adb -d shell am start \
-n com.drawelements.deqp/android.app.NativeActivity \
-e cmdLine '"deqp --deqp-case=dEQP-EGL.functional.wide_color.* \
--deqp-log-filename=/sdcard/dEQP-Log.qpa"'
Change-Id: If8812725be9d3858bf610c647ba53ff38944dd50
Slawomir Cygan [Mon, 31 Jul 2017 12:22:50 +0000 (14:22 +0200)]
Fix regressions in synchronization tests for dedicated allocations
Pass image memory requirements to allocation routine in allocateAndBindMemory.
VK_KHR_get_memory_requirements2 is a device extension (not instance).
Throw NotSupported when external handle requires dedicated allocation,
but 'suballocated' variant of test is being run.
Affects:
dEQP-VK.synchronization.cross_instance.*
Components: Vulkan
VK-GL-CTS issue: 604
Bug:
65490152
Bug:
65202260
Test: Ran tests on couple of Google devices
Change-Id: I3636779459300f5dee2e22b0a2e04762eb7b0601
Alexander Galazin [Fri, 8 Sep 2017 07:13:24 +0000 (09:13 +0200)]
Merge vk-gl-cts/vulkan-cts-1.0.1 into vk-gl-cts/vulkan-cts-1.0.2
Change-Id: Ied1a7d639c56dbdffd3db89085b4b771741e43f7
Graeme Leese [Wed, 30 Aug 2017 15:37:14 +0000 (16:37 +0100)]
Change required sample counts for storage images
Update the API feature info tests to set requiredSampleCounts to 1 for
all images that are not usable as some type of framebuffer attachment.
Previously images that were not usable as attachments but could be used
as a storage image were incorrectly exempted from the requirement.
Components: Vulkan
VK-GL-CTS Issue: 645
Affects: dEQP-VK.api.info.image_format_properties.*
Change-Id: Ia0d09ad0ff51029b75cd3a264860a3dd63c249fb
Ian Elliott [Wed, 16 Aug 2017 21:11:57 +0000 (15:11 -0600)]
Fix flakiness in mailbox.display_timing
The "vktWsiDisplayTimingTests.cpp" file was originally written just for
a present mode of VK_PRESENT_MODE_FIFO_KHR. It has a case at image 80,
where it changes the desiredPresentTime to be 1 second earlier, and then
checks that later. Such a check doesn't work with
VK_PRESENT_MODE_MAILBOX_KHR, which can throw off the timing of images
(because some images may not be presented). This has resulted in the
test having random failures. The "image 80 test" wasn't intended to
occur with MAILBOX, and so it's now being removed.
VK-GL-CTS issue: 622
Components: Vulkan
Affects: dEQP-VK.wsi.*.display_timing.mailbox.display_timing
Bug:
64486630
Test: Build cts and ran scripts/check_build_sanity.py
Change-Id: I9fbd2254b4e6fc1c7bff077c8c0a5229a6d74800
Boris Zanin [Thu, 7 Sep 2017 07:19:08 +0000 (09:19 +0200)]
Fix VK_KHR_maintenance2 extended_usage_bit tests
Due to test runs over uncompressed formats it cannot include
VK_IMAGE_CREATE_BLOCK_TEXEL_VIEW_COMPATIBLE_BIT_KHR bit.
Remove this bit from the tests.
Update tests:
* dEQP-VK.image.extended_usage_bit.*
Components: Vulkan
VK-GL-CTS issue: 673, 614
Change-Id: I0adb26c5306a9d5f49936ffef070050fd5936faa
Gary Sweet [Mon, 4 Sep 2017 10:14:58 +0000 (11:14 +0100)]
Fixup some missing/incorrect flushes and invalidates
Some of the flushes were too small, and there were a few
missing invalidates.
Affects:
dEQP-VK.ssbo.layout.*
dEQP-VK.pipeline.push_constant.compute_pipeline.simple_test
Components: Vulkan
VK-GL-CTS issue: 660
Change-Id: I27fac24397984f82865683f30b823570c3e52aed
TreeHugger Robot [Wed, 6 Sep 2017 20:36:37 +0000 (20:36 +0000)]
Merge "Check for EGL_KHR_gl_colorspace before using it" into oc-mr1-dev
Mika Isojarvi [Wed, 6 Sep 2017 16:32:19 +0000 (16:32 +0000)]
Merge changes Iee2918c1,I3a98fe12 into oc-mr1-dev
* changes:
Fix unused uniform bug in EGL robustness tests
Fix missing SSBO binding in EGL robustness tests
Slawomir Cygan [Wed, 6 Sep 2017 14:47:04 +0000 (16:47 +0200)]
Use SRC image layout for copy image to buffer
The test was calling vkCmdCopyImageToBuffer with
VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL layout, which is not a valid
parameter value for this function (and not the layout the image is currently in).
Affects: dEQP-VK.memory.binding.*.*.image_*
Components: Vulkan
VK-GL-CTS issue: 666
Change-Id: Ifb5a1bd8726535de02a0dc134f5ac76a2734a661
Courtney Goeltzenleuchter [Tue, 5 Sep 2017 23:48:27 +0000 (17:48 -0600)]
Check for EGL_KHR_gl_colorspace before using it
Bug:
65376495
Test: adb -d shell am start \
-n com.drawelements.deqp/android.app.NativeActivity \
-e cmdLine '"deqp --deqp-case=dEQP-EGL.functional.wide_color.* \
--deqp-log-filename=/sdcard/dEQP-Log.qpa"'
Change-Id: Ief654c998e93d72899225120b0ca1ab2fa3ca624
(cherry picked from commit
2cf32ffa6ee9daf7f58e34c1b874f4005e4b888f)
Slawomir Cygan [Tue, 5 Sep 2017 14:39:12 +0000 (16:39 +0200)]
Do not use ycbcr formats if ycbcr extension is not supported
Spec says (on "vkGetPhysicalDeviceFormatProperties"):
"format must be a valid VkFormat value"
Formats from future or unsupported extensions do not
constitute a "valid VkFormat values".
Affects: dEQP-VK.memory.requirements.*.image.*
Components: Vulkan
VK-GL-CTS issue: 663
Change-Id: Ia284977b830d5fda14bcbd9d96010995d84014d5
Mika Isojarvi [Tue, 5 Sep 2017 17:50:15 +0000 (17:50 +0000)]
Merge "Require EGL_KHR_gl_colorspace for wide_color tests." into oc-mr1-dev
Mika Isojärvi [Thu, 31 Aug 2017 19:13:05 +0000 (12:13 -0700)]
Fix unused uniform bug in EGL robustness tests
Bug:
64845766
Bug:
65175554
Test: Ran tests on couple of Google devices
Change-Id: Iee2918c1e45ad305dd9ca30f1b81998bdac06127
Mika Isojärvi [Thu, 31 Aug 2017 18:54:48 +0000 (11:54 -0700)]
Fix missing SSBO binding in EGL robustness tests
Bug:
64845581
Bug:
65175642
Test: Ran the tests on couple of Google devices
Change-Id: I3a98fe12802e6951483499e800cd3fe7412e37f0
Mika Isojarvi [Tue, 5 Sep 2017 17:18:22 +0000 (17:18 +0000)]
Merge changes Iaf75d17e,I3977c3c2,Iff74939d into oc-mr1-dev
* changes:
Use safe glFramebufferTexture* function
Do not use degenerate frames in EGL tests
Check for tessellation/geometry extensions being exposed
Pyry Haulos [Tue, 5 Sep 2017 16:07:56 +0000 (16:07 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am:
0f672f2a20 am:
338a411fd3 am:
0d9b810283 am:
79f028e0ac am:
c3c3b95253 am:
745856554f am:
2b79153434
am:
c0fc41f6bc
Change-Id: I648c5f0e8d281c51625350d93daf2879ad5a430e
Pyry Haulos [Tue, 5 Sep 2017 16:07:32 +0000 (16:07 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am:
0f672f2a20 am:
9e85a126d2 am:
ac400ff59f am:
36b26f80fe am:
f909a2d16c am:
3976e3eade
am:
4564f27dba
Change-Id: I4bac001f8af3ff954aab3258a1187e5f97beb77b
Pyry Haulos [Tue, 5 Sep 2017 15:59:55 +0000 (15:59 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am:
0f672f2a20 am:
338a411fd3 am:
0d9b810283 am:
79f028e0ac am:
c3c3b95253 am:
745856554f
am:
2b79153434
Change-Id: I59da57b654d86c8e5a49068db970566c8e5373d8
Pyry Haulos [Tue, 5 Sep 2017 15:59:31 +0000 (15:59 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am:
0f672f2a20 am:
9e85a126d2 am:
ac400ff59f am:
36b26f80fe am:
f909a2d16c
am:
3976e3eade
Change-Id: I6cb9841790f4027016df0c7cf8023ab991334125
Pyry Haulos [Tue, 5 Sep 2017 15:51:16 +0000 (15:51 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am:
0f672f2a20 am:
338a411fd3 am:
0d9b810283 am:
79f028e0ac am:
c3c3b95253
am:
745856554f
Change-Id: Ie2af4250a408f55c2857629e00b3915e23a5268b
Pyry Haulos [Tue, 5 Sep 2017 15:50:59 +0000 (15:50 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am:
0f672f2a20 am:
9e85a126d2 am:
6d0cee6923 am:
4fa7f75d5f
am:
eecfee50a9
Change-Id: I3e259b3e82816c11d662a314f21e0c6da68dadb2
Pyry Haulos [Tue, 5 Sep 2017 15:50:59 +0000 (15:50 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am:
0f672f2a20 am:
9e85a126d2 am:
ac400ff59f am:
36b26f80fe
am:
f909a2d16c
Change-Id: I3056d6017cd988ff62104131642a22a88b26b24f
Pyry Haulos [Tue, 5 Sep 2017 15:50:28 +0000 (15:50 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am:
0f672f2a20 am:
338a411fd3 am:
0d9b810283 am:
79f028e0ac
am:
c3c3b95253
Change-Id: I62ff995a5e6b0140777b13848af33ece4f6248e8
Pyry Haulos [Tue, 5 Sep 2017 15:41:29 +0000 (15:41 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am:
0f672f2a20 am:
9e85a126d2 am:
6d0cee6923
am:
4fa7f75d5f
Change-Id: I940607508851c13fd4ae3a35e0eb427f96efc571
Pyry Haulos [Tue, 5 Sep 2017 15:41:29 +0000 (15:41 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am:
0f672f2a20 am:
9e85a126d2 am:
ac400ff59f
am:
36b26f80fe
Change-Id: Ie960b01bc31c94107bf7c545aef03b2e9d5671ed
Pyry Haulos [Tue, 5 Sep 2017 15:41:28 +0000 (15:41 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am:
0f672f2a20 am:
338a411fd3 am:
0d9b810283
am:
79f028e0ac
Change-Id: I9523ce132950603adc6a0adf77b9833f670dd6c4
Pyry Haulos [Tue, 5 Sep 2017 15:31:57 +0000 (15:31 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am:
0f672f2a20 am:
9e85a126d2
am:
6d0cee6923
Change-Id: I2c843552baf45bfc918fce8cb7a9c40b3fd8adad
Pyry Haulos [Tue, 5 Sep 2017 15:31:55 +0000 (15:31 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am:
0f672f2a20 am:
338a411fd3
am:
0d9b810283
Change-Id: Ic07c0dafc51bf12a82794d02786b885f8b1323f8
Pyry Haulos [Tue, 5 Sep 2017 15:31:55 +0000 (15:31 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am:
0f672f2a20 am:
9e85a126d2
am:
ac400ff59f
Change-Id: I8fd3f2dac244cddb228d780cb2e7ab4943b1cb9b
Pyry Haulos [Tue, 5 Sep 2017 15:21:58 +0000 (15:21 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am:
0f672f2a20
am:
9e85a126d2
Change-Id: Ia7cd7612e6c2f0f961837734f1900a21b52a0e39
Pyry Haulos [Tue, 5 Sep 2017 15:21:55 +0000 (15:21 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am:
0f672f2a20
am:
9e85a126d2
Change-Id: Idf3c0904f9695e04b48901c23c79b7dcd101d0dc
Pyry Haulos [Tue, 5 Sep 2017 15:21:55 +0000 (15:21 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am:
0f672f2a20
am:
338a411fd3
Change-Id: I6edcc0661c9d702a5bb518d24eebf7702145318f
Pyry Haulos [Tue, 5 Sep 2017 15:14:23 +0000 (15:14 +0000)]
Fix issues in pipeline.timestamp.transfer_tests
am:
0f672f2a20
Change-Id: Ib7e13db1c7801095b925890f226a38969a1b418e
Pyry Haulos [Tue, 5 Sep 2017 15:13:55 +0000 (15:13 +0000)]
Fix issues in pipeline.timestamp.transfer_tests
am:
0f672f2a20
Change-Id: I41d95ce51483f786706f9402701208801e73ecdc
Gary Sweet [Mon, 4 Sep 2017 09:39:36 +0000 (10:39 +0100)]
Fixup some missing/incorrect flushes and invalidates
Some of the flushes were too small, and there were a few
missing invalidates.
Affects:
dEQP-VK.ssbo.layout.*
dEQP-VK.pipeline.push_constant.compute_pipeline.simple_test
Components: Vulkan
VK-GL-CTS issue: 660
Change-Id: Id29b59d127e004a028c04a1075db563d697140a1
james.glanville [Wed, 16 Aug 2017 10:50:19 +0000 (11:50 +0100)]
Use safe glFramebufferTexture* function
glFramebufferTexture() is only supported when GL_EXT_geometry_shader is
present. Use glFramebufferTextureLayer() instead so that testing is
possible on unextended ES3.1 contexts.
Components: AOSP
Bug:
65317295
Test: Ran tests on couple of Google devices
Affects:
dEQP-GLES31.functional.shaders.framebuffer_fetch.basic.framebuffer_texture_level
Change-Id: Iaf75d17e5d1077c1a6f591c3ebfca62c465d4378
Michael Chock [Mon, 14 Aug 2017 18:55:14 +0000 (11:55 -0700)]
Do not use degenerate frames in EGL tests
The dEQP-EGL.functional.buffer_age.* and
dEQP-EGL.functional.partial_update.* tests use randomly-generated frames
for rendering. The test allows the generation of frames with a width or
height of 0, but the tcu::PixelBufferAccess interface does not permit
0-sized subregions (see assertions inside getSubregion overloads in
tcuTextureUtil.cpp).
Skip the rendering of degenerate frames in the reference renderer, as
they are unsupported but would not affect the rendering if they were.
Bug:
65317274
Test: Ran tests on couple of Google devices
Change-Id: I3977c3c293715db633dde74132e56b5d9303ab28
Alexander Galazin [Fri, 11 Aug 2017 09:03:50 +0000 (11:03 +0200)]
Check for tessellation/geometry extensions being exposed
Some sample_variables tests use tessellation/geometry shaders.
Need to check that the relevant extensions are exposed.
Components: AOSP
Affects:
dEQP-GLES31.functional.debug.negative_coverage.*.oes_sample_variables.access_built_in_types_inside_other_shaders
Bug:
65317039
Test: Run tests on couple of Google devices
Change-Id: Iff74939d474082938955e5b7ebfc41ea3b4a6ec5
Tapani Pälli [Mon, 28 Aug 2017 06:20:53 +0000 (09:20 +0300)]
Require EGL_KHR_gl_colorspace for wide_color tests.
These tests utilize enum EGL_GL_COLORSPACE_KHR which is introduced by
EGL_KHR_gl_colorspace extension, check first for support and skip the
test if extension is not supported.
v2: loosen the check, only check when enum in use (Courtney)
Test: adb -d shell am start \
-n com.drawelements.deqp/android.app.NativeActivity \
-e cmdLine '"deqp --deqp-case=dEQP-EGL.functional.wide_color.* \
--deqp-log-filename=/sdcard/dEQP-Log.qpa"'
Bug:
65291400
Change-Id: I891a6fdcce49ac6dcd42577076d4cf64a143dd38
Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Mika Isojärvi [Wed, 16 Aug 2017 20:40:22 +0000 (13:40 -0700)]
Fix texture mip level size in framebuffer fetch tests
Bug:
64280744
Test: Ran tests with multiple Google devices
Change-Id: I369a3c9b16270655332d5a608207f0da2633e0fe
Daniel Koch [Thu, 31 Aug 2017 13:48:53 +0000 (09:48 -0400)]
Whitelist new extensions for VK 1.0.2.6
VK-GL-CTS issue: 653
Component: Vulkan
Affects:
dEQP-VK.api.info.device.extensions
Change-Id: I7f5ef7511ce8312e67833e07c154cd6b9fea6041
Mika Isojärvi [Tue, 15 Aug 2017 23:57:24 +0000 (16:57 -0700)]
Add tests for image copies between YCbCr formats
Components: Vulkan, Framework
VK-GL-CTS issue: 111
Change-Id: I3a7050ae5605c4397cd678e14438f851a7cf48ce
(cherry picked from commit
f24269bdd0c4d3801c2118b153082f0b0223f55a)