js126.lee [Wed, 23 Mar 2016 08:08:51 +0000 (17:08 +0900)]
Resolved security issue-IOT1003 & IOT1013
https://jira.iotivity.org/browse/IOT-1013
[PM C]OCProvisionPairwiseDevices returns OC_STACK_OK instead of
OC_STACK_INVALID_PARAM for provisioning same device
https://jira.iotivity.org/browse/IOT-1003
[PM C] APIs returns OC_STACK_INVALID_PARAM instead of
OC_STACK_INVALID_CALLBACK while CB = NULL
-Patch 1: Resolved security Issue on 1.1-RC1
-Patch 2: Apply MR.Cho's review comment
Change-Id: I1a2d0265e756da41cffbcc60042e4f35de2dbcf5
Signed-off-by: js126.lee <js126.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/6219
Reviewed-by: Kyungsun Cho <goodsun.cho@samsung.com>
Reviewed-by: Yonggoo Kang <ygace.kang@samsung.com>
Reviewed-by: Chul Lee <chuls.lee@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
leechul [Tue, 22 Mar 2016 00:38:06 +0000 (09:38 +0900)]
RAML v1.1 sync-up in SVR DB
Patch#1 : Init
Patch#2 : add missed code
Patch#3 : sync-up ACL, change sample db file(dat, json)
Patch#4 : minor fix on ACL
Patch#5 : sync-up CRED
Patch#6 : minor fix on CRED
Patch#7 : add "didformat" into "doxm"
Patch#8 : remove "ch" and minor fix from "pstat"
Patch#9 : minor change
Patch#10 : change "oxm" to "oxms" in "doxm", minor change
Patch#11 : fix on CRED
Patch#12 : pconf sync up
Patch#13 : Remove TAB characters
Patch#14~16 : Remove the compile errors for arduino
Patch#16 : Modify the convertion funtion's error-handling logic to
gurantee NULL termination of parameter in case of cbor error.
Patch#17 : 1. Rebase to resolve conflicts.
2. Re-generate SVR DB(*.dat) files.
Patch#18 : 1. Resolve ownership transfer issues with two more servers.
2. Resolve the unit test errors.
3. Update unittest's SVR DB(*.dat) in CBOR format.
Patch#19~21 : Upload missing file.
Patch#22~23 : Update according to SVACE report.
Patch#24 : Update ocstack sample's SVR DB(*.dat) in CBOR format.
Patch#25 : Modify c++ samples SVR DB(*.dat, *.json) in correct format.
Patch#26-27 : Insert the device owner field as empty value explicitly
into sample's default SVR DB.
Under test. Please don't merge this patch.
Change-Id: Ia3b6c65bf5c365c664e89d934042e30576f777bf
Signed-off-by: Yonggoo Kang <ygace.kang@samsung.com>
Signed-off-by: Ashwini Kumar <k.ashwini@samsung.com>
Signed-off-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/6099
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
jihwan.seo [Wed, 23 Mar 2016 02:29:07 +0000 (11:29 +0900)]
fixed checking result for ServerStop in caleadapter.
Change-Id: I55f68638bcd9f4ba7a045714412b56aaab368c89
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/6189
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Jay Sharma [Tue, 22 Mar 2016 07:11:53 +0000 (12:41 +0530)]
[Easy-Setup] Updated Mediator Java SDK.
- Added NULL check.
Change-Id: I72c8e64dc72559e254a4fd30dd363673127715f5
Signed-off-by: Jay Sharma <jay.sharma@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/6165
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Manoj Gupta [Wed, 16 Mar 2016 12:09:27 +0000 (17:39 +0530)]
Wrong Comarision Between signed and unsigned value
Change-Id: I5160fd7fccf4f631ce6d86c52c861aca54dcb193
Signed-off-by: Manoj Gupta <manoj.g2@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5981
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jon@joncruz.org>
jihwan.seo [Tue, 22 Mar 2016 08:22:18 +0000 (17:22 +0900)]
(IOT-997) modified checking scanned device for unicast
Change-Id: I48854d19c95f0af6fe3a0e0f28d35a4127262ab1
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/6171
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jon@joncruz.org>
leechul [Wed, 23 Mar 2016 01:39:28 +0000 (10:39 +0900)]
Modify incorrect return value in policy engine
Change-Id: I8f46cafe1898a44e71dd39e8457178819c396154
Signed-off-by: leechul <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/6187
Reviewed-by: Kyungsun Cho <goodsun.cho@samsung.com>
Reviewed-by: Jongsung Lee <js126.lee@samsung.com>
Reviewed-by: Nathan Heldt-Sheller <nathan.heldt-sheller@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Philippe Coval [Fri, 4 Mar 2016 16:06:32 +0000 (17:06 +0100)]
Fixed template syntax to prevent ambiguity with stream operators
This is a minor change but was noticed when trying to build with clang
This message appeared while building using tizen-sdk 2.4.0 Rev4
with imported libs (built with gbs from Tizen:2.4:Mobile repo)
Change-Id: Ib573d5ea9b23b29d6114d1f072210c370859fdec
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/6149
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Habib Virji <habib.virji@samsung.com>
Nathan Heldt-Sheller [Sat, 19 Mar 2016 22:25:52 +0000 (15:25 -0700)]
Added "GetSvrTypeFromUri()" and supporting code.
This is a necessary function
for v1.1 functions to handle "pstat->isop" and "rowner" checks.
Change-Id: I2b381fb6103e939bc554abaf6df0747a94f5a30e
Signed-off-by: Nathan Heldt-Sheller <nathan.heldt-sheller@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/6101
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
hyuna0213.jo [Tue, 22 Mar 2016 01:10:44 +0000 (10:10 +0900)]
Removed unnecessary files in connectivity abstraction
deletes unnecessary files from clond-interface branch.
Change-Id: I6d6e59384f4a2b792e91e6a72d750893a47628fd
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/6159
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>
Habib Virji [Fri, 11 Mar 2016 12:37:43 +0000 (12:37 +0000)]
[IOT-921]Return correct resource type in /oic/d
It adds support to add device resource type via API.
Jira Issue: IOT-921
Signed-off-by: Habib Virji <habib.virji@samsung.com>
Change-Id: Ib47f637ff343b5bc8dbce5d5f0cc2b5f1eab46ab
Reviewed-on: https://gerrit.iotivity.org/gerrit/5747
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
jihwan.seo [Mon, 14 Mar 2016 08:12:47 +0000 (17:12 +0900)]
remove previous received data from ReceiveQueue for gatt server
and modified to adjust destroy thread.
Change-Id: I39043ae19527160a4f76d808a4a8e8b70d055f8a
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5843
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
js126.lee [Sun, 20 Mar 2016 16:18:40 +0000 (01:18 +0900)]
Fixed bug of pstat during OTM
Issue: After completed OTM, ISOP is false.
According to Spec, The TAKE_OWNER of CM should be enabled for OTM.
-Patch 1,2: Fixed isOp issue.
-Patch 3: During OTM, CM is only considered by PT.
-Patch 4: Modify the CM value 0 -> 2 in *.json ant *.dat for OTM.
-Patch 5,6: Fixed build error on Arduino
Change-Id: I6eb625af743adc9f559c2cc085e419d367e78949
Signed-off-by: js126.lee <js126.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/6107
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Kyungsun Cho <goodsun.cho@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Ashwini Kumar [Mon, 21 Mar 2016 05:16:26 +0000 (10:46 +0530)]
Fixed json2cbor to handle private Data
- defined MAX_RANGE for file read
Change-Id: Ia7c2b30e1bb97d2aee239cf0916eab52c0d404c4
Signed-off-by: Ashwini Kumar <k.ashwini@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/6117
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Habib Virji [Thu, 17 Mar 2016 13:31:37 +0000 (13:31 +0000)]
[IOT-980] oic.if.ll support for /oic/res
/oic/res currently was supporting onlu oic.if.baseline.
Support for oic.if.ll has been added. It includes unit test as a callback.
Change-Id: I8b90c7c686b753c5d41191508866b0c23bcc6578
Signed-off-by: Habib Virji <habib.virji@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/6025
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Jay Sharma [Fri, 18 Mar 2016 14:59:58 +0000 (20:29 +0530)]
[Easy-setup] Unit test case fixes for Mediator
Change-Id: Ibcdfe23ee7887d72ac86acdad9b32c8674de8702
Signed-off-by: Jay Sharma <jay.sharma@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/6083
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Jay Sharma [Fri, 18 Mar 2016 17:07:54 +0000 (22:37 +0530)]
[Easy-Setup] Changed the enrollee's cpp files to c files
- Updated the enrollee SDK.
- Updated the Linux Application
Change-Id: Ieacc114d8cff3caaeb5e9f5f9cb1cdc972258d31
Signed-off-by: Jay Sharma <jay.sharma@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/6087
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Jay Sharma [Mon, 21 Mar 2016 03:37:25 +0000 (09:07 +0530)]
[Easy-setup] Commented check for Intended resource
- commented the condition for checking the intended resource in
RemoteEnrolleeResource class.
Change-Id: I937c07d151eb503e238215ec60abe69ba83dde14
Signed-off-by: Jay Sharma <jay.sharma@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/6075
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Sandipan Patra [Fri, 18 Mar 2016 10:21:27 +0000 (15:51 +0530)]
[Tizen Secure mode] Copy json file in rpm package
Change-Id: Ia5b9e0f45017e4f1b25b0538e613509de58eeb2f
Signed-off-by: Sandipan Patra <sandipan.p@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/6073
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
js126.lee [Sat, 19 Mar 2016 07:09:48 +0000 (16:09 +0900)]
Fixed unittest for security
Change-Id: I5f1877c089ffd96ea8dd09479153ab40222755df
Signed-off-by: js126.lee <js126.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/6093
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Kyungsun Cho <goodsun.cho@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Sahil Bansal [Sat, 19 Mar 2016 11:19:23 +0000 (16:49 +0530)]
Security CBOR conversion
- all security resources converted to CBOR format
- added .dat files for samples
- modified psinterface to handle pconf resource
- modified json2cbor tool to handle private data in cred
- Added dat file for c++ PT
- Corrected Unit Test case
- Code change as per review comments
- Resolved SVACE issues
Change-Id: Idadfe37c07f44bfaf1c7929c772f99e2163f7e2f
Signed-off-by: Ashwini Kumar <k.ashwini@samsung.com>
Signed-off-by: Sandeep Sharma <sandeep.s9@samsung.com>
Signed-off-by: saurabh.s9 <saurabh.s9@samsung.com>
Signed-off-by: Sahil Bansal <sahil.bansal@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/6079
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
js126.lee [Sat, 19 Mar 2016 08:53:04 +0000 (17:53 +0900)]
Modify Ciphersuite code number
Accoding to conclusion of OCF Securit TG,
the code number of TLS_ECDH_anon_WITH_AES_128_CBC_SHA256 is changed to
0xFF00 as OCF Vendor Specific Ciphersuite.
Change-Id: I24456049608a8559bd8082ab359e4a2b3c0a00b8
Signed-off-by: js126.lee <js126.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/6095
Reviewed-by: Kyungsun Cho <goodsun.cho@samsung.com>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
jihwan.seo [Thu, 17 Mar 2016 04:58:30 +0000 (13:58 +0900)]
modified start Multicast Server logic of android BLE
Change-Id: I22dc91b6361da26830490dbf7c5b773473ccd4e8
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5993
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jon@joncruz.org>
hyuna0213.jo [Fri, 11 Mar 2016 02:54:02 +0000 (11:54 +0900)]
changed block-wise transfer logic to process non-confirmable message
according to the block-wise transfer specification, block messages
should be transmitted with request-response pairs of information from
a resource representation. current block-wise transfer logic did not
handle non-confirmable message like a specification.
Change-Id: I6305bf14166720638c86eae8dc21aa5903f5b7f4
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5699
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
js126.lee [Fri, 18 Mar 2016 06:40:08 +0000 (15:40 +0900)]
Add timeout into checking invalid input condition
- Patch 1: If timeout is 0, return error.
- Patch 2: Add unittest
- Patch 3: Modify file mode
Change-Id: I571615ffe4d00dc1feff94d9b39525eabc75d215
Signed-off-by: js126.lee <js126.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/6061
Reviewed-by: Yonggoo Kang <ygace.kang@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
lankamadan [Fri, 18 Mar 2016 04:26:22 +0000 (13:26 +0900)]
Adding security json file to easysetup android assets folder
- This file is need for easysetup secured mediator for storing the creds and enrollee information
Change-Id: I3a11c332167dd3969f3fc9dee9b8455aebf8cc51
Signed-off-by: lankamadan <lanka.madan@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/6049
Reviewed-by: Sandipan Patra <sandipan.p@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Jaehong Jo [Wed, 16 Mar 2016 10:40:29 +0000 (19:40 +0900)]
Changed PORT_LENGTH to 6
Change-Id: I7097cca593daacf20e596f664d050558155d0dce
Signed-off-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5971
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jon@joncruz.org>
lankamadan [Wed, 16 Mar 2016 10:35:19 +0000 (19:35 +0900)]
Updated Tizen easysetup readme with proper rpms names
Change-Id: I0f457d03afebae55005924d035a0762dbd5d7b66
Signed-off-by: lankamadan <lanka.madan@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5969
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jon@joncruz.org>
Jaewook Jung [Thu, 17 Mar 2016 05:29:16 +0000 (14:29 +0900)]
fix error for create a new block data
Change-Id: I1a90bc9959e2049dd04d12ef90e5476608357681
Signed-off-by: Jaewook Jung <jw0213.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5995
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jon@joncruz.org>
Manoj Gupta [Wed, 16 Mar 2016 11:41:33 +0000 (17:11 +0530)]
Overflow of Buffer pinNumber resolved
Change-Id: If26833e70cae1d6f201fa90dac2a67751413dadb
Signed-off-by: Manoj Gupta <manoj.g2@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5979
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Joonghwan Lee <jh05.lee@samsung.com>
Reviewed-by: Jon A. Cruz <jon@joncruz.org>
Manoj Gupta [Wed, 16 Mar 2016 11:24:02 +0000 (16:54 +0530)]
Unused Variable Warnings removed
Change-Id: Ic9132465481b6ba8f4afb1a3b9a6d38956f3ac30
Signed-off-by: Manoj Gupta <manoj.g2@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5977
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jon@joncruz.org>
jw0213.jung [Fri, 11 Dec 2015 06:58:35 +0000 (15:58 +0900)]
MAC address parsing in constructResourceObject()
When call the function constructResourceObject(..), the first parameter
is a string for a host address of the server.
The string could be a IPv4 form or IPv6 or MAC.
But there is no parsing logic for MAC address form(xx:xx:xx:xx:xx:xx).
Without this, MAC is parsed as IPv4 which does not work properly.
(the first block as IP address, the second one is port number, and
lasts are ignored)
So I added the MAC parsing logic with checking a validity of address.
Change-Id: I2fc5a14b400605c9255173bbddc2ff7a4bae0551
Signed-off-by: Jaewook Jung <jw0213.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5593
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jon@joncruz.org>
sahil bansal [Sun, 13 Mar 2016 06:56:02 +0000 (12:26 +0530)]
Adding unit test cases for direct pairing
Change-Id: I5f140fcf7895b2e6b517b4588655a3be483c6bb1
Signed-off-by: sahil bansal <sahil.bansal@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5791
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Jee Hyeok Kim [Thu, 17 Mar 2016 00:31:47 +0000 (09:31 +0900)]
Fix cloud client sample build failure
1. Add reference to use sleep function
Change-Id: I0a6eec951f4c3b82ba77cf01a93c441fef7966d3
Signed-off-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5989
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
hyuna0213.jo [Wed, 16 Mar 2016 02:28:43 +0000 (11:28 +0900)]
Changes related to accept socket initialization
Changed tcp adapter start logic to create accept socket only when
host is server.
Change-Id: If0c20f20e8bacdcca63b20e0b204e87c7d1e78df
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5941
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>
hyuna0213.jo [Tue, 15 Mar 2016 05:58:46 +0000 (14:58 +0900)]
fixed the bug related to coap over tcp pdu creation.
The first nibble of the frame is used to indecate the length of
the options/payload. and if a value is 13, an 8-bit unsigned integer
follows the initial byte and indicates the length of options/payload
minus 13. even in case the length of options/payload is 13, an 8-bit
unsigned interger has to be used to indicate 0.
Change-Id: I580e126755ae4b3018fe7eb11eae34035b0efa6c
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5901
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>
Jee Hyeok Kim [Mon, 14 Mar 2016 08:40:16 +0000 (17:40 +0900)]
Fix PUT and Observe relay on cloud stack
1. Fix PUT and Observe relay
2. Add PUT and Observe scenario for native sample client
3. Add Testcases for cloud stack
4. Remove Net Utility for logging local IP address
Change-Id: I03c0bd9afc553e1705c67f24db0d4420405fdf1d
Signed-off-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5847
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Jee Hyeok Kim [Wed, 16 Mar 2016 07:34:46 +0000 (16:34 +0900)]
Fix buildscript on tizen build
Change-Id: I07365483238951bde700b25893f2b060511cf567
Signed-off-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5949
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Jaewook Jung [Tue, 15 Mar 2016 10:44:32 +0000 (19:44 +0900)]
Fix error in cablockwisetransfer.c
In CACheckBlockDataValidation(), crash error occurs when sending response
as CACreateBlockDatablockId() tries to refer requestInfo only for sendData.
Change-Id: I2a7fc7ec17500f1c71e59d7181af81a77ac93705
Signed-off-by: Jaewook Jung <jw0213.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5923
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Manoj Gupta [Mon, 14 Mar 2016 14:12:57 +0000 (19:42 +0530)]
Static Analysis tool errro resolved
Change-Id: I27373ad264716f7a6b3b834f794e66b9a7f64b71
Signed-off-by: Manoj Gupta <manoj.g2@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5883
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
G S Senthil Kumar [Mon, 14 Mar 2016 09:53:16 +0000 (15:23 +0530)]
Resolved simulator build failure issue.
Included a necessary header file(algorithm) to prevent build failures
when using boost version(1.46).
Change-Id: I4c6e9829d6b1a59f7c6f745551ef92ee6514df26
Signed-off-by: G S Senthil Kumar <senthil.gs@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5873
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Jay Sharma [Mon, 14 Mar 2016 10:27:23 +0000 (15:57 +0530)]
[Easy-setup] Updated Doxygen comments
- [Enrollee] Moved files from inc to src folder
(which are not exposed to developers)
Change-Id: I93c3703c39556a2673e034ede4890d1f4ef10b71
Signed-off-by: Jay Sharma <jay.sharma@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5871
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Jay Sharma [Mon, 14 Mar 2016 16:16:41 +0000 (21:46 +0530)]
[Easy-setup] Updated Unittest cases file
- Updated the UnitTest cases for Mediator RichSDK.
Change-Id: I1cb137ba826ca9681faaa9e81856bc74a10bc173
Signed-off-by: Jay Sharma <jay.sharma@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5887
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Ashwini Kumar [Mon, 14 Mar 2016 14:38:01 +0000 (20:08 +0530)]
Fix android run time to load ocprovision
- ocprovision has moved from static to shared lib
- build dependecncy for include file
Change-Id: I5d2ba0ecd506c3e3dfd15ff2670d2eb322de61e3
Signed-off-by: Ashwini Kumar <k.ashwini@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5885
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jon@joncruz.org>
Sandipan Patra [Mon, 14 Mar 2016 08:49:51 +0000 (14:19 +0530)]
[Arduino Due] Arduino wifi multicast defalut return value changed to CA_STATUS_OK
Change-Id: If7b28c30af4093771aee724356114ca5d4929cd4
Signed-off-by: Sandipan Patra <sandipan.p@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5849
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jon@joncruz.org>
Jay Sharma [Mon, 14 Mar 2016 12:21:05 +0000 (17:51 +0530)]
[Easy-Setup] Updated Doxygen and javadoc
- Updated Doxygen and javadoc updates for easysetup service based
on latest folder structure
Change-Id: I4a3d888fb30a6a334aba3d7cd5fe4ed019b2ed75
Signed-off-by: Jay Sharma <jay.sharma@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5825
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
G S Senthil Kumar [Fri, 11 Mar 2016 16:29:28 +0000 (21:59 +0530)]
Fix for klocwork issues.
This change includes fix for all klocwork reported issues
in native and java layer.
Change-Id: Ibba5d478e64251636c8ef514c52b9e9bd6f36442
Signed-off-by: G S Senthil Kumar <senthil.gs@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5749
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
leechul [Tue, 15 Mar 2016 05:34:34 +0000 (14:34 +0900)]
Revert back cbor related patches.
[Patch #1] Intial upload.
[Patch #2] Modify provisionig sample's SConscript to ignore sample codes in case of tizen.
* The json file will be copied in case of tizen.
[Patch #3] Remove the segmentation fault in debug mode.
[Patch #4] Modify the build script to not include security samples in case of tizen build.
[Patch #5] Revmoe the printf
Change-Id: I88b9b5b68bc641f219bcf0c26dbf1dd4c61ae177
Signed-off-by: leechul <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5897
Reviewed-by: Jongsung Lee <js126.lee@samsung.com>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Philippe Coval [Fri, 4 Mar 2016 23:51:05 +0000 (00:51 +0100)]
Fixed build issue by adding Builder contructor with const args
Problem was observed while building on Tizen:2.4:Mobile (g++ 4.9.2):
libresource_hosting.so: undefined reference to \
`OIC::Service::RCSResourceObject::Builder::Builder(std::string const&, std::string const&, std::string const&)'
This message appeared while building RHSampleApp using tizen-sdk 2.4.0 Rev4
with imported libs (built with gbs from Tizen:2.4:Mobile repo)
Change-Id: I3064b9e7234edcabbefe40b5e469413e72127fae
Origin: https://github.com/TizenTeam/iotivity/tree/sandbox/pcoval/for-upstream
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5575
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-by: Robert Spielmann <spielmann@kellendonk.de>
Jaewook Jung [Fri, 11 Mar 2016 08:00:22 +0000 (17:00 +0900)]
code clean up in caedrserver.c
In CAEDRNativeReadData(), getting a address string of the device is unnecessary
unless inputstream is available.
Change-Id: Ic1d363bc42eaeb948fe8f6ee5f4fddcec3d35086
Signed-off-by: Jaewook Jung <jw0213.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5721
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Jon A. Cruz <jon@joncruz.org>
Jaewook Jung [Fri, 4 Mar 2016 05:35:27 +0000 (14:35 +0900)]
removed warning in CA layer
Change-Id: Id7b89929a8497a041590b60e91f2ad33d51ce0c1
Signed-off-by: Jaewook Jung <jw0213.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5585
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jon@joncruz.org>
Jaewook Jung [Thu, 10 Mar 2016 05:03:27 +0000 (14:03 +0900)]
code clean up in cablockwisetransfer
code clean up and remove unnecessary code in cablockwisetransfer
Change-Id: I92836df67c3b5ec128915baad9936aedad176b53
Signed-off-by: Jaewook Jung <jw0213.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5667
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jon@joncruz.org>
jihwan.seo [Thu, 10 Mar 2016 08:29:14 +0000 (17:29 +0900)]
To get device name from scanned device for Android BLE.
Device name has to be included in advertise packet
after Android API 23.
Change-Id: I0379e1fc1d7675088739f07a47b0d0171e9f57eb
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5675
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jon@joncruz.org>
Randeep Singh [Fri, 4 Mar 2016 07:07:26 +0000 (12:37 +0530)]
Updated Address max size
Max array of size 40 is not adequate for storing address ipv6 address.
Thus increased the value from 40 to 56.
Change-Id: Icd63c11365cefc2576043c87ef54802b5028c971
Signed-off-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5411
Reviewed-by: Ashwini Kumar <k.ashwini@samsung.com>
Reviewed-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-by: Junghyun Oh <junghyun.oh@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
(cherry picked from commit
0185651214559e46eea4bc357332c296856789e5)
Reviewed-on: https://gerrit.iotivity.org/gerrit/5899
Philippe Coval [Mon, 7 Mar 2016 11:19:05 +0000 (12:19 +0100)]
Fixed build issue by including condition_variable header
Problem was observed while building on Tizen:2.4:Mobile (g++ 4.9.2):
error: 'condition_variable' in namespace 'std' does not name a type
std::condition_variable cond;
Change-Id: I03b03af4693738c6a852b0d03b6d6a2744a87109
Origin: https://github.com/TizenTeam/iotivity/tree/sandbox/pcoval/for-upstream
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5577
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Mats Wichmann <mats@osg.samsung.com>
Reviewed-by: Robert Spielmann <spielmann@kellendonk.de>
Reviewed-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>
jihwan.seo [Wed, 9 Mar 2016 12:28:12 +0000 (21:28 +0900)]
fixed initialization issue for connection state.
Change-Id: I16b02d35ae36feacb6472a73796cb1b9e24636bb
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5631
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
hyuna0213.jo [Tue, 8 Mar 2016 22:45:51 +0000 (07:45 +0900)]
Changed tcp adapter logic to process the received data directly.
Currently If new connection is created with remote device, received
first data from remote device can be processed after select timeout.
because select() is blocking function. so I added connection file
descriptor to update read file descriptor list after receiving
connection event.
Change-Id: I26d1ee95b3c252194c38d47490b972193e693e77
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5569
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jon@joncruz.org>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5731
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>
Jihun Ha [Fri, 11 Mar 2016 01:48:28 +0000 (10:48 +0900)]
Update a resource type of SceneMember resource
The current public OIC spec.(v0.9.9) has introduced the resource type,
wrongly. It would be "oic.wk.scenemember".
Change-Id: I768c086f75f0bf281558e582cdee264ddc16709c
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5697
Reviewed-by: JungYong KIM <jyong2.kim@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Philippe Coval [Mon, 7 Mar 2016 11:05:12 +0000 (12:05 +0100)]
Fixed build issue by including condition_variable header
Problem was observed while building on Tizen:2.4:Mobile (g++ 4.9.2):
error: 'condition_variable' in namespace 'std' does not name a type
std::condition_variable cond;
Change-Id: Ieaff9bb24e0dd44e6660c7e2ac2d5d718e4270e2
Origin: https://github.com/TizenTeam/iotivity/tree/sandbox/pcoval/for-upstream
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5579
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Mats Wichmann <mats@osg.samsung.com>
Reviewed-by: Sanjeev BA <as2902.b@samsung.com>
Reviewed-by: JungHo Kim <jhyo.kim@samsung.com>
Jihun Ha [Fri, 11 Mar 2016 07:47:13 +0000 (16:47 +0900)]
Add required header file in sceneserver and sceneclient
I've added condition_variable header file because it is required
for some compilers.
Change-Id: I68655e613a10b3c8941fd743651d304999272160
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5715
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: JungHo Kim <jhyo.kim@samsung.com>
jaesick.shin [Thu, 10 Mar 2016 01:56:45 +0000 (10:56 +0900)]
Added Unittests and Added LICENSE
Generate response test(Actuator Interface, Custom Interface)
InterfaceHandler.cpp file not contains LICENSE
Added LICENSE
Change-Id: I034f43f6524ed630ed806173ffa3db267308dec5
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5657
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: JungHo Kim <jhyo.kim@samsung.com>
Jee Hyeok Kim [Fri, 11 Mar 2016 07:57:26 +0000 (16:57 +0900)]
Remove broken validation check logic
If requestUri contains host string like 'coap+tcp://127.0.0.1:5683',
This function also adds host length to validate
regardless it is not affect packet size.
Change-Id: Id053ba6959181311d36d26a4b1a2853fb2e1af7d
Signed-off-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5717
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Sandipan Patra [Wed, 9 Mar 2016 08:34:31 +0000 (14:04 +0530)]
[Tizen Secure Mode] Tizen enrollee build using security mode enabled
Change-Id: I5a4d91e5e56863a9a859f681202f52828207a00a
Signed-off-by: Sandipan Patra <sandipan.p@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5611
Reviewed-by: Jon A. Cruz <jon@joncruz.org>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Jee Hyeok Kim [Fri, 11 Mar 2016 07:41:30 +0000 (16:41 +0900)]
Update cloud project
1. Add Testcases for each projects.
2. Fix coap encoder to correctly reference accept flag
3. Modify native sample application to use csdk
Change-Id: I0697341fe6e927c679d8d4b4f0e07275f28e86fb
Signed-off-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5713
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Jee Hyeok Kim [Thu, 10 Mar 2016 05:43:33 +0000 (14:43 +0900)]
Fix main buildscript build order
1. Current plugins project changes main global env variable.
So switch Cloud sample build order prior to plugins project
2. Change Cloud sample output not to copied to main output folder.
Change-Id: If9a5d66e5606bdbc4a37864e7ff1cc001877489d
Signed-off-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5605
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Habib Virji [Sun, 21 Feb 2016 20:26:04 +0000 (20:26 +0000)]
Doxm payload conversion from JSON to CBOR
- Updates return type to OCStackResult and parameters as part of the conversion function.
- Changes in ownership transfer to return uint8_t instead of chari for payload conversion.
- security_internals includes function which are used in the testing.
- Unit test is updated to match the changes in conversion.
Change-Id: I088d75d67d8520e853db9b14fc802e3b31481e8b
Signed-off-by: Habib Virji <habib.virji@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5096
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5797
Habib Virji [Tue, 16 Feb 2016 16:07:11 +0000 (16:07 +0000)]
Security code comments which are doxygen compliant
Some file using comments similar to doxygen changed.
Comments has been updated to used return instead of retval.
Comments having in/out tags has been updated.
Some functions missing space after keyword has been updated.
Change-Id: I0e9b75d2f75576f992d0ff4bafeaf5ba16917cc6
Signed-off-by: Habib Virji <habib.virji@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5027
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5757
Habib Virji [Mon, 22 Feb 2016 16:04:11 +0000 (16:04 +0000)]
CRED payload conversion from JSON to CBOR
Converts CRED payload from JSON to CBOR directly using tinycbor library.
- CRED unit test has been updated to handle the changes.
- Unit test related functions are defined in security_internals.
- Parameter which were passed as char * has been converted to uint8_t as they were later converted to base64.
- All the usage and base64 has been removed.
Change-Id: I159d46f8500c1880b49a3acbcfc59cfa0c6da4f0
Signed-off-by: Habib Virji <habib.virji@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5117
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5793
Philippe Coval [Mon, 7 Mar 2016 14:48:13 +0000 (15:48 +0100)]
Fixed build issue by Installing missing header OCUtilities.h
Change-Id: Icc5313c48ef95b322526eea169c4b23eab3758a6
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5581
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Mats Wichmann <mats@osg.samsung.com>
Reviewed-by: Habib Virji <habib.virji@samsung.com>
Habib Virji [Fri, 19 Feb 2016 00:42:03 +0000 (00:42 +0000)]
AMACL payload conversion from JSON to CBOR
Converts AMACL payload conversion from JSON to CBOR directly using tinycbor library.
- Amacl unit test is updated to match new changes.
- Data file are updated to handle new format.
Change-Id: I80e56f182f3f516025977e26fa5d719058832fd8
Signed-off-by: Habib Virji <habib.virji@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5053
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5777
Habib Virji [Thu, 18 Feb 2016 15:24:29 +0000 (15:24 +0000)]
Pstat payload conversion from JSON to CBOR
Converts Pstat payload conversion from JSON to CBOR directly using tinycbor library.
- Pstat unit test is updated to match new changes.
- Fixes bug in psinterface to move to the next element.
- ocpayloadparse.c, is updated to include bytestring or cjson depending on the message contents.
- Pstat format: {"isop": <0/1>, "deviceid":<bytestring>, "ch": <int>, "cm": <int>, "om": <int>, "tm": <int>, sm:[<int>, <int>] }.
- Persistant storage format: { "acl": <aclcbor>, "pstat": <pstatcbor> }
Change-Id: I29a92bbf0f24d82612b8795b86119863c4a1905b
Signed-off-by: Habib Virji <habib.virji@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5045
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5775
Randeep Singh [Sat, 12 Mar 2016 12:58:38 +0000 (18:28 +0530)]
Resolved Arduino build error
Change-Id: Id517f81c8a01db9e873c330b9449fa1e77afae95
Jira: https://jira.iotivity.org/browse/IOT-985
Signed-off-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5773
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Habib Virji <habib.virji@samsung.com>
Habib Virji [Thu, 18 Feb 2016 20:18:33 +0000 (20:18 +0000)]
SVC payload conversion from JSON to CBOR
Converts SVC payload conversion from JSON to CBOR directly using tinycbor library.
- SVC unit test is updated to match new changes.
- Persistant storage format: { "acl": <aclcbor>, "svc": <svccbor> }
Change-Id: I1a5b5600260b8965e468844636f6d77274688d29
Signed-off-by: Habib Virji <habib.virji@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5047
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5771
Habib Virji [Sun, 20 Dec 2015 23:44:41 +0000 (23:44 +0000)]
ACL payload conversion from JSON to CBOR
Converts ACL payload conversion from JSON to CBOR directly using tinycbor library.
- It includes a new interface for psinterface to update persistant storage to write CBOR instead of JSON.
- Includes a new interface to read file from cbor and pass to Init functions.
- Also removes base64 conversion for device id field.
- OCConvert payload is updated to send uint8_t payload instead of JSON payload string.
- ACL Unit test is updated to match new changes.
- New file unittest.h is added to pass functions from testing purpose.
- Data file are updated to handle new format.
- ACL format: [{"sub": <byteString>, "rsrc":[<string>, ..], prms: <uint64_t>, ownrs: [<byteString>,..]}. ..]
- Persistant storage format: { "acl": <aclcbor>, ... }
Change-Id: I125eb3291342c49cc4335ee3a1327a02b88952ba
Signed-off-by: Habib Virji <habib.virji@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4669
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5755
hekra [Thu, 10 Mar 2016 01:58:19 +0000 (17:58 -0800)]
[IOT-972] add type and interface to platform representation
Change-Id: Ie02a201507ffcc0c6a640846dc57341832ea3158
Signed-off-by: Hugues Ekra <hekra@cisco.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5655
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Habib Virji <habib.virji@samsung.com>
Habib Virji [Thu, 10 Mar 2016 17:59:51 +0000 (17:59 +0000)]
[IOT-914] Change format of the device id as text string
DI field was being sent as a byte string over ther wire.
This patch update it to be sent as a string.
ocpayloadparse.c can handle both byte string and text string.
But ocpayloadconvert.c will be sending in text string.
Jira Issue: IOT-914
Signed-off-by: Habib Virji <habib.virji@samsung.com>
Change-Id: I049bf4cff5f2b390e589eb5cf55966e8034838b1
Reviewed-on: https://gerrit.iotivity.org/gerrit/5691
Reviewed-by: Dwarkaprasad Dayama <dwarka.dayama@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Habib Virji [Thu, 10 Mar 2016 12:03:42 +0000 (12:03 +0000)]
[IOT-979] Correct /oic/d icv field
Currently icv [Spec Version] field was being set as lcv instead of icv.
Change-Id: I3e4930cba42f5474f90f622b28c031a03331053e
Signed-off-by: Habib Virji <habib.virji@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5685
Reviewed-by: Dwarkaprasad Dayama <dwarka.dayama@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Joonghwan Lee [Thu, 10 Mar 2016 05:57:03 +0000 (14:57 +0900)]
Add direct-pairing feature
<contents of modification/addition>
: Added direct-pairing resouces and related types
: Added direct-pairing provisioning feature for provisioning tool
: Added D2D pairing operation feature(discovery, pairing) for client
: Added RI layer APIs and data types for direct-pairing client
: Modified provisioning tool for direct-pairing feature and created new sample client
-Patch 1: Initial
-Patch 2: Fix OSX build error.
-Patch 3: Add DPC(Direct Pairing Capability) resource and processing logic
-Patch 4: Fix dpc parse error when loading svr db
-Patch 5: Fix unnormal processing when duplicated request on dpairing resource & Change DPC default value as true
-Patch 6: Fix SVACE warning & Divide pconf and dpairing resource into another ACL entry in svr db
-Patch 7: Fix SVACE warning's positive false
-Patch 8: Fix device list management
Change-Id: I461626fe041a5927c0e27e78e63e74e215d61cd5
Signed-off-by: Joonghwan Lee <jh05.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5673
Reviewed-by: Jongsung Lee <js126.lee@samsung.com>
Reviewed-by: Kyungsun Cho <goodsun.cho@samsung.com>
Reviewed-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Tested-by: Randeep Singh <randeep.s@samsung.com>
leechul [Fri, 11 Mar 2016 04:21:27 +0000 (13:21 +0900)]
Remove the compile errors for arduino.
If we use 'goto' on arduino.
We should initialize variable before the 'goto'.
Change-Id: I06bc47dcfece26ad5d5bde7e71e0f57473310d5a
Signed-off-by: leechul <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5705
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Tested-by: Randeep Singh <randeep.s@samsung.com>
jihwan.seo [Thu, 10 Mar 2016 13:19:15 +0000 (22:19 +0900)]
fixed wrong waiting for scanned device.
when scanning is waiting for target device for unicast.
there is no delay time in previous logic.
so send was failed
Change-Id: I8b7d3b71e462434d1f31f273c5b2dcbb5e0e9f28
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5689
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jon@joncruz.org>
koushik.girijala [Tue, 8 Mar 2016 06:03:29 +0000 (11:33 +0530)]
Fix for Klockwork issues
Fixed issues reported in Klockwork run
Change-Id: Icc1fb0d2d0e3aa9662fa50e17d2d821e8407c4a4
Signed-off-by: koushik.girijala <g.koushik@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5663
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Jon A. Cruz <jon@joncruz.org>
Philippe Coval [Mon, 7 Mar 2016 10:58:19 +0000 (11:58 +0100)]
Fixed build issue by implicitly capture by reference (of Scene)
Problem was observed while building on Tizen:2.4:Mobile (g++ 4.9.2):
error: capture of non-variable 'OIC::Service::Scene::m_name'
[&actions, &m_name](const SceneMemberResource::Ptr& member)
Futher explanation from Thiago Macieira <thiago.macieira@intel.com> :
Looking up the C++ standard, it says that :
"An entity that is designated by a simple-capture [...]
shall be this or a variable with automatic storage duration".
That means you cannot capture non-static members by name and you
have to capture the whole object.
Using [&] accomplishes capturing of "this".
Change-Id: Id9db9ca55b858b5c39cee48a5eb9b25ad9e59b41
Origin: https://github.com/TizenTeam/iotivity/tree/sandbox/pcoval/for-upstream
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5573
Reviewed-by: Robert Spielmann <spielmann@kellendonk.de>
Reviewed-by: Mats Wichmann <mats@osg.samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Habib Virji <habib.virji@samsung.com>
Jaewook Jung [Mon, 7 Mar 2016 10:40:28 +0000 (19:40 +0900)]
fixed an issue there is no check null for connection manager.
Change-Id: I6cdde605bce31634cb80073ec28239edf4f72ceb
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Signed-off-by: Jaewook Jung <jw0213.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5589
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Jon A. Cruz <jon@joncruz.org>
jihwan.seo [Wed, 9 Mar 2016 00:58:18 +0000 (09:58 +0900)]
clean up for android BLE client
- release variable related to JNI
- terminate Glabal variable
- add some comment
Change-Id: I342a7fd9a8550d0a3c2bf139254e5a147e2dd4dc
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5591
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jon@joncruz.org>
jihwan.seo [Thu, 10 Mar 2016 05:18:47 +0000 (14:18 +0900)]
clean global variables for connection manager
Change-Id: I595d2fc6c92939a4b4d048e0f0eb97db3d903db1
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5669
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jon@joncruz.org>
hyuna0213.jo [Wed, 9 Mar 2016 05:25:23 +0000 (14:25 +0900)]
Removed unnecessary/duplicated code in connectivity abstraction
remove unnecessary/duplicated code in connectivity abstraction
to increase unit tc coverage
Change-Id: I3ddb28ed1f0a319a2e2f6ff0bb1de7fa95cf2741
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5607
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jon@joncruz.org>
jaesick.shin [Tue, 8 Mar 2016 03:09:48 +0000 (12:09 +0900)]
RE ServerBuilder always included "oic.if.baseline" interface.
If User don't setting "oic.if.baseline" interface.
but, RE ServerBuilder always support "oic.if.baseline" interface.
setDefaultInterface API(Modified comment of header) and Modified Initialize of Builder Constructor
If it is not called, the interface passed to the constructor is the default.
Added, Duplicate check the resource property of interface and resourcetype.
Change-Id: Ie25f1135cc7c99fbf5fe1b04f3121b9e2707be21
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5529
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
(cherry picked from commit
6768956d2bdbf81f1180caf137e246d877ef1992)
Reviewed-on: https://gerrit.iotivity.org/gerrit/5647
Minji Park [Tue, 8 Mar 2016 08:55:59 +0000 (17:55 +0900)]
add doxygen comments for exceptions in Scene-manager remote apis
- add doxygen comments in scene-manager remote apis
- change to use const variable in scenecommons with get request in RemoteSceneList class
Change-Id: I3354b7c271962be8d22f226a663e5cc415c8f211
Signed-off-by: Minji Park <minjii.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5545
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
(cherry picked from commit
5f95d30eb6f7e7a00675a74ac2dd348e5d5c53e4)
Reviewed-on: https://gerrit.iotivity.org/gerrit/5649
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Markus Jung [Wed, 9 Mar 2016 09:53:06 +0000 (18:53 +0900)]
IOT-945: Fixing segmentation fault issue
- Using smart pointers for managing bundles
- Changing APIs to use smart pointers
NOTE: this patch breaks backward compatibility with previous APIs
Change-Id: Ibeb833c3a0381856ca96747404302ae4bc308a39
Signed-off-by: Markus Jung <markus.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5661
Reviewed-by: Inga Stotland <inga.stotland@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: JungHo Kim <jhyo.kim@samsung.com>
leechul [Wed, 9 Mar 2016 09:57:28 +0000 (18:57 +0900)]
Modify to update default ACL of security resource
after ownership transfer is successfully completed.
Current default ACL of security resource can make a access permission issues.
If we do not update defualt ACL, anonymous user can access security resource.
For this reason, If ownership trnasfer is successfully completed,
the securiy resource ACL should be updated as follows:
{
"sub":"Kg==",
"rsrc":[
"/oic/sec/doxm",
"/oic/sec/pstat"
],
"perms":2,
"ownrs":[
"cmFuZG9tUGluRGV2VVVJRA=="
]
},
In order to resolve this issues,
I've modified SRM to update security resource ACL
when 'owned' property of doxm is changed as 'true'.
[Patch #1] Intial upload
[Patch #2] Remove compile errors
[Patch #3] Update comments in source code.
[Patch #4] Update comment in source code.
[Patch #5] Retrigger
[Patch #6] Fix the bug which is occurred due to operator precedence.
[Patch #7] Remove default ACL provisioning step in ownership transfer.
Change-Id: Ia5eb62693168788cf1a607bb95ce97a44ce5b15d
Signed-off-by: leechul <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5625
Reviewed-by: Kyungsun Cho <goodsun.cho@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Tested-by: Randeep Singh <randeep.s@samsung.com>
hyuna0213.jo [Mon, 7 Mar 2016 06:35:36 +0000 (15:35 +0900)]
Changed the /oic/ping resource registration condition
In order to register /oic/ping resource in case host is not client,
I modified the keepalive init/terminate logic.
Change-Id: I29c42249b5af9363517bde971b74e8f80e8fbaa4
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5571
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>
HyunJun Kim [Tue, 8 Mar 2016 23:16:49 +0000 (08:16 +0900)]
Add collection payload to send a request
for including each resource information(attributes).
- Client side can send a message
which each resource information is stored in one message.
Change-Id: I45a65dc66dfcec9288b858864b6c83906d341756
Signed-off-by: HyunJun Kim <hyunjun2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5583
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Habib Virji <habib.virji@samsung.com>
Jee Hyeok Kim [Thu, 10 Mar 2016 06:07:33 +0000 (15:07 +0900)]
Fix rdpayload initial condition.
If rdpayload contains no variable of each attribute,
This function always returns fail.
So change that accepts empty variable.
Change-Id: Ic2827396d6894f00ce9de94b7924614b9f605f6b
Signed-off-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5671
Reviewed-by: Habib Virji <habib.virji@samsung.com>
Jihun Ha [Wed, 9 Mar 2016 05:15:28 +0000 (14:15 +0900)]
Update a CBOR parser logic for well-known keywords to OIC
I've updated a CBOR parsing logic When CBOR parser encounters a well-known
keyword like "href" as an attribute.
If the attribute is *NOT* on the outermost representation bracket, it is
treated as a normal attribute.
Change-Id: I1f1c28dd59ae09e1f3f8ab0188c59a1b9fc3b950
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5623
Reviewed-by: Habib Virji <habib.virji@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
js126.lee [Thu, 10 Mar 2016 02:03:02 +0000 (11:03 +0900)]
Fixed defects reported by svace in SRM
- Patch #1 : Init patch
- Patch #2 : Modify file permission
- Patch #3 : Update doxmresource.c
- Patch #4 : fix defects
- Patch #5 : Apply the review comment of Mr. Cho
- Patch #6 : Apply the review comment of Mr. Chul Lee.
Change-Id: I7c1ffb65bed604adbee60ee55456f230b83a759c
Signed-off-by: js126.lee <js126.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5653
Reviewed-by: Kyungsun Cho <goodsun.cho@samsung.com>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Tested-by: Randeep Singh <randeep.s@samsung.com>
leechul [Wed, 9 Mar 2016 08:55:52 +0000 (17:55 +0900)]
Modify CBOR parser and convertor to handle security payload correctly.
[Patch #1] Intial upload.
[Patch #2] Update according to review comments.
[Patch #3] Fix typo
[Patch #4] Retrigger
[Patch #5] Remove the invalid type conversion.
Change-Id: I7b1d59d16a48a083d589715ec876d3eb860b921d
Signed-off-by: leechul <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5613
Reviewed-by: Habib Virji <habib.virji@samsung.com>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Dmitriy Zhuravlev [Wed, 9 Mar 2016 17:22:09 +0000 (19:22 +0200)]
Fix defects reported by SVACE in ckm unittests
Change-Id: I68d86ed516dad5492d8b0028d28f460612b8775e
Signed-off-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5437
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit
755ef54828f4e7744b121219b4c259293e748665)
Reviewed-on: https://gerrit.iotivity.org/gerrit/5677
Tested-by: Randeep Singh <randeep.s@samsung.com>
Ashwini Kumar [Thu, 3 Mar 2016 11:05:16 +0000 (16:35 +0530)]
Fix static analysis issues in PM
Change-Id: I1a079333d7636b52f8ae9d4ab0609656a5395278
Signed-off-by: Ashwini Kumar <k.ashwini@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5351
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit
ec7970e13558ba77a7df89830c95969c3155e261)
Reviewed-on: https://gerrit.iotivity.org/gerrit/5665
Tested-by: Randeep Singh <randeep.s@samsung.com>
i.pazderskyy [Wed, 9 Mar 2016 11:59:12 +0000 (13:59 +0200)]
Fix issues reported by SVACE tool in CKM module 2
Change-Id: Ied98d297287e3e1dad6bc51b19889c6647e097b9
Signed-off-by: i.pazderskyy <i.pazderskyy@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5627
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Tested-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit
f4a9bcabc5e28cbc63ff1dfb4fb727afc3949703)
Reviewed-on: https://gerrit.iotivity.org/gerrit/5639
Kyungsun Cho [Wed, 9 Mar 2016 09:41:41 +0000 (18:41 +0900)]
Fixed bugs reported SVase checking on |provisioningclient|
Change-Id: I7f0c7fc2ecd6f1fa410f40fbe96dc3226531e92c
Signed-off-by: Kyungsun Cho <goodsun.cho@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5621
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Tested-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit
a88c448621f464b32fec5cf6cb14a3ed383eb76a)
Reviewed-on: https://gerrit.iotivity.org/gerrit/5637
projects / platform / upstream / iotivity.git / log