Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6

Change-Id: If63af4526f72fc1f214b60c4c9d891718bf2b440

Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5

Change-Id: I768331416f61a0a76c6bff504e0fedd545080f22

Merge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/vulkan-cts-1.2.4

Change-Id: I9ac48fcdfe6e253139ccde50371b9dbfa31ce437

Merge vk-gl-cts/vulkan-cts-1.2.2 into vk-gl-cts/vulkan-cts-1.2.3

Change-Id: I9a085c6867ee119951a839b0d5eecb7fcf351029

Merge vk-gl-cts/vulkan-cts-1.2.1 into vk-gl-cts/vulkan-cts-1.2.2

Change-Id: I575ea750c7a89ec9f8306537a4bc3f7fbb64a619

Revert "Remove too long ray_tracing.build tests"

This reverts commit 6e14c25f5d049cb0dadebdd8a48392721b8a4d0b.

This reinstates long ray_tracing.build tests

VK-GL-CTS Issue: 2896

Components: Vulkan

Change-Id: I1b0ecaa3eeb63f5ca82d7bffe790979e21d08b7c
Affects: dEQP-VK.ray_tracing_pipeline.build.*

Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6

Change-Id: Ice572c5618871869c8dfea2d78f9d02b8125fc9c

Fix inconsistent ray payloads in RT barrier tests

Ray payload declarations (outgoing and incoming) were not consistent
across all ray shader stages in the ray tracing pipeline barrier tests.

In addition, this commit fixes payload and callable data names to make
it clear they are not used.

Affected tests:
dEQP-VK.ray_tracing_pipeline.barrier.*

VK-GL-CTS issue: 2900
Components: Vulkan

Change-Id: If764cf3cde9effb5868a7c03a0b2200cf9d90cb8

Fixes image sparse tests

Tests use sparseImageLoadARB in shader
but not checking for sparse_residency

Components: Vulkan
VK-GL-CTS Issue: 2913

Affects:
dEQP-VK.image.mismatched_formats.sparse_image_read*

Change-Id: I6896c7cec530a69be8ea172205d9155ff71873f9

Fix crash issue when AHB extension is not supported

The Ahb test doesn't check if the vulkan extension
VK_ANDROID_external_memory_android_hardware_buffer is supported and
called AHB function directly, then it crashes when the extension is not
supported.
This patch will let the test first check if this extension is supported.

Affects:

dEQP-VK.draw.ahb.*

Components: Vulkan

VK-GL-CTS issue: 2915

Change-Id: Id470caef3e034f10d08cfa3bad6e9ec705104b53

Fixes sparse image padding tests

Tests were attempting to verify the
values inside the padding X bits of
formats like 10x6, where spec says
they are undefined.

Components: Vulkan
VK-GL-CTS Issue: 2916

Affects:
dEQP-VK.sparse_resources.image_sparse_binding.2d*

Change-Id: Ic785fba111ecebb5a030673642b78872c404d925

Fixes for robust buffer with variable pointer tests

This commit fixes several issues with robust buffer access with variable
pointers tests:

* The variable pointer tests were checking support for the
  variablePointersStorageBuffer feature but they weren't actually
  activating the feature when creating the robust buffer access device.

* Support checks were being done at instance creation time instead of
  using the proper checkSupport method.

* In-bound checks for 64-bit format accesses were only checking 4 out of
  every 8 bytes in the buffer.

* The verification routines were not taking into account 64-bit
  nonatomic accesses could be legally split into two 32-bit accesses
  that could be checked independently.

* The possibility of satisfying a (0,0,0,x) pattern in output data was
  not being checked correctly for 64-bit formats, always using 32-bit
  vectors and values.

Affected tests:
dEQP-VK.robustness.buffer_access.*
dEQP-VK.robustness.vertex_access.*

Components: Vulkan
VK-GL-CTS issue: 2908

Change-Id: I85aeb085cb31d63b70acec08551c53fcc7d2be3c

Fixes fragment density map tests

Multiview extension struct being passed to
render pass 2 is not valid. Need to use
viewMask in the render pass 2 structs instead.

Components: Vulkan
VK-GL-CTS Issue: 2899

Affects:
dEQP-VK.renderpass2.fragment_density_map.*

Change-Id: Ieedaacae4fe7ba6d3c222610d96f1785fa01719a

Sync master and vulkan-cts-1.2.6 headers

Components: Vulkan

Change-Id: I7865f441d2d987f8126e1e8542a494c90fe5b45c

Allow Vulkan CTS 1.2.6.1

Affects: dEQP-VK.api.driver_properties.properties

Components: Vulkan

Change-Id: I40bad2fda3a901a164b5e9e738e27d39776f028c

Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6

Change-Id: I558d95e4d43099527b53f45a6aef6e0c66d93fc4

Remove too long ray_tracing.build tests

The tests have too large runtime (up to 1h20m per
single test case) due to large AS being built on the
host.

VK-GL-CTS Issue: 2896

Components: Vulkan

Affects: dEQP-VK.ray_tracing_pipeline.build.*

Change-Id: Ib298b18967ed76d79bd150ac53d90d36332adc60

Add new tests for VK_EXT_extended_dynamic_state2

Components: Vulkan

New Tests:

dEQP-VK.pipeline.extended_dynamic_state.cmd_buffer_start.depth_bias_enable
dEQP-VK.pipeline.extended_dynamic_state.cmd_buffer_start.depth_bias_disable
dEQP-VK.pipeline.extended_dynamic_state.before_draw.depth_bias_enable
dEQP-VK.pipeline.extended_dynamic_state.before_draw.depth_bias_disable
dEQP-VK.pipeline.extended_dynamic_state.between_pipelines.depth_bias_enable
dEQP-VK.pipeline.extended_dynamic_state.between_pipelines.depth_bias_disable
dEQP-VK.pipeline.extended_dynamic_state.after_pipelines.depth_bias_enable
dEQP-VK.pipeline.extended_dynamic_state.after_pipelines.depth_bias_disable
dEQP-VK.pipeline.extended_dynamic_state.before_good_static.depth_bias_enable
dEQP-VK.pipeline.extended_dynamic_state.before_good_static.depth_bias_disable
dEQP-VK.pipeline.extended_dynamic_state.two_draws_dynamic.depth_bias_enable
dEQP-VK.pipeline.extended_dynamic_state.two_draws_dynamic.depth_bias_disable
dEQP-VK.pipeline.extended_dynamic_state.two_draws_static.depth_bias_enable
dEQP-VK.pipeline.extended_dynamic_state.two_draws_static.depth_bias_disable
dEQP-VK.pipeline.extended_dynamic_state.cmd_buffer_start.enable_raster
dEQP-VK.pipeline.extended_dynamic_state.cmd_buffer_start.disable_raster
dEQP-VK.pipeline.extended_dynamic_state.before_draw.enable_raster
dEQP-VK.pipeline.extended_dynamic_state.before_draw.disable_raster
dEQP-VK.pipeline.extended_dynamic_state.between_pipelines.enable_raster
dEQP-VK.pipeline.extended_dynamic_state.between_pipelines.disable_raster
dEQP-VK.pipeline.extended_dynamic_state.after_pipelines.enable_raster
dEQP-VK.pipeline.extended_dynamic_state.after_pipelines.disable_raster
dEQP-VK.pipeline.extended_dynamic_state.before_good_static.enable_raster
dEQP-VK.pipeline.extended_dynamic_state.before_good_static.disable_raster
dEQP-VK.pipeline.extended_dynamic_state.two_draws_dynamic.enable_raster
dEQP-VK.pipeline.extended_dynamic_state.two_draws_dynamic.disable_raster
dEQP-VK.pipeline.extended_dynamic_state.two_draws_static.enable_raster
dEQP-VK.pipeline.extended_dynamic_state.two_draws_static.disable_raster
dEQP-VK.pipeline.extended_dynamic_state.cmd_buffer_start.logic_op_or
dEQP-VK.pipeline.extended_dynamic_state.before_draw.logic_op_or
dEQP-VK.pipeline.extended_dynamic_state.between_pipelines.logic_op_or
dEQP-VK.pipeline.extended_dynamic_state.after_pipelines.logic_op_or
dEQP-VK.pipeline.extended_dynamic_state.before_good_static.logic_op_or
dEQP-VK.pipeline.extended_dynamic_state.two_draws_dynamic.logic_op_or
dEQP-VK.pipeline.extended_dynamic_state.two_draws_static.logic_op_or
dEQP-VK.pipeline.extended_dynamic_state.cmd_buffer_start.prim_restart_enable
dEQP-VK.pipeline.extended_dynamic_state.before_draw.prim_restart_enable
dEQP-VK.pipeline.extended_dynamic_state.between_pipelines.prim_restart_enable
dEQP-VK.pipeline.extended_dynamic_state.after_pipelines.prim_restart_enable
dEQP-VK.pipeline.extended_dynamic_state.before_good_static.prim_restart_enable
dEQP-VK.pipeline.extended_dynamic_state.two_draws_dynamic.prim_restart_enable
dEQP-VK.pipeline.extended_dynamic_state.two_draws_static.prim_restart_enable
dEQP-VK.pipeline.extended_dynamic_state.cmd_buffer_start.patch_control_points
dEQP-VK.pipeline.extended_dynamic_state.before_draw.patch_control_points
dEQP-VK.pipeline.extended_dynamic_state.between_pipelines.patch_control_points
dEQP-VK.pipeline.extended_dynamic_state.after_pipelines.patch_control_points
dEQP-VK.pipeline.extended_dynamic_state.before_good_static.patch_control_points
dEQP-VK.pipeline.extended_dynamic_state.two_draws_dynamic.patch_control_points
dEQP-VK.pipeline.extended_dynamic_state.two_draws_static.patch_control_points

Change-Id: I0c95f38c90bb411ea6e801885d11fbd931fdbe84
(cherry picked from commit 03816ca23aa419f73d87ee5830a5bf9f903bc226)

Vulkan CTS coverage for VK_EXT_ycbcr_2plane_444_formats

This extension adds a few new 2-plane 444 YCbCr formats:
VK_FORMAT_G8_B8R8_2PLANE_444_UNORM_EXT
VK_FORMAT_G10X6_B10X6R10X6_2PLANE_444_UNORM_3PACK16_EXT
VK_FORMAT_G12X4_B12X4R12X4_2PLANE_444_UNORM_3PACK16_EXT
VK_FORMAT_G16_B16R16_2PLANE_444_UNORM_EXT

This CL extends existing YCbCr coverage to include these new formats.
In most cases the tests leverage vkGetPhysicalDeviceImageFormatProperties
to determine whether the format is supported and what image properties
it supports.

New tests:

dEQP-VK.*2plane_444*

Affects:

dEQP-VK.api.info.format_properties.*
dEQP-VK.api.info.image_format_properties.*
dEQP-VK.api.info.image_format_properties2.*
dEQP-VK.sparse_resources.*
dEQP-VK.ycbcr.*
dEQP-VK.protected_memory.interaction.ycbcr.*

Change-Id: I7b86ea1db14a953213e5277e87f274efb794d350
Components: Vulkan
(cherry picked from commit 81cc90f3eff3e224bb7c862c67a5a1b7ed6a9148)
(cherry picked from commit 5ec7dba1fbcf14b8dacdf47b9c715b9a22f6b897)

Add missing memory barrier between device transfer write and host read

The tests are missing a barrier between buffer being written by transfer operation
on device and reading the buffer contents on host.

Some tests were not missing this barrier, but the access flags were not reflecting
the dependency.

Components: Vulkan

VK-GL-CTS Issue: 2894

Affects:
dEQP-VK.ray_query.*
dEQP-VK.ray_tracing.*

Change-Id: I3e90e53f7db2a885805bd95d5f6033468ff8a927

Move the hit counting from any hit to closest hit shader stage

Fix the counting of ray hits by moving it from any hit to closest hit shader,
as any hit shader may execute multiple times per geometry - what may happen
because triangle primitives are arranged into grid of cubes.

VK-GL-CTS Issue: 2890

Affects: dEQP-VK.ray_tracing_pipeline.misc.*stress*

Change-Id: Id7e10181d15f99685c2997003dd579ab735dc4ee
Components: Vulkan

Use actual pipeline recursion depth when computing stack size

Use the maximum recursion depth as set in the used pipeline,
rather than the maximum recursion depth supported by a physical
device to avoid overflowing uint32 when computing the dynamic
stack size and/or creating exceptionally large stack, not needed by
the pipeline used in this test.

Components: Vulkan

Affects: dEQP-VK.ray_tracing_pipeline.misc.callableshaderstress*

VK-GL-CTS Issue: 2880

Change-Id: Ia4feee82099d34300c70af8eab13245d29d037d9

Tests for VK_EXT_color_write_enable

Tests new pipeline state pColorWriteEnables, in new struct
VkPipelineColorWriteCreateInfoEXT, chained off of
VkPipelineColorBlendStateCreateInfo. Also the corresponding new dynamic
state VK_DYNAMIC_STATE_COLOR_WRITE_ENABLE_EXT and
vkCmdSetColorWriteEnableEXT.

New tests:

dEQP-VK.pipeline.color_write_enable.*

Components: Vulkan
VK-GL-CTS issue: 2823

Change-Id: I07e6d47e647b319b14e6a50d2feb2700b2bab24e
(cherry picked from commit dcd384bb52a4ac8fc68d52f4a82f14941ba5b277)
(cherry picked from commit 520a31980be30c559a55af8985194be5028cef18)

Tests for VK_EXT_vertex_input_dynamic_state

This CL expands the existing dEQP-VK.pipeline.extended_dynamic_state.*
tests to also include coverage for the vertex input pipeline state
being dynamic. The new vertex_input tests utilize the same
extended_dynamic_state test framework which verifies all combinations
of setting the dynamic state before and after the static pipeline
state works correctly.

New tests:

dEQP-VK.pipeline.extended_dynamic_state.*.vertex_input

Affects:

dEQP-VK.pipeline.extended_dynamic_state.*

Components: Vulkan

VK-GL-CTS issue: 2610

Change-Id: I669f60ddec743571d9e3eff1120f0112a829ecb7
(cherry picked from commit 92aa842b6fd13ba0fdfea9a0fe07577816815d31)
(cherry picked from commit 416ab7627b21e1938b88045f6d4a79b3c2fe8971)

Add VK_NV_inherited_viewport_scissor tests

Components: Vulkan AOSP

New tests:

dEQP-VK.dynamic_state.inheritance.baseline
dEQP-VK.dynamic_state.inheritance.primary
dEQP-VK.dynamic_state.inheritance.secondary
dEQP-VK.dynamic_state.inheritance.split
dEQP-VK.dynamic_state.inheritance.primary_with_count
dEQP-VK.dynamic_state.inheritance.secondary_with_count

Change-Id: I39177c2e8b58c3ff25028ddcd8fca330aac25a9c
(cherry picked from commit 5a05fa25b8df2d807f59ef3f5561706539439f27)
(cherry picked from commit 2ddddcba017b028ccd655f7d9ec715d3b56ad9db)

Reduce the number of RayQueryExt objects allocated in shader

This reduces number of RayQueryExt object allocated simultanously
in shader, to avoid running out of memory of local variables.

Components: Vulkan

VK-GL-CTS Issue: 2889

Change-Id: I16ce02af52af6ee0b10a3cf382d132b32f3cf40a
Affects: dEQP-VK.ray_query.misc.dynamic_indexing*

Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5

Change-Id: Ic854c92253dc5745bd4718fab12b567832228861

Android: test list change dEQP-VK.glsl.builtin.*

Move the following tests from the Android 2019 test list to the 2020
test list.

dEQP-VK.glsl.builtin.precision.asin.highp.scalar
dEQP-VK.glsl.builtin.precision.asin.highp.vec2
dEQP-VK.glsl.builtin.precision.asin.highp.vec3
dEQP-VK.glsl.builtin.precision.asin.highp.vec4

Components: AOSP

Change-Id: I6586b0cfb39be6d43278cf61378563b3f894d641

Merge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/vulkan-cts-1.2.4

Change-Id: I83fff4847e0bc12be0d574bd064a511784a72e09

Update Vulkan headers

Components: Vulkan

Change-Id: I53ee070a94d444ca3f3d5198b205a4a7a0f3423d
(cherry picked from commit e360c1b13cdc98be2741b53e63a7a53204bb289a)

Update Vulkan beta Headers

Components: Vulkan

Change-Id: I29364f15c3c9c83424a7c0814b7634aaadfd4ab2
(cherry picked from commit 476acb91ebc242858d6d73253f54b7f8521f4d98)

Merge vk-gl-cts/vulkan-cts-1.2.2 into vk-gl-cts/vulkan-cts-1.2.3

Change-Id: Ib3ccf6adeedb2a55ba8a96bfabb75273a1c664ea

Update Vulkan Headers

Components: Vulkan

Change-Id: I489a247c5d32a19dd48768654ab1ef76cce3687c
(cherry picked from commit aa398b9cbd0ea035bdcc5d48da460c005654e507)

Update Vulkan headers

Components: Vulkan

Change-Id: I1f2650958b9ec4d9af8eb5e6310afa3c72395880
(cherry picked from commit e58814865924d9222859eaf8e4132e0eb842eb49)

Merge vk-gl-cts/vulkan-cts-1.2.1 into vk-gl-cts/vulkan-cts-1.2.2

Change-Id: I90603cf34d44bb7c6f10e81f7b594834391da05e

Android: test list change dEQP-VK.glsl.builtin.*

Move the following tests from the Android 2019 test list to the 2020
test list.

dEQP-VK.glsl.builtin.precision.asin.highp.scalar
dEQP-VK.glsl.builtin.precision.asin.highp.vec2
dEQP-VK.glsl.builtin.precision.asin.highp.vec3
dEQP-VK.glsl.builtin.precision.asin.highp.vec4

Components: AOSP

Change-Id: I6586b0cfb39be6d43278cf61378563b3f894d641

Drop unnecessary barrier

This extra barrier which does the transition from UNDEFINED-> GENERAL,
image data is read immediately after that, which leads to the test
failure after enabling the storage image compression.

Components: Vulkan

VK-GL-CTS Issue: 2884

Affects:
dEQP-VK.synchronization.*
dEQP-VK.synchronization2.*

Change-Id: I2ef7ca40b9c869f69654797872ebabb83bfbec10
(cherry picked from commit 4e830b7e271d5b77bc303f91ee11c7f703f14176)

Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6

Change-Id: I402128a712866638b2b8cc04ac38143712237ebf

Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5

Change-Id: Id90fcd730ba632a3a08f25a01226098421486753

Merge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/vulkan-cts-1.2.4

Change-Id: Iffa708c815ea869d459d6b5a951f69a3fae7d351

Merge vk-gl-cts/vulkan-cts-1.2.2 into vk-gl-cts/vulkan-cts-1.2.3

Change-Id: I452f719e084e6decc02066064c6f0397e4b915e6

Merge vk-gl-cts/vulkan-cts-1.2.1 into vk-gl-cts/vulkan-cts-1.2.2

Change-Id: I2947e16b40c26feb3c95922e18e36e36acbc43b9

Merge vk-gl-cts/vulkan-cts-1.1.6 into vk-gl-cts/vulkan-cts-1.2.1

Change-Id: Id775a0b8cb86bd5929b61c49fbfac4825421c7a7

Fixes transform feedback query tests

Tests were not reseting the query pool prior
to using the queries, as is required by the spec.

Components: Vulkan
VK-GL-CTS Issue: 2866

Affects:
dEQP-VK.transform_feedback.simple.multiquery*

Change-Id: If62c75476f1c9a97ee4d819712bb9904dc6d83c7

Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6

Change-Id: I373a9df4f575b5f9d90b2c9f651c1a69b9265f1d

Fix test does not return failure status

Affected tests:
dEQP-VK.wsi.display_control.register_device_event

Components: Vulkan
VK-GL-CTS issue: 2864

Change-Id: I282ffc5e7b910209a509ae57ee8e38c662b97815

Fixes Fragment Shading Rate layered tests

Test was exporting Layer and ViewportIndex
decorations in Vertex Shader in the
Geometry Shader tests without checking
for support.

Components: Vulkan
VK-GL-CTS Issue: 2865

Affects:
dEQP-VK.fragment_shading_Rate.srlayered.*.gs
dEQP-VK.fragment_shading_Rate.colorlayered.*.gs

Change-Id: Idbf6be2c14bb8409feec2d7262efb9a402cf35a2

Allow more conservative coverage for degenerate triangles

Some implementations of conservative rasterization with degenerate
triangles produce more than one pixel worth of coverage, which is
allowed by the Vulkan specification.

This CL modifies the test to allow some extra coverage so it works
on these implementations.

Affects:

dEQP-VK.rasterization.conservative.overestimate.*.triangles.degenerate.*

Components: Vulkan

VK-GL-CTS issue: 2859

Change-Id: I65c6508813c04d5faa2312e26832efe16e44cea2

Fix insufficient BLAS indirect buffer size

BLAS indirect buffer size is not set correctly. It is set to
sizeof(VkAccelerationStructureBuildRangeInfoKHR) however
geometries number times sizeof(VkAccelerationStructureBuildRangeInfoKHR)
indirect buffer space is needed.

Components: Vulkan

https://gitlab.khronos.org/Tracker/vk-gl-cts/-/issues/2862

Affects: dEQP-VK.ray_tracing_pipeline.indirect.build_structure
Change-Id: I2b5df039aac6c3f2a51177c8bf9f5095ae5c7886

Change format used in pipeline cache control tests

The format used as a colour attachment by the pipeline creation cache
control tests is not required to be supported as a color attachment and
the tests do not query for it being supported.

Change it to R8G8B8A8 which is required to be supported as the specific
format is not important for this test.

Affects:
dEQP-VK.pipeline.creation_cache_control.graphics_pipelines.*

Components: Vulkan

VK-GL-CTS issue: 2856

Change-Id: I7ecfc4de8584dba6824101cb717313247070f12f

Include sys/system_properties.h in teglAndroidUtil.cpp

The following CL added a call to __system_property_get():
https://github.com/KhronosGroup/VK-GL-CTS/commit/8a537a0c916e1a10e134f648801f0812c4c749ba

However, it's failing to build:

  ../../third_party/angle/third_party/VK-GL-CTS/src/modules/egl/teglAndroidUtil.cpp:78:3:
  error: use of undeclared identifier '__system_property_get'
                __system_property_get("ro.build.version.sdk", value);

This is caused by teglAndroidUtil.cpp not including
sys/system_properties.h. Including the file fixes the error.

Change-Id: I0e63fcc9dfe0e872832da07e3b8d7f2f78f9d835
(cherry picked from commit 968b6ee77b11267cb6afb6fdbd9bef847eb14868)

Remove in-repo verify_submission scripts

These scripts are now replaced by the CTS Tools repo:
https://github.com/KhronosGroup/VK-GL-CTS-Tools

Components: Vulkan, OpenGL

Change-Id: If0f47b4186ed10f9946852e8d37956d7328625a8

Allow Vulkan CTS 1.2.6.0

Affects: dEQP-VK.api.driver_properties.properties

Components: Vulkan

Change-Id: Ia8779d2c3ac92ec1a90d43225b551b7efabef023

Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/master

Change-Id: Ie1fb3817afbffd0b18a695230594c2790f6a5d8c

Allow false positive hits from build-in AABBs intersector

This change allows the test to execute any hit shader,
in case of AABB geometry is used and the ray falsely 'intersects'
it.

This is needed, as the test does not calculate the proper
intersection in 'intersection' stage - it uses a shader that always
reports TRUE. Hence the test relies on build-in AABB
intersector, which may report false positives according to the
specification.

VK-GL-CTS Issue: 2848

Components: Vulkan

Affects: dEQP-VK.ray_tracing_pipeline.build.*aabbs*

Change-Id: Ib90f45227a7cd4c412fd4d1c97598f32a80eb6ca

Fix required features checks in shaderRecordExplicitScalarOffset_6 test case

Due to typo in ShaderRecordBlockTest::isTest(), the test case was not
checked for optional features, required by ShaderRecordBlockTest class.

Components: Vulkan

VK-GL-CTS Issues: 2845

Affects: dEQP-VK.ray_tracing_pipeline.misc.shaderRecordExplicitScalarOffset_6
Change-Id: I437637e69294f10343f69d9f5b9a0abfe3acc7a5

Add VK_EXT_headless_surface surface tests

Adds vulkan_headless target which uses VK_EXT_headless_surface
for swapchain surface creation.

New tests:
dEQP-VK.image.swapchain_mutable.headless.*
dEQP-VK.wsi.headless.*
dEQP-VK.protected_memory.interaction.wsi.headless.*

Components: Vulkan

VK-GL-CTS issue: 2825

Change-Id: I21536c41c839b7bb795f05a17cbea68f8125133a

Fix robust buffer access result checking for partially out of bound cases

The spec says:
Out-of-bounds buffer loads will return any of the following values:
...
Values from anywhere within the memory range(s) bound to the buffer (possibly including bytes of memory past the end of the buffer, up to the end of the bound range).
...

So partially out of bound load may return memory content for the in bound part. E.g., loading a 64-bit value from a buffer with 3B size (allocated 4B size), the first 4B can be value within the buffer.

Affected tests:
dEQP-VK.robustness.buffer_access.through_pointers.*

Change-Id: I1fab8d3819cf4d5935904a1c7762c3660c67379b

Remove the tests with too large device AS build workload

This removes the tests that submit accelleration structure
builds with 1048576 instances * geometries * 'squares'.

The accelleation structure builds performed by these tests
were too long and may hit the device timeout imposed by
the operating system.

Components: Vulkan

VK-GL-CTS Issue: 2849

Removed Tests:

dEQP-VK.ray_tracing_pipeline.build.gpu*_1_1_1048576
dEQP-VK.ray_tracing_pipeline.build.gpu*_1_1048576_1
dEQP-VK.ray_tracing_pipeline.build.gpu*_1_1048576_1
dEQP-VK.ray_tracing_pipeline.build.gpu*_4_4_65536
dEQP-VK.ray_tracing_pipeline.build.gpu*_4_65536_4
dEQP-VK.ray_tracing_pipeline.build.gpu*_65536_4_4

Change-Id: Ief53cc01da4f749fd8a030bd8e2ebb5652208ce4

Use linear tiling with external_memory_host tests

With linear, app can query the image's memory layout with
vkGetImageSubresourceLayout. With optimal tiling there is no way for app
to query or provide memory layout, therefore we must use linear.

Component: Vulkan
Affects: dEQP-VK.memory.external_memory_host*
VK-GL-CTS issue: 2794

Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Change-Id: I71e97a937415abe6170e6edd81eaec26a5c68867

Fix precision issue in NearestEdgeTests shaders

We should also use the calculated offset in shader.

Affects:
KHR-GLES32.core.nearest_edge.*

Components: OpenGL ES

VK-GL-CTS issue: 2651

Change-Id: I9427d3a95a98e3be58dd7ea16a2bf96822f33450

Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/master

Change-Id: I8e05ada30678a379a588756779ae4faf6a41851c

Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5

Change-Id: If51e7d93c6b84f7d3fde339f35ae351d8443a7ce

Merge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/vulkan-cts-1.2.4

Change-Id: Id84d297899a981b1fae39d923280446925730cd0

Enable shadow filtering tests for non-filterable formats

The spec says that you don't need to be able to filter the actual format
in order to filter the results of a shadow comparison. Enable this in
the texture tests.

Component: Vulkan
VK-GL-CTS issue: 2834
Affects: dEQP-VK.texture.shadow.*

Change-Id: I0879d8e77b84493d0be9677e9b4811a240c812b5

Add BGR and BGRA formats to image view tests

Test image views, including sampling and swizzling, with BGR and BGRA
formats so as to make sure the ordering of color components in image
memory does not affect the meaning of color component names.

New tests:
dEQP-VK.pipeline.image_view.*b8g8r8*

Components: Vulkan
VK-GL-CTS issue: 2841

Change-Id: I6005ab518e78d40d3e590882ebdedc102fb70d38

Merge vk-gl-cts/vulkan-cts-1.2.2 into vk-gl-cts/vulkan-cts-1.2.3

Change-Id: I6bad956acaf784565692e1ea539a219064deed57

Merge vk-gl-cts/opengl-es-cts-3.2.7 into vk-gl-cts/master

Change-Id: I2a972a234184ede3227a4dc55758407a447483f0

Merge vk-gl-cts/vulkan-cts-1.2.1 into vk-gl-cts/vulkan-cts-1.2.2

Change-Id: I64b979022925b98680602154ad32b13080a04871

Merge vk-gl-cts/opengl-es-cts-3.2.6 into vk-gl-cts/opengl-es-cts-3.2.7

Change-Id: Ied31bf3a3891e6809c3472c70598ac7448a31066

Merge vk-gl-cts/vulkan-cts-1.1.6 into vk-gl-cts/vulkan-cts-1.2.1

Change-Id: If6077d356659193696b2e41c318b5bda2f5ca1d1

Add tests for standard multisample positions

This set of tests renders a triangle per multisample position
and then checks whether the correct colors can be found in
the samples.

New tests:
dEQP-VK.pipeline.multisample.standardsampleposition.*

Components: Vulkan
VK-GL-CTS issue: 2755

Change-Id: I79e941f330952b0473c978554f178c09bfc84af2

Push constant overwrite tests

Add tests that update constant data ranges using multiple commands and
vary data values between draw or dispatch calls.

In addition, add a convenience function to create compute pipelines.
Many other tests use a similar custom function, but this commit does not
attempt to replace previous uses.

New tests:
dEQP-VK.pipeline.push_constant.*.overwrite

Components: Vulkan
VK-GL-CTS issue: 2805

Change-Id: I4358250940639a0812aeb81c51649ebb27c8bd8d

Test large command buffers with many draw commands

Test recording a large number of draw commands in primary and secondary
command buffers, making sure every command is recorded and executed
properly.

New tests:
dEQP-VK.api.command_buffers.record_many_draws_*

Components: Vulkan
VK-GL-CTS issue: 2813

Change-Id: Ife8957242fd5a0babc5e525f28a4014d46b29d3d

Test barycentric coordinates in ray tracing hits

Add some tests to check the reported barycentric coordinates both in hit
attributes when ray tracing and also in ray queries have the expected
values and correspond to factors b and c in the barycentric coordinates
equation:

  p = a pa + b pb + c pc

New tests:
dEQP-VK.ray_tracing_pipeline.barycentric_coordinates.*
dEQP-VK.ray_query.barycentric_coordinates.*

Components: Vulkan
VK-GL-CTS issue: 2812

Change-Id: I1beba46045ea4efdfe7dab2318c331c4046d2d1d

Add missing mandatory features

This commit fixes several missing mandatory feature checks:

* shaderSampledImageArrayDynamicIndexing was missing as mandatory when
  descriptorIndexing is supported.

* Ditto for shaderStorageBufferArrayDynamicIndexing.

* The ray tracing extensions were missing many mandatory features.

Affected tests:
dEQP-VK.info.device_mandatory_features

Components: Vulkan
VK-GL-CTS issue: 2829

Change-Id: I90896df608cdca228fb357b2feabc4deea393db2

Ensure WSI colorspace has no effect on image contents

This test makes sure that rendering is invariant
with regards to the swapchain colorspace.
Fixes validation errors on dEQP-VK.wsi.*.colorspace.* tests.

Affects:

dEQP-VK.wsi.*.colorspace.*

New tests:

dEQP-VK.wsi.*.colorspace_compare.*

Components: Vulkan

VK-GL-CTS issue: 1915

Change-Id: Ic8d4c52e182bbef73c1cfe85be9ea054545c86d8

reset minSampleShading only with OpenGL Core 4.0+

This fixes crashes seen with many tests when context state is
reset and gl.minSampleShading is NULL.

Affects: KHR-GL*

Components: OpenGL

VK-GL-CTS issue: 2827

Fixes: 327ee5674 ("Support GL 4.5 in various multisample tests")
Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Change-Id: I4b67a30264d4bdb6de8a5f7e811ae8bb8ee8a696

Merge vk-gl-cts/opengl-es-cts-3.2.7 into vk-gl-cts/master

Change-Id: Id15497476682a03dd2b2fe4c0e5f9ea5d27d27e7

Update Vulkan/GL Readme

Update the Readme files to point to the new
submission verifcation script

Components: Vulkan, OpenGL

Change-Id: I6fb35a383fcc49e543ae67822be22d744c5fcd9c
(cherry picked from commit 412f5a3363eb228ca1a63be337de172a2e622571)

Update Vulkan/GL Readme

Update the Readme files to point to the new
submission verifcation script

Components: Vulkan, OpenGL

Change-Id: I6fb35a383fcc49e543ae67822be22d744c5fcd9c
(cherry picked from commit 412f5a3363eb228ca1a63be337de172a2e622571)

Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/master

Change-Id: I49df5c172965f67acfc561b8055a6fe9dd4c75de

Merge vk-gl-cts/opengl-cts-4.6.0 into vk-gl-cts/master

Change-Id: Ia707d071b963951d00f6836be3f24fd1a0877cca

Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5

Change-Id: I07fc25f375c0228279e54582fc909876a370d251

Merge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/vulkan-cts-1.2.4

Change-Id: I78e06ea1256567bd761e1ffa5678338eb1f7aa85

Merge vk-gl-cts/vulkan-cts-1.2.2 into vk-gl-cts/vulkan-cts-1.2.3

Change-Id: I15d9b2b0dbaab175d891a824c190198bbcda1b20

Merge vk-gl-cts/vulkan-cts-1.2.1 into vk-gl-cts/vulkan-cts-1.2.2

Change-Id: Iccb63bb8842b2d3b8ae22b78853a0534500aebdf

Enable validation for all custom devices

This commit changes some tests that use custom devices so they rely on
the custom device helper functions to create these custom devices with
the validation layers enabled if requested from the command line.

In addition, some "createDevice" functions are renamed so a simple
search for "createDevice" only reports uses of the createDevice instance
interface method and RefUtil helper function.

The affected tests should only behave differently with validation
enabled. Running these tests without validation should not result in any
changes.

Affected tests:
dEQP-VK.api.buffer_marker.*
dEQP-VK.api.info.vulkan1p2.feature_bits_influence
dEQP-VK.draw.concurrent.compute_and_triangle_list
dEQP-VK.ray_tracing_pipeline.capture_replay.*
dEQP-VK.synchronization*.signal_order.*
dEQP-VK.synchronization.timeline_semaphore.*
dEQP-VK.synchronization2.timeline_semaphore.*

Components: Vulkan
VK-GL-CTS issue: 2835

Change-Id: I6e8028428faa69d92ab9a8a0e8ba25540d04810f

Remove multiview requirement in extended dyn state tests

VK_KHR_multiview was wrongly being required for extended dynamic states
using several viewports, when the only needed check is to verify the
number of viewports does not exceed the maxViewports limit.

Affected tests:
dEQP-VK.pipeline.extended_dynamic_state.*2_viewports*
dEQP-VK.pipeline.extended_dynamic_state.*2_scissors*

Components: Vulkan
VK-GL-CTS issue: 2832

Change-Id: I72b2c09153ed2303b7d64bdd78c756ddfa838137

Fix recursion depth requirement in complexcontrolflow

Checks recursion depth required is supported
(i.e. is lower than maxRayRecursionDepth).
Also properly specifies maxPipelineRayRecursionDepth
in VkRayTracingPipelineCreateInfoKHR.

Updates tests:
 * dEQP-VK.ray_tracing_pipeline.complexcontrolflow.*.trace_ray.chit
 * dEQP-VK.ray_tracing_pipeline.complexcontrolflow.*.trace_ray.miss

Affects tests:
 * dEQP-VK.ray_tracing_pipeline.complexcontrolflow.*

Components: Vulkan

VK-GL-CTS issue: 2836

Change-Id: Ieb2854e3980ac729344a780dc4efaaf7a33c64a0

Check image extent support in watertightness tests

"Closed fan" watertightness ray tracing tests may use 3D images with
large depth dimensions that go over the minimum value for the maximum
depth as required by the spec, so they need to check if such an extent
is supported.

Additionally, this commit fixes two other issues:

* The result verification logic was incorrect for cases with quality
  warnings (i.e. when the miss shader was executed).

* Output buffer memory invalidation triggered validation errors in some
  implementations due to not using VK_WHOLE_SIZE when attempting to
  invalidate the whole range.

Affected tests:
dEQP-VK.ray_tracing_pipeline.watertightness.*

Components: Vulkan
VK-GL-CTS issue: 2833

Change-Id: I607dd9d46f5212a71cf109a711e418ae05011b69

Read deserealization size from stream

Deserialization should read deserialized data size
from serialized data stream, rather than use serialized
data size. To allow reading of this data from stream
command buffer recording should be completed and restarted.

Updates tests:
 * dEQP-VK.ray_tracing_pipeline.acceleration_structures.operations.serialization.*
 * dEQP-VK.ray_tracing_pipeline.capture_replay.acceleration_structures.serialization.*
 * dEQP-VK.ray_query.acceleration_structures.operations.*.serialization.*

Components: Framework, Vulkan

VK-GL-CTS issue: 2545

Change-Id: I460d82ae9ebfe8e43f24b4478154854a01491602

Fix flush/invalidate in mismatched_write_op tests

The memory flush/invalidate logic was incorrect, causing memory updates
to be lost. Having access functions do invalidates makes it difficult to
reuse the code (because the accessor can only be used when no writes are
outstanding, but this is not obvious from the naming), so put these
operations explicitly in around the device commands that need them.

Components: Vulkan
VK-GL-CTS issue: 2817
Affects: dEQP-VK.image.mismatched_write_op.mismatched_vector_sizes.*

Change-Id: I594c6dd9911b2d2a21b2ba88e9570eb4fe09ebd4

Fix sync validation for mismatched_write_op tests

The pipeline stages and accesss bits were incorrect in some cases and
the validation layer was complaining about write-after-write hazards.

Components: Vulkan
VK-GL-CTS issue: 2817
Affects: dEQP-VK.image.mismatched_write_op.mismatched_vector_sizes.*

Change-Id: I254ab3b65342552d71fd3890da271e8586eb1fab

Check if image sample count supported by VkSampleCountFlags

There might be limitations based on format, usage and sample count set.

VK-GL-CTS Issue: 2824

Components: Vulkan

Affects: dEQP-VK.synchronization.cross_instance.*multisample*

Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Change-Id: I4702f7df809671f78183fc647d183d7838bf31c3

Always accumulate errors in desc set random tests

Tests using DEPENDENT and RUNTIME_SIZE index types were overwriting the
value of the accumulated error with each load operation. This has two
problems:

* Sometimes the result of a load operation would not be used in the next
  load operation. This happens when the next descriptor to check is not
  an array. In these cases the implementation may remove load
  operations, which means they would not be checked.

* As long as the implementation does not crash and the last load
  operation works as expected, the implementation was allowed to load
  incorrect values in those operations, because only the last load would
  be taken into account to decide if the output storage image will have
  a "good" or "bad" value.

This commit makes all test variants accumulate errors in the "accum"
variable that's used at the end of each test.

Affected tests:
dEQP-VK.binding_model.descriptorset_random.*

Components: Vulkan
VK-GL-CTS issue: 2763

Change-Id: I4de1bd4525d378b5ec2b7aad3faae81d956a9d7d

Fix missing barrier in compute test

The test does:

- Draw with transform feedback
- Dispatch using the same buffer as storage buffer

This is a WaR hazard that needs a glMemoryBarrier.

VK-GL-CTS issue: 2809

Affects:
KHR-GLES31.core.compute_shader.pipeline-post-xfb
KHR-GL43.compute_shader.pipeline-post-xfb
KHR-GL44.compute_shader.pipeline-post-xfb
KHR-GL45.compute_shader.pipeline-post-xfb
KHR-GL46.compute_shader.pipeline-post-xfb

Change-Id: I18202640e307490352c0c6a6f42e145b054aedd8

Fix missing barrier in texture buffer test

The test does:

- Draw with transform feedback
- Dispatch using the same buffer as imageBuffer

This is a WaR hazard that needs a glMemoryBarrier.

VK-GL-CTS issue: 2809

Affects:
KHR-GLES31.core.texture_buffer.texture_buffer_operations_transform_feedback

Change-Id: Id092229708421002fe1b8df38028f9c6a359c242

Replace libUI with native Android AHB API

EGL AHB tests were using libUI which isn't accessible
using public Android builds. This change maps to the
public AHB API in a similar way Vulkan CTS is already
doing.

The supported AHB formats differ from the libUI ones,
so the tested formats have also changed.

VK-GL-CTS Issue: 2785

Affects:

dEQP-EGL.functional.image.*

Components: EGL, Framework
Change-Id: Ieb9e88106c3a4c42e516f71a0c48d99ca8a59a90

Update Amber

Amber was updated to include a fix for Vulkan pointer
loading that broke CTS when using Vulkan 1.0 device.

VK-GL-CTS Issue: 2802

Affects: All Amber tests

Components: Vulkan, Framework
Change-Id: I2ceaa8b569112f2e32e8a3a4e74d82ef1e4d0a67
(cherry picked from commit e3a5a50e44c4d078d8fd2b97c6a9b4fecc97d1ce)