Alexander Galazin [Thu, 1 Mar 2018 15:21:19 +0000 (16:21 +0100)]
Merge vk-gl-cts/aosp-deqp-dev into vk-gl-cts/master
Change-Id: I43efda824345475ca1305ed3fb2c68e0adb2cc29
Alexander Galazin [Thu, 1 Mar 2018 13:15:58 +0000 (14:15 +0100)]
Merge vk-gl-cts/vulkan-cts-1.0.3 into vk-gl-cts/master
Change-Id: If5b14c7b39f8ed894d9da5129d781d9db3ad2acb
Alexander Galazin [Thu, 1 Mar 2018 12:28:03 +0000 (13:28 +0100)]
Merge vk-gl-cts/vulkan-cts-1.0.2 into vk-gl-cts/vulkan-cts-1.0.3
Change-Id: I41e9aca9c2a5bd2bbb13b55584a4f5faf433aa12
Mika Väinölä [Thu, 22 Feb 2018 12:01:38 +0000 (14:01 +0200)]
Fix validation errors in image clearing tests
Remove access flags which are not supported by
VK_PIPELINE_STAGE_TRANSFER_BIT.
Affects:
dEQP-VK.api.image_clearing.*
Components: Vulkan
VK-GL-CTS issue: 1030
Change-Id: Ia0b4e097766ec674be149dbde4fad652482c1e39
Slawomir Cygan [Thu, 22 Feb 2018 17:55:01 +0000 (18:55 +0100)]
Do not access temporary C++ object members by reference
Fix undefined C++ behavior (resulting in errors when doing runtime memory checks),
where a temporary object returned by getInputAspects() method is used by a reference
to a member after the temporary is destructed.
It seems getInputAspects should just return reference.
Affects: dEQP-VK.renderpass.*.input*
Component: Vulkan
VK-GL-CTS Issue: 1033
Change-Id: I71edabed71ea63f46cdbc45c966d57cd020565ab
Piotr Byszewski [Fri, 16 Feb 2018 13:35:13 +0000 (14:35 +0100)]
Cover gl_WorkGroupSize negative cases
Check if compile-time error is generatef when gl_WorkGroupSize
is used before its declaration.
This change also verifies if omitted dimensions are set to 1.
Components: OpenGL
VK-GL-CTS issue: 951
Affects:
KHR-GLES31.core.compute_shader.work-group-size-usage
Change-Id: I8f3c72401c4f15d9a53d41f0a005d5399527072c
neilmonday [Thu, 8 Feb 2018 15:33:48 +0000 (10:33 -0500)]
Destroy debug context if a failure occurs.
For gl4cKHRDebugTests, Adding TestBase::done before the exception is
thrown so that the temporary context is properly deleted and the
original is restored.
Affects:
KHR-GL46.khr_debug.api_errors_non_debug
KHR-GL46.khr_debug.labels_non_debug
KHR-GL46.khr_debug.receiveing_messages
KHR-GL46.khr_debug.groups
KHR-GL46.khr_debug.api_errors_debug
KHR-GL46.khr_debug.labels_debug
KHR-GL46.khr_debug.synchronous_calls
Components: OpenGL
VK-GL-CTS issue: 976
Change-Id: Ia0b061b6cc5d4b309d2df2a6d4acf25caad0114c
Oliver Wohlmuth [Fri, 2 Feb 2018 13:41:08 +0000 (14:41 +0100)]
Added handling for EGL_YUV_BUFFER_EXT
YUV framebuffer formats are not handled for dEQP-
EGL.functional.color_clears.single_context.gles2.other
which results in an assertion. This patchset handles them similar to
float pixel formats.
Affects:
dEQP-EGL.functional.color_clears.single_context.gles2.other
Components: Framework, AOSP
VK-GL-CTS issue: 894
Change-Id: I4ac65c939819a8de7c464601491bb8df78623171
Chris Forbes [Tue, 27 Feb 2018 17:27:45 +0000 (09:27 -0800)]
Merge remote-tracking branch 'aosp/master' into deqp-dev
Change-Id: If842464627ad7b6c07c8b2fb259ce7abe1e084b5
Chris Forbes [Tue, 27 Feb 2018 15:54:49 +0000 (07:54 -0800)]
Rename Interval::warning's parameters to avoid shadowing
GCC 4.9 warns about this, causing build failures with -Werror
Change-Id: Ic3579de84f4b3f1f231240910dbd15dafe90c6bc
Components: Framework
Alexander Galazin [Tue, 27 Feb 2018 12:42:27 +0000 (07:42 -0500)]
Merge "Merge vk-gl-cts/github-master into vk-gl-cts/master"
Alexander Galazin [Tue, 27 Feb 2018 12:21:11 +0000 (13:21 +0100)]
Merge vk-gl-cts/vulkan-cts-1.0.3 into vk-gl-cts/master
Change-Id: I1f5b1b2621033ffa3551bd2cdf8c057cf89e9539
Alexander Galazin [Tue, 27 Feb 2018 11:16:52 +0000 (12:16 +0100)]
Merge vk-gl-cts/github-master into vk-gl-cts/master
Change-Id: I8990b1e682cdb59cdf15eeddbc91af817b9e3e30
Alexander Galazin [Tue, 27 Feb 2018 09:13:28 +0000 (10:13 +0100)]
Merge pull request #79 from imirkin/master
glx: add getProcAddress override
Piotr Byszewski [Thu, 21 Sep 2017 13:36:36 +0000 (15:36 +0200)]
Handle edge case in GL FP64 tests
mod(a,b) is defined as: a - b * floor(a/b)
mod(a,a) should be 0 however OpenGL allows for some error in
division, so a/a could actually end up being 1.0 - 1ULP. In
such a case, floor(a/a) would end up as 0, with mod(a,a)
becoming a. This patchset detects this case and adjusts the
expected result accordingly.
Components: OpenGL
VK-GL-CTS issue: 641
Affects:
KHR-GL40.gpu_shader_fp64.builtin.*
Change-Id: I9535d337b2132519c985f8ac8eb18bf938a89ea7
Piotr Byszewski [Tue, 23 Jan 2018 13:29:34 +0000 (14:29 +0100)]
Fix gl_FragData usage in draw_buffers test
ES3 specification states that "if some, but not all user-defined
output variables are written, the values of fragment colors
corresponding to unwritten variables are (...) undefined".
Components: OpenGL
VK-GL-CTS issue: 291
Affects:
dEQP-GLES3.functional.shaders.fragdata.draw_buffers
Change-Id: I83f1904e9cf905634a421b6fc5530e0e0510ccb1
Slawomir Cygan [Mon, 19 Feb 2018 13:37:08 +0000 (14:37 +0100)]
Fix wrong layout used in vkCmdImageResolve
VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL is not
a valid source layout for vkCmdImageResolve operation.
Image is already in VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL
layout after transition performed ~48LOC above the offending resolve,
so just use current image layout here.
Components: Vulkan
VK-GL-CTS Issue: 1023
Change-Id: Ibcc3359c030d709c5a947316cea2a9cb19736b21
Affects: dEQP-VK.glsl.builtin_var.fragdepth.*multisample_*
Chris Forbes [Mon, 26 Feb 2018 17:22:55 +0000 (09:22 -0800)]
Merge remote-tracking branch 'khronos/master' into deqp-dev
Change-Id: Id50b4722e499965b7ad9dd5acc771f8b84d30cfc
Peter Quayle [Wed, 21 Feb 2018 15:34:55 +0000 (15:34 +0000)]
Ensure sync_fd tests use valid file descriptors
The external.*.sync_fd.* tests fail on some implementations
because vkGet*FdKHR may return -1 (meaning pre-signalled) instead
of a valid file descriptor.
Affects:
dEQP-VK.api.external.semaphore.sync_fd*
dEQP-VK.api.external.fence.sync_fd*
Components: Vulkan
VK-GL-CTS issue: 957
Change-Id: I91087db1595a19605956dad460caa344e850491e
Bas Nieuwenhuizen [Fri, 23 Feb 2018 22:15:37 +0000 (22:15 +0000)]
DO NOT MERGE: Fix dEQP-VK.api.copy_and_blit.image_to_image_depth value range. am:
f03effb5a0 -s ours am:
7c8b312fbe -s ours
am:
5be6880be9 -s ours
Change-Id: I89fdca56007f43c479e6129183fb2f8c76b5193b
Bas Nieuwenhuizen [Fri, 23 Feb 2018 22:09:07 +0000 (22:09 +0000)]
DO NOT MERGE: Fix dEQP-VK.api.copy_and_blit.image_to_image_depth value range. am:
f03effb5a0 -s ours
am:
7c8b312fbe -s ours
Change-Id: I7302bfbf8d9c38c8a01e604253a9cca1bba8b76c
Bas Nieuwenhuizen [Fri, 23 Feb 2018 22:03:07 +0000 (22:03 +0000)]
DO NOT MERGE: Fix dEQP-VK.api.copy_and_blit.image_to_image_depth value range.
am:
f03effb5a0 -s ours
Change-Id: I26792ef93ead582aabb8bd5beb386588846c7489
Alexander Galazin [Thu, 22 Feb 2018 17:11:04 +0000 (12:11 -0500)]
Revert "Fix texture lookups tests"
This reverts commit
0dd89ea7126f19cca176ffaa6bb47a259671570f.
Change-Id: I3612c45a6b85819e4cc3f5dcef992743f3964c65
Paavo Pessi [Fri, 9 Feb 2018 14:33:16 +0000 (16:33 +0200)]
Use framebuffer with a compatible render pass
This test has the same functionality as
VkLayerTest.RenderPassInUseDestroyedSignaled, which breaks some
shipping drivers in the validation tests.
The test creates two compatible render passes having differing image
layouts and load/store operations. The first render pass is used to
create a framebuffer and the framebuffer is used to begin the second
render pass.
The test passes as long as no crash happens.
New tests:
dEQP-VK.api.pipeline.renderpass.framebuffer_compatible_renderpass
Components: Vulkan
VK-GL-CTS issue: 830
Change-Id: I0b47c8620c06ac3d0ca5288f642908de6dff656b
Chris Forbes [Thu, 22 Feb 2018 18:14:13 +0000 (10:14 -0800)]
Merge remote-tracking branch 'khronos/master' into deqp-dev
Change-Id: Iadea35019f1362e92a5e67ca7383df27cba6d1fd
Paavo Pessi [Tue, 16 Jan 2018 13:16:00 +0000 (15:16 +0200)]
Extend combined image sampler tests
Two types of new tests were added. The first type has a single combined
image sampler descriptor which is accessed in shader with separate
image and sampler variables using the same binding value.
The second type has two combined image sampler descriptors with
separate image and sampler variables. Sampler from the first descriptor
and image from the second descriptor are used to form a new sampled
image.
New tests:
dEQP-VK.spirv_assembly.instruction.compute.image_sampler.imagefetch.combined_image_sampler_separate_variables.*
dEQP-VK.spirv_assembly.instruction.compute.image_sampler.imagefetch.combined_image_sampler_separate_descriptors.*
dEQP-VK.spirv_assembly.instruction.compute.image_sampler.imagesample.combined_image_sampler_separate_variables.*
dEQP-VK.spirv_assembly.instruction.compute.image_sampler.imagesample.combined_image_sampler_separate_descriptors.*
dEQP-VK.spirv_assembly.instruction.graphics.image_sampler.imagefetch.combined_image_sampler_separate_variables.*
dEQP-VK.spirv_assembly.instruction.graphics.image_sampler.imagefetch.combined_image_sampler_separate_descriptors.*
dEQP-VK.spirv_assembly.instruction.graphics.image_sampler.imagesample.combined_image_sampler_separate_variables.*
dEQP-VK.spirv_assembly.instruction.graphics.image_sampler.imagesample.combined_image_sampler_separate_descriptors.*
Components: Vulkan
VK-GL-CTS issue: 940
VK-GL-CTS public issue: 75
Change-Id: I56fc049001f3ac4d59cdaa7c28749ba57c46ce29
Panagiotis Apostolou [Wed, 17 Jan 2018 09:45:06 +0000 (10:45 +0100)]
New dEQP-VK.ycbcr.conversion.one_to_one subgroup
Added subgroup one_to_one in dEQP-VK.ycbcr.conversion which adds 16 tests. The
purspose is to test rendering into a destination with the same dimensions
as the sampled YCbCr image (1:1 mapping).
New tests:
dEQP-VK.ycbcr.conversion.one_to_one.implicit_nearest_16x16_*
dEQP-VK.ycbcr.conversion.one_to_one.implicit_nearest_20x12_*
Components: Vulkan
VK-GL-CTS issue: 980
Change-Id: Ifb7d3cfa8fa4ec7dd99094ef94be680a53c7d5e7
Piotr Byszewski [Fri, 16 Feb 2018 17:06:36 +0000 (18:06 +0100)]
Suppress irrelevant packed pixels log
PackedPixelsTests log statistics during test destruction. That log
is needed only when therea are changes applyed to packed pixels so
there is no need for it to be printed during every glcts execution.
Change-Id: I4be85db2fa31c4218bb3715c32f46cf09ae2e0a5
Components: OpenGL
Piotr Byszewski [Mon, 5 Feb 2018 14:42:27 +0000 (15:42 +0100)]
Test internal formats conversions
This change contains a port of GTFTestCopyTexImageConversions.c
This test verifies that glCopyTexImage2D() implementation accepts
internalformats that are compatible with effective internalformat
of current read buffer.
Components: OpenGL
VK-GL-CTS issue: 978
Affects:
KHR-GLES3.copy_tex_image_conversions.*
Change-Id: Ic51c5bb758debe2e1aaa01d6d110c89310a4e21e
Piotr Byszewski [Mon, 22 Jan 2018 13:31:08 +0000 (14:31 +0100)]
Fix negative texture and fbo attachment tests
Negative GetFramebufferAttachmentParameteriv test
for ES2 properly handles case when it is executed on
ES3 capable hardware.
This change also resolves enum issue for negative
TexSubImage2D test. Invalid enum caused generation
of different error code then expected.
Components: OpenGL
VK-GL-CTS issue: 316
Affects:
dEQP-GLES2.functional.negative_api.texture.texsubimage2d_neg_wdt_hgt
dEQP-GLES2.functional.negative_api.state.get_framebuffer_attachment_parameteriv
Change-Id: Ib22eeba95fca7af3a66ab25934bdaf88362de2b2
Alexander Galazin [Thu, 22 Feb 2018 12:54:58 +0000 (13:54 +0100)]
Merge vk-gl-cts/vulkan-cts-1.0.3 into vk-gl-cts/master
Change-Id: Ie121814de1999c5d3f67080646ea53228f30f7d3
Piotr Byszewski [Thu, 18 Jan 2018 11:40:35 +0000 (12:40 +0100)]
Fix ES2 attachement query test
Error codes changed for ES3 and because of that different
version of test should be used when ES2 context is created
on ES3 compatible hardware.
Components: OpenGL
VK-GL-CTS issue: 287
Affects:
dEQP-GLES2.functional.fbo.api.attachment_query_empty_fbo
Change-Id: I04cb2f4796892d166d56ea0b9584401af3fc3363
Piotr Byszewski [Fri, 26 Jan 2018 16:34:24 +0000 (17:34 +0100)]
Fix cube map filtering and wrap tests
Tests were adjusted so that they also work correctly on
ES3 capable hardware.
Components: OpenGL
VK-GL-CTS issue: 285
Affects:
dEQP-GLES2.functional.texture.vertex.cube.filtering.*
dEQP-GLES2.functional.texture.vertex.cube.wrap.*
Change-Id: I7a8b2511dd6eaff3038c6ace0481b96e0b918d66
Nicolas Capens [Thu, 25 Jan 2018 16:58:26 +0000 (16:58 +0000)]
Update AOSP mustpass for flush/wait test.
The dEQP-GLES3.functional.flush_finish.flush_wait test now produces a
CompatibilityWarning instead of a Failure if the (overly strict) test
assumptions aren't met. Hence it can be added back to the mustpass set.
See:
https://android-review.googlesource.com/c/platform/external/deqp/+/600456
VK-GL-CTS issue: 975
Google bug: b/
71858368
Khronos bug: 13916
internal bug:
20558284
Components: AOSP
Affects: dEQP-GLES2.functional.flush_finish.*,
dEQP-GLES3.functional.flush_finish.*
Change-Id: I3ac84b6f95986dac95b9a8e5ccff95fd384c096c
Piotr Byszewski [Fri, 26 Jan 2018 10:18:53 +0000 (11:18 +0100)]
Handle corner case in random shader generator
Comparision of floats with the same value in reference renderer
does not always produce the same result due to varyings
precision error. This patch resolves this issue by adding
epsilon to one of the floats.
Components: OpenGL
VK-GL-CTS issue: 286
Affects:
dEQP-GLES2.functional.fragment_ops.interaction.basic_shader.*
Change-Id: I4310dcee8ace4e39c66a744901501ee9ccfceafc
Alexander Galazin [Thu, 22 Feb 2018 11:27:36 +0000 (12:27 +0100)]
Merge vk-gl-cts/vulkan-cts-1.0.2 into vk-gl-cts/vulkan-cts-1.0.3
Change-Id: Icb528802155f2ffdfe35e23f84a35403a29acd74
Ari Suonpaa [Tue, 12 Sep 2017 08:10:01 +0000 (11:10 +0300)]
Add tests for texture*ClampARB and sparseTexture*ClampARB.
Extended glsl.texture_functions tests to include texture*ClampARB
and sparseTexture*ClampARB functions.
Affects:
dEQP-VK.glsl.texture_functions.texture*clamp.*
Components: Vulkan
VK-GL-CTS issue: 86
Change-Id: Id080404fe2f0e849b5d5b6c5a84481794cb3ce3e
Andrey Tuganov [Mon, 5 Feb 2018 17:14:40 +0000 (12:14 -0500)]
Fix invalid memory semantics in barrier tests
The tests were breaking the rule:
"If the semantics for OpControlBarrier is not None,
then it must include at least one storage class."
https://www.khronos.org/registry/vulkan/specs/1.0/html/vkspec.html#spirvenv-module-validation
Affects: dEQP-VK.spirv_assembly.instruction.graphics.barrier.*
Components: Vulkan
VK-GL-CTS issue: 989
Change-Id: I3a1d42ae6f0a6ca63e3f32b76f09fa736ff49dc0
Tom Cooper [Mon, 12 Feb 2018 16:20:58 +0000 (16:20 +0000)]
Fix low memory in dedicated_alloc buffer tests
Observe platform memory limits to avoid low memory conditions.
Components: Vulkan
VK-GL-CTS issue: 1008
Affects: dEQP-VK.api.buffer.dedicated_alloc.create_buffer_*
Change-Id: Ib184b648126e8cb6e1acff533447a86be9a1a612
Paavo Pessi [Wed, 7 Feb 2018 09:22:39 +0000 (11:22 +0200)]
Test using a pipeline whose render pass has been destroyed
This test has the same functionality as
VkPositiveLayerTest.DestroyPipelineRenderPass.
The test creates two compatible render passes. The first one is used
to create the graphics pipeline and the second one is used for
everything else. The first render pass is destroyed while the second
render pass is active and the graphics pipeline is bound to a
command buffer.
The test passes as long as no crash happens.
New tests:
dEQP-VK.api.pipeline.renderpass.destroy_pipeline_renderpass
Components: Vulkan
VK-GL-CTS issue: 833
Change-Id: I7eff6595da6dcfacfe8c49b14c2f9a36d5436088
Hernan Liatis [Tue, 30 Jan 2018 18:19:08 +0000 (10:19 -0800)]
Create Graphics tests for OpName
These tests make sure that OpName has no impact on the semantics of
graphics kernels. Note that the vertex shader template
(makeVertexShaderAssembly) changes %main to %BP_main.
New tests:
dEQP-VK.spirv_assembly.instruction.graphics.opname.*
Components: Vulkan
VK-GL-CTS issue: 936
VK-GL-CTS public issue: 76
Change-Id: I2c15b9a8cc9d1482548c32bf7f1acf8d02fc2e89
Chris Forbes [Tue, 20 Feb 2018 23:30:09 +0000 (15:30 -0800)]
Merge remote-tracking branch 'aosp/master' into deqp-dev
Change-Id: Ia51b278e9d2a1c40aa55162f03a420877564dc51
Treehugger Robot [Fri, 16 Feb 2018 19:18:40 +0000 (19:18 +0000)]
Merge "Fix missing precision qualifiers in multiview tests"
Chris Forbes [Thu, 15 Feb 2018 18:14:12 +0000 (10:14 -0800)]
Temporarily exclude unspecified-precision tests
Change-Id: I3849dcef5718c73e0aac4a92b355ed4012a81240
Components: AOSP
Bug: b/
73070970
james.glanville [Thu, 15 Feb 2018 15:50:04 +0000 (15:50 +0000)]
Fix missing precision qualifiers in multiview tests
Multiview final fragment shader was missing some precision qualifiers,
causing compilation failures.
Affects:
dEQP-GLES3.functional.fbo.multiview.*
Change-Id: I25c268260b6676eb666666ca8e675e5fa7ec7303
Bas Nieuwenhuizen [Thu, 15 Feb 2018 10:33:22 +0000 (11:33 +0100)]
DO NOT MERGE: Fix dEQP-VK.api.copy_and_blit.image_to_image_depth value range.
Per spec:
"Because depth or stencil aspect buffer to image copies may require format conversions on some
implementations, they are not supported on queues that do not support graphics. When copying to
a depth aspect, the data in buffer memory must be in the the range [0,1] or undefined results occur."
Initializing it to integer values falls afoul of this rule
quickly. As the image is 256 by 256, x/255.0 should always fall in the range [0,1].
Not entirely sure this would initialize combined depth stencil correctly,
but this version of CTS does not have a test using those formats with
this code.
This has been fixed upstream for a while with
"
9909b9f3 Fix combined depth/stencil clear colors."
but this is not a straight backport as these tests saw some significant rework between
this CTS version and the fix.
Bug: b/
73449389
Change-Id: Iaf0ce14ed4338d437f1b20033be5d0f8c0cbd699
Chris Forbes [Thu, 15 Feb 2018 00:25:39 +0000 (16:25 -0800)]
Merge remote-tracking branch 'aosp/master' into deqp-dev
Change-Id: Iee4ea748158c78112727bf21b905432b62b4fca9
Chris Forbes [Wed, 14 Feb 2018 17:22:18 +0000 (09:22 -0800)]
Merge remote-tracking branch 'khronos/master' into deqp-dev
Change-Id: Ib2085147e9679d6dd16109c660f9777d680d54fe
Juan A. Suarez Romero [Tue, 30 Jan 2018 09:55:40 +0000 (10:55 +0100)]
Add more cases for block/non-block uniforms match
Cover more situations as described in GLSL 3.20 spec, section 4.3.9.
- It is a link-error when using the same name inside a block with non
instance name and outside a block, but it is correct if the block has
instance name.
- It is a link-error when using the same name inside two different
blocks with non instance name.
Components: OpenGL
VK-GL-CTS issue: 972
Affects:
KHR-GLES3.shaders.uniform_block.common.name_matching
KHR-GL33.shaders.uniform_block.common.name_matching
Change-Id: Ie91300685e807774a9cc9bbb9139936133a8ae1c
Piotr Byszewski [Mon, 29 Jan 2018 08:58:50 +0000 (09:58 +0100)]
Fix texture lookups tests
Some shaders didn't compile because of use of reserved word
textureCubeLod. This patch fixes this by checking if
ES implementation is ES3 capable and adjusting the shaders
generation parameters accordingly.
Components: OpenGL
VK-GL-CTS issue: 283
Affects:
dEQP-GLES2.functional.shaders.random.texture.vertex.*
Change-Id: Ib1e9983a9503780f992dcd00e8dc380a4f01bef4
Piotr Byszewski [Tue, 30 Jan 2018 14:19:34 +0000 (15:19 +0100)]
Fix invalid_assign_to_1 fragdata tests
For ES3 capable hardware compilation of shaders in
invalid_assign_to_1 test succeeds resulting in test failure.
This patch resolves that by adding only_glsl_es_100_support
and exactly_one_draw_buffer flags that indicate that test
shouldn't be executed on ES3 capable hardwere or on a
implementation that supports more then one draw buffer.
This change also removes redundant CaseRequirement structure
and parses requirements directly to ShaderCaseSpecification.
Components: OpenGL
VK-GL-CTS issue: 282
Affects:
dEQP-GLES2.functional.shaders.fragdata.invalid_assign_to_1
dEQP-GLES2.functional.shaders.*
dEQP-GLES3.functional.shaders.fragdata.invalid_assign_to_1
dEQP-GLES3.functional.shaders.*
Change-Id: I44949fde7ac9bc724965ec166ed55433c91857c2
Piotr Byszewski [Thu, 1 Feb 2018 12:08:10 +0000 (13:08 +0100)]
Fix texturecubelod test
This patch fixes issue with validation of texturecubelod
test result. Issue happened when test was executed on ES3
capable hardware.
Components: OpenGL
VK-GL-CTS issue: 280
Affects:
dEQP-GLES2.functional.shaders.texture_functions.vertex.*
Change-Id: I92d81ca93cb84785ea806155d0436f167c4fbf31
Juan A. Suarez Romero [Mon, 15 Jan 2018 11:10:46 +0000 (11:10 +0000)]
Check for depth/stencil buffer in default FBO
The affected tests invoke gl.getNamedFramebufferAttachmentParameteriv()
with GL_FRAMEBUFFER_ATTACHMENT_DEPTH_SIZE to get the depth bits used in
the default FBO. And something similar is done for the stencil bits.
But wrongly it assumes that if the FBO does not have an associated depth
or stencil buffer, it would return 0. Rather, this function returns an
error if it is invoked in a FBO without a depth/stencil buffer attached.
So better check first if the default FBO has a depth/stencil buffer
attached, and if so then invoke the above functions to get the
depth/stencil bits.
Components: OpenGL
VK-GL-CTS issue: 969
Affects:
KHR-*.internalformat.renderbuffer.*
Change-Id: I74d28d5d089790fed4dd2728cb5143e7c03d7442
Jari Komppa [Wed, 3 Jan 2018 11:00:55 +0000 (13:00 +0200)]
Added image blit tests with multi-part image lock
Added versions of the image blitting tests that lock the image resource
in multiple parts to stress the VK_REMAINING_MIP_LEVELS and
VK_REMAINING_ARRAY_LAYERS functionality.
Affects:
dEQP-VK.api.copy_and_blit.core.blit_image.all_formats.generate_mipmaps.from_previous_level.*
Components: Vulkan
VK-GL-CTS issue: 901
Change-Id: Ia7f80a0ff1b432af8fe4e032f7e6524785c90bf8
Paavo Pessi [Fri, 26 Jan 2018 13:33:37 +0000 (15:33 +0200)]
Add API info tests for YCbCr formats
The API feature info tests were extended to query physical device's
image format capabilities using YCbCr formats.
New tests:
dEQP-VK.api.info.image_format_properties.2d.*
dEQP-VK.api.info.image_format_properties2.2d.*
Components: Vulkan
VK-GL-CTS issue: 961
Change-Id: I04b948ff3f3f2af809c87c5f6c251385e5bba24f
Chris Forbes [Tue, 13 Feb 2018 21:27:05 +0000 (21:27 +0000)]
Merge "Merge remote-tracking branch 'origin/vulkan-cts-1.0.2' into HEAD" into oreo-cts-dev am:
6d6ebc1b4b
am:
cc01ada806
Change-Id: I6827e2294199817a66666ed5db941491f5462f2a
Chris Forbes [Tue, 13 Feb 2018 21:20:03 +0000 (21:20 +0000)]
Merge "Merge remote-tracking branch 'origin/vulkan-cts-1.0.2' into HEAD" into oreo-cts-dev
am:
6d6ebc1b4b
Change-Id: I71f98787bf29843efbe66343187c3a67c7ca39f9
Treehugger Robot [Tue, 13 Feb 2018 21:08:38 +0000 (21:08 +0000)]
Merge "Merge remote-tracking branch 'origin/vulkan-cts-1.0.2' into HEAD" into oreo-cts-dev
Piotr Byszewski [Tue, 23 Jan 2018 09:43:37 +0000 (10:43 +0100)]
Fix TCS negative test
One of three tests that are checking incorrectly sized tessellation
control output array was actually correct. This is fixed by changing
array size to value that is small then layout declaration. Remaining
two tests check if compilation fails when value is greater then
layout declaration.
Components: OpenGL
VK-GL-CTS issue: 297
Affects:
dEQP-GLES31.functional.tessellation.user_defined_io.negative.es32.per_vertex_incorrect_control_explicit_output_array_size_1
Change-Id: I3f06e36ab8bab4eae541204bdab5db1f5d698ff2
Ilia Mirkin [Sat, 10 Feb 2018 17:59:54 +0000 (12:59 -0500)]
glx: add getProcAddress override
The regular function pointers are filled in on load, but any additional
pointers, potentially from extensions, requested by tests would end up
with NULLs, triggering failures.
Affects:
KHR-GL45.transform_feedback.draw_xfb_instanced_test
KHR-GL45.transform_feedback.draw_xfb_stream_instanced_test
Kantoch [Fri, 9 Feb 2018 19:05:40 +0000 (19:05 +0000)]
DO NOT MERGE: Sparse resources fixes am:
ae793c389b -s ours am:
ce25f76fbb -s ours
am:
fe93d4f83c -s ours
Change-Id: I14929e52bc985f4d152628b48b4a6a76577738a7
Kantoch [Fri, 9 Feb 2018 19:00:10 +0000 (19:00 +0000)]
DO NOT MERGE: Sparse resources fixes am:
ae793c389b -s ours
am:
ce25f76fbb -s ours
Change-Id: I8fa668d939b6c45df4590f823b029536895b4574
Kantoch [Fri, 9 Feb 2018 18:54:40 +0000 (18:54 +0000)]
DO NOT MERGE: Sparse resources fixes
am:
ae793c389b -s ours
Change-Id: Ib87ed9843313e5ba76ccae32161ed5719615fa55
Lionel Landwerlin [Fri, 9 Feb 2018 15:20:25 +0000 (15:20 +0000)]
YCbCr: go through the correct location ranges when sampling
Affects: dEQP-VK.ycbcr.conversion.*
Components: Vulkan
VK-GL-CTS issue: 1005
Change-Id: Ifac1026e82e1bb48195fc7ab5429951a15324042
Paavo Pessi [Mon, 22 Jan 2018 12:23:53 +0000 (14:23 +0200)]
Add descriptor set layout lifetime tests
Test was added to verify that implementation honors descriptor set
layout lifetime. Descriptor set layout is destroyed immediately
after creating the pipeline layout, prior to creating the pipeline.
New tests:
dEQP-VK.api.descriptor_set.descriptor_set_layout_lifetime.graphics
dEQP-VK.api.descriptor_set.descriptor_set_layout_lifetime.compute
Components: Vulkan
VK-GL-CTS issue: 856
Change-Id: I978675ddea30e3b312db4bc65da77c26149cc2df
Alexander Galazin [Tue, 6 Feb 2018 12:39:17 +0000 (13:39 +0100)]
Update Vulkan CTS Readme
Update Vulkan CTS Readme to point to 1.0.3 mustpass
Components: Vulkan
Change-Id: I4d22a233418363476c149e22b5358e8052083f2b
Maciej Jesionowski [Wed, 29 Nov 2017 13:07:42 +0000 (14:07 +0100)]
Remove max expected query result in pipeline statistics tests
Query result is implementation-defined and some internal rendering
operations may count towards the results of queries.
Affects: dEQP-VK.query_pool.statistics_query.*
Components: Vulkan
VK-GL-CTS issue: 876
Change-Id: I0c86e1101c1ae00049623bd49dfe0c4de5798832
(cherry picked from commit
d6b9480d2d7bc67d7ef9522f001f1367f08fbaea)
Jari Komppa [Fri, 2 Feb 2018 13:00:22 +0000 (15:00 +0200)]
Added optimization avoiding shader disassembly
This change avoids disassembling shaders if the
--deqp-log-shader-sources=disable option is used.
The default functionality disassembles everything and discards the
result if the shader source logging is disabled. This change skips the
disassembly too.
The performance gain for this is approximately 10% of runtime.
The timings are based on assumption of debug build and having the
shader cache with zero cache misses.
Affects:
none
Components: Framework
Vk-GL-CTS isue: 899
Change-Id: I36eda000a94400d8f50a565c7ef30f4170d51c83
Hernan Liatis [Wed, 24 Jan 2018 01:47:07 +0000 (17:47 -0800)]
Create Compute tests for OpName
These tests makes sure that OpName has no impact on the semantics of
compute kernels.
New tests:
dEQP-VK.spirv_assembly.instruction.compute.opname.entry_main.*
dEQP-VK.spirv_assembly.instruction.compute.opname.entry_rdc.*
Components: Vulkan
VK-GL-CTS issue: 936
VK-GL-CTS public issue: 76
Change-Id: I1ba6b3e47fe838d9ecc721daa78a869bfcf8bc8f
Courtney Goeltzenleuchter [Wed, 7 Feb 2018 23:54:23 +0000 (23:54 +0000)]
Merge "Separate HDR metadata into two tests"
Kantoch [Tue, 19 Jul 2016 11:37:33 +0000 (13:37 +0200)]
DO NOT MERGE: Sparse resources fixes
1. Do not allow to request more queues than available
2. Allow to reuse queue if it supports more than one type of operations
(cherry picked from VK-GL-CTS commit
5f2cf2f7139c2f603a02fe3c284921dd9152dee3)
Bug: b/
72734354
Change-Id: Ia063df59c2220a082ea5a73a0fc968cfb97fda2c
Mark Adams [Wed, 7 Feb 2018 17:36:09 +0000 (17:36 +0000)]
Handle unsupported no_config contexts am:
b60ae978ad
am:
307c716b4e
Change-Id: I2f90861c7c32f75a1611cc13f0e892195daee747
Mark Adams [Wed, 7 Feb 2018 17:31:36 +0000 (17:31 +0000)]
Handle unsupported no_config contexts
am:
b60ae978ad
Change-Id: Idf51783fac99d14fa5ed28dbffd0db36b80e998b
Courtney Goeltzenleuchter [Wed, 7 Feb 2018 00:57:42 +0000 (16:57 -0800)]
Separate HDR metadata into two tests
Separated the HDR metadata test into two tests that
each test a single HDR metadata extension (SMPTE 2086 and CTA 861.3).
Also rename test group to be more specific to tests being added.
Change-Id: Icb98a5f47796c2c21faf0020221e9f5bb2969f9d
Paavo Pessi [Thu, 11 Jan 2018 09:52:45 +0000 (11:52 +0200)]
Test updating set with an empty binding
This test matches VkPositiveLayerTest.EmptyDescriptorUpdateTest and
updates the last descriptor in a set that includes an empty binding.
The test doesn't check any results and it passes as long as no crash
happens.
New tests:
dEQP-VK.binding_model.descriptor_update.empty_descriptor.uniform_buffer
Components: Vulkan
VK-GL-CTS issue: 831
Change-Id: I795e08fa516d42d980d7b3b8baba6a1ba4a29ec7
Paavo Pessi [Mon, 15 Jan 2018 12:40:38 +0000 (14:40 +0200)]
Test discontiguous descriptor sets
Test two descriptor sets bound to discontiguous set numbers with
different descriptor types and shader stages.
New tests:
dEQP-VK.binding_model.shader_access.*.multiple_discontiguous_descriptor_sets.*
Components: Vulkan
VK-GL-CTS issue: 902
Change-Id: I81b94e5a319738411958f93a02a27ba80b5dbbb8
Mika Väinölä [Thu, 18 Jan 2018 13:02:00 +0000 (15:02 +0200)]
Test creating device when out of host memory
This test matches Allocation.CreateInstanceDeviceIntentionalAllocFail
found in loader validation tests which fails on some shipping drivers.
New tests:
dEQP-VK.api.device_init.create_instance_device_intentional_alloc_fail
Components: Vulkan
VK-GL-CTS issue: 823
Change-Id: I8a9d3bce86beac81fc53f2d58a002dee2318610d
Marcin Rogucki [Thu, 25 Jan 2018 16:18:20 +0000 (17:18 +0100)]
UnpackHalf2x16: consistent subnormal 16bit values
Added subnormal values to the test.
3 subnormal special values added:
- mantissa LSB set
- mantissa MSB set
- all mantissa bits set
15 randomly generated subnormal values added.
Test passes iff:
- all normal values are bit by bit matching
and
- all subnormal values are bit by bit matching
or
- all subnormal values are flushed as zeros
Components: Vulkan
VK-GL-CTS issue: 798
Changes:
dEQP-VK.glsl.builtin.function.pack_unpack.unpackhalf2x16_*
Change-Id: Ib211ec70fac00f94d8dd3496c36a34f4ae17a593
Juan A. Suarez Romero [Thu, 25 Jan 2018 12:23:18 +0000 (12:23 +0000)]
Add operation tests for 64-bit integers
This create tests for SPIR-V arithmetic operations that deal with
integer types.
Right now it covers 32-bit and 64-bit signed and unsigned integers, but
it is designed to easily extend to other types, like 16-bit integers.
New tests:
dEQP-VK.spirv_assembly.type.*
VK-GL-CTS issue: 187
Components: Vulkan
Change-Id: Ib84024019d33bac5026cba5e39bc7247c15ba5bb
Chris Forbes [Tue, 6 Feb 2018 01:12:53 +0000 (17:12 -0800)]
Merge remote-tracking branch 'origin/vulkan-cts-1.0.2' into HEAD
Bug: b/
72972234
Change-Id: I537a4f3207c1f88d68a51a23f21a5fed0975b037
Chris Forbes [Mon, 5 Feb 2018 22:52:52 +0000 (14:52 -0800)]
Merge remote-tracking branch 'origin/master' into HEAD
Change-Id: I46bafca084cccb850bdef6657548fc34088ef0af
Chris Forbes [Mon, 5 Feb 2018 21:10:48 +0000 (13:10 -0800)]
Merge remote-tracking branch 'aosp/master' into HEAD
Change-Id: Iecc6b03291d94c485544ba6a270161f69fa267e3
Chris Forbes [Mon, 5 Feb 2018 20:21:03 +0000 (20:21 +0000)]
Merge "Fix issues in the multiview tests"
Sean Callanan [Mon, 29 Jan 2018 19:55:37 +0000 (11:55 -0800)]
Test invalid precision specifier in initializer
The expression
mediump vec2 v = mediump vec2(...);
is not legal GLSL because of the "mediump" in the initializer.
Many implementations accept it, though. This test verifies that they
catch the syntax error correctly.
Bug:
13881278
Test: Ran this on X11 GLX, saw the test case fail as desired
Change-Id: I12e59ce2d813e72f878ae5c8eaf384063b362cdf
Alexander Galazin [Mon, 5 Feb 2018 12:13:47 +0000 (13:13 +0100)]
Merge vk-gl-cts/vulkan-cts-1.0.3 into vk-gl-cts/master
Change-Id: I5197455fbb3dc596087f7e9ca344ef67e011455b
Alexander Galazin [Mon, 5 Feb 2018 12:13:42 +0000 (13:13 +0100)]
Merge vk-gl-cts/vulkan-cts-1.0.2 into vk-gl-cts/vulkan-cts-1.0.3
Change-Id: If7dc3d47395a03af3a34987f08c873c13effd366
Alexander Galazin [Mon, 5 Feb 2018 08:36:46 +0000 (09:36 +0100)]
Fix issues in the multiview tests
* Fix few asserts
* Add forgotten TestLog::EndSection
Components: AOSP
Affects: dEQP-GLES3.functional.mulitiview.*
Change-Id: Ieb7d09beace12ce7f00e6d9cddacea2465101cca
Piotr Byszewski [Fri, 19 Jan 2018 14:15:07 +0000 (15:15 +0100)]
Fix ES2 rbo clear tests for RGB5_A1
color_clear and stencil_clear tests for GL_RGB5_A1 format
should not perform validation for alpha channel as
test thresholds for this channel do not account for dithering.
Components: OpenGL
VK-GL-CTS issue: 348
Affects:
dEQP-GLES2.functional.fbo.render.color_clear.*
dEQP-GLES2.functional.fbo.render.stencil_clear.*
Change-Id: I72fb6ec98dacfe9b2ad8178d0a01f7bb0bee01fc
Daniel Koch [Wed, 31 Jan 2018 22:22:15 +0000 (17:22 -0500)]
Fix use of sparse binding queue on default context
Avoid trying to create two separate queues
when the queueIndex and sparseQueueIndex are the same,
as this violates valid usage which states:
"The queueFamilyIndex member of each element of pQueueCreateInfos
must be unique within pQueueCreateInfos"
Affects:
All vulkan tests
The forerunner change claimed it only affected the following specifically:
dEQP-VK.texture.shadow.*
dEQP-VK.renderpass.sparserendertarget.*
Component: Vuklan
VK-GL-CTS issue: 898, 964
Change-Id: I342e11f9a63eab875336b8078890e677a5d29a2d
Vamsidhar Gaddam [Wed, 31 Jan 2018 10:23:48 +0000 (11:23 +0100)]
Pass in proper pWaitDstStageMask in vktWsiSharedPresentableImageTests
One of the submitInfos for a queue submit had
a semaphore passed in without passing in any stage mask. This is a
spec violation.
Affects:
dEQP-VK.wsi.android.shared_presentable_image.*
Components: Vulkan
VK-GL-CTS issue: 974
Change-Id: Iee2ea838e971a3610f44b8c1f765869a8a21fedb
Panagiotis Apostolou [Wed, 17 Jan 2018 09:01:58 +0000 (10:01 +0100)]
Spec relaxation for YCbCr Implicit chroma reconstruction
Incorporates spec relaxation in the YCbCr tests which describes that when
doing implicit reconstruction with nearest chroma filtering, an
implementation may behave as if both xChromaOffset and yChromaOffset were
VK_CHROMA_LOCATION_MIDPOINT.
Tests affected:
dEQP-VK.ycbcr.conversion.*
Components: Vulkan
VK-GL-CTS issue: 979
Change-Id: I10e83d2f5845c3e74673aa9e42fc4f0950f9e6cd
Alexander Galazin [Thu, 1 Feb 2018 11:48:25 +0000 (12:48 +0100)]
Note that git/python/cmake must be in PATH
Components: Vulkan
VK-GL-CTS issue: 931
Change-Id: I92197ee4e6b03ff3e220936f73ec73e6808be792
Chris Forbes [Sat, 3 Feb 2018 01:14:59 +0000 (17:14 -0800)]
Don't try to pass metadata attribs to eglCreate*Surface
These attribs are only valid for eglSurfaceAttrib / eglQueryAttrib.
Bug: b/
72870242
Change-Id: I6aad5c19e24f775e0b8be6374716cb4ceef01491
Treehugger Robot [Fri, 2 Feb 2018 20:37:08 +0000 (20:37 +0000)]
Merge "Fixes pixelformat utils for RGB10_A2"
Alexander Galazin [Fri, 2 Feb 2018 15:37:21 +0000 (16:37 +0100)]
Merge vk-gl-cts/vulkan-cts-1.0.3 into vk-gl-cts/master
Change-Id: I0ec19f7ba49c9c543cc3a0268779af0768e06d49
Ari Suonpaa [Tue, 26 Sep 2017 07:51:57 +0000 (10:51 +0300)]
Add sparse image support for pipeline multisample tests.
Extended pipeline multisample tests to support source images that
are using sparse binding.
Affects:
dEQP-VK.pipeline.multisample.*
Components: Vulkan
VK-GL-CTS issue: 101
Change-Id: Ice9624de3e88d0a5daf6574f257714fa83db0877
Treehugger Robot [Fri, 2 Feb 2018 04:19:27 +0000 (04:19 +0000)]
Merge "GLES2/3: error on declarations with unspecified precision"
Treehugger Robot [Fri, 2 Feb 2018 01:14:33 +0000 (01:14 +0000)]
Merge "Relax ULP requirement for Log/Log2"
Chris Forbes [Thu, 1 Feb 2018 23:53:06 +0000 (15:53 -0800)]
Merge remote-tracking branch 'aosp/master' into HEAD
Change-Id: Ib3563123d2da1bd9fe6b81a9aa02cfadfad004c5
Juan A. Suarez Romero [Thu, 11 Jan 2018 12:52:42 +0000 (13:52 +0100)]
Return UNSUPPORTED if no compressed textures available
When testing compressed textures, return NOT_SUPPORTED if none of the
compressed textures under testing are available, instead of returning
FAIL.
Components: OpenGL
VK-GL-CTS issue: 943
Affects:
KHR-GLES2.texture_3d.compressed_texture.negative_compressed_*
Change-Id: I77d18fdbb86fef88c680f63f7fe522ed079887aa