Matthew Netsch [Fri, 17 Sep 2021 15:56:59 +0000 (11:56 -0400)]
Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5
Change-Id: I521f0b1f6f4c3a86e8612239ce2134be76e5d16a
Matthew Netsch [Fri, 17 Sep 2021 15:56:48 +0000 (11:56 -0400)]
Merge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/vulkan-cts-1.2.4
Change-Id: Ic1ab6043f9d70b8491192137c6d8c2fc12f2112d
Ilkka Saarelainen [Tue, 7 Sep 2021 13:03:46 +0000 (16:03 +0300)]
Remove invalid SPIR-V decorations
Some SPIR-V asm tests used invalid Binding and DescriptorSet decorations.
This CL removes those decorations.
Affects:
dEQP-VK.spirv_assembly.instruction.compute.physical_pointers.complex_types_compute.*
dEQP-VK.spirv_assembly.instruction.compute.pointer_parameter.buffer_memory
dEQP-VK.spirv_assembly.instruction.graphics.pointer_parameter.buffer_memory*
dEQP-VK.spirv_assembly.instruction.graphics.16bit_storage.input_output_float_16_to_16x2.scalar
dEQP-VK.spirv_assembly.instruction.graphics.16bit_storage.input_output_float_16_to_16x2.vec2
dEQP-VK.spirv_assembly.instruction.graphics.16bit_storage.input_output_int_16_to_16x2.scalar_int
dEQP-VK.spirv_assembly.instruction.graphics.16bit_storage.input_output_int_16_to_16x2.scalar_uint
dEQP-VK.spirv_assembly.instruction.graphics.16bit_storage.input_output_int_16_to_16x2.ivec2
dEQP-VK.spirv_assembly.instruction.graphics.16bit_storage.input_output_int_16_to_16x2.uvec2
Components: Vulkan
VK-GL-CTS issue: 3063
Change-Id: Icfee33f9ce041bf60a19fba55aef9fdab0747148
Peter Kohaut [Fri, 3 Sep 2021 07:33:02 +0000 (09:33 +0200)]
Merge branch 'vulkan-cts-1.2.4' into vulkan-cts-1.2.5
Change-Id: I952af5b744206c52b4161d8c1102b6a8c2a53f58
Peter Kohaut [Thu, 2 Sep 2021 20:22:53 +0000 (22:22 +0200)]
Merge branch 'vulkan-cts-1.2.3' into vulkan-cts-1.2.4
Change-Id: Ica9ea69514cd36415ad89f4b34e8384b0523181c
Peter Kohaut [Thu, 2 Sep 2021 17:05:54 +0000 (19:05 +0200)]
Merge remote-tracking branch 'origin/vulkan-cts-1.2.2' into vulkan-cts-1.2.3
Change-Id: I3c5b289149d9f2601b5d5ab8986d41b3f33f8bab
Alex Walters [Thu, 12 Aug 2021 13:12:55 +0000 (14:12 +0100)]
Correct Vulkan multiview 'tesellation' test names
Tests are renamed from 'tesellation' to 'tessellation' but are otherwise
unchanged.
Affects:
dEQP-VK.multiview*tessellation*
Components: Vulkan
Change-Id: I1686bb6fb8a0e85e201853602f840e03e847169d
Mike Byrne [Mon, 9 Aug 2021 11:40:07 +0000 (12:40 +0100)]
Fix protected memory ssbo pipeline barrier use
Incorrect stage flags are passed to vkCmdPipelineBarrier in the copy
buffer operation in the dEQP-VK.protected_memory.ssbo.ssbo_read.*
These tests were introduced in origin/vulkan-cts-1.1.0
Components: Vulkan
Affects:
dEQP-VK.protected_memory.ssbo.*
VK-GL-CTS Issue: 3041
Change-Id: Iccdb96fee30e32bf26dec1e26d65ea8d5600c384
John Anthony [Wed, 18 Aug 2021 20:16:53 +0000 (22:16 +0200)]
Add missing vertexPipelineStoresAndAtomics checks in ray query tests
Affected tests:
dEQP-VK.ray_query.acceleration_structures.*.vertex_shader.*
dEQP-VK.ray_query.acceleration_structures.*.tess_control_shader.*
dEQP-VK.ray_query.acceleration_structures.*.tess_evaluation_shader.*
dEQP-VK.ray_query.acceleration_structures.*.geometry_shader.*
dEQP-VK.ray_query.ray_flags.vertex_shader.*
dEQP-VK.ray_query.ray_flags.tess_control_shader.*
dEQP-VK.ray_query.ray_flags.tess_evaluation_shader.*
dEQP-VK.ray_query.ray_flags.geometry_shader.*
dEQP-VK.ray_query.traversal_control.vertex_shader.*
dEQP-VK.ray_query.traversal_control.tess_control_shader.*
dEQP-VK.ray_query.traversal_control.tess_evaluation_shader.*
dEQP-VK.ray_query.traversal_control.geometry_shader.*
Components: Vulkan
VK-GL-CTS Issue: 3069
Change-Id: I49c37d292380fda47b113bf4fa14a6395f8e81a5
Ilkka Saarelainen [Thu, 12 Aug 2021 07:22:22 +0000 (10:22 +0300)]
Fix error in build_apk.py
A typo caused build_apk.py to fail if required Android build
tools were missing.
Components: framework
Change-Id: Ia55b95a9057a37152e5a4c91773b1eaa3abc0156
Alexander Galazin [Thu, 12 Aug 2021 18:56:51 +0000 (20:56 +0200)]
Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5
Change-Id: Id1af44b78cbe4ba82cc76c656e0a22421ac20073
Alexander Galazin [Thu, 12 Aug 2021 18:03:29 +0000 (20:03 +0200)]
Merge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/vulkan-cts-1.2.4
Change-Id: I13ff1ac57c064dc46bbc7c555ba1fed07e04080c
Alexander Galazin [Thu, 12 Aug 2021 18:02:19 +0000 (20:02 +0200)]
Merge vk-gl-cts/vulkan-cts-1.2.2 into vk-gl-cts/vulkan-cts-1.2.3
Change-Id: Iab13500b9aaa9b6da0e99ea9d93fe9cabc66da33
Ari Suonpaa [Fri, 6 Aug 2021 12:08:21 +0000 (15:08 +0300)]
Relax protected heap allocation tests
Some implementations have limitations on protected heap
allocations, and these limitations cannot be queried
using the Vulkan API. This change allows an out-of-memory
to happen after a certain number of allocations to
compensate that.
VK-GL-CTS Issue: 3038
Affects:
dEQP-VK.memory.*allocation.*
Components: Vulkan
Change-Id: I3a34637c8c15eb8670613dce9b6e394a622a4c71
Alexander Galazin [Tue, 27 Jul 2021 10:25:19 +0000 (12:25 +0200)]
Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5
Change-Id: I22fcd718aadfed74408323615cc4bf58618d979a
Alexander Galazin [Tue, 27 Jul 2021 09:29:33 +0000 (11:29 +0200)]
Merge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/vulkan-cts-1.2.4
Change-Id: If23bb885846d42651d7ac77b375b6c44ea02fa93
Alexander Galazin [Tue, 27 Jul 2021 08:01:37 +0000 (10:01 +0200)]
Merge vk-gl-cts/vulkan-cts-1.2.2 into vk-gl-cts/vulkan-cts-1.2.3
Change-Id: If1bb9f63d56815c3ced2ac72d17d4e55ec090f39
Samuel Iglesias Gonsálvez [Thu, 15 Jul 2021 10:15:09 +0000 (12:15 +0200)]
Fix early destruction of VkPipelineLayout
Components: Vulkan
VK-GL-CTS issue: 3004
Affected:
dEQP-VK.sparse_resources.shader_intrinsics.*
Change-Id: Id5508fac89961c5bb934005257d2caa26d32f2dd
Signed-off-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com>
Ari Suonpaa [Wed, 9 Sep 2020 11:27:26 +0000 (14:27 +0300)]
Fix validation errors in AHB tests
AHB protected memory tests were also removed as the test
tried to use protected memory without creating a device
and queue that would support protected operations.
VK-GL-CTS Issue: 2508
Affects:
dEQP-VK.api.external.memory.android_hardware_buffer.*
Components: Vulkan
Change-Id: I307e7450d06d20b6497f2a529e5724ae0538e5a9
Piotr Byszewski [Thu, 9 Apr 2020 11:41:09 +0000 (13:41 +0200)]
Clean ExternalMemoryUtil
This change separates choosing of memory type from
allocateExportableMemory utility function. This makes
use of this functions more clear.
Previous implementation needed to be done ASAP and
involved passing of non-const reference to
allocateExportableMemory which was then filled.
This workaround made code unnecessarily hard to follow.
Components: Vulkan
VK-GL-CTS issue: 587
Affects:
dEQP-VK.api.external.memory.*
dEQP-VK.synchronization.signal_order.*
dEQP-VK.synchronization.cross_instance.*
Change-Id: I781388db390f13c7c03785dd0ae34ae0128ec31c
Sławomir Cygan [Thu, 15 Jul 2021 13:22:26 +0000 (15:22 +0200)]
Remove tests with too many overlapping instances in the accelleration structure
These tests generate a grid of random triangles and assign them to the large
number of instances in the acceleration structure. Because of the randomness,
all instances overlap with each other and the accelleration structure is extremely
slow to trace - as each ray must traverse through all instances.
This change removes some tests cases with 65536 instances and tests cases with
1048576 instances to avoid device timeouts.
The tests apply only to implementations with host accelleration structure builds
supported.
Components: Vulkan
VK-GL-CTS Issue: 3005
Change-Id: I94bcde596cd097672cf8e00c6fe018328998cb37
Affects: dEQP-VK.ray_tracing_pipeline.build.*
Alexander Galazin [Thu, 8 Jul 2021 18:08:17 +0000 (20:08 +0200)]
Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5
Change-Id: I41d5f00d649218e1418c13591f50885858624198
Alexander Galazin [Thu, 8 Jul 2021 17:09:43 +0000 (19:09 +0200)]
Merge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/vulkan-cts-1.2.4
Change-Id: I166b558acc75b2d9259620be5fb8ba89eaa10841
Alexander Galazin [Thu, 8 Jul 2021 16:27:33 +0000 (18:27 +0200)]
Merge vk-gl-cts/vulkan-cts-1.2.2 into vk-gl-cts/vulkan-cts-1.2.3
Change-Id: Ic61d3218b466b8fd2c50127867a0cfdb77c07637
Alexander Galazin [Thu, 8 Jul 2021 15:37:58 +0000 (17:37 +0200)]
Merge vk-gl-cts/vulkan-cts-1.2.1 into vk-gl-cts/vulkan-cts-1.2.2
Change-Id: I7c0abe6efdeab69b5928cc0e67a6365f15b1e5c5
Mohankumar Nekkarakalaya [Wed, 7 Jul 2021 23:00:03 +0000 (16:00 -0700)]
Call computeFixedPointError only for fixed point case
Calling computeFixedPointError for integer case (numAccurateBits=32)
is incorrect and causes crash.
Added assert to make sure numAccurateBits is in legal range.
Affected tests: dEQP-VK.sparse_resources.image_sparse_residency.*
Components: Vulkan
VK-GL-CTS issue: 2994
Change-Id: Ib357cbbbda0f7980ec2d7115053cabc6825a18d3
Iago Toral Quiroga [Tue, 6 Jul 2021 09:10:04 +0000 (11:10 +0200)]
Avoid overflowing arrays in GLSL atomic tests
Tilers may need to execute vertex pipeline stages more than once,
leading to additional shader invocations. This is a problem for atomic
tests, since their result depends on the number of shader invocations
executed.
This is already handled properly for vertex shaders but not for other
vertex pipeline stages.
Affected tests:
dEQP-VK.glsl.atomic_operations.*
Components: Vulkan
VK-GL-CTS issue: 2987
Co-authored-by: Ricardo Garcia <rgarcia@igalia.com>
Change-Id: Iab08e3fb2ef40fc29dcf073817e5fd5dd49e7875
Sławomir Cygan [Fri, 25 Jun 2021 14:08:23 +0000 (16:08 +0200)]
Fix semaphore leak in image atomic operations test
The class 'Image', being base class for `SparseImage` class needs to be
marked as virtual, so objects of SparseImage type can be owned and
destroyed through a pointer of `Image` type. Without that the implicit
destructor of `SparseImage` class is never called.
As SparseImage class has a semaphore member, this fixes the
semaphore VK object leak.
Components: Vulkan
VK-GL-CTS Issue: 2981
Change-Id: Ice24f7018cf9144f4c1adbb8987b730d5f1ca2aa
Affects: dEQP-VK.image.atomic_operations.*
Lars-Ivar Hesselberg Simonsen [Fri, 23 Apr 2021 10:04:44 +0000 (12:04 +0200)]
Fix use of binary semaphore in signaled state
Vulkan spec specifies that binary semaphore waits and signals should
occur in discrete 1:1 pairs.
This change ensures that the binary semaphore signaled by
synchronizationWrapper[SECOND] is waited on before being used again,
which resolves the corresponding validation layer error.
In addition, the change fixes an issue where the second submission pair
did not correctly swap semaphore info.
Components: Vulkan
Affects:
dEQP-VK.synchronization.basic.binary_semaphore.multi_queue
dEQP-VK.synchronization.basic.binary_semaphore.multi_queue_typed
dEQP-VK.synchronization.basic.timeline_semaphore.multi_queue
VK-GL-CTS Issue: 2910
Change-Id: Id2fb2211a43150e3acb5c07dd6c205c7a42296d5
(cherry picked from commit
a017db3c0d1fbf89f30253254d57fb869f57a430)
Sebastiano Cucinotta [Mon, 14 Jun 2021 15:15:40 +0000 (17:15 +0200)]
Properly enable Sample Shading in Fragment Shading Rate tests
Vulkan spec states:
> Sample shading is enabled for a graphics pipeline:
>
> * If the interface of the fragment shader entry point of the graphics
> pipeline includes an input variable decorated with SampleId or
> SamplePosition. In this case minSampleShadingFactor takes the value
> 1.0.
> * Else if the sampleShadingEnable member of the
> VkPipelineMultisampleStateCreateInfo structure specified when
> creating the graphics pipeline is set to VK_TRUE. In this case
> minSampleShadingFactor takes the value of
> VkPipelineMultisampleStateCreateInfo::minSampleShading.
>
> Otherwise, sample shading is considered disabled.
This change ensures that sample shading is properly enabled in the
Fragment Shading Rate tests relying on it by using gl_SampleId.
Components: Vulkan
Affects:
dEQP-VK.fragment_shading_rate.sampleshadinginput.*
VK-GL-CTS Issue: 2966
Change-Id: I7fad0ed7694a2d26ef7db9ea268fa5d6f93264a6
Alexander Galazin [Wed, 16 Jun 2021 07:43:06 +0000 (09:43 +0200)]
Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5
Change-Id: I01d6cedef0b807be928ba68d3aab64fd3d045d8d
Ricardo Garcia [Wed, 9 Jun 2021 11:28:55 +0000 (13:28 +0200)]
Fix dEQP-VK.info.device_extensions not working
The test is using the list of extension dependencies for instances
instead of devices, so it's actually not checking anything in most
cases.
Affected tests:
dEQP-VK.info.device_extensions
Components: Vulkan
VK-GL-CTS issue: 2959
Change-Id: I8ee2ea10f98e1dd45590edc2b5cc8e0c3e21890b
Ricardo Garcia [Wed, 9 Jun 2021 10:11:56 +0000 (12:11 +0200)]
SPIR-V 1.4 test fixes
This commit fixes a couple of SPIR-V 1.4 tests that had inconsistent
requirements in the Amber script and in the CTS side. In one case we're
dropping the requirement from Amber and in the other one we're adding
the requirement to CTS.
Affected tests:
dEQP-VK.spirv_assembly.instruction.spirv1p4.opptrnotequal.variable_pointers_vars_wg_not_equal
dEQP-VK.spirv_assembly.instruction.spirv1p4.hlsl_functionality1.member_decorate_string
Components: Vulkan
VK-GL-CTS issue: 2958
Change-Id: If1e58bc028ce3756623a241bb259024ef077c815
Alexander Galazin [Wed, 16 Jun 2021 06:52:23 +0000 (08:52 +0200)]
Merge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/vulkan-cts-1.2.4
Change-Id: I89ac6a1c9b0b7d908be65033c47371f60cc880cb
Slawomir Cygan [Wed, 19 May 2021 15:18:48 +0000 (17:18 +0200)]
Do not exceed heap size when allocating memory
It is invalid to make larger allocations than heap size.
Components: Vulkan
VK-GL-CTS Issue: 2927
Change-Id: I738356254d95a152a2bb89d711eb6b3f047b405c
Affects: dEQP-VK.memory.mapping
Slawomir Cygan [Tue, 11 May 2021 14:53:20 +0000 (16:53 +0200)]
Optimize the AS build tests to not use host uncached memory
Use userspace host memory for scratch buffer (instead mapped device memory)
and try using HOST_CACHED memory (if supported) for the accelleration structure.
Components: Vulkan
VK-GL-CTS Issue: 2922
Affects:
dEQP-VK.ray_tracing_pipeline.build.*
dEQP-VK.ray_tracing_pipeline.*
Change-Id: I7592c3f93f2e10766cd1276f37ca51924e1cc16f
Sławomir Cygan [Fri, 4 Jun 2021 15:49:38 +0000 (17:49 +0200)]
Add missing cull flags when counting intersections of rays with triangle-based cubes
Add a cull flags, so each convex geometry is counted once, instead of twice.
Components: Vulkan
VK-GL-CTS Issue: 2890
Affects:
dEQP-VK.ray_tracing_pipeline.misc.*stress*
dEQP-VK.ray_tracing_pipeline.misc.cullmask*
dEQP-VK.ray_tracing_pipeline.misc.mixedPrimTL
Change-Id: Ie2e74149be8bb710c7ae3afb77f5854dca247aca
Slawomir Cygan [Fri, 4 Jun 2021 15:45:39 +0000 (15:45 +0000)]
Revert "Move the hit counting from any hit to closest hit shader stage"
The problem with this test was in cull flags, rather than counting
in 'any hit' shader stage.
This reverts commit
2f33c7beac25308ef85a1856032d7a5936197f83.
VK-GL-CTS Issue: 2890
Change-Id: I066fac55a80ff4f4a93748425517785df8777d06
Affects: dEQP-VK.ray_tracing_pipeline.misc.*stress*
Ricardo Garcia [Fri, 28 May 2021 11:53:56 +0000 (13:53 +0200)]
Fix several issues in swapchain tests
This commit fixes the following issues found in the swapchain tests:
- The initial image layout in some render passes did not match the
actual image layout when starting the render pass.
- image_swapchain_create_info tests were using VK_KHR_bind_memory2
functions without activating the extension on the device or making
sure it was core in the used Vulkan API version.
- Many devices were being created with the wrong instance, using the
context instance instead of the custom instance created for the tests.
- Several tests using VK_SHARING_MODE_CONCURRENT did not check for the
availability of two queues or were always using one, which is invalid.
- VkDeviceGroupSwapchainCreateInfoKHR had a wrong sType.
- Swapchain resize tests were calling vkBeginCommandBuffer() on active
command buffers without waiting for them to complete execution.
- Typos and other minor issues.
Affected tests:
dEQP-VK.wsi.*.swapchain.*
Components: Vulkan
VK-GL-CTS issue: 2941
Change-Id: I54d5f46cbcb76617260439a59bf3aef4028309bb
Paul Thomson [Tue, 18 May 2021 10:54:54 +0000 (11:54 +0100)]
Fix surfaceless platform for Android
Fix Vulkan library path on Android and fix config selection when
glu::RenderConfig::DONT_CARE is used.
Affected tests:
dEQP-VK.*
Components: Framework
Change-Id: I8809dd691e144223991a693aa9b90c03cd829a63
Slawomir Cygan [Wed, 19 May 2021 16:04:58 +0000 (18:04 +0200)]
Allow false positive hits from build-in AABBs intersector
This extends the fix from
7ff1f9cd to 'mixed' tests, which
also use AABBs.
This change allows the test to execute any hit shader,
in case of AABB geometry is used and the ray falsely 'intersects'
it.
This is needed, as the test does not calculate the proper
intersection in 'intersection' stage - it uses a shader that always
reports TRUE. Hence the test relies on build-in AABB
intersector, which may report false positives according to the
specification.
VK-GL-CTS Issue: 2848
Components: Vulkan
Affects: dEQP-VK.ray_tracing_pipeline.build.*mix*
Change-Id: Ia962992df866b68f84714dcb6429a1a90499d9b6
Alexander Galazin [Wed, 26 May 2021 09:15:08 +0000 (11:15 +0200)]
Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5
Change-Id: I5a38303ad269d39786584512a105e0e4b636eca1
Alexander Galazin [Wed, 26 May 2021 08:45:36 +0000 (10:45 +0200)]
Merge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/vulkan-cts-1.2.4
Change-Id: I2182f671aa88657e150c9d987713b93920377b23
Alexander Galazin [Wed, 26 May 2021 07:43:38 +0000 (09:43 +0200)]
Merge vk-gl-cts/vulkan-cts-1.2.2 into vk-gl-cts/vulkan-cts-1.2.3
Change-Id: I6a05c3d94da3f1f6397b029997d6d43db2439548
Alexander Galazin [Wed, 26 May 2021 07:01:29 +0000 (09:01 +0200)]
Merge vk-gl-cts/vulkan-cts-1.2.1 into vk-gl-cts/vulkan-cts-1.2.2
Change-Id: Ib9e1ec8639e95a5bda7c361e1db102b5f4f94194
Matthew Netsch [Fri, 26 Feb 2021 19:51:41 +0000 (11:51 -0800)]
Fixes ycbcr copy tests using NaNs
Removes NaNs from the source images
Components: Vulkan
VK-GL-CTS issue: 2772
Affects:
dEQP-VK.ycbcr.copy.*
Change-Id: I52d279633e081ecce0ef93681c4d199296de6107
Alexander Galazin [Fri, 21 May 2021 12:12:54 +0000 (14:12 +0200)]
Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5
Change-Id: I768331416f61a0a76c6bff504e0fedd545080f22
Alexander Galazin [Fri, 21 May 2021 11:34:48 +0000 (13:34 +0200)]
Merge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/vulkan-cts-1.2.4
Change-Id: I9ac48fcdfe6e253139ccde50371b9dbfa31ce437
Alexander Galazin [Fri, 21 May 2021 10:05:50 +0000 (12:05 +0200)]
Merge vk-gl-cts/vulkan-cts-1.2.2 into vk-gl-cts/vulkan-cts-1.2.3
Change-Id: I9a085c6867ee119951a839b0d5eecb7fcf351029
Alexander Galazin [Fri, 21 May 2021 09:18:08 +0000 (11:18 +0200)]
Merge vk-gl-cts/vulkan-cts-1.2.1 into vk-gl-cts/vulkan-cts-1.2.2
Change-Id: I575ea750c7a89ec9f8306537a4bc3f7fbb64a619
Slawomir Cygan [Thu, 13 May 2021 12:00:14 +0000 (12:00 +0000)]
Revert "Remove too long ray_tracing.build tests"
This reverts commit
6e14c25f5d049cb0dadebdd8a48392721b8a4d0b.
This reinstates long ray_tracing.build tests
VK-GL-CTS Issue: 2896
Components: Vulkan
Change-Id: I1b0ecaa3eeb63f5ca82d7bffe790979e21d08b7c
Affects: dEQP-VK.ray_tracing_pipeline.build.*
Ricardo Garcia [Fri, 30 Apr 2021 08:27:31 +0000 (10:27 +0200)]
Fix inconsistent ray payloads in RT barrier tests
Ray payload declarations (outgoing and incoming) were not consistent
across all ray shader stages in the ray tracing pipeline barrier tests.
In addition, this commit fixes payload and callable data names to make
it clear they are not used.
Affected tests:
dEQP-VK.ray_tracing_pipeline.barrier.*
VK-GL-CTS issue: 2900
Components: Vulkan
Change-Id: If764cf3cde9effb5868a7c03a0b2200cf9d90cb8
Matthew Netsch [Thu, 6 May 2021 19:30:22 +0000 (15:30 -0400)]
Fixes image sparse tests
Tests use sparseImageLoadARB in shader
but not checking for sparse_residency
Components: Vulkan
VK-GL-CTS Issue: 2913
Affects:
dEQP-VK.image.mismatched_formats.sparse_image_read*
Change-Id: I6896c7cec530a69be8ea172205d9155ff71873f9
Matthew Netsch [Fri, 7 May 2021 15:40:31 +0000 (11:40 -0400)]
Fixes sparse image padding tests
Tests were attempting to verify the
values inside the padding X bits of
formats like 10x6, where spec says
they are undefined.
Components: Vulkan
VK-GL-CTS Issue: 2916
Affects:
dEQP-VK.sparse_resources.image_sparse_binding.2d*
Change-Id: Ic785fba111ecebb5a030673642b78872c404d925
Ricardo Garcia [Tue, 4 May 2021 08:09:55 +0000 (10:09 +0200)]
Fixes for robust buffer with variable pointer tests
This commit fixes several issues with robust buffer access with variable
pointers tests:
* The variable pointer tests were checking support for the
variablePointersStorageBuffer feature but they weren't actually
activating the feature when creating the robust buffer access device.
* Support checks were being done at instance creation time instead of
using the proper checkSupport method.
* In-bound checks for 64-bit format accesses were only checking 4 out of
every 8 bytes in the buffer.
* The verification routines were not taking into account 64-bit
nonatomic accesses could be legally split into two 32-bit accesses
that could be checked independently.
* The possibility of satisfying a (0,0,0,x) pattern in output data was
not being checked correctly for 64-bit formats, always using 32-bit
vectors and values.
Affected tests:
dEQP-VK.robustness.buffer_access.*
dEQP-VK.robustness.vertex_access.*
Components: Vulkan
VK-GL-CTS issue: 2908
Change-Id: I85aeb085cb31d63b70acec08551c53fcc7d2be3c
Matthew Netsch [Fri, 23 Apr 2021 15:40:52 +0000 (11:40 -0400)]
Fixes fragment density map tests
Multiview extension struct being passed to
render pass 2 is not valid. Need to use
viewMask in the render pass 2 structs instead.
Components: Vulkan
VK-GL-CTS Issue: 2899
Affects:
dEQP-VK.renderpass2.fragment_density_map.*
Change-Id: Ieedaacae4fe7ba6d3c222610d96f1785fa01719a
Sławomir Cygan [Mon, 19 Apr 2021 14:22:35 +0000 (16:22 +0200)]
Remove too long ray_tracing.build tests
The tests have too large runtime (up to 1h20m per
single test case) due to large AS being built on the
host.
VK-GL-CTS Issue: 2896
Components: Vulkan
Affects: dEQP-VK.ray_tracing_pipeline.build.*
Change-Id: Ib298b18967ed76d79bd150ac53d90d36332adc60
Sławomir Cygan [Fri, 16 Apr 2021 08:51:36 +0000 (10:51 +0200)]
Add missing memory barrier between device transfer write and host read
The tests are missing a barrier between buffer being written by transfer operation
on device and reading the buffer contents on host.
Some tests were not missing this barrier, but the access flags were not reflecting
the dependency.
Components: Vulkan
VK-GL-CTS Issue: 2894
Affects:
dEQP-VK.ray_query.*
dEQP-VK.ray_tracing.*
Change-Id: I3e90e53f7db2a885805bd95d5f6033468ff8a927
Slawomir Cygan [Thu, 15 Apr 2021 15:20:21 +0000 (17:20 +0200)]
Move the hit counting from any hit to closest hit shader stage
Fix the counting of ray hits by moving it from any hit to closest hit shader,
as any hit shader may execute multiple times per geometry - what may happen
because triangle primitives are arranged into grid of cubes.
VK-GL-CTS Issue: 2890
Affects: dEQP-VK.ray_tracing_pipeline.misc.*stress*
Change-Id: Id7e10181d15f99685c2997003dd579ab735dc4ee
Components: Vulkan
Slawomir Cygan [Fri, 9 Apr 2021 13:48:51 +0000 (15:48 +0200)]
Use actual pipeline recursion depth when computing stack size
Use the maximum recursion depth as set in the used pipeline,
rather than the maximum recursion depth supported by a physical
device to avoid overflowing uint32 when computing the dynamic
stack size and/or creating exceptionally large stack, not needed by
the pipeline used in this test.
Components: Vulkan
Affects: dEQP-VK.ray_tracing_pipeline.misc.callableshaderstress*
VK-GL-CTS Issue: 2880
Change-Id: Ia4feee82099d34300c70af8eab13245d29d037d9
Alexander Galazin [Wed, 21 Apr 2021 15:54:28 +0000 (18:54 +0300)]
Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5
Change-Id: Ic854c92253dc5745bd4718fab12b567832228861
Paul Thomson [Tue, 20 Apr 2021 10:00:04 +0000 (11:00 +0100)]
Android: test list change dEQP-VK.glsl.builtin.*
Move the following tests from the Android 2019 test list to the 2020
test list.
dEQP-VK.glsl.builtin.precision.asin.highp.scalar
dEQP-VK.glsl.builtin.precision.asin.highp.vec2
dEQP-VK.glsl.builtin.precision.asin.highp.vec3
dEQP-VK.glsl.builtin.precision.asin.highp.vec4
Components: AOSP
Change-Id: I6586b0cfb39be6d43278cf61378563b3f894d641
Alexander Galazin [Wed, 21 Apr 2021 09:08:43 +0000 (12:08 +0300)]
Merge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/vulkan-cts-1.2.4
Change-Id: I83fff4847e0bc12be0d574bd064a511784a72e09
Alexander Galazin [Wed, 21 Apr 2021 08:18:37 +0000 (11:18 +0300)]
Merge vk-gl-cts/vulkan-cts-1.2.2 into vk-gl-cts/vulkan-cts-1.2.3
Change-Id: Ib3ccf6adeedb2a55ba8a96bfabb75273a1c664ea
Alexander Galazin [Wed, 21 Apr 2021 06:56:03 +0000 (09:56 +0300)]
Merge vk-gl-cts/vulkan-cts-1.2.1 into vk-gl-cts/vulkan-cts-1.2.2
Change-Id: I90603cf34d44bb7c6f10e81f7b594834391da05e
Paul Thomson [Tue, 20 Apr 2021 10:00:04 +0000 (11:00 +0100)]
Android: test list change dEQP-VK.glsl.builtin.*
Move the following tests from the Android 2019 test list to the 2020
test list.
dEQP-VK.glsl.builtin.precision.asin.highp.scalar
dEQP-VK.glsl.builtin.precision.asin.highp.vec2
dEQP-VK.glsl.builtin.precision.asin.highp.vec3
dEQP-VK.glsl.builtin.precision.asin.highp.vec4
Components: AOSP
Change-Id: I6586b0cfb39be6d43278cf61378563b3f894d641
Alexander Galazin [Wed, 7 Apr 2021 14:49:03 +0000 (17:49 +0300)]
Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5
Change-Id: Id90fcd730ba632a3a08f25a01226098421486753
Alexander Galazin [Wed, 7 Apr 2021 13:11:48 +0000 (16:11 +0300)]
Merge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/vulkan-cts-1.2.4
Change-Id: Iffa708c815ea869d459d6b5a951f69a3fae7d351
Alexander Galazin [Wed, 7 Apr 2021 09:51:46 +0000 (12:51 +0300)]
Merge vk-gl-cts/vulkan-cts-1.2.2 into vk-gl-cts/vulkan-cts-1.2.3
Change-Id: I452f719e084e6decc02066064c6f0397e4b915e6
Alexander Galazin [Tue, 6 Apr 2021 14:13:37 +0000 (17:13 +0300)]
Merge vk-gl-cts/vulkan-cts-1.2.1 into vk-gl-cts/vulkan-cts-1.2.2
Change-Id: I2947e16b40c26feb3c95922e18e36e36acbc43b9
Alexander Galazin [Tue, 6 Apr 2021 11:46:52 +0000 (14:46 +0300)]
Merge vk-gl-cts/vulkan-cts-1.1.6 into vk-gl-cts/vulkan-cts-1.2.1
Change-Id: Id775a0b8cb86bd5929b61c49fbfac4825421c7a7
Marcin Kantoch [Tue, 30 Mar 2021 14:47:11 +0000 (16:47 +0200)]
Fix test does not return failure status
Affected tests:
dEQP-VK.wsi.display_control.register_device_event
Components: Vulkan
VK-GL-CTS issue: 2864
Change-Id: I282ffc5e7b910209a509ae57ee8e38c662b97815
Matthew Netsch [Wed, 31 Mar 2021 15:08:41 +0000 (11:08 -0400)]
Fixes Fragment Shading Rate layered tests
Test was exporting Layer and ViewportIndex
decorations in Vertex Shader in the
Geometry Shader tests without checking
for support.
Components: Vulkan
VK-GL-CTS Issue: 2865
Affects:
dEQP-VK.fragment_shading_Rate.srlayered.*.gs
dEQP-VK.fragment_shading_Rate.colorlayered.*.gs
Change-Id: Idbf6be2c14bb8409feec2d7262efb9a402cf35a2
Neslisah Torosdagli [Sat, 27 Mar 2021 03:27:06 +0000 (23:27 -0400)]
Fix insufficient BLAS indirect buffer size
BLAS indirect buffer size is not set correctly. It is set to
sizeof(VkAccelerationStructureBuildRangeInfoKHR) however
geometries number times sizeof(VkAccelerationStructureBuildRangeInfoKHR)
indirect buffer space is needed.
Components: Vulkan
https://gitlab.khronos.org/Tracker/vk-gl-cts/-/issues/2862
Affects: dEQP-VK.ray_tracing_pipeline.indirect.build_structure
Change-Id: I2b5df039aac6c3f2a51177c8bf9f5095ae5c7886
Alexander Galazin [Fri, 19 Mar 2021 11:12:55 +0000 (14:12 +0300)]
Remove in-repo verify_submission scripts
These scripts are now replaced by the CTS Tools repo:
https://github.com/KhronosGroup/VK-GL-CTS-Tools
Components: Vulkan, OpenGL
Change-Id: If0f47b4186ed10f9946852e8d37956d7328625a8
Sławomir Cygan [Tue, 16 Mar 2021 16:07:16 +0000 (17:07 +0100)]
Allow false positive hits from build-in AABBs intersector
This change allows the test to execute any hit shader,
in case of AABB geometry is used and the ray falsely 'intersects'
it.
This is needed, as the test does not calculate the proper
intersection in 'intersection' stage - it uses a shader that always
reports TRUE. Hence the test relies on build-in AABB
intersector, which may report false positives according to the
specification.
VK-GL-CTS Issue: 2848
Components: Vulkan
Affects: dEQP-VK.ray_tracing_pipeline.build.*aabbs*
Change-Id: Ib90f45227a7cd4c412fd4d1c97598f32a80eb6ca
Sławomir Cygan [Tue, 16 Mar 2021 15:40:21 +0000 (16:40 +0100)]
Remove the tests with too large device AS build workload
This removes the tests that submit accelleration structure
builds with 1048576 instances * geometries * 'squares'.
The accelleation structure builds performed by these tests
were too long and may hit the device timeout imposed by
the operating system.
Components: Vulkan
VK-GL-CTS Issue: 2849
Removed Tests:
dEQP-VK.ray_tracing_pipeline.build.gpu*_1_1_1048576
dEQP-VK.ray_tracing_pipeline.build.gpu*_1_1048576_1
dEQP-VK.ray_tracing_pipeline.build.gpu*_1_1048576_1
dEQP-VK.ray_tracing_pipeline.build.gpu*_4_4_65536
dEQP-VK.ray_tracing_pipeline.build.gpu*_4_65536_4
dEQP-VK.ray_tracing_pipeline.build.gpu*_65536_4_4
Change-Id: Ief53cc01da4f749fd8a030bd8e2ebb5652208ce4
Alexander Galazin [Wed, 17 Mar 2021 15:26:27 +0000 (18:26 +0300)]
Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5
Change-Id: If51e7d93c6b84f7d3fde339f35ae351d8443a7ce
Alexander Galazin [Wed, 17 Mar 2021 14:28:28 +0000 (17:28 +0300)]
Merge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/vulkan-cts-1.2.4
Change-Id: Id84d297899a981b1fae39d923280446925730cd0
Alexander Galazin [Wed, 17 Mar 2021 13:01:48 +0000 (16:01 +0300)]
Merge vk-gl-cts/vulkan-cts-1.2.2 into vk-gl-cts/vulkan-cts-1.2.3
Change-Id: I6bad956acaf784565692e1ea539a219064deed57
Alexander Galazin [Wed, 17 Mar 2021 12:14:31 +0000 (15:14 +0300)]
Merge vk-gl-cts/vulkan-cts-1.2.1 into vk-gl-cts/vulkan-cts-1.2.2
Change-Id: I64b979022925b98680602154ad32b13080a04871
Alexander Galazin [Wed, 17 Mar 2021 11:33:21 +0000 (14:33 +0300)]
Merge vk-gl-cts/vulkan-cts-1.1.6 into vk-gl-cts/vulkan-cts-1.2.1
Change-Id: If6077d356659193696b2e41c318b5bda2f5ca1d1
Alexander Galazin [Mon, 22 Feb 2021 09:14:11 +0000 (10:14 +0100)]
Update Vulkan/GL Readme
Update the Readme files to point to the new
submission verifcation script
Components: Vulkan, OpenGL
Change-Id: I6fb35a383fcc49e543ae67822be22d744c5fcd9c
(cherry picked from commit
412f5a3363eb228ca1a63be337de172a2e622571)
Alexander Galazin [Mon, 15 Mar 2021 15:50:59 +0000 (18:50 +0300)]
Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5
Change-Id: I07fc25f375c0228279e54582fc909876a370d251
Alexander Galazin [Mon, 15 Mar 2021 14:58:34 +0000 (17:58 +0300)]
Merge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/vulkan-cts-1.2.4
Change-Id: I78e06ea1256567bd761e1ffa5678338eb1f7aa85
Alexander Galazin [Mon, 15 Mar 2021 14:09:42 +0000 (17:09 +0300)]
Merge vk-gl-cts/vulkan-cts-1.2.2 into vk-gl-cts/vulkan-cts-1.2.3
Change-Id: I15d9b2b0dbaab175d891a824c190198bbcda1b20
Alexander Galazin [Mon, 15 Mar 2021 12:55:47 +0000 (15:55 +0300)]
Merge vk-gl-cts/vulkan-cts-1.2.1 into vk-gl-cts/vulkan-cts-1.2.2
Change-Id: Iccb63bb8842b2d3b8ae22b78853a0534500aebdf
Ari Suonpaa [Mon, 22 Feb 2021 12:30:21 +0000 (14:30 +0200)]
Update Amber
Amber was updated to include a fix for Vulkan pointer
loading that broke CTS when using Vulkan 1.0 device.
VK-GL-CTS Issue: 2802
Affects: All Amber tests
Components: Vulkan, Framework
Change-Id: I2ceaa8b569112f2e32e8a3a4e74d82ef1e4d0a67
(cherry picked from commit
e3a5a50e44c4d078d8fd2b97c6a9b4fecc97d1ce)
Paul Thomson [Wed, 3 Mar 2021 12:29:11 +0000 (12:29 +0000)]
Fix bad merge in DeqpTestRunner.java
Components: Android
Change-Id: Ib557d85deb85dc528fde2765e8c6442bffe67fc4
Sławomir Cygan [Fri, 26 Feb 2021 12:34:23 +0000 (13:34 +0100)]
Fix reordering vertices in geometry shader in ray_query AS test
This fixes the shader to write reordered vertice data into sequential
(unordered) store image indices
The change from
48f12336 was incomplete and misses the change to
the image store indices.
Components: Vulkan
VK-GL-CTS Issue: 2764
Affects: dEQP-VK.ray_query.acceleration_structures.*.geometry_shader.*
Change-Id: Ifd51d77e94c607e860e5c9efdefe2cb5a5ee97ff
Marcin Kańtoch [Thu, 25 Feb 2021 16:23:31 +0000 (17:23 +0100)]
Fix source blit image size
Changed the way source blit image size is calculated,
so that in all circumstances width > 0 and height > 0.
Affects:
dEQP-VK.memory.pipeline_barrier.host_read_transfer_dst.1024
Components: Vulkan
VK-GL-CTS issue: 2816
Change-Id: Id23a8e613b013e9e40b0075822b80c78b9ca418c
Matthew Netsch [Wed, 3 Mar 2021 22:21:05 +0000 (17:21 -0500)]
Adds local multi device present mode support check
Test calls vkGetPhysicalDevicePresentRectanglesKHR even if
driver does not support
VK_DEVICE_GROUP_PRESENT_MODE_LOCAL_MULTI_DEVICE_BIT_KHR
Components: Vulkan
VK-GL-CTS Issue: 2828
Affects:
dEQP-VK.wsi.wayland.surface.query_devgroup_present_modes
Change-Id: I91ac8d2820318d1553e28fe71a4d2488a0fead5d
Alastair Donaldson [Thu, 11 Feb 2021 18:12:41 +0000 (18:12 +0000)]
Update dEQP test runner
Updates the dEQP test runner to account for the
android.software.opengles.deqp.level feature flag. This generalises
the logic that previously checked whether a Vulkan test list should be
skipped depending on the value of the analogous Vulkan feature flag.
Bug:
169021525
Change-Id: I00e04b6cda698c0649e4dcd2923e87156539e5c0
Alastair Donaldson [Wed, 10 Feb 2021 13:00:21 +0000 (13:00 +0000)]
Add Android test lists for OpenGL ES
Adds two new test lists for each of OpenGL ES 2.0, OpenGL ES 3.0 and
OpenGL ES 3.1, corresponding to dEQP snapshots for Android
versions. The full master test lists for OpenGL ES are no longer run
by default.
Bug:
169021525
Change-Id: I86eea5263f074fa8e6b826e7ded458953ebfb17c
Alastair Donaldson [Tue, 9 Feb 2021 15:42:03 +0000 (15:42 +0000)]
Add new Vulkan test list and update test list generation
Adds a test list capturing the Vulkan dEQP tests frozen for Android
11, and changes the test list generator to use this list.
Due to various tests having been renamed or removed, list generation
does not yet work.
Bug:
169021525
Change-Id: Icab9e25d1acc24d121feacdf8720d14e8db69d91
Piotr Byszewski [Wed, 17 Feb 2021 11:07:56 +0000 (12:07 +0100)]
Fix custom device creation for synchronization2
Some synchronization tests created custom device without
enabling all used features. This change fixes that.
Components: Vulkan
VK-GL-CTS issue: 2734
Affects:
dEQP-VK.synchronization*.basic.*.multi_queu*
dEQP-VK.synchronization*.op.multi_queue.*
dEQP-VK.synchronization*.cross_instance.*
Change-Id: Ib2c062967608c5348e5b0a5edabd310574900632
Tom Cooper [Fri, 19 Feb 2021 11:45:10 +0000 (11:45 +0000)]
Fix dEQP-VK.synchronization* to not duplicate primary command buffers in a VkSubmitInfo
Several tests in dEQP-VK.synchronization* call a helper which adds a
primary command buffer to the submit info, then use a queue submit
helper which adds the same command buffer again.
Components: Vulkan
VK-GL-CTS Issue: 2798
Affects:
dEQP-VK.synchronization*.op.multi_queue.fence.*
Change-Id: Id84f9c327ff6bc54af331c4bdb95167b2958dcd0
Neslisah Torosdagli [Mon, 22 Feb 2021 23:14:50 +0000 (18:14 -0500)]
Fix inconsistent primitive count issue
Number of primitives added to the geometries were larger than number of primitives initialized in the shader. This change fixes that.
Components: Vulkan
VK-GL-CTS issue: 2800
Affects: dEQP-VK.ray_tracing_pipeline.indirect.build_structure
Change-Id: I50634a2f58281284b093c599d7fe965e347aac02
Alexander Galazin [Fri, 19 Feb 2021 07:57:06 +0000 (08:57 +0100)]
Allow Vulkan CTS 1.2.5.2
Components: Vulkan
Affects: dEQP-VK.api.driver_properties.properties
Change-Id: If42924ce4919dfc372e5e107dc8e9e86d27bbe2b
Sławomir Cygan [Mon, 15 Feb 2021 14:35:21 +0000 (15:35 +0100)]
Do not use image index and semaphore when vkAcquireNextImageKHR fails
This change follows
d9763f6a0, where vkAcquireNextImageKHR was allowed
to fail with VK_ERROR_FULL_SCREEN_EXCLUSIVE_MODE_LOST_EXT error.
However, the (not) acquired image index and semaphore was still used,
causing fauilure when validating the index.
This change skips using the image index and semaphore, when image was
not acquired.
Moreover, failure to acquire the image is logged as quality warning.
VK-GL-CTS Issue: 2792
Affects: dEQP-VK.wsi.*.full_screen_exclusive.*
Components: Vulkan
Change-Id: I7c970289769fd56c9f46ac27cc6d23180e847d74