platform/upstream/VK-GL-CTS.git
6 years agoReturn UNSUPPORTED if no compressed textures available
Juan A. Suarez Romero [Thu, 11 Jan 2018 12:52:42 +0000 (13:52 +0100)]
Return UNSUPPORTED if no compressed textures available

When testing compressed textures, return NOT_SUPPORTED if none of the
compressed textures under testing are available, instead of returning
FAIL.

Components: OpenGL

VK-GL-CTS issue: 943

Affects:
KHR-GLES2.texture_3d.compressed_texture.negative_compressed_*

Change-Id: I77d18fdbb86fef88c680f63f7fe522ed079887aa

6 years agogl_spirv: Correct ARB_gl_spirv check function type
Andres Gomez [Thu, 1 Feb 2018 10:03:21 +0000 (12:03 +0200)]
gl_spirv: Correct ARB_gl_spirv check function type

The check for GL_ARB_gl_spirv or GL 4.6 doesn't return anything but
just throws an exception. This corrects the type of the call.

Affects:

KHR-GL45.gl_spirv.*

Components: OpenGL

VK-GL-CTS issue: 981

Change-Id: Ic051d7949672b7a824ebe5c67761be866cd1877f

6 years agoFix ES2 cube map GL_LINEAR_* filtering tests
Piotr Byszewski [Thu, 18 Jan 2018 12:59:57 +0000 (13:59 +0100)]
Fix ES2 cube map GL_LINEAR_* filtering tests

When ES2 context is created on ES3 compatible hardware
seamless sampler should be used during cube map filtering
test result verification.

Components: OpenGL

VK-GL-CTS issue: 284

Affects:
dEQP-GLES2.functional.texture.mipmap.cube.*

Change-Id: I442429ca2e1c368bd2dba0948923034b8a3e54be

6 years agoFixed ES2 fbo completeness tests
Piotr Byszewski [Wed, 17 Jan 2018 14:45:28 +0000 (15:45 +0100)]
Fixed ES2 fbo completeness tests

Twelve ES2 fbo completeness tests failed when they
were executed on hardware that also supports ES3.
This was fixed by detecting this case and verifying
tests results using ES3 rules.

Components: OpenGL

VK-GL-CTS issue: 288

Affects:
dEQP-GLES2.functional.fbo.completeness.renderable.*

Change-Id: I0377021a5a83cfb08c5222895e357182c2cafe67

6 years agoMerge vk-gl-cts/aosp-deqp-dev into vk-gl-cts/master
Alexander Galazin [Wed, 31 Jan 2018 10:09:13 +0000 (11:09 +0100)]
Merge vk-gl-cts/aosp-deqp-dev into vk-gl-cts/master

Change-Id: I105841cb1422bf42de35208d39195b9e2ddc1469

6 years agoTest texture gather with separate sparse binding queue
Paavo Pessi [Fri, 3 Nov 2017 11:49:27 +0000 (13:49 +0200)]
Test texture gather with separate sparse binding queue

Existing texture gather tests assume the binding queue is part of
graphics queue. Tests were modified to support both combined and
separate sparse binding queues.

Affects:

dEQP-VK.glsl.texture_gather.*.sparse_*

Components: Vulkan

VK-GL-CTS issue: 361

Change-Id: I0c2160649e6d0fd3e45401a43ab6b3960312c5e0

6 years agoAdd tests for sparse compressed textures.
Ari Suonpaa [Mon, 16 Oct 2017 06:29:08 +0000 (09:29 +0300)]
Add tests for sparse compressed textures.

Extended compressed texture test to include sparse images used as
textures.

Affects:

dEQP-VK.texture.compressed.*

Components: Vulkan

VK-GL-CTS issue: 101

Change-Id: If317985fa8ff1c9a83040a77209c90172834968d

6 years agoRe-enable reflect and dot tests
Piotr Byszewski [Tue, 16 Jan 2018 12:42:07 +0000 (13:42 +0100)]
Re-enable reflect and dot tests

Restored dot and reflect precision tests.

Components: OpenGL

VK-GL-CTS issue: 292

Affects:
dEQP-GLES31.functional.shaders.builtin_functions.precision.reflect.*
dEQP-GLES31.functional.shaders.builtin_functions.precision.dot.*

Change-Id: If3acfadc2e41c8c39e2b5d2f065582bdbfdc2e7a

6 years agoMerge "Work around VC++ code-gen bug in shader matrix tests." into deqp-dev
Treehugger Robot [Fri, 26 Jan 2018 23:30:16 +0000 (23:30 +0000)]
Merge "Work around VC++ code-gen bug in shader matrix tests." into deqp-dev

6 years agoMerge "Fix missing case for ANGLE_depth_texture" into deqp-dev
Treehugger Robot [Fri, 26 Jan 2018 23:29:52 +0000 (23:29 +0000)]
Merge "Fix missing case for ANGLE_depth_texture" into deqp-dev

6 years agoFix missing case for ANGLE_depth_texture
Jamie Madill [Fri, 26 Jan 2018 22:57:17 +0000 (17:57 -0500)]
Fix missing case for ANGLE_depth_texture

Happens when ANGLE_depth_texure is exposed and not OES_depth_texture.

Component: AOSP
Affects:
  dEQP-GLES2.functional.fbo.completeness.renderable.texture.stencil.depth_stencil_unsigned_int_24_8
  dEQP-GLES2.functional.fbo.completeness.renderable.texture.depth.depth_stencil_unsigned_int_24_8
  dEQP-GLES3.functional.fbo.completeness.renderable.texture.stencil.depth_stencil_unsigned_int_24_8
  dEQP-GLES3.functional.fbo.completeness.renderable.texture.depth.depth_stencil_unsigned_int_24_8

6 years agoWork around VC++ code-gen bug in shader matrix tests.
Jamie Madill [Fri, 26 Jan 2018 17:55:20 +0000 (12:55 -0500)]
Work around VC++ code-gen bug in shader matrix tests.

This code-gen bug was found in crbug.com/759402, and was causing test
runtime failures when run. Work around it by disabling optimization
for the specific compiler version.

Components: AOSP
Affects:
  dEQP-GLES2.functional.shaders.matrix.*
  dEQP-GLES3.functional.shaders.matrix.*

6 years agoMerge remote-tracking branch 'aosp/master' into deqp-dev
Chris Forbes [Fri, 26 Jan 2018 00:47:12 +0000 (16:47 -0800)]
Merge remote-tracking branch 'aosp/master' into deqp-dev

Change-Id: Ie7623be11190d678413fbe64da5d41d98e370b2c

6 years agoMerge "Tolerate flush/finish test assumption failures."
Treehugger Robot [Thu, 25 Jan 2018 23:26:38 +0000 (23:26 +0000)]
Merge "Tolerate flush/finish test assumption failures."

6 years agoTolerate flush/finish test assumption failures.
Nicolas Capens [Thu, 25 Jan 2018 16:58:26 +0000 (16:58 +0000)]
Tolerate flush/finish test assumption failures.

These tests assume that draw calls are queued up until they're forced
to be executed by a ReadPixels, Flush, or Finish call. The spec does
not require this, and implementations are free to eagerly start
execution of draw calls.

Thus this change reports a CompatibilityWarning if the assumption isn't
met, instead of a Failure.

Google bug: b/71858368
Components: AOSP
Tests: dEQP-GLES2.functional.flush_finish,
dEQP-GLES3.functional.flush_finish

6 years agoMerge "Test glRenderbufferStorage with unsized depth format"
Treehugger Robot [Wed, 24 Jan 2018 13:29:22 +0000 (13:29 +0000)]
Merge "Test glRenderbufferStorage with unsized depth format"

6 years agoTest that points are clamped to ALIASED_POINT_SIZE_RANGE
Kai Ninomiya [Tue, 23 Jan 2018 23:28:27 +0000 (15:28 -0800)]
Test that points are clamped to ALIASED_POINT_SIZE_RANGE

This test verifies that the point size written to gl_PointSize is
clipped to the range ALIASED_POINT_SIZE_RANGE before rasterization.

See also: http://crbug.com/740560
In particular this comment: http://crbug.com/740560#c27

New tests: dEQP-GLES2.functional.rasterization.limits.points
Components: AOSP
Change-Id: I98708ebece4be9c2bce3c7ba3b57454aec657cce

6 years agoTest glRenderbufferStorage with unsized depth format
Nicolas Capens [Tue, 23 Jan 2018 23:16:39 +0000 (23:16 +0000)]
Test glRenderbufferStorage with unsized depth format

The OpenGL ES 2.0 specification only supports formats from Table 4.5,
which are all sized internal formats, while ES 3.0 explicitly states
that "<internalformat> must be a sized internal format".

A color format (GL_RGBA) was already being negatively tested for, but
not a depth format.

6 years agoMerge vk-gl-cts/aosp-deqp-dev into vk-gl-cts/master
Alexander Galazin [Tue, 23 Jan 2018 08:01:54 +0000 (09:01 +0100)]
Merge vk-gl-cts/aosp-deqp-dev into vk-gl-cts/master

Change-Id: I39c67077ab1c9842ab43708f83335eba0d707890

6 years agoFix using representable texture channel ranges.
Nicolas Capens [Mon, 8 Jan 2018 21:49:05 +0000 (16:49 -0500)]
Fix using representable texture channel ranges.

A value of 4294967295 (2^32 - 1) is not exactly representable in
IEEE-754 single-precision floating-point format, and so it gets rounded
to the next representable value, which is 4294967296. However, this
value can't be cast to an unsigned 32-bit integer without overflowing.

GLSL does not define what happens on overflow, and IEEE-754 defines it
as an exception but GLSL forbids exceptions. Hence some implementations
may produce unexpected results. dEQP assumed clamping to the largest
representable integer.

This change fixes that false assumption by reducing the range to values
representable in both float and integer formats.

Note that 32-bit integer formats can still hold values slightly larger
than these ranges. So while previously the floating-point ranges were
too large to represent integer values, they are now too small. This
can't be fixed without separating the integer format tests and only
using integer values to represent their ranges. This doesn't appear
necessary for the time being since the tests that use these floating-
point ranges have large 12/256 tolerances for the output color.

VK-GL-CTS issue: 937
Google bug: 70910885
Component: Framework

Change-Id: Ia2e8a187772bf37ed6ad35b13ed6f5071c46fb43

6 years agoAdd SpirvValidationCapabilitiesTest test case implementation
Adam Czupryna [Fri, 24 Nov 2017 13:59:39 +0000 (14:59 +0100)]
Add SpirvValidationCapabilitiesTest test case implementation

Add CTS_ARB_gl_spirv test implementation that contains:
SpirvValidationCapabilitiesTest

Affects:

KHR-GL45.gl_spirv.spirv_validation_capabilities_test

Components: OpenGL

VK-GL-CTS issue: 554

Change-Id: I0ba93f0ea0dd5c8c9c1348033448fe5ada82b99b

6 years agoFreeze GL 4.6.0 mustpass, add 4.6.1 mustpass
Alexander Galazin [Tue, 23 Jan 2018 01:56:18 +0000 (02:56 +0100)]
Freeze GL 4.6.0 mustpass, add 4.6.1 mustpass

Change-Id: Iae3345620e1dc59437c4b2910fcd08f66cb9eab4

6 years agoTest packed depth and stencil
Piotr Byszewski [Wed, 13 Dec 2017 09:48:54 +0000 (10:48 +0100)]
Test packed depth and stencil

GTFTestPackedDepthStencil tests were ported to glcts.
Packed format loop was extracted from tests.

Components: OpenGL

VK-GL-CTS issue: 815

Affects:
KHR-GLES3.packed_depth_stencil.*
KHR-GL*.packed_depth_stencil.*

Change-Id: Ia13d200909cfe097bfbafcb15d5482d30b4d8c5b

6 years agoTest discontiguous descriptor binding values
Paavo Pessi [Fri, 5 Jan 2018 13:57:10 +0000 (15:57 +0200)]
Test discontiguous descriptor binding values

New tests were added to test discontiguous and arbitrary descriptor
binding values with different descriptor types and shader stages.

New tests:
dEQP-VK.binding_model.shader_access.*.multiple_discontiguous_descriptors.*
dEQP-VK.binding_model.shader_access.*.multiple_arbitrary_descriptors.*

Components: Vulkan

VK-GL-CTS issue: 905
VK-GL-CTS public issue: 67

Change-Id: I00d1ec1e302a03e0f67ba967b6949578ec58c436

6 years agoAdd more component qualifier array tests for fragment outputs
Samuel Iglesias Gonsálvez [Fri, 1 Dec 2017 08:36:57 +0000 (09:36 +0100)]
Add more component qualifier array tests for fragment outputs

Tests were added to verify that various combinations of component
qualifiers can be used with different data arrays (float, vec2, vec3)
in fragment shader outputs.

New tests:

dEQP-VK.glsl.440.linkage.varying.component.frag_out.two_vec4.*

Components: Vulkan
VK-GL-CTS issue: 896

Change-Id: If3ed04b88f4a496dcdada9c50a45bbf7580df88e

6 years agogl_spirv: update ARB_gl_spirv availability check
Alejandro Piñeiro [Tue, 16 Jan 2018 14:43:49 +0000 (15:43 +0100)]
gl_spirv: update ARB_gl_spirv availability check

All tests were checking for the availability of the extension in
order to return NotSupported but one, so it returned Failed.

Additionally we complete the check, so now we are checking for
GL_ARB_gl_spirv or GL 4.6, as other tests already do.

As this is common for all the 8 tests, we add a utility helper at
gl4cts::commonUtils.

Modules: OpenGL

VK-GL-CTS issue: 947

Affects:
KHR-GL45.gl_spirv.spirv_modules_shader_binary_multiple_shader_objects_test
KHR-GL46.gl_spirv.spirv_modules_shader_binary_multiple_shader_objects_test

Change-Id: I8a3be211363d287696ee86f7d6f503794b63710f

6 years agoUse default device for sparse binding tests.
Ari Suonpaa [Wed, 13 Dec 2017 09:49:35 +0000 (11:49 +0200)]
Use default device for sparse binding tests.

The default device supports sparse binding when the underlying
physical device has support. There's no need to create a separate
device object. Test context creates a sparse queue whenever
sparse binding is supported by the physical device. This
change also adds support for having a separate sparse binding
queue.

Affects:

dEQP-VK.texture.shadow.*
dEQP-VK.renderpass.sparserendertarget.*

Components: Vulkan

VK-GL-CTS issue: 898

Change-Id: I2ca36d8e641fe3ef5694784e7bb3d8ebe6ed51bf

6 years agoMerge "Port WebGL multisampled renderbuffer resize test"
Treehugger Robot [Sat, 20 Jan 2018 03:01:01 +0000 (03:01 +0000)]
Merge "Port WebGL multisampled renderbuffer resize test"

6 years agoSuppress new warnings from gcc-6 am: 9a58d041fe
Chris Forbes [Sat, 20 Jan 2018 00:46:18 +0000 (00:46 +0000)]
Suppress new warnings from gcc-6 am: 9a58d041fe
am: fd34041ed0

Change-Id: I0b9eca4091dc271141027d68a6a46d58937e56ac

6 years agoSuppress new warnings from gcc-6
Chris Forbes [Sat, 20 Jan 2018 00:43:46 +0000 (00:43 +0000)]
Suppress new warnings from gcc-6
am: 9a58d041fe

Change-Id: I176dd24b363db336f4f42f8d8c2c5aebb2632dcb

6 years agoSuppress new warnings from gcc-6
Chris Forbes [Fri, 19 Jan 2018 18:06:53 +0000 (10:06 -0800)]
Suppress new warnings from gcc-6

check_build_sanity currently fails with the system gcc on rodete. Let's
just suppress this warning for now. Intend to back out the suppression
and fix the warnings in next release.

Bug: b/72219443
Test: build
Change-Id: Ic842a3de3d247d53c49117562b51e8eece3752f9

6 years agoMerge vk-gl-cts/vulkan-cts-1.0.3 into vk-gl-cts/master
Alexander Galazin [Fri, 19 Jan 2018 10:12:43 +0000 (11:12 +0100)]
Merge vk-gl-cts/vulkan-cts-1.0.3 into vk-gl-cts/master

Change-Id: I2de5195522bb42f25a2eb7181b366c8284ef7fec

6 years agoMerge vk-gl-cts/vulkan-cts-1.0.2 into vk-gl-cts/vulkan-cts-1.0.3
Alexander Galazin [Fri, 19 Jan 2018 08:22:31 +0000 (09:22 +0100)]
Merge vk-gl-cts/vulkan-cts-1.0.2 into vk-gl-cts/vulkan-cts-1.0.3

Change-Id: Ie1eb632fc4601acfc34db84410e04e06cc2da243

6 years agoCheck GS support before testing adjacent primitives
Yanjun Zhang [Wed, 10 Jan 2018 00:12:47 +0000 (16:12 -0800)]
Check GS support before testing adjacent primitives

Affects: dEQP-VK.draw.basic_draw.draw.*

Components: Vulkan

VK-GL-CTS issue: 926

Change-Id: I02569b1944eed52f641966f9206d44983d1ff165

6 years agoFix buffer usage flags for index and indirect buffers
Chris Forbes [Wed, 10 Jan 2018 02:13:15 +0000 (18:13 -0800)]
Fix buffer usage flags for index and indirect buffers

Previously, createAndUploadBuffer would provide
VK_BUFFER_USAGE_VERTEX_BUFFER_BIT for all buffers. This is no good for
index buffers and indirect buffers.

VK-GL-CTS: 930

Change-Id: I774beef7c7226f4fbd5670591eb66475300ee208
Components: Vulkan
Affects: dEQP-VK.draw.instanced.*

6 years agoPort WebGL multisampled renderbuffer resize test
Kai Ninomiya [Tue, 9 Jan 2018 18:59:09 +0000 (10:59 -0800)]
Port WebGL multisampled renderbuffer resize test

Port a WebGL test for a driver bug affecting resizing/reallocation
of multisampled renderbuffers on Qualcomm drivers:
* conformance2/renderbuffers/multisampled-renderbuffer-initialization.html

New tests: dEQP-GLES3.functional.fbo.msaa.renderbuffer_resize.*
Components: AOSP
Change-Id: Ib4377eaf35c1d4b5f431cd433e06301003966d54

6 years agoFreeze 1.0.3 mustpass, add 1.0.4 mustpass
Alexander Galazin [Thu, 18 Jan 2018 17:17:45 +0000 (18:17 +0100)]
Freeze 1.0.3 mustpass, add 1.0.4 mustpass

Components: Vulkan

Change-Id: I163d9767ad526b4a0f040a24fd5f5af86f6ef7c5

6 years agoMerge vk-gl-cts/vulkan-cts-1.0.2 into vk-gl-cts/master
Alexander Galazin [Thu, 18 Jan 2018 09:51:33 +0000 (10:51 +0100)]
Merge vk-gl-cts/vulkan-cts-1.0.2 into vk-gl-cts/master

Change-Id: Ibf30bd51afce5e0e6363eb94ea2cd9293cbb35d9

6 years agoProperly iterate over pNext in VkSamplerCreateInfo
Alexander Galazin [Mon, 15 Jan 2018 13:18:51 +0000 (14:18 +0100)]
Properly iterate over pNext in VkSamplerCreateInfo

Iterate over all pNext elements in VkSamplerCreateInfo.
Skip VkSamplerYcbcrConversionInfoKHR, retrieve
reduction mode from VkSamplerReductionModeCreateInfoEXT

VK-GL-CTS issue: 945

Components: Vulkan

Affects:
dEQP-VK.ycbcr.*
dEQP-VK.api.info.format_properties.*
dEQP-VK.pipeline.sampler.view_type.*.format.(any color format).min_reduce.*
dEQP-VK.pipeline.sampler.view_type.*.format.(any color format).mag_reduce.*
dEQP-VK.pipeline.sampler.view_type.*.format.(any depth format)

Change-Id: Iaba8678f2fa13b5545cec7f903f21aa01c5c13f3

6 years agoSet maxDescriptorSet* limit table based on shader stages
Yanjun Zhang [Thu, 11 Jan 2018 19:44:54 +0000 (11:44 -0800)]
Set maxDescriptorSet* limit table based on shader stages

Re-submit the patch based on WG review and feedback.

Affects: dEQP-VK.api.info.device.properties

Components: Vulkan

VK-GL-CTS issue: 923

Change-Id: Ie627b52cfae099d87f5b6183118d42bcccd313ca

6 years agoMerge remote-tracking branch 'origin/master' into deqp-dev
Chris Forbes [Thu, 18 Jan 2018 00:39:44 +0000 (16:39 -0800)]
Merge remote-tracking branch 'origin/master' into deqp-dev

Change-Id: Ia7d3290f1dbdc712d836c29f56a61f262bf79bdd

6 years agoMerge "Update owners file" into oreo-mr1-cts-dev
Mika Isojärvi [Wed, 17 Jan 2018 22:35:33 +0000 (22:35 +0000)]
Merge "Update owners file" into oreo-mr1-cts-dev
am: 2797a75d5d

Change-Id: I1245c8ed48b7d9fd4f41a57bf52a66c58d4edf7c

6 years agoModify compute shader grid setup.
Anders Frostad Pedersen [Wed, 17 Jan 2018 22:30:57 +0000 (22:30 +0000)]
Modify compute shader grid setup.
am: a7c3d75202

Change-Id: Id377bb796299a4a37df027ef522494b5e7590723

6 years agoMerge "Update owners file" into oreo-mr1-cts-dev
Treehugger Robot [Wed, 17 Jan 2018 22:30:54 +0000 (22:30 +0000)]
Merge "Update owners file" into oreo-mr1-cts-dev

6 years agoMerge "Accept EGL_BAD_PARAMETER for eglCreatePixmapSurface negative test"
Treehugger Robot [Wed, 17 Jan 2018 21:31:35 +0000 (21:31 +0000)]
Merge "Accept EGL_BAD_PARAMETER for eglCreatePixmapSurface negative test"

6 years agoUpdate owners file
Mika Isojärvi [Thu, 28 Sep 2017 17:25:24 +0000 (10:25 -0700)]
Update owners file

Bug: 72113298
Test: build/make/tools/checkowners.py -c -v OWNERS
Change-Id: I117459d91f39055aaa5f0bc6abfbda32f31cdab2
(cherry picked from commit 412471299c0fac5cb5af37fcdeadbf39a4a36744)

6 years agoModify compute shader grid setup.
Anders Frostad Pedersen [Wed, 17 Jan 2018 11:05:45 +0000 (12:05 +0100)]
Modify compute shader grid setup.

Modify how the grid is set up for compute shader draw indirect test,
in order to avoid verfication failures due to difference in
floating-point computations on the CPU vs the GPU.

The existing code assumes infinite FP precision.

This change will guarantee the next value of pos(X) to be equal to
the first value of pos(X+1), avoiding gaps/discontinuities.

Affects:
dEQP-GLES31.functional.draw_indirect.compute_interop.large.drawarrays_combined_grid_1000x1000_drawcount_1
dEQP-GLES31.functional.draw_indirect.compute_interop.large.drawarrays_combined_grid_1000x1000_drawcount_5000
dEQP-GLES31.functional.draw_indirect.compute_interop.large.drawarrays_combined_grid_1000x1000_drawcount_8
dEQP-GLES31.functional.draw_indirect.compute_interop.large.drawarrays_separate_grid_1000x1000_drawcount_1
dEQP-GLES31.functional.draw_indirect.compute_interop.large.drawarrays_separate_grid_1000x1000_drawcount_5000
dEQP-GLES31.functional.draw_indirect.compute_interop.large.drawarrays_separate_grid_1000x1000_drawcount_8

Bug: 71515808
Change-Id: I21fe8ec9ea48b15f6171265df802bc47be775f56

6 years agoMerge changes from topic "tests-dropped-from-o"
Chris Forbes [Wed, 17 Jan 2018 19:35:50 +0000 (19:35 +0000)]
Merge changes from topic "tests-dropped-from-o"

* changes:
  Reinstate excluded UBO tests
  Reinstate dEQP-VK.image.mutable.*

6 years agoAvoid out-of-range depth values
Piers Daniell [Tue, 8 Aug 2017 22:03:35 +0000 (16:03 -0600)]
Avoid out-of-range depth values

The "d32_sfloat_large_depth" variants of the
dEQP-VK.glsl.builtin_var.fragdepth.* tests rely on undefined behavior
because it uses an out-of-range depth value. The unextended Vulkan spec
requires depth values to be in the range of 0.0..1.0. The test was using
a depth value of 20.0..21.0 and expecting the implementation to clamp.

Instead of disabling this part of the test entirely, only run it if the
implementation exposes the VK_EXT_depth_range_unrestricted device
extension, which does have defined behavior with depth values outside
the range of 0.0..1.0.

Affects:

dEQP-VK.glsl.builtin_var.fragdepth.*d32_sfloat_large_depth

Components: Vulkan

VK-GL-CTS issue: 623

Change-Id: I436b8b98bebe3ef37bd306d93da2bf8c40eee6c8

6 years agoMerge changes from topic "multiview"
Treehugger Robot [Tue, 16 Jan 2018 19:08:18 +0000 (19:08 +0000)]
Merge changes from topic "multiview"

* changes:
  Add preliminary dEQP multiview test.
  Add multiview entry points to GL wrappers.

6 years agovk-default-no-waivers mustpass
Alexander Galazin [Mon, 15 Jan 2018 12:47:05 +0000 (13:47 +0100)]
vk-default-no-waivers mustpass

Components: Vulkan

Change-Id: Iec7c2a45663cc318a67614c9e28b8631f1bd1faf

6 years agoAdd INTxx_MAX checks into check_all.py
Boris Zanin [Wed, 10 Jan 2018 12:15:36 +0000 (13:15 +0100)]
Add INTxx_MAX checks into check_all.py

The mentioned consts are not defined in Windows, but are defined in linux.
Presence of this consts breaks Windows builds. To make it easyily detectable
under linux additional check for [U]INT[8,16,32,64]_MAX consts is added
into check_all.py script.

Components: Framework

VK-GL-CTS Issue: 934

Change-Id: I1882c0cd283a63a623972cb69ffb292531e37d10

6 years agoUpdate GL mustpass
Alexander Galazin [Mon, 15 Jan 2018 11:15:02 +0000 (12:15 +0100)]
Update GL mustpass

Components: OpenGL

Change-Id: I378bf119d71b2e8b9785458bb9972452ebbadd58

6 years agoLimit maximum allocation size in memory mapping tests am: adff582b50 am: 71ef361f3e...
Pyry Haulos [Sat, 13 Jan 2018 00:10:10 +0000 (00:10 +0000)]
Limit maximum allocation size in memory mapping tests am: adff582b50 am: 71ef361f3e am: fe861b61a5
am: 8d3d9ceddb

Change-Id: Ifa3b4bdebfc75dd273119a117fc9bfe131a60c2f

6 years agoImprove memory tracking in vulkan memory mapping tests am: 3a8ec35d52 am: b1f38f97cf...
Mika Isojrvi [Sat, 13 Jan 2018 00:10:00 +0000 (00:10 +0000)]
Improve memory tracking in vulkan memory mapping tests am: 3a8ec35d52 am: b1f38f97cf  -s ours am: 346da766ee
am: 40f1c9ad64

Change-Id: I39c3d0f7df1cb3da09e1758d9716c599ffad8cdd

6 years agoOptimize random memory mapping tests reference memory am: 7e69d67a2c am: b2dcf86f17...
Mika Isojrvi [Sat, 13 Jan 2018 00:09:51 +0000 (00:09 +0000)]
Optimize random memory mapping tests reference memory am: 7e69d67a2c am: b2dcf86f17  -s ours am: 1883d6ef48
am: 225bb3c908

Change-Id: I1ef89fe87aaa220a66cfa26008a06bda04295862

6 years agoLimit maximum allocation size in memory mapping tests am: adff582b50 am: 71ef361f3e
Pyry Haulos [Sat, 13 Jan 2018 00:04:17 +0000 (00:04 +0000)]
Limit maximum allocation size in memory mapping tests am: adff582b50 am: 71ef361f3e
am: fe861b61a5

Change-Id: Id7e2ade9ceaad34bee00b2b36bfde50ca2492dd5

6 years agoImprove memory tracking in vulkan memory mapping tests am: 3a8ec35d52 am: b1f38f97cf...
Mika Isojrvi [Sat, 13 Jan 2018 00:04:00 +0000 (00:04 +0000)]
Improve memory tracking in vulkan memory mapping tests am: 3a8ec35d52 am: b1f38f97cf  -s ours
am: 346da766ee

Change-Id: Iece2a8d3c40b646e982008d82f40b16dfdbf94ca

6 years agoOptimize random memory mapping tests reference memory am: 7e69d67a2c am: b2dcf86f17...
Mika Isojrvi [Sat, 13 Jan 2018 00:03:38 +0000 (00:03 +0000)]
Optimize random memory mapping tests reference memory am: 7e69d67a2c am: b2dcf86f17  -s ours
am: 1883d6ef48

Change-Id: I9f6246177cc3651b84370fedd7f48fd9dddf1f94

6 years agoLimit maximum allocation size in memory mapping tests am: adff582b50
Pyry Haulos [Fri, 12 Jan 2018 23:57:24 +0000 (23:57 +0000)]
Limit maximum allocation size in memory mapping tests am: adff582b50
am: 71ef361f3e

Change-Id: I138e6025b0cfb77ffd8197b796e32b06011cbc8a

6 years agoImprove memory tracking in vulkan memory mapping tests am: 3a8ec35d52
Mika Isojrvi [Fri, 12 Jan 2018 23:57:09 +0000 (23:57 +0000)]
Improve memory tracking in vulkan memory mapping tests am: 3a8ec35d52
am: b1f38f97cf  -s ours

Change-Id: I8fc045601456dd0b8d0026c4e70db43cf4998886

6 years agoOptimize random memory mapping tests reference memory am: 7e69d67a2c
Mika Isojrvi [Fri, 12 Jan 2018 23:56:55 +0000 (23:56 +0000)]
Optimize random memory mapping tests reference memory am: 7e69d67a2c
am: b2dcf86f17  -s ours

Change-Id: Iaa15b3997481353a88aef19cdde4348ae2cc3f75

6 years agoLimit maximum allocation size in memory mapping tests
Pyry Haulos [Fri, 12 Jan 2018 22:57:15 +0000 (22:57 +0000)]
Limit maximum allocation size in memory mapping tests
am: adff582b50

Change-Id: Iff465c2be4d7c27702036f8f060a458c55830732

6 years agoImprove memory tracking in vulkan memory mapping tests
Mika Isojrvi [Fri, 12 Jan 2018 22:57:12 +0000 (22:57 +0000)]
Improve memory tracking in vulkan memory mapping tests
am: 3a8ec35d52

Change-Id: I54613d0c408d80a65cc175e86495d0ffd4c650b5

6 years agoOptimize random memory mapping tests reference memory
Mika Isojrvi [Fri, 12 Jan 2018 22:57:10 +0000 (22:57 +0000)]
Optimize random memory mapping tests reference memory
am: 7e69d67a2c

Change-Id: I2c91c3720102d1c4c949bf19a2b6af51c59581f1

6 years agoAdd preliminary dEQP multiview test.
Philip Rideout [Wed, 20 Dec 2017 23:52:51 +0000 (15:52 -0800)]
Add preliminary dEQP multiview test.

This is a pretty basic test of multiview, we'll be enhancing the test
in the near future to provide coverage for additional texture formats.

Test: Passes on Pixel 2 hardware, ran dEQP with --deqp-case=dEQP-GLES3.functional.multiview.*
Change-Id: I16e855641da04e3a09e54d82808f1034e87bc4fc
Component: AOSP

6 years agoMultiple draw buffers in blend_equation_advanced am: 123de4f307
Mark Adams [Fri, 12 Jan 2018 21:50:30 +0000 (21:50 +0000)]
Multiple draw buffers in blend_equation_advanced am: 123de4f307
am: ddd1655bf6

Change-Id: I73797808261dc6a3b0522ee103fa5e44eb97eb4c

6 years agoMultiple draw buffers in blend_equation_advanced
Mark Adams [Fri, 12 Jan 2018 21:44:17 +0000 (21:44 +0000)]
Multiple draw buffers in blend_equation_advanced
am: 123de4f307

Change-Id: I1ce06acaa4f5f725097bcc248b7dbdf048bac61e

6 years agoReinstate excluded UBO tests
Chris Forbes [Fri, 12 Jan 2018 19:34:00 +0000 (11:34 -0800)]
Reinstate excluded UBO tests

These were excluded in O CTS because of an inadvertent shader codegen
change. Reinstate the tests for the next version.

Bug: b/71902667
Test: check_build_sanity
Change-Id: I58dd09d7d7d43081f27287bfa51d7f63d6b1e51b
Affects: dEQP-VK.ubo.random.*

6 years agoMultiple draw buffers in blend_equation_advanced
Mark Adams [Fri, 20 Oct 2017 13:49:08 +0000 (09:49 -0400)]
Multiple draw buffers in blend_equation_advanced

GL_NVX_blend_equation_advanced_multi_draw_buffers adds support for
multiple draw buffers with advanced blend equations. This change
modifies the below test to check for this extension and to expect
GL_NO_ERROR if it is present.

Components: AOSP

VK-GL-CTS issue: 770
Bug: b/71901344

Affects:
dEQP-GLES31.functional.debug.negative_coverage.get_error.advanced_blend.attachment_advanced_equation
(cherry picked from commit 2cb35a235c1a7bd3c63b296c37e186eec34e08e2)

Change-Id: I865fa30e527b5899197bade465602bafc92a54a1

6 years agoReinstate dEQP-VK.image.mutable.*
Chris Forbes [Fri, 12 Jan 2018 18:48:00 +0000 (10:48 -0800)]
Reinstate dEQP-VK.image.mutable.*

These were pulled from the O CTS because they were introduced in a minor
1.0.2.x release. They can now be reinstated.

Bug: b/65845002
Test: check_build_sanity
Change-Id: Icaf0e6073abda5d00f2b6e994bef3fffc31a1cda

6 years agoMerge remote-tracking branch 'aosp/master' into deqp-dev
Chris Forbes [Fri, 12 Jan 2018 18:33:20 +0000 (10:33 -0800)]
Merge remote-tracking branch 'aosp/master' into deqp-dev

Change-Id: If6c19e0cbe0011053af9abe2632534ed23e8a8fe

6 years agoMerge vk-gl-cts/opengl-cts-4.6.0 into vk-gl-cts/master
Alexander Galazin [Fri, 12 Jan 2018 16:02:58 +0000 (17:02 +0100)]
Merge vk-gl-cts/opengl-cts-4.6.0 into vk-gl-cts/master

Change-Id: If8425e73545dec10d8501eb6fb75be5200332e65

6 years agoMerge vk-gl-cts/opengl-es-cts-3.2.4 into vk-gl-cts/master
Alexander Galazin [Fri, 12 Jan 2018 15:52:48 +0000 (16:52 +0100)]
Merge vk-gl-cts/opengl-es-cts-3.2.4 into vk-gl-cts/master

Change-Id: Ie914b0dd7b4facbfa83b89e7d41c8390446843c6

6 years agoMerge vk-gl-cts/vulkan-cts-1.0.2 into vk-gl-cts/master
Alexander Galazin [Fri, 12 Jan 2018 14:02:07 +0000 (15:02 +0100)]
Merge vk-gl-cts/vulkan-cts-1.0.2 into vk-gl-cts/master

Change-Id: I9dc9a99346b7d4079166b53ecbc847568291864e

6 years agoFix instance-rate vertex attribute verification
Maciej Jesionowski [Thu, 5 Oct 2017 12:40:53 +0000 (14:40 +0200)]
Fix instance-rate vertex attribute verification

There was a bug in the test where it expected instance-rate vertex
attribute data at incorrect offsets in the input buffer. As a result
these attributes were always treated as out of bounds.

Affects: dEQP-VK.robustness.vertex_access.*

VK-GL-CTS issue: 752
Components: Vulkan

Change-Id: Ied900ab4174d4e8c25fd07c95e90d3c8228d5a26

6 years agoAdd missing barrier to texel_view_compatible tests
Maciej Jesionowski [Mon, 23 Oct 2017 10:14:36 +0000 (12:14 +0200)]
Add missing barrier to texel_view_compatible tests

There was no GPU to Host barrier. GPU writes are not automatically
visible to the Host.

Affected tests: dEQP-VK.image.texel_view_compatible.compute.*
VK-GL-CTS issue: 786
Components: Vulkan

Change-Id: I47797add1c5e48dfa1a7c7be8897e822091c2044

6 years agoRemove OpUConvert to signed integer tests
Andrey Tuganov [Thu, 28 Sep 2017 21:18:51 +0000 (17:18 -0400)]
Remove OpUConvert to signed integer tests

OpUConvert only convers to unsigned integers.

Affects: dEQP-VK.spirv_assembly.instruction.
compute.uconvert.*
Components: Vulkan

VK-GL-CTS issue: 720

Change-Id: I68b13c8584d64359e52910091347de03b933ba42

6 years agogl_PrimitiveIDIn tests have sketchy loop bounds.
Marcin Rogucki [Wed, 25 Oct 2017 11:33:44 +0000 (13:33 +0200)]
gl_PrimitiveIDIn tests have sketchy loop bounds.

Components: Vulkan

VK-GL-CTS issue: 778

Updates:
dEQP-VK.geometry.basic.primitive_id_in
dEQP-VK.geometry.basic.primitive_id_in_restarted

Change-Id: Icd2be56814de18067ce058a5f2a1da80338f80d6
(cherry picked from commit 52b7de31e0bccf62ca28d820f4dc2d0d52793aa8)

6 years agoYCbCr image views need a VkSamplerYcbcrConversionInfo
Tom Cooper [Wed, 25 Oct 2017 06:26:39 +0000 (08:26 +0200)]
YCbCr image views need a VkSamplerYcbcrConversionInfo

Ensure the image views are created using the
VkSamplerYcbcrConversionInfo object via the pNext
chaining, as this is mandated by the Spec.

Affects:
dEQP-VK.ycbcr.query.*

Components: Vulkan

VK-GL-CTS issue: 788

Change-Id: If641b08432c26ca5b32c084c4c0b9c7f935bcb94
(cherry picked from commit 9a9419aa130a51b6e24a564e6a3997a88af2504e)

6 years agoCheck sampleRateShading for sample_qualifier_distinct_values.* tests
Yanjun Zhang [Wed, 10 Jan 2018 00:26:50 +0000 (16:26 -0800)]
Check sampleRateShading for sample_qualifier_distinct_values.* tests

Affects: dEQP-VK.pipeline.*.sample_qualifier_distinct_values.*

Components: Vulkan

VK-GL-CTS issue: 925

Change-Id: Ife1166e8ed88699c67ee6acde79857f34c013398

6 years agoUse unique indices for each binding in out_of_pool_memory test
Chris Forbes [Tue, 9 Jan 2018 23:26:34 +0000 (15:26 -0800)]
Use unique indices for each binding in out_of_pool_memory test

Previously, all the layout bindings would use binding=0, which is
invalid. Give them their own binding indices.

VK-GL-CTS: 929

Change-Id: I28e62db6c257ed0843dd9b77b2d8cb01d02e3eba
Components: Vulkan
Affects: dEQP-VK.api.descriptor_pool.out_of_pool_memory

6 years agoAvoid hitting fp16 NaN values
Piers Daniell [Wed, 18 Oct 2017 17:01:13 +0000 (11:01 -0600)]
Avoid hitting fp16 NaN values

Modify the test references values to avoid situations where
they hit NaN values when viewed as fp16. This can happen
when uploading {0.1, 0.5, 0.9, 0.2} to r8g8b8a8_unorm which,
depending on the rounding of the 0.5, could end up as a 0x7F
value which when viewed as the MSB of a fp16 value is a NaN.

Affects:

dEQP-VK.image.mutable.*

Components: Vulkan

VK-GL-CTS Issue: 784

Change-Id: I2adbd27aa7d94254c9f19d788eacace2ea95d10c
(cherry picked from commit d51c248f04b980406d9b767064170b77b682cac7)

6 years agoInvalid handle in create_display_plane_surface
Alex Walters [Wed, 13 Dec 2017 15:47:23 +0000 (15:47 +0000)]
Invalid handle in create_display_plane_surface

This test attempts to create a display plane surface but incorrectly
fills in the VkDisplaySurfaceCreateInfo with an index into dEQP's array
of display modes instead of the VkDisplayModeKHR handle itself.

The app is required to specify a valid handle.

An invalid handle results in undefined behaviour.

Affects:

dEQP-VK.wsi.display.create_display_plane_surface

Components: Vulkan
VK-GL-CTS issue: 906

Change-Id: I9fbbd40926e26bf82ed11dc1b5e807922cbc4e73
(cherry picked from commit 3e6306a1f1abba17d9b3f4e36913576fa33ac13d)

6 years agoFix some CTS bugs that cause validation failures
Piers Daniell [Wed, 22 Nov 2017 20:23:12 +0000 (13:23 -0700)]
Fix some CTS bugs that cause validation failures

Most of these are misuse of the dstStageMask parameter to
vkCmdPipelineBarrier. The dstStageMask has to be compatible
with the destination access type of the buffer or image.

The other large source of validation errors is a bug
in the CTS framework when calling vkCreateDevice. The
wrong pNext member was used for setting the enabled
features. The effect is that all features were disabled.

Affects:

dEQP-VK.pipeline.push_constant.graphics_pipeline.*
dEQP-VK.pipeline.multisample_shader_builtin.sample_mask.pattern.*
dEQP-VK.*

Components: Vulkan

VK-GL-CTS issue: 862

Change-Id: I58ca4e033d7d66b52c6726a635808b9b747546d8
(cherry picked from commit 23336be1abda90e87d9bbaf5e0398ca489f0cbc6)

6 years agoAdd StorageImageExtendedFormats cap check
Alexander Galazin [Fri, 6 Oct 2017 20:07:30 +0000 (22:07 +0200)]
Add StorageImageExtendedFormats cap check

dEQP-VK.image.texel_view_compatible.compute.* didn't check
for shaderStorageImageExtendedFormats

Component: Vulkan

VK-GL-CTS issue: 753

Affects:
dEQP-VK.image.texel_view_compatible.compute.*

Change-Id: I957329a66d2f4bedb950a597a702ec29680418de
(cherry picked from commit 1a42786b8dba4e091e1012a458d3ad17457a6b66)

6 years agoEnforce OOB requirements for binding with multiple attributes
Noah Fredriks [Thu, 9 Nov 2017 21:00:29 +0000 (16:00 -0500)]
Enforce OOB requirements for binding with multiple attributes

The spec states that, if any vertex input attribute using a specific
vertex input binding is out of bounds, then all vertex input attributes
using that vertex input binding for that vertex shader invocation are
considered out of bounds.

Affects: dEQP-VK.robustness.vertex_access.*.vertex_incomplete

Components: Vulkan

VK-GL-CTS issue: 848

Change-Id: I6a9222a0b2a53368af361419105793a5301a6bf6
(cherry picked from commit 65df12f839cea43333b11a4da900f838d5f44150)

6 years agoPipeline must be bound before calling vkCmdSetViewport/Scissor etc
Tom Cooper [Wed, 22 Nov 2017 15:57:37 +0000 (15:57 +0000)]
Pipeline must be bound before calling vkCmdSetViewport/Scissor etc

Affects:
dEQP-VK.dynamic_state.*

Components: Vulkan

VK-GL-CTS issue: 861

Change-Id: I0f5312c83096cebebfa4ab01987c2ab9ede7306b
(cherry picked from commit f156345ea872a2913b09b076373bea715f89e3c9)

6 years agoRemove check for depthBounds support in frag depth tests
Alexander Galazin [Mon, 2 Oct 2017 07:13:02 +0000 (09:13 +0200)]
Remove check for depthBounds support in frag depth tests

The tests validate gl_FragDepth. This builtin should not
require any extra feature to be supported.

Components: Vulkan

VK-GL-CTS: 690

Affects: dEQP-VK.glsl.builtin_var.fragdepth.*

Change-Id: I7df775d074e5b9e6dd01f573f5a8545f3db72550
(cherry picked from commit 822f7251791c8b75ad1733c5fc6b4ec3240000ea)

6 years agoInvalidate memory in draw tests
Alexander Galazin [Tue, 3 Oct 2017 19:29:50 +0000 (21:29 +0200)]
Invalidate memory in draw tests

The test group writes to non-coherent device memory with device,
but fails to call the required invalidate on the region before
reading mapped memory with host.

Components: Vulkan

VK-GL-CTS issue: 529

Affects: dEQP-VK.draw.*

Change-Id: Icf4aa6ea80c8c046e41b37402457b7f094d7ae50
(cherry picked from commit 1ce6e233a6245a1cf81a2a4e88b87c5d381a119a)

6 years agoAvoid assert in dEQP-VK.tessellation.fractional_spacing
Slawomir Cygan [Fri, 22 Sep 2017 15:23:05 +0000 (17:23 +0200)]
Avoid assert in dEQP-VK.tessellation.fractional_spacing

The test code dereferences first element of empty std::vector, what
may cause an assert in debug builds (depending on toolchain and it's
settings).

Addects: dEQP-VK.tessellation.*

Components: Vulkan

VK-GL-CTS issue: 710

Change-Id: I2b94a0d03c3523ebf1380a9371765c616fd21b82
(cherry picked from commit b81810d2446bac26ea0d5fb017250934842eb643)

6 years agoFix depth & stencil passOp for pipeline.render_to_image tests
Petros Bantolas [Mon, 18 Sep 2017 16:07:22 +0000 (17:07 +0100)]
Fix depth & stencil passOp for pipeline.render_to_image tests

Affects:
dEQP-VK.pipeline.render_to_image.*_array* with stencil attachments

Those tests render to each layer of the texture in consecutive
subpasses. With a depth/stencil passOp of VK_STENCIL_OP_ZERO, subpasses
after the first one fail the stencil test and skip the render.

Components: Vulkan

VK-GL-CTS issue: 678

Change-Id: Ia704192b8d7e316dacaa7549faa5cb5aa0def60e
(cherry picked from commit 09c67dc11c94f48a03a91c5be920fb940cdc792c)

6 years agoFix unreasonable memory expectations in pipeline.render_to_image
Arkadiusz Sarwa [Tue, 12 Sep 2017 11:28:39 +0000 (13:28 +0200)]
Fix unreasonable memory expectations in pipeline.render_to_image

Affects:
dEQP-VK.pipeline.render_to_image.*

Components: Vulkan

VK-GL-CTS issue: 526

Change-Id: I71ea0381663c39786b227ed712e1111ec3c71cfb
(cherry picked from commit 069aa0ad097f543438b39a260eea52278867ffa8)

6 years agoFix imageExtent to use correct destination size
Piers Daniell [Wed, 4 Oct 2017 16:51:12 +0000 (10:51 -0600)]
Fix imageExtent to use correct destination size

This fixes an issue with using imageParms to specify the
imageExtent for the cases where the test has done scaling
between the source and destination surfaces.

VK-GL-CTS issue: 729

Affects:

dEQP-VK.api.copy_and_blit.*

Change-Id: I4053496dfa1fdedd9edb7e108e554cb988559bcf
Components: Vulkan
(cherry picked from commit 16986d105c5af4c4ef6f8f54df5c42ec5c357bb5)

6 years agoMerge "Reduce GPU workload of pipeline_barrier tests" into oreo-cts-dev am: 4c26442e3d
Jeff Leger [Fri, 12 Jan 2018 01:35:31 +0000 (01:35 +0000)]
Merge "Reduce GPU workload of pipeline_barrier tests" into oreo-cts-dev am: 4c26442e3d
am: d9b0dd51d2

Change-Id: Iddae106a643abc1cae3a66877bc6f32126ea5781

6 years agoMerge "Reduce GPU workload of pipeline_barrier tests" into oreo-cts-dev
Jeff Leger [Fri, 12 Jan 2018 01:31:43 +0000 (01:31 +0000)]
Merge "Reduce GPU workload of pipeline_barrier tests" into oreo-cts-dev
am: 4c26442e3d

Change-Id: I32a3a35837be16886acebd28e30ccdadffa73811

6 years agoMerge "Reduce GPU workload of pipeline_barrier tests" into oreo-cts-dev
Treehugger Robot [Fri, 12 Jan 2018 01:10:31 +0000 (01:10 +0000)]
Merge "Reduce GPU workload of pipeline_barrier tests" into oreo-cts-dev

6 years agoglshared: Add watchdog touches to avoid timeouts on slow hardware am: 0d9250e9eb
Chris Forbes [Thu, 11 Jan 2018 22:32:16 +0000 (22:32 +0000)]
glshared: Add watchdog touches to avoid timeouts on slow hardware am: 0d9250e9eb
am: 65715b7354

Change-Id: I7530fe8d79d43fb5a269347cd302709c7498b764

6 years agoglshared: Add watchdog touches to avoid timeouts on slow hardware
Chris Forbes [Thu, 11 Jan 2018 22:22:49 +0000 (22:22 +0000)]
glshared: Add watchdog touches to avoid timeouts on slow hardware
am: 0d9250e9eb

Change-Id: If675c974a2389787e53d2d618509ca81a48990d9

6 years agoMerge vk-gl-cts/vulkan-cts-1.0.2 into vk-gl-cts/master
Alexander Galazin [Thu, 11 Jan 2018 12:40:43 +0000 (13:40 +0100)]
Merge vk-gl-cts/vulkan-cts-1.0.2 into vk-gl-cts/master

Change-Id: Iff4b07d342db175706efd91f3197b93cb51b520d