ziga-lunarg [Mon, 27 Feb 2023 15:01:56 +0000 (16:01 +0100)]
Fix global priority tests
Extensions VK_KHR_global_priority and VK_EXT_global_priority behave
differently, this test was once changed to fix the test using the
KHR extension, but it broke the test using EXT
The structs from global priority query must only be used with the KHR
version of the test
Components: Vulkan
VK-GL-CTS issue: 3898
Affected tests:
dEQP-VK.api.device_init.create_device_global_priority*
Change-Id: I906d8f9d7593f49533eb73c8faac4920dc9ce0c8
Piotr Byszewski [Fri, 10 Mar 2023 08:35:41 +0000 (09:35 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: I67d7c74c40ab4c824c1841d64b601f1c2e1ed5a1
Piotr Byszewski [Thu, 9 Mar 2023 18:04:52 +0000 (19:04 +0100)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: I0e58080147d67fd4b4dc8c6ce699fcf0975462fa
ziga-lunarg [Sun, 19 Feb 2023 12:27:26 +0000 (13:27 +0100)]
Fix checking support in texture filtering tests
The tests use mipmaps even if the test parameter for mipmaps is false
and the check support function does not do that
Components: Vulkan
VK-GL-CTS issue: 4294
Affected tests:
dEQP-VK.texture.filtering.2d_array.*
Change-Id: Iabd33803fc952f3ea4c7598674fd9f58b53070d4
Marcin Kańtoch [Thu, 16 Feb 2023 16:45:33 +0000 (17:45 +0100)]
Wrong assumption in robustness tests
Accept cases, such as <0.0f, 123.0f>, <123.0f, 0.0f>
for out of bounds memory, as those can be correctly
generated by the compiler.
VK-GL-CTS issue: 4288
Components: Vulkan
Affects:
dEQP-VK.robustness.robustness2.*
Change-Id: If54aedf4277d93b404056274e397e7f73c05872b
Matthew Netsch [Fri, 24 Feb 2023 16:18:56 +0000 (08:18 -0800)]
Fix timeout case in vktSynchronizationTimelineSemaphoreTests
Loop was inverted and race condition on error status.
Components: Vulkan
VK-GL-CTS Issue: 4282
Affects:
dEQP-VK.synchronization*.timeline_semaphore.wait.poll*
Change-Id: I8811dbcbdc34130c8bf4ced7e4e3013ca411da05
Piotr Byszewski [Fri, 3 Mar 2023 12:37:25 +0000 (13:37 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: Idd791399ad26c7817670c730f215978cdaf0831f
Piotr Byszewski [Fri, 3 Mar 2023 12:06:59 +0000 (13:06 +0100)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: I2cdda0aa78f3796624c037050f5fad0cbf757575
aitor_lunarg [Mon, 16 Jan 2023 22:59:34 +0000 (23:59 +0100)]
Fix query_present_modes_surfaceless tests
Tests expected to have same values for null surface and non-null
surfaces when retrieving present modes which is not correct.
When retrieving present modes with null surfaces, retrieved modes
will be a subset of all modes present in all surfaces for version 1.
For version 2, they can either be FIFO_KHR, SHARED_DEMAND_REFRESH_KHR
and SHARED_CONTINUOUS_REFRESH_KHR.
Affects:
dEQP-VK.wsi.*.surface.query_present_modes_surfaceless
Components: Vulkan
VK-GL-CTS issue: 4221
Change-Id: I79be6e8537184572ab164a7216e65d7e2f60bc42
Ricardo Garcia [Fri, 17 Feb 2023 08:33:39 +0000 (09:33 +0100)]
Fix overlapping mutable descriptor types
Some mutable decriptor test variants create pools with several mutable
descriptor entries with overlapping types, which is forbidden by the
spec and results in VUID-VkDescriptorPoolCreateInfo-pPoolSizes-04787.
Affects:
dEQP-VK.binding_model.mutable_descriptor.single_and_array.*
Components: Vulkan
VK-GL-CTS issue: 4289
Change-Id: Ia4274a6f13c52257c0e84e8711a8d883dab0cc36
James Fitzpatrick [Thu, 19 Jan 2023 15:29:58 +0000 (15:29 +0000)]
Disable image robustness by default
Image robustness was being disabled on the default device due to
robustness potentially having
However, when VK_EXT_image_robustness was promoted into Vulkan 1.3
the feature was also added to the 1.3 rollup structure
(VkPhysicalDeviceVulkan1p3Features).
The feature in the 1.3 rollup structure was not being disabled, leading
to robustImageAccess being enabled on any device supporting 1.3
Affects: dEQP-VK.*
Components: vulkan, framework
VK-GL-CTS issue: 4241
Change-Id: I2910fab278a3fd56233db0cee754e9be8372df82
Piotr Byszewski [Fri, 10 Feb 2023 17:47:44 +0000 (18:47 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: Ib344bfdf712d93068f83173623ab06d6824699a7
Piotr Byszewski [Fri, 10 Feb 2023 17:28:43 +0000 (18:28 +0100)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: Ie5e02bf822672fab279d37c028fb66ced1aeae48
Maciej Jurga [Wed, 25 Jan 2023 08:36:52 +0000 (09:36 +0100)]
Change HLSL to avoid nested runtimeArray in SPIR-V
Replace a structure used in RWStructuredBuffer by HLSL tessellation
evaluation shader with two RWStructuredBuffers of a basic type.
Old structure had a dynamic length array member, that caused glslang to
produce invalid SPIR-V with nested runtimeArray decoration.
Components: Vulkan
VK-GL-CTS issue: 2697
Affected tests:
dEQP-VK.tessellation.fractional_spacing.*
Change-Id: I4b55ca3688289b6ca22fa642972dc28e11a5659f
Piotr Byszewski [Thu, 2 Feb 2023 19:26:04 +0000 (20:26 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: Ic7b88eb0135468ea8b013fff65e216a0bc945a6b
Piotr Byszewski [Thu, 2 Feb 2023 18:23:39 +0000 (19:23 +0100)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: I4ec95db96541e01f4e47d3fe1abdd3f9e305adbb
Joe Withers [Mon, 30 Jan 2023 17:32:24 +0000 (17:32 +0000)]
Fix tolerance values when VK_COMPONENT_SWIZZLE_ONE is in use
Tolerance values were being increased unnecessarily for tests using
VK_COMPONENT_SWIZZLE_ONE.
This change overwrites any SWIZZLE_ONE with SWIZZLE_ZERO when applying
a swizzle to the threshold values, to maintain a strict tolerance.
Affects: dEQP-VK.pipeline.sampler.border_swizzle.*
Components: Vulkan
Change-Id: Ie72e4a97e502bdbb74ea412951f5a9481434d489
Charles Johnston [Thu, 19 Jan 2023 15:58:04 +0000 (10:58 -0500)]
Enable CTS log files to exceed 2GB on 32-bit Linux build
Components: Framework
VK-GL-CTS issue: 4238
Change-Id: Ie9c58364f0bb44c3b2a15a71585d4801d0b12063
Charlie Turner [Mon, 23 Jan 2023 13:35:26 +0000 (13:35 +0000)]
Prevent warnings from Amber failing the CTS build
With clang++-16, I'm seeing lots of cases like,
/home/cturner/src/vk-gl-cts/external/amber/src/src/float16_helper.cc:66:42: error: unchecked operation on raw buffer in expression [-Werror,-Wunsafe-buffer-usage]
uint32_t sign = (static_cast<uint32_t>(value[1]) & 0x80) << 24U;
Inhibit all warning messages for Clang, GCC & MSVC.
Components: Framework, Vulkan
Change-Id: I1910780048d8828a61733a5f5f36404f8a8184b0
Piotr Byszewski [Fri, 27 Jan 2023 10:30:35 +0000 (11:30 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: Ic6015e95ad8e7d411948ec7ef1ccaf33081212f7
ziga-lunarg [Fri, 6 Jan 2023 17:09:46 +0000 (18:09 +0100)]
Fix rgba10x6 feature check in texture filtering tests
If VK_IMAGE_USAGE_SAMPLED_BIT is used when creating the image
VkSamplerYcbcrConversionInfo is required in the pNext chain, if format
is VK_FORMAT_R10XgG10X6B10X6A10X6_UNORM_4PACK16 and
formatRgba10x6WithoutYCbCrSampler feature is not enabled
Components: Vulkan
VK-GL-CTS issue: 4206
Affected tests:
dEQP-VK.texture.filtering.*
Change-Id: I296ac69902f87b301f4e2930d28b171e8ce02a13
ziga-lunarg [Fri, 6 Jan 2023 16:34:34 +0000 (17:34 +0100)]
Add missing support check in texture filtering with rgba10x6 format
Feature formatRgba10x6WithoutYCbCrSampler must be enabled when
VK_FORMAT_R10X6G10X6B10X6A10X6_UNORM_4PACK16 is used in these tests,
because more than 1 mip level is used and only formats which do not
require sampler YCbCR conversion can be used
Components: Vulkan
VK-GL-CTS issue: 4205
Affected tests:
dEQP-VK.texture.filtering.cube.*
Change-Id: I3bdd286af2d0f2c19443e5d64304c69e43a43095
Piotr Byszewski [Fri, 27 Jan 2023 08:48:28 +0000 (09:48 +0100)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: I29ea16db0e7ddc2b374888f41ed07523b233aedb
ziga-lunarg [Sun, 15 Jan 2023 11:47:18 +0000 (12:47 +0100)]
Fix image barrier in ray tracing pipeline build tests
Use the correct combination of access mask and pipeline stage
Components: Vulkan
VK-GL-CTS issue: 4202
Affected tests:
dEQP-VK.ray_tracing_pipeline.build.*
Change-Id: I185c3787b6bfa24c79f5fbd063fc041d000ae0f4
Hyunjun Ko [Fri, 20 Jan 2023 02:11:02 +0000 (11:11 +0900)]
Do not allow to call vkSetEvent after submission, which is invalid.
The spec says:
"If a command buffer submission waits for any events to be signaled,
the application must ensure that command buffer submissions will be
able to complete without any subsequent operations by the application.
Events signaled by the host must be signaled before the command buffer
waits on those events."
This means it's not valid to signal an event on the host after submission
of a command buffer containing a wait for the event. Also it forces the
command buffer to stop for an unknown amount of time, as much as the time
needed for the host to signal the event with vkSetEvent.
However there were some CTS tests doing like this, which should be
fixed.
For vktApiExternalMemoryTests.cpp,
There was a vkSetEvent call after submission to hold a command to be
executed before signaling to get a native file descriptor, which is
not valid. So the tests should allow to get -1. Also we do an atomic calculation
to avoid singalling right after submit when trying to get a native fd.
The simple atomic calculation is evaluated to take about 10ms.
For vktApiExternalMemoryTests.cpp and vktMemoryExternalMemoryHostTests.cpp,
replace vkSetEvent with timeline semaphore to signal from the host.
Affects:
dEQP-VK.api.external.semaphore.*
dEQP-VK.api.external.fence.*
dEQP-VK.api.command_buffers.secondary_execute_twice
dEQP-VK.memory.external_memory_host.synchronization.synchronization
VK-GL-CTS Issue: 4075
Components: Vulkan
Change-Id: I5544bb15a418bbbbd6552ca04bec673a56ca3109
Sviatoslav Peleshko [Thu, 5 Jan 2023 23:40:46 +0000 (01:40 +0200)]
Add missing buffer memory flush
We do a memcpy to the buffer, but don't flush it. If we don't use
host-coherent memory for this buffer it might sometimes lead to
corruption (when we later invalidate the buffer's memory to get
results from the shader).
Components: Vulkan
Affected tests:
dEQP-VK.query_pool.statistics_query.compute_shader_invocations.*
dEQP-VK.query_pool.statistics_query.*.compute_shader_invocations.*
Signed-off-by: Sviatoslav Peleshko <sviatoslav.peleshko@globallogic.com>
Change-Id: I2f9491d6cacf39fe6a00d7624e2aa474615421ce
Connor Abbott [Tue, 29 Nov 2022 11:17:17 +0000 (12:17 +0100)]
Use correct extent for 1D compute texel_view_compatible tests
We weren't sanitizing the size in the parameters, resulting in
copyDataToImage() passing an extent with a non-1 height to when
uploading to a 1D image. Sanitize fullSize, and remove a case where
where we were workaround it not being sanitized.
Components: Vulkan
Affects: dEQP-VK.image.texel_view_compatible.compute.basic.1d_image.*
VK-GL-CTS Issue: 4143
Change-Id: Icdb50c09137a947f47b1afc7426e53e73c31f689
Piotr Byszewski [Fri, 20 Jan 2023 12:48:26 +0000 (13:48 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: Iaa91df30fc4231c3a428fef1c74c8d9aa72720ba
Piotr Byszewski [Fri, 20 Jan 2023 10:18:18 +0000 (11:18 +0100)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: I40db0dabbedb2e8245c3597bec80832a47f1658d
Slawomir Cygan [Thu, 12 Jan 2023 15:27:44 +0000 (16:27 +0100)]
Fix merge error in FSR srlayered tests
Reapply last chunk from
853897a8722 which seems to
have been broken in a merge: layercount value was passed
instead of viewFormatCount.
This is fixes a regression introduced by 10618, which was exposed
after being promoted to vulkan-cts-1.2.8+.
Components: Vulkan
VK-GL-CTS Issue: 4224
VK-GL-CTS Issue: 4226
Affects: dEQP-VK.fragment_shading_rate.*
Change-Id: Ib8f5b180368fe9bf3c32f349c2475a4932f30fbf
Piotr Byszewski [Thu, 19 Jan 2023 17:59:29 +0000 (18:59 +0100)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: Iaae2490f0ec3069759a7660dee175cfdc3668622
Aitor Camacho [Tue, 3 Jan 2023 18:25:23 +0000 (19:25 +0100)]
Update scripts for Android build
- Use d8 instead of dx due to deprecation
- Use apksigner instead of jarsigner for signature scheme v2 required by newer SDKs
- Move apk signing to be last step (required for signature scheme v2)
- Force uncompressed arsc files (required for SDK versions 30 and up)
- Add '--tool-api' argument for selecting build tools version
- Add permission for reading external storage in manifest
VK-GL-CTS Issue: 4163
Components: Framework
Change-Id: Iea4429f861148168ffe680cdf9a497cb467b8d6a
Dae Kim [Fri, 16 Dec 2022 11:43:24 +0000 (11:43 +0000)]
Fix bind-transfer synchronization in sparse texture tests
The copyBufferToImage() utility function submits a command buffer with a
copy-buffer-to-image transfer operation. The caller can optionally pass
a semaphore for the transfer to wait on, but the semaphore's wait flags
are set to VK_PIPELINE_STAGE_ALL_GRAPHICS_BIT, which does not include
transfer operations.
As a consequence of this, the transfer operation may ignore the wait
semaphore. In the affected test set this means that the transfer may
happen before sparse bind operations are completed.
Affects: dEQP-VK.texture.*sparse*
Components: Vulkan
VK-GL-CTS issue: 4183
Change-Id: Ia0f0c721e492703301440dbfcf07ed6495fddb1e
Piotr Byszewski [Fri, 13 Jan 2023 18:24:46 +0000 (19:24 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: Icc5dc1c0cbfd798e6df0e7b88d4830e1549a4126
Piotr Byszewski [Fri, 13 Jan 2023 16:21:02 +0000 (17:21 +0100)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: I2142832024febea1baee33b1df04af6921edb846
Piotr Byszewski [Fri, 13 Jan 2023 12:34:18 +0000 (13:34 +0100)]
Remove duplicated test groups
While adding support for dynamic rendering to renderpass group
a mistake was made that added 3 groups with the same tests to both
renderpass2 group and legacy renderpass group.
This mistake was fixed on 1.3.1 branch but is present on 1.2.8
and 1.3.0. There is no need to execute same tests twice - this
change removes duplicates. This fix should be propagated only to
1.3.0.
Components: Vulkan
VK-GL-CTS issue: 4225
Removed tests:
dEQP-VK.renderpass.depth_stencil_resolve.*
dEQP-VK.renderpass.fragment_density_map.*
dEQP-VK.renderpass2.multiple_subpasses_multiple_command_buffers.test
Change-Id: I571e499ead038acf1744c356b884f2be966e3c15
ziga-lunarg [Thu, 22 Dec 2022 12:52:24 +0000 (13:52 +0100)]
Fix oldLayout in image barriers in copy and blit tests
The same barriers are used twice, but the oldLayout is not updated
Components: Vulkan
VK-GL-CTS issue: 4054
Affected tests:
dEQP-VK.api.copy_and_blit.*
Change-Id: I8fd622846a2c9ce840ec6bfb5a431ae66a5af06f
Piotr Byszewski [Fri, 13 Jan 2023 10:11:20 +0000 (11:11 +0100)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: I1139cfa0a1d27a08bd6d3c72b2d65fd754edc886
ziga-lunarg [Fri, 16 Dec 2022 16:31:54 +0000 (17:31 +0100)]
Remove invalid separate_layouts tests on older branches
These tests were fixed, but only on 1.3.2 newer, they should be removed
on older branches
Components: Vulkan
VK-GL-CTS issue: 3527
Removed tests:
dEQP-VK.renderpass2.depth_stencil_resolve.*separate_layouts.*
Change-Id: I467ea14cc5c2eb26723cc9e2453ea5a11a1556b9
Piotr Byszewski [Sat, 7 Jan 2023 12:15:11 +0000 (13:15 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: Ie8e4ee5b77cbea1aa87664a38a074f2381d2ea15
Piotr Byszewski [Sat, 7 Jan 2023 11:05:29 +0000 (12:05 +0100)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: I7507fe1cee9b7bccdbfc4883f0ee6937c116b30a
Piotr Byszewski [Thu, 5 Jan 2023 18:12:20 +0000 (19:12 +0100)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: Iea24c631e95fad0dbf694e67f141c243fda3a3d9
ziga-lunarg [Sat, 19 Nov 2022 22:46:51 +0000 (23:46 +0100)]
Fix 2d image views in fragment shading rate tests
If viewType is VK_IMAGE_VIEW_TYPE_2D then subresourceRange.layerCount
must be 1
Components: Vulkan
VK-GL-CTS issue: 4124
Affected tests:
dEQP-VK.fragment_shading_rate.*
Change-Id: I32db55ce0785a2d91c391625bfed312d5e7371f0
Andrew Fobel [Mon, 5 Dec 2022 21:16:01 +0000 (16:16 -0500)]
Fix VK_KHR_global_priority tests
Use enabledExtensions to properly enable VK_EXT_global_priority_query
along with passing the globalPriorityQueryFeatures struct.
Components: Vulkan
VK-GL-CTS issue: 4157
Affected tests:
dEQP-VK.api.device_init.create_device_global_priority*
Change-Id: Ib024f187f835914bbcb94e42a40d60a32fed0f99
Piers Daniell [Mon, 5 Dec 2022 22:01:43 +0000 (15:01 -0700)]
Work around deArraySizeHelper deficiency with multi-dimension arrays
This fixes a compilation issue with some compilers with deArraySizeHelper
and implicitly sized multi-dimensional arrays.
Affects:
Compilation only.
Components: Framework, Vulkan
VK-GL-CTS issue: 4158
Change-Id: Ie200647f34096b54544aff7f8d82b1eefabbd586
Piotr Byszewski [Fri, 16 Dec 2022 12:35:27 +0000 (13:35 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: Id3cf5e258bce8b7aec13bc44abdada774159136b
Piotr Byszewski [Fri, 16 Dec 2022 11:15:18 +0000 (12:15 +0100)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: Ifdc6f7c08ccb5f65d44e406a7dc6ea6866102ad5
Piotr Byszewski [Fri, 16 Dec 2022 08:42:48 +0000 (09:42 +0100)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: Ib14adccc08aa0dd8767e6dea0199e021885d292d
ziga-lunarg [Sat, 19 Nov 2022 13:02:59 +0000 (14:02 +0100)]
Fix errors in sparse resources tests
VK_EXT_shader_image_atomic_int64 extension must be enabled on the device
if used
Feature structs from non-enabled extensions must not be passed to
VkDeviceCreateInfo pNext
Checks if image formats are supported are missing
Components: Vulkan
VK-GL-CTS issue: 4122
Affected tests:
dEQP-VK.sparse_resources.shader_intrinsics.*
Change-Id: I4fcac8eae1d53826d5ef5f8a7dcc04bfe95f7360
ziga-lunarg [Fri, 18 Nov 2022 18:49:35 +0000 (19:49 +0100)]
Fix subpass dependency dstStageMask in shader_fragment_mask tests
Stage VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUT_BIT must be included if
access mask is VK_ACCESS_COLOR_ATTACHMENT_READ_BIT
Components: Vulkan
VK-GL-CTS issue: 4120
Affected tests:
dEQP-VK.pipeline.*.shader_fragment_mask.*
Change-Id: Iea2a62ff5781c50ad39d707a8eb0f1f4ce344f48
Yun Shu [Mon, 5 Dec 2022 08:20:43 +0000 (16:20 +0800)]
Set correct pipeline barrier between clear image and trace ray
The image is cleared with fixed value, then used as write destination
in ray tracing shaders. The pipeline barrier set for the image is
incorrect between clear command and trace ray command.
Affects:
dEQP-VK.ray_tracing_pipeline.large_shader_set.*
Components: Vulkan
VK-GL-CTS issue: 4137
Change-Id: I41dd55d51ea995c4c878e053f6d617b2e38ba5b1
Amber [Mon, 21 Nov 2022 10:54:07 +0000 (11:54 +0100)]
Add check for the return value of vkGetPhysicalDeviceImageFormatProperties2
Also do not attempt to create images for depth/stencil usage using color formats.
Components: Vulkan
VK-GL-CTS issue: 4125
Affected tests:
dEQP-VK.api.external.memory.dma_buf.suballocated.image.info
Change-Id: If1f41b967d03f1b862c85277d6fe30b20ab1a110
Matthew Netsch [Thu, 8 Dec 2022 18:58:13 +0000 (18:58 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: Icc350abe29e7c1545a65d99884a281cd63239fc4
Matthew Netsch [Thu, 8 Dec 2022 18:30:33 +0000 (18:30 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: Ibfc5624676bae49d9630978494cdfdc660a0fba4
Matthew Netsch [Thu, 8 Dec 2022 18:01:39 +0000 (18:01 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: If5512ea90e2442bc7304502d78cc3b1333f53479
ziga-lunarg [Sun, 4 Dec 2022 20:48:26 +0000 (21:48 +0100)]
Write gl_PointSize in depth tests
Some depth tests use VK_PRIMITIVE_TOPOLOGY_POINT_LIST but the shaders
don't write the point size
Components: Vulkan
VK-GL-CTS issue: 4153
Affected tests:
dEQP-VK.pipeline.*.depth.*
Change-Id: Idaa9ea65f7c43ca02d7780d1825d4558b712a133
ziga-lunarg [Mon, 5 Dec 2022 15:34:50 +0000 (16:34 +0100)]
Add check if format is supported in external memory host tests
Format properties for format used for color attachment must contain
VK_FORMAT_FEATURE_COLOR_ATTACHMENT_BIT
Components: Vulkan
VK-GL-CTS issue: 4156
Affected tests:
dEQP-VK.memory.external_memory_host.bind_image_memory_and_render.*
Change-Id: Ib0346cbc849b94a5af67e5645cc057ca392f9b2f
ziga-lunarg [Fri, 18 Nov 2022 18:11:56 +0000 (19:11 +0100)]
Fix invalid framebuffer in compressed texture 3D tests
Framebuffer attachments must be created with viewType not equal to
VK_IMAGE_VIEW_TYPE_3D
Components: Vulkan
VK-GL-CTS issue: 4118
Affected tests:
dEQP-VK.texture.compressed_3D.*
Change-Id: I9ae036d02daa3579567bf514c70bf623a0bc9aa9
ziga-lunarg [Sat, 19 Nov 2022 19:06:44 +0000 (20:06 +0100)]
Fix flushing memory range in memory model shared tests
Each size of pMemRanges in vkFlushMappedMemoryRanges must be either a
multiple of VkPhysicalDeviceLimits::nonCoherentAtomSize or equal to the
size of memory
Components: Vulkan
VK-GL-CTS issue: 4123
Affected tests:
dEQP-VK.memory_model.shared.*
Change-Id: I0f3ea96736aa73eb92c7809c04297923d84e348c
Matthew Netsch [Thu, 1 Dec 2022 17:33:11 +0000 (17:33 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: Iacdc3192254c41c569dbad94d8025b936f93cc25
Matthew Netsch [Thu, 1 Dec 2022 17:05:02 +0000 (17:05 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: I7a7605b2dffeaedac543e32d97f13f552d6ab68f
ziga-lunarg [Fri, 4 Nov 2022 22:56:17 +0000 (23:56 +0100)]
Re-add texture filtering tests with rgba10x6 format
These tests were removed when only the check for
formatRgba10x6WithoutYCbCrSampler feature was missing
Components: Vulkan
VK-GL-CTS issue: 3646
New tests:
dEQP-VK.texture.filtering.3d.formats.r10x6g10x6b10x6a10x6_unorm.r10x6g10x6b10x6a10x6_unorm_nearest
dEQP-VK.texture.filtering.3d.formats.r10x6g10x6b10x6a10x6_unorm.r10x6g10x6b10x6a10x6_unorm_linear
dEQP-VK.texture.filtering.3d.formats.r10x6g10x6b10x6a10x6_unorm.r10x6g10x6b10x6a10x6_unorm_nearest_mipmap_nearest
dEQP-VK.texture.filtering.3d.formats.r10x6g10x6b10x6a10x6_unorm.r10x6g10x6b10x6a10x6_unorm_linear_mipmap_nearest
dEQP-VK.texture.filtering.3d.formats.r10x6g10x6b10x6a10x6_unorm.r10x6g10x6b10x6a10x6_unorm_nearest_mipmap_linear
dEQP-VK.texture.filtering.3d.formats.r10x6g10x6b10x6a10x6_unorm.r10x6g10x6b10x6a10x6_unorm_linear_mipmap_linear
Change-Id: Ida3cb9f1abd95f57908b9540c65605cbb1b40fa3
Matthew Netsch [Thu, 1 Dec 2022 16:37:27 +0000 (16:37 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: I36f8b8142517f82d581ee2bc365a97ff37a63dc8
Hyunjun Ko [Wed, 23 Nov 2022 08:46:24 +0000 (17:46 +0900)]
Fix invalid usage of descriptorCount for inline uniform
blocks.
Affects:
dEQP-VK.binding_model.descriptorset_random.*.iublimit*
VK-GL-CTS Issue: 4115
Components: Vulkan
Change-Id: I649d86b859ca642b47c1fda4aa915e1d6616c898
Gary Sweet [Thu, 24 Nov 2022 09:16:09 +0000 (09:16 +0000)]
Fix for 16 to 8-bit storage spirv_assembly tests
The output buffer was being made smaller than it was required to
hold all the results. Robust buffer accesss prevented the writes
from trampling memory after the buffer, but could mean that the
data in the valid part of the buffer was incorrectly written instead.
This change makes the output buffer large enough to prevent the
out-of-bounds writes.
Components: Vulkan
VK-GL-CTS issue: 4126
Affected tests:
dEQP-VK.spirv_assembly.instruction.graphics.8bit_storage.storagebuffer_int_16_to_8.*
Change-Id: I59145be8012f7a31037ee3fee4d7ac96a198bc00
James Fitzpatrick [Mon, 14 Nov 2022 09:51:50 +0000 (09:51 +0000)]
Enable VK_*_global_priority before using it
A number of tests were testing functionality from
VK_EXT_global_priority and VK_KHR_global_priority without first
enabling the extension.
Affects: dEQP-VK.api.device_init.create_device_global_priority*
Components: vulkan
VK-GL-CTS issue: 4107
Change-Id: Ib6fc36a8602f544b945fad2f5bfec3c2f8bcd72c
Matthew Netsch [Thu, 17 Nov 2022 18:07:49 +0000 (18:07 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: I7cc1f00c66d75b85505ee76301f437ba878e5683
Matthew Netsch [Thu, 17 Nov 2022 17:39:42 +0000 (17:39 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: Ifffbd3aecc8e2d066ed988ed8fc5af4210aa88da
ziga-lunarg [Fri, 4 Nov 2022 20:22:22 +0000 (21:22 +0100)]
Add missing check for rgba10x6 features
Feature formatRgba10x6WithoutYCbCrSampler must be supported if image is
created with format VK_FORMAT_R10x6G10X6B10X6A10X6_UNORM_4PACK16 and
level count is greater than 1
Components: Vulkan
VK-GL-CTS issue: 3992
Affected tests:
dEQP-VK.pipeline.image_view.view_type.*.format.*
Change-Id: I63f7d2083ea85d9f6232540d72178bd8172b13d5
Matthew Netsch [Thu, 17 Nov 2022 17:12:03 +0000 (17:12 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: I571894bfd5fc1ab88a09272d7452522bce76165d
Christopher Hambacher [Fri, 11 Nov 2022 20:17:58 +0000 (14:17 -0600)]
Fix failed memory map check for reconvergence tests
Tests are checking for ResourceError, when a failed memory map will return TestError.
Components: Vulkan
VK-GL-CTS issue: 4100
Affected tests:
dEQP-VK.reconvergence.*
Change-Id: I61fcc9f29fe19ff592b74986ac39a7e3958f06e8
Ricardo Garcia [Tue, 15 Nov 2022 15:07:16 +0000 (16:07 +0100)]
Limit number of concurrent query pools
The max concurrency tests use a heuristic to try to estimate a safe
number of objects of different types that the implementation would be
able to create, with an upper limit of 16384 objects.
However, in some implementations the creation of these objects have
external limitations that make the safe value hard to guess by only
looking at system and device memory usage. For example, the kernel
driver may impose further limits on the total number of certain objects.
This is reflected in the current tests with some lower hardcoded limits
for some types of objects, like instances, devices, synchronization
primitives and pipeline caches.
This commit halves the limit of concurrent query pools being tested to a
value that doesn't trigger any issue in the Mesa RPi drivers.
Affects:
dEQP-VK.api.object_management.max_concurrent.query_pool
VK-GL-CTS issue: 4106
Components: Vulkan
Change-Id: If88c6aa1ecd3d9c18892b38cb55907a82eee6cf8
ziga-lunarg [Sun, 16 Oct 2022 17:34:09 +0000 (19:34 +0200)]
Enable minLod feature when used
The tests use VkImageViewMinLoadCreateInfoEXT::minLod, but do not enable
the minLod feature
Components: Vulkan
VK-GL-CTS issue: 4052
Affected tests:
dEQP-VK.texture.mipmap.3d.image_view_min_lod.min_lod.*
Change-Id: I2bf99e7543d3ebb799d50ac5f644cc2e12d535e2
Matthew Netsch [Thu, 10 Nov 2022 19:08:10 +0000 (19:08 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: I1e2379907371708b4f3fb556938acb39f3f2f5bc
ziga-lunarg [Fri, 14 Oct 2022 21:03:32 +0000 (23:03 +0200)]
Fix wrong format in unused clear attachment tests
VkPipelineRenderingCreateInfo::depthAttachmentFormat must be a format
that includes a depth aspect or VK_FORMAT_UNDEFINED
VkPipelineRenderingCreateInfo::stencilAttachmentFormat must be a format
that includes a stencil aspect or VK_FORMAT_UNDEFINED
Components: Vulkan
VK-GL-CTS issue: 4041
Affected tests: dEQP-VK.dynamic_rendering.*.unused_clear_attachments.*
Change-Id: I8b003dd2a831e9205f6f91ea00c3ddf2541b512a
Matthew Netsch [Thu, 10 Nov 2022 18:39:54 +0000 (18:39 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: I9f9902ca38ce71e194a12f5aacff73afaaa37972
Ricardo Garcia [Fri, 21 Oct 2022 14:19:52 +0000 (16:19 +0200)]
Add missing checks for geometry shader support
Affects:
dEQP-VK.multiview.*geometry*
dEQP-VK.subgroups.*geometry*
dEQP-VK.fragment_shading_rate.*.gs*
VK-GL-CTS issue: 4064
Components: Vulkan
Change-Id: I64a3b6d7adc8da7671817710c4a4882db2c27035
ziga-lunarg [Sat, 15 Oct 2022 00:03:25 +0000 (02:03 +0200)]
Add missing read without format bit check in robustness tests
If buffer view is being read as storage texel buffer with image format
of OpTypeImage being Unknown then the view's buffer features must
contain VK_FORMAT_FEATURE_2_STORAGE_READ_WITHOUT_FORMAT_BIT
Components: Vulkan
VK-GL-CTS issue: 4047
Affected tests:
dEQP-VK.robustness.robustness2.bind.*
Change-Id: I46e5482fbfea3a945b133dbca0e020159049516f
ziga-lunarg [Fri, 14 Oct 2022 23:24:43 +0000 (01:24 +0200)]
Fix stencilAttachmentFormat in inverted depth ranges tests
If format is not VK_FORMAT_UNDEFINED in
VKPipelineRenderingCreateInfo::stencilAttachmentFormat then it must be a
format that includes a stencil aspect
Components: Vulkan
VK-GL-CTS issue: 4046
Affected tests:
dEQP-VK.draw.dynamic_rendering.inverted_depth_ranges.*
Change-Id: Ia0dcb1989b8ace78632d26dd0a1e3c1101f5f547
Matthew Netsch [Thu, 10 Nov 2022 18:12:22 +0000 (18:12 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: I46781852d8da0c1c3d65c9435cf93cd05ce1781b
ziga-lunarg [Sun, 16 Oct 2022 22:42:52 +0000 (00:42 +0200)]
Fix viewport width in FSR with multiviewport tests
Tests with extent 1x1 create viewport with width equal to 0.0f
Components: Vulkan
VK-GL-CTS issue: 4057
Affected tests:
dEQP-VK.fragment_shading_rate.*
Change-Id: I99a050348de83d1790320bd5d6d711722dd1fbaf
ziga-lunarg [Sat, 15 Oct 2022 19:51:22 +0000 (21:51 +0200)]
Fix image barrier oldLayout in timeline semaphore tests
Image layout in image barrier must be updated after first transition
Components: Vulkan
VK-GL-CTS issue: 4049
Affected tests:
dEQP-VK.synchronization.timeline_semaphore.one_to_n.*
Change-Id: I7fde2342007a3ec9c2562375fd634539e186acdc
ziga-lunarg [Sun, 16 Oct 2022 19:45:02 +0000 (21:45 +0200)]
Fix barrier in ray tracing pipeline build tests
If access mask is VK_ACCEDSS_ACCELERATION_STRUCTURE_WRITE_BIT_KHR then
stage must be VK_PIPELINE_STAGE_ACCELERATION_STRUCTURE_BUILD_BIT_KHR
Components: Vulkan
VK-GL-CTS issue: 4053
Affected tests:
dEQP-VK.ray_tracing_pipeline.build.*
Change-Id: I0a8080881f944319aae2417e5f9fe3297b933dd7
ziga-lunarg [Sun, 16 Oct 2022 01:50:25 +0000 (03:50 +0200)]
Fix pMutableDescriptorTypeLists in mutable descriptor tests
pMutableDescriptorTypeLists between srcBinding and dstBinding must match
exactly for copying descriptor sets
Components: Vulkan
VK-GL-CTS issue: 4051
Affected tests:
dEQP-VK.binding_model.mutable_descriptor.*
Change-Id: I64445e84ccd4872789a3db8b15e005d36c08d8a4
Hyunjun Ko [Fri, 21 Oct 2022 00:27:05 +0000 (09:27 +0900)]
Fix to reset dynamicDenstiyMap after dynamic subsampled tets done.
Affects:
dEQP-VK.*.fragment_density_map.*.static_nonsubsampled*
dEQP-VK.*.fragment_density_map.*.deferred_nonsubsampled*
VK-GL-CTS Issue: 4062
Components: Vulkan
Change-Id: Ib347bd6e4734b2928ccacfa17dd01dfc134301bb
ziga-lunarg [Fri, 14 Oct 2022 22:53:12 +0000 (00:53 +0200)]
Fix flush memory range in ssbo corner case tests
The size in VKMappedMemoryRange used in vkFlushMappedMemoryRanges must
either be a multiple of VkPhysicalDeviceLimits::nonCoherentAtomSize or
offset + size must be equal to the size of memory
Components: Vulkan
VK-GL-CTS issue: 4044
Affected tests:
dEQP-VK.ssbo.corner_case.*
Change-Id: I9ea2ee1e055b55ec39988a6ec0539cd3219937f4
ziga-lunarg [Fri, 14 Oct 2022 23:11:59 +0000 (01:11 +0200)]
Fix flush memory range in robustness vertex access tests
The size in VkMappedMemoryRange used in vkFlushMappedMemoryRanges must
either be a multiple of VkPhysicalDeviceLimits::nonCoherentAtomSize or
offset + size must be equal to the size of memory
Components: Vulkan
VK-GL-CTS issue: 4045
Affected tests:
dEQP-VK.robustness.vertex_access.r32_sint.draw.*
Change-Id: I3d0944b6c6808dc66de0c9dc25f6c4e99578a1cf
ziga-lunarg [Sat, 15 Oct 2022 22:05:50 +0000 (00:05 +0200)]
Add shader image atomic int64 extension if used when creating device
Add VK_EXT_shader_image_atomic_int64 extension and enabled the features
when creating the device in sparse resources tests if the extension
is used
Components: Vulkan
VK-GL-CTS issue: 4050
Affected tests:
dEQP-VK.sparse_resources.*
Change-Id: If3de1d1e30a57db076802e2933392081c7c3069c
ziga-lunarg [Fri, 14 Oct 2022 22:30:38 +0000 (00:30 +0200)]
Fix attachment description in explicit vertex parameter tests
If initialLayout is VK_IMAGE_LAYOUT_UNDEFINED then loadOp must not be
VK_ATTACHMENT_LOAD_OP_LOAD
Components: Vulkan
VK-GL-CTS issue: 4043
Affected tests:
dEQP-VK.draw.explicit_vertex_parameter.*
Change-Id: I94cd72967798d424081f13033d1afbb3e11d993b
ziga-lunarg [Wed, 21 Sep 2022 01:38:41 +0000 (03:38 +0200)]
Fix VK_KHR_global_priority tests
Support for priorities must be queries and if a priority is used but not
reported by VkQueueFamilyGlobalPriorityPropertiesKHR the driver must
fail with VK_ERROR_INITIALIZATION_FAILED
Components: Vulkan
VK-GL-CTS issue: 3898
Affected tests:
dEQP-VK.api.device_init.create_device_global_priority*
Change-Id: I5570006758e73522968a2399a2a4294588b2dde5
Matthew Netsch [Thu, 27 Oct 2022 18:07:00 +0000 (18:07 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: I96317661558490598f309c45bc9a6d040b937d13
Matthew Netsch [Thu, 27 Oct 2022 17:38:34 +0000 (17:38 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: I4b3c2c0c9e8185a634b8917faa9b67cd97469fe7
Matthew Netsch [Thu, 27 Oct 2022 17:10:48 +0000 (17:10 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: I398ca9776ea24153af3f5cc4bd4db4812333d76a
ziga-lunarg [Mon, 10 Oct 2022 22:39:37 +0000 (00:39 +0200)]
Fix loadOp in imageless framebuffer test
If initial layout in attachment descriptions is
VK_IMAGE_LAYOUT_UNDEFINED, then the load op must not be
VK_ATTACHMENT_LOAD_OP_LOAD
Components: Vulkan
VK-GL-CTS issue: 4030
Affected tests:
dEQP-VK.imageless_framebuffer.*
Change-Id: I5e7f3f5e440dd380a05cf82127af4bea2538fdd2
Tapani Pälli [Wed, 5 Oct 2022 16:59:48 +0000 (19:59 +0300)]
Choose optimal tiling with dmabuf in synchronization tests.
This is revert of commit
55027ea63. Problem is that while that change
caused coverage to raise on some drivers it decreased coverage on
others. Ideally this will be written in more dynamic way as a
follow-up work so that everyone could have coverage with these
tests.
Component: Vulkan
Affects: dEQP-VK.synchronization.cross_instance*
VK-GL-CTS issue: 2887
Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Change-Id: I252c87ccd1870067417166bf1a4ba769a153105f
ziga-lunarg [Sun, 16 Oct 2022 21:07:41 +0000 (23:07 +0200)]
Fix memory binding tests
Wrong size is used in results verification
Components: Vulkan
VK-GL-CTS issue: 4055
Affected tests:
dEQP-VK.memory.binding.*
Change-Id: I3325070d5173dfcc469b2d836616f79a0777d8e4
ziga-lunarg [Sun, 2 Oct 2022 19:45:08 +0000 (21:45 +0200)]
Fix cull distance tests without fragment shader read
These tests were supposed to test using gl_cullDistance but removing
those writes from shaders did not affect the tests passing
If fragment shader does not read cull distances the tests will now set a
cull plane and check the number of fragments culled
Components: Vulkan
VK-GL-CTS issue: 3502
Affected tests:
dEQP-VK.clipping.user_defined.clip_cull_distance.*
Change-Id: I5ea3d95cc14da934994db2b41aa22fa386570d70
Matthew Netsch [Fri, 14 Oct 2022 17:47:16 +0000 (17:47 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: Id2c911dc88c4169a9c800b4a1ff7d505bec9b74e
Matthew Netsch [Fri, 14 Oct 2022 17:47:09 +0000 (17:47 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: I2ea5abbe68202c09a290fad282bba0152514691b
Matthew Netsch [Fri, 14 Oct 2022 17:47:03 +0000 (17:47 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: Id224a630047cd512b36da121961684a9350ff731