Hyunjun Ko [Tue, 6 Sep 2022 05:36:05 +0000 (14:36 +0900)]
Fix to ensure that a particular image with that format can be sampled
via vkGetPhysicalDeviceImageFormatProperties.
Affects:
dEQP-VK.pipeline.*.attachment_feedback_loop_layout.*
VK-GL-CTS Issue: 3923
Components: Vulkan
Change-Id: I7a436e4650009a12f8abd561cb70132a11add951
Piotr Byszewski [Tue, 6 Sep 2022 10:43:39 +0000 (12:43 +0200)]
Interact FDM with imageless FB and secondary CB
Add test for interaction between VK_EXT_fragment_density_map,
VK_KHR_imageless_framebuffer and secondary command buffers
with continuation bit.
VK-GL-CTS issue: 3801
Components: Vulkan
Affects:
dEQP-VK.renderpass*.fragment_density_map.*
Change-Id: If3d2fcf5152ac5a46c1af8ee5f6451321a70badf
Piotr Byszewski [Fri, 2 Sep 2022 16:00:11 +0000 (18:00 +0200)]
Add test for pervertex correctness
Added test for VK_KHR_fragment_shader_barycentric that declares
a PerVertex varying at location 0 and another "normal" varying
at location 1 to make sure that:
1) the PerVertex decoration is only applied to location 0
2) the location 1 isn't compacted/remapped to location 0.
VK-GL-CTS issue: 3078
Components: Vulkan
Affects:
dEQP-VK.fragment_shading_barycentric.data.*
Change-Id: I389931e8b53d4bfc957810372c6afe1f4b6d71b8
Marcin Zając [Thu, 1 Sep 2022 10:13:31 +0000 (12:13 +0200)]
pipelineStageCreationFeedbackCount = 0 case
Coverage of VkPipelineCreationFeedbackCreateInfo
configuration with per stage feedback count
set to 0 which should cause per-stage information
to not being emitted
Components: Vulkan
VK-GL-CTS issue: 3736
New test:
dEQP-VK.pipeline.*.creation_feedback.graphics_tests.vertex_stage_fragment_stage_no_cache_zero_out_feedback_cout
Change-Id: Idf656c53bd09ec00bee70e6ff08ebd73a95aa7e0
Jarredhdavies [Fri, 3 Jun 2022 18:27:21 +0000 (19:27 +0100)]
Add tests for VK_EXT_pipeline_robustness
Components: Vulkan, Framework
New Tests: dEQP-VK.robustness.pipeline_robustness*
VK-GL-CTS Issue: 2757
Change-Id: I04a05e85a179b5718931ae37fb9ca249d85a4464
ziga-lunarg [Wed, 17 Aug 2022 00:21:48 +0000 (02:21 +0200)]
Add tests with dynamic states that discard all fragments
Make sure there are no changes in framebuffer attachments after
rendering with different dynamic states and discarding every fragment
Components: Vulkan
VK-GL-CTS issue: 3880
New Tests:
dEQP-VK.dynamic_state.*.discard.*
dEQP-VKSC.dynamic_state.*.discard.*
Change-Id: I2fc69ee7cd044f6429f4bff3ac91e89810e77d01
Chip Davis [Thu, 30 Jun 2022 00:34:45 +0000 (19:34 -0500)]
Use Mach semaphores on Darwin
Using named POSIX semaphores presents a problem: since they are visible
to other processes, they don't get cleaned up automatically when the
process dies. This causes problems down the line when the POSIX
semaphore namespace is filled up (macOS, by default, only allows 10000
POSIX semaphores to exist at once): creating new semaphores fails, and
thus we die with a null pointer reference when we try to use the
semaphore.
Mach semaphores have none of these problems. And no, I have no idea why
Apple doesn't just implement anonymous POSIX semaphores on top of Mach
semaphores. Maybe they thought it would be too hard to distinguish named
from unnamed semaphores?
Components: Framework
VK-GL-CTS public PR: 350
Change-Id: Id2b5a05b8afe96c5d9999417b0fcd1f96ddb7ba3
Marcin Zając [Fri, 9 Sep 2022 13:26:05 +0000 (15:26 +0200)]
robustness1_vertex_access for VKSC
Patch for testing robustBufferAccess in Vulkan SC mode
Components: Vulkan
VK-GL-CTS Issue: 3926
Affects:
dEQP-VK.robustness.robustness1_vertex_access.out_of_bounds_*
Change-Id: Id7786ecfdb9e3cec81939a99a437817ac22318ca
Piotr Byszewski [Fri, 9 Sep 2022 10:30:05 +0000 (12:30 +0200)]
Fix vkDeviceFeatures2.inl
While applying recent gen_framework changes (that generates
.inl files directly from vk.xml) some required changes in
writeDeviceFeatures2 were overlooked. This resulted in incorrect
recognition of promoted and partially promoted extensions.
This change fixes this.
VK-GL-CTS issue: 3928
Components: Framework, Vulkan
Affects:
dEQP-VK.api.info.get_physical_device_properties2.features.*
Change-Id: Ie9582a0584984b272cb89e5a4217aa58f0104233
Matthew Netsch [Fri, 16 Sep 2022 14:43:34 +0000 (14:43 +0000)]
Merge vk-gl-cts/opengl-cts-4.6.2 into vk-gl-cts/main
Change-Id: I240f056caf5a2e3e0037a27718077281a105f358
Matthew Netsch [Fri, 16 Sep 2022 14:15:20 +0000 (14:15 +0000)]
Merge vk-gl-cts/opengl-cts-4.6.1 into vk-gl-cts/opengl-cts-4.6.2
Change-Id: I840fb91ba7f6e91956f56b765dba16e2435d4162
Matthew Netsch [Thu, 15 Sep 2022 21:32:18 +0000 (21:32 +0000)]
Merge vk-gl-cts/opengl-es-cts-3.2.8 into vk-gl-cts/main
Change-Id: I359783cd885569b2d6eb6846760ee2d030657940
Matthew Netsch [Thu, 15 Sep 2022 21:04:18 +0000 (21:04 +0000)]
Merge vk-gl-cts/opengl-es-cts-3.2.7 into vk-gl-cts/opengl-es-cts-3.2.8
Change-Id: I583b180f82fbb1c9af9a0ddec49f94c84785dc1f
Matthew Netsch [Thu, 15 Sep 2022 20:35:37 +0000 (20:35 +0000)]
Merge vk-gl-cts/opengl-es-cts-3.2.6 into vk-gl-cts/opengl-es-cts-3.2.7
Change-Id: Ie5909532e6b5af30e4e28702a5731ab3b7b4d0a3
Peter Kasting [Thu, 8 Sep 2022 19:00:54 +0000 (19:00 +0000)]
Fix build in C++20 mode.
* Compound assignments to volatiles are deprecated. Use non-compound
forms.
* Math between disparate enums is deprecated. Use constexprs.
* The full definition of a type T must be visible for code that
instantiates std::vector<T>. Reorder code to guarantee this.
Components: Framework
Bug: chromium:1284275
Change-Id: I75a99b5c09cc911f2312aabe85f49aadff84dc51
Peter Kasting [Thu, 8 Sep 2022 19:00:54 +0000 (19:00 +0000)]
Fix build in C++20 mode.
* Compound assignments to volatiles are deprecated. Use non-compound
forms.
* Math between disparate enums is deprecated. Use constexprs.
* The full definition of a type T must be visible for code that
instantiates std::vector<T>. Reorder code to guarantee this.
Components: Framework
Bug: chromium:1284275
Change-Id: I75a99b5c09cc911f2312aabe85f49aadff84dc51
Matthew Netsch [Mon, 12 Sep 2022 15:09:42 +0000 (15:09 +0000)]
Merge "Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/main" into main
Matthew Netsch [Fri, 9 Sep 2022 18:52:44 +0000 (18:52 +0000)]
Merge vk-gl-cts/vulkansc-cts-1.0.1 into vk-gl-cts/main
Change-Id: Ic6be7702f895e29e162fb975ef280af57ccdabe4
Tom Malnar [Wed, 24 Aug 2022 18:30:15 +0000 (14:30 -0400)]
VKSC low-memory implementations require lower semaphore count for chain test.
Components: Vulkan SC
VK-GL-CTS issue: 3903
Affects:
dEQP-VKSC.synchronization.basic.binary_semaphore.chain
Change-Id: Ic64f23ee2ee7f770d8b5db3d39deb79a394796ac
Matthew Netsch [Fri, 9 Sep 2022 18:49:30 +0000 (11:49 -0700)]
Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/main
Change-Id: I44edd12c04383ff54403341843b3a24335bf96e4
Matthew Netsch [Wed, 17 Aug 2022 19:32:00 +0000 (19:32 +0000)]
Reintroduce tests for VK_EXT_color_write_enable extension
Adding tests back in to enable coverage for this feature
VK-GL-CTS Issue: 3759
Components: Vulkan
Affects:
dEQP-VK.pipeline.*.color_write_enable_maxa.cwe_after_bind.*
dEQP-VK.pipeline.*.color_write_enable_maxa.cwe_before_bind.*
Change-Id: Ia43d495097038272df407ac633a05ce729af3ea3
Matthew Netsch [Fri, 9 Sep 2022 17:27:30 +0000 (17:27 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3
Change-Id: I590325438900e9a2d08d5abe584d63a50a0781f7
ziga-lunarg [Sun, 21 Aug 2022 00:22:18 +0000 (02:22 +0200)]
Fix dynamic rendering tests using queries with multiview
If queries are used in a render pass instance with multiview enabled
then the query uses N consecutive query indices
Components: Vulkan
VK-GL-CTS issue: 3877
Affected tests:
dEQP-VK.dynamic_rendering*random.seed*
Change-Id: I884b30f7e1be470c0515a6783dbfe1771f1a3ba0
Juha Heiskanen [Tue, 19 Apr 2022 13:15:10 +0000 (16:15 +0300)]
Test per-stage descriptor limits
Add tests to verify that per-stage descriptor limit support works as
advertised.
Components: Vulkan
VK-GL-CTS Issue: 3470
New tests: dEQP-VK.pipeline.*.descriptor_limits.*
Change-Id: I89164d5fbf5382ff4a63410541b6f68efb5c9ad4
John Bauman [Mon, 29 Aug 2022 16:35:49 +0000 (16:35 +0000)]
Tests for VK_FUCHSIA_external_*
New tests:
dEQP-VK.api.external.semaphore.zircon_event.*
dEQP-VK.api.external.memory.*
dEQP-VK.synchronization.cross_instance.*_zircon_handle
dEQP-VK.synchronization2.cross_instance.*_zircon_handle
Components: Vulkan
VK-GL-CTS issue: 3911
Change-Id: I6c8e61d61f2c0dd380f01711ce7886aa6e3b60df
Graeme Leese [Tue, 30 Aug 2022 13:32:50 +0000 (14:32 +0100)]
Test barriers in conditional control flow
Barriers in compute shaders are allowed to be within uniform control
flow, but there were no tests with any barriers in selection constructs.
Add a test.
Uniform control flow for barriers is only required when the barrier is
actually executed (see cross-api/memory-model#116), so the test uses a
mix of uniform and non-uniform selections whilst ensuring that the
barrier is only executed in uniform control flow.
Components: Vulkan
New Test: dEQP-VK.compute.basic.branch_past_barrier
Change-Id: Ic4fbf95f2d903724aa0e564ebc2c3adca982b6da
Aitor Camacho [Tue, 9 Aug 2022 21:05:18 +0000 (23:05 +0200)]
Extend tests for depth parameter of OpTypeImage
Add tests for depth parameter of OpTypeImage for compute pipeline.
All existing tests will now have 3 variations with depth property
being 0, 1 and 2. Modified name will be same as previous with
'depth.value' added to it.
Extend graphics pipeline tests to correctly generate all tests
for depth parameter of OpTypeImage. Existing tests will be replaced
by tests with similar name with 'depth.value' added to it.
Removed tests:
dEQP-VK.spirv_assembly.instruction.graphics.image_sampler.depth_property.*
New tests:
dEQP-VK.spirv_assembly.instruction.graphics.image_sampler.*
dEQP-VK.spirv_assembly.instruction.compute.image_sampler.*
Components: Vulkan
VK-GL-CTS issue: 3603
Change-Id: I396e767de14381867c2cb042c2b94b985c80190b
Matthew Netsch [Fri, 9 Sep 2022 16:17:26 +0000 (16:17 +0000)]
Merge vk-gl-cts/opengl-cts-4.6.2 into vk-gl-cts/main
Change-Id: Id9b9246a43eaada1ac75f94980627dd536f5ce5f
Matthew Netsch [Fri, 9 Sep 2022 15:49:35 +0000 (15:49 +0000)]
Merge vk-gl-cts/opengl-cts-4.6.1 into vk-gl-cts/opengl-cts-4.6.2
Change-Id: I4c597cb9671bc4a7893d4d921dbaf4bfb42843e0
Matthew Netsch [Thu, 8 Sep 2022 21:06:26 +0000 (14:06 -0700)]
Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2
Change-Id: Ib404387348df248f2a0a6e50f22813bf004c4935
Matthew Netsch [Thu, 8 Sep 2022 17:57:21 +0000 (17:57 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: I5a2183d155a48675e5ef2edc90f4323fe59a9032
Matthew Netsch [Thu, 8 Sep 2022 17:30:18 +0000 (17:30 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: Id151a00583138c75f0ef53f559a3465dabcfdf6e
Matthew Netsch [Thu, 8 Sep 2022 17:03:16 +0000 (17:03 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: I58b46f7b755b5f731d3865d16b2e248eb0653501
Matthew Netsch [Thu, 8 Sep 2022 16:36:32 +0000 (16:36 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7
Change-Id: Idcb4f9a2cb008e61fcfcd45aaed0e31be4cf8e1b
Hyunjun Ko [Fri, 2 Sep 2022 05:27:33 +0000 (14:27 +0900)]
Fix wrong calculation to check diff between floats.
Affects:
dEQP-VK.spirv_assembly.instruction.graphics.variable_pointers.graphics.*
Components: Vulkan
VK-GL-CTS issue: 3916
Change-Id: I05d2b7375c0bd34b6b7fffabbfe52969009ea218
Chad Versace [Thu, 25 Aug 2022 20:27:53 +0000 (13:27 -0700)]
VK_EXT_pipeline_creation_feedback: Invalid feedback is legal
The tests incorrectly required that
VK_PIPELINE_CREATION_FEEDBACK_VALID_BIT be set in
VkPipelineCreationFeedbackCreateInfo::pPipelineCreationFeedback.
However, the tests already and correctly permit the bit to be unset in
VkPipelineCreationFeedbackCreateInfo::pPipelineStageCreationFeedbacks.
The Vulkan 1.3.225 spec says:
An implementation should write pipeline creation feedback to
pPipelineCreationFeedback and may write pipeline stage creation
feedback to pPipelineStageCreationFeedbacks. An implementation must
set or clear the VK_PIPELINE_CREATION_FEEDBACK_VALID_BIT in
VkPipelineCreationFeedback::flags for pPipelineCreationFeedback and
every element of pPipelineStageCreationFeedbacks.
Components: Vulkan
VK-GL-CTS Issue: 3912
Affects:
dEQP-VK.pipeline.creation_feedback.*
Signed-off-by: Chad Versace <chadversary@google.com>
Change-Id: I4eb37b5888a4d780b4b0b12f9c65960aca9f7806
Andreas Flöjt [Tue, 14 Jun 2022 13:07:46 +0000 (15:07 +0200)]
Stay within the minimum required limit for maxUniformBufferRange
The biggest one was i64vec4 which consumed 128kB. Now it fits within the
16384 byte minimum supported buffer range.
Affects:
dEQP-VK.robustness.buffer_access.vertex.*
dEQP-VK.robustness.buffer_access.fragment.*
dEQP-VK.robustness.buffer_access.compute.*
Components: Vulkan
VK-GL-CTS issue: 3776
Change-Id: Ib71dce12a346bce79a9b719e227cd6ddfb0d64b6
Mohd Faisal [Wed, 10 Aug 2022 14:04:04 +0000 (15:04 +0100)]
Added missing android hardware buffer formats
Android hardware buffer formats are added in image compression
control test. Also, updated the test names.
Components: Vulkan
VK-GL-CTS issue: 3883
Affects:
dEQP-VK.api.image_compression_control.android_hardware_buffer.*
Change-Id: I39643d186200d63a81cff2eb244bbdf085954a03
Mika Väinölä [Tue, 24 May 2022 10:09:47 +0000 (13:09 +0300)]
Test PGQ with disabled color output
Add variants with empty fragment shaders, attachmentless render
passes and VK_EXT_color_write_enable with and without depth stencil
attachments to the same subgroup as the existing rasterizer discard
tests.
New tests:
dEQP-VK.transform_feedback.primitives_generated_query.*.empty_frag.*
dEQP-VK.transform_feedback.primitives_generated_query.*.no_attachment.*
dEQP-VK.transform_feedback.primitives_generated_query.*.color_write_disable_*
Affects:
dEQP-VK.transform_feedback.primitives_generated_query.*
Components: Vulkan
VK-GL-CTS issue: 2739
Change-Id: If1b6077290fddfcae704f4d0af14b82d0dde6d98
Matthew Netsch [Thu, 8 Sep 2022 13:51:47 +0000 (13:51 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/main
Change-Id: I14e9d2f875ed566f4622dd347ecddd51856faea0
Matthew Netsch [Wed, 7 Sep 2022 17:01:51 +0000 (10:01 -0700)]
Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3
Change-Id: I46fc9aef51fa742fdaf5159861d3f9f68326cf3d
Matthew Netsch [Tue, 6 Sep 2022 19:25:57 +0000 (12:25 -0700)]
Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2
Change-Id: Iaf496a1c9317287562c43d586010ee9cbc744bc8
Matthew Netsch [Tue, 6 Sep 2022 16:36:08 +0000 (09:36 -0700)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: Ib963ea274243454803090094d0ac61136ab8e998
Matthew Netsch [Fri, 2 Sep 2022 23:55:34 +0000 (23:55 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: Ibfc38c618b170dc12bcd04c2db36ed3e0e3b386a
Matthew Netsch [Fri, 2 Sep 2022 23:26:36 +0000 (23:26 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: If2412675c25225c696d61dec802d76ed8001180e
Sławomir Cygan [Mon, 22 Aug 2022 12:52:59 +0000 (14:52 +0200)]
Fix unsupported condition in memory requirements test
This fixes parantheses to not require VK_KHR_sampler_ycbcr_conversion
extension for non-YCbCr formats
VK-GL-CTS Issue: 3902
Affects: dEQP-VK.memory.requirements.*
Components: Vulkan
Change-Id: I17c58fb1f085e7d32dea9aceb2b9e421990499a5
Piotr Byszewski [Thu, 21 Jul 2022 10:23:03 +0000 (12:23 +0200)]
Fix device_memory_report test
allocation_failed test for VK_EXT_device_memory_report attempts to
allocate UINT64_MAX bytes of memory in order to deliberately trigger
an allocation failure. However, vkAllocateMemory also has VU in which
allocationSize must be less than or equal to
VkPhysicalDeviceMemoryProperties::memoryHeaps[memindex].size .
VK-GL-CTS issue: 3775
Components: Vulkan
Affects:
dEQP-VK.memory.device_memory_report.vk_device_memory.allocation_failed
Change-Id: I0b9db1beb1e7b01d369d5ee6bbfb93c2eb3e1c97
Marcin Kańtoch [Tue, 26 Jul 2022 15:25:41 +0000 (17:25 +0200)]
Fix undefined behaviour by allowing NaNs
One graphicsfuzz test contains computations with the float constant 0x1.8p+128.
This constant represents a NaN value. The computation with undef in the test
allows any optimization/triggers undefined behavior and the driver is free
to crash. Adding OpExecutionMode %4 SignedZeroInfNanPreserve 32 to the CTS fixes
this by allowing NaNs.
Affects:
dEQP-VK.graphicsfuzz.cov-instruction-simplify-atanh-log-undefined
Components: Vulkan
VK-GL-CTS issue: 3787
Change-Id: I2442bc4f50add8b8f779dbfae3c5fe2be8fd85f4
Matthew Netsch [Thu, 1 Sep 2022 23:48:42 +0000 (16:48 -0700)]
Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7
Change-Id: Id9e93b66b2242c3b789e5742b84432c1ba8b355e
Aitor Camacho [Tue, 30 Aug 2022 15:40:50 +0000 (17:40 +0200)]
Remove non-compliant event wait test
Removed tests:
dEQP-VK.api.command_buffers.record_simul_use_primary
dEQP-VK.api.command_buffers.record_simul_use_secondary
Components: Vulkan
VK-GL-CTS issue: 3432
Change-Id: I297b53dcee56bec69e3abd3693639f64e462a574
Ilkka Saarelainen [Thu, 2 Dec 2021 05:45:44 +0000 (07:45 +0200)]
Rework platform memory limits
Some OpenGL tests in openglcts and kc_cts used Vulkan platform class to
get the available system / device memory. The memory limits are not
Vulkan related.
This CL moves the getMemoryLimits function to the base class of all
platforms, so the functions can be accessed from openglcts without
referencing any Vulkan files.
Affects:
dEQP-VK.info.memory_limits
dEQP-VK.api.buffer.suballocation.*
dEQP-VK.api.buffer.dedicated_alloc.*
dEQP-VK.api.object_management.*
dEQP-VK.memory.allocation.*
dEQP-VK.memory.device_group_allocation.*
dEQP-VK.pipeline.render_to_image.*.small.*
dEQP-VK.pipeline.render_to_image.*.huge.*
KHR-GL4*.shader_image_load_store.advanced-*
Components:
Vulkan, OpenGL, Framework
VK-GL-CTS issue: 3360
Change-Id: I0743a83148c946d962fd793c8771f2c3c2e33ecc
ziga-lunarg [Tue, 23 Aug 2022 13:48:06 +0000 (15:48 +0200)]
Update structs and enums that were renamed in the latest spec
Some structs and enums for the video extensions were renamed
Components: Vulkan
VK-GL-CTS issue: 3905
Affected tests:
dEQP-VK.api.buffer_memory_requirements.*
dEQP-VK.api.info.get_physical_device_properties2.features.rasterization_order_attachment_access_features_ext
dEQP-VK.api.info.get_physical_device_properties2.features.amigo_profiling_features_sec
dEQP-VK.api.info.get_physical_device_properties2.features.attachment_feedback_loop_layout_features_ext
dEQP-VK.api.device_init.create_device_unsupported_features.rasterization_order_attachment_access_features_ext
dEQP-VK.api.device_init.create_device_unsupported_features.amigo_profiling_features_sec
dEQP-VK.api.device_init.create_device_unsupported_features.attachment_feedback_loop_layout_features_ext
Change-Id: Ic2e4767d1c712345d19f8c2aa890d2c2fffe3993
Chad Versace [Thu, 25 Aug 2022 22:19:54 +0000 (15:19 -0700)]
VK_EXT_pipeline_creation_feedback: Add indentation
No change in behavior.
Add an indentation level to some code. This prepares for the next
commit, making its diff understandable.
Components: Vulkan
Change-Id: I31e5f706ca6f05b42682a862c740bc4953a91f9b
Matthew Netsch [Mon, 29 Aug 2022 16:00:45 +0000 (16:00 +0000)]
Merge "Merge vk-gl-cts/opengl-es-cts-3.2.8 into vk-gl-cts/main" into main
Aitor Camacho [Thu, 4 Aug 2022 13:13:16 +0000 (15:13 +0200)]
Add dynamic rendering test for mixed inside/outside render pass commands
New test:
dEQP-VK.dynamic_rendering.basic.secondary_cmdbuffer_out_of_rendering_commands
Components: Vulkan
VK-GL-CTS issue: 3394
Change-Id: Iafebdeab6e365e376be0cf0a85af46b94836b6ca
Arkadiusz Sarwa [Thu, 4 Nov 2021 13:57:40 +0000 (14:57 +0100)]
Tests for AMD_shader_early_and_late_fragment_tests
New tests:
dEQP-VK.fragment_operations.early_fragment.*early_and_late*
dEQP-VK.fragment_shading_rate.*.fragdepth_early_late.*
dEQP-VK.fragment_shading_rate.*.fragstencil_early_late.*
dEQP-VK.pipeline.*.op_replace_early_and_late
dEQP-VK.spirv_assembly.instruction.graphics.early_and_late_fragment.*
dEQP-VK.fragment_operations.early_fragment.*early_and_late*
Affected:
dEQP-VK.fragment_operations.early_fragment.*
dEQP-VK.fragment_shading_rate.*
dEQP-VK.pipeline.fast_linked_library.shader_stencil_export.*
dEQP-VK.pipeline.monolithic.shader_stencil_export.*
dEQP-VK.pipeline.pipeline_library.shader_stencil_export.*
dEQP-VK.spirv_assembly.instruction.graphics.*
dEQP-VK.fragment_operations.early_fragment.*
Components: Vulkan
VK-GL-CTS issue: 3866
Change-Id: I279310ed8be42c3a6cd4ed83febcb6a404752a1a
Matthew Netsch [Mon, 29 Aug 2022 15:10:22 +0000 (08:10 -0700)]
Merge vk-gl-cts/opengl-es-cts-3.2.8 into vk-gl-cts/main
Change-Id: I32263338d6ff1c7c9da96a1ed44cb418fbb27ada
Matthew Netsch [Fri, 26 Aug 2022 16:56:32 +0000 (09:56 -0700)]
Merge vk-gl-cts/opengl-es-cts-3.2.7 into vk-gl-cts/opengl-es-cts-3.2.8
Change-Id: Ib61101e1c720a4f28429af20dba9554ad03dd94e
Matthew Netsch [Fri, 26 Aug 2022 15:40:40 +0000 (15:40 +0000)]
Merge "Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/main" into main
Matthew Netsch [Fri, 26 Aug 2022 15:23:22 +0000 (08:23 -0700)]
Merge vk-gl-cts/opengl-es-cts-3.2.6 into vk-gl-cts/opengl-es-cts-3.2.7
Change-Id: Ia00eca74b753f1f88ac794c6d3664a769cfc2c6f
ziga-lunarg [Mon, 25 Jul 2022 15:14:31 +0000 (17:14 +0200)]
Fix triangle strip adjacency tests vertex ordering
OpenGL got an update where the ordering of vertices captured
by transform feedback when GL_TRIANGLE_STRIP_ADJACENCY is used
can either match the old OpenGL ordering or the new Vulkan ordering
Components: OpenGL
VK-GL-CTS issue: 3671
Affected tests:
KHR-GLES31.core.geometry_shader.*
KHR-GLES32.core.geometry_shader.*
Change-Id: I7f75b357593429110cc4517d0852b5cf2f7bb8db
Piotr Byszewski [Tue, 23 Aug 2022 11:18:48 +0000 (13:18 +0200)]
Fix enabling of partially promoted extensions
Recent framework change that generates .inl files
directly from vk.xml introduced an error in which
partially promoted extensions were added to core
device extensions list. This resulted in not
enabling those extensions which lead to failure of
some tests. This change fixed this.
VK-GL-CTS issue: 3892
Components: Framework, Vulkan
Affects:
dEQP-VK.pipeline.monolithic.extended_dynamic_state.*.logic_op_or
dEQP-VK.*
Change-Id: Ieb6b9e2d469be14d30ecd86b4b112655c82e297c
Piotr Byszewski [Wed, 24 Aug 2022 14:07:12 +0000 (16:07 +0200)]
Fix subpassMergeFeedback mandatory feature check
While checking subpassMergeFeedback mandatory feature test
checked presence of VK_KHR_create_renderpass2 instead of
VK_EXT_subpass_merge_feedback.
VK-GL-CTS issue: 3879
Components: Framework, Vulkan
Affects:
dEQP-VK.info.device_mandatory_features
Change-Id: Idaeb522c1bda0e07a4a0286d59ded7ca51b1c6cb
Piotr Byszewski [Tue, 23 Aug 2022 14:44:05 +0000 (16:44 +0200)]
Fix aliases of aliases
Recent framework change that generates .inl files directly from
vk.xml introduced an error in which aliases of aliases were missing
from vkBasicTypes.inl. This change fixed this.
VK-GL-CTS issue: 3875
Components: Framework, Vulkan
Affects:
dEQP-VK.*
Change-Id: I98fbe520d9f611077254454721732a6142efaf06
Marcin Zając [Thu, 7 Jul 2022 11:17:33 +0000 (13:17 +0200)]
Depth and stencil clears in dynamic rendering
Exposure of cleaning values for depth and stencil
attachments. Different values are to ensure
that corresponding attachments are using dedicated
clearing values
Components: Vulkan
VK-GL-CTS issue: 3695
Affects:
dEQP-VK.dynamic_rendering.basic.*
Change-Id: I9b833b2fa2e6e5468b63b8e1d3cd51bafbc8d709
John Anthony [Thu, 18 Aug 2022 12:31:03 +0000 (14:31 +0200)]
Add support for VK_EXT_rasterization_order_attachment_access
Modify existing tests for VK_ARM_rasterization_order_attachment_access
to also run if only the EXT version of the extension is supported.
Affected tests:
dEQP-VK.rasterization.rasterization_order_attachment_access.*
Components: Vulkan
Change-Id: Ia5ad0ee82c7a2aa8fa9681a3ba0a34f6e3818059
Piotr Byszewski [Wed, 27 Jul 2022 15:36:26 +0000 (17:36 +0200)]
Test clears of 3D depth/stencil images
Existing clear tests checked only 2D depth/stencil images.
This change extend these tests to exercise also 3D depth/stencil
clears. It also adds missing barrier that was reported by layers.
Components: Vulkan
VK-GL-CTS issue: 3693
Affects:
dEQP-VK.api.image_clearing.*
Change-Id: Ia84c2ef8de49f3e0db1ace2e7a59450e4d5c2202
Piers Daniell [Mon, 6 Jun 2022 23:31:55 +0000 (17:31 -0600)]
Use multi-level multi-layer compressed image views
This test verifies whether implementations can handle multi-layer and multi-level
compressed image views of compressed images created with
VK_IMAGE_CREATE_BLOCK_TEXEL_VIEW_COMPATIBLE_BIT.
Currently the specification states:
https://www.khronos.org/registry/vulkan/specs/1.3/html/vkspec.html#VUID-VkImageViewCreateInfo-image-01584
If image was created with the VK_IMAGE_CREATE_BLOCK_TEXEL_VIEW_COMPATIBLE_BIT flag,
the levelCount and layerCount members of subresourceRange must both be 1
The proposal is to only require levelCount and layerCount to be 1 when the view
uses an uncompressed format:
https://gitlab.khronos.org/vulkan/vulkan/-/merge_requests/5149
Affects:
dEQP-VK.image.texel_view_compatible.*
Components: Vulkan
VK-GL-CTS issue: 3749
Change-Id: I6a7cc858f4464b07fbc216547e53c961e130dd2c
Piers Daniell [Fri, 15 Jul 2022 15:44:05 +0000 (09:44 -0600)]
Reenable texel_view_compatible 3d_image tests
These tests are disabled because they violate VUID-VkImageViewCreateInfo-image-04739.
This was removed from the spec.
See https://gitlab.khronos.org/vulkan/vulkan/-/issues/3164 for the spec issue.
Affects:
dEQP-VK.image.texel_view_compatible.*.3d_image.*
dEQP-VKSC.image.texel_view_compatible.*.3d_image.*
Components: Vulkan
VK-GL-CTS issue: 3835
Change-Id: Id513c29dd9b042d498dd0a12ca2f5d3b6257b705
Matthew Netsch [Thu, 25 Aug 2022 21:02:37 +0000 (21:02 +0000)]
Merge vk-gl-cts/vulkansc-cts-1.0.1 into vk-gl-cts/main
Change-Id: Ife4384ed5b6c254cd4e72cc425549624f34f261d
Stanley Tang [Mon, 25 Jul 2022 17:00:09 +0000 (17:00 +0000)]
Add CTS tests for VK_EXT_application_parameters
New tests:
dEQP-VKSC.sc.application_parameters.*
New command-line option:
--deqp-app-params-input-file=<path>
Components: Vulkan SC, Framework
VK-GL-CTS issue: 3850
Change-Id: I19807696fd3c7fccab3b7f719474c8cfaf62f766
Matthew Netsch [Thu, 25 Aug 2022 21:01:33 +0000 (14:01 -0700)]
Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/main
Change-Id: Ie46b51dc959d6a3c5c73e61b9698dec7dc921f5d
Matthew Netsch [Thu, 25 Aug 2022 18:54:32 +0000 (18:54 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3
Change-Id: I80a5e97d6ee8d7d15c8d67de7f084f7f3fd239e0
Matthew Netsch [Thu, 25 Aug 2022 18:23:24 +0000 (18:23 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2
Change-Id: I3dcb14db985ef75cff08dae8e346cefd7a27ff19
Matthew Netsch [Wed, 10 Aug 2022 16:29:24 +0000 (09:29 -0700)]
Adds reset watchdog timer to timeline sempahore tests
Tests go through many iterations which exceeds test
max time when matchdog timer is enabled
Components: Vulkan
VK-GL-CTS Issue: 3884
Affects:
dEQP-VK.synchronization*.basic.timeline_semaphore.chain
Change-Id: Id257b7162d49cfaf5b78c198cdc932f74c0d4a2b
Matthew Netsch [Thu, 25 Aug 2022 17:58:42 +0000 (17:58 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: I1be609e78cf12d03a7db1430364c332ec1ac37ae
Matthew Netsch [Thu, 25 Aug 2022 17:31:45 +0000 (17:31 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: If088fd987f51bff07712612cfc9672f1cddd1df6
Matthew Netsch [Thu, 25 Aug 2022 17:04:58 +0000 (17:04 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: I17c7fc7a6c0dde2555e90873105027b0f26e94ad
Matthew Netsch [Thu, 25 Aug 2022 16:37:33 +0000 (16:37 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7
Change-Id: Ia1e9c64b9149680d40e6c2deff9e64725c227439
Hyunjun Ko [Mon, 22 Aug 2022 06:55:24 +0000 (15:55 +0900)]
Improve the error message when storing uncomressed images fails.
It's been ambiguous since the output doesn't have any information when
storing an uncompressed image fails.
Affects:
dEQP-VK.image.texel_view_compatible.compute.basic.*
Components: Vulkan
VK-GL-CTS issue: 3897
Change-Id: I923efb15a9927c87c581dc3c96115b5d6c0b2580
Graeme Leese [Thu, 18 Aug 2022 14:33:53 +0000 (15:33 +0100)]
Fix loop continue construct for SPIR-V assembly
The multi-block continue construct tests were setting the continue
target to the loop header itself, which is not valid according to the
new structural dominance rules. Set it to the first block inside the
loop instead, which still gives a multi-block continue construct but
also follows the validation rules.
Components: Vulkan
VK-GL-CTS issue: 3896
Affects:
dEQP-VK.spirv_assembly.instruction.graphics.loop.multi_block_continue_construct_*
Change-Id: I7480f6107696ec8587625bfa110aa7478308512f
Graeme Leese [Thu, 18 Aug 2022 11:36:28 +0000 (12:36 +0100)]
Fix SPIRV validation for decoration tests
The decoration matching tests were incorrectly using Flat and
NoPerspective decoration on vertex inputs. The validator has been
updated to catch these errors, so the tests now cause an InternalError.
Compoennts: Vulkan
VK-GL-CTS issue: 3895
Affects: dEQP-VK.spirv_assembly.instruction.graphics.cross_stage.basic_type.flat
dEQP-VK.spirv_assembly.instruction.graphics.cross_stage.basic_type.no_perspective
dEQP-VK.spirv_assembly.instruction.graphics.cross_stage.interface_blocks.flat
dEQP-VK.spirv_assembly.instruction.graphics.cross_stage.interface_blocks.no_perspective
Change-Id: I818868ca87d15d068430e9721204be620b28e225
WenkeZh [Thu, 11 Aug 2022 03:08:53 +0000 (11:08 +0800)]
Fixes arrays of arrays tests
Tests were requiring more ssbos in shaders
than what the implementation supports
VK-GL-CTS Public Issue: 324
Components: OpenGL
Affects either:
KHR-GL46.arrays_of_arrays_gl.InteractionInterfaceArrays1
or
KHR-Single-GL46.arrays_of_arrays_gl.InteractionInterfaceArrays1
depending on branch.
Change-Id: I8664e7b85ff78b93aeb52c4e0739a4cc3c14e6aa
Piotr Byszewski [Mon, 11 Apr 2022 11:21:27 +0000 (13:21 +0200)]
Run DR tests with secondary command buffers
dynamic_rendering tests were replaced with three sub groups:
primary_cmd_buff, partial_secondary_cmd_buff and
complete_secondary_cmd_buff.
* primary_cmd_buff subgroup contains previously existing dynamic
rendering tests where drawing is done in primary command buffer.
* partial_secondary_cmd_buff contains tests where drawing commands
are recorded in secondary command buffer but begin/endRendering
are recorded to primary command buffer.
* complete_secondary_cmd_buff executes tests using secondaries that
completely contain the dynamic render pass.
Components: Vulkan
VK-GL-CTS issue: 3516
Affects:
dEQP-VK.dynamic_rendering.*
dEQP-VK.renderpass*
Change-Id: Id640e0fb8f6e9382d48844d3cdee4a7e040eb609
Antto Mäkinen [Fri, 17 Jun 2022 10:52:15 +0000 (13:52 +0300)]
Fix division by zero in glsBuiltinPrecisionTests
GLSL precision tests were using 1 / InverseSqrt(x) to calculate
reference values for square root. This is problematic when x = 0,
as it causes a division by zero.
VK-GL-CTS Issue: 3330
Affects:
dEQP-GLES3*.functional.shaders.builtin_functions.precision.*
Components: OpenGL ES
Change-Id: I199f16b2eeb66ab042f0bb1ab6b588246efeb6d5
Matthew Netsch [Wed, 24 Aug 2022 19:52:18 +0000 (12:52 -0700)]
Merge vk-gl-cts/dev/VK_EXT_attachment_feedback_loop_layout into vk-gl-cts/main
Change-Id: Ic7fcede2a0f71c344a41e76cbb1e9cd68301dfb8
Matthew Netsch [Wed, 24 Aug 2022 18:06:37 +0000 (11:06 -0700)]
Merge vk-gl-cts/main into vk-gl-cts/dev/VK_EXT_attachment_feedback_loop_layout
Change-Id: Ieb2f535a96807e0d1fcd8ca6a84cac46651fc8f3
Arkadiusz Sarwa [Tue, 23 Aug 2022 15:08:55 +0000 (17:08 +0200)]
Fix barrier VK_AMD_buffer_marker
Affected tests:
dEQP-VK.api.buffer_marker.*
Components: Vulkan
VK-GL-CTS issue: 3854
Change-Id: Ia65c7ec44db3019125012b7d7e2d1b65e0f942f6
Mika Väinölä [Mon, 26 Oct 2020 21:19:59 +0000 (23:19 +0200)]
Update Amber to fix Clang 11 build
Building Amber with Clang 11 failed due to -Werror and several
-Wsuggest-destructor-override warnings.
Affects: dEQP-VK.*
VK-GL-CTS issue: 2628
Change-Id: Ibae8dbc955d32bb50eb6f5c26cd62579bc6967dd
Alexander Galazin [Wed, 16 Sep 2020 07:12:43 +0000 (09:12 +0200)]
Update Amber
Components: Framework
Affects: dEQP-VK.*
Change-Id: I0bb5016b2ec063396cd797060e14d6de474b96af
Paul Thomson [Mon, 20 Jul 2020 15:00:08 +0000 (16:00 +0100)]
Update Amber to fix regression
Affects:
dEQP-VK.glsl.combined_operations.*
dEQP-VK.compute.basic.write_ssbo_array
dEQP-VK.draw.output_location.array.*
dEQP-VK.graphicsfuzz.*
dEQP-VK.pipeline.vertex_only.position_to_ssbo
dEQP-VK.rasterization.provoking_vertex.*
dEQP-VK.rasterization.line_continuity.*
dEQP-VK.spirv_assembly.*
dEQP-VK.texture.conversion.*
dEQP-VK.texture.multisample.*
dEQP-VK.texture.subgroup_lod.*
dEQP-VK.texture.texel_buffer.*
Components: Vulkan
VK-GL-CTS issue: 2443
Change-Id: I3c6ec1eb0ee8695468c54f95c210cc81b50a4f1a
Ari Suonpaa [Sat, 20 Jun 2020 07:27:41 +0000 (10:27 +0300)]
Add test for writing to an SSBO array
VK-GL-CTS Issue: 2285
New tests:
dEQP-VK.compute.basic.write_ssbo_array
Components: Vulkan
Change-Id: I6650aa1e087a5fb3c2bdad5eb3788b944faf996e
Mika Väinölä [Thu, 14 May 2020 19:50:16 +0000 (22:50 +0300)]
Add modfStruct comparison tests
Add tests for comparing the output of modf and modfStruct with 32-bit floats
and vectors as input. Update Amber and implement delegate for loading buffers
from files in AmberScript.
New tests:
dEQP-VK.spirv_assembly.instruction.*.float32.comparison_*.modfstruct*
Components: Vulkan
VK-GL-CTS issue: 1728
Change-Id: If2ee37779472be543038bae313792e2367051bdf
Alexander Galazin [Thu, 7 May 2020 14:16:08 +0000 (16:16 +0200)]
Fix Fedora 32 gcc/clang warnings
Component: AOSP, OpenGL, Vulkan
VK-GL-CTS issue: 2350
Affects:
KHR*direct_state_access.vertex_arrays*
KHR*core.arrays_of_arrays.sized_declarations_invalid*
dEQP-VK.geometry.*
Change-Id: I55680ac671d0610917d45f7187deec6e883dd6b7
Matthew Netsch [Fri, 19 Aug 2022 14:46:11 +0000 (07:46 -0700)]
Merge vk-gl-cts/opengl-cts-4.6.2 into vk-gl-cts/main
Change-Id: Idb23c14d0c59ef6dd554b27ecca20ee9dfdbcb0c
Matthew Netsch [Thu, 18 Aug 2022 21:33:28 +0000 (21:33 +0000)]
Merge vk-gl-cts/opengl-cts-4.6.1 into vk-gl-cts/opengl-cts-4.6.2
Change-Id: I621d54886cc3e3521d3e02f456017abad2085796
Jeff Bolz [Tue, 16 Aug 2022 16:51:31 +0000 (11:51 -0500)]
Add missing checks for update after bind support
Some descriptor_copy tests use update-after-bind without checking
the corresponding field of VkPhysicalDeviceDescriptorIndexingFeatures.
Affects: dEQP-VKSC.binding_model.descriptor_copy.*
Components: Vulkan, VulkanSC
Change-Id: I3cfefda0b118bb05d210c47dbcf504a9a985c123
Piotr Byszewski [Thu, 28 Jul 2022 18:09:31 +0000 (20:09 +0200)]
Add coverage for MaxAtomicCounterBufferSize
Test if placing an atomic counter into a buffer
at such an offset that the buffer is too large results
in a compilation error.
Components: OpenGL
VK-GL-CTS issue: 3124
Affects:
KHR-GL42.shader_atomic_counters.negative-large-offset
KHR-GLES31.core.shader_atomic_counters.negative-large-offset
Change-Id: Ib1ea21f2c1035d0a86ab2d4b3e4260756c88bfba
Piotr Byszewski [Fri, 29 Jul 2022 17:07:09 +0000 (19:07 +0200)]
Check that image*Shadow are not reserved keywords
There used to be a tests that treated: image1DShadow, image2DShadow,
image1DArrayShadow, image2DArrayShadow as reserved keywords but they
were removed because the spec doesn't actually reserve them. Any
drivers that were passing the old test were behaving incorrectly so
this change adds new tests that check if these keywords are not
reserved.
Components: OpenGL ES
VK-GL-CTS issue: 3007
Affects:
dEQP-GLES3.functional.shaders.keywords.allowed_keywords.*
Change-Id: Ic6b4463e51b45611441481d661d71735570dd15a
Piotr Byszewski [Thu, 4 Aug 2022 10:10:59 +0000 (12:10 +0200)]
Fix vkGetPhysicalDeviceProperties2 query
Recent framework change added few invalid structures to
pNext chain of vkGetPhysicalDeviceProperties2.
VK-GL-CTS issue: 3872
Components: Framework, Vulkan
Affects:
dEQP-VK.*
Change-Id: Iae75d84e454ee4c55ae31db3ea0b756574747066