android-build-prod (mdb) [Mon, 30 Apr 2018 17:30:06 +0000 (17:30 +0000)]
Merge "DO NOT MERGE: Merge remote-tracking branch 'khronos/vulkan-cts-1.0.2' into HEAD" into oreo-cts-dev
Chris Forbes [Tue, 27 Feb 2018 00:31:59 +0000 (16:31 -0800)]
DO NOT MERGE: Merge remote-tracking branch 'khronos/vulkan-cts-1.0.2' into HEAD
Change-Id: Id624bed0598e117aff161ee6ed92a135095e33d7
Bug: b/
73945443
Caio Marcelo de Oliveira Filho [Thu, 22 Feb 2018 01:54:57 +0000 (17:54 -0800)]
Handle gcc 7 warnings
- "-Wimplicit-fallthrough" warns on case conditions that
fallthrough. GCC does have a way to accept conditions that have a
comment about falling through inside the cases, but the codebase has
other cases where a single comment explains the fallthrough for the
whole switch. This warning is being ignored. It was not possible to
use "-Wno-error=WARNING" because older GCCs fail -- but they do
accept "-Wno-WARNING" where WARNING is unknown (since at least gcc
4.6.4).
- "-Wint-in-bool-context" warns (among other things) about result of
multiplication being used in boolean context. Code was changed to
use de::max() instead.
- "-Wmaybe-uninitialized" warned about some attributes of a struct not
being initialized depending on the case. Code was changed to
initialize the struct in question.
Components: Framework, Vulkan
Bug: b/
74405145
Change-Id: Iabb26f01e047353c6e2a704ab27b673e85b185be
(cherry picked from commit
f1ee9253e64f7434cdba7c8ac048c0e9baccc133)
Brian Anderson [Fri, 9 Mar 2018 18:25:08 +0000 (10:25 -0800)]
eglGetFrameTimestamps: Don't require reads done to be monotonic.
Reads done is usually monotonic, but only under the assumption
that every buffer of the surface is being consumed by the same
unit. It is possible for a surface to switch between being an
overlay and being composited by the GPU. It's also possible a
driver will maintain a shadow copy of a frame that will further
affect when reads from a buffer might finish.
Remove the overly strict check.
Bug:
70334851,
74184639
Test: --deqp-case=dEQP-EGL*get_frame_timestamps*
Change-Id: I8e242a9fd649720b4d8059797c71163329b7b92c
Bas Nieuwenhuizen [Fri, 23 Feb 2018 22:03:07 +0000 (22:03 +0000)]
DO NOT MERGE: Fix dEQP-VK.api.copy_and_blit.image_to_image_depth value range.
am:
f03effb5a0 -s ours
Change-Id: I26792ef93ead582aabb8bd5beb386588846c7489
Tom Cooper [Mon, 12 Feb 2018 16:20:58 +0000 (16:20 +0000)]
Fix low memory in dedicated_alloc buffer tests
Observe platform memory limits to avoid low memory conditions.
Components: Vulkan
VK-GL-CTS issue: 1008
Affects: dEQP-VK.api.buffer.dedicated_alloc.create_buffer_*
Change-Id: Ib184b648126e8cb6e1acff533447a86be9a1a612
Bas Nieuwenhuizen [Thu, 15 Feb 2018 10:33:22 +0000 (11:33 +0100)]
DO NOT MERGE: Fix dEQP-VK.api.copy_and_blit.image_to_image_depth value range.
Per spec:
"Because depth or stencil aspect buffer to image copies may require format conversions on some
implementations, they are not supported on queues that do not support graphics. When copying to
a depth aspect, the data in buffer memory must be in the the range [0,1] or undefined results occur."
Initializing it to integer values falls afoul of this rule
quickly. As the image is 256 by 256, x/255.0 should always fall in the range [0,1].
Not entirely sure this would initialize combined depth stencil correctly,
but this version of CTS does not have a test using those formats with
this code.
This has been fixed upstream for a while with
"
9909b9f3 Fix combined depth/stencil clear colors."
but this is not a straight backport as these tests saw some significant rework between
this CTS version and the fix.
Bug: b/
73449389
Change-Id: Iaf0ce14ed4338d437f1b20033be5d0f8c0cbd699
Treehugger Robot [Tue, 13 Feb 2018 21:08:38 +0000 (21:08 +0000)]
Merge "Merge remote-tracking branch 'origin/vulkan-cts-1.0.2' into HEAD" into oreo-cts-dev
Kantoch [Fri, 9 Feb 2018 18:54:40 +0000 (18:54 +0000)]
DO NOT MERGE: Sparse resources fixes
am:
ae793c389b -s ours
Change-Id: Ib87ed9843313e5ba76ccae32161ed5719615fa55
Lionel Landwerlin [Fri, 9 Feb 2018 15:20:25 +0000 (15:20 +0000)]
YCbCr: go through the correct location ranges when sampling
Affects: dEQP-VK.ycbcr.conversion.*
Components: Vulkan
VK-GL-CTS issue: 1005
Change-Id: Ifac1026e82e1bb48195fc7ab5429951a15324042
Kantoch [Tue, 19 Jul 2016 11:37:33 +0000 (13:37 +0200)]
DO NOT MERGE: Sparse resources fixes
1. Do not allow to request more queues than available
2. Allow to reuse queue if it supports more than one type of operations
(cherry picked from VK-GL-CTS commit
5f2cf2f7139c2f603a02fe3c284921dd9152dee3)
Bug: b/
72734354
Change-Id: Ia063df59c2220a082ea5a73a0fc968cfb97fda2c
Chris Forbes [Tue, 6 Feb 2018 01:12:53 +0000 (17:12 -0800)]
Merge remote-tracking branch 'origin/vulkan-cts-1.0.2' into HEAD
Bug: b/
72972234
Change-Id: I537a4f3207c1f88d68a51a23f21a5fed0975b037
Vamsidhar Gaddam [Wed, 31 Jan 2018 10:23:48 +0000 (11:23 +0100)]
Pass in proper pWaitDstStageMask in vktWsiSharedPresentableImageTests
One of the submitInfos for a queue submit had
a semaphore passed in without passing in any stage mask. This is a
spec violation.
Affects:
dEQP-VK.wsi.android.shared_presentable_image.*
Components: Vulkan
VK-GL-CTS issue: 974
Change-Id: Iee2ea838e971a3610f44b8c1f765869a8a21fedb
Panagiotis Apostolou [Wed, 17 Jan 2018 09:01:58 +0000 (10:01 +0100)]
Spec relaxation for YCbCr Implicit chroma reconstruction
Incorporates spec relaxation in the YCbCr tests which describes that when
doing implicit reconstruction with nearest chroma filtering, an
implementation may behave as if both xChromaOffset and yChromaOffset were
VK_CHROMA_LOCATION_MIDPOINT.
Tests affected:
dEQP-VK.ycbcr.conversion.*
Components: Vulkan
VK-GL-CTS issue: 979
Change-Id: I10e83d2f5845c3e74673aa9e42fc4f0950f9e6cd
Mark Adams [Fri, 12 Jan 2018 21:21:00 +0000 (16:21 -0500)]
Handle unsupported no_config contexts
EGL_KHR_no_config_context doesn't mandate support for ES 1.1 or
for GL versions prior to 3.0. Update the test to handle
optional support, and also update the GL version to 3.0 in order
to test a case which is expected to work.
Bug: b/
72041864
Components: AOSP
Test: dEQP-EGL.functional.create_context.no_config
Change-Id: Ibe7856000c67326fe23cd024435290fba536d127
Chris Forbes [Fri, 19 Jan 2018 18:06:53 +0000 (10:06 -0800)]
Suppress new warnings from gcc-6
check_build_sanity currently fails with the system gcc on rodete. Let's
just suppress this warning for now. Intend to back out the suppression
and fix the warnings in next release.
Bug: b/
72219443
Test: build
Change-Id: Ic842a3de3d247d53c49117562b51e8eece3752f9
Yanjun Zhang [Wed, 10 Jan 2018 00:12:47 +0000 (16:12 -0800)]
Check GS support before testing adjacent primitives
Affects: dEQP-VK.draw.basic_draw.draw.*
Components: Vulkan
VK-GL-CTS issue: 926
Change-Id: I02569b1944eed52f641966f9206d44983d1ff165
Chris Forbes [Wed, 10 Jan 2018 02:13:15 +0000 (18:13 -0800)]
Fix buffer usage flags for index and indirect buffers
Previously, createAndUploadBuffer would provide
VK_BUFFER_USAGE_VERTEX_BUFFER_BIT for all buffers. This is no good for
index buffers and indirect buffers.
VK-GL-CTS: 930
Change-Id: I774beef7c7226f4fbd5670591eb66475300ee208
Components: Vulkan
Affects: dEQP-VK.draw.instanced.*
Yanjun Zhang [Thu, 11 Jan 2018 19:44:54 +0000 (11:44 -0800)]
Set maxDescriptorSet* limit table based on shader stages
Re-submit the patch based on WG review and feedback.
Affects: dEQP-VK.api.info.device.properties
Components: Vulkan
VK-GL-CTS issue: 923
Change-Id: Ie627b52cfae099d87f5b6183118d42bcccd313ca
Pyry Haulos [Fri, 12 Jan 2018 23:57:24 +0000 (23:57 +0000)]
Limit maximum allocation size in memory mapping tests am:
adff582b50
am:
71ef361f3e
Change-Id: I138e6025b0cfb77ffd8197b796e32b06011cbc8a
Mika Isojrvi [Fri, 12 Jan 2018 23:57:09 +0000 (23:57 +0000)]
Improve memory tracking in vulkan memory mapping tests am:
3a8ec35d52
am:
b1f38f97cf -s ours
Change-Id: I8fc045601456dd0b8d0026c4e70db43cf4998886
Mika Isojrvi [Fri, 12 Jan 2018 23:56:55 +0000 (23:56 +0000)]
Optimize random memory mapping tests reference memory am:
7e69d67a2c
am:
b2dcf86f17 -s ours
Change-Id: Iaa15b3997481353a88aef19cdde4348ae2cc3f75
Pyry Haulos [Fri, 12 Jan 2018 22:57:15 +0000 (22:57 +0000)]
Limit maximum allocation size in memory mapping tests
am:
adff582b50
Change-Id: Iff465c2be4d7c27702036f8f060a458c55830732
Mika Isojrvi [Fri, 12 Jan 2018 22:57:12 +0000 (22:57 +0000)]
Improve memory tracking in vulkan memory mapping tests
am:
3a8ec35d52
Change-Id: I54613d0c408d80a65cc175e86495d0ffd4c650b5
Mika Isojrvi [Fri, 12 Jan 2018 22:57:10 +0000 (22:57 +0000)]
Optimize random memory mapping tests reference memory
am:
7e69d67a2c
Change-Id: I2c91c3720102d1c4c949bf19a2b6af51c59581f1
Mark Adams [Fri, 20 Oct 2017 13:49:08 +0000 (09:49 -0400)]
Multiple draw buffers in blend_equation_advanced
GL_NVX_blend_equation_advanced_multi_draw_buffers adds support for
multiple draw buffers with advanced blend equations. This change
modifies the below test to check for this extension and to expect
GL_NO_ERROR if it is present.
Components: AOSP
VK-GL-CTS issue: 770
Bug: b/
71901344
Affects:
dEQP-GLES31.functional.debug.negative_coverage.get_error.advanced_blend.attachment_advanced_equation
(cherry picked from commit
2cb35a235c1a7bd3c63b296c37e186eec34e08e2)
Change-Id: I865fa30e527b5899197bade465602bafc92a54a1
Yanjun Zhang [Wed, 10 Jan 2018 00:26:50 +0000 (16:26 -0800)]
Check sampleRateShading for sample_qualifier_distinct_values.* tests
Affects: dEQP-VK.pipeline.*.sample_qualifier_distinct_values.*
Components: Vulkan
VK-GL-CTS issue: 925
Change-Id: Ife1166e8ed88699c67ee6acde79857f34c013398
Chris Forbes [Tue, 9 Jan 2018 23:26:34 +0000 (15:26 -0800)]
Use unique indices for each binding in out_of_pool_memory test
Previously, all the layout bindings would use binding=0, which is
invalid. Give them their own binding indices.
VK-GL-CTS: 929
Change-Id: I28e62db6c257ed0843dd9b77b2d8cb01d02e3eba
Components: Vulkan
Affects: dEQP-VK.api.descriptor_pool.out_of_pool_memory
Treehugger Robot [Fri, 12 Jan 2018 01:10:31 +0000 (01:10 +0000)]
Merge "Reduce GPU workload of pipeline_barrier tests" into oreo-cts-dev
Noah Fredriks [Fri, 3 Nov 2017 18:20:06 +0000 (14:20 -0400)]
Round up vertex buffer size to stride multiple to fix OOB attribute reads
Partial stride multiple vertex buffer elements are now considered OOB
to accomodate implementations that fetch stride-sized elements
Affects: dEQP-VK.texture.*
Components: Vulkan
VK-GL-CTS issue: 812
Change-Id: I72a2143146b4ea0d893d70d41b7ca2c84c34542a
(cherry picked from commit
50c0544ec8c2e99158bf8a375eacfc9baf364a91)
Chris Forbes [Thu, 21 Dec 2017 18:22:58 +0000 (10:22 -0800)]
glshared: Add watchdog touches to avoid timeouts on slow hardware
Based on diffs posted to deqp-external-requests
Bug: b/
71753331
Bug: b/
67854695
Change-Id: Id25e334814caf65f72b76e66d3b07fccba5ad355
Component: AOSP
Treehugger Robot [Sat, 16 Dec 2017 00:34:23 +0000 (00:34 +0000)]
Merge "Avoid watchdog timeout in Vulkan builtin precision tests" into oreo-cts-dev
Noah Fredriks [Thu, 14 Dec 2017 19:48:48 +0000 (14:48 -0500)]
Fix Invalid VkImageSubresourceRange
Pipeline image barrier was using the arraySize of the wrong image.
Affects: dEQP-VK.api.copy_and_blit.core.resolve_image.*
Components: Vulkan
VK-GL-CTS Issue: 910
Change-Id: I021bdd0ba5eff9e894f21186b3d85bb2f2c99f16
Jeff Leger [Sat, 2 Dec 2017 02:16:28 +0000 (21:16 -0500)]
Modify spirv_assembly tests adding dependency on 16bit_storage extension
Several tests were using 16bit_storage, but were not checking the
extension was supported nor declaring the required opCapability.
Affects:
dEQP-VK.spirv_assembly.instruction.compute.sconvert.*
dEQP-VK.spirv_assembly.instruction.compute.uconvert.*
Components: Vulkan
VK-GL-CTS issue: 875
Change-Id: I07fda13c69cdef09967d4aab5067edff07c47fa1
Noah Fredriks [Wed, 29 Nov 2017 23:27:52 +0000 (18:27 -0500)]
Avoid creating vkInstances for not supported cases
Defer vkInstance creation for cross instance tests until not supported
checks complete to shorten the runtime of these 10k total test cases.
Affects: dEQP-VK.synchronization.cross_instance.*
Components: Vulkan
VK-GL-CTS Issue: 885
Change-Id: I481de90d8c0363c23a287aaf457ac101c327c558
Igor Ostrowski [Wed, 15 Nov 2017 17:33:51 +0000 (18:33 +0100)]
Fix mediump zero division in matrix inverse tests
To avoid zero division all input matrix determinants should be same signed.
Affects:
dEQP-VK.glsl.matrix.inverse.*
Components: Vulkan
VK-GL-CTS issue: 881
Change-Id: Ib702f81c4eb7f25ba9081db6ead67da02f484ca9
Pyry Haulos [Fri, 19 Aug 2016 12:20:38 +0000 (13:20 +0100)]
Limit maximum allocation size in memory mapping tests
Fixes also ReferenceMemory::m_flushed memory usage counting when
estimating reference memory usage (size should be divided by atomSize).
Fixes #468
Bug: b/
69677943
Change-Id: Iad754e211e8070b09254d2451e03418fc2be541b
Mika Isojärvi [Tue, 7 Jun 2016 19:39:37 +0000 (12:39 -0700)]
Improve memory tracking in vulkan memory mapping tests
- Round up allocation size to multiple of page size for
memory usage tracking.
- Update reference memory usage tracking to follow new reference memory
implementation.
Bug: b/
69677943
Change-Id: I219c2b3abe0ee0731f5a7e2bb44492e5b85b95c2
Mika Isojärvi [Tue, 7 Jun 2016 18:21:46 +0000 (11:21 -0700)]
Optimize random memory mapping tests reference memory
Bug: b/
69677943
Change-Id: I7af6fe67a25462dcb0acc66c238a8708157060df
Mark Adams [Mon, 4 Dec 2017 22:26:54 +0000 (17:26 -0500)]
Don't assume rendering complete before buffer latch
It's valid for the buffer to latch before rendering is completed, and
this is causing intermittent failures.
Bug: b/
69981429
Test: --deqp-case=dEQP-EGL*get_frame_timestamps*
Change-Id: Ia9f1d0e4ffa7f3e16a46fc4566157a651d1b0601
Chris Forbes [Mon, 16 Oct 2017 19:42:35 +0000 (12:42 -0700)]
Avoid watchdog timeout in Vulkan builtin precision tests
Calculating the reference intervals can take a substantial amount of
time. On some very slow targets, this can cause us to trip the watchdog
in the verification loop.
Same approach and limit as in modules/glshared/glsBuiltinPrecisionTests.cpp
Affected tests:
dEQP-VK.glsl.builtin.precision.*
Component: Vulkan
Bug:
67854695
Test: run on google devices
Change-Id: I492b656e7e2a9aa724bb3785bdf1416a4c22ec04
Jeff Leger [Wed, 22 Nov 2017 17:12:58 +0000 (12:12 -0500)]
Reduce GPU workload of pipeline_barrier tests
Tests with large buffer sizes will now clamp the
GPU workload to avoid triggering execution timeout
on implementations.
Affects: dEQP-VK-memory.pipeline_barrier.*
Components: Vulkan
VK_GL_CTS issue: 813
Change-Id: I479f6ad04ef2ec6f9d87b65a39a2bc13bcbcc6a2
Jeff Leger [Wed, 22 Nov 2017 17:12:58 +0000 (12:12 -0500)]
Reduce GPU workload of pipeline_barrier tests
Tests with large buffer sizes will now clamp the
GPU workload to avoid triggering execution timeout
on implementations.
b/
68360750
Affects: dEQP-VK-memory.pipeline_barrier.*
Components: Vulkan
VK_GL_CTS issue: 813
Change-Id: If8772973fd49cac0b8cc5fa66c33af4de38f2f68
Jari Komppa [Tue, 14 Nov 2017 12:21:06 +0000 (14:21 +0200)]
Added constraints for random access flags
The pipeline barrier tests randomize access flags and stages, sometimes
resulting in access flags being enabled for stages that do not support
said accesses. This fix removes the illegal access flags while leaving
the random flag generation intact.
Affects:
dEQP-VK.memory.pipeline_barrier.*
Components: Vulkan
VK-GL-CTS issue: 814
Change-Id: I135ea8a9e41b5d8428ef77fe6ecbdf2380d80c7d
Jorg Wagner [Mon, 6 Nov 2017 13:56:49 +0000 (14:56 +0100)]
Do not use depthClampEnable unconditionally.
Depth clamping is not needed by this test, so
do not rely on the optional feature when creating
the pipeline object.
Affects:
dEQP-VK.api.smoke.*
Components: Vulkan
VK-GL-CTS issue: 817
Change-Id: I6794f7f5d17d7610ff43dcb4080a6a30e12ed95b
Gurchetan Singh [Tue, 7 Nov 2017 20:24:36 +0000 (20:24 +0000)]
Lower correlation threshold in flush-finish tests again
am:
6455e6f987
Change-Id: I11a62d5d0af3612ed1cdcbedee1ba53d5b0e57ae
Treehugger Robot [Tue, 7 Nov 2017 19:49:35 +0000 (19:49 +0000)]
Merge changes I5f7e56e3,I7f88e1da into oreo-cts-dev
* changes:
eglGetFrameTimestamps: Consider timestamps of 0 as invalid.
eglGetFrameTimestamps: Allow reads done to equal rendering complete.
Brian Anderson [Thu, 19 Oct 2017 21:59:28 +0000 (14:59 -0700)]
eglGetFrameTimestamps: Consider timestamps of 0 as invalid.
There's a bug in the kernel that doesn't merge fences properly,
resulting in "reads done" timestamps of 0 when the fences being
merged have already signaled.
This is a temporary relaxation of the test requirements until
the kernel fix is required.
Bug:
68811985
Test: --deqp-case=dEQP-EGL*get_frame_timestamps*
Change-Id: I5f7e56e3a0c9808237a1ebc3787cf788feef1a79
Brian Anderson [Tue, 17 Oct 2017 19:17:40 +0000 (12:17 -0700)]
eglGetFrameTimestamps: Allow reads done to equal rendering complete.
If there are no reads performed by the compositor, it is possible
for reads done timestamp to be the same as the rendering complete
timestamp.
Also add and use check_lt and check_le, to print out more detailed
debug info in the results.
Bug:
68811985
Test: --deqp-case=dEQP-EGL*get_frame_timestamps*
Change-Id: I7f88e1da98be97101e8b0d6cd130b75bda8d88ca
Chris Forbes [Mon, 23 Oct 2017 22:13:38 +0000 (15:13 -0700)]
KHR_swapchain: Trigger the fence off vkQueueSubmit
Another instance of
438ea0888e8ccae.
VK-GL-CTS issue: 756
Component: Vulkan
Affects:
dEQP-VK.wsi.*.swapchain.*
Change-Id: I87da6800e0c8402c2c50ca88eb3360b31c3a515d
Chris Forbes [Mon, 23 Oct 2017 22:09:56 +0000 (15:09 -0700)]
GOOGLE_display_timing: Trigger the fence off vkQueueSubmit
Another instance of
438ea0888e8ccae.
VK-GL-CTS issue: 756
Component: Vulkan
Affects:
dEQP-VK.wsi.*.display_timing.*
Change-Id: If94644402579ba1f46347d155313f6ef52d125a0
Jason Ekstrand [Thu, 19 Oct 2017 16:07:52 +0000 (09:07 -0700)]
VK_KHR_variable_pointers: Don't use OpPtrAccessChain on a bare SSBO
You can't use OpPtrAccessChain on the direct result of an OpVariable
because it's not the element of any array. Instead, we need to do our
OpPtrAccessChain on a pointer to an actual array element and that
pointer needs to be properly decorated with a stride.
Component: Vulkan
VK-GL-CTS issue: https://gitlab.khronos.org/Tracker/vk-gl-cts/issues/686
Affects:
dEQP-VK.spirv_assembly.instruction.graphics.variable_pointers.multi_buffer_*
Change-Id: I9c45fb1320099e404672ee169a6a8e5c41eb13f7
Jason Ekstrand [Thu, 19 Oct 2017 15:43:36 +0000 (08:43 -0700)]
VK_KHR_variable_pointers: Delete an unused and invalid variable
The %float_var variable was not being used in any way by the test. It
was also invalid because it had the StorageBuffer storage class (so it's
in external memory) but also had a constant initializer. The real
variable being tested in these tests is %f32_ptr_var which has the
Function storage class so a constant initializer is fine.
Component: Vulkan
VK-GL-CTS issue: https://gitlab.khronos.org/Tracker/vk-gl-cts/issues/686
Affects:
dEQP-VK.spirv_assembly.instruction.graphics.variable_pointers.nullptr_graphics.opvariable_initialized_null_*
dEQP-VK.spirv_assembly.instruction.graphics.variable_pointers.nullptr_graphics.opselect_null_or_valid_ptr_*
Change-Id: I9e2f118b1c774a84c0b6900ef0db081cb5256c2f
Chris Forbes [Mon, 16 Oct 2017 19:42:35 +0000 (12:42 -0700)]
Avoid watchdog timeout in Vulkan builtin precision tests
Calculating the reference intervals can take a substantial amount of
time. On some very slow targets, this can cause us to trip the watchdog
in the verification loop.
Same approach and limit as in modules/glshared/glsBuiltinPrecisionTests.cpp
Affected tests:
dEQP-VK.glsl.builtin.precision.*
Component: Vulkan
Bug:
67854695
Test: run on google devices
Change-Id: I492b656e7e2a9aa724bb3785bdf1416a4c22ec04
Chris Forbes [Fri, 29 Sep 2017 16:51:49 +0000 (09:51 -0700)]
Exclude incremental_present scale down from Android CTS
Bug: b/
67022169
Bug: b/
67295411
Test: check_build_sanity
Change-Id: I4be889f0bf64251069e829924faf4e8c113baa86
Chris Forbes [Fri, 29 Sep 2017 16:51:49 +0000 (09:51 -0700)]
Exclude shared_presentable_image scale down from Android CTS
Bug: b/
66464066
Test: check_build_sanity
Change-Id: If815b53b8e998e720aca4fc1994e0151eef971a5
Gurchetan Singh [Fri, 6 Oct 2017 16:06:21 +0000 (09:06 -0700)]
Lower correlation threshold in flush-finish tests again
This test expects predictability from glFlush/glFinish timing.
In particular, the code from FlushFinishCase::analyzeResults()
checks that the result falls within specific timing thresholds.
Notice that in the GLES3 specification, there is no requirement for
timing, just a guarantee that "commands [...] complete in finite time".
This is a problem because it makes the test very flaky, for example
if the CPU/GPU clocks are not ramping up fast enough.
BUG=b:
67331095
TEST=Ran dEQP-GLES3.functional.flush_finish.finish on Elm for over 3+ hours
Observed 1.5% to 2% flakiness without this patch. Observed no flakiness
with this patch.
(cherry picked from commit
59f4fcde5ac1402ab3b911cf6a9f66b886c10464)
Signed-off-by: Gurchetan Singh <gurchetansingh@google.com>
Jason Ekstrand [Fri, 6 Oct 2017 23:10:26 +0000 (16:10 -0700)]
VK_KHR_incremental_present: Trigger the fence off vkQueueSubmit
Previously, the tests were using AcquireNextImage to trigger the fence
and using it to guard the vkFreeCommandBuffers call. However, the
acquire fence tells you when the PE is done with an image and when you
can start rendering to it. This meant that the test was waiting for the
start of the previous frame's rendering not the end before deleting the
previous frame's command buffer. This meant that the previous frame's
rendering could still be active on the GPU when the command buffer was
freed. By triggering the fence off of the vkQueueSubmit, we wait for
the end of the previous frame's rendering before freeing its command
buffer.
VK-GL-CTS issue: 756
Component: Vulkan
Affects:
dEQP-VK.wsi.*.incremental_present.*
Change-Id: I87b25eb2a25e4ae48c8c527d5d63c45d89a31a30
(cherry picked from commit
db916576a76a17c02c14390fc5d5b3db1488d1d2)
Igor Ostrowski [Mon, 9 Oct 2017 14:41:31 +0000 (16:41 +0200)]
DrawUtil: Fix depthBounds check
Affects:
dEQP-VK.glsl.builtin_var.fragdepth*
Components: Vulkan
VK-GL-CTS issue: 758
Change-Id: I4da79b236921e64f11566fe386b144497249123b
Chris Forbes [Tue, 3 Oct 2017 17:17:59 +0000 (10:17 -0700)]
Disable some UBO tests which got broken by recent glslang change
Bug: b/
67013571
Change-Id: I54c3f9aba636381a57e398de603b09dad4d14188
Jorg Wagner [Thu, 28 Sep 2017 11:59:51 +0000 (13:59 +0200)]
Correct image usage flags for YCbCr copy tests
The images are used as copy source and destination,
hence TRANSFER_SRC | TRANSFER_DST must be present
in the usage flags.
Images are not sampled from - remove SAMPLED flag.
Affects:
dEQP-VK.ycbcr.copy.*
Components: Vulkan
VK-GL-CTS issue: 715
Change-Id: Ie53d3e2fb18aa834af12938cd822aa6c50f75986
(cherry picked from commit
f2a5b768c81760bef727f1d72741e74274968518)
Panagiotis Apostolou [Thu, 7 Sep 2017 11:54:51 +0000 (13:54 +0200)]
Serialize region copies for YCbCr copy tests
As the generated regions can overlap - force all calls
of vkCmdCopyImage() to be executed sequentially by adding
a pipeline barrier between each call to avoid producing
undefined results.
Affects:
dEQP-VK.ycbcr.copy.*
Components: Vulkan
VK-GL-CTS issue: 716
Change-Id: Ifed67cdc077a8c03630b36f8aa59bd6dae0578a3
(cherry picked from commit
9fe7d4753721d10235cbf38194cf7c8cf2eb7d19)
Alexander Galazin [Wed, 27 Sep 2017 12:13:30 +0000 (14:13 +0200)]
Remove YCbCr from the instance extensions
VK_KHR_sampler_ycbcr_conversion is a device extension.
It must not be listed as an allowed instance extension.
Components: Vulkan
VK-GL-CTS issue: 698
Affects:
dEQP-VK.api.info.instance.extensions
Change-Id: I1ee1448535df75016a0214ebfe800a476daf32c4
Peter Gal [Fri, 15 Sep 2017 16:39:08 +0000 (18:39 +0200)]
Typo fix in YCbCr conversion tests
During YCbCr conversion tests the Disjoint
information ws incorrectly recorded into the
log file.
Change-Id: I63c5d5fc326fd52019f4e167c6632132cbc4668c
Components: Vulkan
(cherry picked from commit
37a196f757a516af2d75f4653153d1e5df8809db)
Alexander Galazin [Tue, 19 Sep 2017 15:24:50 +0000 (10:24 -0500)]
Remove merge conflicts artefacts
vulkan.h.in has some merge conflicts artefacts.
This change removes them.
Components: Vulkan
VK-GL-CTS issue: 699
Change-Id: Ic9a72583f1d082e69a26a67e7e1306040cac0453
Mika Isojärvi [Thu, 31 Aug 2017 18:54:48 +0000 (11:54 -0700)]
Fix missing SSBO binding in EGL robustness tests
Bug:
64845581
Bug:
65175642
Test: Ran the tests on couple of Google devices
Change-Id: I3a98fe12802e6951483499e800cd3fe7412e37f0
Mika Isojärvi [Thu, 31 Aug 2017 19:13:05 +0000 (12:13 -0700)]
Fix unused uniform bug in EGL robustness tests
Bug:
64845766
Bug:
65175554
Test: Ran tests on couple of Google devices
Change-Id: Iee2918c1e45ad305dd9ca30f1b81998bdac06127
Michael Chock [Mon, 14 Aug 2017 18:55:14 +0000 (11:55 -0700)]
Do not use degenerate frames in EGL tests
The dEQP-EGL.functional.buffer_age.* and
dEQP-EGL.functional.partial_update.* tests use randomly-generated frames
for rendering. The test allows the generation of frames with a width or
height of 0, but the tcu::PixelBufferAccess interface does not permit
0-sized subregions (see assertions inside getSubregion overloads in
tcuTextureUtil.cpp).
Skip the rendering of degenerate frames in the reference renderer, as
they are unsupported but would not affect the rendering if they were.
Bug:
65317274
Test: Ran tests on couple of Google devices
Change-Id: I3977c3c293715db633dde74132e56b5d9303ab28
Mika Isojärvi [Mon, 18 Sep 2017 20:27:19 +0000 (13:27 -0700)]
Exclude mutable image tests from Android CTS
Bug:
65844886
Test: Ran scripts/check_build_sanity.py
Change-Id: Ia779ed1e9c3339f0e4ddb599647284c15f1aeaaf
Mika Isojärvi [Fri, 15 Sep 2017 21:15:20 +0000 (14:15 -0700)]
Merge Vulkan CTS 1.0.2.6 into aosp/oreo-cts-dev
Bug:
65677277
Test: Run Android CTS deqp tests
Change-Id: I2ffb7d3929448e721f8097f323eaab011b445d8b
Samuel Iglesias Gonsálvez [Mon, 4 Sep 2017 07:16:30 +0000 (09:16 +0200)]
Fix bug when setting descriptor set layouts
Affects:
dEQP-VK.glsl.builtin_var.fragdepth.*
dEQP-VK.glsl.builtin_var.fragcoord_msaa.*
Fixes crashes added by
595b5f763a8f6ef1c68bfd133a55ded9c25ac101 (CL#1017).
Components: Vulkan
VK-GL-CTS issue: 659
Change-Id: I1464ff6b213f38a2ade08f1e9b11dad422ee3f21
(cherry picked from commit
153979d342b54aa04cb2038e158ff3e3c742d8b8)
Tony Wasserka [Tue, 12 Sep 2017 11:03:13 +0000 (12:03 +0100)]
Check for depthBounds support in shader builtin frag depth tests
Depth bounds testing was enabled without checking for feature support
in a couple of tests. With this change, tests that don't need this
feature leave it disabled, whereas other tests (currently only
dEQP-VK.glsl.builtin_var.fragdepth.*) now throw NotSupported when
the device doesn't support it.
Affects:
dEQP-VK.clipping.*
dEQP-VK.glsl.builtin_var.*
Components: Vulkan
VK-GL-CTS issue: 685
Change-Id: I44d94142e295ff135ad1a55d0d6e212b65994257
Alexander Galazin [Fri, 8 Sep 2017 07:13:24 +0000 (09:13 +0200)]
Merge vk-gl-cts/vulkan-cts-1.0.1 into vk-gl-cts/vulkan-cts-1.0.2
Change-Id: Ied1a7d639c56dbdffd3db89085b4b771741e43f7
Graeme Leese [Wed, 30 Aug 2017 15:37:14 +0000 (16:37 +0100)]
Change required sample counts for storage images
Update the API feature info tests to set requiredSampleCounts to 1 for
all images that are not usable as some type of framebuffer attachment.
Previously images that were not usable as attachments but could be used
as a storage image were incorrectly exempted from the requirement.
Components: Vulkan
VK-GL-CTS Issue: 645
Affects: dEQP-VK.api.info.image_format_properties.*
Change-Id: Ia0d09ad0ff51029b75cd3a264860a3dd63c249fb
Boris Zanin [Thu, 7 Sep 2017 07:19:08 +0000 (09:19 +0200)]
Fix VK_KHR_maintenance2 extended_usage_bit tests
Due to test runs over uncompressed formats it cannot include
VK_IMAGE_CREATE_BLOCK_TEXEL_VIEW_COMPATIBLE_BIT_KHR bit.
Remove this bit from the tests.
Update tests:
* dEQP-VK.image.extended_usage_bit.*
Components: Vulkan
VK-GL-CTS issue: 673, 614
Change-Id: I0adb26c5306a9d5f49936ffef070050fd5936faa
Gary Sweet [Mon, 4 Sep 2017 10:14:58 +0000 (11:14 +0100)]
Fixup some missing/incorrect flushes and invalidates
Some of the flushes were too small, and there were a few
missing invalidates.
Affects:
dEQP-VK.ssbo.layout.*
dEQP-VK.pipeline.push_constant.compute_pipeline.simple_test
Components: Vulkan
VK-GL-CTS issue: 660
Change-Id: I27fac24397984f82865683f30b823570c3e52aed
Slawomir Cygan [Wed, 6 Sep 2017 14:47:04 +0000 (16:47 +0200)]
Use SRC image layout for copy image to buffer
The test was calling vkCmdCopyImageToBuffer with
VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL layout, which is not a valid
parameter value for this function (and not the layout the image is currently in).
Affects: dEQP-VK.memory.binding.*.*.image_*
Components: Vulkan
VK-GL-CTS issue: 666
Change-Id: Ifb5a1bd8726535de02a0dc134f5ac76a2734a661
Slawomir Cygan [Tue, 5 Sep 2017 14:39:12 +0000 (16:39 +0200)]
Do not use ycbcr formats if ycbcr extension is not supported
Spec says (on "vkGetPhysicalDeviceFormatProperties"):
"format must be a valid VkFormat value"
Formats from future or unsupported extensions do not
constitute a "valid VkFormat values".
Affects: dEQP-VK.memory.requirements.*.image.*
Components: Vulkan
VK-GL-CTS issue: 663
Change-Id: Ia284977b830d5fda14bcbd9d96010995d84014d5
Pyry Haulos [Tue, 5 Sep 2017 15:21:58 +0000 (15:21 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am:
0f672f2a20
am:
9e85a126d2
Change-Id: Ia7cd7612e6c2f0f961837734f1900a21b52a0e39
Pyry Haulos [Tue, 5 Sep 2017 15:14:23 +0000 (15:14 +0000)]
Fix issues in pipeline.timestamp.transfer_tests
am:
0f672f2a20
Change-Id: Ib7e13db1c7801095b925890f226a38969a1b418e
Gary Sweet [Mon, 4 Sep 2017 09:39:36 +0000 (10:39 +0100)]
Fixup some missing/incorrect flushes and invalidates
Some of the flushes were too small, and there were a few
missing invalidates.
Affects:
dEQP-VK.ssbo.layout.*
dEQP-VK.pipeline.push_constant.compute_pipeline.simple_test
Components: Vulkan
VK-GL-CTS issue: 660
Change-Id: Id29b59d127e004a028c04a1075db563d697140a1
Daniel Koch [Thu, 31 Aug 2017 13:48:53 +0000 (09:48 -0400)]
Whitelist new extensions for VK 1.0.2.6
VK-GL-CTS issue: 653
Component: Vulkan
Affects:
dEQP-VK.api.info.device.extensions
Change-Id: I7f5ef7511ce8312e67833e07c154cd6b9fea6041
Mika Isojärvi [Tue, 15 Aug 2017 23:57:24 +0000 (16:57 -0700)]
Add tests for image copies between YCbCr formats
Components: Vulkan, Framework
VK-GL-CTS issue: 111
Change-Id: I3a7050ae5605c4397cd678e14438f851a7cf48ce
(cherry picked from commit
f24269bdd0c4d3801c2118b153082f0b0223f55a)
Mika Isojärvi [Tue, 16 May 2017 21:17:49 +0000 (14:17 -0700)]
Add tests for VK_KHR_sampler_ycbcr_conversion
Components: Vulkan, Framework
VK-GL-CTS issue: 111
Change-Id: Id0810b196f0a148903922df3fc08f1c5db88f86e
(cherry picked from commit
595b5f763a8f6ef1c68bfd133a55ded9c25ac101)
Boris Zanin [Fri, 12 May 2017 08:11:01 +0000 (10:11 +0200)]
Test VK_KHR_dedicated_allocation mem requirement queries
Add tests:
* dEQP-VK.memory.requirements.dedicated_allocation.buffer.*
* dEQP-VK.memory.requirements.dedicated_allocation.image.*
Components: Vulkan
VK-GL-CTS issue: 391
Change-Id: I9510464987e33b395a5ac20c2fdb9129eefd91da
(cherry picked from commit
6c472cc5e98a1a73aeac019ce34cccac7f3fa30e)
David Sodman [Fri, 24 Feb 2017 19:04:46 +0000 (11:04 -0800)]
Add tests for FragCoord interaction with multisampling
Components: Vulkan
VK-GL-CTS issue: 89
Test: fragcoord_msaa, frontface, fragdepth, clipping
Change-Id: Ibf342e63f224b88fe0b0cffde59b10b34afd1faf
(cherry picked from commit
69a7a0079a6cc06d556ecb5314f275d2fa01a60d)
Maciej Jesionowski [Wed, 26 Jul 2017 13:53:13 +0000 (15:53 +0200)]
Fix VS12 compilation error (typedef)
Change-Id: Iebfece1455df2a49c79885d42f43817001a31b84
(cherry picked from commit
68c41978cf7a76391e898af7faaddea0598a3911)
Slawomir Cygan [Wed, 5 Jul 2017 17:17:02 +0000 (19:17 +0200)]
Fix wrong transition in dEQP-VK.glsl.builtin_var.fragdepth
The test was using vkCmdClearDepthStencilImage to clear an
image, than used this image as a depth attachment in
redering performed by VulkanDrawContext utility.
However, this utility always starts the renderpass on depth
attachment from UNDEFINED layout. As no depth clear is done
in the renderpass, the depth attachment contents are undefined
(and initially cleared image contents may be corrupted).
The easiest fix here is to move the clear to LOAD_OP - as
is already done for color, leaving the UNDEFINED layout as is.
Affects: dEQP-VK.glsl.builtin_var.fragdepth*
Components: Vulkan
VK-GL-CTS issue: 559
Change-Id: Icef3289ba62f71bf1ed989f84085a4d9d3b7218a
(cherry picked from commit
f3a36239082b721e1f5f6849afc70af65b42e3ed)
David Sodman [Fri, 24 Feb 2017 18:41:59 +0000 (10:41 -0800)]
Add test for FragDepth shader built-in
Components: Vulkan
VK-GL-CTS issue: 93
Test: fragdepth, frontface, clipping
Change-Id: I531e39a58dd6b577108bff14b2206d7bf9d9cd4f
(cherry picked from commit
3aeb0c565fe64441466247fe381fc815209d46e4)
David Sodman [Tue, 6 Sep 2016 21:05:59 +0000 (14:05 -0700)]
Extend gl_FrontFacing tests
Update gl_FrontFacing tests to include more tests as well as to use the
vktDrawUtil utility class
Change-Id: If94fb552f5f9366c79ffa3fcac6f085611a23f65
(cherry picked from commit
417115b2676c3064a06385184573b6d7a0644f42)
David Sodman [Fri, 9 Sep 2016 02:58:35 +0000 (19:58 -0700)]
Add ability to generate images with the reference renderer
*Separate DrawContext into a DrawContext and DrawContextState to reflect
graphics API's are split between state and action parts
* Add abstract DrawContext class
Test: Test clipping and synchronization primitives
Change-Id: I9f3945c6c3de169325fadea7bf70a9d5d7bfd932
(cherry picked from commit
11da53fb71eced942e89bac59407a5681dba3bb1)
David Sodman [Thu, 1 Sep 2016 17:40:21 +0000 (10:40 -0700)]
Add Vulkan DrawContext utility class
This is the first in a series of changes to move the DrawContext class
for more general use.
Test: run clipping tests on Vulkan
Affects: dEQP-VK.clipping.*
Change-Id: Ia9b8953d25c10ec2a6c227bf300637dcd62ea898
(cherry picked from commit
9a928cdc2014c830eb8cb43043746f8f2ea6969a)
Arkadiusz Sarwa [Tue, 29 Aug 2017 14:40:58 +0000 (16:40 +0200)]
VK_KHR_maintenance2: View block-compressed add check shader_read_only_optimal
Affects:
* dEQP-VK.image.texel_view_compatible.compute.extended.image_load.*
* dEQP-VK.image.texel_view_compatible.compute.extended.texel_fetch.*
* dEQP-VK.image.texel_view_compatible.compute.extended.texture.*
* dEQP-VK.image.texel_view_compatible.compute.extended.image_store.*
* dEQP-VK.image.texel_view_compatible.graphic.extended.attachment_read.*
* dEQP-VK.image.texel_view_compatible.graphic.extended.attachment_write.*
* dEQP-VK.image.texel_view_compatible.graphic.extended.texture_read.*
* dEQP-VK.image.texel_view_compatible.graphic.extended.texture_write.*
Components: Vulkan
VK-GL-CTS issue: 124
Change-Id: Ida0c7b8085e7ca90c325ffb0477773e8b09bf564
(cherry picked from commit
62e68c3916ce22a76b44bec91e470abc42cd6e92)
Boris Zanin [Tue, 8 Aug 2017 09:59:32 +0000 (11:59 +0200)]
VK_KHR_maintenance2: extended_usage_bit tests
Add tests:
* dEQP-VK.image.extended_usage_bit.*
Components: Vulkan
VK-GL-CTS issue: 614
Change-Id: Ied6251e642746d5f37aa7b2fe3f262061f765f8f
(cherry picked from commit
dcae428a67a0bccf2a6694075dd06115f0eb1db7)
Arkadiusz Sarwa [Tue, 29 Aug 2017 10:39:57 +0000 (12:39 +0200)]
Fix build errors with uint32_t vktImageMutableTests.cpp
Change-Id: I072fade98fd20b6a4a0389e9a63e790d36d6c0d0
Components: Vulkan
(cherry picked from commit
1afc0a15d483701f3319467f7a3f1d9b47692f66)
Boris Zanin [Thu, 24 Aug 2017 08:29:06 +0000 (10:29 +0200)]
VK_KHR_maintenance2: View block-compressed speedup
Do strict comparison first, if it fails use fuzzy.
Update tests:
* dEQP-VK.image.texel_view_compatible.compute.*
Components: Vulkan
VK-GL-CTS issue: 124
Change-Id: I1ad580d60638ba3fce83fc913819608d5d9a8812
(cherry picked from commit
c9e2dea449429762592af0530b609cf80ab913ce)
Arkadiusz Sarwa [Fri, 21 Jul 2017 14:35:33 +0000 (16:35 +0200)]
VK_KHR_maintenance2: View block-compressed formats extended tests
Add tests:
* dEQP-VK.image.texel_view_compatible.compute.extended.image_load.*
* dEQP-VK.image.texel_view_compatible.compute.extended.texel_fetch.*
* dEQP-VK.image.texel_view_compatible.compute.extended.texture.*
* dEQP-VK.image.texel_view_compatible.compute.extended.image_store.*
* dEQP-VK.image.texel_view_compatible.graphic.extended.attachment_read.*
* dEQP-VK.image.texel_view_compatible.graphic.extended.attachment_write.*
* dEQP-VK.image.texel_view_compatible.graphic.extended.texture_read.*
* dEQP-VK.image.texel_view_compatible.graphic.extended.texture_write.*
Update tests:
* dEQP-VK.image.texel_view_compatible.compute.basic.*
* dEQP-VK.image.texel_view_compatible.graphic.basic.*
Components: Vulkan
VK-GL-CTS issue: 124
Change-Id: Ia51ece39a339617302ec4f2a48c9133a3f9423d4
(cherry picked from commit
90d87fdceed790f9542acb19c3da196951c4d2dc)
Fix build errors with makeViewport
Local makeViewport cannot be used in recently added tests
in vktImageMutableTests.
Fix: Remove local makeViewport and use one from vkTypeUtil.inl
Components: Vulkan
VK-GL-CTS issue: 124
Change-Id: I27c9c255d9e46a74a6528327339317ba74e5eb98
(cherry picked from commit
310b00cc9869e26e85e620b55b6ad3a7efeb8d90)
Pyry Haulos [Mon, 12 Jun 2017 20:52:42 +0000 (13:52 -0700)]
Framework support for VK_KHR_sampler_ycbcr_conversion
Change-Id: I749b92c79766f933ea34bb183d3d34c102e023c2
(cherry picked from commit
e5cf8de067694afde10873b6fdbd7907486e5611)
Mika Isojärvi [Thu, 4 May 2017 22:55:19 +0000 (15:55 -0700)]
Add support for 10 and 12bit packed unorm formats
10 and 12bit unsigned normalized values are packed into highers bits
of 16bit unsigned int.
Change-Id: I18a88547ba29003961bf0806a50cb17995c72f13
Components: Framework
(cherry picked from commit
07621ffcf0362606afeccf2c2deac35bc0f3668a)
Iago Toral Quiroga [Tue, 4 Jul 2017 08:59:45 +0000 (10:59 +0200)]
Add tests for VK_KHR_image_format_list
Components: Vulkan
VK-GL-CTS issue: 550
New tests:
dEQP-VK.image.mutable.*_format_list
Change-Id: Ic72304a65c76335c98764678e056f030fafba71f
(cherry picked from commit
dcd00f2f316fae0b86e1b03a8cf22774ce312c1d)