platform/upstream/gst-editing-services.git
5 years agotests: Avoid random timeout and let the launcher set it up for us
Thibault Saunier [Thu, 28 Mar 2019 16:08:55 +0000 (13:08 -0300)]
tests: Avoid random timeout and let the launcher set it up for us

5 years agoasset: s/unsure/ensure
Thibault Saunier [Thu, 28 Mar 2019 16:08:01 +0000 (13:08 -0300)]
asset: s/unsure/ensure

5 years agoasset: Plug a leak of EncodingProfiles
Thibault Saunier [Thu, 28 Mar 2019 16:06:37 +0000 (13:06 -0300)]
asset: Plug a leak of EncodingProfiles

5 years agoxml-formatter: Plug leaks of pending groups
Thibault Saunier [Thu, 28 Mar 2019 16:06:16 +0000 (13:06 -0300)]
xml-formatter: Plug leaks of pending groups

5 years agoasset: plug a GTask leak
Thibault Saunier [Thu, 28 Mar 2019 16:05:45 +0000 (13:05 -0300)]
asset: plug a GTask leak

5 years agoFix splitting control bindings leaks
Thibault Saunier [Thu, 28 Mar 2019 14:29:05 +0000 (11:29 -0300)]
Fix splitting control bindings leaks

5 years agotests: Fix a leak in the 'asset' test
Thibault Saunier [Thu, 28 Mar 2019 14:09:13 +0000 (11:09 -0300)]
tests: Fix a leak in the 'asset' test

5 years agotree: Fixup some GList leaks
Thibault Saunier [Thu, 28 Mar 2019 14:08:58 +0000 (11:08 -0300)]
tree: Fixup some GList leaks

5 years agouri-asset: Ensure that the discoverer stops on deinit.
Yeongjin Jeong [Mon, 15 Apr 2019 09:37:58 +0000 (18:37 +0900)]
uri-asset: Ensure that the discoverer stops on deinit.

Discoverer maintain a referernce on the discoverer object while
the async timeout callback is alive to prevent a potential crash
if the object is freed while the callback is pending.

But if g_main_context is released before calling the timeout callback,
the discoverer pointer which was weak referenced from GESUriClipAssetClass
will not be disposed because the discoverer object is not finalized.

5 years agoRelease 1.15.90
Tim-Philipp Müller [Wed, 10 Apr 2019 23:37:00 +0000 (00:37 +0100)]
Release 1.15.90

5 years agog-i: pass --quiet to g-ir-scanner
Tim-Philipp Müller [Sat, 23 Mar 2019 19:21:31 +0000 (19:21 +0000)]
g-i: pass --quiet to g-ir-scanner

This suppresses the annoying 'g-ir-scanner: link: cc ..' output
that we get even if everything works just fine.

We still get g-ir-scanner warnings and compiler warnings if
we pass this option.

5 years agovideosource: Expose video-direction child property
Jakub Adam [Tue, 19 Mar 2019 15:39:20 +0000 (16:39 +0100)]
videosource: Expose video-direction child property

5 years agovideosource: auto-flip the image according to image-orientation tag
Jakub Adam [Fri, 15 Mar 2019 15:24:16 +0000 (16:24 +0100)]
videosource: auto-flip the image according to image-orientation tag

If there's image-orientation tag, make sure the image is correctly
oriented before we scale it.

5 years agoFix autotools build
Tim-Philipp Müller [Sat, 16 Mar 2019 15:04:29 +0000 (15:04 +0000)]
Fix autotools build

5 years agoclip: Make sure to set the pasted clip start before adding to layer
Thibault Saunier [Fri, 8 Mar 2019 20:45:27 +0000 (17:45 -0300)]
clip: Make sure to set the pasted clip start before adding to layer

And handle the fact that adding to a layer can fail.

Also plug some leaks in the dispose method (and use the dispose
vmethod instead of finalize as appropriate).

5 years agoclip: Emit signals while splitting in a way the operation is undoable
Thibault Saunier [Fri, 8 Mar 2019 15:28:31 +0000 (12:28 -0300)]
clip: Emit signals while splitting in a way the operation is undoable

Basically if we do not emit a "duration" change of the clip being
splitted first when executing the 'reverse' operations would lead
to fully overallaping clips.

5 years agoReimplement the timeline editing API
Thibault Saunier [Fri, 1 Mar 2019 22:32:19 +0000 (19:32 -0300)]
Reimplement the timeline editing API

This is implemented on top of a Tree that represents the whole timeline.

SourceClips can not fully overlap anymore and the tests have been
updated to take that into account. Some new tests were added to verify
that behaviour in greater details

5 years agoSome copyright fixing
Thibault Saunier [Mon, 4 Mar 2019 00:18:53 +0000 (21:18 -0300)]
Some copyright fixing

5 years agotimeline: Rename group_id to stream_start_group_id
Thibault Saunier [Sun, 3 Mar 2019 23:59:12 +0000 (20:59 -0300)]
timeline: Rename group_id to stream_start_group_id

5 years agotests: Add utilities to print the timeline
Thibault Saunier [Fri, 1 Mar 2019 22:30:41 +0000 (19:30 -0300)]
tests: Add utilities to print the timeline

Making debugging tests simpler

5 years agotimeline-element: Add a method to retrieve layer priority
Thibault Saunier [Fri, 1 Mar 2019 22:08:39 +0000 (19:08 -0300)]
timeline-element: Add a method to retrieve layer priority

Each timeline element is in a layer (potentially spanning
over several), it is very often useful to retrieve an element
layer priority (from an app perspective more than the element
priority itself as that is a bit of an implementation detail
in the end).

Port tests to it

5 years agopython: Implement TimelineElement.__repr__
Thibault Saunier [Mon, 11 Feb 2019 23:30:31 +0000 (20:30 -0300)]
python: Implement TimelineElement.__repr__

5 years agoAdd API to get the GESEdge names
Thibault Saunier [Thu, 28 Feb 2019 16:56:50 +0000 (13:56 -0300)]
Add API to get the GESEdge names

5 years agoges: Move GESClipFlags to GESTimelineElementFlags
Thibault Saunier [Sat, 9 Feb 2019 21:59:08 +0000 (18:59 -0300)]
ges: Move GESClipFlags to GESTimelineElementFlags

Keeping it internal

And add an internal method to get layer priority for GESTimelineElements
(dirty implementation to make it simple for now)

5 years agotests:python: assertEquals is deprecated, use assertEqual
Thibault Saunier [Fri, 8 Feb 2019 20:50:04 +0000 (17:50 -0300)]
tests:python: assertEquals is deprecated, use assertEqual

5 years agolayer: factor out a method to remove an object without signaling it
Thibault Saunier [Fri, 8 Feb 2019 20:48:26 +0000 (17:48 -0300)]
layer: factor out a method to remove an object without signaling it

5 years agotests: python: Move assertTimelineTopology to the baseclass
Thibault Saunier [Fri, 8 Feb 2019 20:47:48 +0000 (17:47 -0300)]
tests: python: Move assertTimelineTopology to the baseclass

5 years agotimeline: No error when moving an object as part of the context
Thibault Saunier [Fri, 8 Feb 2019 20:46:31 +0000 (17:46 -0300)]
timeline: No error when moving an object as part of the context

It will just happen from the context

5 years agotimeline: Not being able to trim and object is an error
Thibault Saunier [Fri, 8 Feb 2019 20:44:40 +0000 (17:44 -0300)]
timeline: Not being able to trim and object is an error

So error out when that happens.

5 years agotimeline: Setting duration to the same value is valid
Thibault Saunier [Fri, 8 Feb 2019 20:43:34 +0000 (17:43 -0300)]
timeline: Setting duration to the same value is valid

And should not be advertised as if the operation failed.

5 years agotimeline: Do not ripple if resulting duration would be 0
Thibault Saunier [Fri, 8 Feb 2019 20:37:39 +0000 (17:37 -0300)]
timeline: Do not ripple if resulting duration would be 0

5 years agoclip: Add a method to get the priority of the layer it is in
Thibault Saunier [Fri, 8 Feb 2019 19:44:39 +0000 (16:44 -0300)]
clip: Add a method to get the priority of the layer it is in

Just an helper method to get the 'priority of a the clip'

5 years agoclip: Rollback moving clips when moving a contained TrackElement fails
Thibault Saunier [Fri, 8 Feb 2019 19:05:18 +0000 (16:05 -0300)]
clip: Rollback moving clips when moving a contained TrackElement fails

And fix unit tests to match the correct behaviour

5 years agoShorten GES_FORMAT output
Thibault Saunier [Sat, 9 Feb 2019 03:07:08 +0000 (00:07 -0300)]
Shorten GES_FORMAT output

5 years agoclip: Make sure to remove and re add effects when adding clips to layer
Thibault Saunier [Thu, 21 Feb 2019 20:24:51 +0000 (17:24 -0300)]
clip: Make sure to remove and re add effects when adding clips to layer

And make re add them in the same order.

And enhance tests to check that

5 years agosource: No checks when linking default elements
Thibault Saunier [Sat, 2 Mar 2019 01:57:48 +0000 (22:57 -0300)]
source: No checks when linking default elements

5 years agonlesource: Use gst_element_call_async as appropriate
Thibault Saunier [Fri, 15 Mar 2019 21:31:30 +0000 (18:31 -0300)]
nlesource: Use gst_element_call_async as appropriate

5 years agonlesource: Protect seeks from tear down
Thibault Saunier [Fri, 15 Mar 2019 20:07:06 +0000 (17:07 -0300)]
nlesource: Protect seeks from tear down

Otherwise there is a race where we trigger the seek at the exact
same time the composition is being teared down potentially leading
to basesrc restarting its srcpad task which ends up being leaked.

Fixes ges.playback.scrub_backward_seeking.test_title.audio_video.vorbis_theora_ogg
and probably all its friends timeouting with the following stack trace:

     (gdb) t a a bt

     Thread 4 (Thread 0x7f5962acd700 (LWP 19997)):
     #0  0x00007f5976713efd in syscall () at ../sysdeps/unix/sysv/linux/x86_64/syscall.S:38
     #1  0x00007f5976a9d3f3 in g_cond_wait (cond=cond@entry=0x7f5938125410, mutex=mutex@entry=0x7f59381253c8) at gthread-posix.c:1402
     #2  0x00007f5976c9e26b in gst_task_func (task=0x7f59381253b0 [GstTask]) at ../subprojects/gstreamer/gst/gsttask.c:313
     #3  0x00007f5976a7ecb3 in g_thread_pool_thread_proxy (data=<optimized out>) at gthreadpool.c:307
     #4  0x00007f5976a7e2aa in g_thread_proxy (data=0x7f5954071d40) at gthread.c:784
     #5  0x00007f59767ea58e in start_thread (arg=<optimized out>) at pthread_create.c:486
     #6  0x00007f59767196a3 in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95

     Thread 3 (Thread 0x7f5963fff700 (LWP 19995)):
     #0  0x00007f597670e421 in __GI___poll (fds=0xe32da0, nfds=2, timeout=-1) at ../sysdeps/unix/sysv/linux/poll.c:29
     #1  0x00007f5976a553a6 in g_main_context_poll (priority=<optimized out>, n_fds=2, fds=0xe32da0, timeout=<optimized out>, context=0xe31ff0) at gmain.c:4221
     #2  0x00007f5976a553a6 in g_main_context_iterate (context=0xe31ff0, block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at gmain.c:3915
     #3  0x00007f5976a55762 in g_main_loop_run (loop=0xe32130) at gmain.c:4116
     #4  0x00007f59768db10a in gdbus_shared_thread_func (user_data=0xe31fc0) at gdbusprivate.c:275
     #5  0x00007f5976a7e2aa in g_thread_proxy (data=0xe1b8a0) at gthread.c:784
     #6  0x00007f59767ea58e in start_thread (arg=<optimized out>) at pthread_create.c:486
     #7  0x00007f59767196a3 in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95

     Thread 2 (Thread 0x7f5968dcc700 (LWP 19994)):
     #0  0x00007f597670e421 in __GI___poll (fds=0xe1bcc0, nfds=1, timeout=-1) at ../sysdeps/unix/sysv/linux/poll.c:29
     #1  0x00007f5976a553a6 in g_main_context_poll (priority=<optimized out>, n_fds=1, fds=0xe1bcc0, timeout=<optimized out>, context=0xe1b350) at gmain.c:4221
     #2  0x00007f5976a553a6 in g_main_context_iterate (context=context@entry=0xe1b350, block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at gmain.c:3915
     #3  0x00007f5976a554d0 in g_main_context_iteration (context=0xe1b350, may_block=may_block@entry=1) at gmain.c:3981
     #4  0x00007f5976a55521 in glib_worker_main (data=<optimized out>) at gmain.c:5861
     #5  0x00007f5976a7e2aa in g_thread_proxy (data=0xe1b800) at gthread.c:784
     #6  0x00007f59767ea58e in start_thread (arg=<optimized out>) at pthread_create.c:486
     #7  0x00007f59767196a3 in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95

     Thread 1 (Thread 0x7f5975df4fc0 (LWP 19993)):
     #0  0x00007f5976713efd in syscall () at ../sysdeps/unix/sysv/linux/x86_64/syscall.S:38
     #1  0x00007f5976a9d3f3 in g_cond_wait (cond=cond@entry=0xe34020, mutex=0xe39b80) at gthread-posix.c:1402
     #2  0x00007f5976a7f41c in g_thread_pool_free (pool=0xe34000, immediate=0, wait_=<optimized out>) at gthreadpool.c:776
     #3  0x00007f5976c9f1ca in default_cleanup (pool=0xe256b0 [GstTaskPool]) at ../subprojects/gstreamer/gst/gsttaskpool.c:89
     #4  0x00007f5976c9e32d in init_klass_pool (klass=<optimized out>) at ../subprojects/gstreamer/gst/gsttask.c:161
     #5  0x00007f5976c9e502 in gst_task_cleanup_all () at ../subprojects/gstreamer/gst/gsttask.c:381
     #6  0x00007f5976c214f4 in gst_deinit () at ../subprojects/gstreamer/gst/gst.c:1095
     #7  0x000000000040394f in main (argc=6, argv=<optimized out>) at ../subprojects/gst-editing-services/tools/ges-launch.c:94

5 years agomeson: Build benchmarks
Thibault Saunier [Fri, 8 Feb 2019 21:26:19 +0000 (18:26 -0300)]
meson: Build benchmarks

5 years agoasset-uri: Create a specific discoverer when discovering sync
Thibault Saunier [Mon, 11 Mar 2019 22:56:09 +0000 (19:56 -0300)]
asset-uri: Create a specific discoverer when discovering sync

To allow 'reintrancy'.

This was a 'regression' introduced in bad64296d9b497a13f5f7fe91d568d85ed236265

Fixes https://gitlab.gnome.org/GNOME/pitivi/issues/2278

5 years agoMark ges_timeline_load_from_uri as deprecated
Pat DeSantis [Sat, 23 Feb 2019 01:31:06 +0000 (17:31 -0800)]
Mark ges_timeline_load_from_uri as deprecated

5 years agoUpdate deprecation warning to match GTK style
Pat DeSantis [Thu, 21 Feb 2019 04:17:55 +0000 (20:17 -0800)]
Update deprecation warning to match GTK style

5 years agoMark ges_formatter_save_to_uri as deprecated
Pat DeSantis [Thu, 21 Feb 2019 01:17:14 +0000 (17:17 -0800)]
Mark ges_formatter_save_to_uri as deprecated

5 years agotests: Add inconsistent init/deinit test case
Seungha Yang [Tue, 29 Jan 2019 04:45:49 +0000 (13:45 +0900)]
tests: Add inconsistent init/deinit test case

5 years agoges: Enhance ges_{init/deinit} documentation
Seungha Yang [Mon, 28 Jan 2019 11:45:11 +0000 (20:45 +0900)]
ges: Enhance ges_{init/deinit} documentation

Add some init/deinit related comment and make assertion when
ges_deinit() is called from unexpected thread.

5 years agotests:python: Use proper GES.Project constructor
Thibault Saunier [Wed, 6 Feb 2019 22:49:14 +0000 (19:49 -0300)]
tests:python: Use proper GES.Project constructor

Avoiding a g_critical

5 years agonlecomposition: Suppress error from child during sync state with parent
Seungha Yang [Fri, 8 Feb 2019 04:54:06 +0000 (13:54 +0900)]
nlecomposition: Suppress error from child during sync state with parent

This commit is to ensure cleanup internal elements on state change failure.

nlecomposition posts its own error message after cleanup child.
If we don't suppress child error, meanwhile, an application
triggered downward state change (resulting from child error message)
might be able to reach nlecomposition before internal cleaning child up.
That eventually results to downward state change failure.

5 years agonlesource: Don't leak pending seek event on dispose
Seungha Yang [Tue, 5 Feb 2019 08:29:00 +0000 (17:29 +0900)]
nlesource: Don't leak pending seek event on dispose

5 years agonlecomposition: Don't keep sync state of child on activation failure
Seungha Yang [Fri, 1 Feb 2019 06:37:42 +0000 (15:37 +0900)]
nlecomposition: Don't keep sync state of child on activation failure

This will result in downward state change failure eventually
when user is finalizing top level (i.g., gespipeline) bin.

5 years agoexamples: add gessrc example binary to .gitignore
Tim-Philipp Müller [Mon, 4 Mar 2019 11:09:33 +0000 (11:09 +0000)]
examples: add gessrc example binary to .gitignore

5 years agogesdemux: don't use deprecated gst_uri_construct()
Tim-Philipp Müller [Mon, 4 Mar 2019 11:07:51 +0000 (11:07 +0000)]
gesdemux: don't use deprecated gst_uri_construct()

Fixes #64

5 years agoBack to development
Tim-Philipp Müller [Mon, 4 Mar 2019 09:14:25 +0000 (09:14 +0000)]
Back to development

5 years agoges: Link ges plugin to libgstpbutils
Sebastian Dröge [Thu, 28 Feb 2019 11:09:38 +0000 (13:09 +0200)]
ges: Link ges plugin to libgstpbutils

/usr/bin/ld: .libs/libgstges_la-gesdemux.o: in function `ges_timeline_new_from_uri_from_main_thread':
./plugins/ges/gesdemux.c:279: undefined reference to `gst_discoverer_new'
/usr/bin/ld: ./plugins/ges/gesdemux.c:288: undefined reference to `gst_discoverer_start'

5 years agoRelease 1.15.2
Tim-Philipp Müller [Tue, 26 Feb 2019 11:59:49 +0000 (11:59 +0000)]
Release 1.15.2

5 years agoexamples: add new gessrc example, so sourcefile gets disted
Tim-Philipp Müller [Tue, 26 Feb 2019 14:12:13 +0000 (14:12 +0000)]
examples: add new gessrc example, so sourcefile gets disted

5 years agoplugins: add autotools build for new ges plugin
Tim-Philipp Müller [Tue, 26 Feb 2019 13:57:17 +0000 (13:57 +0000)]
plugins: add autotools build for new ges plugin

5 years agoexamples: Add an example about using keyframes in python
Thibault Saunier [Thu, 21 Feb 2019 01:11:54 +0000 (22:11 -0300)]
examples: Add an example about using keyframes in python

5 years agoges-meta-container: Fix g-i annotation
Seungha Yang [Mon, 11 Feb 2019 09:26:04 +0000 (18:26 +0900)]
ges-meta-container: Fix g-i annotation

ges-meta-container.c:516: Warning: GES: invalid "allow-none" annotation:
only valid for pointer types and out parameters

5 years agomisc: Fix warnings on Cerbero's ancient MinGW
Nirbheek Chauhan [Tue, 5 Feb 2019 19:00:35 +0000 (00:30 +0530)]
misc: Fix warnings on Cerbero's ancient MinGW

gesdemux.c:297:3: error: value computed is not used [-Werror=unused-value]

5 years agoFix segfault when adding clips to group outside a timeline
Thibault Saunier [Wed, 23 Jan 2019 12:07:58 +0000 (09:07 -0300)]
Fix segfault when adding clips to group outside a timeline

Making sure that objects are inside a timeline before adding/removing them from it

Fixes https://gitlab.freedesktop.org/gstreamer/gst-editing-services/issues/35

5 years agotests: Fix usage of undefined class
Thibault Saunier [Wed, 30 Jan 2019 18:58:33 +0000 (15:58 -0300)]
tests: Fix usage of undefined class

5 years agolauncher: Add options to set tracks restriction caps
Thibault Saunier [Mon, 28 Jan 2019 22:09:03 +0000 (19:09 -0300)]
launcher: Add options to set tracks restriction caps

5 years agotests: ges: Fix various leak
Yeongjin Jeong [Sun, 27 Jan 2019 15:55:27 +0000 (00:55 +0900)]
tests: ges: Fix various leak

5 years agolayer: Fix asset leak
Yeongjin Jeong [Sat, 26 Jan 2019 10:50:48 +0000 (19:50 +0900)]
layer: Fix asset leak

5 years agoeffect: Fix string leak
Yeongjin Jeong [Sat, 26 Jan 2019 07:44:09 +0000 (16:44 +0900)]
effect: Fix string leak

5 years agouri-asset: Implement dispose vmethod for GESUriSourceAsset
Yeongjin Jeong [Tue, 29 Jan 2019 02:52:43 +0000 (11:52 +0900)]
uri-asset: Implement dispose vmethod for GESUriSourceAsset

... and fix DiscovererStreamInfo leak

5 years agouri-asset: Don't forget to unref DiscovererInfo on dispose
Yeongjin Jeong [Sat, 26 Jan 2019 07:27:27 +0000 (16:27 +0900)]
uri-asset: Don't forget to unref DiscovererInfo on dispose

Dispose() must unref DiscovererInfo ownership
taken by ges_uri_clip_asset_set_info().

5 years agovideo-transition: Fix GstPad leak
Yeongjin Jeong [Fri, 25 Jan 2019 09:21:43 +0000 (18:21 +0900)]
video-transition: Fix GstPad leak

Returned Gstpad by link_element_to_mixer_with_smpte()
has increased refcount in ges_smart_mixer_get_mixer_pad().

5 years agotimeline: Better handle loading inconsistent timelines
Alexandru Băluț [Tue, 27 Nov 2018 03:55:17 +0000 (04:55 +0100)]
timeline: Better handle loading inconsistent timelines

Auto transition when having 3 overlapping clips in a same point in the
timeline is not supported as we can't handle it in a nice way. Before we
to avoid creating 2 overlapping transitions (which is plain broken in
NLE) were completely disabling `auto-transition` and removing all
auto-transitions in the timeline but this is pretty weird for the end
user. This commit changes and now makes sure 2 transitions are not
created in the same place.

Also cleanup previous test case.

5 years agos/accured/occurred/g
Thibault Saunier [Fri, 18 Jan 2019 20:25:11 +0000 (17:25 -0300)]
s/accured/occurred/g

5 years agoxml-formatter: Minor debug enhancement
Thibault Saunier [Fri, 18 Jan 2019 20:12:42 +0000 (17:12 -0300)]
xml-formatter: Minor debug enhancement

5 years agoplugins: Add an a gesdemux element to 'demux' serialized timelines
Thibault Saunier [Fri, 18 Jan 2019 12:52:47 +0000 (09:52 -0300)]
plugins: Add an a gesdemux element to 'demux' serialized timelines

5 years agoplugins: implement a gessrc element useable from playbin
Thibault Saunier [Sat, 14 Mar 2015 20:52:47 +0000 (20:52 +0000)]
plugins: implement a gessrc element useable from playbin

This is a new simple GstBin that can handle the ges:// uris
and will directly expose the srcppads of the tracks present in the
timeline.

5 years agouri-asset: Use the same code path for sync discovery as the async one
Thibault Saunier [Fri, 18 Jan 2019 18:45:39 +0000 (15:45 -0300)]
uri-asset: Use the same code path for sync discovery as the async one

And start handling relocated assets.

Also expose the discoverer callback as a vmethod so that we can
overridde the discoverer when necessary (to handle discovering of
timeline through gesdemux for example)

5 years agonlecomposition: Get overall pipeline position by recursing up
Thibault Saunier [Thu, 17 Jan 2019 18:12:42 +0000 (15:12 -0300)]
nlecomposition: Get overall pipeline position by recursing up

And handle NLEComposition inside NLEComposition

Fixes https://gitlab.freedesktop.org/gstreamer/gst-editing-services/issues/39

5 years agovideomixer: Drop allocation query after the compositor
Thibault Saunier [Sun, 30 Sep 2018 20:22:13 +0000 (17:22 -0300)]
videomixer: Drop allocation query after the compositor

Working around https://gitlab.freedesktop.org/gstreamer/gstreamer/issues/310

5 years agolayer: Resort clips before syncing priorities
Thibault Saunier [Mon, 28 Jan 2019 21:59:40 +0000 (18:59 -0300)]
layer: Resort clips before syncing priorities

We set the priorities making the assumption that `start_clips` is properly
ordered by start!

Fixes https://gitlab.gnome.org/GNOME/pitivi/issues/2254

5 years agotests: asset: Add test async asset request with custom GMainContext
Seungha Yang [Mon, 28 Jan 2019 03:58:06 +0000 (12:58 +0900)]
tests: asset: Add test async asset request with custom GMainContext

... and test call ges_{init/deinit} multiple times in a unit test.

5 years agoRevert "ges: Add missing type unref on deinit"
Seungha Yang [Mon, 28 Jan 2019 08:22:10 +0000 (17:22 +0900)]
Revert "ges: Add missing type unref on deinit"

This reverts commit e939cfebaf4deeabf21ba799ddc3eeaa87e7cf9a.

Class might not be initialized if they were already registered
when ges_init() was called, but were not created until ges_deinit() called.

5 years agoges: Add check sync/async discoverer
Seungha Yang [Mon, 28 Jan 2019 08:12:54 +0000 (17:12 +0900)]
ges: Add check sync/async discoverer

To support ges_{init/deinit} multiple times in a process,
there should be a method for setting up internal object/table of
GESUriClipAssetClass. because *_class_init() will be called
only once in process lifecycle.

5 years agouri-asset: Add missing GHashTable cleanup
Seungha Yang [Mon, 28 Jan 2019 08:15:19 +0000 (17:15 +0900)]
uri-asset: Add missing GHashTable cleanup

... and use g_object_unref() for GFile object, it's not a GstObject.

5 years agoges: Print initialize error reasons
Seungha Yang [Mon, 28 Jan 2019 07:34:15 +0000 (16:34 +0900)]
ges: Print initialize error reasons

5 years agotests: asset: Remove out-of-date comment
Seungha Yang [Mon, 28 Jan 2019 03:19:30 +0000 (12:19 +0900)]
tests: asset: Remove out-of-date comment

5 years agotests: asset: Remove pointless gst_init()
Seungha Yang [Mon, 28 Jan 2019 03:17:00 +0000 (12:17 +0900)]
tests: asset: Remove pointless gst_init()

It's done by GST_CHECK_MAIN() already

5 years agotests: init/deinit per test case
Seungha Yang [Mon, 28 Jan 2019 02:24:29 +0000 (11:24 +0900)]
tests: init/deinit per test case

... in order to verify init/deinit pair.

5 years agoges: Simplify init/deinit flag
Seungha Yang [Mon, 28 Jan 2019 02:07:36 +0000 (11:07 +0900)]
ges: Simplify init/deinit flag

In theory, GES can be init/deinit multiple times in a process.
To simplify that use-case, let's trace only "ges_initialized" flag.

5 years agouri-asset: Add ges_uri_clip_asset_finish to get better introspection
Corentin Noël [Mon, 21 Jan 2019 10:53:44 +0000 (11:53 +0100)]
uri-asset: Add ges_uri_clip_asset_finish to get better introspection

Vala requires a matching _finish function to correctly bind the method with the right finish method.

5 years agotimeline: fix two issues in the documentation
Corentin Noël [Mon, 21 Jan 2019 13:14:06 +0000 (14:14 +0100)]
timeline: fix two issues in the documentation

5 years agoxml-formatter: Do not forget to serialize clips metadata
Thibault Saunier [Tue, 15 Jan 2019 12:59:59 +0000 (09:59 -0300)]
xml-formatter: Do not forget to serialize clips metadata

5 years agoxml-formatter: Serialize groups metadatas
Thibault Saunier [Tue, 15 Jan 2019 12:38:14 +0000 (09:38 -0300)]
xml-formatter: Serialize groups metadatas

5 years agouri-asset: Don't leak GstDiscovererInfo
Seungha Yang [Mon, 14 Jan 2019 15:15:28 +0000 (00:15 +0900)]
uri-asset: Don't leak GstDiscovererInfo

5 years agouri-asset: Impl. dispose vfunc
Seungha Yang [Mon, 14 Jan 2019 15:13:24 +0000 (00:13 +0900)]
uri-asset: Impl. dispose vfunc

... and fix GList/GESAsset leak

5 years agotransition-clip: Don't leak GESAsset
Seungha Yang [Mon, 14 Jan 2019 14:38:19 +0000 (23:38 +0900)]
transition-clip: Don't leak GESAsset

Returned GESAsset from ges_asset_request should be freed since
ges_extractable_set_asset doesn't take ownership

5 years agoframepositioner: Fix invalid memory access
Seungha Yang [Mon, 14 Jan 2019 13:14:18 +0000 (22:14 +0900)]
framepositioner: Fix invalid memory access

The GstFramePositioner might be finalized before the notify callback

Without this commit,
gst-editing-services / ges_basic / test_ges_timeline_remove_track
can reproduce the case.

5 years agonleoperation: Fix GstPad leak
Seungha Yang [Mon, 14 Jan 2019 06:06:26 +0000 (15:06 +0900)]
nleoperation: Fix GstPad leak

Returned GstPad by nle_object_remove_ghost_pad() has increased
refcount.

5 years agonleghostpad: Fix GstEvent leak
Seungha Yang [Mon, 14 Jan 2019 05:10:32 +0000 (14:10 +0900)]
nleghostpad: Fix GstEvent leak

5 years agonlecomposition: Don't leak GNode
Seungha Yang [Mon, 14 Jan 2019 03:52:47 +0000 (12:52 +0900)]
nlecomposition: Don't leak GNode

Clear the last node before update

5 years agotests: nle: Fix various leak
Seungha Yang [Mon, 14 Jan 2019 04:22:13 +0000 (13:22 +0900)]
tests: nle: Fix various leak

Don't leak GError and GstPad object

5 years agotests: nle: Fix GList leak
Seungha Yang [Mon, 14 Jan 2019 02:34:20 +0000 (11:34 +0900)]
tests: nle: Fix GList leak

5 years agotests: ges: Fix various leak
Seungha Yang [Sat, 12 Jan 2019 15:12:42 +0000 (00:12 +0900)]
tests: ges: Fix various leak