platform/core/uifw/dali-toolkit.git
7 months agoLet we use OrderedSet for VectorAnimationManager / SceneView 43/309943/3
Eunki, Hong [Thu, 18 Apr 2024 08:20:54 +0000 (17:20 +0900)]
Let we use OrderedSet for VectorAnimationManager / SceneView

Some containers that triggered only one times could be optimized by OrderedSet feature.

Let we make Add/Remove time faster.

Change-Id: I3a4864a6e76671fa89f851b3b4382e74893ba130
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
7 months agoMerge "Add offset to text outline" into devel/master
Bowon Ryu [Mon, 29 Apr 2024 01:18:40 +0000 (01:18 +0000)]
Merge "Add offset to text outline" into devel/master

7 months agoAdd offset to text outline 34/310334/2
Bowon Ryu [Thu, 25 Apr 2024 11:28:13 +0000 (20:28 +0900)]
Add offset to text outline

Change-Id: I280ed148384325cfa83e2d48fae15a387bc81fcd
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
7 months agoDALi Version 2.3.21 93/310393/1 dali_2.3.21
Richard Huang [Fri, 26 Apr 2024 09:42:59 +0000 (10:42 +0100)]
DALi Version 2.3.21

Change-Id: Iee3f73027b8d239c187ed2aef18c7fa1501188aa

8 months agoFixes analysis hub issues 61/310161/1
Adam Bialogonski [Tue, 23 Apr 2024 08:16:51 +0000 (09:16 +0100)]
Fixes analysis hub issues

Change-Id: I1b55b6d635bec59ecf843fc56574044a2ccfcbab
Signed-off-by: Adam Bialogonski <adam.b@samsung.com>
8 months agoMerge "[AT-SPI] Use Accessible::IsHighlighted()" into devel/master
Lukasz Oleksak [Mon, 22 Apr 2024 12:22:33 +0000 (12:22 +0000)]
Merge "[AT-SPI] Use Accessible::IsHighlighted()" into devel/master

8 months agoMerge "Add INSET Property to TextField and TextEditor" into devel/master
Chihun Jeong [Mon, 22 Apr 2024 09:02:42 +0000 (09:02 +0000)]
Merge "Add INSET Property to TextField and TextEditor" into devel/master

8 months agoAdd INSET Property to TextField and TextEditor 73/310073/2
ANZ1217 [Mon, 22 Apr 2024 03:53:20 +0000 (12:53 +0900)]
Add INSET Property to TextField and TextEditor

Add the REMOVE_FRONT_INSET and REMOVE_BACK_INSET properties
to TextField and TextEditor as well, which were in TextLabel.

Change-Id: Ie5a417f22fb24423fde139e57c078dc45337099f

8 months agoMerge "Text controller checks data type of the clipboard" into devel/master
Bowon Ryu [Mon, 22 Apr 2024 05:07:12 +0000 (05:07 +0000)]
Merge "Text controller checks data type of the clipboard" into devel/master

8 months agoText controller checks data type of the clipboard 30/309930/2
Bowon Ryu [Thu, 18 Apr 2024 07:46:55 +0000 (16:46 +0900)]
Text controller checks data type of the clipboard

IsClipboardEmpty works meaningfully.
Temporary code has been applied to paste html type.
Once multiple types and data can be stored in the clipboard, this code should be removed.

Change-Id: I29b279acf19dd1c3397568b55e0567d314c41990
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
8 months agoDo not create unneccessary sampler 51/309951/4
Eunki, Hong [Thu, 18 Apr 2024 09:02:25 +0000 (18:02 +0900)]
Do not create unneccessary sampler

We can 'skip' sampler for TextureSet if we want to use default wrap mode.

So usual cases, we don't need to create and set Sampler objects.

Change-Id: Ic1d0cf21d80e62f5bdf8209402e2a3a4612bd598
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
8 months agoMerge "Remove TextureManager / VectorAnimationManaver lifecycle observing" into devel...
Eunki Hong [Sat, 20 Apr 2024 07:46:13 +0000 (07:46 +0000)]
Merge "Remove TextureManager / VectorAnimationManaver lifecycle observing" into devel/master

8 months agoMerge "Less call mAnimatedImageLoading.GetImageCount() who might load file synchronou...
Eunki Hong [Sat, 20 Apr 2024 07:44:15 +0000 (07:44 +0000)]
Merge "Less call mAnimatedImageLoading.GetImageCount() who might load file synchronously" into devel/master

8 months agoDALi Version 2.3.20 29/310029/1 dali_2.3.20
David Steele [Fri, 19 Apr 2024 09:47:18 +0000 (10:47 +0100)]
DALi Version 2.3.20

Change-Id: If3d8b1e01d9c5a1c9061b59be05c05f52c47064c

8 months agoRemove TextureManager / VectorAnimationManaver lifecycle observing 23/310023/4
Eunki, Hong [Fri, 19 Apr 2024 07:43:38 +0000 (16:43 +0900)]
Remove TextureManager / VectorAnimationManaver lifecycle observing

Since we can use Dali::Adaptor::IsAvailable(), we don't need to check
whether manager itself is alive or not.

Since both of them are member value of VisualFactoryCache, and VisualFactory
is singletone class what will be destructed at Adaptor stop timing,
Dali::Adaptor::IsAvailabe() is enough.

Add/Remove observer will give some overhead for usual cases.
So just remove it, and check adaptor vailables intead.

Change-Id: Ib26df2d607d2871626cda956d86524f74afd424b
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
8 months agoLess call mAnimatedImageLoading.GetImageCount() who might load file synchronously 93/309993/2
Eunki, Hong [Fri, 19 Apr 2024 04:14:36 +0000 (13:14 +0900)]
Less call mAnimatedImageLoading.GetImageCount() who might load file synchronously

Since AnimatedImageLoading might not load imagefile if we use
cached texture.

In this case, If we try to call 'GetImageCount()' or similar API, it will
try to load file synchronously, what user never notify.

For example, when we call DoCreatePropertyMap, it will call that API
what we can use some other cached value.

Change-Id: I77d30b985efd86d09663dfd51e885ba6227adbc9
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
8 months ago[AT-SPI] Use Accessible::IsHighlighted() 55/309955/5
Artur Świgoń [Thu, 18 Apr 2024 09:28:12 +0000 (11:28 +0200)]
[AT-SPI] Use Accessible::IsHighlighted()

This helper allows to simplify multiple comparisons of Self() to
GetCurrentlyHighlightedActor() to simply checking IsHighlighted().

Some new usages of IsHighlighted() are also introduced before event
emission in order to reduce D-Bus traffic.

Change-Id: I5d8906db22c84764de3e8df631df4d4cf8062c2f

8 months agoDisconnect DevelWindow::VisibilityChangedSignal when off scene 70/309870/1
Seungho Baek [Wed, 17 Apr 2024 12:48:50 +0000 (21:48 +0900)]
Disconnect DevelWindow::VisibilityChangedSignal when off scene

Change-Id: I0b7faee8af24b04a496c4f5695767b454493fce6
Signed-off-by: Seungho Baek <sbsh.baek@samsung.com>
8 months agoMerge "Remove BaseHandle / BaseObject TypeTraits is trivialgit" into devel/master
Eunki Hong [Wed, 17 Apr 2024 06:36:26 +0000 (06:36 +0000)]
Merge "Remove BaseHandle / BaseObject TypeTraits is trivialgit" into devel/master

8 months agoMerge "Fix potential of UTC fail after notify patch merged" into devel/master
Eunki Hong [Wed, 17 Apr 2024 06:11:19 +0000 (06:11 +0000)]
Merge "Fix potential of UTC fail after notify patch merged" into devel/master

8 months agoReduce the number of UpdateOnce call after rasterization 05/309705/1
Eunki, Hong [Tue, 16 Apr 2024 01:44:15 +0000 (10:44 +0900)]
Reduce the number of UpdateOnce call after rasterization

Previous code request UpdateOnce by each visuals.
But this don't need to spend the number of requests.
So let we just use only one single request API for it.

Change-Id: I5b11ee7ad19dc7c32945c0cfc637f7c65cfe3a77
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
8 months agoFix potential of UTC fail after notify patch merged 27/309627/5
Eunki Hong [Sat, 13 Apr 2024 16:49:27 +0000 (01:49 +0900)]
Fix potential of UTC fail after notify patch merged

A lots of vector animated image visual UTC failed due to 'ForceRenderOnce' required event thread trigger.

Since force render once might execute with 'load complete' or 'animation finished' signal,
Several UTC might not synchronized.

Let we change those cases and now works well anyway.

List of UTC failed:

Test case UtcDaliAnimatedVectorImageVisualGetPropertyMap01 failed: 1
Test case UtcDaliVisualFactoryGetAnimatedVectorImageVisual03 failed: 1
Test case UtcDaliVisualFactoryGetAnimatedVectorImageVisual04 failed: 1
Test case UtcDaliAnimatedVectorImageVisualPlayRange failed: 1
Test case UtcDaliAnimatedVectorImageVisualUpdateProperty failed: 1
Test case UtcDaliAnimatedVectorImageVisualNotifyAfterRasterization failed: 1

For example log:

[Pass case]
BEGIN: AsyncTask[VectorAnimationTask] Process
Add event trigger callback with id : 0
Trigger!
END: AsyncTask[VectorAnimationTask] Process
Adaptor::UnregisterProcessor : VectorAnimationManager
BEGIN: AsyncTask[VectorAnimationTask] Process
mNeedForceRenderOnceTrigger due to mCurrentFrame is not start (0 -> 1)
Add event trigger callback with id : 1110
END: AsyncTask[VectorAnimationTask] Process
INFO: scene-graph-scene.cpp: SetSurfaceRect(154) > update surfce rect in scene-graph, from width[0], height[0], to width[480], height[800]. Changed count [1]
Execute callback with id : 0
Execute callback with id : 1110
Trigger finished
Adaptor::RegisterProcessor : VectorAnimationManager
Adaptor::UnregisterProcessor : VectorAnimationManager
BEGIN: AsyncTask[VectorAnimationTask] Process
END: AsyncTask[VectorAnimationTask] Process

[Fail case]
BEGIN: AsyncTask[VectorAnimationTask] Process
Add event trigger callback with id : 0
Trigger!
END: AsyncTask[VectorAnimationTask] Process
Execute callback with id : 0
Trigger finished
BEGIN: AsyncTask[VectorAnimationTask] Process
mNeedForceRenderOnceTrigger due to mCurrentFrame is not start (0 -> 1)
Add event trigger callback with id : 1110
Trigger!
END: AsyncTask[VectorAnimationTask] Process
Adaptor::RegisterProcessor : VectorAnimationManager
Adaptor::UnregisterProcessor : VectorAnimationManager
Warning, TestGraphicsReflection::GetSamplers is unimplemented

Execute callback with id : 1110
Trigger finished
Test failed in utc-Dali-AnimatedVectorImageVisual.cpp:1452, checking 1 == 0

Change-Id: I7d7cc5a78428bc3e6f192a75def142ace0f92cb6
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
8 months agoMerge "(Vector) Add NOTIFY_AFTER_RASTERIZATION property for low fps file + Use Update...
David Steele [Mon, 15 Apr 2024 11:40:01 +0000 (11:40 +0000)]
Merge "(Vector) Add NOTIFY_AFTER_RASTERIZATION property for low fps file + Use UpdateOnce instead of KeepRendering" into devel/master

8 months agoMerge "Add imgSrc to GetAttribute return map if available" into devel/master
Youngsun Suh [Mon, 15 Apr 2024 08:03:54 +0000 (08:03 +0000)]
Merge "Add imgSrc to GetAttribute return map if available" into devel/master

8 months agoAdd imgSrc to GetAttribute return map if available 78/309578/6
Youngsun Suh [Fri, 12 Apr 2024 07:19:18 +0000 (16:19 +0900)]
Add imgSrc to GetAttribute return map if available

Change-Id: I9f9df3905ab13442e5ff12a04414484a25f3d41b

8 months ago(Vector) Add NOTIFY_AFTER_RASTERIZATION property for low fps file + Use UpdateOnce... 27/309127/9
Eunki, Hong [Fri, 5 Apr 2024 03:16:25 +0000 (12:16 +0900)]
(Vector) Add NOTIFY_AFTER_RASTERIZATION property for low fps file + Use UpdateOnce instead of KeepRendering

Let we change renderer rendering behavior is IF_REQUIRED.

It will be useful if app try to render lottie file which has less than 60fps.

+

Let we use UpdateOnce() API for force-rendering instead of KeepRendering().

KeepRendering will make ProcessCoreEvents forcely, which might not be need for animated vector cases.

Change-Id: Iaece9a5ff9e135acfdac404f68bdc690e6a7be8c
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
8 months agoRemove BaseHandle / BaseObject TypeTraits is trivialgit 47/309647/1
Eunki, Hong [Mon, 15 Apr 2024 04:23:21 +0000 (13:23 +0900)]
Remove BaseHandle / BaseObject TypeTraits is trivialgit

Since Dali::Vector doesn't call destructor, BaseHandle / BaseObject
shoudl 'not' be used as Dali::Vector.

To avoid some memory leak mistake, let we remove some mis implementations

Change-Id: I001993d10812bddc0beb888d41e6bc316301484b
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
8 months agoForce call KeepRendering when lottie animation stopped, or frame changed 12/309612/4
Eunki, Hong [Fri, 12 Apr 2024 13:07:07 +0000 (22:07 +0900)]
Force call KeepRendering when lottie animation stopped, or frame changed

Change-Id: Ie9c44a8a3997a644080c934d36e99c8aee804bf2
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
8 months agoRevert "Do not call malloc during terminate" 02/309602/1
Eunki, Hong [Fri, 12 Apr 2024 10:25:43 +0000 (19:25 +0900)]
Revert "Do not call malloc during terminate"

This reverts commit cc221e4f8a66b6748e5c737e5dbde82c68db8d48.

Change-Id: Ib0dd44b9ca2a82738bfb1cc1a12528803327b1fa

8 months agoDALi Version 2.3.19 91/309591/1 dali_2.3.19
Richard Huang [Fri, 12 Apr 2024 09:52:26 +0000 (10:52 +0100)]
DALi Version 2.3.19

Change-Id: I496a510356a3c578585d9898198d4080f980f1e7

8 months agoFix Crash when the InsertText event is executed multiple times between Relayout. 15/309315/3
ANZ1217 [Mon, 8 Apr 2024 11:46:52 +0000 (20:46 +0900)]
Fix Crash when the InsertText event is executed multiple times between Relayout.

When using IME, InsertText may be executed multiple times within one relayout.
Fix the problem that length of the text cannot be calculated correctly.

Change-Id: Id47f7bbacf90a098055fc7b6ae0d4931a9facde2

8 months agoMerge "Fix bug in transition effect" into devel/master
sunghyun kim [Mon, 8 Apr 2024 06:10:10 +0000 (06:10 +0000)]
Merge "Fix bug in transition effect" into devel/master

8 months ago(Vector) Let we send finished signal only for matched sent play/stop from visual 09/309209/4
Eunki, Hong [Fri, 5 Apr 2024 13:28:08 +0000 (22:28 +0900)]
(Vector) Let we send finished signal only for matched sent play/stop from visual

It is possible that AnimationFinished trigger comes "after" event thread Play action comes.

If then, user's Play action be skipped.

To avoid this case, let we give the id when play state changed to Play / Pause / Stop.
And send finished signal only if the id is matched what visual know.

Change-Id: I03409e65d2f6b947940ea5591959b106ff8de2bd
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
8 months agoFix bug in transition effect 11/308711/11
sunghyun kim [Wed, 27 Mar 2024 07:33:59 +0000 (16:33 +0900)]
Fix bug in transition effect

Image view provides transitoin effect when image is replaced.
but this function has some bugs, so i fixed them.

Below is the issue list
1.Sometimes, some of view play transition effect when image is not replaced.
2.Sometimes, Don't play transition effect when image is replaced.
3.Focus items show transition effect even if resource is not changed.

Change-Id: I610ef472c3046177c5e3f76dd4d854497805168c

8 months agoDALi Version 2.3.18 76/309176/1 dali_2.3.18
David Steele [Fri, 5 Apr 2024 09:57:43 +0000 (10:57 +0100)]
DALi Version 2.3.18

Change-Id: I104ee21bd9fe23e4fe03f4edfde6681fc11c20ac

8 months agoFix hit-test RenderTask error 78/308978/3
huiyu.eun [Wed, 3 Apr 2024 06:08:22 +0000 (15:08 +0900)]
Fix hit-test RenderTask error

There is a problem that the hit-test does not work properly because the
RenderTask is always fetched with a fixed index from the RenderTaskList.
It is fixed by passing the corresponding SceneView's RenderTask.

Change-Id: Id114c839455613fc4ed6437e2cb8482ee6677be9
Signed-off-by: huiyu.eun <huiyu.eun@samsung.com>
8 months agoRemove unused AccessibilityActivate method 08/308708/2
Youngsun Suh [Fri, 29 Mar 2024 05:36:08 +0000 (14:36 +0900)]
Remove unused AccessibilityActivate method

Change-Id: I2ab634421bf9eb81327f7fee0c96a1f6ccac30b8

8 months agoDALi Version 2.3.17 45/308645/1 dali_2.3.17
Adeel Kazmi [Thu, 28 Mar 2024 09:29:44 +0000 (09:29 +0000)]
DALi Version 2.3.17

Change-Id: I9f4993940f0b0ab230d3eaf88013c72cdb739b66

8 months agoMerge "Apply premultiply on initial time in animated visual" into devel/master
sunghyun kim [Mon, 25 Mar 2024 01:23:56 +0000 (01:23 +0000)]
Merge "Apply premultiply on initial time in animated visual" into devel/master

9 months agoDALi Version 2.3.16 73/308373/1 dali_2.3.16
Adam Bialogonski [Fri, 22 Mar 2024 10:32:15 +0000 (10:32 +0000)]
DALi Version 2.3.16

Change-Id: Ib3f94717e7af660bc16ab47fffb235db0457c63f

9 months agoApply premultiply on initial time in animated visual 00/308300/1
sunghyun kim [Thu, 21 Mar 2024 05:13:48 +0000 (14:13 +0900)]
Apply premultiply on initial time in animated visual

Change-Id: I7ce10be72455c659f5b5d09c3ce303f39dd13102

9 months agoMerge "Make ModelNode / Light don't work A11y + Clean code lines" into devel/master
Seungho BAEK [Wed, 20 Mar 2024 09:27:06 +0000 (09:27 +0000)]
Merge "Make ModelNode / Light don't work A11y + Clean code lines" into devel/master

9 months agoMerge "[AT-SPI] Lazily calculate the "class" attribute" into devel/master
Lukasz Oleksak [Tue, 19 Mar 2024 09:03:24 +0000 (09:03 +0000)]
Merge "[AT-SPI] Lazily calculate the "class" attribute" into devel/master

9 months agoMake ModelNode / Light don't work A11y + Clean code lines 70/304870/3
Eunki, Hong [Thu, 25 Jan 2024 04:24:24 +0000 (13:24 +0900)]
Make ModelNode / Light don't work A11y + Clean code lines

Let we make ModelNode and Light disable to create ControlAccessible as default.

And also, let we seperate the header file API override comes from.
It will make easy to find where it is comes from.

Change-Id: I477a2c34e247681df45120d83edd84b67fc22a9e
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
9 months agoFix svace issue phase2 : Need to check Property::Value.Get() return 11/308111/1
Eunki, Hong [Mon, 18 Mar 2024 05:29:36 +0000 (14:29 +0900)]
Fix svace issue phase2 : Need to check Property::Value.Get() return

It is possible that user set invalid value type.

If then, we need to skip given value setter.

Change-Id: I1d3074c6bf7ee061cb195195a90f8b07fe04db7f
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
9 months agoMerge "(Vector) Change shader at visual side" into devel/master
Eunki Hong [Mon, 18 Mar 2024 03:59:05 +0000 (03:59 +0000)]
Merge "(Vector) Change shader at visual side" into devel/master

9 months agoMerge "Ensure image visual shaderType is in range" into devel/master
Eunki Hong [Mon, 18 Mar 2024 03:43:56 +0000 (03:43 +0000)]
Merge "Ensure image visual shaderType is in range" into devel/master

9 months agoMerge "(AutomatedTests) Let we make adaptor invalidate if adaptor stop" into devel...
Eunki Hong [Fri, 15 Mar 2024 23:26:33 +0000 (23:26 +0000)]
Merge "(AutomatedTests) Let we make adaptor invalidate if adaptor stop" into devel/master

9 months agoDALi Version 2.3.15 77/308077/1 dali_2.3.15
Adeel Kazmi [Fri, 15 Mar 2024 19:24:29 +0000 (19:24 +0000)]
DALi Version 2.3.15

Change-Id: Ie546eda86d7b47c8473d6aca29c86d4f38a99549

9 months agoEnsure image visual shaderType is in range 67/307567/3
Eunki, Hong [Tue, 12 Mar 2024 04:05:25 +0000 (13:05 +0900)]
Ensure image visual shaderType is in range

Let we make assert if we try to use invalid native shader feature

Change-Id: I20780e264038c5d59018c8c7110a51a18f36dbe5
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
9 months ago[AT-SPI] Lazily calculate the "class" attribute 06/308006/3
Artur Świgoń [Fri, 15 Mar 2024 07:16:16 +0000 (08:16 +0100)]
[AT-SPI] Lazily calculate the "class" attribute

This helps streamline Control::Initialize() by moving the attribute calculation
to ControlAccessible::GetAttributes() which is where the value is really
needed. Additionally, GetAttributes() is cleaned up a little for readability.

Change-Id: Iecc2a63a200d23e4bfb30681fa00b63ca4d72c5a

9 months ago(Vector) Change shader at visual side 42/307642/3
Eunki, Hong [Tue, 12 Mar 2024 05:12:22 +0000 (14:12 +0900)]
(Vector) Change shader at visual side

Let we change animated vector visual shader at visual side, instead of dali-extension.
Now we can use cached shader.

Change-Id: Ie530f295227ce55b9d374bc4ddfd1a09361905a4
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
9 months ago(AutomatedTests) Let we make adaptor invalidate if adaptor stop 82/307682/3
Eunki, Hong [Tue, 12 Mar 2024 07:44:58 +0000 (16:44 +0900)]
(AutomatedTests) Let we make adaptor invalidate if adaptor stop

Change-Id: I1436b6dcb86810821abdf90eff9c9a9d63e8ee0a
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
9 months agoMerge "Change TransitionEffect" into devel/master
sunghyun kim [Thu, 14 Mar 2024 01:24:27 +0000 (01:24 +0000)]
Merge "Change TransitionEffect" into devel/master

9 months agoMerge "Ignore overwritable image changeness during utc test" into devel/master
David Steele [Wed, 13 Mar 2024 10:17:35 +0000 (10:17 +0000)]
Merge "Ignore overwritable image changeness during utc test" into devel/master

9 months agoMerge "The canvas view defaults to SYNCHRONOUS_LOADING." into devel/master
joogab yun [Wed, 13 Mar 2024 01:11:38 +0000 (01:11 +0000)]
Merge "The canvas view defaults to SYNCHRONOUS_LOADING." into devel/master

9 months agoChange TransitionEffect 19/307719/2
sunghyun kim [Tue, 12 Mar 2024 11:39:09 +0000 (20:39 +0900)]
Change TransitionEffect

The existing effect was rather slow and unnatural.
therefore, some of the settings have been modified to make the effect more natural.

Change-Id: I42ef237dd831dd210766bf670b2d3061def69c44

9 months agoMerge "Lock mutex when we queue offscreen texture at GlView" into devel/master
David Steele [Tue, 12 Mar 2024 11:58:51 +0000 (11:58 +0000)]
Merge "Lock mutex when we queue offscreen texture at GlView" into devel/master

9 months agoIgnore overwritable image changeness during utc test 97/307697/2
Eunki, Hong [Tue, 12 Mar 2024 08:38:09 +0000 (17:38 +0900)]
Ignore overwritable image changeness during utc test

Change-Id: I09ad220850be41ae1b659100e6e4a5ba555dba59
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
9 months agoThe canvas view defaults to SYNCHRONOUS_LOADING. 71/307671/3
joogab.yun [Tue, 12 Mar 2024 04:48:35 +0000 (13:48 +0900)]
The canvas view defaults to SYNCHRONOUS_LOADING.

A crash occurs when multiple CanvasViews are operated async.
So, we change it to operate synchronously by default.

The problem of async operation when using a multi-canvas view should be resolved later.

Change-Id: I9bb4c8165b69ebdd93753211214fcadf06a3f456

9 months agoIntroduce REMOVE_FRONT_INSET, REMOVE_BACK_INSET Property 25/307025/17
ANZ1217 [Wed, 21 Feb 2024 05:39:52 +0000 (14:39 +0900)]
Introduce REMOVE_FRONT_INSET, REMOVE_BACK_INSET Property

Added new property to TextLabel

Example:
textLabel.SetProperty(DevelTextLabel::Property::REMOVE_FRONT_INSET, false);
textLabel.SetProperty(DevelTextLabel::Property::REMOVE_BACK_INSET, false);

When REMOVE_FRONT_INSET is set to false, the xBearing of first glyph won't be trimmed.
When REMOVE_BACK_INSET is set to false, the advance of last glyph won't be trimmed.

Change-Id: I169d87b9f83d3b204ea51601188982cda54cb9d0

9 months agoMerge "Fix svace issue : Need to check Property::Value.Get() return" into devel/master
Eunki Hong [Mon, 11 Mar 2024 02:45:43 +0000 (02:45 +0000)]
Merge "Fix svace issue : Need to check Property::Value.Get() return" into devel/master

9 months agoMerge "DALi Version 2.3.14" into devel/master
David Steele [Fri, 8 Mar 2024 10:55:24 +0000 (10:55 +0000)]
Merge "DALi Version 2.3.14" into devel/master

9 months agoDALi Version 2.3.14 54/307454/1 dali_2.3.14
Adam Bialogonski [Fri, 8 Mar 2024 10:49:53 +0000 (10:49 +0000)]
DALi Version 2.3.14

Change-Id: I523b759829956740ddc95706005ce408a0741041

9 months agoAdd CastShadow and ReceiveShadow for Model and ModelNode 61/307061/3
Seungho Baek [Mon, 4 Mar 2024 09:08:27 +0000 (18:08 +0900)]
Add CastShadow and ReceiveShadow for Model and ModelNode

 - CastShadow can be used to make an object cast shadow or not.
 - ReceiveShadow can be used to make an object be not drawn any shadow on its surface.
 - Model and ModelNode have the methods.
 - If Model's method is called, it is inherited to its current child ModelNode.
 - If ModelNode's method is called, it is only affects the ModelNode itself.
 - The ModelNode's property changes do not affect its parent Model's property.

Change-Id: I8ebeeed9ed814718a38ad7f69c43a4814a5a70ae
Signed-off-by: Seungho Baek <sbsh.baek@samsung.com>
9 months agoFix svace issue : Need to check Property::Value.Get() return 98/307098/2
Eunki, Hong [Tue, 5 Mar 2024 00:43:05 +0000 (09:43 +0900)]
Fix svace issue : Need to check Property::Value.Get() return

It is possible that user set invalid value type. If then, we need to skip
given value setter.

Change-Id: I8bc339f30b969c049a0b07bda152c4d24593bb48
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
9 months agoLet we use legacy rounded blur algorithm for gles2.0 + remove GL keyword 17/307317/5
Eunki, Hong [Thu, 7 Mar 2024 06:21:03 +0000 (15:21 +0900)]
Let we use legacy rounded blur algorithm for gles2.0 + remove GL keyword

Since low spec device also want to use rounded blur color visual,
let we make them use some old legacy code, which required low calculation.

Change-Id: I50ad32c09da384e9ddc8a18423e67681f8824a5c
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
9 months agoLock mutex when we queue offscreen texture at GlView 38/307038/2
Eunki, Hong [Mon, 4 Mar 2024 06:39:55 +0000 (15:39 +0900)]
Lock mutex when we queue offscreen texture at GlView

Change-Id: I3919c9be6dbb7cb16ef269d95a0ebab5a70711e9
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
9 months agoFix code comments 11/307111/1
Eunki, Hong [Tue, 5 Mar 2024 03:57:08 +0000 (12:57 +0900)]
Fix code comments

Change-Id: Id61ceee6144d6b81e8e302785093c4b545140d91
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
9 months agoFix many svace issues at dali-toolkit (integer overflow + etc) 68/307068/1
Eunki, Hong [Mon, 4 Mar 2024 07:50:23 +0000 (16:50 +0900)]
Fix many svace issues at dali-toolkit (integer overflow + etc)

This is a combination of 3 commits.

Let we remove many cases of dali-toolkit when we can be call 0u - 1u, which is undefined behavior.

Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
(Scene3D) Fix svace issue : convert uint32_t to std::streamoff + minor

Fix svace issue when we try to convert from 32bit unsigned integer
to (might) 64bit signed integer.

+

Fix the name of function collision issue

Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Fix svace issue : Avoid to divide by zero cases

Change-Id: If11884693253cd86f89cb98704e93473166faca1
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
9 months agoDo not call malloc during terminate 73/306873/2
Eunki, Hong [Wed, 28 Feb 2024 12:51:32 +0000 (21:51 +0900)]
Do not call malloc during terminate

There was some strange crash issue during application terminate.

That crash comes at malloc.c during destruct JsonParser.

So, let we just remove some potential of mallocate memory during terminate,
what might not neccessary.

Change-Id: I93dc70b0c069f90a94e526f7916f9c54e1565a7f
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
9 months agoAssume memory allocation failed cases 12/307012/1
Eunki, Hong [Mon, 4 Mar 2024 01:54:19 +0000 (10:54 +0900)]
Assume memory allocation failed cases

Let we consider malloc return null.

Change-Id: I5bafbf1cd47880ca5bc488cea264b88d742a7861
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
9 months agoImageVisualShader debug script make to add custom attribute / varying / uniform 43/306943/2
Eunki, Hong [Thu, 29 Feb 2024 05:25:04 +0000 (14:25 +0900)]
ImageVisualShader debug script make to add custom attribute / varying / uniform

Let we allow to set some extra uniform and attribute , varying if user need to debug.

Change-Id: I0c98358fe22e6678fcfa352d33c61308597bcfe0
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
9 months agoDALi Version 2.3.13 83/306983/1 dali_2.3.13
Richard Huang [Fri, 1 Mar 2024 11:42:39 +0000 (11:42 +0000)]
DALi Version 2.3.13

Change-Id: I694a7fa17d2953cb73dea911f332f3276de1352d

9 months ago(Automated Tests) Use github link instead of w3 for SVG image 78/306878/1
Adeel Kazmi [Wed, 28 Feb 2024 17:43:24 +0000 (17:43 +0000)]
(Automated Tests) Use github link instead of w3 for SVG image

Change-Id: I801f86b265f0101c5c906ccfcb221c477aee9484

9 months ago(Vector) Change ConditionalWait as Mutex at lottie task 66/306766/1
Eunki, Hong [Tue, 27 Feb 2024 09:27:30 +0000 (18:27 +0900)]
(Vector) Change ConditionalWait as Mutex at lottie task

Change-Id: I1f652c440945a9b40a88a992018e14ae0746bc9d
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
9 months agoChange precision of corner radius relative shader codes as highp 96/306696/2
Eunki, Hong [Mon, 26 Feb 2024 09:31:22 +0000 (18:31 +0900)]
Change  precision of corner radius relative shader codes as highp

There was some visual defect when view size is near 20,000 in target.

Change-Id: Ia9440c98e20a873664d09493cc9d645f1f7a91b1
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
9 months agoMerge "Change precision of shader variable" into devel/master
Seungho BAEK [Mon, 26 Feb 2024 01:46:23 +0000 (01:46 +0000)]
Merge "Change precision of shader variable" into devel/master

10 months agoMerge "DALi Version 2.3.12" into devel/master
David Steele [Fri, 23 Feb 2024 13:32:13 +0000 (13:32 +0000)]
Merge "DALi Version 2.3.12" into devel/master

10 months agoDALi Version 2.3.12 36/306636/1 dali_2.3.12
David Steele [Fri, 23 Feb 2024 13:05:44 +0000 (13:05 +0000)]
DALi Version 2.3.12

Change-Id: I853019d9e13691b62c471ac789e010c101fca2d1

10 months agoFix Shadow crash issue during SceneOff 10/306510/2
Eunki, Hong [Thu, 22 Feb 2024 08:31:25 +0000 (17:31 +0900)]
Fix Shadow crash issue during SceneOff

Change-Id: If2e7cd12212d6207f7b9e582c8105574df0dd3c7
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
10 months agoChange precision of shader variable 37/306537/2
seungho baek [Thu, 22 Feb 2024 13:08:44 +0000 (22:08 +0900)]
Change precision of shader variable

Change-Id: I4138a170c0ba9bea240a0fd0fcfab36afc2d182b
Signed-off-by: seungho baek <sbsh.baek@samsung.com>
10 months agoMerge "Support Scene3D on gles 2.0" into devel/master
Eunki Hong [Thu, 22 Feb 2024 11:22:04 +0000 (11:22 +0000)]
Merge "Support Scene3D on gles 2.0" into devel/master

10 months agoMerge "Fix bug when we try to load two image s.t. premultyOnLoad difference" into...
Eunki Hong [Thu, 22 Feb 2024 05:59:37 +0000 (05:59 +0000)]
Merge "Fix bug when we try to load two image s.t. premultyOnLoad difference" into devel/master

10 months agoMerge "Emit ResourceReady if we call Reload even if it was ready visual." into devel...
Eunki Hong [Thu, 22 Feb 2024 05:59:29 +0000 (05:59 +0000)]
Merge "Emit ResourceReady if we call Reload even if it was ready visual." into devel/master

10 months agoMerge changes Ic9dba03a,Id5ec87c1 into devel/master
Eunki Hong [Thu, 22 Feb 2024 04:18:56 +0000 (04:18 +0000)]
Merge changes Ic9dba03a,Id5ec87c1 into devel/master

* changes:
  Print image process duration when we trace it
  Reduce the length of log during image trace

10 months agoSupport Scene3D on gles 2.0 21/305621/10
Eunki, Hong [Mon, 5 Feb 2024 10:49:19 +0000 (19:49 +0900)]
Support Scene3D on gles 2.0

Let we support Scene3D::Model under gles 2.0 devices.

Note : Since glsl doesnt support textureLod, we cannot support roughness.

Change-Id: If518bf48361331eb47b0f8a5a2ef265ba3fee488
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
10 months agoAdded UNSAFE_RENDERING_DIRECT backend mode for GLView. 91/306191/6
Adam Bialogonski [Fri, 16 Feb 2024 16:11:14 +0000 (16:11 +0000)]
Added UNSAFE_RENDERING_DIRECT backend mode for GLView.

UNSAFE_RENDERING_DIRECT mode allows injecting the GL calls
directly into window context. This method is considered unsafe
and should be used cautiously as it may alter GL state of the
main DALi pipeline (ie. affect UI rendering).

Change-Id: Idd36a26541f9af56657c1eef72ee7e83e2a45581
Signed-off-by: Adam Bialogonski <adam.b@samsung.com>
10 months agoPrint image process duration when we trace it 89/306289/2
Eunki, Hong [Mon, 19 Feb 2024 13:31:11 +0000 (22:31 +0900)]
Print image process duration when we trace it

Change-Id: Ic9dba03a2f18743ea253ccf9e1234bd1bda78239
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
10 months agoReduce the length of log during image trace 88/306288/2
Eunki, Hong [Mon, 19 Feb 2024 13:08:19 +0000 (22:08 +0900)]
Reduce the length of log during image trace

Change-Id: Id5ec87c10021a3d391295d88fbef2a88e1750150
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
10 months agoFix bug when we try to load two image s.t. premultyOnLoad difference 84/306184/1
Eunki, Hong [Fri, 16 Feb 2024 12:54:48 +0000 (21:54 +0900)]
Fix bug when we try to load two image s.t. premultyOnLoad difference

Let we seperate cache between
"Could-be-premultiplied, but not loaded yet" VS "Do not premultiplied"

Currently, we check both of them as same item.

Change-Id: Idfb68580e5a321745ee3accf9bb61d3845a39067
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
10 months agoEmit ResourceReady if we call Reload even if it was ready visual. 83/306183/1
Eunki, Hong [Fri, 16 Feb 2024 11:25:09 +0000 (20:25 +0900)]
Emit ResourceReady if we call Reload even if it was ready visual.

If the visual was already ready state, and if we call Reload, the visual state
still ResourceReady. So ResourceReady signal was not be emitted.

Since someone might need to know the timing of resource loaded after Reload(),
Make we reset status as PREPARE, and wait callback again.

Change-Id: Id0ddb6523c4d9fcd58aab63a2fb07d27fdd9c5b5
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
10 months agoMerge "DALi Version 2.3.11" into devel/master
David Steele [Fri, 16 Feb 2024 11:13:11 +0000 (11:13 +0000)]
Merge "DALi Version 2.3.11" into devel/master

10 months agoDALi Version 2.3.11 63/306163/1 dali_2.3.11
Richard Huang [Fri, 16 Feb 2024 11:02:25 +0000 (11:02 +0000)]
DALi Version 2.3.11

Change-Id: Ifb9447b21d0f483c31d2658660f19c15694704a5

10 months agoMerge "Ignore corner blur radius if glsl version is low" into devel/master
Eunki Hong [Fri, 16 Feb 2024 07:17:36 +0000 (07:17 +0000)]
Merge "Ignore corner blur radius if glsl version is low" into devel/master

10 months agoTest harness sync 86/305886/3
David Steele [Mon, 12 Feb 2024 19:12:44 +0000 (19:12 +0000)]
Test harness sync

Change-Id: I480e0fb3b1f3a475ea02ec7be1599f9af36a8f18

10 months agoMerge "Let we make WebView invisible if window is hide" into devel/master
Eunki Hong [Wed, 14 Feb 2024 06:58:54 +0000 (06:58 +0000)]
Merge "Let we make WebView invisible if window is hide" into devel/master

10 months agoMerge "Make uShadowBias highp" into devel/master
Eunki Hong [Wed, 14 Feb 2024 06:58:18 +0000 (06:58 +0000)]
Merge "Make uShadowBias highp" into devel/master

10 months agoMerge changes Iafce95d1,I701627ff,Ic2b33c53 into devel/master
Eunki Hong [Wed, 14 Feb 2024 06:37:15 +0000 (06:37 +0000)]
Merge changes Iafce95d1,I701627ff,Ic2b33c53 into devel/master

* changes:
  Apply some missing shader names
  Add precompiled shader names
  Add name of shader what we generate as default

10 months agoDALi Version 2.3.10 44/305844/1 dali_2.3.10
Adeel Kazmi [Fri, 9 Feb 2024 10:11:52 +0000 (10:11 +0000)]
DALi Version 2.3.10

Change-Id: I86045f8c3be35213371476eac93fcc52d3b3b615