review.tizen.org Git - platform/upstream/iotivity.git/log

Add wrong PIN defence codes in case of PIN based OxM

* Add CAErrorCallback in OTM to handle result of DTLS handshake.
* Our implementation as follows :
    1. Implemente CAErrorCallback(DTLSHandshakeCB) in OTM to handle result of DTLS handshake.
    2. Try dtls handshake.
    3. Wait for handshake result.
    4. Invoke CAErrorCallback(DTLSHandshakeCB) at CAHandleSecureEvent() when handshake is finished.
    5. Handle handshake result in DTLSHandshakeCB.
        - in case of success, we can send next coaps request.
        - in case of failure, return the error value or restart ownership transfer.

Related jira : https://jira.iotivity.org/browse/IOT-831

[Patch #1] Intial upload
[Patch #2] Remove white-space
[Patch #3] Update comment
[Patch #4] Update according to comments
[Patch #5] Revert extlibs/tinydtls/crypto.c to seprate changeset
[Patch #6] Rebase
[Patch #7] Modify the stCADtlsContext_t to save the OTMContext.
[Patch #8] Remove white-space.
[Patch #9] Modify according to sachin's comment.
[Patch #10] Modify according to comments.
[Patch #11] Remove whitespace
[Patch #12] Rebase by sachin
[Patch #13] Update commit message

Change-Id: I034b0e9ad267cb6998ce3df3ce50629583740608
Signed-off-by: leechul <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4143
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>

/oic/res response for the RD

Earlier collection payload was added in discovery payload to handle RD response in
a separate way in form of tags and links. But with recent changes and discussion
baseURI is mvoed to discovery payload.

With this change there is one response for /oic/res with an additional field for RD.

Change-Id: Ia29cc64ffb48062d72ee4b9a9b59013480f13ff1
Signed-off-by: Habib Virji <habib.virji@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4611
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Removed collection resource and device support from simulator plug-in.

1. Collection resource and device related UI has been removed
from service provider eclipse plug-in.
2. This check-in also includes refactoring and fixing of minor UI bugs.

Change-Id: I1b12620202d3a861c251afb8ae4e14c5a96b7b44
Signed-off-by: G S Senthil Kumar <senthil.gs@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4635
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

IoTivity Simulator System testing bug fixes.

1. Resolved issues found during stress testing.
2. Limiting the maximum number of resources that can be created
from server to 200(Considering block-wise transfer and application
stability).
3. Includes minor optimization and code clean-up.

Change-Id: If196b72b5221e3795b4693f00a99d33650c0a8d0
Signed-off-by: G S Senthil Kumar <senthil.gs@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4431
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Radha Bhavani <radha.p@samsung.com>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Fixed simple fixes according to static code analysis for resource-container

- Prohibit implicit copy-contructor and assignment operator for certain classes.
- Update copyright note

Change-Id: I0893aa2a4de23832fb9d540128f106fd7b45bafa
Signed-off-by: Markus Jung <markus.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4489
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Make sure the Platform Resource and Device Resource have 2 interfaces.

The /oic/d and /oic/p resources must have oic.if.r and oic.if.baseline
interfaces specified.

This is also for IOT-874.

Change-Id: Ia6a666c03e954634d4589c2bbe8a3a4d72ad8a86
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4587
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Modified discovery payload to be spec compliant.

The discovery oic/res payload had the device id "di" and "links"
being repeated for every resource. The payload itself was not structured
in a spec compliant way.

Plucked out di and links from every resource and put in the root map.
The format for the payload is "modelled" as JSON.
[
    {
        "di" : UUID,
        links :[
                    {
                        href, rt, if, policy        // Resource 1
                    },
                    {
                        href, rt, if, policy        // Resource 2
                    },
                    .
                    .
                    .
                ]
    }
]

Change-Id: I2c50a7cc1ee46df633810372e446ac92c5e496f5
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4543
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Markus Jung <markus.jung85@gmail.com>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Add /oic/d and /oic/p discovery response messaging to IoTivity.

Prior to this, Clients could only perform a GET request directly on
/oic/d and /oic/p. This commit also enables performing DISCOVERY
requests on /oic/d and /oic/p as well.

This aligns with OIC spec compliancy.

This fixes Jira Ticket IOT-874.

Change-Id: I29693a67bb245b3fae8d1ed54833eacd1397884e
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4567
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Markus Jung <markus.jung85@gmail.com>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Update index of Zigbee Resources when a NodeId changes.

Change-Id: Ia1ffd7ebb7bba51fdb211a33000713c7e1daab32
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3937
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Replaced zigbee nodeId in URI with zigbee eui.

Change-Id: Ib2df8d45ceb9ecd62bc8fab3978ac8d30f3571e8
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3785
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Added context for callbacks.

Change-Id: Ia20cae8abc1e4a4112bc70608fb482174701abbb
Signed-off-by: Thuyen Tran <thuyen.c.tran@intel.com>
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3939
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Added context parameter.

Change-Id: Ic4616d69ff78fdef4897fd7ca47f0192a4f9420e
Signed-off-by: Thuyen Tran <thuyen.c.tran@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3927
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

check the method type of request info.

if method type of request info is invalid,
CA has to return error code to RI Layer.

Change-Id: Ic34da1c13e63172885a44a114a86f52cbbb34f6f
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4565
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: MyeongGi Jeong <myeong.jeong@samsung.com>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

fixed sample app defects detected by static analysis

fixed issues in CA sample app reported by static analysis tool

Change-Id: I1eaf0c6bedb0a86e8da7edf3301dcd06cb1ddfbf
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4401
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

updated Readme.scons.txt file

the build script for each platform is not updated.
so I updated the build script and options.

Change-Id: I5e4298b77fae1bfdacd7539fb199d82afdc7a550
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4393
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Naga Ashok Jampani <jn.ashok@samsung.com>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Enabled CoAP/TCP on android platform

currently, coap/tcp can be supported on linux platform.
so I modified the code to support Android platform.

Change-Id: Ia9a9e36939f848b98393648968ddcfacfa7ce564
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3411
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Naga Ashok Jampani <jn.ashok@samsung.com>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

IOT-897:OCRepresentation can check attribute type

Change-Id: I6a63bdb958b016385aa20b3467c61c44a1824327
Signed-off-by: Hugues Ekra <hekra@cisco.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4429
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

IoT-875, IoT-876 core value and data model value fix

Updates oic/d to use the following values:
- icv: core.1.0.0 (https://jira.iotivity.org/browse/IOT-876)
- dmv: res.1.0.0 (https://jira.iotivity.org/browse/IOT-875)

Signed-off-by: Markus Jung <markus.jung@samsung.com>
Change-Id: Ia9019f26aa32790fc3bf445c4a7404a5afdd67ea
Signed-off-by: Markus Jung <markus.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4515
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
(cherry picked from commit 2e2fc369a7427525c0d891dc250bdedfba270e85)
Reviewed-on: https://gerrit.iotivity.org/gerrit/4517

Modify incorrect conditional statements in OCParseSecurityPayload

Since, payload format changed as follows :

[ { rep: security payload } ]

to

{security payload}

We don't need check whether cbor value is a map.

Change-Id: I65912c4bacd9e33cee991d5ba37c8ae1b01d0f1d
Signed-off-by: leechul <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4511
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>

Added api in PDM to set device as stale

Remove Device API deletes the device from the PDM. but if value is deleted from
DB then we loose that device's reference which is required by other functions of
same API.

To overcome this issue we have added device stale API which instead of removing
device row, sets stale status of device as true.

Due to this chnage APIs like PDMLinkDevices and PDMGetOwnedDevices are also changed.
these apis now ignore data corresponding to stale entries.

Change-Id: I9ee2180296163e289724c7c71f70c4271b9f1c4f
Signed-off-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3415
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>

Update the OC_SPEC_VERSION macro

Updated the spec version from 0.9.0 to 1.0.0 in octypes.h file.

Change-Id: I2968a167fa4c76ba85e46d3a2eaf42451d07fc7a
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4379
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
(cherry picked from commit 099bca1e90fd867f1632e3c4d120465f19573ba7)
Reviewed-on: https://gerrit.iotivity.org/gerrit/4507

Change RD payload in correct format.

Updated RD without surrounding array.
[
   {
     "di":"",
   },
   [
     {links}
   ]
]

Change-Id: I6d6082bcb04f03a80e367dfc081a3e381a4d8f8d
Signed-off-by: Habib Virji <habib.virji@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4495
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

[IOT-898] Propagate result of CA discovery/listen start call.

Capture and return the result of CA discovery and listen start
function calls to allow for better differentiation of transport
adapter initialization and communication errors.

Change-Id: Ib5717600708e36792c020cb1c3b9f9caeaad9839
Signed-off-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4443
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Fix for Build error in Arduino Due Build

Fixed Random Function calls as per random func availability for avr and arm boards.

Change-Id: I2d4e9aea56d35dd5a8112f1ec90b1215dbc728be
Signed-off-by: koushik.girijala <g.koushik@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4383
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Change SECURITY payload in correct format.

Updated code to correct format:
[ { rep: security payload } ]

to

{security payload}

Change-Id: I8ab414d762b34c75ccff6ac7698d564462636829
Signed-off-by: Habib Virji <habib.virji@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4499
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Change PRESENCE payload in correct format.

Removes enclosing array and rep from the presence payload.

It changes structure from
[{
  rep: {
   presence payload
  }
}]
to
{
  presence payload

}

Change-Id: I44f7fa1d6f18a0a883057ffb52cfc27c5ead596d
Signed-off-by: Habib Virji <habib.virji@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4467
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Change DEVICE payload in correct format.

Removes enclosing array, href and rep from the device payload.

It changes structure from
[{
  href: "",
  rep: {
   device payload
  }
}]
to
{
  device payload

}

Change-Id: I374d3c1e6dca24a0ae97f56ac0c5e40d3cbf09e0
Signed-off-by: Habib Virji <habib.virji@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4435
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Change PLATFORM payload in correct format.

Removes enclosing array, href and rep from the platform payload.

It changes structure from
[{
  href: "",
  rep: {
   platform payload
  }
}]
to
{
  platform payload

}

Change-Id: I4f475bbbaba905806fba163bb379a47a866e3011
Signed-off-by: Habib Virji <habib.virji@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4433
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Change REPRESENTATION payload in correct format.

Updated rep without starting array, href, and removed prop strucutre.
[
   {
     "href":"/BinarySwitchResURI",
     "rt":
     "if":
     "rep":
           {
              "value":true
           }
   }
]
to be
{
    "rt":
    "if":
    "value":true
}

Change-Id: I26fd608999c88323ab1b9fae1e06a270756e9d31
Signed-off-by: Habib Virji <habib.virji@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4327
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Propagate NodeId change to upper layer.

Change-Id: I741889380b0798cadbbad6014639dfec19926b27
Signed-off-by: Thuyen Tran <thuyen.c.tran@intel.com>
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3913
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Added test case for ZigBee Light Temperature and Brightness.

Change-Id: I5e20d2dae522a01140abaf2d97ac218c1b2d60f9
Signed-off-by: Thuyen Tran <thuyen.c.tran@intel.com>
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3889
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Added support for ZigBee Water and Motion sensor and Chroma light.

Change-Id: If60902286ad38466aa62eb127e1a64e18a41d550
Signed-off-by: Thuyen Tran <thuyen.c.tran@intel.com>
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3887
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Handled zone status enrollment on subsequence runs.

Change-Id: I00d2e866bb4af58105e7255124b9d17444d7366a
Signed-off-by: Thuyen Tran <thuyen.c.tran@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3885
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

- Ensure 10 seconds timeout entryType if found or not-found.
- Ignore “REPORTATTR:” prompts.
- Empty the buffer when the stack is initialized.

Change-Id: I4452622951ad07cfc5fe81f4f98e52f96b8d47d4
Signed-off-by: Thuyen Tran <thuyen.c.tran@intel.com>
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3883
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

add the prefix definition to resolve the build error

after '[IOT-828] OCRepresentation to provide host info' was submitted,
build error has been encountered while building WITH_TCP=true option.
so I added the prefix definition for coap over tcp.

Change-Id: Ia479a1946eae78beffc146b61f99ec864bd0b142
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4371
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

RD handling of publishing device address

Correct address in the baseURI field for resource directory.

This patch fixes issues where host() in OCResource.cpp returned
a wrong IP address. It uses baseURI field in the /oic/res to send
publishing device address.

JIRA ISSUE:855

Signed-off-by: Habib Virji <habib.virji@samsung.com>
Change-Id: Idf86fe801e25e32c84268f421feff479270faa1b
Reviewed-on: https://gerrit.iotivity.org/gerrit/4337
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

[IOT-826] Android: Fixed failure on cancelObserve() with High QoS

In addition it propagates the actual error codes
from the C++ exceptions

Change-Id: I49ab61c42c5dade8e021cf1f1ae6fed83f1fee88
Signed-off-by: Tim Kourt <tim.a.kourt@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4387
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Fix for Memory management in Arduino

Modified code to make more heap available in arduino MEGA

Change-Id: I62ebc1bcf08331d7d90871bb2a6dd201f4ae7e4b
Signed-off-by: vimala.v <vimala.v@samsung.com>
Signed-off-by: koushik.girijala <g.koushik@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3879
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

[RE] Added Secure Resource Linux Sample Apps to the RE Layer

- Added API to RCSResourceObject to support OC_SECURE property for
resource creation.
- Added Secure Resource Linux Applications.

Change-Id: I97fb97387c1c03c44a6a5ff123729107bd28681d
Signed-off-by: Jay Sharma <jay.sharma@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4399
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Fix for IOT-769. Sets the uri in OCRepresentation
sent by the server as a response to a client query.

Change-Id: I1c432ce66ba912d04a1b5b35374cf53cf6f95c4b
Signed-off-by: Rahul Rahul <rahul.rahul@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4329
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

libcoap: remove fix build error on big endian systems

In the big endian case an additional typedef is added in a wrong
position in TinyDTLS. This breaks compiling this code on big endian
systems.

Change-Id: Iad854aba112ddb23bf490b064ec6fbf5d01ce6b6
Signed-off-by: Hauke Mehrtens <hauke.mehrtens@lantiq.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3951
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Modifying version number

Change-Id: I8b1c1d13c8d3f488cef18d99035c09c11f44bb5f
Signed-off-by: Minchul Lee <slotus.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3915
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Remove extlibs/expat for removing the PPM

Only Protocol Plugin Manager(PPM) used expat library.
Now, PPM does not exist, so remove this library.

Signed-off-by: YounghyunJoo <yh_.joo@samsung.com>
Change-Id: Ib144294553f0e3e19b85748f4354d760dc508645
Reviewed-on: https://gerrit.iotivity.org/gerrit/4391
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Modify RE layer to use POST operation for set-request

POST operation is for updation.
It is what the set-request exactly does.

Change-Id: I32615b284b5b7222c4a151bc990b1e4f1014ac41
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4347
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

Code clean-up, Bug fixes and enhancements in eclipse plug-ins.

1. Enhanced resource deletion UI.
2. Resolved minor issues.
3. Removed unnecessary code.
4. Added code to set the device and platform information from server linux sample.

Change-Id: I5eebd95614e0aefb221cd3b5bc9930d676b40c41
Signed-off-by: G S Senthil Kumar <senthil.gs@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4335
Reviewed-by: RadhaBhavani <radha.p@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

resource-container: remove empty files

move default constructor/destructor to header files and remove empty source files

Change-Id: I5ec63a34926c74fab9742cbf299c978a7e76bd1d
Signed-off-by: Minji Park <minjii.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4331
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

[IOT-828] OCRepresentation to provide host info

Change-Id: Iaf18ef8119d592a33eac69bd6d9e6a609aaf0d87
Signed-off-by: Hugues Ekra <hekra@cisco.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4307
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Tim Kourt <tim.a.kourt@intel.com>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Refactored CA linux sample application

- remove unnecessary log
- modify memory free logic

Change-Id: I89af29565e546dc1d6a5f266c7cbca75421c0cb6
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4085
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Naga Ashok Jampani <jn.ashok@samsung.com>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Added error check code for Reset with no empty message.

Reset must be empty message by spec rfc 7252.
both receiver and sender applied to check
whether reset has empty message or not.

Change-Id: I0aaeec22bbeda1ffd893e488f74450eb31b742ae
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3873
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Revert "MAC address parsing" as per info from Thiago Macieira

This reverts commit 5a27b9c30d54d4e92f0a86dc6cb05ea20b6fb296.

Change-Id: I12dc5db3c8319b38e23e5580f2875c13e6428e4e
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4321
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Modified location of unittest folder.

location of unittest is moved to resource-hosting\ from resource-hosting\src\.
and code refactoring of resource hosting source files.
removed local variables and modified more simple logic.

Change-Id: Ic018e699ecd7e9f3d1d66a8914409573b4732cb4
Signed-off-by: jyong2.kim <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4311
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

resource-container: add return of status code for registerResource() also to JAVA API

This forwards the return code of the registerResource() function also to the
JAVA API, so java application can also make use of it.

This is an extension to commit b449dcc5e7 "resource-container: make
registerResource() return status code"

Change-Id: Icdb71447486ea77b8ea1ef4f0b2f645c9ffbf6d2
Signed-off-by: Hauke Mehrtens <hauke.mehrtens@lantiq.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4305
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Markus Jung <markus.jung85@gmail.com>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Simulator Plug-ins: Bug fixing and enhancements.

1. Resolved minor issues in resource creation, invalid URIs and editing attribute values.
2. Updated the APIs to get the device and platform information by address.
3. Showing all properties of device in service provider plug-in.

Change-Id: I810f3110c0587a34042361c4d0be109ba9f7f646
Signed-off-by: G S Senthil Kumar <senthil.gs@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4313
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: RadhaBhavani <radha.p@samsung.com>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

resource-container: fix segmentation fault if configuration is not initialized

When the configuration is not initialized, for example because the
demon does not use the configuration, this program will run into a
segmentation fault when a new resource gets registered.

Change-Id: I1a6b4b468bdc74136e91ffb5c5dbc3c4d276fe15
Signed-off-by: Hauke Mehrtens <hauke.mehrtens@lantiq.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4151
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Markus Jung <markus.jung85@gmail.com>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

resource-container: add make it possible to specify OIC interface name

Without this the interface name of a bridged device is hard coded to
"oic.if.baseline" with this patch it is possible to change it to
something else if needed.

Change-Id: If593ed43c6deb1787f689ef1be928a0aee66bb24
Signed-off-by: Hauke Mehrtens <hauke.mehrtens@lantiq.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4149
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Markus Jung <markus.jung85@gmail.com>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

connectivity: fix getnameinfo() call for musl libc

The musl libc and also the libc from net/freebsd are currently checking
if the size of the sockaddr given to getnameinfo() matches the size for
this family and it fails when giving sizeof(struct sockaddr_storage).
This patch fixes this problem by making the caller also provide the
size of the struct sockaddr_storage.

I am currently trying to get a fix for this problem into musl libc, but
IoTivity should still fix this.

This also fixes a wrong error message.

Change-Id: Ie9b89523b5ba20e536c03e3ad85c65bd5ff2ba53
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3959
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Enable multiple EDR connection in Android.

Using Available API before using blocking EDR read function.
Bluetooth read function is a blocking function which makes other connection to wait.
So added checking the packet availability before making blocking read.

Change-Id: I794a4010ae6ad3e21c63f3a9e3e9d3fc0d89cad5
Signed-off-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4277
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Add missing return statement

Non-void method in android jni wrapper was missing its return statement.

Change-Id: Ib7a643f16e1bb8bbf20ca193c23328d05face093
Signed-off-by: Erkka Kääriä <erkka.kaaria@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4173
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Naga Ashok Jampani <jn.ashok@samsung.com>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Add missing return statement

A non-void method in android jni wrapper was missing its return statement in
case an OCException was thrown.

Change-Id: Ic5651f3161e9387bdc8522d9509832337a938f23
Signed-off-by: Erkka Kääriä <erkka.kaaria@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4175
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Naga Ashok Jampani <jn.ashok@samsung.com>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Add missing return statements

Several non-void methods were missing their return statements in case
OCException was thrown.

Change-Id: Ic18aed97c5389426c6e36695a5886538174afdc9
Signed-off-by: Erkka Kääriä <erkka.kaaria@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4177
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Naga Ashok Jampani <jn.ashok@samsung.com>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

MAC address parsing

There was no MAC address parsing process from uri.
and checking a address validity neither.

Change-Id: I12476caf7a42c9d95a6613566ad50034ccb57d08
Signed-off-by: jaewook jung <jw0213.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4013
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Optimization for EDR and LE adapter

In EDR and LE adapter, a request can't be differentiated as unicast or multicast.
Hence when a multicast request was received in EDR or LE adapter,
a error response was sent which could have been ignored.
Especially in Hetrogenous network, we received many responses with payload
NULL for a multicast request. Hence as an optimization, we are blocking the
error response for EDR and LE adapters.

Change-Id: Ie3766115e8b89e21c760ec8232ebd74d73fc39c0
Signed-off-by: vimala.v <vimala.v@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4029
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

added to call unregisterReceiver for Android BT/BLE.

there was no method to call unregisterReceiver.

Change-Id: I7ceb5bc73d4a25a1e93cbbf6e3e167c0d9f5c98f
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4047
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Modified preprocessor for headers of RI layer

Change-Id: I8639f3627f58ef8abd3200b3ac059807e6cbe55f
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4273
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Set transport flag according to adapter type in CA Sample

transportflag is always set with CA_IPV4.
so I fixed CA Sample to set the flag according to transport adapter.

Change-Id: I1bc7a86a193355365b2602d88130405e8c7ab187
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4263
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

[IOT-830] Added remove API for all credentials on |credresource|

added all credentials remove API for iotivity client with provisioning
feature. considering commercialization, iotivity client needs not only to
reset SVR data, e.g. doxm, acl and cred resources, but also to remove only
all credential data for its owned servers. for the former case legacy API(s)
could be supported but for the latter case additional API is needed.
the added API for this supports to remove all credentials and update
persistent storage in running iotivity client.
Jira-issue: https://jira.iotivity.org/browse/IOT-830

Change-Id: Icb41023f9acb6498c96e2b089a73daf4f39dd354
Signed-off-by: Kyungsun Cho <goodsun.cho@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4147
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>

[IOT-829] Updated |CT_FLAG_SECURE| support on |PMGenerateQuery| API

fixed |PMGenerateQuery| API in inputting |connType| with |CT_FLAG_SECURE|
Jira-issue: https://jira.iotivity.org/browse/IOT-829

Change-Id: Ib82e4a4ad10c84aef03de31ef81e5a25b9e1bc20
Signed-off-by: Kyungsun Cho <goodsun.cho@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4145
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>

[ARDUINO][BLE] Enable Arduino BLE support in RI sample

Change-Id: Ie326dca25edbfea638e5fea718ad0802224e4c39
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3807
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Changed the logic to add option list in pdu.

resource uri has become null when CASendResponse API use
large payload. because we failed to add option in pdu.
so we fixed the code to add all option normally.

Change-Id: I9e25421793879020ccc0695b9c2642f18fd5e8d2
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3811
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

[IOT-839] Ensure correct map size when serializing rep payload

type & interface map size was hardcoded as two, which broke representation
deserialization when only one of type or interface was present.

Change-Id: I8356fc4ae80f649163d093adbac3cae49cac1cff
Signed-off-by: Erkka Kääriä <erkka.kaaria@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4265
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

modified the wrong variable identifier in messagehandler.

gReceiveThread was deleted in messagehandler.
but in the case of 'ifndef SINGLE_HANDLE',
we use gReceiveThread still. so I modified the variable name.

Change-Id: I99cb0ae5b6edebc772adf94790f3c3ddde2d8c78
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3997
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Android: Removed CAInitialize() call from the CA initializer.

The early initialization call has prevented a proper propagation of the
configuration parameters into CA from ocstack.c. Therefore, IPv6 mode
was not available on Android.

Change-Id: Id90a1eb288ef80f08068113da2967e9ba0989483
Signed-off-by: Tim Kourt <tim.a.kourt@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3941
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Added message format error logic for EMPTY message.

According to CoAP spec(RFC 7252), Empty message has
the token length field set to Zero.
and bytes of data MUST NOT be present after the MessageID field.
If there are any bytes, they MUST be preocessed as a message
format error.

Change-Id: I1709143c9aa1851c428bbcce08d28c2d0534b89c
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3797
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

changed default transport type on android platform

if there is no trasport option from command line,
all transport should be enabled on android platform.

Change-Id: I78e7e3c0d7473f711db67a388d9ea0bbd5908587
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4135
Reviewed-by: Naga Ashok Jampani <jn.ashok@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Temp. fix for the IOT-826

Change-Id: Iacd88a29e5705604b377a5bcf90ee5685dcef6c7
Signed-off-by: Tim Kourt <tim.a.kourt@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4071
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

removed unnecessary log for Android BLE

since the log is occured continually,
there are some obstruction to analyze.
thru, it is better to remove it.

Change-Id: I211ad748f3689bdd855089cde4a388cc12f7fc82
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4027
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Tim Kourt <tim.a.kourt@intel.com>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

things-manager: Updated doxygen comments for things-manager.

Updated and fixed some issues w.r.t doxygen comments in things-manager dir.

Change-Id: I3b872c2720f7723fd84c9f317c60f7785906806f
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3841
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Fix for JIRA issue IOT-599.

- This patch include changes to install the public libraries in ${libdir} and all
public headers in ${includedir}.
- As of now, the iotivitiy.pc.in file refers to resource C and C++ SDK related libraries only.
- If required, the services related public libraries need to segregated into a different .pc.in
file.

Change-Id: Ie110db76900c29534f6bc36dc9e2424f71e9f71f
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3261
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Resolved build issue.

Issue arised from merging the following commits:
d0686ee241a3102399a7135dbe3eb2930219aab9
b76f9709482b03334b468ab47a295761b3fd6a78

Change-Id: I3053d6f995c74f3e174863c25e97d148503a3a50
Signed-off-by: G S Senthil Kumar <senthil.gs@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4287
Reviewed-by: Spurthi SV <spurthi.segu@samsung.com>
Reviewed-by: Harish Marappa <h.marappa@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Multiple EDR connection in Tizen

To support multiple EDR connection, the multicast data will be
added to an arraylist and as on when a device is discovered,
the data will be sent. Once the discovery is finished, the data
will be removed from the arraylist.
Also the current implementation does discovery during initialization alone,
with this commit discovery will be done everytime when a multicast data
is sent.

Change-Id: I6bedb72ab716b828244d79f6f54bdaa4c8005b2f
Signed-off-by: vimala.v <vimala.v@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3625
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Coap over TCP support for Tizen

Tizen platform can be supported for coap over TCP

Change-Id: I8731181e3eac716b39ec40350df24d9c7fd03f74
Signed-off-by: koushik.girijala <g.koushik@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3585
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Fixed issues reported by Prevent static analysis tool

Fix issues in CA and Routing manager reported by Prevent tool

Change-Id: I855181fa12e8e8b483f48c071fa6e12de9b94c2c
Signed-off-by: Sandipan Patra <sandipan.p@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3857
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Abhishek Pandey <abhi.siso@samsung.com>
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Displaying and editing the complex value types for attributes.

1. Tested model and array of model type attribute values.
2. Inclues bug fixing for single resource creation without RAML.

Change-Id: I3f0791dde17e4e0d7f6c2165eb59443465f4163d
Signed-off-by: G S Senthil Kumar <senthil.gs@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4267
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: RadhaBhavani <radha.p@samsung.com>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Fix for issue of server updates its model on both PUT and POST requests even

its respective raml file doest not support either PUT or POST.

Providing the request and response information from raml to simulated resource,
so it can validate the requests it can support whenever it receives one from client.

Change-Id: I42ea78d963dd2c11e7ab945cb6a75bb8e3cd0864
Signed-off-by: spurthi.segu <spurthi.segu@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4259
Reviewed-by: RadhaBhavani <radha.p@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Simplified OICGetCurrentTime() implementation.

Restructured the OICGetCurrentTime() implementation to remove two
unnecessary variables. This allows us to drop a run-time conditional
in the _POSIX_MONOTONIC_CLOCK == 0 case, as well as fix an "unused
variable" compile-time warning. Include directives were also cleaned
up to the minimum needed.

Change-Id: I8f478c08310a74ad642aad5b45f9fc3310b102de
Signed-off-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4249
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

To Enable empty token for CoAP

since token can be used 0~8 byte by spec.
to check null token should be removed.

Change-Id: I0e3b6a605e647206e9f886c9f7e406b6ea6e5288
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4261
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

[JIRA-IOT 722] Removed deprecated socket functions and updated inet_ntop() instead of snprintf()

Change-Id: I1efa2129728386728bcee0f3d0859c7343b4fd8f
Signed-off-by: vimala.v <vimala.v@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3795
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Abhishek Pandey <abhi.siso@samsung.com>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

resource-container: add method to manually send a notification

When I am setting more than one attribute at a time I only want to send one
notification after all the attributes have been set. This change makes it
possible to send the notification at the end.

Change-Id: I8a4825edab97b92041a67a8cdf57f9a6fd832f3b
Signed-off-by: Hauke Mehrtens <hauke.mehrtens@lantiq.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4207
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Markus Jung <markus.jung85@gmail.com>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Replaced hard-coded uri to discovered uri for GET/PUT in occlient.cpp

occlient.cpp always made GET PUT requests on /a/light as ocserver was
built with /a/light.
Changed this to make requests to discovered resources to enable easier
testing for test engineers.

Change-Id: I642b1d83e46f91d92270d414dda933b6cf97240e
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2721
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Resolved Tizen RI sample build error for SECURED=1 and enabled build in Jenkins

Change-Id: Ide348722046cb4dcf962f7652b6a5f19794d5b83
Signed-off-by: vimala.v <vimala.v@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3259
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Fixed implicit declaration warning about OCSeedRandom() function.

Change-Id: I092496ed7dc0828cb4ec183426eedecb9c651458
Signed-off-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4247
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Fix payload logging related compile-time warnings.

Corrected format specifier for size_t typed value (%lld -> %zu).
Removed duplicate UUID_LENGTH definition.

Change-Id: Ia142247346cccbadea3a3c51d8e6f55af575c6ff
Signed-off-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4245
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Placed OC random functionality at common place for RI and CA to use

Moved OC random implementation to c_common folder to make it available for CA as well. As Seed Random should be called at common place for RI and CA.

Change-Id: I0a7cd674b9c4212b3a1d1e382aa1f455bec1a6d2
Signed-off-by: koushik.girijala <g.koushik@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4101
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Expose PISetup() API in Plugin Interface.

This puts the onus on the application layer to perform discovery
operations for their radio(s). This way the discovery operations can be
triggered via the appropriate actions for the application.

Change-Id: If5140b436159c74260dc30ac3d33401e62478b25
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3779
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Fixed issue of invalid value gets update even if attribute has allowed values property.

Other issues fixed:
1. Crash while editing resource properties when attribute's update automation is going on.
2. Update automation starts from previous state when resource is deleted and created with same properties as deleted one.

Change-Id: I0ab53a1ebc4b03fd4e7d281fed612ba1c1709268
Signed-off-by: Harish Kumara Marappa <h.marappa@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4231
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: RadhaBhavani <radha.p@samsung.com>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Add message length validation check code in case of wrong key

[Patch #1] Intial upload
[Patch #2] Modify according to comments.
[Patch #3] Retrigger
[Patch #4] Retrigger again!

Change-Id: I90e38f950aa07dafd058cf88591ef8f5af5ca367
Signed-off-by: leechul <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4189
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>

[PLUGIN-INTERFACE] Delete resources when a request has failed.

This will allow for the Plugin-Interface module to delete resources which
are no longer properly mapped.

Change-Id: I7a3f0022b49aa6ebdae016b7f416df2ced0952d7
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Signed-off-by: Thuyen Tran <thuyen.c.tran@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3791
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Collection resource support in SDK and Plug-in.

- Managing life cycle of collection resource.
- Supporting all types of attribute value in SimulatorResourceModel as supported in
OCRepresentation.
- Updated unit test cases.

JIRA: https://jira.iotivity.org/browse/IOT-836

Change-Id: Iba01f46477155adad64e69dec9cda192405b09ee
Signed-off-by: Harish Kumara Marappa <h.marappa@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4209
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>