Sangchul Lee [Mon, 13 Jan 2020 01:11:32 +0000 (10:11 +0900)]
mm_sound_plugin_codec_wave: Set client pid to PulseAudio property
[Version] 0.12.57
[Issue Type] Improvement
Change-Id: I756323dcfaa05eaf7584c4d6d16814242d137400
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 12 Nov 2019 05:16:06 +0000 (14:16 +0900)]
Add internal volume API set
Initially, this patch supports the bixby volume type.
[Version] 0.12.56
[Issue Type] New feature
Change-Id: Ib6739238356dd52aa2d519154ece65a892254dfa
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Seungbae Shin [Wed, 20 Nov 2019 04:54:48 +0000 (13:54 +0900)]
Retry when writing to keysound pipe is failed with 'Resource temporarily unavailable'
[Version] 0.12.55
[Issue Type] Improvement
Change-Id: Ib9e43afca246832b81b8e7dc4e559d66ba13194c
Sangchul Lee [Tue, 12 Nov 2019 09:11:04 +0000 (18:11 +0900)]
Remove the validation check of volume level in the client side
It was the only hard-coded condition which limits the maxium
volume level per each volume type. The rest of volume policy
has been implemented with fixing the maximum level by the values
in the volume table loaded inside of the PulseAudio.
[Version] 0.12.54
[Issue Type] Improvement
Change-Id: Id34f818764062da0060a8288f16e4281fd7aae05
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Mon, 11 Nov 2019 02:01:49 +0000 (11:01 +0900)]
mm_sound: Remove deprecated symbol - mm_sound_volume_remove_callback()
[Version] 0.12.53
[Issue Type] Clean-up
Change-Id: I45db42cae27ff0537e747118b85cbff5c241684c
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Seungbae Shin [Tue, 24 Sep 2019 03:30:41 +0000 (12:30 +0900)]
mm_sound_server: fix not to nofity complete callback in case of stopping wav playback
[Version] 0.12.52
[Issue Type] Bug
Change-Id: I89d6c270511a1f51f8c048484dda24226c0cd43b
Sangchul Lee [Fri, 20 Sep 2019 07:24:46 +0000 (16:24 +0900)]
mm_sound_server: Terminate the server when MMSoundThreadPoolRun() is failed
[Version] 0.12.51
[Issue Type] Crash
Change-Id: Ia58555507d775426dd1b4633e296f57c4635af2f
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 11 Sep 2019 08:09:27 +0000 (17:09 +0900)]
Add new function to update taken_info of nodes used right after invoking user callback
It'll reduce cyclomatic complexity of SAM.
[Version] 0.12.50
[Issue Type] Refactoring
Change-Id: Ife68840f015f82ab7cfd25dc3d54ecc792a197da
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 11 Sep 2019 02:32:26 +0000 (11:32 +0900)]
Add new function to check if it needs to trigger focus callback or not
It'll reduce cyclomatic complexity of SAM.
[Version] 0.12.49
[Issue Type] Refactoring
Change-Id: Ibc71f4192ffed181d1d9999dc5a3f48b512c5929
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 10 Sep 2019 08:02:03 +0000 (17:02 +0900)]
Add new function to get my focus node and apply it
It'll reduce cyclomatic complexity of SAM.
[Version] 0.12.48
[Issue Type] Refactoring
Change-Id: I3cc8ae7160161c3d2e52078fab268f8a710b99d7
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Seungbae Shin [Tue, 27 Aug 2019 11:39:28 +0000 (20:39 +0900)]
Use static keyword for global variables
[Version] 0.12.47
[Issue Type] Refactorying
Change-Id: I00460fb797eb41492c6b8223dce6fc39610a2fea
Seungbae Shin [Tue, 27 Aug 2019 10:40:55 +0000 (19:40 +0900)]
Remove unused handle mode enum for pa_client
[Version] 0.12.46
[Issue Type] Refactorying
Change-Id: I208d23d0bb9318d3a7b21de49ca1ee7f6968550c
Jeongmo Yang [Thu, 11 Jul 2019 05:59:40 +0000 (14:59 +0900)]
Add new functions to support ducking state changed callback
[Version] 0.12.45
[Profile] Common
[Issue Type] New feature
Change-Id: Ia4664b74e810320c39a268c7f5de1c829ef874e6
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
Hyotaek Shim [Tue, 9 Jul 2019 02:23:24 +0000 (11:23 +0900)]
Remove unused dependency of tizen-system.target
Change-Id: Iac2ed749279512e559f01df44ae7436e699af053
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
INSUN PYO [Mon, 24 Jun 2019 06:01:22 +0000 (15:01 +0900)]
Adjust the position of focus-server.path
Change-Id: I4afcb31ea237dfd2e0a379a1ff942a634624e6d3
INSUN PYO [Mon, 24 Jun 2019 02:23:46 +0000 (11:23 +0900)]
Change the config value of the systemd service ("false" -> "no")
"no" and "false" have the same meaning, but the document has "no".
Also, since the parsing order is "no" first, there is some performance gain.
Change-Id: Ia619d43197cdf42c6a430b9c32700e99483662af
Sangchul Lee [Tue, 18 Jun 2019 00:17:00 +0000 (09:17 +0900)]
Use MM_SOUND_DEVICE_TYPE_NETWORK renamed from _TYPE_RAOP
[Version] 0.12.44
[Issue Type] Improvement
Change-Id: I77ab3317bca9ae4d75d7c3e09ae735d1a9a188e1
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Fri, 24 May 2019 04:47:11 +0000 (13:47 +0900)]
Get stream list again if it doesn't seem to have done it before
stream list is obtained from PulseAudio via DBus during the initialization
of the focus server. Normally, PulseAudio is launched before this focus
server. It has no problem with the normal situation. If the sequence is
reversed for some reason, these new codes can get a chance to make it right.
[Version] 0.12.43
[Issue Type] Fault tolerance
Change-Id: I95007aa7ea8aecbf9f7212c6b0d2daaf6bee7806
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Mon, 29 Apr 2019 01:03:52 +0000 (10:03 +0900)]
Improve logic regarding focus reacquisition change in the callback
If reacquisition value is changed in the focus callback, taken_by_id
/taken_backup structures for both playback/capture of the node should
be updated.
[Version] 0.12.42
[Issue Type] Bug fix
Change-Id: I0161d0af91878909ae5c60b3072382d576955a80
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Fri, 22 Mar 2019 01:25:30 +0000 (10:25 +0900)]
Manage focus cb thread and focus watch cb thread separately
API is revised as below.
- int mm_sound_focus_is_cb_thread(bool *result)
+ int mm_sound_focus_is_cb_thread(bool *result, bool *is_for_watching)
[Version] 0.12.41
[Issue Type] Enhancement
Change-Id: Ib2cfa6b7b2425d5a37db224bb242c7c2a1651d14
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 19 Mar 2019 06:25:32 +0000 (15:25 +0900)]
Add to check the condition before unlocking mutex in focus watch callback handler
[Version] 0.12.40
[Issue Type] Bug fix
Change-Id: I767b8d1593ee92f8196a9bbdba9ade0ccdbdafa9
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Thu, 14 Feb 2019 08:25:14 +0000 (17:25 +0900)]
Add support for mute API set
[Version] 0.12.39
[Issue Type] New feature
Change-Id: I53276fe8e860eb97ba1b6aa4864ac10552ebf494
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Fri, 15 Feb 2019 01:23:24 +0000 (10:23 +0900)]
Remove unused symbols
[Version] 0.12.38
[Issue Type] Clean up
Change-Id: Iad1ca7700177a193390b1c2b6410c3080fce6577
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 13 Feb 2019 02:29:39 +0000 (11:29 +0900)]
Add mm_sound_is_stream_on_device_by_id()
[Version] 0.12.37
[Issue Type] API
Change-Id: I897d2198ec9fb592a0f75b5905cfad8568514ae1
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Seungbae Shin [Thu, 10 Jan 2019 03:52:48 +0000 (12:52 +0900)]
Apply -fPIC -pie on focus-server always due to non-prelink
[Version] 0.12.36
[Issue Type] Build
Change-Id: I1f04948b721abd973f8da7c92536a5480ed490aa
Seungbae Shin [Thu, 17 Jan 2019 10:52:33 +0000 (19:52 +0900)]
Fix SVACE defects : OP_PRECEDENCE_ASSIGN_CMP
[Version] 0.12.35
[Issue Type] Security vulnerability
Change-Id: I594c7f33c95500141c27d830b9b4cbb92b10f87f
Sangchul Lee [Mon, 14 Jan 2019 09:53:43 +0000 (18:53 +0900)]
Check for symbolic link vulnerability
Verfiy the absolute path by using realpath() and
unlink it if it seems to be unexpected symbolic link.
[Version] 0.12.34
[Issue Type] Security vulnerability
Change-Id: I82d85f1b2d3c218985f59463461dfc005ade5ccf
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Seungbae Shin [Thu, 20 Dec 2018 10:46:32 +0000 (19:46 +0900)]
Fix improper errno handling
[Version] 0.12.33
[Issue Type] Bug
Change-Id: If13ea55bbce212bf96581a66b9e464019e7b8819
Seungbae Shin [Fri, 14 Dec 2018 01:57:46 +0000 (10:57 +0900)]
fixup! Fix invalid format string
[Version] 0.12.32
[Issue Type] Build
Change-Id: Iff9e7ab2701743640c605867849b502a700c03e0
Seungbae Shin [Fri, 7 Dec 2018 06:52:04 +0000 (15:52 +0900)]
Fix invalid format string
[Version] 0.12.31
[Issue Type] Build
Change-Id: I17a4f2603d215e69864042c172c51d5c7db3c377
Seungbae Shin [Thu, 22 Nov 2018 05:45:15 +0000 (14:45 +0900)]
Add initial unittest
[Version] 0.12.30
[Issue Type] Test
Change-Id: I67946e26c90492d9d39cb6ee080be8e1d6a4e8bf
Sangchul Lee [Wed, 7 Nov 2018 07:42:04 +0000 (16:42 +0900)]
Enhance error handling in case of failure in focus_init_context()
operations of quitting mainloop and joining focus thread are added to error handling codes.
timeout for waiting run state of mainloop is also changed to 2.5 sec.
[Version] 0.12.29
[Issue Type] Enhancement
Change-Id: Ide47c174b531395d69a1aa9f45a4b381f4d505af
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Seungbae Shin [Tue, 10 Jul 2018 07:44:17 +0000 (16:44 +0900)]
Add MM_SOUND_DEVICE_TYPE_RAOP
[Version] 0.12.28
[Issue Type] Feature
Change-Id: I1533f03e174490ecf9ae4d64ef8c0d72c13617f4
Sangchul Lee [Mon, 20 Aug 2018 01:49:17 +0000 (10:49 +0900)]
Fix ASAN build break
Declaration of g_focus_sound_handle array is moved to mm_sound_focus_private.c
[Version] 0.12.27
[Issue Type] Bug fix
Change-Id: Idc5a03f7df22763b4cf71762489d7f4c0d7df45b
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 8 Aug 2018 06:41:04 +0000 (15:41 +0900)]
Fix coverity issues
[Version] 0.12.26
[Issue Type] Coverity
Change-Id: Ibea05053ed04c21c347471d9e885206ca944afc9
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Seungbae Shin [Fri, 3 Aug 2018 10:44:27 +0000 (19:44 +0900)]
Fix not to shutdown when playing streams.
[Version] 0.12.25
[Issue Type] Bug
Change-Id: I63ed17dce2a220c2374c0cdbff68bae0663ac1cd
Sangchul Lee [Thu, 2 Aug 2018 05:48:33 +0000 (14:48 +0900)]
Remove undefined symbol
The function has been already removed.
[Version] 0.12.24
[Issue Type] VD Build break
Change-Id: I7b5ad7eb825682c7be591c3a21053ead1a865edf
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 25 Jul 2018 06:55:37 +0000 (15:55 +0900)]
Revise error handling in mm_sound_proxy.c
[Version] 0.12.23
[Issue Type] Refactor and bug fix
Change-Id: If0b5bfa27d2d434b5a126df6a9d7ecd66e06e691
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Seungbae Shin [Fri, 29 Jun 2018 05:50:26 +0000 (14:50 +0900)]
Fix stack-buffer-overflow bug issued by ASAN
[Version] 0.12.22
[Issue Type] Bug
Change-Id: If94c462f9e586a56a3e26bfdfe4256c1894df6f1
Seungbae Shin [Thu, 28 Jun 2018 12:11:08 +0000 (21:11 +0900)]
Fix use-after-free bug issued by ASAN
[Version] 0.12.21
[Issue Type] Bug
Change-Id: I324875fd1aedfec9f91560b701c1062c7fb52b20
Sangchul Lee [Fri, 15 Dec 2017 09:05:12 +0000 (18:05 +0900)]
Use socket for IPC of focus APIs instead of the DBus
The benefits of this change are here.
- Connection is established when registering a focus node. This leads to
remove the previous signal handler for cleaning focus resources.
- Response time is enhanced as per the change of IPC.(DBus to socket)
[Version] 0.12.20
[Issue Type] Enhancement
Change-Id: Ifbc3ecde29985e9150ed7429b8616ef6cbe99d92
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Jungsup Lee [Wed, 30 May 2018 02:06:02 +0000 (11:06 +0900)]
Fix Wformat build error
[Version] 0.12.19
[Issue Type] Build break
Change-Id: I65a370861867d2630b84d8d6f7ce09554fe658e3
Signed-off-by: Jungsup Lee <jungsup4.lee@samsung.com>
Sangchul Lee [Thu, 10 May 2018 02:35:26 +0000 (11:35 +0900)]
Fix unchecked return value
[Version] 0.12.18
[Issue Type] Coverity (CID 118319)
Change-Id: I04aa31259c6a7f6d433ee91517d8aa9adf591148
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Thu, 10 May 2018 03:21:22 +0000 (12:21 +0900)]
Correct signature of internal function that does not require return value
svace info : Redundant comparison 'ret' == '0' (0 == 0) is always true at
mm_sound_plugin_codec_wave.c:604.
[Version] 0.12.17
[Issue Type] SVACE (WGID 34314)
Change-Id: I9e89b3fca2b98f45a5e97ae30fb6a122ed2689d5
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Seungbae Shin [Fri, 4 May 2018 09:06:50 +0000 (18:06 +0900)]
Apply deny policy for default context in dbus conf
Applied to both sound-server / focus-server
[Version] 0.12.16
[Issue Type] Security
Change-Id: Idb3c93ae5397269089eed1f0f351d5ff467b0878
Seungbae Shin [Thu, 26 Apr 2018 12:47:55 +0000 (21:47 +0900)]
Fix float->int(short) clipping issue when playing ogg content
related reference:
http://www.mega-nerd.com/libsndfile/api.html#note2
https://github.com/erikd/libsndfile/issues/194
[Version] 0.12.15
[Issue Type] Bug Fix
Change-Id: I60894d8286c53999c5d907c486a10ca7a88dd95a
Seungbae Shin [Tue, 24 Apr 2018 11:36:26 +0000 (20:36 +0900)]
Fix coverity defects
fix minor build warning
[Version] 0.12.14
[Issue Type] Security
Change-Id: I5eee1290de2fb381f61078e099e566ae166e530e
Seungbae Shin [Mon, 23 Apr 2018 10:14:06 +0000 (19:14 +0900)]
Fix for TV product build macro
[Version] 0.12.13
[Issue Type] Build
Change-Id: Ib717c739ef11c46425ee9163394a3ebdbcc7c3b2
Sangchul Lee [Thu, 16 Nov 2017 08:20:56 +0000 (17:20 +0900)]
Remove deprecated APIs and codes for session backward compatibility
[Version] 0.12.12
[Issue Type] Clean-up
Change-Id: I7545981ceafe13d56e9c4fa9d99227d6e326f631
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Seungbae Shin [Tue, 13 Mar 2018 07:38:16 +0000 (16:38 +0900)]
Fix SVACE defects
[Version] 0.12.12
[Issue Type] Security
Change-Id: Id681c147e6b346e7391e0f635d5ff92d49ca6b48
Jungsup Lee [Tue, 20 Feb 2018 04:43:12 +0000 (13:43 +0900)]
Check pulseaudio ready file in _mm_sound_play_keysound
Check "/tmp/.pulseaudio_ready" file before access "/tmp/keytone"
[Version] 0.12.11
[Issue Type] Bug Fix
Signed-off-by: Jungsup Lee <jungsup4.lee@samsung.com>
Change-Id: Ib5d91e2733bdf390f277faf1efcb2d4cdfbbec48
Sangchul Lee [Tue, 16 Jan 2018 00:25:49 +0000 (09:25 +0900)]
Extend timeout period of waiting for mainloop running
Sometimes it takes long time to change its state to "running" especially on TV target.
[Version] 0.12.10
[Issue Type] Enhancement
Change-Id: I2192047295794fbd21ca2a541826eaac1ed7c5f9
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Seungbae Shin [Wed, 10 Jan 2018 12:58:07 +0000 (21:58 +0900)]
Add TV BT device when current device list query
[Version] 0.12.9
[Profile] TV
[Issue Type] Bug
Change-Id: I74998313adbd54ac99094a1f68f34e983723d767
Sangchul Lee [Wed, 20 Dec 2017 02:45:53 +0000 (11:45 +0900)]
Revise service file to add capabilities option
[Version] 0.12.8
[Issue Type] Enhancement
Change-Id: Ieefd933534c94d4af36678cd78d05fe8659fb7bb
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Seungbae Shin [Tue, 6 Feb 2018 09:22:13 +0000 (18:22 +0900)]
Remove unused / unnecessary usage of pa simple
[Version] 0.12.7
[Issue Type] Build
Change-Id: I8f593a868df18d458aec256c44b5e2ece187c5d9
Seungbae Shin [Fri, 15 Dec 2017 04:40:14 +0000 (13:40 +0900)]
Remove dlog prints on signal handler / dotnet cleanup
[Version] 0.12.6
[Issue Type] Enhancement
Change-Id: Ib73de0cbd07d3648d4aa500a9a2d8f5ea1670275
Seungbae Shin [Thu, 7 Dec 2017 11:28:15 +0000 (20:28 +0900)]
Fix memory leak after wav playback
threaded_mainloop was not removed after wav playback,
now it will be removed on seperate temporal thread
(we can't remove from inside of mainloop thread)
in addition, change shutdown timeout from 10 to 60 sec.
(I think 10 sec. might be too short)
[Version] 0.12.5
[Issue Type] Bug Fix
Change-Id: Ic3a0053812fc3f31c344b9170a0684c656a97648
Seungbae Shin [Thu, 23 Nov 2017 14:32:39 +0000 (23:32 +0900)]
fixup! Fix build warnings
[Version] 0.12.4
[Issue Type] Warning
Change-Id: Ie402f9bfa739dfba422ecffc9993a258b5cb39f8
Seungbae Shin [Tue, 14 Nov 2017 09:13:11 +0000 (18:13 +0900)]
Fix build warnings
[Version] 0.12.3
[Issue Type] Warning
Change-Id: I16f7dafeb0a7fb70971255ffedeb8490b4b1d6f3
Sangchul Lee [Tue, 7 Nov 2017 02:47:07 +0000 (11:47 +0900)]
Remove unused argument
[Version] 0.12.2
[Issue Type] Fix warning
Change-Id: Ie55d69f874d27664489ad72b47394e45d871fb36
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 27 Sep 2017 02:51:46 +0000 (11:51 +0900)]
Add support for device running changed callback
- mm_sound_add_device_running_changed_callback()
- mm_sound_remove_device_running_changed_callback()
- mm_sound_is_device_running()
Functions for change of running state are added. Previous device functions
including callback could not represent a device state related to its audio streams.
Now, these new APIs provide functionality regarding the 'running' state based on
the fundamental rule of that a device will be changed to 'running' only if
any stream go through the device.
[Version] 0.12.1
[Issue Type] New APIs
Change-Id: I79c164f706a5903cd2c6c76902d69c11a55ddbc3
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 1 Nov 2017 00:31:14 +0000 (09:31 +0900)]
focus_server: copy pid of node that will be used for session backward compatibility
This pid information will be used to each multimedia framework to keep session behavior.
[Version] 0.11.31
[Issue Type] backward compatibility
Change-Id: I4f52b7f29d28b1f5d3ad0388e2df42f6d3bf32aa
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Seungbae Shin [Thu, 26 Oct 2017 05:47:08 +0000 (14:47 +0900)]
fixup! Fix Coverity defects
[Version] 0.11.30
[Issue Type] Bug Fix
Change-Id: I3931e5811379eaae5596a893c39c26d11e971872
(cherry picked from commit
ec308faabad9c5b5c06b68438b391c38ce9716b5)
Seungbae Shin [Tue, 12 Sep 2017 06:02:59 +0000 (15:02 +0900)]
Modification for Tizen Coding Rule
Change-Id: I05fe4103c333f75b0ac85387c197ad2899026dfa
(cherry picked from commit
0f3a484264047bcccb8804e72db68420f3509a27)
Seungbae Shin [Mon, 16 Oct 2017 11:39:53 +0000 (20:39 +0900)]
disable signal handler for VD dotnet application, cleanup will be done by external call
fix for coding rule included
[Version] 0.11.29
[Issue Type] Product / Dotnet
Change-Id: I5ed9ec1bc21bfddfd553d577bb048870123c8c50
(cherry picked from commit
c5426e625d881fa2e75e2e5ba5d404c8c9166169)
Sangchul Lee [Wed, 18 Oct 2017 01:27:48 +0000 (10:27 +0900)]
Forward error from dbus method properly in mm_sound_proxy.c
[Version] 0.11.28
[Issue Type] Bug Fix
Change-Id: I1c4531df4983658f58db8b50a57fb32153015f9e
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Mon, 16 Oct 2017 01:59:02 +0000 (10:59 +0900)]
Free device list from first node
[Version] 0.11.27
[Issue Type] Memory leak
Change-Id: Ibc10c0f2f7619bd92d927c546f9922b456adfa71
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Seungbae Shin [Tue, 10 Oct 2017 10:14:13 +0000 (19:14 +0900)]
Fix Coverity defects
[Version] 0.11.26
[Issue Type] Security
Change-Id: I83114daea560103ce66ee03fc0f86399c891fcc1
Sangchul Lee [Wed, 20 Sep 2017 09:45:12 +0000 (18:45 +0900)]
focus_server: Fix bug regarding update of reacquisition information within focus callback
It is also modified regarding conding convention
[Version] 0.11.25
[Issue Type] Bug fix
Change-Id: Id6a84b0c2f392aea4aa5c390a783720f95c038a3
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Thu, 14 Sep 2017 08:01:23 +0000 (17:01 +0900)]
Remove useless build config
exclude MM_DEBUG_FLAG from CFLAGS
[Version] 0.11.24
[Issue Type] Cleanup
Change-Id: Iaf26d9c1a95b8dd8b29ded787b2b3012a2246faf
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Thu, 14 Sep 2017 03:22:30 +0000 (12:22 +0900)]
Remove dependency of libmm-log
[Version] 0.11.23
[Issue Type] Cleanup
Change-Id: I8ffb472f6ce7b119afd5c5f2ce2e538512ab659d
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Mon, 4 Sep 2017 06:59:30 +0000 (15:59 +0900)]
Revise dbus error handling codes to be more defensive
[Version] 0.11.22
[Issue Type] Enhancement
Change-Id: Ic433b6e794efc9256799a4bc09cdb535655b8e76
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 29 Aug 2017 04:56:00 +0000 (13:56 +0900)]
Use mutex for focus index only when it is not for session in mm_sound_client_set_focus_reacquisition()
Since the muse server which uses this library for multiple handles executes requests from clients serially,
we can skip locking/unlocking the mutex for this case.
[Version] 0.11.21
[Issue Type] Enhancement
Change-Id: Ib90eb2c5f20086c048c7cae52ee9e4037cab265b
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Seungbae Shin [Tue, 22 Aug 2017 04:47:04 +0000 (13:47 +0900)]
fixup! Do not raise() inside signal handler
[Version] 0.11.20
[Issue Type] Revise
Change-Id: I62f9cb32009421810581ca689e5e194b5492c645
Seungbae Shin [Tue, 22 Aug 2017 04:45:37 +0000 (13:45 +0900)]
fixup! focus-server: Apply umask(0) to change access permissions of its files
Change-Id: Ie36dc6e99bc06f7d38220208f920fe7d22b9f491
Seungbae Shin [Fri, 18 Aug 2017 08:05:02 +0000 (17:05 +0900)]
Do not raise() inside signal handler
[Version] 0.11.19
[Issue Type] Cleanup
Change-Id: I17e3d04d75b54bdec9a29aa45575f32e0de89903
Sangchul Lee [Mon, 21 Aug 2017 00:56:12 +0000 (09:56 +0900)]
focus-server: Apply umask(0) to change access permissions of its files
[Version] 0.11.18
[Issue Type] Enhancement
Change-Id: I7a46d3ea7df6cef23301175dccc5d6c4a553fecb
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Thu, 17 Aug 2017 08:05:29 +0000 (17:05 +0900)]
focus-server: fix bug of invoking monitor callback of other nodes
[Version] 0.11.17
[Issue Type] Bug
Change-Id: I630cb5420f2addb4666e398f3fcd38af3143ae51
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Thu, 17 Aug 2017 04:35:06 +0000 (13:35 +0900)]
fix invalid parameter in error log
[Version] 0.11.16
[Issue Type] Bug
Change-Id: Ib825e9c02459b5d498d50d4045e1899721710b82
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Seungbae Shin [Thu, 3 Aug 2017 05:54:43 +0000 (14:54 +0900)]
fixup! Move volume vconf set to pulseaudio
- Fix for returning permission error properly if set_volume without privilege
- Revise codes based on coding rule
[Version] 0.11.15
[Profile] Common
[Issue Type] Bug
Change-Id: I37a8171de8382aa011659d8fd2ac3212d3becd0e
Jungsup Lee [Mon, 24 Jul 2017 04:26:32 +0000 (13:26 +0900)]
Add notstrip file for TV
Add libmm-sound.notstrip file
[Version] 0.11.15
[Profile] TV
[Issue Type] Requirement
Signed-off-by: Jungsup Lee <jungsup4.lee@samsung.com>
Change-Id: Ie404d8e31f14faf50dbca8b0a60b0efc21800d77
Seungbae Shin [Tue, 18 Jul 2017 07:07:42 +0000 (16:07 +0900)]
Revise unnecessary logs, remove build warnings
[Version] 0.11.14
[Issue Type] Cleanup
Change-Id: I3168b80a822f054a073f76ff7acaf448c2dd01c2
Seungbae Shin [Tue, 18 Jul 2017 11:45:33 +0000 (20:45 +0900)]
Fix possible buffer overflow using strncat
+ Remove unnecessary getenv code
[Version] 0.11.13
[Profile] Common
[Issue Type] Security
Change-Id: Ief1e7f38562eacd4a4fea2e04bc726197c1d6d94
Seungbae Shin [Fri, 14 Jul 2017 11:40:06 +0000 (20:40 +0900)]
fixup! Fix use-after-free crash during get empty codec slot
reset of shutdown timer was missing during new handle is created
[Version] 0.11.12
[Issue Type] Bug
Change-Id: I8915ae1ebbe57d7b34d8889212fd7808b1103802
Seungbae Shin [Mon, 3 Jul 2017 12:23:54 +0000 (21:23 +0900)]
Move volume vconf set to pulseaudio
[Version] 0.11.11
[Profile] Common
[Issue Type] Requirement
Change-Id: I6f8be5668a6e32ad7f498ea6c8c5add6cb45879c
Sangchul Lee [Thu, 29 Jun 2017 07:14:09 +0000 (16:14 +0900)]
Remove capability options in spec file and those will be moved to security-config package
[Version] 0.11.10
[Issue Type] spec
Change-Id: If6a727c0deb0664b1ed65b3f92d095ab0ebbcbbe
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Seungbae Shin [Fri, 19 May 2017 10:34:02 +0000 (19:34 +0900)]
Fix use-after-free crash during get empty codec slot
Issue detected using libFuzzer, patch provided by SQE.
[Version] 0.11.9
[Profile] Common
[Issue Type] Enhancement
Change-Id: I9dc7afa7a3733bebd03c634a8400ccfb0aebf0f3
Sangchul Lee [Tue, 13 Jun 2017 08:08:21 +0000 (17:08 +0900)]
focus_server: Apply new macro
CONTINUE_IF_LIST_DATA_IS_NULL(x_node, x_list)
CONTINUE_IF_NOT_MY_FOCUS_NODE(x_node, x_param)
[Version] 0.11.8
[Profile] Common
[Issue Type] Refactoring
Change-Id: I191793ab7fb8b9eebd359b365458f349494a89bf
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Mon, 12 Jun 2017 02:51:42 +0000 (11:51 +0900)]
focus_server: Add support for delivery focus to another node
[Version] 0.11.7
[Profile] Common
[Issue Type] New feature
Change-Id: I685153d97900881e07b0c95e6c405e335da8cf99
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Jeongho Mok [Mon, 12 Jun 2017 08:31:37 +0000 (17:31 +0900)]
Add device property vendor/product id for USB
[Version] 0.11.6
[Profile] Common
[Issue Type] Enhancement
Change-Id: Ifdfc3f47efd82c6097fa9ef5a4b539ca626bced3
Seungbae Shin [Mon, 5 Jun 2017 08:08:18 +0000 (17:08 +0900)]
[SQE][LibFuzzer] Fix opened file descriptors cleanup in libmm-sound
[Version] 0.11.5
[Profile] Common
[Issue Type] SQE
Change-Id: I2c241b1d61e5041b68beb3ed9c43eecc2ccdbf24
Jeongho Mok [Thu, 1 Jun 2017 05:01:39 +0000 (14:01 +0900)]
testsuite: Fix fgets error handling branch
[Version] 0.11.4
[Profile] Common
[Issue Type] Testsuite
Change-Id: I033e141174d39cd3bb69fd760074e984f4fb865f
Jeongho Mok [Thu, 1 Jun 2017 07:06:12 +0000 (16:06 +0900)]
Fix invalid signature of mm_sound_get_device_by_id
[Version] 0.11.4
[Profile] Common
[Issue Type] Enhancement
Change-Id: I7ffd3ae656937012110ae82e90d505285fa2e6e6
Jeongho Mok [Tue, 30 May 2017 04:44:18 +0000 (13:44 +0900)]
Get device by id
[Version] 0.11.3
[Profile] Common
[Issue Type] Enhancement
Change-Id: I140885278aa8bab3d5fabc5c0a0860b38d6fde9a
Sangchul Lee [Tue, 16 May 2017 05:10:43 +0000 (14:10 +0900)]
Skip invoking watch callback if the request is coming from the watch callback
It is possible that request of acquiring/releasing focus can be executed within
focus watch callback. In this case, focus server can try to invoke the focus
watch callback of same node again based on conditions and then it gets blocked.
This patch avoids situation by skipping the callback again.
[Version] 0.11.2
[Issue Type] Enhancement
Change-Id: I2fc337227fa75dfb2d6f660fbc6c2fe4977b0548
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Fri, 12 May 2017 05:41:19 +0000 (14:41 +0900)]
Add support for acquiring/releasing focus within focus callback
Added socket infrastructure for new IPC.
Added signal handler to deinitialize resources.
[Version] 0.11.1
[Issue Type] Enhancement
Change-Id: Ia497cc7e651221cc5dcfeb58518194c877cf7458
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Seungbae Shin [Thu, 25 May 2017 13:58:06 +0000 (22:58 +0900)]
Remove version from plugin so, remove symbolic link
few build warnings are removed also
[Version] 0.10.115
[Profile] Common
[Issue Type] Enhancement
Change-Id: Ia6657a1f82b090b9f62ee0b05c33426b7116ee3c
Sangchul Lee [Thu, 11 May 2017 07:26:15 +0000 (16:26 +0900)]
Add exception case as per the previous session policy when releasing focus
- session resumption is only available for media session.
[Version] 0.10.115
[Issue Type] Backward compatibility
Change-Id: I2d56838d0eb3d4c3116115205dd2e81842a439b8
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 18 Apr 2017 01:04:30 +0000 (10:04 +0900)]
FOCUS_TYPE_BOTH can be passed to argument of mm_sound_mgr_focus_get_stream_type_of_acquired_focus()
Some codes that check validation of arguments are also added.
[Version] 0.10.114
[Profile] Common
[Issue Type] Enhancement
Change-Id: Ie286d59afe7c98bb5f0c7774b19a660dedc4a057
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Fri, 14 Apr 2017 07:16:35 +0000 (16:16 +0900)]
Invoke focus watch callback when unregistering node with acquired state
Even though there's no node which has lost the focus by this unregistering node,
focus watch callbacks should be called in contrast with focus state callback.
Revise wrong condition of invoking monitor callback.
[Version] 0.10.113
[Profile] Common
[Issue Type] Bug fix
Change-Id: I83fb18081ea94f4e26f7a3aaf158fb0357d7a108
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>