Rafal Walczyna [Tue, 25 Aug 2020 07:29:53 +0000 (09:29 +0200)]
[MediaController] Add locks for variable used in different threads
Handles for client and server can be used in different threads.
It may cause segmentation fault when already freed handle will be used.
Verification: Build successful
Change-Id: Iba90d1a85be51710ccda169389ce393f5ce1d1a3
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Piotr Kosko [Wed, 10 Jun 2020 11:19:07 +0000 (13:19 +0200)]
[Systeminfo] Fixed behaviour of Network property
[Bug] When using device with not supported feature
http://tizen.org/feature/network.telephony
e.g. R800 device, below code returns no error:
tizen.systeminfo.getPropertyValueArray("NETWORK", (s) => {console.log(s)}, (s) => {console.log(s)})
listener for "NETWORK" property is never triggered also:
tizen.systeminfo.addPropertyValueChangeListener("NETWORK", (s) => console.log(s));
[verification]
Systeminfo TCT 100% passrate.
After fix, listener and getter works properly on TW3.
Change-Id: I9f0d533055926d186305fb7c39418de1fed76f5b
Piotr Kosko [Fri, 29 May 2020 10:06:12 +0000 (12:06 +0200)]
Merge branch 'tizen_4.0' into tizen_5.0
Change-Id: If003c06d7b3ed61e67b370011b59993e7f211d69
Piotr Kosko [Fri, 29 May 2020 09:59:52 +0000 (11:59 +0200)]
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: I00cb2f4c2c127315e11546b3d244f25208f921f3
Piotr Kosko [Fri, 29 May 2020 09:11:31 +0000 (11:11 +0200)]
[version] 2.42
Change-Id: I21e64688f0d19c08c7ce6ce28b1c1209c3c3d04d
Michal Michalski [Thu, 28 May 2020 11:47:22 +0000 (13:47 +0200)]
[archive] Fix paths comparator for permissions dictionary.
[Verification] tct-archive-tizen-tests 100% pass rate on TM1 emulator.
Change-Id: I675857a5f1335d8fb28a623ff15edc2d6d1aa8b5
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Piotr Kosko [Thu, 26 Mar 2020 09:09:19 +0000 (10:09 +0100)]
Merge branch 'tizen_4.0' into tizen_5.0
Change-Id: Iba85c9ce0c49127d8cbe14687d6e21cb5e9bb444
Piotr Kosko [Thu, 26 Mar 2020 08:32:14 +0000 (09:32 +0100)]
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: Ifbd17f0ca3fcaa5922f6a2194c5f2ffc007ee1c6
Piotr Kosko [Thu, 26 Mar 2020 08:30:38 +0000 (09:30 +0100)]
[version] 2.41
Change-Id: If5ba0f4ac89de2b51259a0a94be4a3a2f156e5a5
Piotr Kosko [Thu, 26 Mar 2020 07:41:59 +0000 (08:41 +0100)]
[Alarm] Fixed Coverity issue and undefined behaviour
[Coverity] 1134493
Change-Id: I3c9aa41a640efc6ca001ea96978374994a88e029
[version] 2.47
Change-Id: I2960e1b4a2214206304d3a944814bcc37f140a85
Revert "[Application] Make launch() and launchAppControl() asynchronous"
This reverts commit
b6cff5d0cf62f059dc2cf5e64208d05794d31f5d.
[Verification]
TCT application - 100%
TCT deprecated - 100%
Change-Id: I1d1c42cfa5c5731ce329525b7007127b56de796b
Merge branch 'tizen_4.0' into tizen_5.0
Change-Id: I47343e6732942b125e9eae672626a60967704062
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: I1bd47bf631acfcd842c26a5076c3538d8cbe8247
[version] 2.40
Change-Id: I06a43e95787fe3e97fc87cbaaee7f2e430b99b97
Pawel Wasowski [Wed, 8 Jan 2020 10:28:08 +0000 (11:28 +0100)]
[Archive] Prevent extracting files with ".." in relative paths
This change mitigates a potential security issue, which could occur if
a zip archive contained files with ".." in their paths.
ArchiveEntry.extract() and Archive.extractAll() will not extract such
files.
Verification: auto tct-tizen-archive-tests pass rate: 100%
Manual tests: attempts to extract files with forbidden
".." results in an UnknownError.
Change-Id: I563744d834d24e896493f55d15e579e714d539f9
Signed-off-by: Pawel Wasowski <p.wasowski2@samsung.com>
Merge branch 'tizen_4.0' into tizen_5.0
Change-Id: Ib491adc102418f59ef279fc47d45a7ef3f867569
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: I46b19761d8c18ed668e27a078c7e8094c1dde614
[version] 2.39
Change-Id: I4b83c04cba5ab218c11cefdbffd4e89054f54540
[Messageport] Fixed listener issues
[Bugs]
* There was a problem with missing unregistration of
listeners for local ports, it was added.
* There was invalid calling of listeners (only latest listener was called),
now each registered listener is called properly.
[Verification] Messageport TCT passrate 100%.
Below scenario calls 3 different callbacks:
abc = tizen.messageport.requestLocalMessagePort("abc");
abc.addMessagePortListener((data, name) => {console.log(abc.messagePortName + " -> \"" + data + "\" : \"" + name + "\"")} );
abc.addMessagePortListener((data, name) => {console.log("2" + abc.messagePortName + " -> \"" + data + "\" : \"" + name + "\"")} );
abc.addMessagePortListener((data, name) => {console.log("3" + abc.messagePortName + " -> \"" + data + "\" : \"" + name + "\"")} );
abc_remote = tizen.messageport.requestRemoteMessagePort(tizen.application.getCurrentApplication().appInfo.id, "abc");
abc_remote.sendMessage([{key: "key1", value: "val1"}]);
Change-Id: If3a4b362de76599904c83737137c0d0cd4d023c7
Merge branch 'tizen_4.0' into tizen_5.0
Change-Id: I6272ee91b469df02a70c0ddea192ef9cc46b0123
[version] 2.39
Change-Id: I06df52433c2f8c159d42ae7ad11e10531b13a60d
[Code format] Fixed formatting issues
Change-Id: Ieb6000829e03777e709ecfa9e447185975828866
Piotr Kosko [Mon, 2 Dec 2019 11:21:50 +0000 (11:21 +0000)]
Merge "[ham] Fixed sleep recorder, returned value" into tizen_4.0
[ham] Fixed sleep recorder, returned value
[Bug] there was missing conversion from numerical value from database to string value used in Web API
[Verification] TCT passrate 100% on wearable TW3.
Below code works when activity added manually to database.
var data = [];
date = new Date(), startTime = date.getTime(), endTime = date.setDate(date.getDate() + 1),
query = {
startTime: startTime/1000,
endTime: endTime/1000,
interval: 1440
};
tizen.humanactivitymonitor.readRecorderData("SLEEP_MONITOR", query, (s) => console.log(data = s), (s) => console.log(s))
returns one of values of "ASLEEP", "AWAKE", or "UNKNOWN"
Change-Id: I86b6bead534638bafcb5abcb16512bb462c79374
[ham] Fixed sleep recorder, returned value
[Bug] there was missing conversion from numerical value from database to string value used in Web API
[Verification] TCT passrate 100% on wearable TW3.
Below code works when activity added manually to database.
var data = [];
date = new Date(), startTime = date.getTime(), endTime = date.setDate(date.getDate() + 1),
query = {
startTime: startTime/1000,
endTime: endTime/1000,
interval: 1440
};
tizen.humanactivitymonitor.readRecorderData("SLEEP_MONITOR", query, (s) => console.log(data = s), (s) => console.log(s))
returns one of values of "ASLEEP", "AWAKE", or "UNKNOWN"
Change-Id: I86b6bead534638bafcb5abcb16512bb462c79374
[ham] Fixed sleep recorder, returned value
[Bug] there was missing conversion from numerical value from database to string value used in Web API
[Verification] TCT passrate 100% on wearable TW3.
Below code works when activity added manually to database.
var data = [];
date = new Date(), startTime = date.getTime(), endTime = date.setDate(date.getDate() + 1),
query = {
startTime: startTime/1000,
endTime: endTime/1000,
interval: 1440
};
tizen.humanactivitymonitor.readRecorderData("SLEEP_MONITOR", query, (s) => console.log(data = s), (s) => console.log(s))
returns one of values of "ASLEEP", "AWAKE", or "UNKNOWN"
Change-Id: I86b6bead534638bafcb5abcb16512bb462c79374
Piotr Kosko [Mon, 2 Dec 2019 07:21:30 +0000 (07:21 +0000)]
Merge "[MediaController] Fix removing invalid listener" into tizen_4.0
Merge branch 'tizen_4.0' into tizen_5.0
Change-Id: I0e0154add6a286b1fb259a2d973210d3887c3a94
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: I19c718eb38545fda3bf0b49403e1cbd88960ec4f
[version] 2.38
Change-Id: Id74d1d21292bd36c33771009e5a6fac0bd50537b
Rafal Walczyna [Thu, 21 Nov 2019 10:46:10 +0000 (11:46 +0100)]
[MediaController] Fix removing invalid listener
CommandListener was removed instead of ChangeRequestPlaybackInfoListener.
It was impossible to add ChangeRequestPlaybackInfoListener again.
Verification: tct passrate 100%.
Tested in GoogleChrome console on TM1 and KantM2.
Change-Id: Iff0ea6026581b3649592ee5bde3bfb625ceb35e4
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Rafal Walczyna [Thu, 21 Nov 2019 10:46:10 +0000 (11:46 +0100)]
[MediaController] Fix removing invalid listener
CommandListener was removed instead of ChangeRequestPlaybackInfoListener.
It was impossible to add ChangeRequestPlaybackInfoListener again.
Verification: tct passrate 100%.
Tested in GoogleChrome console on TM1 and KantM2.
Change-Id: Iff0ea6026581b3649592ee5bde3bfb625ceb35e4
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Merge branch 'tizen_4.0' into tizen_5.0
Change-Id: I2b03c54dc49d3de0aafbf08bd5f037ce97ecd2ec
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: Icba6eb40bb40a300befb71d01aa07320ea68b069
[version] 2.37
Change-Id: Ib1de6d53a704c6321d70c5202b5a5fcc3b055ead
Rafal Walczyna [Tue, 29 Oct 2019 12:58:14 +0000 (13:58 +0100)]
[filesystem] Fix getAllStorages
Fixed bug which causes to show duplicated values of internal
and external storages
[verification] Filesystem and Archive tct - 100% pass.
Change-Id: Ic087583a906eecfa040d97cb903f4c99838c6591
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Rafal Walczyna [Tue, 29 Oct 2019 12:58:14 +0000 (13:58 +0100)]
[filesystem] Fix getAllStorages
Fixed bug which causes to show duplicated values of internal
and external storages
[verification] Filesystem and Archive tct - 100% pass.
Change-Id: Ic087583a906eecfa040d97cb903f4c99838c6591
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Rafal Walczyna [Tue, 29 Oct 2019 12:58:14 +0000 (13:58 +0100)]
[filesystem] Fix getAllStorages
Fixed bug which causes to show duplicated values of internal
and external storages
[verification] Filesystem and Archive tct - 100% pass.
Change-Id: Ic087583a906eecfa040d97cb903f4c99838c6591
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Merge branch 'tizen_4.0' into tizen_5.0
Change-Id: I486c2595028dc8e9cf7555aa13ae114fe8af7be3
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: I99c57c205dd95970412c98430b9998c773a94917
[version] 2.36
Change-Id: I99c7c0258b677468f6a163e03a7807411dbbde56
[Bluetooth] Fixed issues related to BLE
[Bug/Fix]
1. Prevent possible crash in case of invalid data passed from native
2. Prevent type mismatch exception in JS in case of LE devices advertising
serviceData.
[Verification] tct passrate 100%
Checked in chrome console and le device with serviceData.
Change-Id: Iecc9929a77a1acfd1b33eb325ea287011b9a6096
Merge branch 'tizen_4.0' into tizen_5.0
Change-Id: I6307aead894899f049bacde9cb8af54febe91251
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: Iea1a8a0914572301a28c53d54bf64c795237ce44
[version] 2.35
Change-Id: Ifc5a4e534e395579031af9d3d115389b7545ab77
Rafal Walczyna [Fri, 27 Sep 2019 08:33:30 +0000 (10:33 +0200)]
[Filesystem] Source code auto-formatting
Used: ./code_format src/ -c -js
Change-Id: I1a27efa220445342ec42ef5327d06ac7bdd40ca9
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Szymon Jastrzebski [Fri, 12 Jan 2018 10:07:53 +0000 (11:07 +0100)]
[Archive] Fix for retrieving virtual roots
Current implmentation gets only internal virtual roots. This change adds
getting external roots as well.
[Verification] TCT Archive passed with 100% p.r.
Change-Id: Ia961dd276901ed31d42b22d93148d51066276163
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Rafal Walczyna [Tue, 24 Sep 2019 14:23:38 +0000 (16:23 +0200)]
[Filesystem] List of virtual roots for resolve function fixed.
Current implementation of virtual roots list did not include internal0 or
external memory i.e. SDCard or USBDrive. It results in not working resolve()
function, when location to resolve was on external memory.
Verification: TCT - 100 % pass.
Change-Id: I11c2537a7f5643f8c9ccfe2f45be9f3bce3edf00
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Arkadiusz Pietraszek [Mon, 22 Jul 2019 12:48:41 +0000 (14:48 +0200)]
Merge branch 'tizen_4.0' into tizen_5.0
Change-Id: Id7abc98f999b2bfb8dc0b49692f688f1b4c9ee9f
Piotr Kosko [Mon, 22 Jul 2019 12:30:05 +0000 (12:30 +0000)]
Merge "[Application] Fixed path of getAppSharedURI" into tizen_5.0
[Application] Fixed path of getAppSharedURI
Application should return path to the 'shared' directory which follows
the description of 'shared' directory content available here:
https://developer.tizen.org/development/training/native-application/understanding-tizen-programming/file-system-directory-hierarchy
New application returns the path like:
sh-3.2# ls -al /opt/usr/home/owner/apps_rw/org.example.basic/shared/
total 20
drwxr-xr-x 4 owner users 4096 Jul 18 13:06 .
drwxr-xr-x 5 owner users 4096 Jul 18 13:06 ..
drwxrwsr-x 2 owner system_share 4096 Jul 18 13:06 data
lrwxrwxrwx 1 app_fw app_fw 58 Jul 18 13:06 res -> /opt/usr/globalapps/org.example.basic/shared/res
drwxr-xr-x 2 owner users 4096 Jul 18 13:06 trusted
Instead of the previous result:
sh-3.2# ls -al /opt/usr/globalapps/org.example.basic/shared/
total 12
drwxr-xr-x 3 tizenglobalapp root 4096 Jul 18 13:06 .
drwxr-xr-x 6 tizenglobalapp root 4096 Jul 18 13:06 ..
drwxr-xr-x 2 tizenglobalapp root 4096 Jul 18 13:06 res
[Verification] Checked manually in chrome console
TCT Application 100% passrate
Change-Id: I0032c10bf2d98487117cd0049103767f9c7f1d09
[Application] Fixed path of getAppSharedURI
Application should return path to the 'shared' directory which follows
the description of 'shared' directory content available here:
https://developer.tizen.org/development/training/native-application/understanding-tizen-programming/file-system-directory-hierarchy
New application returns the path like:
sh-3.2# ls -al /opt/usr/home/owner/apps_rw/org.example.basic/shared/
total 20
drwxr-xr-x 4 owner users 4096 Jul 18 13:06 .
drwxr-xr-x 5 owner users 4096 Jul 18 13:06 ..
drwxrwsr-x 2 owner system_share 4096 Jul 18 13:06 data
lrwxrwxrwx 1 app_fw app_fw 58 Jul 18 13:06 res -> /opt/usr/globalapps/org.example.basic/shared/res
drwxr-xr-x 2 owner users 4096 Jul 18 13:06 trusted
Instead of the previous result:
sh-3.2# ls -al /opt/usr/globalapps/org.example.basic/shared/
total 12
drwxr-xr-x 3 tizenglobalapp root 4096 Jul 18 13:06 .
drwxr-xr-x 6 tizenglobalapp root 4096 Jul 18 13:06 ..
drwxr-xr-x 2 tizenglobalapp root 4096 Jul 18 13:06 res
[Verification] Checked manually in chrome console
TCT Application 100% passrate
Change-Id: I0032c10bf2d98487117cd0049103767f9c7f1d09
[Application] Fixed path of getAppSharedURI
Application should return path to the 'shared' directory which follows
the description of 'shared' directory content available here:
https://developer.tizen.org/development/training/native-application/understanding-tizen-programming/file-system-directory-hierarchy
New application returns the path like:
sh-3.2# ls -al /opt/usr/home/owner/apps_rw/org.example.basic/shared/
total 20
drwxr-xr-x 4 owner users 4096 Jul 18 13:06 .
drwxr-xr-x 5 owner users 4096 Jul 18 13:06 ..
drwxrwsr-x 2 owner system_share 4096 Jul 18 13:06 data
lrwxrwxrwx 1 app_fw app_fw 58 Jul 18 13:06 res -> /opt/usr/globalapps/org.example.basic/shared/res
drwxr-xr-x 2 owner users 4096 Jul 18 13:06 trusted
Instead of the previous result:
sh-3.2# ls -al /opt/usr/globalapps/org.example.basic/shared/
total 12
drwxr-xr-x 3 tizenglobalapp root 4096 Jul 18 13:06 .
drwxr-xr-x 6 tizenglobalapp root 4096 Jul 18 13:06 ..
drwxr-xr-x 2 tizenglobalapp root 4096 Jul 18 13:06 res
[Verification] Checked manually in chrome console
TCT Application 100% passrate
Change-Id: I0032c10bf2d98487117cd0049103767f9c7f1d09
Arkadiusz Pietraszek [Fri, 12 Jul 2019 11:47:35 +0000 (13:47 +0200)]
Merge remote-tracking branch 'origin/tizen_3.0' into tizen_4.0
[Verification] TCT passrate 100%.
Signed-off-by: Arkadiusz Pietraszek <a.pietraszek@partner.samsung.com>
Change-Id: Id004158e62f5d0b6f2c09eeee5cf300d461a9d9f
Arkadiusz Pietraszek [Mon, 8 Jul 2019 08:20:14 +0000 (10:20 +0200)]
[Project][Filesystem] Fix needed after code formating of tizen_3.0 branch
Prietter code formatter treated obiect properties named 'null' and 'undefined' as keywords that should not be in apostrophes and removed those apostrophes.
This change has been reverted and //prettier-ignore tags has been added.
Change-Id: I78d502b9f674397f01c959031ad37fa139dd0b16
Signed-off-by: Arkadiusz Pietraszek <a.pietraszek@partner.samsung.com>
Arkadiusz Pietraszek [Thu, 27 Jun 2019 12:12:21 +0000 (14:12 +0200)]
[Mediacontroller] Added callIfPossible safeguards in ServerPlaybackInfoListener.
Change-Id: Ic77f57e39b73acc77c67c3f1cff0352a94315206
Signed-off-by: Arkadiusz Pietraszek <a.pietraszek@partner.samsung.com>
Piotr Kosko [Wed, 3 Jul 2019 09:00:58 +0000 (09:00 +0000)]
Merge "[Mediacontroller] Added callIfPossible safeguards in ServerPlaybackInfoListener." into tizen_3.0
Rafal Walczyna [Fri, 28 Jun 2019 06:37:13 +0000 (08:37 +0200)]
[MediaController] Fix for custom command without data
If custom command was sent without additional data then
command was not parsed at all.
[Verification] Tested manually
Change-Id: Id35a5852a7fa61aff48fc181926e77ee01f65ff8
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Arkadiusz Pietraszek [Thu, 27 Jun 2019 12:12:21 +0000 (14:12 +0200)]
[Mediacontroller] Added callIfPossible safeguards in ServerPlaybackInfoListener.
[verification] TCT 100% passrate
Change-Id: Ic77f57e39b73acc77c67c3f1cff0352a94315206
Signed-off-by: Arkadiusz Pietraszek <a.pietraszek@partner.samsung.com>
Michal Michalski [Fri, 10 May 2019 10:09:45 +0000 (12:09 +0200)]
[mediacontroller] Declare MediaControllerContentType enum.
Extracted into separate commit from adding ContentType WebAPI
because it is needed by Search API implementation as well.
[Verification] Code compiles. Both ContentType API implementation and Search API
implementation compile as well with this commit as a parent.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I1f140bb8dd608887b90a1d7b5a202c493e5fd3e4
Michal Michalski [Tue, 7 May 2019 08:59:32 +0000 (10:59 +0200)]
[mediacontroller][common] Use PlatformEnum in MediaController.
Refactor enums in MediaController module using PlatformEnum
template class.
[Verification] Code compiles + MC TCT passed.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: Ie861d1c0aca7651a2f9ce45b966773082abf6045
Michal Michalski [Tue, 7 May 2019 08:36:56 +0000 (10:36 +0200)]
[common] Define PlatformEnum class template.
Will replace current way enums are defined in webapi-plugins.
[Verification] Code compiles.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: Id8c53df46ae9039e81d699884494b72c20d5cba8
Michal Michalski [Tue, 16 Apr 2019 10:26:16 +0000 (12:26 +0200)]
[mediacontroller] Fix error handling in ReplyCommand.
MediaControllerServerReplyCommand function did not
handle errors returned by MediaControllerServer::CommandReply()
call. This commit handles those errors.
[Verification]
Code compiles.
Change-Id: Ibc5acacc32ff23a6d8fa7cac096ade0e40e2b697
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Michal Michalski [Wed, 20 Mar 2019 17:19:15 +0000 (18:19 +0100)]
[mediacontroller] Use request_id for listener matching in SendCommand.
SendCommand method was using watchId to identify CommandReply callback which
should be called. It was passed in bundle object to mc_client_send_custom_cmd
function. Now instead of passing watchId we use already available request_id
to perform the same matching for command reply listeners.
[Verification]
Manual test.
tct-mediacontroller-tizen-tests - pass 100%
Change-Id: I57e90dbe36d7726f2e2f66866b11910d5d1d5d0d
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Lukasz Bardeli [Tue, 12 Mar 2019 12:43:18 +0000 (13:43 +0100)]
[MediaController] Change InvalidState to UnknownError.
[Verification] Code compiles without error.
Change-Id: Ibda8a419257caf071c7ed8e08e5b496b5c0efe2e
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Arkadiusz Pietraszek [Thu, 27 Jun 2019 12:12:21 +0000 (14:12 +0200)]
[Mediacontroller] Added callIfPossible safeguards in ServerPlaybackInfoListener.
Change-Id: Ic77f57e39b73acc77c67c3f1cff0352a94315206
Signed-off-by: Arkadiusz Pietraszek <a.pietraszek@partner.samsung.com>
Arkadiusz Pietraszek [Thu, 27 Jun 2019 09:14:58 +0000 (11:14 +0200)]
[Mediacontroller] Setter fixes for shuffleMode, repeatMode end position in MediaControllerPlaybackInfo
Previous implementation intended to check for null and undefined and in reality didn't allow for setting 'false' or '0' values.
Change-Id: I03194e81d5d0bd5ef97a88d01a014f758a6ca49d
Arkadiusz Pietraszek [Thu, 27 Jun 2019 09:14:58 +0000 (11:14 +0200)]
[Mediacontroller] Setter fixes for shuffleMode, repeatMode end position in MediaControllerPlaybackInfo
Previous implementation intended to check for null and undefined and in reality didn't allow for setting 'false' or '0' values.
Change-Id: I03194e81d5d0bd5ef97a88d01a014f758a6ca49d
[version] 2.34
Change-Id: Idd416b0d826a58f7bbc72edb07d4570aa3319212
Arkadiusz Pietraszek [Thu, 27 Jun 2019 09:14:58 +0000 (11:14 +0200)]
[Mediacontroller] Setter fixes for shuffleMode, repeatMode end position in MediaControllerPlaybackInfo
Previous implementation intended to check for null and undefined and in reality didn't allow for setting 'false' or '0' values.
Change-Id: I03194e81d5d0bd5ef97a88d01a014f758a6ca49d
Pawel Wasowski [Thu, 9 May 2019 11:31:49 +0000 (13:31 +0200)]
[messaging] Fix synchronization issues
Due to the delay between updating email with native C API functions and
updates of the corresponding message/thread records in the mail
database, race conditions occured in the previous implementation,
resulting in inconsitencies between thread_ids in the DB and those of
messages in JS layer. Active waits have been added to mitigate this
problems.
[Verification] tct-tizen-messaging-email pass rate: 100%
Change-Id: Ie0771ffc40e6cdee696756a8e831ae56bbe8f84d
Signed-off-by: Pawel Wasowski <p.wasowski2@samsung.com>
(cherry picked from commit
1440977fb5202077c98d86da90ee2046bc213132)
[version] 2.33
Change-Id: I2a04c187950845b460b398c9b16ad963c4c2330f
Arkadiusz Pietraszek [Wed, 3 Apr 2019 11:09:04 +0000 (13:09 +0200)]
[Project] JS code formatting
All project *.js files were formatted with eslint tool, to eliminate CodingRule_Auto negative marks.
Additionally Prettier tool was used for unified line breaking rules.
In few cases, the tool did not break line for very long object definitions e.g.
HumanActivityRecorderPressureData.prototype.constructor = HumanActivityRecorderPressureData;
in such cases, line was broken manually and flag // prettier-ignore was added to ignore next node.
Change-Id: I537435c652abad22364421fc4c5ebddd411defbf
Merge branch 'tizen_4.0' into tizen_5.0
Change-Id: Ie11b3d545d450613ecf61ccee824744108218c73
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: I0d282d007e89b4c761fa74d9b0737ca35c29ec57
[Content] isFavorite added to editableAttributes array
[Bug] Since 2.3 isFavorite is an editableAttribute, which was missing
in editableAttributes array. Now added it there.
[Verification] Code compiles without errors.
Change-Id: Ib5266a66920f0050fd5c25287602514bc4ea3762
Piotr Kosko [Wed, 17 Apr 2019 10:35:16 +0000 (10:35 +0000)]
Merge "[Project][Codeformat] Added prettier as partial formatter for JS" into tizen_3.0
Piotr Kosko [Wed, 17 Apr 2019 10:34:30 +0000 (10:34 +0000)]
Merge "[Project][code_formatter] Added u options and changed JS formatting and validating tools" into tizen_3.0
[Project][Codeformat] Added prettier as partial formatter for JS
[Feature] Existing solution check the format using eslint and fix
some issues with predefined rules (which match the requirements
of review.tizen.org CodingRule_Auto bot rules.
However the tool checks the validity, it does not provide auto
formating of too long lines issues.
To ensure such feature, the new tool was introduced and executed before
eslint validation.
Thanks to prettier, the line breaks are unified and handled the same
way in whole project.
Change-Id: I077036521307ef28fda5388ecab01b8d850ad3e3
Merge branch 'tizen_4.0' into tizen_5.0
Change-Id: I42897295af557b4844c1b9c4a16a687e96045cc5
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: I8f28e19de69751b7b92328491366aa0b8c7c6847
[version] 2.32
Change-Id: Idb24a1afa087aa101cebcfde7d46d283d459c956
[Filesystem] listFiles method of File ignores files without access
[Bug] Files with invalid SMACK labels (not allowed to be accessed by app)
caused exception about missing member ("location is required argument").
Fix ignores the files that cannot be accessed.
[Verification] Manually checked with Chrome console and trying to list files
with invalid SMACK label. Files are being ignored.
100% passrate for filesystem module.
Change-Id: I48ed83ebbba5d0c6cfa0e597f083a7a1abce17fa
Arkadiusz Pietraszek [Wed, 27 Mar 2019 14:29:37 +0000 (15:29 +0100)]
[Project][code_formatter] Added u options and changed JS formatting and validating tools
Now eslint is used to format js files.
Not all issues can be fixed by eslint, so it prints list of issues for user to fix.
All 'u' options in formatter format appropriate files, that was changed from last commit.
Since files to format are not commited, this script backs up those files.
[Verification] Script executes without errors and proper files are chosen to format. Formated .js files have 4 spaces of indentation.
Change-Id: I10509ce3f639b25cca7e68e95e7c9419d9d82304
Signed-off-by: Arkadiusz Pietraszek <a.pietraszek@partner.samsung.com>
Dawid Juszczak [Wed, 20 Mar 2019 12:42:20 +0000 (13:42 +0100)]
[messaging] fixed bug with foldersupdate callback
foldersupdated callback in method addFoldersChangeListener was not
invoked when renamed folder
[Verification] Tested on device, works fine. Also tested with new
testcase added in commit:
https://review.tizen.org/gerrit/#/c/test/tct/web/api/+/201889/
Change-Id: Ic48f0740da9c73ef676d30eedf72226c7f4d5699
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
Dawid Juszczak [Wed, 20 Mar 2019 11:19:48 +0000 (12:19 +0100)]
[messaging] fixed bug with foldersupdate callback
foldersupdated callback in method addFoldersChangeListener was not
invoked when renamed folder
[Verification] Tested on device, works fine. Also tested with new
testcase added in commit:
https://review.tizen.org/gerrit/#/c/test/tct/web/api/+/201880/
Change-Id: I26f3ae8991218e97d1a55cf6a0abffba622ed25f
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
Dawid Juszczak [Wed, 20 Mar 2019 13:55:22 +0000 (14:55 +0100)]
[messaging] fixed bug with foldersupdate callback
foldersupdated callback in method addFoldersChangeListener was not
invoked when renamed folder
[Verification] Tested on device, works fine. Also tested with new
testcase added in commit:
https://review.tizen.org/gerrit/#/c/test/tct/web/api/+/201891/
Change-Id: Ia5efe12e79b7f388c2a967a7f118c33edc34d06f
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
[version] 2.38
Change-Id: If39fca0d841550a2b4d36489374276686adcf14d
Signed-off-by: Piotr Kosko/Native/Web API (SWP) /SRPOL/Professional/삼성전자 <p.kosko@samsung.com>
Lukasz Bardeli [Mon, 7 Jan 2019 10:24:28 +0000 (11:24 +0100)]
[Common] Fix preventing crash in argument validator
If to method which takes object as parameter, array with one element
of this object will be passed them applicaiton will crash. This fix prevent
such situations and will throw TypeMissmatch
[Verification] Code compiles without error. Tested in chrome console and
execute automatic TCT (modules which have methods taking platform object as parameter -
account, alarm, application, bluetooth, bookmark, calendar, callhistory, contact,
content, download, exif, filesystem, iotcon, mediacontroller, messageport,
messaging, nfc, notification, push, time)
100% passrate
Change-Id: Idfd9ad6f1acc0a6d5fd140dfd655d1cab7d2291a
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
(cherry picked from commit
faaf457e2aa1307f0c3406208374d71d5c98827b)
Lukasz Bardeli [Thu, 24 Jan 2019 09:40:40 +0000 (10:40 +0100)]
[Messaging] Adding Log to get information about open error
[Verification] Code compiles properly.
Change-Id: I41dcf32e20eea77e1c7f37a7bc3d981baaa2cc32
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Merge branch 'tizen_4.0' into tizen_5.0
Change-Id: Icf1b978d0b5a6dea865fe10426e51ed79fe0d7ae
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: I7bdf58474ccd556f444f93dee7856566a65373b6
[version] 2.31
Change-Id: Ic8c3ade13866c7e55ee660346c3a79103f29d006
[Archive][Exif] Added checking return value of fseek
SVACE issues: 246302, 246317
Change-Id: If4f803b9db18c352912290b25df706a21cd07853
Signed-off-by: Piotr Kosko/Native/Web API (SWP) /SRPOL/Professional/삼성전자 <p.kosko@samsung.com>
Merge branch 'tizen_4.0' into tizen_5.0
Change-Id: I95d2ae95dbf4f9688dcd3c4beb3fecb0aac52206
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: Ifadc8944744fa1fe4e944670a51c184f1c36c228
[version] 2.30
Change-Id: I701491ee275a9540c9ddb821f420898629a3f5ca
Signed-off-by: Piotr Kosko/Native/Web API (SWP) /SRPOL/Professional/삼성전자 <p.kosko@samsung.com>
Pawel Wasowski [Wed, 19 Dec 2018 18:05:20 +0000 (19:05 +0100)]
[Messaging] Prevent crash on getMessageServices call
Calling tizen.messaging.getMessageServices() multiple times at
short intervals used to cause a crash, due to race condition, occurring
between different threads, modifying the same MessagingManager
instance's fields.
The fix moves execution of the underlying implementation to the main
thread - it is not called concurrently. The function execution time
is typically below 2 ms, so moving it to the main thread should
not worsen user experience.
[Verification] tct-tizen-messaging-email-tests pass rate: 100%
tct-tizen-messaging-sms-tests pass rate: 100%
tct-tizen-messaging-mms-tests pass rate: 100%
A code snippet, that used to cause a crash, does not
cause crash now:
for (var i = 0; i < 1000; ++i) {
tizen.messaging.getMessageServices('messaging.email',
s=>{console.log(s);},
e=>{console.error(e);});
}
Change-Id: I2f140281e64aeffea1ad9ca15f99ee38378693d3
Signed-off-by: Pawel Wasowski <p.wasowski2@partner.samsung.com>
Pawel Wasowski [Wed, 19 Dec 2018 18:05:20 +0000 (19:05 +0100)]
[Messaging] Prevent crash on getMessageServices call
Calling tizen.messaging.getMessageServices() multiple times at
short intervals used to cause a crash, due to race condition, occurring
between different threads, modifying the same MessagingManager
instance's fields.
The fix moves execution of the underlying implementation to the main
thread - it is not called concurrently. The function execution time
is typically below 2 ms, so moving it to the main thread should
not worsen user experience.
[Verification] tct-tizen-messaging-email-tests pass rate: 100%
tct-tizen-messaging-sms-tests pass rate: 100%
tct-tizen-messaging-mms-tests pass rate: 100%
A code snippet, that used to cause a crash, does not
cause crash now:
for (var i = 0; i < 1000; ++i) {
tizen.messaging.getMessageServices('messaging.email',
s=>{console.log(s);},
e=>{console.error(e);});
}
Change-Id: I2f140281e64aeffea1ad9ca15f99ee38378693d3
Signed-off-by: Pawel Wasowski <p.wasowski2@partner.samsung.com>