[M120 Migration] Fix coverity issue

This patch combine two patches.
First patch will fix coverity issue for CID 1677057.
Second patch will fix couple of coverity issues for [WRTJS].

https://review.tizen.org/gerrit/291078/
https://review.tizen.org/gerrit/290957/

Change-Id: I7b7ee36f33afdac473f4533c2131c591a2fe69ba
Signed-off-by: Manjeet <manjeet.1@partner.samsung.com>

diff --git a/tizen_src/chromium_impl/content/browser/context_menu/context_menu_controller_base.cc b/tizen_src/chromium_impl/content/browser/context_menu/context_menu_controller_base.cc
index 14517c15f4bf2971ae77d19df3b5142a3cf7e774..0fdf255d8082d096df7f09d50726db089727760e 100644 (file)
--- a/tizen_src/chromium_impl/content/browser/context_menu/context_menu_controller_base.cc
+++ b/tizen_src/chromium_impl/content/browser/context_menu/context_menu_controller_base.cc
@@ -639,7 +639,8 @@ const char* ContextMenuControllerBase::GetSelectedText() {
   if (!rwhva())
     return "";
 
-  return base::UTF16ToUTF8(rwhva()->GetSelectedText()).c_str();
+  selected_text_ = base::UTF16ToUTF8(rwhva()->GetSelectedText());
+  return selected_text_.c_str();
 }
 
 }  // namespace content

diff --git a/tizen_src/chromium_impl/content/browser/context_menu/context_menu_controller_base.h b/tizen_src/chromium_impl/content/browser/context_menu/context_menu_controller_base.h
index 8e02d827f0eb3b86b56288c8f8320f4762f3b65f..247f3a7f5bce16ce28f060acf416ae3ed1b95ddf 100644 (file)
--- a/tizen_src/chromium_impl/content/browser/context_menu/context_menu_controller_base.h
+++ b/tizen_src/chromium_impl/content/browser/context_menu/context_menu_controller_base.h
@@ -138,6 +138,7 @@ class ContextMenuControllerBase {
   Evas_Object* list_ = nullptr;
   Ecore_Timer* restore_timer_ = nullptr;
   ContextMenuStatusTag context_menu_status_ = NONE;
+  std::string selected_text_;
 };
 
 }  // namespace content

diff --git a/tizen_src/ewk/efl_integration/wrt/wrt_dynamicplugin.cc b/tizen_src/ewk/efl_integration/wrt/wrt_dynamicplugin.cc
index e430b91aaf77f34df9b8a6a3be835046f9ae153c..01544d4d997e1a387fb9a69e96a85ed7a5722b04 100644 (file)
--- a/tizen_src/ewk/efl_integration/wrt/wrt_dynamicplugin.cc
+++ b/tizen_src/ewk/efl_integration/wrt/wrt_dynamicplugin.cc
@@ -28,6 +28,7 @@ WrtDynamicPlugin::WrtDynamicPlugin()
     : DynamicPlugin(),
       url_parser_(0),
       set_widget_info_(0),
+      database_attach_(0),
       on_IPC_message_(0) {}
 
 bool WrtDynamicPlugin::Init(const std::string& injected_bundle_path) {

diff --git a/tizen_src/ewk/efl_integration/wrt/wrt_widget_host.cc b/tizen_src/ewk/efl_integration/wrt/wrt_widget_host.cc
index cf488f701828f1a9e9c6759c58347d65c871b0ea..6fa53a8bd4bab8d7ce9c9fa0d3524bd85850a5d6 100644 (file)
--- a/tizen_src/ewk/efl_integration/wrt/wrt_widget_host.cc
+++ b/tizen_src/ewk/efl_integration/wrt/wrt_widget_host.cc
@@ -104,7 +104,7 @@ void WrtWidgetHost::GetUrlForRequest(
       return;
 #endif
 
-  std::move(callback).Run(GURL());
+  std::move(callbacks_[callback_id]).Run(GURL());
   callbacks_.erase(callback_id);
 }