And correct even more valid sparse warnings.

[platform/upstream/gstreamer.git] / tests / check / libs / gdp.c

diff --git a/tests/check/libs/gdp.c b/tests/check/libs/gdp.c
index ca0e80b..c0edf24 100644 (file)
--- a/tests/check/libs/gdp.c
+++ b/tests/check/libs/gdp.c
@@ -20,8 +20,14 @@
  * Boston, MA 02111-1307, USA.
  */
 
+#include "config.h"
+
 #include <gst/check/gstcheck.h>
 
+#ifndef GST_REMOVE_DEPRECATED
+#undef GST_DISABLE_DEPRECATED
+#endif
+
 #include <gst/dataprotocol/dataprotocol.h>
 #include "libs/gst/dataprotocol/dp-private.h"   /* private header */
 
@@ -83,6 +89,10 @@ GST_START_TEST (test_conversion)
 
 GST_END_TEST;
 
+#ifndef GST_REMOVE_DEPRECATED   /* these tests use deprecated API, that we disable by default */
+
+#ifndef HAVE_CPU_PPC64          /* this test doesn't work on PPC64. See #348114 */
+
 /* test creation of header from buffer and back again */
 GST_START_TEST (test_buffer)
 {
@@ -146,6 +156,7 @@ GST_START_TEST (test_buffer)
 }
 
 GST_END_TEST;
+#endif
 
 GST_START_TEST (test_caps)
 {
@@ -278,7 +289,127 @@ GST_START_TEST (test_event)
 
 GST_END_TEST;
 
-Suite *
+/* try to segfault the thing by passing NULLs, short headers, etc.. */
+GST_START_TEST (test_memory)
+{
+  guint8 foo[5];
+  GstBuffer *buffer;
+  GstCaps *caps;
+  GstEvent *event;
+  guint length;
+  guint8 *header;
+  guint8 *payload;
+
+  /* check 0 sized input, data pointer can be NULL or anything. CRC is always 0,
+   * though. */
+  fail_if (gst_dp_crc (NULL, 0) != 0);
+  fail_if (gst_dp_crc (foo, 0) != 0);
+
+  /* this is very invalid input and gives a warning. */
+  ASSERT_CRITICAL (gst_dp_crc (NULL, 1));
+  ASSERT_CRITICAL (gst_dp_header_payload_length (NULL));
+  ASSERT_CRITICAL (gst_dp_header_payload_type (NULL));
+
+  /* wrong */
+  ASSERT_CRITICAL (gst_dp_header_from_buffer (NULL, 0, NULL, NULL));
+
+  /* empty buffer has NULL as data pointer */
+  buffer = gst_buffer_new_and_alloc (0);
+
+  /* no place to store the length and/or header data */
+  ASSERT_CRITICAL (gst_dp_header_from_buffer (buffer, 0, NULL, NULL));
+  ASSERT_CRITICAL (gst_dp_header_from_buffer (buffer, 0, &length, NULL));
+
+  /* this should work fine */
+  fail_if (gst_dp_header_from_buffer (buffer, 0, &length, &header) != TRUE);
+  fail_unless (length != 0);
+  fail_unless (header != NULL);
+
+  /* this should validate */
+  fail_if (gst_dp_validate_header (length, header) == FALSE);
+
+  /* NULL header pointer */
+  ASSERT_CRITICAL (gst_dp_validate_header (length, NULL));
+  /* short header */
+  ASSERT_CRITICAL (gst_dp_validate_header (5, header));
+
+  g_free (header);
+
+  /* this should work and not crash trying to calc a CRC on a 0 sized buffer */
+  fail_if (gst_dp_header_from_buffer (buffer,
+          GST_DP_HEADER_FLAG_CRC_HEADER | GST_DP_HEADER_FLAG_CRC_PAYLOAD,
+          &length, &header) != TRUE);
+
+  /* this should validate */
+  fail_if (gst_dp_validate_header (length, header) == FALSE);
+
+  /* there was no payload, NULL as payload data should validate the CRC
+   * checks and all. */
+  fail_if (gst_dp_validate_payload (length, header, NULL) == FALSE);
+
+  /* and the whole packet as well */
+  fail_if (gst_dp_validate_packet (length, header, NULL) == FALSE);
+
+  /* some bogus length */
+  ASSERT_CRITICAL (gst_dp_validate_packet (5, header, NULL));
+  gst_buffer_unref (buffer);
+
+  /* create buffer from header data, integrity tested elsewhere */
+  buffer = gst_dp_buffer_from_header (length, header);
+  fail_if (buffer == NULL);
+  gst_buffer_unref (buffer);
+  g_free (header);
+
+  ASSERT_CRITICAL (gst_dp_packet_from_caps (NULL, 0, NULL, NULL, NULL));
+
+  /* some caps stuff */
+  caps = gst_caps_new_empty ();
+  ASSERT_CRITICAL (gst_dp_packet_from_caps (caps, 0, NULL, NULL, NULL));
+  ASSERT_CRITICAL (gst_dp_packet_from_caps (caps, 0, &length, NULL, NULL));
+  ASSERT_CRITICAL (gst_dp_packet_from_caps (caps, 0, &length, &header, NULL));
+
+  fail_if (gst_dp_packet_from_caps (caps, 0, &length, &header,
+          &payload) != TRUE);
+  fail_if (strcmp ((const gchar *) payload, "EMPTY") != 0);
+  gst_caps_unref (caps);
+
+  caps = gst_dp_caps_from_packet (length, header, payload);
+  fail_if (caps == NULL);
+  gst_caps_unref (caps);
+
+  g_free (header);
+  g_free (payload);
+
+  /* some event stuff */
+  event = gst_event_new_eos ();
+  ASSERT_CRITICAL (gst_dp_packet_from_event (event, 0, NULL, NULL, NULL));
+  ASSERT_CRITICAL (gst_dp_packet_from_event (event, 0, &length, NULL, NULL));
+  ASSERT_CRITICAL (gst_dp_packet_from_event (event, 0, &length, &header, NULL));
+
+  /* payload is not NULL from previous test and points to freed memory, very
+   * invalid. */
+  fail_if (payload == NULL);
+  fail_if (gst_dp_packet_from_event (event, 0, &length, &header,
+          &payload) != TRUE);
+
+  /* the EOS event has no payload */
+  fail_if (payload != NULL);
+  gst_event_unref (event);
+
+  event = gst_dp_event_from_packet (length, header, payload);
+  fail_if (event == NULL);
+  fail_if (GST_EVENT_TYPE (event) != GST_EVENT_EOS);
+  gst_event_unref (event);
+
+  g_free (header);
+  g_free (payload);
+}
+
+GST_END_TEST;
+
+#endif
+
+static Suite *
 gst_dp_suite (void)
 {
   Suite *s = suite_create ("data protocol");
@@ -286,9 +417,14 @@ gst_dp_suite (void)
 
   suite_add_tcase (s, tc_chain);
   tcase_add_test (tc_chain, test_conversion);
+#ifndef GST_REMOVE_DEPRECATED
+#ifndef HAVE_CPU_PPC64
   tcase_add_test (tc_chain, test_buffer);
+#endif
   tcase_add_test (tc_chain, test_caps);
   tcase_add_test (tc_chain, test_event);
+  tcase_add_test (tc_chain, test_memory);
+#endif
 
   return s;
 }