Fix dereference after null check
[platform/upstream/connman.git] / src / rfkill.c
old mode 100644 (file)
new mode 100755 (executable)
index 0f54185..99b337d
@@ -2,7 +2,7 @@
  *
  *  Connection Manager
  *
- *  Copyright (C) 2007-2010  Intel Corporation. All rights reserved.
+ *  Copyright (C) 2007-2013  Intel Corporation. All rights reserved.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -37,10 +37,10 @@ enum rfkill_type {
        RFKILL_TYPE_WLAN,
        RFKILL_TYPE_BLUETOOTH,
        RFKILL_TYPE_UWB,
-       RFKILL_TYPE_WIMAX,
        RFKILL_TYPE_WWAN,
        RFKILL_TYPE_GPS,
        RFKILL_TYPE_FM,
+       NUM_RFKILL_TYPES,
 };
 
 enum rfkill_operation {
@@ -65,8 +65,6 @@ static enum connman_service_type convert_type(uint8_t type)
                return CONNMAN_SERVICE_TYPE_WIFI;
        case RFKILL_TYPE_BLUETOOTH:
                return CONNMAN_SERVICE_TYPE_BLUETOOTH;
-       case RFKILL_TYPE_WIMAX:
-               return CONNMAN_SERVICE_TYPE_WIMAX;
        case RFKILL_TYPE_WWAN:
                return CONNMAN_SERVICE_TYPE_CELLULAR;
        }
@@ -74,15 +72,38 @@ static enum connman_service_type convert_type(uint8_t type)
        return CONNMAN_SERVICE_TYPE_UNKNOWN;
 }
 
+#if !defined TIZEN_EXT
+static enum rfkill_type convert_service_type(enum connman_service_type type)
+{
+       switch (type) {
+       case CONNMAN_SERVICE_TYPE_WIFI:
+               return RFKILL_TYPE_WLAN;
+       case CONNMAN_SERVICE_TYPE_BLUETOOTH:
+               return RFKILL_TYPE_BLUETOOTH;
+       case CONNMAN_SERVICE_TYPE_CELLULAR:
+               return RFKILL_TYPE_WWAN;
+       case CONNMAN_SERVICE_TYPE_GPS:
+               return RFKILL_TYPE_GPS;
+       case CONNMAN_SERVICE_TYPE_SYSTEM:
+       case CONNMAN_SERVICE_TYPE_ETHERNET:
+       case CONNMAN_SERVICE_TYPE_VPN:
+       case CONNMAN_SERVICE_TYPE_GADGET:
+       case CONNMAN_SERVICE_TYPE_P2P:
+       case CONNMAN_SERVICE_TYPE_UNKNOWN:
+               return NUM_RFKILL_TYPES;
+       }
+
+       return NUM_RFKILL_TYPES;
+}
+#endif
+
 static GIOStatus rfkill_process(GIOChannel *chan)
 {
-       GIOStatus status = G_IO_STATUS_NORMAL;
        unsigned char buf[32];
        struct rfkill_event *event = (void *) buf;
-       char sysname[32];
        enum connman_service_type type;
-       connman_bool_t blocked;
        gsize len;
+       GIOStatus status;
 
        DBG("");
 
@@ -101,31 +122,19 @@ static GIOStatus rfkill_process(GIOChannel *chan)
                                                event->type, event->op,
                                                event->soft, event->hard);
 
+       type = convert_type(event->type);
+
        switch (event->op) {
        case RFKILL_OP_ADD:
-               type = convert_type(event->type);
                __connman_technology_add_rfkill(event->idx, type,
                                                event->soft, event->hard);
                break;
        case RFKILL_OP_DEL:
-               __connman_technology_remove_rfkill(event->idx);
+               __connman_technology_remove_rfkill(event->idx, type);
                break;
        case RFKILL_OP_CHANGE:
-               __connman_technology_update_rfkill(event->idx, event->soft,
-                                                               event->hard);
-               break;
-       default:
-               break;
-       }
-
-       snprintf(sysname, sizeof(sysname) - 1, "rfkill%d", event->idx);
-
-       blocked = (event->soft || event->hard) ? TRUE : FALSE;
-
-       switch (event->type) {
-       case RFKILL_TYPE_ALL:
-       case RFKILL_TYPE_WLAN:
-               /* FIXME: unblock device */
+               __connman_technology_update_rfkill(event->idx, type,
+                                               event->soft, event->hard);
                break;
        default:
                break;
@@ -134,8 +143,7 @@ static GIOStatus rfkill_process(GIOChannel *chan)
        return status;
 }
 
-static gboolean rfkill_event(GIOChannel *chan,
-                               GIOCondition cond, gpointer data)
+static gboolean rfkill_event(GIOChannel *chan, GIOCondition cond, gpointer data)
 {
        if (cond & (G_IO_NVAL | G_IO_HUP | G_IO_ERR))
                return FALSE;
@@ -146,16 +154,58 @@ static gboolean rfkill_event(GIOChannel *chan,
        return TRUE;
 }
 
-static GIOChannel *channel = NULL;
+static guint watch = 0;
+
+int __connman_rfkill_block(enum connman_service_type type, bool block)
+{
+#if !defined TIZEN_EXT
+       uint8_t rfkill_type;
+       struct rfkill_event event;
+       ssize_t len;
+       int fd, err = 0;
+#endif
+
+       DBG("type %d block %d", type, block);
+
+#if defined TIZEN_EXT
+       DBG("try to set rfkill block %d, but it's not permitted", block);
+
+       return 0;
+#else
+       rfkill_type = convert_service_type(type);
+       if (rfkill_type == NUM_RFKILL_TYPES)
+               return -EINVAL;
+
+       fd = open("/dev/rfkill", O_RDWR | O_CLOEXEC);
+       if (fd < 0)
+               return -errno;
+
+       memset(&event, 0, sizeof(event));
+       event.op = RFKILL_OP_CHANGE_ALL;
+       event.type = rfkill_type;
+       event.soft = block;
+
+       len = write(fd, &event, sizeof(event));
+       if (len < 0) {
+               err = -errno;
+               connman_error("Failed to change RFKILL state");
+       }
+
+       close(fd);
+
+       return err;
+#endif
+}
 
 int __connman_rfkill_init(void)
 {
+       GIOChannel *channel;
        GIOFlags flags;
        int fd;
 
        DBG("");
 
-       fd = open("/dev/rfkill", O_RDWR);
+       fd = open("/dev/rfkill", O_RDONLY | O_CLOEXEC);
        if (fd < 0) {
                connman_error("Failed to open RFKILL control device");
                return -EIO;
@@ -164,6 +214,9 @@ int __connman_rfkill_init(void)
        channel = g_io_channel_unix_new(fd);
        g_io_channel_set_close_on_unref(channel, TRUE);
 
+       g_io_channel_set_encoding(channel, NULL, NULL);
+       g_io_channel_set_buffered(channel, FALSE);
+
        flags = g_io_channel_get_flags(channel);
        flags |= G_IO_FLAG_NONBLOCK;
        g_io_channel_set_flags(channel, flags, NULL);
@@ -171,21 +224,21 @@ int __connman_rfkill_init(void)
        /* Process current RFKILL events sent on device open */
        while (rfkill_process(channel) == G_IO_STATUS_NORMAL);
 
-       g_io_add_watch(channel, G_IO_IN | G_IO_NVAL | G_IO_HUP | G_IO_ERR,
-                                                       rfkill_event, NULL);
+       watch = g_io_add_watch(channel,
+                               G_IO_IN | G_IO_NVAL | G_IO_HUP | G_IO_ERR,
+                               rfkill_event, NULL);
 
-       return 0;
+       g_io_channel_unref(channel);
+
+       return watch ? 0 : -EIO;
 }
 
 void __connman_rfkill_cleanup(void)
 {
        DBG("");
 
-       if (channel == NULL)
-               return;
-
-       g_io_channel_shutdown(channel, TRUE, NULL);
-       g_io_channel_unref(channel);
-
-       channel = NULL;
+       if (watch) {
+               g_source_remove(watch);
+               watch = 0;
+       }
 }