static void
gst_pad_template_init (GstPadTemplate * templ)
{
- /* FIXME 0.11: Does anybody remember why this is here? If not, let's
- * change it for 0.11 and let gst_element_class_add_pad_template() for
- * example ref/sink the pad templates.
- */
- /* We ensure that the pad template we're creating has a sunken reference.
- * Inconsistencies in pad templates being floating or sunken has caused
- * problems in the past with leaks, etc.
- *
- * For consistency, then, we only produce them with sunken references
- * owned by the creator of the object
- */
- if (g_object_is_floating (templ)) {
- gst_object_ref_sink (templ);
- }
}
static void
* @name_template: the name template.
* @direction: the #GstPadDirection of the template.
* @presence: the #GstPadPresence of the pad.
- * @caps: (transfer full): a #GstCaps set for the template. The caps are
- * taken ownership of.
+ * @caps: a #GstCaps set for the template.
*
* Creates a new pad template with a name according to the given template
- * and with the given arguments. This functions takes ownership of the provided
- * caps, so be sure to not use them afterwards.
+ * and with the given arguments.
*
* Returns: (transfer full): a new #GstPadTemplate.
*/
|| presence == GST_PAD_SOMETIMES || presence == GST_PAD_REQUEST, NULL);
if (!name_is_valid (name_template, presence)) {
- gst_caps_unref (caps);
return NULL;
}
"name", name_template, "name-template", name_template,
"direction", direction, "presence", presence, "caps", caps, NULL);
- gst_caps_unref (caps);
-
return new;
}
*
* Gets the capabilities of the pad template.
*
- * Returns: (transfer none): the #GstCaps of the pad template. If you need to
- * keep a reference to the caps, take a ref (see gst_caps_ref ()).
+ * Returns: (transfer full): the #GstCaps of the pad template.
+ * Unref after usage.
*/
GstCaps *
gst_pad_template_get_caps (GstPadTemplate * templ)
{
+ GstCaps *caps;
g_return_val_if_fail (GST_IS_PAD_TEMPLATE (templ), NULL);
- return GST_PAD_TEMPLATE_CAPS (templ);
+ caps = GST_PAD_TEMPLATE_CAPS (templ);
+
+ return (caps ? gst_caps_ref (caps) : NULL);
}
/**
GST_PAD_TEMPLATE_NAME_TEMPLATE (object) = g_value_dup_string (value);
break;
case PROP_DIRECTION:
- GST_PAD_TEMPLATE_DIRECTION (object) = g_value_get_enum (value);
+ GST_PAD_TEMPLATE_DIRECTION (object) =
+ (GstPadDirection) g_value_get_enum (value);
break;
case PROP_PRESENCE:
- GST_PAD_TEMPLATE_PRESENCE (object) = g_value_get_enum (value);
+ GST_PAD_TEMPLATE_PRESENCE (object) =
+ (GstPadPresence) g_value_get_enum (value);
break;
case PROP_CAPS:
- /* allow caps == NULL for backwards compatibility (ie. g_object_new()
- * called without any of the new properties) (FIXME 0.11) */
- if (g_value_get_boxed (value) != NULL) {
- GST_PAD_TEMPLATE_CAPS (object) =
- gst_caps_copy (g_value_get_boxed (value));
- }
+ GST_PAD_TEMPLATE_CAPS (object) = g_value_dup_boxed (value);
break;
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);