Merge branch 'tizen' into 'tizen_gst_1.19.2'

[platform/upstream/gstreamer.git] / ext / dvdread / dvdreadsrc.c

diff --git a/ext/dvdread/dvdreadsrc.c b/ext/dvdread/dvdreadsrc.c
index 8ab1e9d..eb29482 100644 (file)
--- a/ext/dvdread/dvdreadsrc.c
+++ b/ext/dvdread/dvdreadsrc.c
@@ -78,7 +78,7 @@ static void gst_dvd_read_src_set_property (GObject * object, guint prop_id,
 static void gst_dvd_read_src_get_property (GObject * object, guint prop_id,
     GValue * value, GParamSpec * pspec);
 static GstEvent *gst_dvd_read_src_make_clut_change_event (GstDvdReadSrc * src,
-    const guint * clut);
+    const guint32 * clut);
 static gboolean gst_dvd_read_src_get_size (GstDvdReadSrc * src, gint64 * size);
 static gboolean gst_dvd_read_src_do_seek (GstBaseSrc * src, GstSegment * s);
 static gint64 gst_dvd_read_src_convert_timecode (dvd_time_t * time);
@@ -91,11 +91,13 @@ static gint gst_dvd_read_src_get_sector_from_time (GstDvdReadSrc * src,
 
 static void gst_dvd_read_src_uri_handler_init (gpointer g_iface,
     gpointer iface_data);
+static gboolean dvdread_element_init (GstPlugin * plugin);
 
 #define gst_dvd_read_src_parent_class parent_class
 G_DEFINE_TYPE_WITH_CODE (GstDvdReadSrc, gst_dvd_read_src, GST_TYPE_PUSH_SRC,
     G_IMPLEMENT_INTERFACE (GST_TYPE_URI_HANDLER,
         gst_dvd_read_src_uri_handler_init));
+GST_ELEMENT_REGISTER_DEFINE_CUSTOM (dvdreadsrc, dvdread_element_init);
 
 static void
 gst_dvd_read_src_finalize (GObject * object)
@@ -349,6 +351,7 @@ static gboolean
 gst_dvd_read_src_goto_chapter (GstDvdReadSrc * src, gint chapter)
 {
   gint i;
+  const guint8 *palette;
 
   /* make sure the chapter number is valid for this title */
   if (chapter < 0 || chapter >= src->num_chapters) {
@@ -391,8 +394,11 @@ gst_dvd_read_src_goto_chapter (GstDvdReadSrc * src, gint chapter)
   if (src->pending_clut_event)
     gst_event_unref (src->pending_clut_event);
 
+  /* Work around GCC 9 compiler warning here about taking address of packed
+   * member, which may result in an unaligned pointer access */
+  palette = (const guint8 *) src->cur_pgc->palette;
   src->pending_clut_event =
-      gst_dvd_read_src_make_clut_change_event (src, src->cur_pgc->palette);
+      gst_dvd_read_src_make_clut_change_event (src, (const guint32 *) palette);
 
   return TRUE;
 }
@@ -560,6 +566,7 @@ gst_dvd_read_src_goto_title (GstDvdReadSrc * src, gint title, gint angle)
       lang_code[0] = (u->lang_code >> 8) & 0xff;
       lang_code[1] = u->lang_code & 0xff;
       gst_structure_set (s, t, G_TYPE_STRING, lang_code, NULL);
+      g_free (t);
       t = g_strdup_printf ("subpicture-%d-stream", i);
       gst_structure_set (s, t, G_TYPE_INT, (int) sid, NULL);
       g_free (t);
@@ -1033,7 +1040,7 @@ gst_dvd_read_src_set_property (GObject * object, guint prop_id,
       if (g_value_get_string (value) == NULL) {
         src->location = g_strdup ("/dev/dvd");
       } else {
-        src->location = g_strdup (g_value_get_string (value));
+        src->location = g_value_dup_string (value);
       }
       break;
     }
@@ -1348,7 +1355,7 @@ gst_dvd_read_src_src_event (GstBaseSrc * basesrc, GstEvent * event)
 
 static GstEvent *
 gst_dvd_read_src_make_clut_change_event (GstDvdReadSrc * src,
-    const guint * clut)
+    const guint32 * clut)
 {
   GstStructure *structure;
   gchar name[16];
@@ -1392,7 +1399,7 @@ static gboolean
 gst_dvd_read_src_do_duration_query (GstDvdReadSrc * src, GstQuery * query)
 {
   GstFormat format;
-  gint64 val;
+  gint64 val = 0;
 
   gst_query_parse_duration (query, &format, NULL);
 
@@ -1785,7 +1792,7 @@ gst_dvd_read_src_uri_handler_init (gpointer g_iface, gpointer iface_data)
 }
 
 static gboolean
-plugin_init (GstPlugin * plugin)
+dvdread_element_init (GstPlugin * plugin)
 {
   GST_DEBUG_CATEGORY_INIT (gstgst_dvd_read_src_debug, "dvdreadsrc", 0,
       "DVD reader element based on dvdreadsrc");
@@ -1796,13 +1803,14 @@ plugin_init (GstPlugin * plugin)
   bindtextdomain (GETTEXT_PACKAGE, LOCALEDIR);
   bind_textdomain_codeset (GETTEXT_PACKAGE, "UTF-8");
 #endif /* ENABLE_NLS */
+  return gst_element_register (plugin, "dvdreadsrc", GST_RANK_NONE,
+      GST_TYPE_DVD_READ_SRC);
+}
 
-  if (!gst_element_register (plugin, "dvdreadsrc", GST_RANK_NONE,
-          GST_TYPE_DVD_READ_SRC)) {
-    return FALSE;
-  }
-
-  return TRUE;
+static gboolean
+plugin_init (GstPlugin * plugin)
+{
+  return GST_ELEMENT_REGISTER (dvdreadsrc, plugin);
 }
 
 GST_PLUGIN_DEFINE (GST_VERSION_MAJOR,