btrfs-progs: extent_io: Init eb->lru to avoid NULL pointer dereference
[platform/upstream/btrfs-progs.git] / cmds-device.c
index fa0830f..86459d1 100644 (file)
@@ -32,6 +32,8 @@
 #include "cmds-fi-usage.h"
 
 #include "commands.h"
+#include "help.h"
+#include "mkfs/common.h"
 
 static const char * const device_cmd_group_usage[] = {
        "btrfs device <command> [<args>]",
@@ -118,8 +120,8 @@ static int cmd_device_add(int argc, char **argv)
 
                path = canonicalize_path(argv[i]);
                if (!path) {
-                       error("could not canonicalize pathname '%s': %s",
-                               argv[i], strerror(errno));
+                       error("could not canonicalize pathname '%s': %m",
+                               argv[i]);
                        ret++;
                        goto error_out;
                }
@@ -128,8 +130,7 @@ static int cmd_device_add(int argc, char **argv)
                strncpy_null(ioctl_args.name, path);
                res = ioctl(fdmnt, BTRFS_IOC_ADD_DEV, &ioctl_args);
                if (res < 0) {
-                       error("error adding device '%s': %s",
-                               path, strerror(errno));
+                       error("error adding device '%s': %m", path);
                        ret++;
                }
                free(path);
@@ -190,8 +191,7 @@ static int _cmd_device_remove(int argc, char **argv,
                 */
                if (res < 0 && (errno == ENOTTY || errno == EOPNOTSUPP)) {
                        if (is_devid) {
-                               error("device delete by id failed: %s",
-                                                       strerror(errno));
+                               error("device delete by id failed: %m");
                                ret++;
                                continue;
                        }
@@ -222,9 +222,16 @@ static int _cmd_device_remove(int argc, char **argv,
        return !!ret;
 }
 
+#define COMMON_USAGE_REMOVE_DELETE                                     \
+       "If 'missing' is specified for <device>, the first device that is",     \
+       "described by the filesystem metadata, but not present at the mount",   \
+       "time will be removed. (only in degraded mode)"
+
 static const char * const cmd_device_remove_usage[] = {
        "btrfs device remove <device>|<devid> [<device>|<devid>...] <path>",
        "Remove a device from a filesystem",
+       "",
+       COMMON_USAGE_REMOVE_DELETE,
        NULL
 };
 
@@ -235,7 +242,9 @@ static int cmd_device_remove(int argc, char **argv)
 
 static const char * const cmd_device_delete_usage[] = {
        "btrfs device delete <device>|<devid> [<device>|<devid>...] <path>",
-       "Remove a device from a filesystem",
+       "Remove a device from a filesystem (alias of \"btrfs device remove\")",
+       "",
+       COMMON_USAGE_REMOVE_DELETE,
        NULL
 };
 
@@ -300,8 +309,7 @@ static int cmd_device_scan(int argc, char **argv)
                }
                path = canonicalize_path(argv[i]);
                if (!path) {
-                       error("could not canonicalize path '%s': %s",
-                               argv[i], strerror(errno));
+                       error("could not canonicalize path '%s': %m", argv[i]);
                        ret = 1;
                        goto out;
                }
@@ -344,8 +352,8 @@ static int cmd_device_ready(int argc, char **argv)
 
        path = canonicalize_path(argv[optind]);
        if (!path) {
-               error("could not canonicalize pathname '%s': %s",
-                       argv[optind], strerror(errno));
+               error("could not canonicalize pathname '%s': %m",
+                       argv[optind]);
                ret = 1;
                goto out;
        }
@@ -360,8 +368,8 @@ static int cmd_device_ready(int argc, char **argv)
        strncpy_null(args.name, path);
        ret = ioctl(fd, BTRFS_IOC_DEVICES_READY, &args);
        if (ret < 0) {
-               error("unable to determine if device '%s' is ready for mount: %s",
-                       path, strerror(errno));
+               error("unable to determine if device '%s' is ready for mount: %m",
+                       path);
                ret = 1;
        }
 
@@ -372,10 +380,13 @@ out:
 }
 
 static const char * const cmd_device_stats_usage[] = {
-       "btrfs device stats [-z] <path>|<device>",
-       "Show current device IO stats.",
+       "btrfs device stats [options] <path>|<device>",
+       "Show device IO error statistics",
+       "Show device IO error statistics for all devices of the given filesystem",
+       "identified by PATH or DEVICE. The filesystem must be mounted.",
        "",
-       "-z                     show current stats and reset values to zero",
+       "-c|--check             return non-zero if any stat counter is not zero",
+       "-z|--reset             show current stats and reset values to zero",
        NULL
 };
 
@@ -387,13 +398,27 @@ static int cmd_device_stats(int argc, char **argv)
        int ret;
        int fdmnt;
        int i;
-       int c;
        int err = 0;
+       int check = 0;
        __u64 flags = 0;
        DIR *dirstream = NULL;
 
-       while ((c = getopt(argc, argv, "z")) != -1) {
+       while (1) {
+               int c;
+               static const struct option long_options[] = {
+                       {"check", no_argument, NULL, 'c'},
+                       {"reset", no_argument, NULL, 'z'},
+                       {NULL, 0, NULL, 0}
+               };
+
+               c = getopt_long(argc, argv, "cz", long_options, NULL);
+               if (c < 0)
+                       break;
+
                switch (c) {
+               case 'c':
+                       check = 1;
+                       break;
                case 'z':
                        flags = BTRFS_DEV_STATS_RESET;
                        break;
@@ -414,7 +439,7 @@ static int cmd_device_stats(int argc, char **argv)
 
        ret = get_fs_info(dev_path, &fi_args, &di_args);
        if (ret) {
-               error("getting dev info for devstats failed: %s",
+               error("getting device info for %s failed: %s", dev_path,
                        strerror(-ret));
                err = 1;
                goto out;
@@ -427,24 +452,37 @@ static int cmd_device_stats(int argc, char **argv)
 
        for (i = 0; i < fi_args.num_devices; i++) {
                struct btrfs_ioctl_get_dev_stats args = {0};
-               __u8 path[BTRFS_DEVICE_PATH_NAME_MAX + 1];
+               char path[BTRFS_DEVICE_PATH_NAME_MAX + 1];
 
-               strncpy((char *)path, (char *)di_args[i].path,
+               strncpy(path, (char *)di_args[i].path,
                        BTRFS_DEVICE_PATH_NAME_MAX);
-               path[BTRFS_DEVICE_PATH_NAME_MAX] = '\0';
+               path[BTRFS_DEVICE_PATH_NAME_MAX] = 0;
 
                args.devid = di_args[i].devid;
                args.nr_items = BTRFS_DEV_STAT_VALUES_MAX;
                args.flags = flags;
 
                if (ioctl(fdmnt, BTRFS_IOC_GET_DEV_STATS, &args) < 0) {
-                       error("DEV_STATS ioctl failed on %s: %s",
-                             path, strerror(errno));
-                       err = 1;
+                       error("device stats ioctl failed on %s: %m",
+                             path);
+                       err |= 1;
                } else {
                        char *canonical_path;
-
-                       canonical_path = canonicalize_path((char *)path);
+                       int j;
+                       static const struct {
+                               const char name[32];
+                               u64 num;
+                       } dev_stats[] = {
+                               { "write_io_errs", BTRFS_DEV_STAT_WRITE_ERRS },
+                               { "read_io_errs", BTRFS_DEV_STAT_READ_ERRS },
+                               { "flush_io_errs", BTRFS_DEV_STAT_FLUSH_ERRS },
+                               { "corruption_errs",
+                                       BTRFS_DEV_STAT_CORRUPTION_ERRS },
+                               { "generation_errs",
+                                       BTRFS_DEV_STAT_GENERATION_ERRS },
+                       };
+
+                       canonical_path = canonicalize_path(path);
 
                        /* No path when device is missing. */
                        if (!canonical_path) {
@@ -457,31 +495,18 @@ static int cmd_device_stats(int argc, char **argv)
                                         "devid:%llu", args.devid);
                        }
 
-                       if (args.nr_items >= BTRFS_DEV_STAT_WRITE_ERRS + 1)
-                               printf("[%s].write_io_errs   %llu\n",
-                                      canonical_path,
-                                      (unsigned long long) args.values[
-                                       BTRFS_DEV_STAT_WRITE_ERRS]);
-                       if (args.nr_items >= BTRFS_DEV_STAT_READ_ERRS + 1)
-                               printf("[%s].read_io_errs    %llu\n",
-                                      canonical_path,
-                                      (unsigned long long) args.values[
-                                       BTRFS_DEV_STAT_READ_ERRS]);
-                       if (args.nr_items >= BTRFS_DEV_STAT_FLUSH_ERRS + 1)
-                               printf("[%s].flush_io_errs   %llu\n",
-                                      canonical_path,
-                                      (unsigned long long) args.values[
-                                       BTRFS_DEV_STAT_FLUSH_ERRS]);
-                       if (args.nr_items >= BTRFS_DEV_STAT_CORRUPTION_ERRS + 1)
-                               printf("[%s].corruption_errs %llu\n",
-                                      canonical_path,
-                                      (unsigned long long) args.values[
-                                       BTRFS_DEV_STAT_CORRUPTION_ERRS]);
-                       if (args.nr_items >= BTRFS_DEV_STAT_GENERATION_ERRS + 1)
-                               printf("[%s].generation_errs %llu\n",
-                                      canonical_path,
-                                      (unsigned long long) args.values[
-                                       BTRFS_DEV_STAT_GENERATION_ERRS]);
+                       for (j = 0; j < ARRAY_SIZE(dev_stats); j++) {
+                               /* We got fewer items than we know */
+                               if (args.nr_items < dev_stats[j].num + 1)
+                                       continue;
+                               printf("[%s].%-16s %llu\n", canonical_path,
+                                       dev_stats[j].name,
+                                       (unsigned long long)
+                                        args.values[dev_stats[j].num]);
+                               if ((check == 1)
+                                   && (args.values[dev_stats[j].num] > 0))
+                                       err |= 64;
+                       }
 
                        free(canonical_path);
                }
@@ -517,8 +542,8 @@ static int _cmd_device_usage(int fd, char *path, unsigned unit_mode)
 
        for (i = 0; i < devcount; i++) {
                printf("%s, ID: %llu\n", devinfo[i].path, devinfo[i].devid);
-               print_device_sizes(fd, &devinfo[i], unit_mode);
-               print_device_chunks(fd, &devinfo[i], chunkinfo, chunkcount,
+               print_device_sizes(&devinfo[i], unit_mode);
+               print_device_chunks(&devinfo[i], chunkinfo, chunkcount,
                                unit_mode);
                printf("\n");
        }