btrfs-progs: extent_io: Init eb->lru to avoid NULL pointer dereference
authorQu Wenruo <wqu@suse.com>
Fri, 30 Mar 2018 05:48:54 +0000 (13:48 +0800)
committerDavid Sterba <dsterba@suse.com>
Tue, 24 Apr 2018 11:00:11 +0000 (13:00 +0200)
commit43dea2af140fe21111e7ce8491cad2724d73b2d4
treeeefd5f919244cb5b9632cc7e52bfca6a2aeced38
parent98d5d325a887b6c061096c141eef10755762bbcf
btrfs-progs: extent_io: Init eb->lru to avoid NULL pointer dereference

eb->lru is not initialized in __alloc_extent_buffer(), so in the
following call chain, it could call NULL pointer dereference:

btrfs_clone_extent_buffer()
|- __alloc_extent_buffer()
   |- Now eb->lru is NULL (not initialized)

free_extent_buffer_final()
|- list_del_init(&eb->lru)

Thankfully, current btrfs-progs won't trigger such bug as the only
btrfs_clone_extent_buffer() user is paths_from_inode(), which is not
used by anyone.
(But due to the usefulness of that function in future offline scrub, I'd
like to keep this dead code.)

Anyway, initialize eb->lru in __alloc_extent_bufer() bring no harm.

Signed-off-by: Qu Wenruo <wqu@suse.com>
Reviewed-by: Lu Fengqi <lufq.fnst@cn.fujitsu.com>
Signed-off-by: David Sterba <dsterba@suse.com>
extent_io.c