fsck.c

   1 #include "cache.h"
   2 #include "object.h"
   3 #include "blob.h"
   4 #include "tree.h"
   5 #include "tree-walk.h"
   6 #include "commit.h"
   7 #include "tag.h"
   8 #include "fsck.h"
   9 #include "refs.h"
  10 #include "utf8.h"
  11 #include "sha1-array.h"
  12 #include "decorate.h"
  13 #include "oidset.h"
  14 #include "packfile.h"
  15 #include "submodule-config.h"
  16 #include "config.h"
  17
  18 static struct oidset gitmodules_found = OIDSET_INIT;
  19 static struct oidset gitmodules_done = OIDSET_INIT;
  20
  21 #define FSCK_FATAL -1
  22 #define FSCK_INFO -2
  23
  24 #define FOREACH_MSG_ID(FUNC) \
  25         /* fatal errors */ \
  26         FUNC(NUL_IN_HEADER, FATAL) \
  27         FUNC(UNTERMINATED_HEADER, FATAL) \
  28         /* errors */ \
  29         FUNC(BAD_DATE, ERROR) \
  30         FUNC(BAD_DATE_OVERFLOW, ERROR) \
  31         FUNC(BAD_EMAIL, ERROR) \
  32         FUNC(BAD_NAME, ERROR) \
  33         FUNC(BAD_OBJECT_SHA1, ERROR) \
  34         FUNC(BAD_PARENT_SHA1, ERROR) \
  35         FUNC(BAD_TAG_OBJECT, ERROR) \
  36         FUNC(BAD_TIMEZONE, ERROR) \
  37         FUNC(BAD_TREE, ERROR) \
  38         FUNC(BAD_TREE_SHA1, ERROR) \
  39         FUNC(BAD_TYPE, ERROR) \
  40         FUNC(DUPLICATE_ENTRIES, ERROR) \
  41         FUNC(MISSING_AUTHOR, ERROR) \
  42         FUNC(MISSING_COMMITTER, ERROR) \
  43         FUNC(MISSING_EMAIL, ERROR) \
  44         FUNC(MISSING_GRAFT, ERROR) \
  45         FUNC(MISSING_NAME_BEFORE_EMAIL, ERROR) \
  46         FUNC(MISSING_OBJECT, ERROR) \
  47         FUNC(MISSING_PARENT, ERROR) \
  48         FUNC(MISSING_SPACE_BEFORE_DATE, ERROR) \
  49         FUNC(MISSING_SPACE_BEFORE_EMAIL, ERROR) \
  50         FUNC(MISSING_TAG, ERROR) \
  51         FUNC(MISSING_TAG_ENTRY, ERROR) \
  52         FUNC(MISSING_TAG_OBJECT, ERROR) \
  53         FUNC(MISSING_TREE, ERROR) \
  54         FUNC(MISSING_TREE_OBJECT, ERROR) \
  55         FUNC(MISSING_TYPE, ERROR) \
  56         FUNC(MISSING_TYPE_ENTRY, ERROR) \
  57         FUNC(MULTIPLE_AUTHORS, ERROR) \
  58         FUNC(TAG_OBJECT_NOT_TAG, ERROR) \
  59         FUNC(TREE_NOT_SORTED, ERROR) \
  60         FUNC(UNKNOWN_TYPE, ERROR) \
  61         FUNC(ZERO_PADDED_DATE, ERROR) \
  62         FUNC(GITMODULES_MISSING, ERROR) \
  63         FUNC(GITMODULES_BLOB, ERROR) \
  64         FUNC(GITMODULES_PARSE, ERROR) \
  65         FUNC(GITMODULES_NAME, ERROR) \
  66         FUNC(GITMODULES_SYMLINK, ERROR) \
  67         FUNC(GITMODULES_URL, ERROR) \
  68         FUNC(GITMODULES_PATH, ERROR) \
  69         /* warnings */ \
  70         FUNC(BAD_FILEMODE, WARN) \
  71         FUNC(EMPTY_NAME, WARN) \
  72         FUNC(FULL_PATHNAME, WARN) \
  73         FUNC(HAS_DOT, WARN) \
  74         FUNC(HAS_DOTDOT, WARN) \
  75         FUNC(HAS_DOTGIT, WARN) \
  76         FUNC(NULL_SHA1, WARN) \
  77         FUNC(ZERO_PADDED_FILEMODE, WARN) \
  78         FUNC(NUL_IN_COMMIT, WARN) \
  79         /* infos (reported as warnings, but ignored by default) */ \
  80         FUNC(BAD_TAG_NAME, INFO) \
  81         FUNC(MISSING_TAGGER_ENTRY, INFO)
  82
  83 #define MSG_ID(id, msg_type) FSCK_MSG_##id,
  84 enum fsck_msg_id {
  85         FOREACH_MSG_ID(MSG_ID)
  86         FSCK_MSG_MAX
  87 };
  88 #undef MSG_ID
  89
  90 #define STR(x) #x
  91 #define MSG_ID(id, msg_type) { STR(id), NULL, FSCK_##msg_type },
  92 static struct {
  93         const char *id_string;
  94         const char *downcased;
  95         int msg_type;
  96 } msg_id_info[FSCK_MSG_MAX + 1] = {
  97         FOREACH_MSG_ID(MSG_ID)
  98         { NULL, NULL, -1 }
  99 };
 100 #undef MSG_ID
 101
 102 static int parse_msg_id(const char *text)
 103 {
 104         int i;
 105
 106         if (!msg_id_info[0].downcased) {
 107                 /* convert id_string to lower case, without underscores. */
 108                 for (i = 0; i < FSCK_MSG_MAX; i++) {
 109                         const char *p = msg_id_info[i].id_string;
 110                         int len = strlen(p);
 111                         char *q = xmalloc(len);
 112
 113                         msg_id_info[i].downcased = q;
 114                         while (*p)
 115                                 if (*p == '_')
 116                                         p++;
 117                                 else
 118                                         *(q)++ = tolower(*(p)++);
 119                         *q = '\0';
 120                 }
 121         }
 122
 123         for (i = 0; i < FSCK_MSG_MAX; i++)
 124                 if (!strcmp(text, msg_id_info[i].downcased))
 125                         return i;
 126
 127         return -1;
 128 }
 129
 130 static int fsck_msg_type(enum fsck_msg_id msg_id,
 131         struct fsck_options *options)
 132 {
 133         int msg_type;
 134
 135         assert(msg_id >= 0 && msg_id < FSCK_MSG_MAX);
 136
 137         if (options->msg_type)
 138                 msg_type = options->msg_type[msg_id];
 139         else {
 140                 msg_type = msg_id_info[msg_id].msg_type;
 141                 if (options->strict && msg_type == FSCK_WARN)
 142                         msg_type = FSCK_ERROR;
 143         }
 144
 145         return msg_type;
 146 }
 147
 148 static void init_skiplist(struct fsck_options *options, const char *path)
 149 {
 150         static struct oid_array skiplist = OID_ARRAY_INIT;
 151         int sorted, fd;
 152         char buffer[GIT_MAX_HEXSZ + 1];
 153         struct object_id oid;
 154
 155         if (options->skiplist)
 156                 sorted = options->skiplist->sorted;
 157         else {
 158                 sorted = 1;
 159                 options->skiplist = &skiplist;
 160         }
 161
 162         fd = open(path, O_RDONLY);
 163         if (fd < 0)
 164                 die("Could not open skip list: %s", path);
 165         for (;;) {
 166                 const char *p;
 167                 int result = read_in_full(fd, buffer, sizeof(buffer));
 168                 if (result < 0)
 169                         die_errno("Could not read '%s'", path);
 170                 if (!result)
 171                         break;
 172                 if (parse_oid_hex(buffer, &oid, &p) || *p != '\n')
 173                         die("Invalid SHA-1: %s", buffer);
 174                 oid_array_append(&skiplist, &oid);
 175                 if (sorted && skiplist.nr > 1 &&
 176                                 oidcmp(&skiplist.oid[skiplist.nr - 2],
 177                                        &oid) > 0)
 178                         sorted = 0;
 179         }
 180         close(fd);
 181
 182         if (sorted)
 183                 skiplist.sorted = 1;
 184 }
 185
 186 static int parse_msg_type(const char *str)
 187 {
 188         if (!strcmp(str, "error"))
 189                 return FSCK_ERROR;
 190         else if (!strcmp(str, "warn"))
 191                 return FSCK_WARN;
 192         else if (!strcmp(str, "ignore"))
 193                 return FSCK_IGNORE;
 194         else
 195                 die("Unknown fsck message type: '%s'", str);
 196 }
 197
 198 int is_valid_msg_type(const char *msg_id, const char *msg_type)
 199 {
 200         if (parse_msg_id(msg_id) < 0)
 201                 return 0;
 202         parse_msg_type(msg_type);
 203         return 1;
 204 }
 205
 206 void fsck_set_msg_type(struct fsck_options *options,
 207                 const char *msg_id, const char *msg_type)
 208 {
 209         int id = parse_msg_id(msg_id), type;
 210
 211         if (id < 0)
 212                 die("Unhandled message id: %s", msg_id);
 213         type = parse_msg_type(msg_type);
 214
 215         if (type != FSCK_ERROR && msg_id_info[id].msg_type == FSCK_FATAL)
 216                 die("Cannot demote %s to %s", msg_id, msg_type);
 217
 218         if (!options->msg_type) {
 219                 int i;
 220                 int *msg_type;
 221                 ALLOC_ARRAY(msg_type, FSCK_MSG_MAX);
 222                 for (i = 0; i < FSCK_MSG_MAX; i++)
 223                         msg_type[i] = fsck_msg_type(i, options);
 224                 options->msg_type = msg_type;
 225         }
 226
 227         options->msg_type[id] = type;
 228 }
 229
 230 void fsck_set_msg_types(struct fsck_options *options, const char *values)
 231 {
 232         char *buf = xstrdup(values), *to_free = buf;
 233         int done = 0;
 234
 235         while (!done) {
 236                 int len = strcspn(buf, " ,|"), equal;
 237
 238                 done = !buf[len];
 239                 if (!len) {
 240                         buf++;
 241                         continue;
 242                 }
 243                 buf[len] = '\0';
 244
 245                 for (equal = 0;
 246                      equal < len && buf[equal] != '=' && buf[equal] != ':';
 247                      equal++)
 248                         buf[equal] = tolower(buf[equal]);
 249                 buf[equal] = '\0';
 250
 251                 if (!strcmp(buf, "skiplist")) {
 252                         if (equal == len)
 253                                 die("skiplist requires a path");
 254                         init_skiplist(options, buf + equal + 1);
 255                         buf += len + 1;
 256                         continue;
 257                 }
 258
 259                 if (equal == len)
 260                         die("Missing '=': '%s'", buf);
 261
 262                 fsck_set_msg_type(options, buf, buf + equal + 1);
 263                 buf += len + 1;
 264         }
 265         free(to_free);
 266 }
 267
 268 static void append_msg_id(struct strbuf *sb, const char *msg_id)
 269 {
 270         for (;;) {
 271                 char c = *(msg_id)++;
 272
 273                 if (!c)
 274                         break;
 275                 if (c != '_')
 276                         strbuf_addch(sb, tolower(c));
 277                 else {
 278                         assert(*msg_id);
 279                         strbuf_addch(sb, *(msg_id)++);
 280                 }
 281         }
 282
 283         strbuf_addstr(sb, ": ");
 284 }
 285
 286 __attribute__((format (printf, 4, 5)))
 287 static int report(struct fsck_options *options, struct object *object,
 288         enum fsck_msg_id id, const char *fmt, ...)
 289 {
 290         va_list ap;
 291         struct strbuf sb = STRBUF_INIT;
 292         int msg_type = fsck_msg_type(id, options), result;
 293
 294         if (msg_type == FSCK_IGNORE)
 295                 return 0;
 296
 297         if (options->skiplist && object &&
 298                         oid_array_lookup(options->skiplist, &object->oid) >= 0)
 299                 return 0;
 300
 301         if (msg_type == FSCK_FATAL)
 302                 msg_type = FSCK_ERROR;
 303         else if (msg_type == FSCK_INFO)
 304                 msg_type = FSCK_WARN;
 305
 306         append_msg_id(&sb, msg_id_info[id].id_string);
 307
 308         va_start(ap, fmt);
 309         strbuf_vaddf(&sb, fmt, ap);
 310         result = options->error_func(options, object, msg_type, sb.buf);
 311         strbuf_release(&sb);
 312         va_end(ap);
 313
 314         return result;
 315 }
 316
 317 static char *get_object_name(struct fsck_options *options, struct object *obj)
 318 {
 319         if (!options->object_names)
 320                 return NULL;
 321         return lookup_decoration(options->object_names, obj);
 322 }
 323
 324 static void put_object_name(struct fsck_options *options, struct object *obj,
 325         const char *fmt, ...)
 326 {
 327         va_list ap;
 328         struct strbuf buf = STRBUF_INIT;
 329         char *existing;
 330
 331         if (!options->object_names)
 332                 return;
 333         existing = lookup_decoration(options->object_names, obj);
 334         if (existing)
 335                 return;
 336         va_start(ap, fmt);
 337         strbuf_vaddf(&buf, fmt, ap);
 338         add_decoration(options->object_names, obj, strbuf_detach(&buf, NULL));
 339         va_end(ap);
 340 }
 341
 342 static const char *describe_object(struct fsck_options *o, struct object *obj)
 343 {
 344         static struct strbuf buf = STRBUF_INIT;
 345         char *name;
 346
 347         strbuf_reset(&buf);
 348         strbuf_addstr(&buf, oid_to_hex(&obj->oid));
 349         if (o->object_names && (name = lookup_decoration(o->object_names, obj)))
 350                 strbuf_addf(&buf, " (%s)", name);
 351
 352         return buf.buf;
 353 }
 354
 355 static int fsck_walk_tree(struct tree *tree, void *data, struct fsck_options *options)
 356 {
 357         struct tree_desc desc;
 358         struct name_entry entry;
 359         int res = 0;
 360         const char *name;
 361
 362         if (parse_tree(tree))
 363                 return -1;
 364
 365         name = get_object_name(options, &tree->object);
 366         if (init_tree_desc_gently(&desc, tree->buffer, tree->size))
 367                 return -1;
 368         while (tree_entry_gently(&desc, &entry)) {
 369                 struct object *obj;
 370                 int result;
 371
 372                 if (S_ISGITLINK(entry.mode))
 373                         continue;
 374
 375                 if (S_ISDIR(entry.mode)) {
 376                         obj = (struct object *)lookup_tree(entry.oid);
 377                         if (name && obj)
 378                                 put_object_name(options, obj, "%s%s/", name,
 379                                         entry.path);
 380                         result = options->walk(obj, OBJ_TREE, data, options);
 381                 }
 382                 else if (S_ISREG(entry.mode) || S_ISLNK(entry.mode)) {
 383                         obj = (struct object *)lookup_blob(entry.oid);
 384                         if (name && obj)
 385                                 put_object_name(options, obj, "%s%s", name,
 386                                         entry.path);
 387                         result = options->walk(obj, OBJ_BLOB, data, options);
 388                 }
 389                 else {
 390                         result = error("in tree %s: entry %s has bad mode %.6o",
 391                                         describe_object(options, &tree->object), entry.path, entry.mode);
 392                 }
 393                 if (result < 0)
 394                         return result;
 395                 if (!res)
 396                         res = result;
 397         }
 398         return res;
 399 }
 400
 401 static int fsck_walk_commit(struct commit *commit, void *data, struct fsck_options *options)
 402 {
 403         int counter = 0, generation = 0, name_prefix_len = 0;
 404         struct commit_list *parents;
 405         int res;
 406         int result;
 407         const char *name;
 408
 409         if (parse_commit(commit))
 410                 return -1;
 411
 412         name = get_object_name(options, &commit->object);
 413         if (name)
 414                 put_object_name(options, &commit->tree->object, "%s:", name);
 415
 416         result = options->walk((struct object *)commit->tree, OBJ_TREE, data, options);
 417         if (result < 0)
 418                 return result;
 419         res = result;
 420
 421         parents = commit->parents;
 422         if (name && parents) {
 423                 int len = strlen(name), power;
 424
 425                 if (len && name[len - 1] == '^') {
 426                         generation = 1;
 427                         name_prefix_len = len - 1;
 428                 }
 429                 else { /* parse ~<generation> suffix */
 430                         for (generation = 0, power = 1;
 431                              len && isdigit(name[len - 1]);
 432                              power *= 10)
 433                                 generation += power * (name[--len] - '0');
 434                         if (power > 1 && len && name[len - 1] == '~')
 435                                 name_prefix_len = len - 1;
 436                 }
 437         }
 438
 439         while (parents) {
 440                 if (name) {
 441                         struct object *obj = &parents->item->object;
 442
 443                         if (++counter > 1)
 444                                 put_object_name(options, obj, "%s^%d",
 445                                         name, counter);
 446                         else if (generation > 0)
 447                                 put_object_name(options, obj, "%.*s~%d",
 448                                         name_prefix_len, name, generation + 1);
 449                         else
 450                                 put_object_name(options, obj, "%s^", name);
 451                 }
 452                 result = options->walk((struct object *)parents->item, OBJ_COMMIT, data, options);
 453                 if (result < 0)
 454                         return result;
 455                 if (!res)
 456                         res = result;
 457                 parents = parents->next;
 458         }
 459         return res;
 460 }
 461
 462 static int fsck_walk_tag(struct tag *tag, void *data, struct fsck_options *options)
 463 {
 464         char *name = get_object_name(options, &tag->object);
 465
 466         if (parse_tag(tag))
 467                 return -1;
 468         if (name)
 469                 put_object_name(options, tag->tagged, "%s", name);
 470         return options->walk(tag->tagged, OBJ_ANY, data, options);
 471 }
 472
 473 int fsck_walk(struct object *obj, void *data, struct fsck_options *options)
 474 {
 475         if (!obj)
 476                 return -1;
 477
 478         if (obj->type == OBJ_NONE)
 479                 parse_object(&obj->oid);
 480
 481         switch (obj->type) {
 482         case OBJ_BLOB:
 483                 return 0;
 484         case OBJ_TREE:
 485                 return fsck_walk_tree((struct tree *)obj, data, options);
 486         case OBJ_COMMIT:
 487                 return fsck_walk_commit((struct commit *)obj, data, options);
 488         case OBJ_TAG:
 489                 return fsck_walk_tag((struct tag *)obj, data, options);
 490         default:
 491                 error("Unknown object type for %s", describe_object(options, obj));
 492                 return -1;
 493         }
 494 }
 495
 496 /*
 497  * The entries in a tree are ordered in the _path_ order,
 498  * which means that a directory entry is ordered by adding
 499  * a slash to the end of it.
 500  *
 501  * So a directory called "a" is ordered _after_ a file
 502  * called "a.c", because "a/" sorts after "a.c".
 503  */
 504 #define TREE_UNORDERED (-1)
 505 #define TREE_HAS_DUPS  (-2)
 506
 507 static int verify_ordered(unsigned mode1, const char *name1, unsigned mode2, const char *name2)
 508 {
 509         int len1 = strlen(name1);
 510         int len2 = strlen(name2);
 511         int len = len1 < len2 ? len1 : len2;
 512         unsigned char c1, c2;
 513         int cmp;
 514
 515         cmp = memcmp(name1, name2, len);
 516         if (cmp < 0)
 517                 return 0;
 518         if (cmp > 0)
 519                 return TREE_UNORDERED;
 520
 521         /*
 522          * Ok, the first <len> characters are the same.
 523          * Now we need to order the next one, but turn
 524          * a '\0' into a '/' for a directory entry.
 525          */
 526         c1 = name1[len];
 527         c2 = name2[len];
 528         if (!c1 && !c2)
 529                 /*
 530                  * git-write-tree used to write out a nonsense tree that has
 531                  * entries with the same name, one blob and one tree.  Make
 532                  * sure we do not have duplicate entries.
 533                  */
 534                 return TREE_HAS_DUPS;
 535         if (!c1 && S_ISDIR(mode1))
 536                 c1 = '/';
 537         if (!c2 && S_ISDIR(mode2))
 538                 c2 = '/';
 539         return c1 < c2 ? 0 : TREE_UNORDERED;
 540 }
 541
 542 static int fsck_tree(struct tree *item, struct fsck_options *options)
 543 {
 544         int retval = 0;
 545         int has_null_sha1 = 0;
 546         int has_full_path = 0;
 547         int has_empty_name = 0;
 548         int has_dot = 0;
 549         int has_dotdot = 0;
 550         int has_dotgit = 0;
 551         int has_zero_pad = 0;
 552         int has_bad_modes = 0;
 553         int has_dup_entries = 0;
 554         int not_properly_sorted = 0;
 555         struct tree_desc desc;
 556         unsigned o_mode;
 557         const char *o_name;
 558
 559         if (init_tree_desc_gently(&desc, item->buffer, item->size)) {
 560                 retval += report(options, &item->object, FSCK_MSG_BAD_TREE, "cannot be parsed as a tree");
 561                 return retval;
 562         }
 563
 564         o_mode = 0;
 565         o_name = NULL;
 566
 567         while (desc.size) {
 568                 unsigned mode;
 569                 const char *name;
 570                 const struct object_id *oid;
 571
 572                 oid = tree_entry_extract(&desc, &name, &mode);
 573
 574                 has_null_sha1 |= is_null_oid(oid);
 575                 has_full_path |= !!strchr(name, '/');
 576                 has_empty_name |= !*name;
 577                 has_dot |= !strcmp(name, ".");
 578                 has_dotdot |= !strcmp(name, "..");
 579                 has_dotgit |= is_hfs_dotgit(name) || is_ntfs_dotgit(name);
 580                 has_zero_pad |= *(char *)desc.buffer == '0';
 581
 582                 if (is_hfs_dotgitmodules(name) || is_ntfs_dotgitmodules(name)) {
 583                         if (!S_ISLNK(mode))
 584                                 oidset_insert(&gitmodules_found, oid);
 585                         else
 586                                 retval += report(options, &item->object,
 587                                                  FSCK_MSG_GITMODULES_SYMLINK,
 588                                                  ".gitmodules is a symbolic link");
 589                 }
 590
 591                 if (update_tree_entry_gently(&desc)) {
 592                         retval += report(options, &item->object, FSCK_MSG_BAD_TREE, "cannot be parsed as a tree");
 593                         break;
 594                 }
 595
 596                 switch (mode) {
 597                 /*
 598                  * Standard modes..
 599                  */
 600                 case S_IFREG | 0755:
 601                 case S_IFREG | 0644:
 602                 case S_IFLNK:
 603                 case S_IFDIR:
 604                 case S_IFGITLINK:
 605                         break;
 606                 /*
 607                  * This is nonstandard, but we had a few of these
 608                  * early on when we honored the full set of mode
 609                  * bits..
 610                  */
 611                 case S_IFREG | 0664:
 612                         if (!options->strict)
 613                                 break;
 614                         /* fallthrough */
 615                 default:
 616                         has_bad_modes = 1;
 617                 }
 618
 619                 if (o_name) {
 620                         switch (verify_ordered(o_mode, o_name, mode, name)) {
 621                         case TREE_UNORDERED:
 622                                 not_properly_sorted = 1;
 623                                 break;
 624                         case TREE_HAS_DUPS:
 625                                 has_dup_entries = 1;
 626                                 break;
 627                         default:
 628                                 break;
 629                         }
 630                 }
 631
 632                 o_mode = mode;
 633                 o_name = name;
 634         }
 635
 636         if (has_null_sha1)
 637                 retval += report(options, &item->object, FSCK_MSG_NULL_SHA1, "contains entries pointing to null sha1");
 638         if (has_full_path)
 639                 retval += report(options, &item->object, FSCK_MSG_FULL_PATHNAME, "contains full pathnames");
 640         if (has_empty_name)
 641                 retval += report(options, &item->object, FSCK_MSG_EMPTY_NAME, "contains empty pathname");
 642         if (has_dot)
 643                 retval += report(options, &item->object, FSCK_MSG_HAS_DOT, "contains '.'");
 644         if (has_dotdot)
 645                 retval += report(options, &item->object, FSCK_MSG_HAS_DOTDOT, "contains '..'");
 646         if (has_dotgit)
 647                 retval += report(options, &item->object, FSCK_MSG_HAS_DOTGIT, "contains '.git'");
 648         if (has_zero_pad)
 649                 retval += report(options, &item->object, FSCK_MSG_ZERO_PADDED_FILEMODE, "contains zero-padded file modes");
 650         if (has_bad_modes)
 651                 retval += report(options, &item->object, FSCK_MSG_BAD_FILEMODE, "contains bad file modes");
 652         if (has_dup_entries)
 653                 retval += report(options, &item->object, FSCK_MSG_DUPLICATE_ENTRIES, "contains duplicate file entries");
 654         if (not_properly_sorted)
 655                 retval += report(options, &item->object, FSCK_MSG_TREE_NOT_SORTED, "not properly sorted");
 656         return retval;
 657 }
 658
 659 static int verify_headers(const void *data, unsigned long size,
 660                           struct object *obj, struct fsck_options *options)
 661 {
 662         const char *buffer = (const char *)data;
 663         unsigned long i;
 664
 665         for (i = 0; i < size; i++) {
 666                 switch (buffer[i]) {
 667                 case '\0':
 668                         return report(options, obj,
 669                                 FSCK_MSG_NUL_IN_HEADER,
 670                                 "unterminated header: NUL at offset %ld", i);
 671                 case '\n':
 672                         if (i + 1 < size && buffer[i + 1] == '\n')
 673                                 return 0;
 674                 }
 675         }
 676
 677         /*
 678          * We did not find double-LF that separates the header
 679          * and the body.  Not having a body is not a crime but
 680          * we do want to see the terminating LF for the last header
 681          * line.
 682          */
 683         if (size && buffer[size - 1] == '\n')
 684                 return 0;
 685
 686         return report(options, obj,
 687                 FSCK_MSG_UNTERMINATED_HEADER, "unterminated header");
 688 }
 689
 690 static int fsck_ident(const char **ident, struct object *obj, struct fsck_options *options)
 691 {
 692         const char *p = *ident;
 693         char *end;
 694
 695         *ident = strchrnul(*ident, '\n');
 696         if (**ident == '\n')
 697                 (*ident)++;
 698
 699         if (*p == '<')
 700                 return report(options, obj, FSCK_MSG_MISSING_NAME_BEFORE_EMAIL, "invalid author/committer line - missing space before email");
 701         p += strcspn(p, "<>\n");
 702         if (*p == '>')
 703                 return report(options, obj, FSCK_MSG_BAD_NAME, "invalid author/committer line - bad name");
 704         if (*p != '<')
 705                 return report(options, obj, FSCK_MSG_MISSING_EMAIL, "invalid author/committer line - missing email");
 706         if (p[-1] != ' ')
 707                 return report(options, obj, FSCK_MSG_MISSING_SPACE_BEFORE_EMAIL, "invalid author/committer line - missing space before email");
 708         p++;
 709         p += strcspn(p, "<>\n");
 710         if (*p != '>')
 711                 return report(options, obj, FSCK_MSG_BAD_EMAIL, "invalid author/committer line - bad email");
 712         p++;
 713         if (*p != ' ')
 714                 return report(options, obj, FSCK_MSG_MISSING_SPACE_BEFORE_DATE, "invalid author/committer line - missing space before date");
 715         p++;
 716         if (*p == '0' && p[1] != ' ')
 717                 return report(options, obj, FSCK_MSG_ZERO_PADDED_DATE, "invalid author/committer line - zero-padded date");
 718         if (date_overflows(parse_timestamp(p, &end, 10)))
 719                 return report(options, obj, FSCK_MSG_BAD_DATE_OVERFLOW, "invalid author/committer line - date causes integer overflow");
 720         if ((end == p || *end != ' '))
 721                 return report(options, obj, FSCK_MSG_BAD_DATE, "invalid author/committer line - bad date");
 722         p = end + 1;
 723         if ((*p != '+' && *p != '-') ||
 724             !isdigit(p[1]) ||
 725             !isdigit(p[2]) ||
 726             !isdigit(p[3]) ||
 727             !isdigit(p[4]) ||
 728             (p[5] != '\n'))
 729                 return report(options, obj, FSCK_MSG_BAD_TIMEZONE, "invalid author/committer line - bad time zone");
 730         p += 6;
 731         return 0;
 732 }
 733
 734 static int fsck_commit_buffer(struct commit *commit, const char *buffer,
 735         unsigned long size, struct fsck_options *options)
 736 {
 737         unsigned char tree_sha1[20], sha1[20];
 738         struct commit_graft *graft;
 739         unsigned parent_count, parent_line_count = 0, author_count;
 740         int err;
 741         const char *buffer_begin = buffer;
 742
 743         if (verify_headers(buffer, size, &commit->object, options))
 744                 return -1;
 745
 746         if (!skip_prefix(buffer, "tree ", &buffer))
 747                 return report(options, &commit->object, FSCK_MSG_MISSING_TREE, "invalid format - expected 'tree' line");
 748         if (get_sha1_hex(buffer, tree_sha1) || buffer[40] != '\n') {
 749                 err = report(options, &commit->object, FSCK_MSG_BAD_TREE_SHA1, "invalid 'tree' line format - bad sha1");
 750                 if (err)
 751                         return err;
 752         }
 753         buffer += 41;
 754         while (skip_prefix(buffer, "parent ", &buffer)) {
 755                 if (get_sha1_hex(buffer, sha1) || buffer[40] != '\n') {
 756                         err = report(options, &commit->object, FSCK_MSG_BAD_PARENT_SHA1, "invalid 'parent' line format - bad sha1");
 757                         if (err)
 758                                 return err;
 759                 }
 760                 buffer += 41;
 761                 parent_line_count++;
 762         }
 763         graft = lookup_commit_graft(&commit->object.oid);
 764         parent_count = commit_list_count(commit->parents);
 765         if (graft) {
 766                 if (graft->nr_parent == -1 && !parent_count)
 767                         ; /* shallow commit */
 768                 else if (graft->nr_parent != parent_count) {
 769                         err = report(options, &commit->object, FSCK_MSG_MISSING_GRAFT, "graft objects missing");
 770                         if (err)
 771                                 return err;
 772                 }
 773         } else {
 774                 if (parent_count != parent_line_count) {
 775                         err = report(options, &commit->object, FSCK_MSG_MISSING_PARENT, "parent objects missing");
 776                         if (err)
 777                                 return err;
 778                 }
 779         }
 780         author_count = 0;
 781         while (skip_prefix(buffer, "author ", &buffer)) {
 782                 author_count++;
 783                 err = fsck_ident(&buffer, &commit->object, options);
 784                 if (err)
 785                         return err;
 786         }
 787         if (author_count < 1)
 788                 err = report(options, &commit->object, FSCK_MSG_MISSING_AUTHOR, "invalid format - expected 'author' line");
 789         else if (author_count > 1)
 790                 err = report(options, &commit->object, FSCK_MSG_MULTIPLE_AUTHORS, "invalid format - multiple 'author' lines");
 791         if (err)
 792                 return err;
 793         if (!skip_prefix(buffer, "committer ", &buffer))
 794                 return report(options, &commit->object, FSCK_MSG_MISSING_COMMITTER, "invalid format - expected 'committer' line");
 795         err = fsck_ident(&buffer, &commit->object, options);
 796         if (err)
 797                 return err;
 798         if (!commit->tree) {
 799                 err = report(options, &commit->object, FSCK_MSG_BAD_TREE, "could not load commit's tree %s", sha1_to_hex(tree_sha1));
 800                 if (err)
 801                         return err;
 802         }
 803         if (memchr(buffer_begin, '\0', size)) {
 804                 err = report(options, &commit->object, FSCK_MSG_NUL_IN_COMMIT,
 805                              "NUL byte in the commit object body");
 806                 if (err)
 807                         return err;
 808         }
 809         return 0;
 810 }
 811
 812 static int fsck_commit(struct commit *commit, const char *data,
 813         unsigned long size, struct fsck_options *options)
 814 {
 815         const char *buffer = data ?  data : get_commit_buffer(commit, &size);
 816         int ret = fsck_commit_buffer(commit, buffer, size, options);
 817         if (!data)
 818                 unuse_commit_buffer(commit, buffer);
 819         return ret;
 820 }
 821
 822 static int fsck_tag_buffer(struct tag *tag, const char *data,
 823         unsigned long size, struct fsck_options *options)
 824 {
 825         unsigned char sha1[20];
 826         int ret = 0;
 827         const char *buffer;
 828         char *to_free = NULL, *eol;
 829         struct strbuf sb = STRBUF_INIT;
 830
 831         if (data)
 832                 buffer = data;
 833         else {
 834                 enum object_type type;
 835
 836                 buffer = to_free =
 837                         read_sha1_file(tag->object.oid.hash, &type, &size);
 838                 if (!buffer)
 839                         return report(options, &tag->object,
 840                                 FSCK_MSG_MISSING_TAG_OBJECT,
 841                                 "cannot read tag object");
 842
 843                 if (type != OBJ_TAG) {
 844                         ret = report(options, &tag->object,
 845                                 FSCK_MSG_TAG_OBJECT_NOT_TAG,
 846                                 "expected tag got %s",
 847                             type_name(type));
 848                         goto done;
 849                 }
 850         }
 851
 852         ret = verify_headers(buffer, size, &tag->object, options);
 853         if (ret)
 854                 goto done;
 855
 856         if (!skip_prefix(buffer, "object ", &buffer)) {
 857                 ret = report(options, &tag->object, FSCK_MSG_MISSING_OBJECT, "invalid format - expected 'object' line");
 858                 goto done;
 859         }
 860         if (get_sha1_hex(buffer, sha1) || buffer[40] != '\n') {
 861                 ret = report(options, &tag->object, FSCK_MSG_BAD_OBJECT_SHA1, "invalid 'object' line format - bad sha1");
 862                 if (ret)
 863                         goto done;
 864         }
 865         buffer += 41;
 866
 867         if (!skip_prefix(buffer, "type ", &buffer)) {
 868                 ret = report(options, &tag->object, FSCK_MSG_MISSING_TYPE_ENTRY, "invalid format - expected 'type' line");
 869                 goto done;
 870         }
 871         eol = strchr(buffer, '\n');
 872         if (!eol) {
 873                 ret = report(options, &tag->object, FSCK_MSG_MISSING_TYPE, "invalid format - unexpected end after 'type' line");
 874                 goto done;
 875         }
 876         if (type_from_string_gently(buffer, eol - buffer, 1) < 0)
 877                 ret = report(options, &tag->object, FSCK_MSG_BAD_TYPE, "invalid 'type' value");
 878         if (ret)
 879                 goto done;
 880         buffer = eol + 1;
 881
 882         if (!skip_prefix(buffer, "tag ", &buffer)) {
 883                 ret = report(options, &tag->object, FSCK_MSG_MISSING_TAG_ENTRY, "invalid format - expected 'tag' line");
 884                 goto done;
 885         }
 886         eol = strchr(buffer, '\n');
 887         if (!eol) {
 888                 ret = report(options, &tag->object, FSCK_MSG_MISSING_TAG, "invalid format - unexpected end after 'type' line");
 889                 goto done;
 890         }
 891         strbuf_addf(&sb, "refs/tags/%.*s", (int)(eol - buffer), buffer);
 892         if (check_refname_format(sb.buf, 0)) {
 893                 ret = report(options, &tag->object, FSCK_MSG_BAD_TAG_NAME,
 894                            "invalid 'tag' name: %.*s",
 895                            (int)(eol - buffer), buffer);
 896                 if (ret)
 897                         goto done;
 898         }
 899         buffer = eol + 1;
 900
 901         if (!skip_prefix(buffer, "tagger ", &buffer)) {
 902                 /* early tags do not contain 'tagger' lines; warn only */
 903                 ret = report(options, &tag->object, FSCK_MSG_MISSING_TAGGER_ENTRY, "invalid format - expected 'tagger' line");
 904                 if (ret)
 905                         goto done;
 906         }
 907         else
 908                 ret = fsck_ident(&buffer, &tag->object, options);
 909
 910 done:
 911         strbuf_release(&sb);
 912         free(to_free);
 913         return ret;
 914 }
 915
 916 static int fsck_tag(struct tag *tag, const char *data,
 917         unsigned long size, struct fsck_options *options)
 918 {
 919         struct object *tagged = tag->tagged;
 920
 921         if (!tagged)
 922                 return report(options, &tag->object, FSCK_MSG_BAD_TAG_OBJECT, "could not load tagged object");
 923
 924         return fsck_tag_buffer(tag, data, size, options);
 925 }
 926
 927 struct fsck_gitmodules_data {
 928         struct object *obj;
 929         struct fsck_options *options;
 930         int ret;
 931 };
 932
 933 static int fsck_gitmodules_fn(const char *var, const char *value, void *vdata)
 934 {
 935         struct fsck_gitmodules_data *data = vdata;
 936         const char *subsection, *key;
 937         int subsection_len;
 938         char *name;
 939
 940         if (parse_config_key(var, "submodule", &subsection, &subsection_len, &key) < 0 ||
 941             !subsection)
 942                 return 0;
 943
 944         name = xmemdupz(subsection, subsection_len);
 945         if (check_submodule_name(name) < 0)
 946                 data->ret |= report(data->options, data->obj,
 947                                     FSCK_MSG_GITMODULES_NAME,
 948                                     "disallowed submodule name: %s",
 949                                     name);
 950         if (!strcmp(key, "url") && value &&
 951             looks_like_command_line_option(value))
 952                 data->ret |= report(data->options, data->obj,
 953                                     FSCK_MSG_GITMODULES_URL,
 954                                     "disallowed submodule url: %s",
 955                                     value);
 956         if (!strcmp(key, "path") && value &&
 957             looks_like_command_line_option(value))
 958                 data->ret |= report(data->options, data->obj,
 959                                     FSCK_MSG_GITMODULES_PATH,
 960                                     "disallowed submodule path: %s",
 961                                     value);
 962         free(name);
 963
 964         return 0;
 965 }
 966
 967 static int fsck_blob(struct blob *blob, const char *buf,
 968                      unsigned long size, struct fsck_options *options)
 969 {
 970         struct fsck_gitmodules_data data;
 971
 972         if (!oidset_contains(&gitmodules_found, &blob->object.oid))
 973                 return 0;
 974         oidset_insert(&gitmodules_done, &blob->object.oid);
 975
 976         if (!buf) {
 977                 /*
 978                  * A missing buffer here is a sign that the caller found the
 979                  * blob too gigantic to load into memory. Let's just consider
 980                  * that an error.
 981                  */
 982                 return report(options, &blob->object,
 983                               FSCK_MSG_GITMODULES_PARSE,
 984                               ".gitmodules too large to parse");
 985         }
 986
 987         data.obj = &blob->object;
 988         data.options = options;
 989         data.ret = 0;
 990         if (git_config_from_mem(fsck_gitmodules_fn, CONFIG_ORIGIN_BLOB,
 991                                 ".gitmodules", buf, size, &data))
 992                 data.ret |= report(options, &blob->object,
 993                                    FSCK_MSG_GITMODULES_PARSE,
 994                                    "could not parse gitmodules blob");
 995
 996         return data.ret;
 997 }
 998
 999 int fsck_object(struct object *obj, void *data, unsigned long size,
1000         struct fsck_options *options)
1001 {
1002         if (!obj)
1003                 return report(options, obj, FSCK_MSG_BAD_OBJECT_SHA1, "no valid object to fsck");
1004
1005         if (obj->type == OBJ_BLOB)
1006                 return fsck_blob((struct blob *)obj, data, size, options);
1007         if (obj->type == OBJ_TREE)
1008                 return fsck_tree((struct tree *) obj, options);
1009         if (obj->type == OBJ_COMMIT)
1010                 return fsck_commit((struct commit *) obj, (const char *) data,
1011                         size, options);
1012         if (obj->type == OBJ_TAG)
1013                 return fsck_tag((struct tag *) obj, (const char *) data,
1014                         size, options);
1015
1016         return report(options, obj, FSCK_MSG_UNKNOWN_TYPE, "unknown type '%d' (internal fsck error)",
1017                           obj->type);
1018 }
1019
1020 int fsck_error_function(struct fsck_options *o,
1021         struct object *obj, int msg_type, const char *message)
1022 {
1023         if (msg_type == FSCK_WARN) {
1024                 warning("object %s: %s", describe_object(o, obj), message);
1025                 return 0;
1026         }
1027         error("object %s: %s", describe_object(o, obj), message);
1028         return 1;
1029 }
1030
1031 int fsck_finish(struct fsck_options *options)
1032 {
1033         int ret = 0;
1034         struct oidset_iter iter;
1035         const struct object_id *oid;
1036
1037         oidset_iter_init(&gitmodules_found, &iter);
1038         while ((oid = oidset_iter_next(&iter))) {
1039                 struct blob *blob;
1040                 enum object_type type;
1041                 unsigned long size;
1042                 char *buf;
1043
1044                 if (oidset_contains(&gitmodules_done, oid))
1045                         continue;
1046
1047                 blob = lookup_blob(oid);
1048                 if (!blob) {
1049                         ret |= report(options, &blob->object,
1050                                       FSCK_MSG_GITMODULES_BLOB,
1051                                       "non-blob found at .gitmodules");
1052                         continue;
1053                 }
1054
1055                 buf = read_sha1_file(oid->hash, &type, &size);
1056                 if (!buf) {
1057                         if (is_promisor_object(&blob->object.oid))
1058                                 continue;
1059                         ret |= report(options, &blob->object,
1060                                       FSCK_MSG_GITMODULES_MISSING,
1061                                       "unable to read .gitmodules blob");
1062                         continue;
1063                 }
1064
1065                 if (type == OBJ_BLOB)
1066                         ret |= fsck_blob(blob, buf, size, options);
1067                 else
1068                         ret |= report(options, &blob->object,
1069                                       FSCK_MSG_GITMODULES_BLOB,
1070                                       "non-blob found at .gitmodules");
1071                 free(buf);
1072         }
1073
1074
1075         oidset_clear(&gitmodules_found);
1076         oidset_clear(&gitmodules_done);
1077         return ret;
1078 }