profile/tv/apps/web/browser.git
8 years agoAdding UrlHistoryList class and other classes managing display of 'URL from history' 41/49541/7 accepted/tizen/tv/20151019.074357 submit/tizen_tv/20151018.232544 submit/tizen_tv/20151019.233638 tizen_3.0.m2.a1_tv_release
Adam Skobodzinski [Wed, 14 Oct 2015 09:49:17 +0000 (11:49 +0200)]
Adding UrlHistoryList class and other classes managing display of 'URL from history'

[Issue]    https://bugs.tizen.org/jira/browse/TT-161
[Problem]  'Display URL from browser history that matches to given keyword.'
[Solution] Adding necessary class and .edc files. Usage implemention in other commit.

Signed-off-by: Adam Skobodzinski <a.skobodzins@partner.samsung.com>
Change-Id: I35c8b86409e024e107498a552623840553fb3735

8 years agoAdding HistoryService::getHistoryItemsByKeywordsString(). 40/49540/4
Adam Skobodzinski [Wed, 14 Oct 2015 08:55:08 +0000 (10:55 +0200)]
Adding HistoryService::getHistoryItemsByKeywordsString().

[Issue]    https://bugs.tizen.org/jira/browse/TT-161
[Problem]  "Url from history" needed new method in HistoryService getting urls basing on a keywords string.
[Solution] New method in HistoryService.

Signed-off-by: Adam Skobodzinski <a.skobodzins@partner.samsung.com>
Change-Id: I0d2ed414eb6af2b7cb61a14dfb9f7024e55a6729

8 years agoChange Url bar guide text 71/49471/8
posial [Tue, 13 Oct 2015 14:55:55 +0000 (16:55 +0200)]
Change Url bar guide text

[Issue] https://bugs.tizen.org/jira/browse/TT-216
[Problem] Outdated URL bar guide text
[Solution] URL bar guide text changed in accordance with new guidline specification
[Verify]
1. Focus on empty URL bar
2. Write some text
3. Clear text
4. Change focus

Change-Id: I4365b332e4ce7d3cec554366d3d34fa84ecfd7e4

8 years agoSetting page title in the URI entry. 76/49276/12 accepted/tizen/tv/20151015.053420 submit/tizen_tv/20151014.225154
Albert Malewski [Mon, 12 Oct 2015 08:26:52 +0000 (10:26 +0200)]
Setting page title in the URI entry.

[Issue]    https://bugs.tizen.org/jira/browse/TT-193
[Problem]  After page is loaded URL full URL address is displayed
           instead of the name of the page.
[Cause]    N/A
[Solution] Added setPageTitle function and connected it to titleChanged
           signal. Added showing URI when entry is focused and page title
           when unfocused. Additionally removed unneded _cb_mouse_in
           and _cb_mouse_out callbacks.
[Verify]   Launch browser > Enter an URL address > Obs
           Only page name should be visible.

Change-Id: Icd9da0fc2dbffb1779be895130d36391dd04835d

8 years agoNotification Popup implementation 25/49325/6
Dariusz Frankiewicz [Thu, 8 Oct 2015 06:58:22 +0000 (08:58 +0200)]
Notification Popup implementation

[Issue]    N/A
[Problem]  Lack of notification popup in settings.
[Solution] Implement missing functionality.
[Verify]   Go to settings and press all three buttons, afterch each of
           them notification popup should appear.

Change-Id: I45d217fbacb5f05c2d9d25d72dc2642df4142ab6
Signed-off-by: Dariusz Frankiewicz <d.frankiewic@samsung.com>
8 years agoRefactoring, renamed MainUI to QuickAccess 69/49469/2
Maciej Skrzypkowski [Tue, 13 Oct 2015 13:35:29 +0000 (15:35 +0200)]
Refactoring, renamed MainUI to QuickAccess

[Issue]    N/A
[Problem]  Misleading name
[Solution] Changed
[Verify]   Open Quick Access view, check if it works by clicking tiles etc.

Change-Id: Ibebaa3b3e4216adb762453b8d9bfc74dfa6ff3d8
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
8 years agoCookies saving between browser restarts. 57/49457/4
Maciej Skrzypkowski [Tue, 13 Oct 2015 11:13:36 +0000 (13:13 +0200)]
Cookies saving between browser restarts.

[Issue]    https://bugs.tizen.org/jira/browse/TT-138
[Problem]  Cookies saving path was not set.
[Solution] Addes cookies saving path.
[Verify]   Open onet.pl > click on X button in cookies popup information
           > close browser > open again onet.pl,
           cookies popup should not appear.

Change-Id: I4d0c4d1a544bd59a093dcf62092365121ef17435
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
8 years agoRefactoring, removed unneeded check in WebkitEngineService 06/49306/2 accepted/tizen/tv/20151014.043655 submit/tizen_tv/20151013.231319
Maciej Skrzypkowski [Mon, 12 Oct 2015 11:27:54 +0000 (13:27 +0200)]
Refactoring, removed unneeded check in WebkitEngineService

[Issue]    N/A
[Problem]  Unneeded check and unneeded line
[Solution] Removed
[Verify]   1.Open few tabs.
           2. Try to switch between them and check if it's OK

Change-Id: I0d9bb2eaa485277de4bd567a146fb6a49e768075
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
8 years agoAdd a few missing thumbail images 02/49302/4
Kamil Nowac [Mon, 12 Oct 2015 11:07:17 +0000 (13:07 +0200)]
Add a few missing thumbail images

[Issue] N/A
[Problem] Lack of few images
[Solution] Added images

Change-Id: I0f75c5d88d973e51d66f85403b5cddec76a968d3

8 years agoNavigation in Tab Manager 42/49442/1
Albert Malewski [Tue, 13 Oct 2015 08:04:47 +0000 (10:04 +0200)]
Navigation in Tab Manager

[Issue]    https://bugs.tizen.org/jira/browse/TT-214
[Problem]  Focus cannot move to "New Tab/New Incognito Tab" buttons.
[Cause]    N/A
[Solution] Added focus directions:
           "Up" arrow on "Opened tabs" -> focus moves to "Close tabs"
           "Left" arrow on "Close tabs" -> focus moves to "new incognito tab"
[Verify]   Launch browser > Open Tab Manager > Move focus to
           "New Tab/New Incognito Tab"

Change-Id: Ia5aea25a36e4fa779bca541621c250e45ec60f28

8 years agoFix for receiving of the last session from database 28/49228/3 accepted/tizen/tv/20151013.040805 submit/tizen_tv/20151012.224538
Kamil Nowac [Fri, 9 Oct 2015 08:03:40 +0000 (10:03 +0200)]
Fix for receiving of the last session from database

[Issue] https://bugs.tizen.org/jira/browse/TT-182
[Problem] Browser does not load the last session
properly.
[Solution] Changed SQL instruction and a Session
copy constructor
[Verify]
1.Open few tabs.
2.Close browser.
3.Open browser.
Tabs from the last session should be loaded.

Change-Id: I401a7ea2f864c8459e6b2c2a6cef3af035138627
Signed-off-by: Kamil Nowac <k.nowac@samsung.com>
8 years agoImplemented ZoomUI service 68/47568/12 accepted/tizen/tv/20151012.223346 submit/tizen_tv/20151011.233324
t.dakowicz [Fri, 4 Sep 2015 15:25:46 +0000 (17:25 +0200)]
Implemented ZoomUI service

[Issue#] https://bugs.tizen.org/jira/browse/TT-133
[Problem] Page zoom implementation
[Cause] N/A
[Solution] New ZoomUI service
[Verify] Open a new page -> MoreMenu -> Screen Zoom
         Check if zooming/navigating the page works.

Change-Id: I1c47d5fd37927e0a8f88f8952af1350791eac02f

8 years agoAdd star image to the quick access bookmark thumbnails 06/49206/5
Kamil Nowac [Thu, 8 Oct 2015 10:27:34 +0000 (12:27 +0200)]
Add star image to the quick access bookmark thumbnails

[Issue] https://bugs.tizen.org/jira/browse/TT-202
[Problem] No image
[Solution] Added image according to the GUI guideline
[Verification] Add some bookmarks. Go to the Bookmarks
in Quick Access menu. Star should be visible.

Change-Id: Iad04388526e84618d58a01065228366b6094f5fa
Signed-off-by: Kamil Nowac <k.nowac@samsung.com>
8 years agoRemove "On other devices" button from Tab Manager 58/49158/5
Kamil Nowac [Wed, 7 Oct 2015 10:27:41 +0000 (12:27 +0200)]
Remove "On other devices" button from Tab Manager

[Issue] https://bugs.tizen.org/jira/browse/TT-207
[Problem] "On other devices" button is excluded
from phase 1.
[Solution] Commented EDC parts connected with
the button
[Verification] Open tabs manager. There should be no
"On Other Devices" button.

Change-Id: I602d8be8feb16c880fe01a9a067f108af47339de
Signed-off-by: Kamil Nowac <k.nowac@samsung.com>
8 years agoFixed navigating by D-pad in Bookmark Manager 51/49151/6
Albert Malewski [Wed, 7 Oct 2015 08:34:04 +0000 (10:34 +0200)]
Fixed navigating by D-pad in Bookmark Manager

[Issue]    https://bugs.tizen.org/jira/browse/TT-183
[Problem]  There was a problem with navigation in Bookmark Manager.
[Cause]    Disabled "Add to bookmarks" button was blocking moving
           the focus.
[Solution] This is a workaround (because 'custom focus chain' API
           did not work properly. FocusManager class is used.
           Additionally, changed topContent from genlist to layout.
[Verify]   Launch browser > Navigate to Bookmarka Manager > Use arrows to
           move the focus.

Change-Id: I8f22bb24653f9df0dde5f5e009fbbd73d887d6ec

8 years agoImplemented new class FocusManager that manages focus in MoreMenu 39/49139/8
Albert Malewski [Tue, 6 Oct 2015 15:18:14 +0000 (17:18 +0200)]
Implemented new class FocusManager that manages focus in MoreMenu

[Issue]    https://bugs.tizen.org/jira/browse/TT-183
[Problem]  There was a problem with navigation in MoreMenu.
[Cause]    Disabled "Add to bookmarks" button was blocking moving
           the focus.
[Solution] This is a workaround (because 'custom focus chain' API
           did not work properly. I have created new class that
           stores objects to focus and implements mechanism of
           mooving the focus.
[Verify]   Launch browser > Navigate to More menu > Use arrows to
           move the focus.

Change-Id: I3942e97c3176a204fc2ccd8738344f179cf1e89b

8 years agoAdd dimmed Add to Bookmarks 16/49116/5
Kamil Nowac [Tue, 6 Oct 2015 13:32:39 +0000 (15:32 +0200)]
Add dimmed Add to Bookmarks

[Issue] https://bugs.tizen.org/jira/browse/TT-204
[Problem] Add to bookmarks button is not dimmed when are
no loaded pages
[Solution] According to the GUI guideline v0.5 dimmed button
should have white background and black text with
50% opacity.

Change-Id: Id0035d4bbcee6a5ecc67bc9caf35136e878652bd
Signed-off-by: Kamil Nowac <k.nowac@samsung.com>
8 years agoD-pad navigation for bookmarks in Quick Access view 17/49117/4
Maciej Skrzypkowski [Thu, 8 Oct 2015 09:46:48 +0000 (11:46 +0200)]
D-pad navigation for bookmarks in Quick Access view

[Issue]    https://bugs.tizen.org/jira/browse/TT-205
[Problem]  Threre was no d-pad navigation for bookmarks
[Cause]    Not implemented.
[Solution] Implemented adding and removing items from focus
           chain while switching between Most Visted and Bookmarks.
           Additionaly fixed switching between Most Visited
           and Bookmark buttons.
[Verify]   Add few bookmarks, switch to bookmarks view on Quick
           Access page, try to navigate using keboard.

Change-Id: Idb3f89e46af1ae3656fc3cc3d9ddb65115ba549e
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
8 years agoFix Reset browser functionality. 14/49114/3
Dariusz Frankiewicz [Tue, 6 Oct 2015 11:56:41 +0000 (13:56 +0200)]
Fix Reset browser functionality.

[Issue]    https://bugs.tizen.org/jira/browse/TT-176
[Problem]  Reset browser button didn't work.
[Cause]    Not implemented
[Solution] Add function calls that remove necessary items.
[verify]   Open some tabs, add some pages to bookmarks.
           Then go to the settings and press Reset Broswser.
           History, bookmarks, cookies, opened tabs should be deleted.

Change-Id: I592f2897e1d7447c544d2c8fc14847668c8e2059
Signed-off-by: Dariusz Frankiewicz <d.frankiewic@samsung.com>
8 years agoRemove dead code from WebView class 50/49050/1
sungwon2han [Tue, 6 Oct 2015 01:42:04 +0000 (10:42 +0900)]
Remove dead code from WebView class

Change-Id: I112affb7ce2924388cc7fb701a66671111d2c047
Signed-off-by: sungwon2han <sungwon2.han@samsung.com>
8 years agoFix reset most visited sites functionality. 26/49026/8 accepted/tizen/tv/20151006.042220 submit/tizen_tv/20151006.003037
Dariusz Frankiewicz [Mon, 5 Oct 2015 09:00:32 +0000 (11:00 +0200)]
Fix reset most visited sites functionality.

[Issue]    https://bugs.tizen.org/jira/browse/TT-175
[Problem]  Reset most visited sites isn't working.
[Cause]    Not implemented.
[Solution] Implemented setting site visit counter to 0 and
           displaying only sites with counter grater then 0.
[Verify]   Visit some sites, go to settings, press Reset Most Visted
           Sites button, check if on new tab most visited sites are empty.

Change-Id: I05d44043744a1b7859b23df282dfb53745fb894d
Signed-off-by: Dariusz Frankiewicz <d.frankiewic@samsung.com>
8 years agoFocus mode for DetailPopup. 16/49016/3
Maciej Skrzypkowski [Mon, 5 Oct 2015 07:29:48 +0000 (09:29 +0200)]
Focus mode for DetailPopup.

[Issue]    https://bugs.tizen.org/jira/browse/TT-196
[Problem]  Keyboard navigation for Detail Popup was not implemented.
[Cause]    N/A
[Solution] Added links to focus chain.
[Verify]   Launch browser > Open few web pages > open Quick Access
           > navigate using keyboard, open Detail Popup, navigate there
           using keyboard, try choosing main link and history links.

Change-Id: Ia78b68f364220232359ec1583c3e32c8aa191924
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
8 years ago[PointerMode] Pointer Mode removal 27/49027/4
Kamil Nowac [Mon, 5 Oct 2015 10:28:47 +0000 (12:28 +0200)]
[PointerMode] Pointer Mode removal

[Issue] https://bugs.tizen.org/jira/browse/TT-130
[Problem] Not needed feature
[Solution] N/A

Change-Id: Id3e2df1abe346d1c2575b915e1a906d73bb1b722
Signed-off-by: Kamil Nowac <k.nowac@samsung.com>
8 years agoChanged ordering of hiding Detail Popup. 92/48892/2
Maciej Skrzypkowski [Thu, 1 Oct 2015 08:45:19 +0000 (10:45 +0200)]
Changed ordering of hiding Detail Popup.

[Issue]    https://bugs.tizen.org/jira/browse/TT-199
[Problem]  Clicking on history link in detail popup caused openig gray,
           empty page.
[Cause]    Wrong order of opening new web page caused referencing
           to deleted object.
[Solution] Changed order, now popup hiding is after opening new URL.
[Verify]   Launch browser > Open few web pages > open Quick Access
           view, click on thumbnail, check if history links work.

Change-Id: I519e023592bc5870ab1330ec0157c06836eb154c
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
8 years agoRemoved dead code from SimpleUI 15/48215/6 accepted/tizen/tv/20150930.042038 submit/tizen_tv/20150929.235647
Maciej Skrzypkowski [Mon, 28 Sep 2015 06:54:23 +0000 (08:54 +0200)]
Removed dead code from SimpleUI

[Issue#:]   https://bugs.tizen.org/jira/browse/TT-157
[Problem:]  SimpleUI contains dead code. Lots of unimplemented and
            unused methods in class definition.
[Cause:]    N/A
[Solution:] Remove dead code and unused method definitions.
[Verify:]   Changes builds and doesn't breaks anything.

Change-Id: Id1e0df1abe445d8c2575b915e1a906d70bb1b741

8 years agoIntroduced new window management. 04/48604/13
Maciej Skrzypkowski [Tue, 29 Sep 2015 08:21:22 +0000 (10:21 +0200)]
Introduced new window management.

Continuation of patch proposed by Marcin Łapiński.

[Issue]    https://bugs.tizen.org/jira/browse/TT-157
[Problem]  There was no proper views management
[Cause]    N/A
[Solution] New class ViewManager for controling switching
           between views.
[Verify]   Launch browser > switch between different
           views (page view, more menu, settings, etc.),
           check if switching is correct check if there
           are no relevant warnings in logs.

Change-Id: I8827964b6539ecb7a4c02edd3d296b72a149a9e7
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
8 years agoFix bad progress bar position. 36/48736/2
Dariusz Frankiewicz [Fri, 25 Sep 2015 12:53:50 +0000 (14:53 +0200)]
Fix bad progress bar position.

[Issue]    N/A
[Problem]  Progress bar is invisible while page is loading.
[Cause]    Bad posiotion.
[Solution] Move progress bar down.
[Verify]   Load some page and check if progress bar is visible.

Change-Id: I0c628d60c46ae855dc517150bf235331846f7ed0
Signed-off-by: Dariusz Frankiewicz <d.frankiewic@samsung.com>
8 years agoRename some labels in browser. 37/48737/1
Dariusz Frankiewicz [Tue, 22 Sep 2015 15:07:19 +0000 (17:07 +0200)]
Rename some labels in browser.

[Issue]   https://bugs.tizen.org/jira/browse/TT-179
[Problem] Some labels are incorrect according to UI guidelines.
[Verify]  Check if reported labels are consistent with UI guidelines.

Change-Id: I4bb700e9003477611a9999aff415486a3236d2a2
Signed-off-by: Dariusz Frankiewicz <d.frankiewic@samsung.com>
8 years agoReneme More Menu tooltip label 12/48512/2 accepted/tizen/tv/20150925.012936 submit/tizen_tv/20150925.001246
Dariusz Frankiewicz [Tue, 22 Sep 2015 09:14:40 +0000 (11:14 +0200)]
Reneme More Menu tooltip label

[Issue]    https://bugs.tizen.org/jira/browse/TT-172
[Problem]  Wrong tooltip label.
[Solution] Rename label.
[Verify]   Open browser, point More Menu button and check if label is
           "More Menu" instead of "Settings".

Change-Id: I4694d62669952fae28533c8ae3540f6a7828fe18
Signed-off-by: Dariusz Frankiewicz <d.frankiewic@samsung.com>
8 years agoTT-168 Proper display of current site info 34/48534/3
t.dakowicz [Tue, 22 Sep 2015 12:15:06 +0000 (14:15 +0200)]
TT-168 Proper display of current site info

[Issue#] https://bugs.tizen.org/jira/browse/TT-168
[Problem] Current site info was wrong for Home Page (Quick Access view)
[Cause] Home Page status was not checked
[Solution] Added method for that case and added posibillity of disabling
           the 'add to bookmark' button when needed
[Verify] Check if adding blank page doesn't work

Change-Id: Iaf287a26a238732029897f867a34a8f1f810c813

8 years agoD-pad navigation for Quic access view 08/48608/1 accepted/tizen/tv/20150923.231359 submit/tizen_tv/20150923.224634
Maciej Skrzypkowski [Wed, 23 Sep 2015 14:44:14 +0000 (16:44 +0200)]
D-pad navigation for Quic access view

[Issue]    https://bugs.tizen.org/jira/browse/TT-183
[Problem]  There was no support for D-pad navigation in Quick Access.
[Cause]    Some elements seemed not to be allowed to be focused.
[Solution] Added buttons which enables to focus tiles in Quick Access.
[Verify]   Launch browser > Open few web pages > open Quick Access
           view, try to navigate using D-pad.

Change-Id: Ie0e5b661a8502d551539e9d89e59162d554eb044
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
8 years agoFixed navigating by D-pad in History and Settings 00/48600/3
Albert Malewski [Wed, 23 Sep 2015 11:06:16 +0000 (13:06 +0200)]
Fixed navigating by D-pad in History and Settings

[Issue]    https://bugs.tizen.org/jira/browse/TT-183
[Problem]  There was no support for D-pad navigation in More Menu.
[Cause]    Some elements seemed not to be allowed to be focused.
[Solution] Added focus on some elements in HistoryUI and SettingsUI
           using elm_object_focus_custom_chain_append. Set focus on
           'Close' button by default. Cleared focused elements from
           MoreMenuUI that were visible in HistoryUI, BookmarkManagerUI
           and SettingsUI.
[Verify]   Launch browser > Navigate to More menu > Choose an item
           You should be able to go into Bookmarks/History/Settings
           from More Menu just using keyboard/D-pad.

Change-Id: Ica000176f025659b2a4352a2b4e49fe13f552b92

8 years agoFixed navigating by D-pad in More Menu 76/48576/2 accepted/tizen/tv/20150923.231332 submit/tizen_tv/20150923.083054
Albert Malewski [Wed, 23 Sep 2015 06:13:29 +0000 (08:13 +0200)]
Fixed navigating by D-pad in More Menu

[Issue]    https://bugs.tizen.org/jira/browse/TT-183
[Problem]  There was no support for D-pad navigation in More Menu.
[Cause]    Incorrect method of callback registration was used.
[Solution] Registered callback in elm_gengrid_item_append function
           instead of evas_object_smart_callback_add.
[Verify]   Launch browser > Navigate to More menu > Choose an item
           You should be able to go into Bookmarks/History/Settings
           from More Menu just using keyboard/D-pad.

Change-Id: Ib4673f0e645dbc1c3cbf4d4e2503cf4609b5a205

8 years agoBrowser exit when load history items 74/48574/1
sungwon2han [Wed, 23 Sep 2015 06:18:59 +0000 (15:18 +0900)]
Browser exit when load history items

[Issue#] NA
[Problem] Browser cannot get history info from browser-provider
[Cause] browser-provider issue
[Solution] add error check routine for browser-provider

Change-Id: I12368bc9394e8115c4debfa9b72d8aa5a9aa9f5c
Signed-off-by: sungwon2han <sungwon2.han@samsung.com>
8 years agoBrowser exit when load bookmark items 65/48565/1
sungwon2han [Wed, 23 Sep 2015 04:53:33 +0000 (13:53 +0900)]
Browser exit when load bookmark items

[Issue#] NA
[Problem] Browser cannot get bookmark info from browser-provider
[Cause] browser-provider issue
[Solution] add error check routing for browser-provider

Change-Id: If91dc072d4c6294d331294b7cde74433d1dc2f2f
Signed-off-by: sungwon2han <sungwon2.han@samsung.com>
8 years agoTT-171 Removing bookmark folders from browser 39/48439/8 accepted/tizen/tv/20150922.232938 submit/tizen_tv/20150922.230855
t.dakowicz [Mon, 21 Sep 2015 11:47:00 +0000 (13:47 +0200)]
TT-171 Removing bookmark folders from browser

[Issue#] https://bugs.tizen.org/jira/browse/TT-171
[Problem] N/A
[Cause] Newest guide doesn't contain folders anymore
[Solution] Removed bookmark folders
[Verify] Check if bookmarks are added/removed/displayed properly

Change-Id: Ife3cd8859ef4e1ceb1c4fae0412f40314e89fe02

8 years agoTT-163 'Add to bookmarks' UI change 79/48179/16 accepted/tizen/tv/20150922.001457 submit/tizen_tv/20150921.230152
t.dakowicz [Tue, 15 Sep 2015 14:40:23 +0000 (16:40 +0200)]
TT-163 'Add to bookmarks' UI change

[Issue#] https://bugs.tizen.org/jira/browse/TT-163
[Problem] N/A
[Cause] 1.02 UI guideline
[Solution] Added checkbox that defines current bookmark status
           and toast popup for info purpose

Choosing folder for a new bookmark is still there.
Checkbox's style 'favorite' is not available.

Change-Id: I78eaf6ca94d6c0ca6605b6822ea5e5c087260d90

8 years agoChanged database path 97/48397/3
Albert Malewski [Mon, 21 Sep 2015 08:45:52 +0000 (10:45 +0200)]
Changed database path

[Issue]    N/A
[Problem]  There was wrong database path which resulted in fails
           while launching the browser.
[Cause]    Wrong Tizen platform variable was used.
[Solution] Used TZ_USER_APP instead of TZ_USER_DB and added <pkgid>/data
           directory.
[Verify]   Launch browser > Observe logs
           There shouldn't be fails in logs while loading database.

Change-Id: Ibb2a6934f25b4974d2c6990cc78b1d97b8137bce

8 years agoClosing app when pressing back key on Web Page view. 98/48398/2
Maciej Skrzypkowski [Mon, 21 Sep 2015 08:48:29 +0000 (10:48 +0200)]
Closing app when pressing back key on Web Page view.

[Issue#]   https://bugs.tizen.org/jira/browse/TT-170
[Problem]  Browser didn't close when pressing back key.
[Cause]    There was a check if back button is enabled which prevent
           from closing app when there was no previous web page.
[Solution] Removed unneeded check.
[Verify]   Run browser, visit some web page, press back button, check
           if browser will close.

Change-Id: I46c29149a1d311679f9b6ef141f6dd71dc335363
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
8 years agoMoved code responsible for web page ui to separate service. 68/48368/6
Maciej Skrzypkowski [Mon, 21 Sep 2015 09:24:46 +0000 (11:24 +0200)]
Moved code responsible for web page ui to separate service.

[Issue]    https://bugs.tizen.org/jira/browse/TT-167
[Problem]  Functionality of SimpleUI was confusing.
[Cause]    N/A
[Solution] Created new class WebPageUI, moved all classes connected
           to web page ui to new service.

Change-Id: I633b5c5abad0040b9b7d51e5fb532de2c0d25689
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
8 years agoRevert "Changed database path" 78/48378/1
Dariusz Frankiewicz [Fri, 18 Sep 2015 14:53:18 +0000 (07:53 -0700)]
Revert "Changed database path"

This reverts commit 5059e93c83493911ad58c4c26162f2792c99ded6.

Change-Id: I8cdfa7391739693de3813eed6d2179a90f94f76f

8 years agoChanged database path 75/48375/2
Albert Malewski [Fri, 18 Sep 2015 13:02:56 +0000 (15:02 +0200)]
Changed database path

[Issue]    N/A
[Problem]  There was wrong database path which resulted in fails
           while launching the browser.
[Cause]    Wrong Tizen platform variable was used.
[Solution] Used TZ_USER_APP instead of TZ_USER_DB.
[Verify]   Launch browser > Observe logs
           There shouldn't be fails in logs while loading database.

Change-Id: I2641314543647e15cdfc70b5b8decc201fdcc57b

8 years agofixup! ViewManager class added. 62/48362/1
Dariusz Frankiewicz [Fri, 18 Sep 2015 10:18:53 +0000 (12:18 +0200)]
fixup! ViewManager class added.

Change-Id: I9a52869f215df69a9e82c18ab2b3e4c547ea1c1d

8 years agoViewManager class added. 55/48055/7
Marcin Lapinski [Fri, 11 Sep 2015 13:37:24 +0000 (15:37 +0200)]
ViewManager class added.

[Issue#:]   https://bugs.tizen.org/jira/browse/TT-157
[Problem:]  New window management class is needed.
[Cause:]    N/A
[Solution:] Implemented new class with following public methods:
            popStackTo
            popTheStack
            pushViewToStack
            getContent

[Verify:]   Class is not used. Changes builds and doesn't crash.

Merge this after merging this patch:
https://review.tizen.org/gerrit/#/c/48052/

Change-Id: I4b8ca2866fa1cecbf858b4aed41e42112620a9f7

8 years agoMake AbstractUIComponent doing anything. 52/48052/12
Marcin Lapinski [Fri, 11 Sep 2015 12:04:37 +0000 (14:04 +0200)]
Make AbstractUIComponent doing anything.

[Issue#:]   https://bugs.tizen.org/jira/browse/TT-157
[Problem:]  New window management class needs AbstractUIComponent to
            have some view managing functions.
[Cause:]    N/A
[Solution:] Added needed methods to interface:
            void init(Evas_Object* parent)
            Evas_Object* getContent()
            void showUI()
            void hideUI()
[Verify:]   Change builds. Browser is not crashing on loading services.

Merge it after all UI components implement these methods.

Change-Id: I7c67cad62a5b68a713395ecc1487fa9e90c72bc7

8 years agoRemove unused classes. 16/48116/3
Maciej Skrzypkowski [Tue, 15 Sep 2015 08:33:12 +0000 (10:33 +0200)]
Remove unused classes.

[Issue#]   N/A
[Problem]  These classes were unused.
[Cause]    N/A
[Solution] Delete classes and theirs references.
[Verify] Run browser, check if page browsing works.

Change-Id: I11bd790c0cec58dfa7e13f7b9d553a8b822e69a3
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
8 years agoMoreMenuUI Implementing new AbstractUIComponent methods. 19/48119/3
Marcin Lapinski [Mon, 14 Sep 2015 13:48:57 +0000 (15:48 +0200)]
MoreMenuUI Implementing new AbstractUIComponent methods.

[Issue#:]   https://bugs.tizen.org/jira/browse/TT-157
[Problem:]  New window management class needs AbstractUIComponent to
            have some view managing functions.
[Cause:]    N/A
[Solution:] Implemented needed methods:
            void init(Evas_Object* parent)
            Evas_Object* getContent()
            void showUI()
            void hideUI()
[Verify:]   Change is not affecting browsers behaviour.

Change-Id: I4aef907e35f5240be86c259f4d6705a43c93ee4a

8 years agoTabUI Implementing new AbstractUIComponent methods. 25/48125/1
Marcin Lapinski [Mon, 14 Sep 2015 16:16:49 +0000 (18:16 +0200)]
TabUI Implementing new AbstractUIComponent methods.

[Issue#:]   https://bugs.tizen.org/jira/browse/TT-157
[Problem:]  New window management class needs AbstractUIComponent to
            have some view managing functions.
[Cause:]    N/A
[Solution:] Implemented needed methods:
            void init(Evas_Object* parent)
            Evas_Object* getContent()
            void showUI()
            void hideUI()
[Verify:]   Change is not affecting browsers behaviour.

Change-Id: I6d4a91af909722050564690510f64e9c331b7fe5

8 years agoRemoved inheritance of AbstractUIComponent in MainUI and SimpleURI classes 12/48112/2 accepted/tizen/tv/20150917.041341 submit/tizen_tv/20150915.034203
Albert Malewski [Mon, 14 Sep 2015 12:12:12 +0000 (14:12 +0200)]
Removed inheritance of AbstractUIComponent in MainUI and SimpleURI classes

[Issue]    https://bugs.tizen.org/jira/browse/TT-157
[Problem]  MainUI and SimpleURI classes are not UI components in fact.
           They are not suspected to call AbstractUIComponent's methods.
[Cause]    N/A
[Solution] Removed inheritance of AbstractUIComponent in MainUI
           and SimpleURI classes.
[Verify]   This patch does not change browser's behaviour.

Change-Id: I048c6ad288df7af331efda6552565b83a112af08

8 years agoBookmarkManagerUI Implementing new AbstractUIComponent methods. 51/48051/10
Marcin Lapinski [Fri, 11 Sep 2015 11:54:40 +0000 (13:54 +0200)]
BookmarkManagerUI Implementing new AbstractUIComponent methods.

[Issue#:]   https://bugs.tizen.org/jira/browse/TT-157
[Problem:]  New window management class needs AbstractUIComponent to
            have some view managing functions.
[Cause:]    N/A
[Solution:] Implemented needed methods:
            void init(Evas_Object* parent)
            Evas_Object* getContent()
            void showUI()
            void hideUI()
[Verify:]   Change is not affecting browsers behaviour.

Change-Id: Ia8f4eca29b82a54f239671f32bc6c43f9a47b7fe

8 years agoAdded proper handler for bookmark click in Quick Access view. 07/48107/1
Maciej Skrzypkowski [Mon, 14 Sep 2015 11:07:04 +0000 (13:07 +0200)]
Added proper handler for bookmark click in Quick Access view.

[Issue]    N/A
[Problem]  Clicking on bookmark caused opening popup or crashing.
[Cause]    Wrong callback was assigned to bookmark click.
[Solution] Changed callback to opening new tab.

Change-Id: I85dbaa29ba83005e25a4796f80a80c901a23a1f9
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
8 years agoRefactoring - removed genlist from Quick Access tiles. 93/48093/5
Maciej Skrzypkowski [Mon, 14 Sep 2015 10:25:36 +0000 (12:25 +0200)]
Refactoring - removed genlist from Quick Access tiles.

[Issue]    N/A
[Problem]  Genlist were unneeded for tiles.
[Cause]    N/A
[Solution] Removed genlist, added aditional swallows for tiles.

Change-Id: I9a561d2973c9db0b70f413792dfdab4a2e7c24ab
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
8 years agoTT-165 Fixed browser crash after opening page from history/bookmarks 47/48047/5
t.dakowicz [Fri, 11 Sep 2015 11:16:44 +0000 (13:16 +0200)]
TT-165 Fixed browser crash after opening page from history/bookmarks

[Issue#] https://bugs.tizen.org/jira/browse/TT-165
[Problem] Browser's crash after opening a page from bookmarks/history
[Cause] Favicon was inserted into freed object
[Solution] Added disconnects from signals after closing MoreMenu
[Verify] New Tab -> MoreMenu -> History -> open page
         or New Tab -> Bookmarks -> open page
         Check if browser crashes

Please keep in mind that disconnects are needed here because views
are removed when exiting, which won't be done in future new browser's
structure.

Change-Id: I7a8db96b35d397b88196bbdbba21f526c73c2ec8

8 years agoSimpleUI refactoring 64/47264/10
Marcin Lapinski [Tue, 1 Sep 2015 11:33:29 +0000 (13:33 +0200)]
SimpleUI refactoring

[Issue#:]    https://bugs.tizen.org/jira/browse/TT-157
[Problem:]   Function exec() covers functionality which will be
             covered by different classes;
[Cause:]     N/A
[Sollution:] Splitted huge exec() to few smaller.
[Verify:]    Refactor is not affecting browsers behaviour.

Change-Id: I073154a3116ef7ff9723e2445737a699f59e214e

8 years agoImplementing AbstractUIComponent's new interface methods in SettingsUI 27/48027/7
Albert Malewski [Fri, 11 Sep 2015 08:27:53 +0000 (10:27 +0200)]
Implementing AbstractUIComponent's new interface methods in SettingsUI

[Issue]    https://bugs.tizen.org/jira/browse/TT-157
[Problem]  Improper view navigation is used.
[Cause]    N/A
[Solution] Implemented needed methods:
           void init(Evas_Object *parent)
           Evas_Object* getContent()
           void showUI()
           void hideUI()
[Verify]   Launch browser > More Menu > Settings > Obs
           Settings should be displayed correctly.

It needs implementation on SimpleUI side - when it's done,
show() function should be removed.

Change-Id: Ic28f501398cf55de4b4a5a9d5bae20bada55c525

8 years agoHistoryUI Refactor 82/47982/9 accepted/tizen/tv/20150914.043144 submit/tizen_tv/20150913.234024
Albert Malewski [Thu, 10 Sep 2015 13:14:29 +0000 (15:14 +0200)]
HistoryUI Refactor

[Issue]    https://bugs.tizen.org/jira/browse/TT-157
[Problem]  Improper view navigation is used.
[Cause]    N/A
[Solution] Implemented needed methods:
           void init(Evas_Object *parent)
           Evas_Object* getContent()
           void showUI()
           void hideUI()
[Verify]   Launch browser > More Menu > History > Obs
           History should be displayed correctly.

It needs implementation on SimpleUI side - when it's done,
show() function should removed.

Change-Id: I83500ec9053f9ac9fc418f63f7b87f5a24a38c92

8 years agoAdded thubnail and history links clicking for detail popup. 79/47979/3
Maciej Skrzypkowski [Thu, 10 Sep 2015 12:34:17 +0000 (14:34 +0200)]
Added thubnail and history links clicking for detail popup.

[Issue]     https://bugs.tizen.org/jira/browse/TT-144
[Problem]   Detail popup missed thumbnail.
[Cause]     N/A
[Solution]  Added thumbnail in proper size.
[Verify]    Launch browser > open few pages >
            check thubnails Most Visited view in detail popup,
            check if history links in popup are clickable.

Change-Id: I50d3e2862fc672a41de8cdc50f790f48f19ff21d
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
8 years agoTT-101 Fixed URL bar update and added doc icon 84/47884/5
t.dakowicz [Wed, 9 Sep 2015 13:57:01 +0000 (15:57 +0200)]
TT-101 Fixed URL bar update and added doc icon

[Issue#] https://bugs.tizen.org/jira/browse/TT-101
[Problem] URL bar shows wrong URL after back/forward action
[Cause] Multiple URL changes and lack of direct connection to
        proper SimpleURI method
[Solution] Added direct connection to SimpleURI::changeUri and
           added doc icon for pages not loaded completely
           (placeholder)
[Verify] Check if back/forward action causes correct URL update

Change-Id: Ibc5cad20397328789d3bfcc07e0852d41d1a87b7

8 years agoFixed bookmark creation 88/47988/1 tizen_3.0.m1_tv accepted/tizen/tv/20150911.145821 accepted/tizen/tv/20150914.120401 submit/tizen/20150914.114621 submit/tizen_tv/20150911.013041 tizen_3.0.m1_tv_release
t.dakowicz [Thu, 10 Sep 2015 13:55:02 +0000 (15:55 +0200)]
Fixed bookmark creation

[Issue#] N/A
[Problem] Bookmarks couldn't be created
[Cause] Variables used in 'bp_bookmark_adaptor_easy_create()' had some
        not initialized values
[Solution] std::memset before passing its reference
[Verify] Check if bookmarks can be created

Change-Id: I861e70a6f6fa8e980423eb2721899421de9c485b

8 years agoFixed crash while loading page without title. 67/47767/3 accepted/tizen/tv/20150910.025343 submit/tizen_tv/20150910.010500
Maciej Skrzypkowski [Tue, 8 Sep 2015 14:04:20 +0000 (16:04 +0200)]
Fixed crash while loading page without title.

[Issue]     https://bugs.tizen.org/jira/browse/TT-162
[Problem]   Browser crashed while loading page.
[Cause]     There was no check if page title is empty while comparing.
[Solution]  Changed compering to URL, added check if it's empty.
[Verify]    Launch browser > go to: http://jmajnert.github.io/tests/localStorage_test/localStoragePersistance.html
            refresh page > close browser > open again > go to previous site.
            Browser shouldn't crash.

Change-Id: Icc19ad7a327d97fe6ff79777b0fc819189cf660a
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
8 years agoFixed radio selection in settings 43/47743/1 accepted/tizen/tv/20150909.055754 submit/tizen_tv/20150909.041734
Albert Malewski [Tue, 8 Sep 2015 07:44:29 +0000 (09:44 +0200)]
Fixed radio selection in settings

[Issue]     https://bugs.tizen.org/jira/browse/TT-154
[Problem]   Cannot select any item in radio list at Web contents Sharing section.
[Cause]     Every radio was set to one group. Missing state valuesof radios.
[Solution]  Added enums with state values and separate radio buttons within
            3 lists.
[Verify]    Launch browser > More Menu > Settings > Obs
            You should be able to select any radio in settings.

Change-Id: I894d6527770c51066be60372cc3e69646c21ff82

8 years agoSwitching between mobile/desktop mode per tab. 15/47715/3
Maciej Skrzypkowski [Tue, 8 Sep 2015 08:27:34 +0000 (10:27 +0200)]
Switching between mobile/desktop mode per tab.

[Issue#]   https://bugs.tizen.org/jira/browse/TT-132
[Problem]  View mode was set as global flag.
[Cause]    N/A
[Solution] Added flag for each tab to remeber current mode.
[Verify]   Open new tab (google.com), open settings, switch to mobile
           mode, page should reload in mobile view.

Change-Id: I19a6f1965938930b45f46b076ce030f2fe9c10ed
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
8 years agoRefactoring - deleted unused history SQLite classes. 21/47721/2
Maciej Skrzypkowski [Tue, 8 Sep 2015 08:39:46 +0000 (10:39 +0200)]
Refactoring - deleted unused history SQLite classes.

[Issue#]   N/A
[Problem]  These history classes were not used.
[Cause]    N/A
[Solution] Removed dead code.
[Verify]   Open few pages, check if they appeared in history.

Change-Id: Ia996b2259a7cc8c6e5506eb707a4f0a89c494aae
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
8 years agoAdded switching between 'Open Tabs' and 'On Other Devices' 54/47554/6
Albert Malewski [Fri, 4 Sep 2015 11:23:47 +0000 (13:23 +0200)]
Added switching between 'Open Tabs' and 'On Other Devices'

[Issue]     https://bugs.tizen.org/jira/browse/TT-149
[Problem]   "Opened Tabs" is not toggle with "On Other Devices" in Tab Manager.
[Cause]     Lack of implementation.
[Solution]  Added boolean onOtherDevicesSwitch variable, which allows to switch
            between 'Open Tabs' and 'On Other Devices' correctly. Changed type
            of onotherdevices_click and openedtabs_click from RECT to SWALLOW.
            Additionally, changed 'tab_gengird' to 'tab_gengrid'.
[Verify]    Launch browser > Open new tab > Tabs > On Other Devices > Obs
            Tabs should be hidden when 'On Other Devices' is clicked.

Change-Id: I18529df81e274dcbc658e8db7ef038b4080e907d

8 years agoTT-158 Fixed 'Clear History' bug 73/47473/7 accepted/tizen/tv/20150904.064311 submit/tizen_tv/20150903.235433
t.dakowicz [Thu, 3 Sep 2015 14:25:39 +0000 (16:25 +0200)]
TT-158 Fixed 'Clear History' bug

[Issue#] https://bugs.tizen.org/jira/browse/TT-158
[Problem] Browser's crash after clicking on 'clear history'
          button
[Cause] 'm_historyUI' object was not freed after closing the HistoryUI,
        which caused multiple sending of the clearHistory signal
[Solution] Provided proper object management and prevented multiple
           creation of the 'm_historyUI'.
           In addition, there is a problem with displaying NoHistoryLabel
           from the HistoryUI - currently, it is not available from there
[Verify] Do some browsing -> MoreMenu -> History Manager -> Clear
         Check if this action causes browser's crash

Change-Id: I8be4b31c67b901d241d0bafdd621b72d5ea4c5f4

8 years agoFixed creating history list 72/47472/2
Albert Malewski [Thu, 3 Sep 2015 06:16:11 +0000 (08:16 +0200)]
Fixed creating history list

[Issue#]    https://bugs.tizen.org/jira/browse/TT-159
[Problem]   "Close Tabs" function is not implemented in Tab Manager.
[Cause]     N/A
[Solution]  Added closeAllTabs, closeTabsClicked functions. Added boolean
            'editMode' variable that conditions action in _thumbSelected function.
            Added callback to make 'X' icon and '[OK] to close' visible.
[Verify]    Launch browser > Add tabs > Tab manager > Close Tabs
            Check if 'Close all' button works properly
            Check if closing selected item works properly

Change-Id: I98453027ad3ccfa797ab94e1e2c3ffa67f65d28f

8 years agoRefactor SettingsUI 37/47237/4
Dariusz Frankiewicz [Mon, 31 Aug 2015 07:13:00 +0000 (09:13 +0200)]
Refactor SettingsUI

[Issue#]   https://bugs.tizen.org/jira/browse/TT-153
[Problem]  Check boxes in settings menu can't be clicked.
[Cause]    Invisible platform rectangle covers this screen area.
[Solution] Refactoring settings UI code by replacing unneded genlist,
           with layout inside scrooler. Also added possibility to click
           check box labels as a complementary fix for platform issue
           with invisible rectangle.
[Verify]   Open More menu -> Settings and check if check boxes: Cache,
           Cookies and History can be changed by clicking their labels.

Change-Id: I49e2ea04054cb1efdecd3fed02d26914b1ecac48
Signed-off-by: Dariusz Frankiewicz <d.frankiewic@samsung.com>
8 years agoUser agent set depending on browsing mode (desktop/mobile). 51/47451/2
Maciej Skrzypkowski [Thu, 3 Sep 2015 10:28:26 +0000 (12:28 +0200)]
User agent set depending on browsing mode (desktop/mobile).

[Issue#]  https://bugs.tizen.org/jira/browse/TT-132
[Problem] Browising mode switching was not implemented.
[Cause]   N/A
[Solution]Added changing user agent by using EWK API
          method: ewk_view_user_agent_set.
[Verify]  Open new page, go to google.com then
          settings > view mobile web then close settings,
          type in new URL google.com, it should appear
          in mobile mode.

Change-Id: I8a6888d09b94f97eb51b9d2440f04bf8e2ba544c
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
8 years agoTT-106 Removed MoreMenu's tiles from BookmarkManager screen 85/46985/9 accepted/tizen/tv/20150903.053724 submit/tizen_tv/20150903.010345
t.dakowicz [Thu, 27 Aug 2015 16:32:57 +0000 (18:32 +0200)]
TT-106 Removed MoreMenu's tiles from BookmarkManager screen

[Issue#] https://bugs.tizen.org/jira/browse/TT-106
[Problem] Tiles from MoreMenu was visible and accessible
          from BookmarkManager screen
[Caused] Items were not cleared/hidden
[Solution] This solution just clear those problematic items from
           MoreMenu - it should be removed after the new correct
           displaying design will be done
[Verify] MoreMenu->BookmarkManager or
         MainUI->Bookmarks->BookmarkManager
         Check if any invisible tile is accessible or visible

Change-Id: I371496d9befb64095721354f76fbb56d5fd18fc9

8 years agoFixed not displaying thumbnails on Most visited screen. 28/47228/2 accepted/tizen/tv/20150902.004909 submit/tizen_tv/20150901.234711
Maciej Skrzypkowski [Tue, 1 Sep 2015 07:28:14 +0000 (09:28 +0200)]
Fixed not displaying thumbnails on Most visited screen.

[Issue#] https://bugs.tizen.org/jira/browse/TT-73
[Problem] There was no thumbnails on main screen.
[Cause] Website thumbnail was not saved and not fetched.
[Solution] Added saving thumbnail on page finish loading and fetching it
for Most visited screen.
[Verify] Visit few different sites (wait until page is fully loaded) > open
the Most visited screen, check if there are thumbnails.

Change-Id: I8d8e648df0d1314fa772e5519ee07a06e795bc63
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
8 years agoAdded detail popup to most visited view. 53/47053/5
Maciej Skrzypkowski [Fri, 28 Aug 2015 14:23:53 +0000 (16:23 +0200)]
Added detail popup to most visited view.

[Issue#]   https://bugs.tizen.org/jira/browse/TT-144
[Problem]  N/A
[Cause]    N/A
[Solution] Create popup view.
[Verify]   Open most visited view, click on tile, check if new popup
           with history appears

Change-Id: Ia8ecffbba4d93e7d759780cf49f35a2c03c87fda
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
8 years agoFixed creating history list 73/46973/3
Albert Malewski [Thu, 27 Aug 2015 12:12:36 +0000 (14:12 +0200)]
Fixed creating history list

[Issue#]    https://bugs.tizen.org/jira/browse/TT-156
[Problem]   There is at most 5 items visible in history and the list
            is not updated.
[Cause]     There was used getMostVisitedHistoryItems function to generate
            history list.
[Solution]  Added several functions in HistoryService to get history list:
            getHistoryAll, getHistoryToday, getHistoryYesterday, getHistoryLastWeek,
            getHistoryLastMonth, getHistoryOlder.
[Verify]    Launch browser > More Menu > History > Obs
            History should not crash after clicking on 'History' button.

Change-Id: I1dde7088555a4cdba01e92be78c3dda5276040c4

8 years agoTT-141 Added current web page info sync 82/46982/8 accepted/tizen/tv/20150901.083958 submit/tizen_tv/20150901.005232
t.dakowicz [Thu, 27 Aug 2015 14:43:15 +0000 (16:43 +0200)]
TT-141 Added current web page info sync

[Issue#] https://bugs.tizen.org/jira/browse/TT-141
[Problem] Current web page info wasn't always updated and
          favicon wasn't loaded
[Cause] Lack of proper signals
[Solution] Added signals, removed genlist and used single layout instead,
           resized space for site info, removed pointless image reload
           from  WebView::getFavicon
[Verify] Open a new page -> type web url -> MoreMenu
         Check if the info is properly loaded

Change-Id: Ibe3f7cd97279470761eaa9f58c9e40b06c655eeb

8 years agoFixed crash that occurs after clicking on 'History' button 98/46798/6 accepted/tizen/tv/20150828.012542 submit/tizen_tv/20150827.234458
Albert Malewski [Thu, 27 Aug 2015 07:45:37 +0000 (09:45 +0200)]
Fixed crash that occurs after clicking on 'History' button

[Issue#]    https://bugs.tizen.org/jira/browse/TT-98
[Problem]   Browser crashes after clicking on 'History' button.
[Cause]     There was used normal pointer that pointed to the destroyed object.
[Sollution] 1. Changed type of HistoryService::getHistoryItems() and
            HistoryService::getMostVisitedHistoryItems() functions that the return
            std::shared_ptr<std::vector<std::shared_ptr<HistoryItem> > >.
            2. Added HistoryService::getHistoryItem function which returns HistoryItem by id.
            3. Added HistoryService::getCurrentTab functions that returns currently
            observed web page's info.
            4. Changed type of h_item pointer in MoreMenuUI.cpp from normal pointer to
            shared_ptr.
            5. Added listItemDel function to avoid memory leaks when genlist is cleared.
[Verify]    Launch browser > More Menu > History > Obs
            History should not crash after clicking on 'History' button.

Change-Id: I9140c1dedc061b2d014792aa14da92053e7aa27f

8 years agoRefactoring MainUI 63/46563/12
Marcin Lapinski [Fri, 21 Aug 2015 13:33:02 +0000 (15:33 +0200)]
Refactoring MainUI

[Issue#]    https://bugs.tizen.org/jira/browse/TT-72
[Problem]   MainUI needs refactoring.
[Cause]     N/A
[Sollution] Following actions were taken:
            -Split humongous show functions into several smaller.
            -Removed unused functions.
            -Logically split most visited and bookmark view.
            -Replace redundant class members with local variables.
            -Renamed functions and variables to make names more adequate.
[Verify]    1. Browser builds
            2. Refactor does not change behaviour of browser.

Change-Id: I44a5c958ad4e7b0c694434a4cfdb45702c871ec7

8 years agoRefactoring TabUI 56/46756/3
Marcin Lapinski [Tue, 25 Aug 2015 15:48:36 +0000 (17:48 +0200)]
Refactoring TabUI

[Issue#]    https://bugs.tizen.org/jira/browse/TT-72
[Problem]   TabUI needs refactoring.
[Cause]     N/A
[Sollution] Following actions were taken:
            -Split humongous show functions into several smaller.
            -Removed unused functions.
            -Replaced redundant class members with local variables.
            -Renamed functions, variables and edc names to make names
             more adequate.
[Verify]    1. Browser builds
            2. Refactor does not change behaviour of browser.

Change-Id: I12a850bfb239b2d8477536517dfb93bb1db76df4

8 years agoChange the log level INFO to DEBUG 86/46786/1 accepted/tizen/tv/20150826.095630 submit/tizen_tv/20150826.065702
cookie [Wed, 26 Aug 2015 06:42:49 +0000 (15:42 +0900)]
Change the log level INFO to DEBUG

[Issue#]    The browser log don't display by journalctl -fl
[Problem]   The browser log don't display for debugging
[Cause]     The log level is INFO
[Sollution] Change to log level to LoggerLevel::DEBUG

Change-Id: Iefd33af8344996d0de812e290476f948a387fa1b
Signed-off-by: cookie <cookie@samsung.com>
8 years agoFixed bug that 2nd app control is not working 80/46780/2
Jung Ick Guack [Wed, 26 Aug 2015 06:01:02 +0000 (15:01 +0900)]
Fixed bug that 2nd app control is not working

[Issue#]    HQ Synergy TF team reported the issue
[Problem]   Only 1st app control is working.
            After 2nd app control is not working.
[Cause]     There is wrong scope for first initializing code when start SimpleUI::exec
[Sollution] Move opening new tab to out of first initializing scope.
[Verify]    App control should open the tab even after 2nd command.
            HQ Synergy TF team verified thie fix.

Change-Id: Ic59d7e977c07a90de6aea455224d4bb44db7c922
Signed-off-by: Jung Ick Guack <ji.guack@samsung.com>
8 years agoReintroduce removed ewk_view_screenshot_contents_get api call. 12/45812/4 accepted/tizen/tv/20150826.015718 submit/tizen_tv/20150825.231341
Marcin Lapinski [Mon, 10 Aug 2015 09:18:01 +0000 (11:18 +0200)]
Reintroduce removed ewk_view_screenshot_contents_get api call.

[Issue#]    https://bugs.tizen.org/jira/browse/TT-89
[Problem]   Bookmark items do not show its thumbnail.
[Cause]     N/A
[Sollution] Put ewk_view_screenshot_contents_get call back as it
            was moved to public api.
[Verify]    Bookmark items thumbnalis should be visible.

Change-Id: I50538f737eebbce566565f5c6052266125d52610

8 years agoTT-134 Implemented tree structure of bookmark folders 66/46366/13
t.dakowicz [Wed, 19 Aug 2015 13:00:17 +0000 (15:00 +0200)]
TT-134 Implemented tree structure of bookmark folders

[Issue#] https://bugs.tizen.org/jira/browse/TT-134
[Problem] New folders were always added to the root folder
[Cause] N/A
[Solution] Used properly a current folder variable,
           changed displaying/updating folder content and
           did minor style improvements
[Verify] Check if new folder addition inside a folder
         actually adds a folder to the selected one.

Please keep in mind that there are some problems with diplaying
content inside folders, which will be handled in separate issue.

Change-Id: Ic5f71c57d78e95bb9878bf17d84db57eb57b8f9d

8 years agoRefactoring MainUI 70/46370/4
Marcin Lapinski [Wed, 19 Aug 2015 12:25:54 +0000 (14:25 +0200)]
Refactoring MainUI

[Issue#]    https://bugs.tizen.org/jira/browse/TT-72
[Problem]   MainUI needs refactoring.
[Cause]     N/A
[Sollotion] -Removed redundant gengrid from bottom panel.
            -Removed unused declarations.
            -Removed redundant namespace identifiers.
[Verify]    1. Browser builds
            2. Refactor does not change behaviour of browser.

Change-Id: If23e9979914cb44af91b881b25e5caffbba4c246

8 years agoAdded "no visited site" view for Most visted tab. 57/46257/4
Maciej Skrzypkowski [Wed, 19 Aug 2015 13:49:06 +0000 (15:49 +0200)]
Added "no visited site" view for Most visted tab.

[Issue#] https://bugs.tizen.org/jira/browse/TT-73
[Problem] For no history there was no message.
[Cause] N/A
[Solution] Added label "No visited site" when there is no history
[Verify] Run fresh browser instance, there should be  "No visited site"
               message in Most visited tab.

Change-Id: I171f6d5d74dbc175102a08afac37b22ff3bb6e50
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
8 years agoRemoving ewk_context_default_get call 31/46231/2 accepted/tizen/tv/20150819.235910 submit/tizen_tv/20150819.233112
Janusz Majnert [Tue, 18 Aug 2015 07:40:57 +0000 (09:40 +0200)]
Removing ewk_context_default_get call

[Issue#] N/A
[Problem] Call to internal EWK API
[Cause] Code restored during branch merge
[Solution] Remove the call, it is not needed
[Verify] Build and run the browser, load a few tabs, close tabs

The call to ewk_context_default get was restored by mistake when performing a
merge between branches. The version in tizen branch had the code replaced with
another method to implicitly initialize EWK internal contexts.

Change-Id: If21dcc4ca40242786c22e80b7a5591a70c56ecfb

8 years agoFixed navigating to links from history 49/46249/3
Albert Malewski [Tue, 18 Aug 2015 11:02:37 +0000 (13:02 +0200)]
Fixed navigating to links from history

[Issue#]   https://bugs.tizen.org/jira/browse/TT-93
[Problem]  Browser cannot navigate to links from history.
[Cause]    There is no implemented callback on click event in history.
[Solution] Implemented callback _history_item_clicked_cb and switching the view.
[Verify]   Launch Browser > More menu > History > Click on some link > Obs
           Browser should load clicked webpage.

Change-Id: Iaac04dd59776b302fa199dd6d631aafa03eca139

8 years agoAdd removing http prefix from URL, add preventing from loading view two times. 29/46229/4
Maciej Skrzypkowski [Wed, 19 Aug 2015 09:13:52 +0000 (11:13 +0200)]
Add removing http prefix from URL, add preventing from loading view two times.

[Issue#] https://bugs.tizen.org/jira/browse/TT-73
[Problem] Full URL was shown, second click on button caused
          hiding view.
[Cause] N/A
[Solution] Parsing URL, preventing second view show.
[Verify] Check URL on "Most visited" tiles, check if second click on
         "Most visited" or "Bookmark" button causes hiding view.

Change-Id: I0b043c75e2779ae277620cc16d14c221da64df22
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
8 years agoChange view of Most Visited tiles. 30/46230/3
Maciej Skrzypkowski [Mon, 17 Aug 2015 14:02:17 +0000 (16:02 +0200)]
Change view of Most Visited tiles.

[Issue#] https://bugs.tizen.org/jira/browse/TT-73
[Problem] Font sizes, colors, highlight were wrong.
[Cause] N/A
[Solution] Changed to proper ones.
[Verify] Check tiles title and URL font and it's location acording to
               guideline. Check backgrounds. Check highliting tiles.

Change-Id: I8ab0b869a72f6baedaf3832e58edb88c40135940
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
8 years agoSet callback for bookmark gengrid item instead of items thumbnail. 50/46250/3 accepted/tizen/tv/20150819.022934 submit/tizen_tv/20150818.234904
Marcin Lapinski [Tue, 18 Aug 2015 09:46:41 +0000 (11:46 +0200)]
Set callback for bookmark gengrid item instead of items thumbnail.

[Issue#]    https://bugs.tizen.org/jira/browse/TT-135
[Problem]   Clicking on bookmark folder text doesn't work.
[Cause]     Callback was set on thumbnail instead of on whole item.
[Sollution] Move callback to bookmark gengrid item click.
[Verify]    1. Run browser
            2. Create some bookmark folders
            3. Open More Menu -> Bookmark manager
            4. Click on some bookmark folder description
            5. Bookmark folder shold be opened.

Additional changes:
  - Changed some function names to make code more self-explaining.
  - Removed redundant focus managment callbacks causing problems
    in the current approach.

Change-Id: Ibddc457a7cfdc19f7b68ce4163f4b2ae04d793db

8 years agoAdded action on "Exit browser" button 46/46246/1
Albert Malewski [Mon, 17 Aug 2015 12:22:02 +0000 (14:22 +0200)]
Added action on "Exit browser" button

[Issue#]   https://bugs.tizen.org/jira/browse/TT-131
[Problem]  "Exit browser" in More Menu is not working.
[Cause]    There was no action connected to "exit browser" button.
[Solution] Added function _exitClicked that calls elm_exit().
[Verify]   Browser -> MoreMenu -> Exit browser -> Obs
           Browser should be closed.

Change-Id: I14473625d1b8ba9d60e9049005193b63e3a66208

8 years agoMerge branch 'new_ui' into tizen 84/46184/1
Janusz Majnert [Mon, 17 Aug 2015 13:58:22 +0000 (15:58 +0200)]
Merge branch 'new_ui' into tizen

Conflicts:
services/BookmarkService/BookmarkService.cpp
services/SimpleUI/SimpleUI.cpp
services/WebKitEngineService/WebView.cpp

Change-Id: If7f333aa9127d034e9a4f0ade2d303688572ee2e

8 years agoRemove unneeded genlist from top buttons. 59/45959/7 new_ui
Maciej Skrzypkowski [Mon, 17 Aug 2015 13:03:27 +0000 (15:03 +0200)]
Remove unneeded genlist from top buttons.

[Issue#] https://bugs.tizen.org/jira/browse/TT-73
[Problem] Uneeded genlist caused scrolling of top buttons.
[Cause] N/A
[Solution] Removed genlist.
[Verify] Check if buttons "Most visited" and "Bookmarks" work.

Change-Id: I044d8502be38d55fe7ce9b44c1674f3cf155922c
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
8 years agoBug TT-94 Fixed bookmarks folder creation bug 65/46065/5
t.dakowicz [Thu, 13 Aug 2015 13:05:35 +0000 (15:05 +0200)]
Bug TT-94 Fixed bookmarks folder creation bug

[Issue#] https://bugs.tizen.org/jira/browse/TT-94
[Problem] User couldn't create new folder for bookmarks.
[Cause] Wrong initialization of variable
[Solution] The variable initialized with zeros
[Verify] MoreMenu -> Add bookmark -> '+' -> type new folder's
         name. Check if the folder is visible in Bookmark
         Manager.

Change-Id: I630787ae4251cbe6ab4ad53ce23b756996173e3d

8 years agoDisabled START_MINIBROWSER and READ_MODE features 72/46172/1
Marcin Lapinski [Mon, 17 Aug 2015 12:28:24 +0000 (14:28 +0200)]
Disabled START_MINIBROWSER and READ_MODE features

[Issue#]   https://bugs.tizen.org/jira/browse/TT-129
[Problem]  N/A
[Cause]    N/A
[Solution] N/A
[Verify]   1. Change builds.
           2. Feature buttons in More Menu should be not visible.

Change-Id: I9aec51faabafb9503a31e30955cd92d0ed31b10b

8 years agoFixed tabs addition 34/45934/6
Albert Malewski [Wed, 12 Aug 2015 10:32:04 +0000 (12:32 +0200)]
Fixed tabs addition

[Issue#]   https://bugs.tizen.org/jira/browse/TT-92
[Problem]  Multiple tabs are added when navigating a page
           from Most Visited or Bookmarks.
[Cause]    Slots were added to signals every time the ShowMainUI
           function was called.
[Solution] Changed time of adding slots. Now they are added in function exec
           only once (if m_initialised is false).
[Verify]   Launch Browser > Create new tabs > Obs
           Number of open tabs should be correct.

Change-Id: I0401061a1cc75984c739a582be6bb83465849556

8 years agoRefactor of HistoryUI::showActionBar function. 39/46039/2
Marcin Lapinski [Thu, 13 Aug 2015 09:58:37 +0000 (11:58 +0200)]
Refactor of HistoryUI::showActionBar function.

[Issue#]   https://bugs.tizen.org/jira/browse/TT-72
[Problem]  HistoryUI::showActionBar is too complicated. Uses unnecessary
           genlist, with only one item to create action bar. This makes
           code long and unclear as it is not the proper use of genlist.
[Cause]    N/A
[Solution] Use layout instead the genlist to make the code shorter and
           more self-explaining.
[Verify]   1. Browser builds.
           2. Run the browser and check history ui to see if the change
              is not introducing any new issues.

Change-Id: I9b1ad458d7497af9d85741978e844ebb4f918079

8 years agoAdded action on clear history button clicked. 56/45956/4
Marcin Lapinski [Wed, 12 Aug 2015 13:31:53 +0000 (15:31 +0200)]
Added action on clear history button clicked.

[Issue#]   https://bugs.tizen.org/jira/browse/TT-99
[Problem]  'Clear History' button does not work.
[Cause]    Buttons callback was empty.
[Solution] Trigger history clear on button click.
[Verify]   1. (History is not empty)
           2. Open More menu -> history.
           3. Click 'Clear History' button.
           4. History should be deleted.

Change-Id: I7d9b5d40451398d21ef88359f37660261ce1e6e6

8 years agoImprove sizes of tiles, remove unneeded medium style, 40/45940/2
Maciej Skrzypkowski [Wed, 12 Aug 2015 12:03:09 +0000 (14:03 +0200)]
Improve sizes of tiles, remove unneeded medium style,
small refactoring of white spaces.

[Issue#] https://bugs.tizen.org/jira/browse/TT-73
[Problem] Sizes of most visited tiles were wrong.
[Cause] N/A
[Solution] Fixed style for small tiles, removed style for medium
                    tiles.
[Verify] Check if Most visited view has proper tiles sizes.

Change-Id: I4d884e3d099056e553c99b492469b8abb03d8b16
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
8 years agoRefactored HistoryUI service 86/45786/2
Janusz Majnert [Tue, 11 Aug 2015 08:44:06 +0000 (10:44 +0200)]
Refactored HistoryUI service

[Issue#]   https://bugs.tizen.org/jira/browse/TT-72
[Problem]  Lots of style fixes, several fixes for build warnings
[Cause]    n/a
[Solution] Reformat code, fix casting and remove unused variables
[Verify]   1. Check that there are no build problems caused by this change
           2. Run the browser and explore the history ui to see if nothing got broken

List of changes:
* tabs -> spaces
* proper indentation
* other minor style fixes
* removing unused variables' declarations
* renaming a few class members to better express their use
* replacing reinterpret_cast with static_cast where appropriate
* adding null-checks in callback functions
* replacing deprecated Elementary API call with its successor

Change-Id: Id2c4c020573138d641a8e6a676942830a6505ab5

8 years agoBug TT-96 Fixed 'Bookmark Manager' button in the More Menu 15/45815/7
t.dakowicz [Tue, 11 Aug 2015 12:46:23 +0000 (14:46 +0200)]
Bug TT-96 Fixed 'Bookmark Manager' button in the More Menu

[Issue#] https://bugs.tizen.org/jira/browse/TT-96
[Problem] Bookmark Manager couldn't be accessed from
          More Menu
[Cause] Proper signal wasn't created
[Solution] Added signal to MoreMenu class
[Verify] Check if Bookmark Manager button does anything

Change-Id: Idad6aaa774ad30fb9ff9b0207d4ef2a2004bf751

8 years agoRefactored SettingsUI service 20/45720/3
Janusz Majnert [Mon, 10 Aug 2015 14:41:33 +0000 (16:41 +0200)]
Refactored SettingsUI service

[Issue#]   https://bugs.tizen.org/jira/browse/TT-72
[Problem]  Lots of style fixes, several fixes for build warnings
[Cause]    n/a
[Solution] Reformat code, fix casting and remove unused variables
[Verify]   1. Check that there are no build problems caused by this change
           2. Run the browser and explore the settings to see if nothing's broken

List of changes:
* tabs -> spaces
* proper indentation
* other minor style fixes
* removing unused variables' declarations
* renaming a few class members to better express their use
* replacing reinterpret_cast with static_cast where appropriate
* adding null-checks in callback functions
* replacing deprecated Elementary API call with its successor

Change-Id: Ic9e00dd20b93f9392af61bede11868df18448478

8 years agoRefactored TabUI service 90/45690/2
Janusz Majnert [Fri, 7 Aug 2015 17:01:24 +0000 (19:01 +0200)]
Refactored TabUI service

[Issue#]   https://bugs.tizen.org/jira/browse/TT-72
[Problem]  Lots of style fixes, several fixes for build warnings
[Cause]    n/a
[Solution] Reformat code, fix casting and remove unused variables
[Verify]   1. Check that there are no build problems caused by this change
           2. Run the browser and explore the tab functionality to see if nothing's broken

List of changes:
* tabs -> spaces
* proper indentation
* other minor style fixes
* removing unused variables' declarations
* renaming a few class members to better express their use
* replacing reinterpret_cast with static_cast where appropriate
* adding null-checks in callback functions

Change-Id: Ib2a5731683c99aa5b89acf9f00417a41d207c579