mm: remove gup_flags FOLL_WRITE games from __get_user_pages() 30/94330/1 accepted/tizen/3.0/mobile/20161102.075051 accepted/tizen/mobile/20161101.005054 submit/tizen/20161031.063338 submit/tizen_3.0/20161102.035825
authorLinus Torvalds <torvalds@linux-foundation.org>
Thu, 13 Oct 2016 20:07:36 +0000 (13:07 -0700)
committerSeung-Woo Kim <sw0312.kim@samsung.com>
Fri, 28 Oct 2016 08:25:28 +0000 (17:25 +0900)
commit97d5e3408d65a161c2cd6621de4452f3fe3ad41e
treef9174d9968a03936184044d8806ae7e744b6bd31
parent14f5d375928283aeac056481b207b64c6ffa23a6
mm: remove gup_flags FOLL_WRITE games from __get_user_pages()

commit 19be0eaffa3ac7d8eb6784ad9bdbc7d67ed8e619 upstream.

This is an ancient bug that was actually attempted to be fixed once
(badly) by me eleven years ago in commit 4ceb5db9757a ("Fix
get_user_pages() race for write access") but that was then undone due to
problems on s390 by commit f33ea7f404e5 ("fix get_user_pages bug").

In the meantime, the s390 situation has long been fixed, and we can now
fix it by checking the pte_dirty() bit properly (and do it better).  The
s390 dirty bit was implemented in abf09bed3cce ("s390/mm: implement
software dirty bits") which made it into v3.9.  Earlier kernels will
have to look at the page state itself.

Also, the VM has become more scalable, and what used a purely
theoretical race back then has become easier to trigger.

To fix it, we introduce a new internal FOLL_COW flag to mark the "yes,
we already did a COW" rather than play racy games with FOLL_WRITE that
is very fundamental, and then use the pte dirty flag to validate that
the FOLL_COW flag is still valid.

Reported-and-tested-by: Phil "not Paul" Oester <kernel@linuxace.com>
Acked-by: Hugh Dickins <hughd@google.com>
Reviewed-by: Michal Hocko <mhocko@suse.com>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Kees Cook <keescook@chromium.org>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Willy Tarreau <w@1wt.eu>
Cc: Nick Piggin <npiggin@gmail.com>
Cc: Greg Thelen <gthelen@google.com>
Cc: stable@vger.kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
[wt: s/gup.c/memory.c; s/follow_page_pte/follow_page_mask;
     s/faultin_page/__get_user_page]
Signed-off-by: Willy Tarreau <w@1wt.eu>
[Apply from linux-3.10.104 to fix CVE-2016-5195]
Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
Change-Id: I5a99df42c34af2b109a8f9e1647b606324e981e7
include/linux/mm.h
mm/memory.c