From 18f26fb5be7dcf0de11098e70bb3c0fe40139b75 Mon Sep 17 00:00:00 2001 From: Chris Adams Date: Mon, 20 Aug 2012 12:37:42 +1000 Subject: [PATCH] Fix signal offset in dynamic sig param lookup Related to 4317c442fd492121e2fc037a39b40653bbc34294 Change-Id: I6aa505b9dc13813d4996c0b5761e9c3e5eea0292 Reviewed-by: Michael Brasser --- src/qml/qml/qqmlcompiler.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/qml/qml/qqmlcompiler.cpp b/src/qml/qml/qqmlcompiler.cpp index 3805e98..ec1d19d 100644 --- a/src/qml/qml/qqmlcompiler.cpp +++ b/src/qml/qml/qqmlcompiler.cpp @@ -2942,9 +2942,8 @@ bool QQmlCompiler::buildDynamicMeta(QQmlScript::Object *obj, DynamicMetaMode mod while ((parentCache = parentCache->parent())) { if (int pSigCount = parentCache->signalCount()) { int pSigOffset = parentCache->signalOffset(); - for (int i = 0; i < pSigCount; ++i) { - QQmlPropertyData *currPSig = parentCache->signal(pSigOffset+i); - if (!currPSig) continue; + for (int i = pSigOffset; i < pSigCount; ++i) { + QQmlPropertyData *currPSig = parentCache->signal(i); // XXX TODO: find a better way to get signal name from the property data :-/ for (QQmlPropertyCache::StringCache::ConstIterator iter = parentCache->stringCache.begin(); iter != parentCache->stringCache.end(); ++iter) { -- 2.7.4