xcb_request_check: Sync even if an event was read for this sequence.
authorJamey Sharp <jamey@minilop.net>
Tue, 24 Aug 2010 16:17:38 +0000 (09:17 -0700)
committerJamey Sharp <jamey@minilop.net>
Tue, 24 Aug 2010 16:29:59 +0000 (09:29 -0700)
commit2040f10a4efa95092bc9409c5b20347989b5f0a2
treeb7bbc2218046c3c2c7af07f1e782c5a61cb83538
parent35f901a0f2bc3f5bb30dc6ff9d791679c9e84c05
xcb_request_check: Sync even if an event was read for this sequence.

This fixes the test case I have so far for Havoc's report that
xcb_request_check hangs.

Rationale: Since we have a void cookie, request_expected can't have been
set equal to this sequence number when the request was sent; it can only
have become equal due to the arrival of an event or error. If it became
equal due to an event then we still need to sync. If it became equal due
to an error, then request_completed will have been updated, which means
we correctly won't sync.

Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=29599

However, Havoc reports that he can still reproduce the problem, so we
may be revisiting this later.

Reported-by: Havoc Pennington <hp@pobox.com>
Signed-off-by: Jamey Sharp <jamey@minilop.net>
src/xcb_in.c