platform/upstream/pulseaudio.git
3 years agoRemove unnecessary pa-info script from packaging 40/244940/2 accepted/tizen/6.0/unified/20201030.112521 accepted/tizen/6.0/unified/20201117.214928 accepted/tizen/6.0/unified/hotfix/20201102.232430 accepted/tizen/unified/20200928.213346 submit/tizen/20200928.072700 submit/tizen_6.0/20201029.205503 submit/tizen_6.0/20201116.045601 submit/tizen_6.0_hotfix/20201102.192903 submit/tizen_6.0_hotfix/20201103.115103 tizen_6.0.m2_release
Seungbae Shin [Mon, 28 Sep 2020 07:05:25 +0000 (16:05 +0900)]
Remove unnecessary pa-info script from packaging

[Version] 13.0-21
[Issue Type] Packaging

Change-Id: Icc59bf09de7569a30c3b4897dd8de6f59b1037f3

3 years agofixup! Fix build warnings 24/244124/1 accepted/tizen/unified/20200918.123649 submit/tizen/20200915.083021 submit/tizen/20200916.050225 submit/tizen/20200916.182711 submit/tizen/20200918.024414
Seungbae Shin [Tue, 15 Sep 2020 07:25:22 +0000 (16:25 +0900)]
fixup! Fix build warnings

[Version] 13.0-20
[Issue Type] Build

Change-Id: Id4440e520e8d5a00c2a5e8d8fa621a62aa05d3b2

3 years agostream-restore,device-restore: Avoid unaligned access 12/243512/1 accepted/tizen/unified/20200908.130450 submit/tizen/20200908.035839 submit/tizen/20200908.061751
Arun Raghavan [Thu, 23 Jul 2020 23:42:47 +0000 (19:42 -0400)]
stream-restore,device-restore: Avoid unaligned access

Newer GCC warns us that the channel_map and volume in legacy entries are
accessed via pointers, and these might be unaligned as the legacy entry
is a packed structure. For this reason, we read out those values into
local variables before accessing them as pointers.

The warnings are:

[146/433] Compiling C object src/modules/module-device-restore.so.p/module-device-restore.c.o
../src/modules/module-device-restore.c: In function â€˜legacy_entry_read’:
../src/modules/module-device-restore.c:554:51: warning: taking address of packed member of â€˜struct legacy_entry’ may result in an unaligned pointer value [-Waddress-of-packed-member]
  554 |     if (le->volume_valid && !pa_channel_map_valid(&le->channel_map)) {
      |                                                   ^~~~~~~~~~~~~~~~
../src/modules/module-device-restore.c:559:48: warning: taking address of packed member of â€˜struct legacy_entry’ may result in an unaligned pointer value [-Waddress-of-packed-member]
  559 |     if (le->volume_valid && (!pa_cvolume_valid(&le->volume) || !pa_cvolume_compatible_with_channel_map(&le->volume, &le->channel_map))) {
      |                                                ^~~~~~~~~~~
../src/modules/module-device-restore.c:559:104: warning: taking address of packed member of â€˜struct legacy_entry’ may result in an unaligned pointer value [-Waddress-of-packed-member]
  559 |     if (le->volume_valid && (!pa_cvolume_valid(&le->volume) || !pa_cvolume_compatible_with_channel_map(&le->volume, &le->channel_map))) {
      |                                                                                                        ^~~~~~~~~~~
../src/modules/module-device-restore.c:559:117: warning: taking address of packed member of â€˜struct legacy_entry’ may result in an unaligned pointer value [-Waddress-of-packed-member]
  559 |     if (le->volume_valid && (!pa_cvolume_valid(&le->volume) || !pa_cvolume_compatible_with_channel_map(&le->volume, &le->channel_map))) {
      |                                                                                                                     ^~~~~~~~~~~~~~~~
[211/433] Compiling C object src/modules/module-stream-restore.so.p/module-stream-restore.c.o
../src/modules/module-stream-restore.c: In function â€˜legacy_entry_read’:
../src/modules/module-stream-restore.c:1076:51: warning: taking address of packed member of â€˜struct legacy_entry’ may result in an unaligned pointer value [-Waddress-of-packed-member]
 1076 |     if (le->volume_valid && !pa_channel_map_valid(&le->channel_map)) {
      |                                                   ^~~~~~~~~~~~~~~~
../src/modules/module-stream-restore.c:1081:48: warning: taking address of packed member of â€˜struct legacy_entry’ may result in an unaligned pointer value [-Waddress-of-packed-member]
 1081 |     if (le->volume_valid && (!pa_cvolume_valid(&le->volume) || !pa_cvolume_compatible_with_channel_map(&le->volume, &le->channel_map))) {
      |                                                ^~~~~~~~~~~
../src/modules/module-stream-restore.c:1081:104: warning: taking address of packed member of â€˜struct legacy_entry’ may result in an unaligned pointer value [-Waddress-of-packed-member]
 1081 |     if (le->volume_valid && (!pa_cvolume_valid(&le->volume) || !pa_cvolume_compatible_with_channel_map(&le->volume, &le->channel_map))) {
      |                                                                                                        ^~~~~~~~~~~
../src/modules/module-stream-restore.c:1081:117: warning: taking address of packed member of â€˜struct legacy_entry’ may result in an unaligned pointer value [-Waddress-of-packed-member]
 1081 |     if (le->volume_valid && (!pa_cvolume_valid(&le->volume) || !pa_cvolume_compatible_with_channel_map(&le->volume, &le->channel_map))) {
      |

[jcsing.lee: cherry-pick from mainstream commit merge_requests/333]
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Change-Id: I37a2ac9e0a352457a1fd882862f9186715d1a253

3 years agoglib-mainloop: Drop deprecated g_get_current_time() usage 11/243511/1
Arun Raghavan [Thu, 23 Jul 2020 23:36:11 +0000 (19:36 -0400)]
glib-mainloop: Drop deprecated g_get_current_time() usage

This uses the year 2038-safe g_get_real_time() as recommended instead.
Bumps GLib dependency to 2.28 as a result.

[jcsing.lee: cherry-pick from mainstream commit merge_requests/333]
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Change-Id: I94d46f248783c5edc617f9ff157bbf23dd2391f8

3 years agoproplist-util: Drop deprecated G_CONST_RETURN macro 10/243510/1
Arun Raghavan [Thu, 23 Jul 2020 23:36:06 +0000 (19:36 -0400)]
proplist-util: Drop deprecated G_CONST_RETURN macro

The preference in glib is now to just use the const qualifier directly.

[jcsing.lee: cherry-pick from mainstream commit merge_requests/333]
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Change-Id: I255533b36d818a20f193b80864c338ece0e24dd0

3 years agoFix build warnings 75/242975/1 accepted/tizen/unified/20200904.035452 submit/tizen/20200902.103308 submit/tizen/20200903.061740
Seungbae Shin [Wed, 2 Sep 2020 07:12:11 +0000 (16:12 +0900)]
Fix build warnings

[Version] 13.0-19
[Issue Type] Build

Change-Id: I35eeecabad0dbb2b3eaf52bcd0fe394055edf96f

3 years agobluetooth: Apply upstream 13.0 69/238069/8 accepted/tizen/unified/20200902.145553 submit/tizen/20200901.072933
Wootak Jung [Wed, 8 Jul 2020 05:23:33 +0000 (14:23 +0900)]
bluetooth: Apply upstream 13.0

Change-Id: I285cfd8ba851cfdb729ba1a9bcd9377fbdd2247b
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
3 years agobluez5-discover: Fix Coverity defect of Resource leak(RESOURCE_LEAK) 24/242524/2 accepted/tizen/unified/20200828.121432 submit/tizen/20200828.005944
Seungbae Shin [Thu, 27 Aug 2020 11:08:15 +0000 (20:08 +0900)]
bluez5-discover: Fix Coverity defect of Resource leak(RESOURCE_LEAK)

[Version] 13.0-18
[Issue Type] Vulnerability

Change-Id: I1c4890be02b3443e11a33298ca61bcb4ac1182ba

3 years agoApply deny policy on remote-audio methods for default context in dbus conf 03/242303/1 accepted/tizen/unified/20200826.133030 submit/tizen/20200825.121242
Seungbae Shin [Tue, 25 Aug 2020 12:06:32 +0000 (21:06 +0900)]
Apply deny policy on remote-audio methods for default context in dbus conf

[Version] 13.0-17
[Issue Type] Update

Change-Id: I9404c1aba633fd252869bbcdeb3993bac622b659

3 years agostream: skip cynara checks for remote connection 98/241298/6 accepted/tizen/unified/20200824.134510 submit/tizen/20200821.074009 submit/tizen/20200824.023231
Seungbae Shin [Wed, 19 Aug 2020 05:28:18 +0000 (14:28 +0900)]
stream: skip cynara checks for remote connection

[Version] 13.0-16
[Issue Type] Update

Change-Id: I20caf16d5745bcb0e51c8e9b1ae4353c9a71f653

3 years agotunnel-sink(source)-new: modification for remote-audio 87/241187/10
Seungbae Shin [Tue, 18 Aug 2020 09:56:15 +0000 (18:56 +0900)]
tunnel-sink(source)-new: modification for remote-audio

- receive stream event to update access permission of the sink(source)
- set remote name from target device name vconf
- set default remote access permission as denied
- set device api property with 'tunnel'

[Version] 13.0-15
[Issue Type] Update

Change-Id: Iae64a8805b6befa088b0c5ffce678894114a8bba

3 years agopulsecore: add remote utility functions with proplist definitions 55/241155/9
Seungbae Shin [Tue, 18 Aug 2020 07:09:39 +0000 (16:09 +0900)]
pulsecore: add remote utility functions with proplist definitions

- pa_proplist_has_remote_name
- pa_proplist_set_remote_access_permission
- pa_proplist_remote_is_allowed
- pa_sink_update_proplist_remote_access_permission
- pa_source_update_proplist_remote_access_permission

[Version] 13.0-14
[Issue Type] Add

Change-Id: I61615c128f91b2eaeda77bce44fab67dfed3e1c0

3 years agobluez5-device: Update the port latency offset according to the delay change 46/240946/1
Sangchul Lee [Thu, 13 Aug 2020 04:06:32 +0000 (13:06 +0900)]
bluez5-device: Update the port latency offset according to the delay change

This patch applies the delay to the sink of the device. It will affect
the current latency of the sink.

[Version] 13.0-13
[Issue Type] New feature

Change-Id: I33dcc030876236d66bd074a5789f79febe0626ea
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
3 years agobluez5-util: Add pa_bluetooth_transport_set_delay() and related HOOK 45/240945/1
Sangchul Lee [Wed, 12 Aug 2020 10:56:32 +0000 (19:56 +0900)]
bluez5-util: Add pa_bluetooth_transport_set_delay() and related HOOK

This delay originates from the AVDTP 1.3 Delay Reporting feature.

This function sets the delay(us) to the bluetooth transport and notifies
the change via PA_BLUETOOTH_HOOK_TRANSPORT_DELAY_CHANGED hook.

[Version] 13.0-12
[Issue Type] New feature

Change-Id: I7d639e5f52d4b65c9a012d5716a4d544757d00e6
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
3 years agoplay-memblockq: Adds debug log when pop_cb_fails to peek data. 64/240064/3 accepted/tizen/unified/20200807.141039 submit/tizen/20200803.040500 submit/tizen/20200804.005539 submit/tizen/20200804.013519 submit/tizen/20200805.011938 submit/tizen/20200807.045236 submit/tizen/20200810.052120
Jaechul Lee [Mon, 3 Aug 2020 03:11:13 +0000 (12:11 +0900)]
play-memblockq: Adds debug log when pop_cb_fails to peek data.

pulseaudio crashed when sink-input(feedback sound) moved to the combine
sink in multiview scenario.

[Version] 13.0-11
[Issue Type] TV issue

Change-Id: I38df7d6de7d931e5da829c42b62f078ed0ca9b77
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
3 years agothread-posix: retry thread joining if failed 32/239732/4 accepted/tizen/unified/20200731.145707 submit/tizen/20200730.100637 submit/tizen/20200731.014101 submit/tizen/20200731.074405
Seungbae Shin [Wed, 29 Jul 2020 08:57:19 +0000 (17:57 +0900)]
thread-posix: retry thread joining if failed

print some logs related to threaded-mainloop

[Version] 13.0-10
[Issue Type] Debugging

Change-Id: Iaf415b422b8857ad5b84ee398da6d1535e468232

3 years agomodule-loopback: rollback calculation of requested buffer latency due to bluetooth... 17/239417/1 accepted/tizen/unified/20200730.130855 submit/tizen/20200729.164602 submit/tizen/20200730.033624
Seungbae Shin [Fri, 24 Jul 2020 10:41:49 +0000 (19:41 +0900)]
module-loopback: rollback calculation of requested buffer latency due to bluetooth sync issue

[Version] 13.0-9
[Issue Type] audio sync

Change-Id: Ic4e7c4cba0fa31f41c33c1c3fc4870de28665f8e

3 years agobluez5-util: Add DelayReporting flag on endpoint registration 12/237412/5 accepted/tizen/unified/20200706.133948 submit/tizen/20200703.064624
Wootak Jung [Tue, 30 Jun 2020 06:22:47 +0000 (15:22 +0900)]
bluez5-util: Add DelayReporting flag on endpoint registration

Change-Id: I1234032fd03a70913bdc5d81a9a9a770580fcc8f
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
3 years agosound-file-stream: Fix pulseaudio crash when invalid samples are pushed 21/234121/5 accepted/tizen/unified/20200601.051750 submit/tizen/20200529.085112
Jaechul Lee [Fri, 22 May 2020 04:39:10 +0000 (13:39 +0900)]
sound-file-stream: Fix pulseaudio crash when invalid samples are pushed

memblockq only allows to push aligned data but a invalid file that has
not aligned samples was played though wav-player.

pulseaudio was crashed in pa_memblockq_push function.
pa_assert(uchunk->length % bq->base == 0);

[Version] 13.0-8
[Issue Type] Bugs (TFDF-10411)

Change-Id: I9f117bb3402ef94b46e4b77e7d188f1722f23114
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
3 years agoalsa-sink: Adds handling EAGAIN in try_recover 91/233491/7 submit/tizen/20200520.011942
Jaechul Lee [Fri, 15 May 2020 04:46:10 +0000 (13:46 +0900)]
alsa-sink: Adds handling EAGAIN in try_recover

snd_pcm_avail returns a negative value sometimes. It depends on H/W. So,
trying to recover function was added and print out the state of the
buffer.

[Version] 13.0.7
[Issue Type] TSIX-3385

Change-Id: Ia5f97261d6216e2a64e40d0432e03c5c816ba022
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
4 years agoMerge "Allow tone-player interface" into tizen submit/tizen/20200512.012802
jaechul lee [Mon, 11 May 2020 04:51:40 +0000 (04:51 +0000)]
Merge "Allow tone-player interface" into tizen

4 years agoMerge "pactl: Adds set-pcm-dump command" into tizen
jaechul lee [Mon, 11 May 2020 04:20:46 +0000 (04:20 +0000)]
Merge "pactl: Adds set-pcm-dump command" into tizen

4 years agoAllow tone-player interface 38/231438/5
Jaechul Lee [Wed, 22 Apr 2020 03:46:16 +0000 (12:46 +0900)]
Allow tone-player interface

[Version] 13.0-6
[Issue Type] None

Change-Id: I6fbf3a2a78cf5ac3773c39fa5670d6ed49372a1b
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
4 years agoFix build warning 72/231972/2
Jaechul Lee [Mon, 27 Apr 2020 03:47:51 +0000 (12:47 +0900)]
Fix build warning

[Version] 13.0.4
[Issue Type] Bug

Change-Id: Ib64feeaf9debec9abec70a1358983d9d7946cf90
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
4 years agopactl: Adds set-pcm-dump command 56/231656/6
Jaechul Lee [Thu, 23 Apr 2020 08:08:00 +0000 (17:08 +0900)]
pactl: Adds set-pcm-dump command

This commit is from d2f6895a1. Unused functions such as
pcm_dump_option and defines regarding gstreamer have been removed.

[Version] 13.0-5
[Issue Type] None

Change-Id: I9d1be1ab5e38e4f7b21b6d99687bf66d8f50f896
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
4 years agoFix memory leak in context_free 13/231613/2 accepted/tizen/unified/20200424.141642 submit/tizen/20200423.051322
Daniil Kovalev [Sat, 2 Nov 2019 18:43:51 +0000 (21:43 +0300)]
Fix memory leak in context_free

In commit f727cd9a `int error` member in `struct pa_context` was changed
to `pa_context_error *error`. The memory that is allocated with
`pa_xnew0` in src/pulse/context.c:142 is never freed, and it causes
a leak of 4 bytes. The leak can be easily detected with leak-sanitizer.

[jcsing.lee: backport mainline commit 5fdde3fa8 for fixing memory leak]

Change-Id: I08bd62a2b390a7e9025186b6eb00c0c0dfc87bb2
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
4 years agoAllow signal to pulseaudio 17/230017/1 accepted/tizen/unified/20200408.131508 submit/tizen/20200408.002613
sanghyeok.oh [Tue, 7 Apr 2020 07:17:38 +0000 (16:17 +0900)]
Allow signal to pulseaudio

Signal from callmgrd to pulseaudio has denied.

Feb 17 13:38:47 localhost dbus[333]: [system] Rejected send message, 2 matched rules; type="signal", sender=":1.40" (uid=601 pid=549 comm="/usr/bin/callmgrd ") interface="org.tizen.AudioClient1" member="ClientSubscribed" error name="(unset)" requested_reply="0" destination="org.freedesktop.DBus" privilege="(n/a)" (uid=122 pid=453 comm="/usr/bin/pulseaudio ") rule(<deny send_destination="org.pulseaudio.Server" />)

Feb 17 13:39:46 localhost dbus[333]: [system] Rejected send message, 2 matched rules; type="signal", sender=":1.79" (uid=5001 pid=1360 comm="/usr/apps/org.tizen.multi-assistant-service/bin/or") interface="org.tizen.AudioClient1" member="ClientSubscribed" error name="(unset)" requested_reply="0" destination="org.freedesktop.DBus" privilege="(n/a)" (uid=122 pid=453 comm="/usr/bin/pulseaudio ") rule(<deny send_destination="org.pulseaudio.Server" />)

Change-Id: I0ea45a53f64212044ab772e09bc3a59456470708

4 years agopulsecore: Adds pa_play_file_repeat function 93/228893/5 submit/tizen/20200403.080755 submit/tizen/20200406.030837 submit/tizen/20200407.002130
Jaechul Lee [Thu, 26 Mar 2020 07:54:58 +0000 (16:54 +0900)]
pulsecore: Adds pa_play_file_repeat function

[Version] 13.0-4
[Issue Type] None

Change-Id: I704a7aa9e8fd871f47af3988b8c2997ed293692f
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
4 years agocard-restore: Fix memory leak 02/227002/1 accepted/tizen/unified/20200310.151127 submit/tizen/20200309.043014
Sangchul Lee [Mon, 9 Mar 2020 03:33:22 +0000 (12:33 +0900)]
card-restore: Fix memory leak

[Version] 13.0-3
[Issue Type] Coverity defect

Change-Id: If6a5f8a7acedc0b6be5acf9ce270f8757ab6529c
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
4 years agonull-sink: Fix memory leak in pa__init() 98/226998/1
Sangchul Lee [Mon, 9 Mar 2020 03:11:05 +0000 (12:11 +0900)]
null-sink: Fix memory leak in pa__init()

[Version] 13.0-2
[Issue Type] Coverity

Change-Id: I4e831abe1000b8428a1256bc72c81d7136e02726
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
4 years agoMerge branch 'upstream/13.0' into tizen 70/222570/8 accepted/tizen/unified/20200304.123924 submit/tizen/20200211.115824 submit/tizen/20200224.103343 submit/tizen/20200303.010146
Sangchul Lee [Fri, 7 Feb 2020 02:57:20 +0000 (11:57 +0900)]
Merge branch 'upstream/13.0' into tizen

[Version] 13.0-1
[Issue Type] Upgrade

Change-Id: I252236dc28ad2be6fa4cb7f44fd942aeb83f5396
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
4 years agomix: Update logic to set ramp finished flag 75/223475/1 accepted/tizen/unified/20200205.125309 submit/tizen/20200204.080130 submit/tizen/20200204.110420
Jeongmo Yang [Wed, 29 Jan 2020 01:58:46 +0000 (10:58 +0900)]
mix: Update logic to set ramp finished flag

- The ramp finished flag could not be set as TRUE although "left" is reached to 0.

[Version] 11.1-81
[Profile] Common
[Issue Type] Update

Change-Id: I8ac34723379b42e41d12b9f685395bb0c7af6bba
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
4 years agosink-input: fix to add ducking silence block with correct sample spec 58/216758/2 accepted/tizen/unified/20191107.140658 submit/tizen/20191107.041351
Seungbae Shin [Fri, 1 Nov 2019 01:44:40 +0000 (10:44 +0900)]
sink-input: fix to add ducking silence block with correct sample spec

[Version] 11.1-80
[Issue Type] Bug fix

Change-Id: I2dc445abdd121178d4890089b0a63520dba6f271

4 years agobuild-sys: Add missing files to release tarballs upstream/13.0 v13.0
Tanu Kaskinen [Fri, 13 Sep 2019 13:18:43 +0000 (16:18 +0300)]
build-sys: Add missing files to release tarballs

4 years agoupdate NEWS
Tanu Kaskinen [Fri, 13 Sep 2019 12:48:51 +0000 (15:48 +0300)]
update NEWS

4 years agoman: Add description of pactl special names.
Danny O'Brien [Mon, 2 Sep 2019 07:06:49 +0000 (00:06 -0700)]
man: Add description of pactl special names.

4 years agobuild-sys: Fix documentation of version info
Arun Raghavan [Mon, 2 Sep 2019 04:29:29 +0000 (09:59 +0530)]
build-sys: Fix documentation of version info

The comment has been incorrect for a while now. Thanks to Jan Steffens
for pointing this out.

4 years agol10n: Update lt.po
Moo [Sun, 1 Sep 2019 13:16:20 +0000 (13:16 +0000)]
l10n: Update lt.po

4 years agobuild-sys: Bump version info for libpulse v12.99.3
Arun Raghavan [Sun, 1 Sep 2019 07:35:10 +0000 (13:05 +0530)]
build-sys: Bump version info for libpulse

Minor implementation change since last release (we now load X11
properties only for SSH connections).

4 years agopo: Update Brazilian Portuguese translation
Rafael Fontenelle [Fri, 30 Aug 2019 13:12:24 +0000 (13:12 +0000)]
po: Update Brazilian Portuguese translation

4 years agodaemon: Drop KDE-specific loading of module-device-manager
Nicolas Fella [Fri, 30 Aug 2019 11:07:52 +0000 (11:07 +0000)]
daemon: Drop KDE-specific loading of module-device-manager

Newer versions of Plasma no longer use this module, and the consensus
seems to be that module-switch-on-connect works better for most cases.

Fixes: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/issues/509

4 years agoclient-conf: Avoid loading X11 properties unless SSH_CONNECTION is set
Carlos Garnacho [Sat, 22 Jun 2019 12:33:59 +0000 (14:33 +0200)]
client-conf: Avoid loading X11 properties unless SSH_CONNECTION is set

Reading properties from the X11 root window is meant to provide 1:1 results
with reading the configuration directly in the local case. This configuration
is essentially different only in remote cases.

Add an extra check for the SSH_CONNECTION envvar, so we don't even need
opening a X11 display connection for IPC in the most usual case.

4 years agogitlab: white space change to Bug.md
Russell Treleaven [Mon, 19 Aug 2019 10:54:06 +0000 (10:54 +0000)]
gitlab: white space change to Bug.md

Add a second whitespace at the end of the line to force a newline in the
output.

4 years agodbus: fix ActiveProfile setting
David Emett [Sat, 27 Jul 2019 21:24:42 +0000 (22:24 +0100)]
dbus: fix ActiveProfile setting

Just like with handle_set_active_port, we need to look up the profile
corresponding to the provided path rather than doing a name comparison.

Fixes: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/issues/709

4 years agobluetooth: Only perform write-related calculations when we have a sink
Pali Rohár [Tue, 27 Aug 2019 03:11:27 +0000 (08:41 +0530)]
bluetooth: Only perform write-related calculations when we have a sink

This avoids a potential divide-by-zero when we try to decide how much to
write to the sink in the source thread when there is no sink.

Fixes https://gitlab.freedesktop.org/pulseaudio/pulseaudio/issues/717

4 years agobuild-sys: meson: Process subdirectories before generating configuration
Arun Raghavan [Thu, 22 Aug 2019 13:23:13 +0000 (18:53 +0530)]
build-sys: meson: Process subdirectories before generating configuration

Subdirectories add to the top-level cdata (specifically, the SIMD
detection happens in the pulsecore meson.build), so we were missing
HAVE_MMX/SSE2/NEON defines without this fix.

4 years agobuild-sys: meson: Fixes for some ARM compiler checks
Arun Raghavan [Thu, 22 Aug 2019 12:28:20 +0000 (17:58 +0530)]
build-sys: meson: Fixes for some ARM compiler checks

4 years agopo: update Ukrainian translation
Yuri Chornoivan [Mon, 19 Aug 2019 08:35:06 +0000 (08:35 +0000)]
po: update Ukrainian translation

4 years agoUpdate Bug.md to encourage users to attach pa-info output to bug reports
Russell Treleaven [Sun, 18 Aug 2019 20:48:23 +0000 (20:48 +0000)]
Update Bug.md to encourage users to attach pa-info output to bug reports

4 years agobuild-sys: meson: Give ourselves a little more timeout headroom
Arun Raghavan [Sat, 17 Aug 2019 10:42:37 +0000 (16:12 +0530)]
build-sys: meson: Give ourselves a little more timeout headroom

We're seeing CI failures due to once-test sometimes taking long. Let's
give ourselves a little more space per test (2 min -> 5 min) to avoid
this.

4 years agoraop: Fix infinite loop in raop-sink with UDP mode
RODRIGUEZ Christophe [Sat, 17 Aug 2019 10:43:20 +0000 (10:43 +0000)]
raop: Fix infinite loop in raop-sink with UDP mode

There are potentially unresolved issues around the EAGAIN logic, but
this should prevent an infinite loop and log flood in the mean time.

Fixes: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/issues/695

4 years agobuild-sys: meson: Add a bunch of missing checks
Arun Raghavan [Thu, 15 Aug 2019 10:19:30 +0000 (15:49 +0530)]
build-sys: meson: Add a bunch of missing checks

4 years agobuild-sys: meson: Add mkfifo checks for module-pipe-*
Arun Raghavan [Thu, 15 Aug 2019 10:00:41 +0000 (15:30 +0530)]
build-sys: meson: Add mkfifo checks for module-pipe-*

4 years agobuild-sys: meson: Add some missing declaration checks
Arun Raghavan [Thu, 15 Aug 2019 10:00:26 +0000 (15:30 +0530)]
build-sys: meson: Add some missing declaration checks

4 years agobuild-sys: meson: Add a check for fast 64-bit operations
Arun Raghavan [Thu, 15 Aug 2019 10:00:00 +0000 (15:30 +0530)]
build-sys: meson: Add a check for fast 64-bit operations

4 years agobuild-sys: meson: Add ARMv6 instruction check
Arun Raghavan [Thu, 15 Aug 2019 07:38:14 +0000 (13:08 +0530)]
build-sys: meson: Add ARMv6 instruction check

4 years agobuild-sys: meson: Add atomic ops related checks
Arun Raghavan [Thu, 15 Aug 2019 07:37:54 +0000 (13:07 +0530)]
build-sys: meson: Add atomic ops related checks

4 years agomeson: add stdint.h to checked headers
Lucas Stach [Tue, 13 Aug 2019 15:27:37 +0000 (17:27 +0200)]
meson: add stdint.h to checked headers

Without this check we won't ever define HAVE_STDINT_H, which isn't used
in pulse directly, but is needed by e.g. the speex headers to work
correctly.

4 years agomeson: allow to build bluez support without libbluetooth
Lucas Stach [Tue, 13 Aug 2019 15:08:13 +0000 (17:08 +0200)]
meson: allow to build bluez support without libbluetooth

pulseaudio does not link against libbluetooth, as it's only talking to the
bluez daemon over dbus. So the build dependency on libbluetooth is overly
restrictive, as some embedded systems choose to ship without libbluetooth
but still have bluez daemon support.

This syncs the meson to the autotools configuration behavior by changing
the bluez option to a default on boolean.

4 years agomeson: fix build files list when building with NEON
Lucas Stach [Tue, 13 Aug 2019 14:01:01 +0000 (16:01 +0200)]
meson: fix build files list when building with NEON

Sync the meson NEON build files list with the autotools build
sources list. Fixes "ERROR: File svolume_neon.c does not exist."

4 years agobuild-sys: meson: Fix 2 cases of joining paths w/o join_paths
Jan Alexander Steffens (heftig) [Tue, 13 Aug 2019 19:47:23 +0000 (21:47 +0200)]
build-sys: meson: Fix 2 cases of joining paths w/o join_paths

Fixes https://gitlab.freedesktop.org/pulseaudio/pulseaudio/issues/712

4 years agobootstrap.sh: don't set sysconfdir and localstatedir configure options
Tanu Kaskinen [Tue, 13 Aug 2019 13:49:31 +0000 (16:49 +0300)]
bootstrap.sh: don't set sysconfdir and localstatedir configure options

I don't know why these options were being passed to configure
(--sysconfdir has been there from the very beginning, --localstatedir
got added when the system mode was added). Overwriting system files by
default is not good, so let's not set these options.

4 years agobuild-sys: meson: Add some missing checks
Jan Alexander Steffens (heftig) [Thu, 8 Aug 2019 18:23:12 +0000 (20:23 +0200)]
build-sys: meson: Add some missing checks

- Header and function checks from configure.ac
  (some libc, some libpthread, dladdr from libdl)
- Find iconv and check constness

4 years agoadd script to collect information for bug reports
Russell Treleaven [Thu, 8 Aug 2019 16:30:05 +0000 (12:30 -0400)]
add script to collect information for bug reports

4 years agol10n: Update Italian translation
Milo Casagrande [Wed, 7 Aug 2019 07:53:37 +0000 (09:53 +0200)]
l10n: Update Italian translation

  * Fixed typo.
  * Fixed use of double quotes.

Signed-off-by: Milo Casagrande <milo@milo.name>
4 years agobuild-sys: autotools: Add meson build files to EXTRA_DIST v12.99.2
Arun Raghavan [Tue, 6 Aug 2019 16:25:44 +0000 (21:55 +0530)]
build-sys: autotools: Add meson build files to EXTRA_DIST

As we currently still generate our tarballs using autotools, let's make
sure the meson build system is distributed with the tarball.

4 years agobuild-sys: Move svolume-*.c to libpulsecore
Arun Raghavan [Mon, 5 Aug 2019 08:49:27 +0000 (14:19 +0530)]
build-sys: Move svolume-*.c to libpulsecore

The various software volume implementations were being built as part of
libpulsecommon for some reason. These should only ever be used in the
daemon, so they should be in libpulsecore.

4 years agobuild-sys: meson: Fix minor typo in orc build
Arun Raghavan [Mon, 5 Aug 2019 08:39:44 +0000 (14:09 +0530)]
build-sys: meson: Fix minor typo in orc build

4 years agobuild-sys: meson: Add symbol versioning as in autotools
Arun Raghavan [Mon, 5 Aug 2019 05:09:49 +0000 (10:39 +0530)]
build-sys: meson: Add symbol versioning as in autotools

Adds the -version-script linker argument that we use with autotools to
version symbols in our public API.

4 years agobuild-sys: meson: Fix some defines for default.pa generation
Arun Raghavan [Mon, 5 Aug 2019 05:00:50 +0000 (10:30 +0530)]
build-sys: meson: Fix some defines for default.pa generation

Removes a warning from HAVE_GCONF not being set, and fixes generation of
a large section that depends on OS_IS_WIN32 being explicitly set to 0.

We can't set OS_IS_WIN32 to 0 by default since a bunch of code uses it
via an ifdef rather than by value.

4 years agobuild-sys: meson: Correctly set up RPATH
Arun Raghavan [Fri, 2 Aug 2019 21:11:55 +0000 (02:41 +0530)]
build-sys: meson: Correctly set up RPATH

This was being done automatically by autotools, now we need to manually
specify this for each executable/library with a dependency in a
non-standard directory.

4 years agobuild-sys: meson: Add -Wl,no-delete to relevant libraries
Arun Raghavan [Fri, 2 Aug 2019 20:22:09 +0000 (01:52 +0530)]
build-sys: meson: Add -Wl,no-delete to relevant libraries

This mirrors the autotools option for all server-side dynamic libraries.

4 years agostream-interaction: Fix crash when moving a ducked sink-input 96/211196/2 accepted/tizen_5.5_unified_mobile_hotfix tizen_5.5_mobile_hotfix accepted/tizen/5.5/unified/20191031.013918 accepted/tizen/5.5/unified/mobile/hotfix/20201027.072702 accepted/tizen/unified/20190808.113701 submit/tizen/20190807.082039 submit/tizen_5.5/20191031.000008 submit/tizen_5.5_mobile_hotfix/20201026.185108 tizen_5.5.m2_release
Sangchul Lee [Wed, 31 Jul 2019 02:48:32 +0000 (11:48 +0900)]
stream-interaction: Fix crash when moving a ducked sink-input

The operation of a ducked stream in sink_input_move_start_cb()
should differ from sink_input_unlink_cb().

[Version] 11.1-79
[Issue Type] Bug fix

Change-Id: I698f3ca232b7151aaae021572a559d54bc3209bf
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
4 years agorole-ducking, role-cork, stream-interaction: Fetch and apply upstream codes 84/211084/1
Sangchul Lee [Tue, 30 Jul 2019 01:22:28 +0000 (10:22 +0900)]
role-ducking, role-cork, stream-interaction: Fetch and apply upstream codes

 - stream-interaction: Support for triggering ducking/cork by source-output
  : https://gitlab.freedesktop.org/pulseaudio/pulseaudio/commit/0f4f109a3c1035ef3d8321ff836f83b3b6157326

 - stream-interaction: Use PA_IDXSET_FOREACH macro to iterate idxset
  : https://gitlab.freedesktop.org/pulseaudio/pulseaudio/commit/5540f728e52e9c369079e3ac83b8bc55e3519079

 - role-ducking, role-cork: Add use_source_trigger argument
  : https://gitlab.freedesktop.org/pulseaudio/pulseaudio/commit/65cc86f609525a89b740de6b366e35277763e32c

[Version] 11.1-78
[Issue Type] Upstream patch

Change-Id: I9b707e873a6fd1c50ee8fb47f82f09b8a092cd7f
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
4 years agoFixes to Catalan translation
Jordi Mas [Sun, 28 Jul 2019 10:17:39 +0000 (10:17 +0000)]
Fixes to Catalan translation

4 years agomeson: Fix installation of headers
Jan Alexander Steffens (heftig) [Wed, 10 Jul 2019 23:32:57 +0000 (01:32 +0200)]
meson: Fix installation of headers

To match Autotools:
 - internal.h should not be installed
 - Install simple.h and version.h

4 years agomeson: Fix library versioning to match Autotools
Jan Alexander Steffens (heftig) [Wed, 10 Jul 2019 23:25:38 +0000 (01:25 +0200)]
meson: Fix library versioning to match Autotools

For ease of maintaining both build systems, use the same version info
sequences as configure.ac. This should be simplified after Autotools has
been dropped.

4 years agomeson: Fix build of padsp
Jan Alexander Steffens (heftig) [Wed, 10 Jul 2019 22:52:50 +0000 (00:52 +0200)]
meson: Fix build of padsp

 - Rename "pulsedspdir" to the same "padsplibdir" that Autotools uses.

 - Add a new option "pulsedsp-location" that is only used for padsp.in,
   just like Autotools' --with-pulsedsp-location.

 - Use 'set' instead of 'set_quoted' to avoid PULSEDSP_LOCATION getting
   quoted twice.

4 years agobluetooth: Fix usage of RTP structures in SBC codec
Pali Rohár [Sun, 21 Jul 2019 15:07:02 +0000 (17:07 +0200)]
bluetooth: Fix usage of RTP structures in SBC codec

Rename struct rtp_payload to rtp_sbc_payload as it is specific for SBC
codec payload.

Add proper checks for endianity in rtp.h header and use uint8_t type
where appropriated.

Field frame_count is only 4 bit number, so add checks to prevent overflow.

And because is_fragmented field is not parsed by decoder there is no
support for decoding fragmented SBC frames. So throw an error in this case.

4 years agobluetooth: Change A2DP codec API of reset() method to indicate failure
Pali Rohár [Sun, 21 Jul 2019 15:07:01 +0000 (17:07 +0200)]
bluetooth: Change A2DP codec API of reset() method to indicate failure

SBC codec reset() method may fail, so propagate this failure to caller.

4 years agobluetooth: Fix usage of MTU, buffer sizes and return values of encode/decode methods
Pali Rohár [Sun, 21 Jul 2019 15:07:00 +0000 (17:07 +0200)]
bluetooth: Fix usage of MTU, buffer sizes and return values of encode/decode methods

Add explanation why minimal bitpool value is used in SBC codec as initial
bitpool value for A2DP source.

Set buffer size for reading/writing from/to A2DP socket to exact link MTU
value. This would ensure that A2DP codec does not produce larger packet as
maximal possible size which can be sent.

Because A2DP socket is of SOCK_SEQPACKET type, it is guaranteed that
we do not read two packets via one read/recvmsg call.

Properly check for all return values of encode/encode methods of A2DP codec
functions. They may fail at different levels. Also encode or decode API
method may return zero length buffer (e.g. because of algorithmic delay of
codec), so do not fail in this case.

4 years agoMigrate OpenSSL 1.0.2 to OpenSSL 1.1.1 12/207912/3 accepted/tizen/unified/20190729.081042 submit/tizen/20190726.065627
Seungbae Shin [Fri, 14 Jun 2019 03:36:52 +0000 (12:36 +0900)]
Migrate OpenSSL 1.0.2 to OpenSSL 1.1.1

https://bugs.tizen.org/browse/TC-2600

[Version] 11.1-77
[Issue type] Migration

Change-Id: I01479d0d92cb72e5a2441097d07b6f59cb024788

4 years agosource: Fix a bad condition that made source events not be emitted 68/210768/2 accepted/tizen/unified/20190725.042946 submit/tizen/20190724.120524
Arun Raghavan [Tue, 19 Feb 2019 03:57:02 +0000 (09:27 +0530)]
source: Fix a bad condition that made source events not be emitted

This broke during a refactor of sink/source state-change.

https://cgit.freedesktop.org/pulseaudio/pulseaudio/commit/?id=db788229c66369a7b1283173183662b7f5e6c742

[Version] 11.1-76
[Profile] Common
[Issue Type] Upstream patch

Change-Id: I670281dcb94aa7d2bcc24b05cd44b99fa7ffc376

4 years agoCommit fd9e3452 removed -ffast-math from the compile flags. Under some
Georg Chini [Sun, 21 Jul 2019 13:07:18 +0000 (15:07 +0200)]
Commit fd9e3452 removed -ffast-math from the compile flags. Under some
conditions this may lead to massive slowdown of floating point operations
when underflows or denormals are encountered. In particular, this problem
was observed with the soxr resampler after applying
https://gitlab.freedesktop.org/pulseaudio/pulseaudio/merge_requests/120

Therefore this patch adds -ffast-math to the link flags of the pulseaudio
daemon. Linking with -ffast-math adds a procedure set_fast_math() to the
startup code of the daemon. On x86, the procedure sets bit 6 and 15 of the
mxcsr register. When these bits are set, denormals and results of
underflowing operations are truncated to 0.

4 years agoi18n: update Polish translation
Piotr Drąg [Sat, 20 Jul 2019 12:13:29 +0000 (14:13 +0200)]
i18n: update Polish translation

4 years agopasuspender: explain program argument in help
S Page [Tue, 16 Jul 2019 06:23:50 +0000 (06:23 +0000)]
pasuspender: explain program argument in help

Fixes: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/issues/706

4 years agosvolume: Mark channel parameter as earlyclobber
Arun Raghavan [Thu, 11 Jul 2019 05:27:31 +0000 (10:57 +0530)]
svolume: Mark channel parameter as earlyclobber

For all our MMX/SSE code, we use a temporary channel variable, assigned
to the DI register, which is zero'ed as the very first operation in the
inline assembly code, before any other code is run.

With GCC 9.1, while using -O2, the DI register is also used for the
input operand. This is perfectly legal, but causes our code to become
incorrect because the output operand that is assigned to DI is not
explicitly marked as being clobbered before inputs are read.

This change fixes the problem by adding an earlyclobber annotation (&)
to the DI output argument.

4 years agoalsa-mixer: Add a missing USB product ID for SteelSeries Arctis 7
Kaleb Ercanbrack [Thu, 11 Jul 2019 14:09:58 +0000 (14:09 +0000)]
alsa-mixer: Add a missing USB product ID for SteelSeries Arctis 7

4 years agobuild-sys: Install cmedia-high-speed-true-hdaudio.conf
Jan Alexander Steffens (heftig) [Wed, 10 Jul 2019 23:41:55 +0000 (01:41 +0200)]
build-sys: Install cmedia-high-speed-true-hdaudio.conf

This profile set was missing from the installation.

4 years agoAdd to check privilege in case of ActivateDucking DBus method 97/209797/1 accepted/tizen/unified/20190716.111219 submit/tizen/20190716.020521
Jeongmo Yang [Thu, 11 Jul 2019 06:16:37 +0000 (15:16 +0900)]
Add to check privilege in case of ActivateDucking DBus method

[Version] 11.1.75
[Profile] Common
[Issue Type] New feature

Change-Id: Ie52a6745dd399251188ad506f0659dc5d526449a
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
4 years agobuild-sys: meson: Disable coverage by default
Arun Raghavan [Thu, 11 Jul 2019 02:24:13 +0000 (07:54 +0530)]
build-sys: meson: Disable coverage by default

4 years agoproplist: Add PA_PROP_MEDIA_ROUTE_AUTO_PREFERRED_DEVICE_ROLE property 44/209444/1 accepted/tizen/unified/20190715.111913 submit/tizen/20190712.062844
Sangchul Lee [Mon, 8 Jul 2019 05:39:08 +0000 (14:39 +0900)]
proplist: Add PA_PROP_MEDIA_ROUTE_AUTO_PREFERRED_DEVICE_ROLE property

[Version] 11.1.74
[Issue type] New feature

Change-Id: I8aadbe1842fbc89ead5ced97457f2c75a93318c7
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
4 years agobuild-sys: Fixes for i18n parts of the meson build v12.99.1
Arun Raghavan [Mon, 1 Jul 2019 15:49:04 +0000 (21:19 +0530)]
build-sys: Fixes for i18n parts of the meson build

4 years agoproplist: Add PA_PROP_DEVICE_ROLE property 08/207808/2
Sangchul Lee [Thu, 13 Jun 2019 02:31:19 +0000 (11:31 +0900)]
proplist: Add PA_PROP_DEVICE_ROLE property

[Version] 11.1.73
[Issue type] New feature

Change-Id: I9c61e89aa86f3fa2cb95be6aad996e89cea098eb
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
4 years agobuild-sys: Bump libpulse soversion
Arun Raghavan [Thu, 4 Jul 2019 08:49:33 +0000 (14:19 +0530)]
build-sys: Bump libpulse soversion

We've added new API and updated an enum. A bunch of function parameters
have been marked as const, but this probably shouldn't count as a change
anyway.

4 years agocore-util: Fix detection when running in a VM
Arun Raghavan [Mon, 1 Jul 2019 01:52:55 +0000 (07:22 +0530)]
core-util: Fix detection when running in a VM

The original code that was written was trying to detect what hypervisor
we were running under, rather than testing the presence bit first. We
don't really need the former, so let's use the more comprehensive latter
instead.

Fixes: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/issues/684

4 years agosink-input: fix rewriting render memblockq when nothing should be rewound
Georg Chini [Wed, 3 Jul 2019 10:32:50 +0000 (12:32 +0200)]
sink-input: fix rewriting render memblockq when nothing should be rewound

If process_rewind() is called with nbytes = 0, process_rewind() will
nevertheless request a rewrite of the render memblockq.

This patch fixes the problem by adding the render memblockq length to the
rewrite amount only if nbytes > 0.

4 years agosource-output: Fix rewinding bug
Georg Chini [Wed, 3 Jul 2019 10:32:16 +0000 (12:32 +0200)]
source-output: Fix rewinding bug

Currently the rewind logic for the source output is broken if the output
does not implement a process_rewind() callback. In that case, the read
index of the delay memblockq is rewound. This is wrong, because the data
that is going to be re-written was not yet read. Instead the write index
should be rewound and the read index left untouched. This is the reason
for the rewind glitches of monitor sources.

4 years agobluetooth: Fix crash when disabling Bluetooth adapter
Frédéric Danis [Wed, 19 Jun 2019 09:09:11 +0000 (11:09 +0200)]
bluetooth: Fix crash when disabling Bluetooth adapter

This crash occurs when PA is connected to a phone through the oFono
backend.
When disabling the Bluetooth adapter, pa_bluetooth_device is removed before
hf_audio_card. Both keep refs on pa_bluetooth_transport. Those removal will
call pa_bluetooth_transport_free() from device_free() (bluez5-util.c) and
hf_audio_card_free() (backend-ofono.c).
In the end, the call to pa_bluetooth_transport_free() calls
pa_hasmap_remove() through pa_bluetooth_transport_unlink(), but since
memory has already been freed, the second try results in a segfault.

Triggering hf_audio_card removal during pa_bluetooth_device removal allows
hf_audio_card to be freed at the right time.

4 years agobluetooth: Fix crash in setup_stream()
Frédéric Danis [Tue, 18 Jun 2019 08:15:15 +0000 (10:15 +0200)]
bluetooth: Fix crash in setup_stream()

setup_stream() crashes when calling set_nonblock() with an invalid
stream_fd.

On a new call, the ofono backend gets notified of a new connection.
The ofono backend sets the transport state to playing, and that triggers
a profile change, which sets up the stream for the first time.
Then module-bluetooth-policy sets up the loopbacks. The loopbacks get
fully initialized before the crash.

After module-bluetooth-policy has done its things, the execution
continues in the transport state change hook. The next hook user is
module-bluez5-device, whose handle_transport_state_change() function
gets called. It will then set up the stream again even though it's
already set up. I'm not sure if that's a some kind of a bug.
setup_stream() can handle the case where it's unnecessarily called,
though, so this second setup is not a big problem.

The crash happens, because the connection died due to POLLHUP in the IO
thread before the second setup_stream() call.