From 88b47b2f20bcc81788a9a5518a4f5eff6fd7ebbc Mon Sep 17 00:00:00 2001 From: Dan Fandrich Date: Mon, 4 Feb 2019 16:27:17 +0100 Subject: [PATCH] Fixed a potential NULL pointer dereference in exif_loader_get_buf. This would only happen if given a NULL pointer by the application. Found by Clang scan-build. --- libexif/exif-loader.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libexif/exif-loader.c b/libexif/exif-loader.c index 317b86b..e2208b4 100644 --- a/libexif/exif-loader.c +++ b/libexif/exif-loader.c @@ -410,9 +410,12 @@ exif_loader_get_buf (ExifLoader *loader, const unsigned char **buf, const unsigned char* b = NULL; unsigned int s = 0; - if (!loader || (loader->data_format == EL_DATA_FORMAT_UNKNOWN)) { + if (!loader) + return; + if (loader->data_format == EL_DATA_FORMAT_UNKNOWN) { exif_log (loader->log, EXIF_LOG_CODE_DEBUG, "ExifLoader", "Loader format unknown"); + return; } else { b = loader->buf; s = loader->bytes_read; -- 2.7.4