From 4e2a57247c78ff6bbaaba0c70e9c862d126d69a0 Mon Sep 17 00:00:00 2001 From: Kush Date: Tue, 16 Jul 2019 17:08:45 +0530 Subject: [PATCH] Crash in OCCreateResource Added check for uri before strncmp https://github.sec.samsung.net/RS7-IOTIVITY/IoTivity/pull/544/commits/ba1c2fd49c1fd4f519c64943656a5329cf36b0bd (cherry-picked from ba1c2fd49c1fd4f519c64943656a5329cf36b0bd) Change-Id: Ieddc1809174a1360a1bb82a6aeec580cb34e4755 Signed-off-by: Kush Signed-off-by: Sudipto Bal --- resource/csdk/stack/src/ocstack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resource/csdk/stack/src/ocstack.c b/resource/csdk/stack/src/ocstack.c index caed6d9..086567e 100644 --- a/resource/csdk/stack/src/ocstack.c +++ b/resource/csdk/stack/src/ocstack.c @@ -3682,7 +3682,7 @@ OCStackResult OCCreateResource(OCResourceHandle *handle, // repeated URLs, which are not allowed. If a repeat is found, exit with an error while (pointer) { - if (strncmp(uri, pointer->uri, MAX_URI_LENGTH) == 0) + if (pointer->uri && strncmp(uri, pointer->uri, MAX_URI_LENGTH) == 0) { OIC_LOG_V(ERROR, TAG, "Resource %s already exists", uri); return OC_STACK_INVALID_PARAM; -- 2.7.4