Gilbok Lee [Thu, 6 Jan 2022 05:21:25 +0000 (14:21 +0900)]
hlsdemux: Reset m3u8 sequence when fail three times to get next fragment
- When media sequence of m3u8 decreases on live stream, fail to get next fragment
Change-Id: Iaae7ba7cf3439fcca5155e9cc7f3a1a95e85909e
Sangchul Lee [Fri, 17 Dec 2021 06:03:57 +0000 (15:03 +0900)]
webrtcbin: Add drop-probability-receiver property
If netsim property is enabled, this property can be set to simulate
loss of being received RTP packets.
Change-Id: I4f229d41f40e649bdefffd48827f6f7172401741
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Thu, 16 Dec 2021 11:31:57 +0000 (20:31 +0900)]
webrtcbin: Add netsim and drop-probability-sender properties
These properties are added to simulate loss of sending RTP packets.
Change-Id: Ia633a32a902d6322189d1b0c033a3a15bdbc4e9d
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Fri, 17 Dec 2021 02:25:31 +0000 (11:25 +0900)]
webrtcbin: Fix invalid structure type
It also fix a build warning.
Change-Id: I4eebaa9c04ee20b85bb04a21f4c5464d58329e54
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Eunhye Choi [Fri, 17 Dec 2021 05:48:35 +0000 (14:48 +0900)]
hlsdemux: update segment with valid pos info
- add checking stream type to update segment position
- vtt stream is not proper to construct segment
Change-Id: Ibbdd91c6d75573afd708dc210dac20286290c3be
Gilbok Lee [Wed, 1 Dec 2021 04:55:42 +0000 (13:55 +0900)]
mpegtsdemux: activate new stream when program update
Change-Id: If8f299f90e181d47579f143e9671d488f0b2dbe6
Eunhye Choi [Mon, 29 Nov 2021 07:09:19 +0000 (16:09 +0900)]
hlsdemux: fix block issue if webvtt data is empty
- send webvtt dummy buffer to avoid block and
expose all the hlsdemux pad normally
Change-Id: I5ff48c4498752353ca4fd985a73df0c9bbe914f2
Eunhye Choi [Sat, 20 Nov 2021 05:45:31 +0000 (14:45 +0900)]
hlsdemux: set discont. only at start fragment
- discont have to be set in case of start fragment
to update pts correctly.
Change-Id: I482dd48012b8dc76d54e97b91e83b3083ad81d5b
Eunhye Choi [Wed, 17 Nov 2021 12:00:30 +0000 (21:00 +0900)]
tsdemux: update pmt info
- to handle new pmt as psi,
the pmt info have to be removed from the previous pes list
Change-Id: Ibd7df6f945287cb8f1ca8e9b6c6f71c07a3dc486
Sangchul Lee [Wed, 17 Nov 2021 08:08:54 +0000 (17:08 +0900)]
fixup! webrtcbin: Remove transceiver from array when releasing pad
Change-Id: Idd611bc2f66adf24abc51ae0ef0b000adbe8f48c
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Fri, 29 Oct 2021 06:45:18 +0000 (15:45 +0900)]
webrtcbin: Notify missing ice-gathering-state for COMPLETE
Occasionally, GATHERING_STATE_COMPLETE was obtained in _update_ice_
gathering_state_task() before consuming all the tasks for local ICE
candidates in _on_local_ice_candidate_task(). It missed notifying the
'ice-gathering-state' signal for gathering completion.
This patch fixes it.
Change-Id: Ie0a997e6976f48b876cb0741f488826a0c172116
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Gilbok Lee [Tue, 16 Nov 2021 01:14:04 +0000 (10:14 +0900)]
hlsdemux: Add condition for setting stream discontinuity
- Set stream continuity when fragment time changes
- Change in the wrong define in the spec
Change-Id: I592f4cd915c2d186462f771714de797c4b424521
Gilbok Lee [Fri, 12 Nov 2021 05:45:42 +0000 (14:45 +0900)]
hlsdemux: Set stream discontinuity when the last PCR value differs by more than 1 second
Change-Id: I1747f7485c9f2eabae67f6f17e11005715a1a081
Gilbok Lee [Fri, 12 Nov 2021 03:38:50 +0000 (12:38 +0900)]
tsdemux: Handle invalid PCR_PID streams
- If pcr_pid stream does not have PCR,
find PCR in all streams and update the program PCR_pid
Change-Id: I53c7fcfc8c405eb9ff162d52000d56d7e9cf3bfb
Sangchul Lee [Fri, 15 Oct 2021 03:07:47 +0000 (12:07 +0900)]
webrtcbin: Remove transceiver from array when releasing pad
Previously, even after releasing a pad, 'create-offer' could not
get valid sdp message. It is fixed.
Change-Id: I21120e5a4064f0c51cdf6dce88f51079592f5161
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Gilbok Lee [Tue, 7 Sep 2021 01:34:49 +0000 (10:34 +0900)]
tsdemux: Fix the check for the wrong event type
Change-Id: I54222748b3432b5f76392bb6567b0359c43dbb90
Gilbok Lee [Mon, 6 Sep 2021 04:52:58 +0000 (13:52 +0900)]
tsdemux: Save custom event(HLSMedia info) when program is NULL
Change-Id: Ida60c066ea5d069ccb7a64605317ee24805060bd
Sangchul Lee [Mon, 6 Sep 2021 04:53:59 +0000 (04:53 +0000)]
Merge changes from topic "webrtc_based_on_1.19.1" into tizen
* changes:
tests/webrtc: check for more sdp things across the board
webrtc: don't generate duplicate rtx payloads when bundle-policy is set
webrtc ice: Add 'min/max-rtp-port' props for setting RTP port range
webrtc ice: Only ever request one component, it's always rtcpmux
webrtcbin: use regular ice nomination by default
webrtc: expose transport property on sender and receiver
webrtcbin: try harder not to pick duplicate media ids
Matthew Waters [Fri, 19 Mar 2021 05:36:41 +0000 (16:36 +1100)]
tests/webrtc: check for more sdp things across the board
e.g.
- test for a=setup:$val and direction attributes in all tests
- test number of media sections
- test number of formats in each m= section (for audio/video)
- test no duplicate formats
Change-Id: I9cbb75f9f127bc662f9f909bdc8bb33cd42326f6
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/2093>
Matthew Waters [Mon, 1 Mar 2021 09:53:53 +0000 (20:53 +1100)]
webrtc: don't generate duplicate rtx payloads when bundle-policy is set
It was possible to generate a SDP that had an RTX payload type
that matched one of the media payload types when providing caps via
codec_preferences without any sink pads.
Fixes
m=video 9 UDP/TLS/RTP/SAVPF 96
...
a=rtpmap:96 VP8/90000
a=rtcp-fb:96 nack pli
a=fmtp:96 apt=96
Change-Id: I0b2d360cb40abcf5a61035673d43f15a40fc09fa
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/2046>
Ilya Kreymer [Thu, 15 Aug 2019 15:25:26 +0000 (08:25 -0700)]
webrtc ice: Add 'min/max-rtp-port' props for setting RTP port range
default min port == 0, max port == 65535 -- if min port == 0, uses existing random port selection (range ignored)
add 'gathering_started' flag to avoid changing ports after gathering has started
validity checks: min port <= max port enforced, error thrown otherwise
include tests to ensure port range is being utilized (by @hhardy)
Change-Id: I5fcc747bb3416c37e2dfdb6d83c9552e30583212
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/119>
Olivier Crête [Thu, 25 Feb 2021 16:58:57 +0000 (11:58 -0500)]
webrtc ice: Only ever request one component, it's always rtcpmux
Change-Id: Ic72fcc70844b5869961efed8878f815a087e71a9
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/119>
Matthew Waters [Mon, 22 Feb 2021 05:59:25 +0000 (16:59 +1100)]
webrtcbin: use regular ice nomination by default
1. We don't currently deal with an a=ice-options in the SDP which means
we currently violate https://tools.ietf.org/html/rfc5245#section-8.1.1
which states: "If its peer is using ICE options (present in
an ice-options attribute from the peer) that the agent does not
understand, the agent MUST use a regular nomination algorithm."
2. The recommendation is default to regular nomination in both RFC5245
and RFC8445. libnice change for this is
https://gitlab.freedesktop.org/libnice/libnice/-/merge_requests/125
which requires an API break in libnice.
Change-Id: I672c2d92b2ac258b563ed7a77a263502d1656bd2
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/2031>
Mathieu Duponchelle [Tue, 12 Jan 2021 18:12:42 +0000 (19:12 +0100)]
webrtc: expose transport property on sender and receiver
As advised by !1366#note_629558 , the nice transport should be
accessed through:
> transceiver->sender/receiver->transport/rtcp_transport->icetransport
All the objects on the path can be accessed through properties
except sender/receiver->transport. This patch addresses that.
Change-Id: I38e0c71f9dae0bf09ba4e8ea01cfa23726623d0a
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1952>
Mathieu Duponchelle [Tue, 22 Dec 2020 01:29:03 +0000 (02:29 +0100)]
webrtcbin: try harder not to pick duplicate media ids
On renegotiation, or when the user has specified a mid for
a transceiver, we need to avoid picking a duplicate mid for
a transceiver that doesn't yet have one.
Also assign the mid we created to the transceiver, that doesn't
fix a specific bug but seems to make sense to me.
Change-Id: I6c2399a352f2ab05b469914a348512bb2b5b4a34
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1902>
Gilbok Lee [Tue, 31 Aug 2021 08:22:13 +0000 (17:22 +0900)]
hlsdemux: Send HLSMedia information through custom event
Change-Id: Ibd1845ec1a40c81e026752b1e955cf16644f27bc
Sangchul Lee [Tue, 24 Aug 2021 07:49:13 +0000 (16:49 +0900)]
webrtcbin: Reset need_negotiation flag in case of READY to NULL
If the state is changed from PLAYING to NULL without releasing pad,
'on-negotiation-needed' signal is not be emitted even if the state
is changed to PLAYING again without any pad changes. It fixes this
issue.
[Version] 1.16.2-23
[Issue Type] Improvement
Change-Id: I15b6c34e590a84b6c9731e39f588078f8afaeef9
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Olivier Crête [Fri, 20 Nov 2020 22:32:44 +0000 (17:32 -0500)]
webrtc: Make ssrc map into separate data structures
They now contain a weak reference and that could be freed later
causing strange crashes as GWeakRef are not movable.
Change-Id: I3a5f4ee907bbaac48b25747f76f5d3abb7e3a1f6
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1766>
Olivier Crête [Fri, 16 Oct 2020 01:23:08 +0000 (21:23 -0400)]
webrtcstats: Get the remote-inbound stats from the right RTPSource
This also means that we need to get the clock-rate from the codec instead
of from the RTPSource, as the remote one doesn't include a clock rate.
Change-Id: Ib7ee7746a26897fb0a6a188f8a4132acbd0a4e60
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1766>
Edward Hervey [Wed, 11 Nov 2020 17:07:57 +0000 (18:07 +0100)]
hlsdemux: Don't double-free variant streams on errors
If an error happened switching to a new variant, we switch back to the previous
one ... except it will be unreffed when settin git.
In order to avoid such issues, keep a reference to the old variant until we're
sure we don't need it anymore
Fixes cases of double-free on variants and its contents
Change-Id: I2829e42d87e9d9218073aaa24ca18474748b092f
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1799>
Edward Hervey [Tue, 3 Nov 2020 16:48:02 +0000 (17:48 +0100)]
hlsdemux: Re-use streams if possible
When switching variants, try to re-use existing streams/pads instead of creating
new ones. When dealing with urisourcebin and decodebin3 this is not only the
expected way but also avoids a lot of buffering/hang issues.
Change-Id: I32cf158a0695e5af7de3a2e6001a0e9748f9e2b3
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1757>
Edward Hervey [Wed, 4 Nov 2020 09:36:21 +0000 (10:36 +0100)]
m3u8: Make a debug function usable elsewhere
The rest of the code might want to use this
Change-Id: Ica617d702a452e785fb1de16e910a3afcb56232d
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1757>
Olivier Crête [Wed, 30 Dec 2020 18:51:21 +0000 (13:51 -0500)]
webrtcbin: Remove remnant of non-rtcp-mux mode
There was some code left that wasn't used anymore.
Change-Id: Ic192f19accf3d1758c80b66fe455851a1fce5442
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1930>
Olivier Crête [Tue, 29 Dec 2020 18:29:05 +0000 (13:29 -0500)]
webrtcstats: PLI/FIR/NACK direction are the opposite of the media
Change-Id: I0c538c43041406abc1fb5b8727d2f0098594da51
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1924>
Olivier Crête [Thu, 15 Oct 2020 23:36:45 +0000 (19:36 -0400)]
webrtcbin: Implement getting stats for a specific pad
Change-Id: I6147beab9bd62a7fe7c9cb4c76a0207476e3d77e
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1766>
Olivier Crête [Sat, 10 Oct 2020 22:21:19 +0000 (18:21 -0400)]
webrtcstats: Also return the raw rtpsource stats for more information
Change-Id: Ic3d3503bedfb3d47b2ea5fc54c97b209f582d92a
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1766>
Olivier Crête [Sat, 10 Oct 2020 00:59:58 +0000 (20:59 -0400)]
webrtcstats: Avoid copy of GstStructure
Instead transfer the ownership to the new structure
Change-Id: I08281880d7267ddddd39eb867669df48af5156d8
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1766>
Olivier Crête [Sat, 10 Oct 2020 00:45:10 +0000 (20:45 -0400)]
webrtcstats: Remove receiver side when sending
Those are just invalid and just reflect what we sent. We'd need to parse the
RTCP XR packets from the other side to know more about those.
Change-Id: I071784b6017f156345e77463f4bb4980e9ee79f5
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1766>
Olivier Crête [Sat, 10 Oct 2020 00:27:40 +0000 (20:27 -0400)]
webrtcstats: Extract statistics from the rtpjitterbuffer
And expose them as standardised webrtc statistics
Change-Id: Ie4257b3ef0ffe0d3eb7128e3f48403cbba8a54f9
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1766>
Olivier Crête [Fri, 9 Oct 2020 22:45:57 +0000 (18:45 -0400)]
webrtcbin: Store the rtpjitterbuffer instances to extract stats from them
Store them as web refs to avoid having to worry about freeing later and because
the new-jitterbuffer is on a different thread
Change-Id: I96255421a669a3a08bf853ae0a5ad5f037ab114a
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1766>
Olivier Crête [Fri, 9 Oct 2020 23:59:18 +0000 (19:59 -0400)]
webrtcstats: Document all RTP missing fields according to the latest spec
Just document all the missing fields and document which ones will never
be implemented because they depend on the codec or depayloader
Change-Id: I52a9bde7155d146056dbc8bf8c450d3534b67847
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1766>
Olivier Crête [Fri, 9 Oct 2020 23:38:15 +0000 (19:38 -0400)]
webrtcstats: RTCP computed RTT is only available at sender
The receiver doesn't have the information to compute it.
Change-Id: Ic7ee27c650ca5853320a41c936a223f0c67198d1
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1766>
Olivier Crête [Thu, 8 Oct 2020 21:11:30 +0000 (17:11 -0400)]
webrtcstats: Remove redundant lines
Change-Id: If5fd93a87026ca1d9d6e52c46c227b4e6209adf3
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1766>
YoungHun Kim [Thu, 12 Aug 2021 06:15:21 +0000 (15:15 +0900)]
webrtcbin: Call nice_debug_enable() to enable nice debug
[Version] 1.16.2-22
[Issue Type] Improvement
Change-Id: Ibdb502e357bbe099703dbdff743980d9f1799eb7
Olivier Crête [Wed, 4 Nov 2020 22:06:02 +0000 (17:06 -0500)]
webrtc: Also remove rtcp_transport from the structure
Change-Id: Id63ee4d28b7ebaf72004af554d16f711d6d72ee9
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1765>
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Olivier Crête [Tue, 3 Nov 2020 00:55:46 +0000 (19:55 -0500)]
webrtc: Remove APIs to set transport on sender/receiver
They're not not used ever.
Change-Id: Ia90b7edfd32571bc018cb0cb2e5c1a8132da79e7
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1765>
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Olivier Crête [Thu, 9 Jul 2020 17:39:03 +0000 (13:39 -0400)]
rtpsender: Add API to set the priority
Change-Id: I2d2d907322a105e9e5d66667afca3373e03dc6d6
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1707>
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Olivier Crête [Tue, 3 Nov 2020 00:49:55 +0000 (19:49 -0500)]
webrtc: Remove non rtcp-mux code
RTCP mux is now always required by the WebRTC spec
Change-Id: I5a2112c84280d4ea7bf9969b5d2e7485855b9aaf
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1765>
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Raul Tambre [Wed, 11 Nov 2020 11:39:37 +0000 (13:39 +0200)]
webrtc: Update libnice version requirement to 0.1.17
Since !1366 nice_agent_get_sockets() is used, which requires 0.1.17.
Update the version requirement accordingly.
Fixes #1459.
Change-Id: Ic7e8afdf65475e7ffde24aa0665dac8725cdc626
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1792>
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Olivier Crête [Tue, 23 Jun 2020 14:29:42 +0000 (10:29 -0400)]
webrtc: Add properties to change the socket buffer sizes to ice object
libnice doesn't touch the kernel buffer sizes. When dealing with RTP data,
it's generally advisable to increase them to avoid dropping packets locally.
This is especially important when running multiple higher bitrate streams at
the same time.
Change-Id: Iee0ad6c5252fba2b27dffadd629930b3152a5f9d
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1366>
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Olivier Crête [Wed, 8 Jul 2020 21:24:36 +0000 (17:24 -0400)]
webrtc: Set the DSCP markings based on the priority
This matches how the WebRTC javascript API works and the Chrome implementation.
Change-Id: I83ee2bbf0afc6c627dc367ff7a1c8ea7a0fef43f
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1707>
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Olivier Crête [Wed, 8 Jul 2020 23:13:33 +0000 (19:13 -0400)]
webrtc: Save the media kind in the transceiver
Change-Id: If05ff32397a82abfab8394dbaa0209261631cea7
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1707>
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Olivier Crête [Sat, 3 Oct 2020 01:38:00 +0000 (21:38 -0400)]
webrtc: Document more objects
Change-Id: I553f4312cbe67d159cb66f3b7a4359887c017874
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1707>
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Olivier Crête [Thu, 9 Jul 2020 17:45:20 +0000 (13:45 -0400)]
webrtcbin: Remove unused function
Change-Id: I98dea5b58f3b3870db28e5de6ee9d26728b07150
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1707>
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sebastian Dröge [Wed, 7 Oct 2020 08:04:30 +0000 (11:04 +0300)]
webrtc: Require gstreamer-sdp in the pkg-config file
Some headers include API from it.
Change-Id: Iefdcb95ee4bc897dc6ce034a374c5df184a66b31
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1660>
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Olivier Crête [Thu, 26 Mar 2020 00:50:01 +0000 (20:50 -0400)]
webrtcbin: Accept end-of-candidate pass it to libnice
libnice now supports the concept of end-of-candidate, so use the API
for it. This also means that if you don't do that, the webrtcbin will
never declared the connection as failed.
This requires bumping the dependency to libnice 0.1.16
Change-Id: I6eae82ce39e7e65ff71247f6d4343e6df0b547e5
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1139>
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Olivier Crête [Wed, 26 Aug 2020 21:48:06 +0000 (17:48 -0400)]
webrtcbin: Merge the RTX SSRCs from all transceivers when bundling
Change-Id: Iedc2ed9fdeecc4b0b846983957be9a4fb47c6aaa
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1545>
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Matthew Waters [Wed, 26 Aug 2020 05:45:35 +0000 (15:45 +1000)]
webrtc: propagate more errors through the promise
Return errors on promises when things fail where available.
Things like parsing errors, invalid states, missing fields, unsupported
transitions, etc.
Change-Id: I1ca633d2620c99bf874a27d1c10f129d7aee96eb
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1565>
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Fri, 13 Aug 2021 08:06:03 +0000 (17:06 +0900)]
webrtc: Update tests/ based on 1.18.4
Files below are updated.
- tests/check/elements/webrtcbin.c
- tests/examples/webrtc/*
Change-Id: Ife33500c886357ec60fbaf28f5fdd16a84d4d575
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Gilbok Lee [Fri, 13 Aug 2021 04:10:06 +0000 (13:10 +0900)]
tsdemux: Save language tag when program is NULL
- When streaming HLS, global_tag release because of the buffer discontinue.
So, Save and sending pending laguage tag
Change-Id: Ia2823d64894701d27dd47810c0a5a6db385e71b2
Gilbok Lee [Wed, 11 Aug 2021 08:26:48 +0000 (17:26 +0900)]
hlsdemux: Save the EXT-X-MEDIA information about embedded stream
- And set the tag for embedded stream language code
Change-Id: Ie5336e24d5c09c90324df902b63dfa57324f0dfd
Eunhye Choi [Wed, 14 Jul 2021 10:00:24 +0000 (19:00 +0900)]
videoparse: Only add a single closed caption meta
Only add a single closed caption meta
Otherwise, having a stream go through a parser multiple times would
result in duplicate closed caption meta.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1396>
upstream commit id :
31d5d04bb1f5e3f6acdef8460193019237ecf5df
Change-Id: I587de0415e78e9e0de21ef079e594bec9bfedabd
Sangchul Lee [Wed, 7 Jul 2021 03:27:20 +0000 (12:27 +0900)]
webrtcbin: Fix memory leak in _set_rtx_ptmap_from_stream()
[Version] 1.16.2-20
[Issue Type] Coverity (Resource leak)
Change-Id: Ieb7ae7649503026eff5737c5fbe28057ce81a590
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Gilbok Lee [Fri, 25 Jun 2021 00:34:09 +0000 (09:34 +0900)]
tsdemux: send converted GST_BUFFER_PTS() when emit stats
Change-Id: I1730850632eef9f93e25e6b5f40a5d0ef034bb09
Sangchul Lee [Thu, 24 Jun 2021 03:03:14 +0000 (12:03 +0900)]
webrtcbin: Remove unreachable codes and redundant condition
[Version] 1.16.2-18
[Issue Type] SVACE (UNREACHABLE_CODE/SIMILAR_BRANCHES)
Change-Id: Ic3475956be436e9d2151b1dee1fbc79a1cd1c8b7
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Thu, 24 Jun 2021 02:11:20 +0000 (11:11 +0900)]
webrtcdatachannel: Fix memory leak
[Version] 1.16.2-17
[Issue Type] SVACE (MEMORY_LEAK.STRDUP)
Change-Id: I8b24e1e01b9f82a952cf53240e6626a55dcedb12
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Thu, 24 Jun 2021 01:59:54 +0000 (10:59 +0900)]
webrtcice: Avoid access memory after free and fix memory leak
[Version] 1.16.2-16
[Issue Type] SVACE (PASSED_TO_PROC_AFTER_FREE.EX)
Change-Id: I61f9148466ec842972cf44d8e87a01e8a504b363
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Eunhye Choi [Tue, 15 Jun 2021 08:09:05 +0000 (17:09 +0900)]
m3u8: remove unreachable code
- fix svace issue
Change-Id: I342e992e126f2d2ffbbaa1a9e47c403f171f6bae
Olivier Crête [Wed, 30 Dec 2020 18:51:21 +0000 (13:51 -0500)]
webrtcbin: Remove remnant of non-rtcp-mux mode
There was some code left that wasn't used anymore.
Change-Id: I76d0148e40012adf07f42c9008075d2f529537ed
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1930>
Olivier Crête [Tue, 3 Nov 2020 00:49:55 +0000 (19:49 -0500)]
webrtc: Remove non rtcp-mux code
RTCP mux is now always required by the WebRTC spec
Change-Id: I541ca3e3a9a6a016f9d0be1ab6da1f37c2dde69e
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1765>
Sangchul Lee [Wed, 21 Apr 2021 06:01:15 +0000 (15:01 +0900)]
webrtcbin: Call the missing gst_ghost_pad_construct()
[Version] 1.16.2-14
[Issue Type] Improvement
Change-Id: Ia733b9972f72595e7dac175b22983332889b6fcf
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 10 Feb 2021 07:17:14 +0000 (16:17 +0900)]
dtls: Update codes based on 1.18.4
Files in ext/dtls/ are updated.
Change-Id: I14a943cf0210610c4e8ee3da31d03bd4f47944dd
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Thu, 31 Dec 2020 11:31:09 +0000 (20:31 +0900)]
webrtc: Update codes based on 1.18.4
files below are updated.
- ext/webrtc/*
- gst-libs/gst/webrtc/*
Change-Id: Ic2622a1e0275a4e11ccd806a631d923a5601308e
Signed-off-by: Sangchul Lee <sangchul1011@gmail.com>
Eunhye Choi [Wed, 12 May 2021 11:26:51 +0000 (20:26 +0900)]
hlsdemux: add property about live info
- add readable property about live info
: is live, live start time, live end time
Change-Id: I0be1bfec4527cad2db6910e8e0cae5a6fa2eb498
Gilbok Lee [Wed, 12 May 2021 08:11:16 +0000 (17:11 +0900)]
hlsdemux: push language code tag
Change-Id: I0941e39c9384f6c936d8ea736704d2b718902b3c
Gilbok Lee [Tue, 11 May 2021 04:40:01 +0000 (13:40 +0900)]
hlsdemux: Enable support for external subtitles
- auto-indented using gst-indent
Change-Id: I71f521a191bbca086e8cd01883bed600e3e50b5d
Eunhye Choi [Thu, 6 May 2021 07:59:40 +0000 (16:59 +0900)]
hlsdemux: post first variant bandwidth info
- post bandwidth information if the first variant is selected.
- when the variant is changed, the bandwidth info has been posted.
Change-Id: Ic22cf3e41524bce1b46bd83a2fc0ea54c0e9debd
Eunhye Choi [Mon, 26 Apr 2021 10:36:07 +0000 (19:36 +0900)]
hlsdemux: parse cue related tag for AD
- parse cue-out, cue-in, cue-out-cont hls tag
to get AD information
Change-Id: I9b9e4ec3e370418b8cf1310d0aed7afc4cffb79f
Sangchul Lee [Wed, 21 Apr 2021 06:18:08 +0000 (15:18 +0900)]
fixup! adaptive: allow pad switching
Fix ignoring build definitions caused by the commented line.
Change-Id: Ie08002787deb634c6b5e560ea529d10c972207b6
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Eunhye Choi [Tue, 13 Apr 2021 09:52:52 +0000 (18:52 +0900)]
adaptive: allow pad switching
- disable the AVOID_PAD_SWITCHING patch to support
pad switching as upstream.
- pad switching should be allowed to support AD during
adaptive streaming.
Change-Id: Iabec91fe30e9069970b057efa80d143d5d191f50
Sangchul Lee [Fri, 2 Apr 2021 08:45:46 +0000 (17:45 +0900)]
webrtcbin: Make it possible to create data channel before READY state
The condition 'webrtc->priv->is_closed' is set to TRUE when NULL state.
In Tizen, skip checking this condition to create data channel within
NULL state.
[Version] 1.16.2-8
[Profile] Common
[Issue Type] Improvement
Change-Id: I60dad04350372d6fa10dd987be92b152e9cada19
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Eunhye Choi [Tue, 9 Mar 2021 06:55:26 +0000 (15:55 +0900)]
hls: support bandwidth limit
- add start-bandwidth, min-bandwidth properties
to use when switching to alternates.
Change-Id: I616847f7a6f9c71564b9a054feae1a0b38625506
Gilbok Lee [Mon, 4 Jan 2021 04:36:46 +0000 (13:36 +0900)]
dashdemux: Check bandwidth instead of video mime-type when storing variant information.
- There may be no mimetype in the representation field
Change-Id: Icf40af82ea8c01f649bf982ecb37d19fc33e49b0
Gilbok Lee [Thu, 24 Dec 2020 03:54:46 +0000 (03:54 +0000)]
Merge "h264parse: ignore GST_H264_PARSER_NO_NAL return when last nal type is GST_H264_NAL_SEQ_END" into tizen
Gilbok Lee [Tue, 15 Dec 2020 08:46:18 +0000 (17:46 +0900)]
h264parse: ignore GST_H264_PARSER_NO_NAL return when last nal type is GST_H264_NAL_SEQ_END
Change-Id: Ie3c42c98ff22079bd1da31c96e8f26d04d035b6d
Sangchul Lee [Wed, 16 Dec 2020 02:52:22 +0000 (11:52 +0900)]
webrtcsdp: Fix memory leaks
[Version] 1.16.2-5
[Profile] Common
[Issue Type] Bug fix (SVACE)
Change-Id: I3d60ac5e2cb6b89065edab44ab9139b4e2b442fa
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Minje Ahn [Mon, 9 Nov 2020 06:54:58 +0000 (15:54 +0900)]
Activate plug-in for Gstreamer Editing Services
Activation list:
- libgstgaudieffects.so
- libgstcoloreffects.so (Activated in TV profile)
Change-Id: I789d3667f65e40c5a03c87f6884fe6d579f169b4
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Gilbok Lee [Tue, 15 Sep 2020 07:25:49 +0000 (16:25 +0900)]
adaptivedemux/mpegdemux : Fix coverity issue (Missing unlock)
Change-Id: I51fea48a0d00b2a38e136e03fa5f7b3a537440da
gichan-jang [Fri, 10 Jul 2020 08:16:36 +0000 (17:16 +0900)]
[SPEC] Enable gst gdp plugin
Gdp plugin need to be transmit the gst buffers through tcp communication.
Change-Id: I2cdc012f96bdb0ddf1b30164ffb061b92a086bb7
Signed-off-by: gichan-jang <gichan2.jang@samsung.com>
Hyunil [Mon, 27 Apr 2020 07:58:52 +0000 (16:58 +0900)]
Add webrtcsendrecv test app to tests/example/webrtc
- Answerer logic is added
- Add call stack log
- Add use-camera-mic feature to use camera and mic
- Add use-proxy feature to use proxy server
- Add build define for webrtctest
Change-Id: Ide51737b4ef5a87ec853b4f8c1920ddab39dd502
Signed-off-by: Hyunil <hyunil46.park@samsung.com>
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Jeongmo Yang [Wed, 22 Apr 2020 10:57:30 +0000 (19:57 +0900)]
fixup! Enable opusparse plugin
- The explicit build dependency should be added after correct spec file of gst-plugins-base package.
[Version] 1.16.2-2
[Profile] Common
[Issue Type] Bug fix
Change-Id: I6adcea6a2d2d7c4af6dc74912918707b2aeff3b1
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
Jeongmo Yang [Tue, 14 Apr 2020 06:08:24 +0000 (15:08 +0900)]
Enable opusparse plugin
- This patch should be merged with opus enabled gst-plugins-base package.
[Version] 1.16.2-1
[Profile] Common
[Issue Type] Update
Change-Id: Iefa7deceff196974151e10fe4e820d52e93c7b02
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
Hyunil [Wed, 1 Apr 2020 09:08:32 +0000 (18:08 +0900)]
srtp: enable plugins
Change-Id: I3fc2b995862f194d63f84919635b5c31f1f62f97
Signed-off-by: Hyunil <hyunil46.park@samsung.com>
Gilbok Lee [Tue, 31 Mar 2020 04:55:15 +0000 (04:55 +0000)]
Merge "Remove unrecognized configure options" into tizen
Gilbok Lee [Mon, 30 Mar 2020 08:20:28 +0000 (17:20 +0900)]
Remove unrecognized configure options
Change-Id: I3b2c18c417567ccd00edf50267769df8ddbeb213
Hyunil [Wed, 18 Mar 2020 09:15:55 +0000 (18:15 +0900)]
sctp: enable sctpdec and sctpenc plugins
Change-Id: Ifcd70387b5d3f36dcc980f5ee5a99f335440dc31
Signed-off-by: Hyunil <hyunil46.park@samsung.com>
Hyunil [Tue, 17 Mar 2020 01:00:25 +0000 (10:00 +0900)]
dtls: enable plugins
Change-Id: Ia8c157ce48f59448eb600d84e3da2d3138c2a153
Signed-off-by: Hyunil <hyunil46.park@samsung.com>
Hyunil [Wed, 11 Mar 2020 08:35:38 +0000 (17:35 +0900)]
webrtc: modify to allow installation of webrtc plugin
Change-Id: I84a51559a4504ff0d73f9b4617906e51d57c5e42
Signed-off-by: Hyunil <hyunil46.park@samsung.com>
Eunhye Choi [Mon, 9 Mar 2020 04:45:03 +0000 (13:45 +0900)]
soundtouch: fix coverity issue
Change-Id: I7290f22c61ffda3f27ea77e5232d332be9d5c3d4
Gilbok Lee [Fri, 21 Feb 2020 06:24:41 +0000 (15:24 +0900)]
Merge branch 'tizen_gst_1.16.2' into tizen
Change-Id: Icf2e38c593ba1f1e4a74ddb1bd1559af6d123676
projects / platform / upstream / gstreamer.git / log