platform/upstream/gstreamer.git
2 years agortphdrext-clientaudiolevel: Rename RFC 6464 element
Olivier Crête [Wed, 15 Sep 2021 18:19:06 +0000 (14:19 -0400)]
rtphdrext-clientaudiolevel: Rename RFC 6464 element

Multiplying elements named after RFC numbers is confusing,
so let's give them meaningful names.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1125>

2 years agoci: gstreamer-full: reenable build
Stéphane Cerveau [Tue, 19 Oct 2021 11:11:01 +0000 (13:11 +0200)]
ci: gstreamer-full: reenable build

The gstreamer-full job should be run
during the integrate stage always.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1190>

2 years agosubprojects: Update ogg and vorbis wraps
Seungha Yang [Tue, 19 Oct 2021 15:28:33 +0000 (00:28 +0900)]
subprojects: Update ogg and vorbis wraps

... to 1.3.5-2 and 1.3.7-2, respectively. Specifically to fix
ogg/vorbis plugin loading on Windows devenv environment.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1196>

2 years agoRevert "meson: Link to objects instea of static helper library"
Xavier Claessens [Tue, 19 Oct 2021 14:24:42 +0000 (10:24 -0400)]
Revert "meson: Link to objects instea of static helper library"

This reverts commit b19de413b94d228b1460b0899f9b41b2b5233943.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1194>

2 years agoRevert "audio: Merge simd libs into the main one"
Xavier Claessens [Tue, 19 Oct 2021 14:07:55 +0000 (10:07 -0400)]
Revert "audio: Merge simd libs into the main one"

This reverts commit 4d3a200358439e6c76c5dd1be2daae0cceb0e44a.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1194>

2 years agoAdd initial meson devenv support
Xavier Claessens [Sun, 21 Feb 2021 15:20:15 +0000 (10:20 -0500)]
Add initial meson devenv support

There is still a few things missing compared to gst-env.py, but it is
functional.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1162>

2 years agovideo-overlay-composition: Fix constructor guard to actually allow NULL as parameter
Sebastian Dröge [Tue, 19 Oct 2021 14:07:37 +0000 (17:07 +0300)]
video-overlay-composition: Fix constructor guard to actually allow NULL as parameter

And don't use a NULL rectangle later.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1195>

2 years agogl/eagl: fix eagl display creation
Matthew Waters [Tue, 19 Oct 2021 08:46:48 +0000 (19:46 +1100)]
gl/eagl: fix eagl display creation

The GstGLDisplayType of the display was win32 instead of the required eagl.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1188>

2 years agoqtdemux: Add support for wvtt (WebVTT) subtitles.
Jan Schmidt [Fri, 4 Jun 2021 17:13:52 +0000 (03:13 +1000)]
qtdemux: Add support for wvtt (WebVTT) subtitles.

WebVTT in ISO MP4 is specified in ISO 14496-30,
and needed for DASH support. It's stored in an
mp4 specific format. To handle it compatibly,
the wvtt boxes are converted back into WebVTT text
and pushed as application/x-subtitle-vtt

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1182>

2 years agoisomp4: Split buffer process functions.
Jan Schmidt [Fri, 27 Aug 2021 12:45:18 +0000 (22:45 +1000)]
isomp4: Split buffer process functions.

Split the different handling for closed captions, VobSub subpicture
and timed text samples into separate simplified process functions.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1182>

2 years agoisomp4: Use a function pointer for buffer splitting.
Jan Schmidt [Fri, 27 Aug 2021 11:58:25 +0000 (21:58 +1000)]
isomp4: Use a function pointer for buffer splitting.

Swap the `need_process` boolean check on qtdemux streams
for a direct function pointer to the splitting function,
so we can stop adding extra cases to the single growing
`gst_qtdemux_process_buffer()` function.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1182>

2 years agosrt: Plug leak of headers
Jan Alexander Steffens (heftig) [Fri, 7 May 2021 09:11:31 +0000 (11:11 +0200)]
srt: Plug leak of headers

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1040>

2 years agotests/rtp/payload: add test for shrinking extension data
Matthew Waters [Tue, 31 Aug 2021 06:21:09 +0000 (16:21 +1000)]
tests/rtp/payload: add test for shrinking extension data

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1146>

2 years agortp: also support shrinking the extension data
Matthew Waters [Tue, 24 Aug 2021 11:26:54 +0000 (21:26 +1000)]
rtp: also support shrinking the extension data

Currently the extension data length specified in the RTP header would
say it was shorter then the data serialised to a packet. When
combining the resulting buffer, the underlying memory would still
contain the extra (now 0-filled) padding data.

This would mean that parsing the resulting RTP packet would potentially
start with a number of 0-filled bytes which many RTP formats are not
expecting.

Such usage is found by e.g. RTP header extension when allocating the
maximum buffer (which may be larger than the written size) and shrinking
to the required size the data once all the rtp header extension data has
been written.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1146>

2 years agompegtsmux: Avoid crash when best pad gets flushed
Jan Alexander Steffens (heftig) [Mon, 31 Aug 2020 15:17:56 +0000 (17:17 +0200)]
mpegtsmux: Avoid crash when best pad gets flushed

The 'best' pad might receive a flush event between us picking it and us
popping the buffer. In this case, the buffer will be missing.

Similar to https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/711

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1042>

2 years agovorbisdec: don't emit g_warning() on malformed input data
Tim-Philipp Müller [Sun, 17 Oct 2021 12:14:38 +0000 (13:14 +0100)]
vorbisdec: don't emit g_warning() on malformed input data

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1009>

2 years agotheoradec: don't emit g_warning() on malformed input stream
Tim-Philipp Müller [Sun, 17 Oct 2021 12:12:11 +0000 (13:12 +0100)]
theoradec: don't emit g_warning() on malformed input stream

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1009>

2 years agosubparse: don't use g_warning() for malformed input
Tim-Philipp Müller [Sun, 17 Oct 2021 12:04:14 +0000 (13:04 +0100)]
subparse: don't use g_warning() for malformed input

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1009>

2 years agotools: Define G_LOG_DOMAIN for various tools as well
Tim-Philipp Müller [Sun, 17 Oct 2021 10:39:57 +0000 (11:39 +0100)]
tools: Define G_LOG_DOMAIN for various tools as well

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1009>

2 years agortsp-server: define G_LOG_DOMAIN
Tim-Philipp Müller [Fri, 1 Oct 2021 14:32:58 +0000 (15:32 +0100)]
rtsp-server: define G_LOG_DOMAIN

Fixes #634

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1009>

2 years agogst-plugins-bad: define G_LOG_DOMAIN for all libraries
Tim-Philipp Müller [Fri, 1 Oct 2021 14:31:18 +0000 (15:31 +0100)]
gst-plugins-bad: define G_LOG_DOMAIN for all libraries

Fixes #634

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1009>

2 years agogst-plugins-base: define G_LOG_DOMAIN for all libraries
Tim-Philipp Müller [Fri, 1 Oct 2021 14:30:27 +0000 (15:30 +0100)]
gst-plugins-base: define G_LOG_DOMAIN for all libraries

Fixes #634

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1009>

2 years agogstreamer: define G_LOG_DOMAIN for all libraries
Tim-Philipp Müller [Fri, 1 Oct 2021 14:29:36 +0000 (15:29 +0100)]
gstreamer: define G_LOG_DOMAIN for all libraries

And get rid of weird way the define was done for core.

Fixes #634

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1009>

2 years agolibs: check: handle criticals and warnings for new gstreamer log domains
Tim-Philipp Müller [Wed, 6 Oct 2021 00:30:03 +0000 (01:30 +0100)]
libs: check: handle criticals and warnings for new gstreamer log domains

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1009>

2 years agoaes: specify the required OpenSSL version
Antonio Ospite [Wed, 6 Oct 2021 11:38:35 +0000 (13:38 +0200)]
aes: specify the required OpenSSL version

The code in the aes elements assumes OpenSSL >= 1.1.0:

  - implicit library initialization;
  - version retrieved with OpenSSL_version(OPENSSL_VERSION);

and it fails to build with older versions.

Specify the required OpenSSL version explicitly in meson.build so that
the elements are excluded on older systems (e.g. Ubuntu 16.04) and the
rest of GStreamer can still build.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1067>

2 years agoci: fix plugins cache diffs directory
Mathieu Duponchelle [Mon, 18 Oct 2021 22:19:58 +0000 (00:19 +0200)]
ci: fix plugins cache diffs directory

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/867>

2 years agoaudio/video aggregator: make use of new aggregator inactive pad API
Mathieu Duponchelle [Sat, 14 Aug 2021 23:36:14 +0000 (01:36 +0200)]
audio/video aggregator: make use of new aggregator inactive pad API

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/867>

2 years agoaggregator: expose API for ignoring inactive pads
Mathieu Duponchelle [Mon, 18 Oct 2021 13:56:31 +0000 (15:56 +0200)]
aggregator: expose API for ignoring inactive pads

An inactive pad is a pad which, in live mode, hasn't yet received
a first buffer, but has been waited on at least once.

Exposing API to support this behaviour allows users of aggregator
subclasses to request pads, and not start pushing data on those
immediately, while avoiding systematic timeouts.

Subclasses must check in explicitly to this behavior, most likely
by exposing a user-facing property, and must check whether a pad
needs ignoring when aggregating. That is because by design,
aggregator subclasses don't get a list of "ready" pads, but instead
directly iterate element->sinkpads.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/867>

2 years agodocs: tutorial 1: error out if an error occurred in Hello World tutorial
Tim-Philipp Müller [Mon, 18 Oct 2021 17:20:10 +0000 (18:20 +0100)]
docs: tutorial 1: error out if an error occurred in Hello World tutorial

Very confusing if it just exits silently with exit code 0 on error.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1185>

2 years agodiscoverer: Advertise container-specific tags with a new API
Philippe Normand [Sun, 10 Oct 2021 16:07:33 +0000 (17:07 +0100)]
discoverer: Advertise container-specific tags with a new API

Since commit a55dafe341ac7398e7c37c30d8b760228296da92, stream-scoped tags no
longer appeared as top-level tags, introducing a behaviour regression, specially
for MP3 files.

The `gst_discoverer_info_get_tags()` API now returns all tags detected for the
given media, as documented.

A new API is introduced to get container-specific tags,
`gst_discoverer_container_info_get_tags()`. The discoverer tool was adapted to
use it. `gst_discoverer_info_get_tags()` is now deprecated in favor of
`gst_discoverer_container_info_get_tags()` and
`gst_discoverer_stream_info_get_tags()`.

Fixes #759

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1107>

2 years agovadeinterlace: Accept ANY feature.
Víctor Manuel Jáquez Leal [Mon, 11 Oct 2021 11:05:24 +0000 (13:05 +0200)]
vadeinterlace: Accept ANY feature.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1024>

2 years agovadeinterlace: Fixate interlace-mode and framerate accordingly.
Víctor Manuel Jáquez Leal [Mon, 11 Oct 2021 11:04:19 +0000 (13:04 +0200)]
vadeinterlace: Fixate interlace-mode and framerate accordingly.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1024>

2 years agovapostproc: Accept ANY feature.
Víctor Manuel Jáquez Leal [Thu, 14 Oct 2021 05:03:26 +0000 (07:03 +0200)]
vapostproc: Accept ANY feature.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1024>

2 years agovapostproc: Traverse caps features in gst_va_vpp_caps_remove_fields()
Víctor Manuel Jáquez Leal [Wed, 13 Oct 2021 17:27:41 +0000 (19:27 +0200)]
vapostproc: Traverse caps features in gst_va_vpp_caps_remove_fields()

The previous code had a potential failure for multiple caps features. Now
each caps feature in each structure is reviewed, and if it has a supported
feature, the structure is processed.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1024>

2 years agovapostproc: Refactor gst_va_vpp_complete_caps_features()
Víctor Manuel Jáquez Leal [Wed, 13 Oct 2021 15:08:12 +0000 (17:08 +0200)]
vapostproc: Refactor gst_va_vpp_complete_caps_features()

gst_va_vpp_complete_caps_features() now receives the @feature_name to
add and return if @caps doesn't provide it.

So, instead of two nested loops, now the function is a single loop,
traversing @caps to find if each structure already contains the requested
@features_name.

It's important to add missing caps features with @caps, in order to
not lost information.

The function caller does the external loop by calling per each
available caps feature.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1024>

2 years agovapostproc: Split caps transform in two phases.
Víctor Manuel Jáquez Leal [Mon, 11 Oct 2021 16:57:48 +0000 (18:57 +0200)]
vapostproc: Split caps transform in two phases.

In order to make more readable the caps transformation, the operation
was split in two phases:

1. Rangify the supported caps structures.
2. Add the missing (and supported) caps features.

Step 1 modified its logic, by copying any unrecognized structure.
It's a previous step required for allowing ANY caps feature as
passthrough.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1024>

2 years agotsdemux: Change many GST_{DEBUG, LOG, etc} into _OBJECT
Vivia Nikolaidou [Fri, 8 Oct 2021 09:38:04 +0000 (12:38 +0300)]
tsdemux: Change many GST_{DEBUG, LOG, etc} into _OBJECT

Log files with several demuxers running at once can otherwise get
confusing

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1096>

2 years agotsdemux: Issue GST_ELEMENT_WARNING for continuity errors
Vivia Nikolaidou [Fri, 8 Oct 2021 09:36:58 +0000 (12:36 +0300)]
tsdemux: Issue GST_ELEMENT_WARNING for continuity errors

The application might want to make use of these.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1096>

2 years agoci: install newer meson via pip in documentation job
Tim-Philipp Müller [Mon, 18 Oct 2021 14:48:09 +0000 (15:48 +0100)]
ci: install newer meson via pip in documentation job

Since updating the existing image seems difficult and efforts
to redo the setup are still work in progress.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1084>

2 years agomeson: bump meson requirement to >= 0.59
Tim-Philipp Müller [Thu, 14 Oct 2021 17:38:26 +0000 (18:38 +0100)]
meson: bump meson requirement to >= 0.59

For monorepo build and ugly/bad, for advanced feature
option API like get_option('xyz').required(..) which
we use in combination with the 'gpl' option.

For rest of modules for consistency (people will likely
use newer features based on the top-level requirement).

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1084>

2 years agomeson: add 'gpl' option and only build plugins with (A)GPL deps if explicitly enabled
Tim-Philipp Müller [Sat, 18 Sep 2021 23:55:34 +0000 (00:55 +0100)]
meson: add 'gpl' option and only build plugins with (A)GPL deps if explicitly enabled

Require explicit opt-in to build plugins with (A)GPL dependencies.

Keep ugly/bad options on 'auto' for now so cerbero doesn't fail.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1084>

2 years agobasetsmux: Support for caps changes
Vivia Nikolaidou [Fri, 30 Oct 2020 14:02:22 +0000 (16:02 +0200)]
basetsmux: Support for caps changes

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/981>

2 years agobasetsmux: Clean up gst_base_ts_mux_create_stream
Jan Alexander Steffens (heftig) [Thu, 12 Nov 2020 11:17:14 +0000 (12:17 +0100)]
basetsmux: Clean up gst_base_ts_mux_create_stream

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/981>

2 years agompegtsbase: Search SCTE-35 DRF_ID_CUEI in multiple registration descriptors
Vivia Nikolaidou [Tue, 31 Aug 2021 13:35:06 +0000 (16:35 +0300)]
mpegtsbase: Search SCTE-35 DRF_ID_CUEI in multiple registration descriptors

There are streams in the wild that have to add a SCTE-35 trigger in
another e.g. GA94 stream. Most encoders would replace the GA94
descriptor ID with the CUEI one temporarily, but there are some that
will add two registration ID descriptors, one with GA94 and one with
CUEI.

Failing to parse the CUEI registration ID in that case would return
FALSE in _stream_is_private_section , therefore setting it as known PES
and pushing packets downstream instead of calling handle_psi.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/979>

2 years agosmartencoder: Force reencoding of vp9 for profiles can't support
Thibault Saunier [Fri, 15 Oct 2021 02:02:36 +0000 (23:02 -0300)]
smartencoder: Force reencoding of vp9 for profiles can't support

If the input file is in a profile we won't be able to output (1 or 3 in BGR
format), simply reencode everything for now.

Once we add support for that case we can remove that code

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1062>

2 years agoencoding-profile: ignore more fields when creating for discover info
Thibault Saunier [Fri, 15 Oct 2021 01:55:35 +0000 (22:55 -0300)]
encoding-profile: ignore more fields when creating for discover info

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1062>

2 years agosmartencoder: Always plug a vp9parse when encoding vp9
Thibault Saunier [Fri, 15 Oct 2021 01:29:19 +0000 (22:29 -0300)]
smartencoder: Always plug a vp9parse when encoding vp9

This way we know that all relevant fields about video format are
added and we avoid renegotiation issues.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1062>

2 years agoqtmux: Allow more fields changes renegotiating h264
Thibault Saunier [Tue, 5 Oct 2021 15:28:22 +0000 (12:28 -0300)]
qtmux: Allow more fields changes renegotiating h264

And consider interlace-mode=progress as equivalent to the field not
being specified.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1062>

2 years agomatroskamux: Ignore some fields when renegotiating
Thibault Saunier [Tue, 5 Oct 2021 13:50:32 +0000 (10:50 -0300)]
matroskamux: Ignore some fields when renegotiating

Those values are never used in the muxer so we should not fail the
negotiation if those are changing.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1062>

2 years agosmartencoder: Fix renegotiating when reencoding parts of the stream with vpx
Thibault Saunier [Tue, 5 Oct 2021 13:46:26 +0000 (10:46 -0300)]
smartencoder: Fix renegotiating when reencoding parts of the stream with vpx

In the encoded streams we might not have all the information about the
raw video stream, but when reencoding they end up being specified, even
if those are default values.

As vp8 decoders always output frames in some YUV color space we can
ensure that when upstream doesn't specify any value in its caps we
use the default one which is what we end up doing when decoding/reencoding
anyway, so this way downstream (matroskamux in that case) doesn't need
to be able to renegotiate (which it doesn't).

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1062>

2 years agotsdemux: Improve gap detection
Edward Hervey [Fri, 1 Oct 2021 12:36:48 +0000 (14:36 +0200)]
tsdemux: Improve gap detection

We should also take into account whether data is currently pending when checking
for gap on streams. It could very well be that some streams have very low
bitrate (and spread out) data. For those we don't want to push out a gap event.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1179>

2 years agotsdemux: Handle "negative" timestamps
Edward Hervey [Sun, 5 Sep 2021 09:57:18 +0000 (11:57 +0200)]
tsdemux: Handle "negative" timestamps

This is only enabled in push time mode. Furthermore it's only enabled for now if
PCR is to be ignored.

The problem is dealing with streams where the initial PTS/DTS observation might
be greater than following ones (from other PID for example). Before this patch,
this would result in sending buffers without any timestamp which would cause a
wide variety of issues.

Instead, pad segment and buffer timestamps with an extra
value (packetizer->extra_shift, default to 2s), to ensure that we can get valid
timestamps on outgoing buffers (even if that means they are before the segment
start).

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1179>

2 years agotsdemux: Handle streams with bogus PTS vs DTS
Edward Hervey [Sun, 5 Sep 2021 09:55:55 +0000 (11:55 +0200)]
tsdemux: Handle streams with bogus PTS vs DTS

PTS and DTS should be within a reasonable distance of each other.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1179>

2 years agotsdemux: Handle PTS->TS at wraparound
Edward Hervey [Sun, 5 Sep 2021 09:53:05 +0000 (11:53 +0200)]
tsdemux: Handle PTS->TS at wraparound

This has been a FIXME for ages.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1179>

2 years agowebrtcbin: fix prevention of webrtcbin deletion due to ref held by probe callback
Rob Agar [Thu, 14 Oct 2021 13:07:07 +0000 (14:07 +0100)]
webrtcbin: fix prevention of webrtcbin deletion due to ref held by probe callback

https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/810

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1150>

2 years agod3d11: d3d11{convert,scale}: Add add-borders property
Seungha Yang [Sat, 16 Oct 2021 10:01:27 +0000 (19:01 +0900)]
d3d11: d3d11{convert,scale}: Add add-borders property

Functionally identical to that of videoscale element.

When disabled, d3d11convert or d3d11scale element will scale
image without adding borders, meaning that display aspect ratio
will not be preserved.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1170>

2 years agovapostproc: Add add-borders property to keep dar
Víctor Manuel Jáquez Leal [Sat, 16 Oct 2021 08:58:53 +0000 (10:58 +0200)]
vapostproc: Add add-borders property to keep dar

Just as videoscale, it enables add-borders property (FALSE by default)
in vapostproc to add border, if necessary, to keep the display aspect
ratio from the original image.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1169>

2 years agovapostproc: Fix early fixation.
Víctor Manuel Jáquez Leal [Sat, 16 Oct 2021 08:51:57 +0000 (10:51 +0200)]
vapostproc: Fix early fixation.

First copy missing fields and then fixate all remaining fields.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1169>

2 years agoofa: remove ofa audio fingerprinting plugin
Tim-Philipp Müller [Thu, 14 Oct 2021 18:08:49 +0000 (19:08 +0100)]
ofa: remove ofa audio fingerprinting plugin

I think the MusicIP database for this has been defunct for years,
so I can't imagine this plugin is particularly useful or still
used by anyone.

See https://musicbrainz.org/doc/Fingerprinting#PUID

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1153>

2 years agomeson: Define cpp_std in the top-level project()
Nirbheek Chauhan [Wed, 13 Oct 2021 08:05:51 +0000 (13:35 +0530)]
meson: Define cpp_std in the top-level project()

Due to a bug, meson ignores ${lang}_std settings in default_options
for subprojects: https://github.com/mesonbuild/meson/issues/1889

This causes build failures when a subproject requires c++11 or c++14,
etc. Compilers that support those cpp_stds are very common, and all
the toolchains that we support include c++ compilers, so we can
add cpp_std=c++14 to the top-level.

This fixes the webrtc-audio-processing build on Linux, and harfbuzz on
macOS.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1133>

2 years agomeson: wasapi2,mediafoundation: Work around Windows SDK header issue
Seungha Yang [Sat, 16 Oct 2021 13:43:32 +0000 (22:43 +0900)]
meson: wasapi2,mediafoundation: Work around Windows SDK header issue

Some SDK headers are not standard compliant, so MSVC will
complain when such headers are in use with "/permissive-" compile
option. Use "/Zc:twoPhase-" to work around the issue as documented in
https://docs.microsoft.com/en-us/cpp/build/reference/permissive-standards-conformance?view=msvc-160#windows-header-issues

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1174>

2 years agolame:meson: Avoid using fallback when we could use system install
Thibault Saunier [Sun, 17 Oct 2021 04:59:35 +0000 (01:59 -0300)]
lame:meson: Avoid using fallback when we could use system install

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1176>

2 years agosubprojects: update vorbis wrap to 1.3.7 and add fallback url
Tim-Philipp Müller [Sat, 16 Oct 2021 22:53:04 +0000 (23:53 +0100)]
subprojects: update vorbis wrap to 1.3.7 and add fallback url

The Windows CI runners complain about self-signed certificates
with the download.xiph.org urls.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1175>

2 years agosubprojects: update ogg wrap to 1.3.5 and add fallback url
Tim-Philipp Müller [Sat, 16 Oct 2021 22:50:51 +0000 (23:50 +0100)]
subprojects: update ogg wrap to 1.3.5 and add fallback url

The windows ci runners complain about a self-signed certificate
with the download.xiph.org urls.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1175>

2 years agovalidate:known_issues:rtsp: Mark error message on bus as known
Thibault Saunier [Sat, 16 Oct 2021 14:32:53 +0000 (11:32 -0300)]
validate:known_issues:rtsp: Mark error message on bus as known

See https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/814

And reindent file.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1171>

2 years agomeson: Mark newly fdkaac/ogg/vorbis as allow fallback
Thibault Saunier [Sat, 16 Oct 2021 12:29:28 +0000 (09:29 -0300)]
meson: Mark newly fdkaac/ogg/vorbis as allow fallback

This way when the dep is `auto` we will fallback if the system
dependency is not available.

And use https to get libvorbis

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1171>

2 years agomediafoundation: Use GetProcAddress() for OS version dependent symbols
Seungha Yang [Fri, 15 Oct 2021 16:15:06 +0000 (01:15 +0900)]
mediafoundation: Use GetProcAddress() for OS version dependent symbols

We are using some symbols which are not available on Windows 7,
specifically D3D11 interop related ones

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1167>

2 years agovapostproc: Transfer colorimetry at fixate if possible.
Víctor Manuel Jáquez Leal [Wed, 6 Oct 2021 01:26:25 +0000 (03:26 +0200)]
vapostproc: Transfer colorimetry at fixate if possible.

Taken from videoconvert element.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1110>

2 years agomeson: Fix warning building GstGLEGL
Thibault Saunier [Sat, 16 Oct 2021 01:07:39 +0000 (22:07 -0300)]
meson: Fix warning building GstGLEGL

We forgot to add the `GstGL` gir as a dependency which was properly
done for GstGLWayland and GstGLX11.

And document why we use a list for `all_libraries`

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1168>

2 years agomeson: Support building lame as subproject
Thibault Saunier [Tue, 5 Oct 2021 14:38:33 +0000 (11:38 -0300)]
meson: Support building lame as subproject

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1068>

2 years agomeson: Add wrap for libvorbis and libogg
Thibault Saunier [Mon, 4 Oct 2021 17:41:28 +0000 (14:41 -0300)]
meson: Add wrap for libvorbis and libogg

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1068>

2 years agomeson: Add wrap for fdkaac
Thibault Saunier [Tue, 5 Oct 2021 21:51:57 +0000 (18:51 -0300)]
meson: Add wrap for fdkaac

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1068>

2 years agopython:meson: Do not build plugin when statically built
Thibault Saunier [Wed, 22 Sep 2021 16:12:07 +0000 (13:12 -0300)]
python:meson: Do not build plugin when statically built

It is not supported yet

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1093>

2 years agopython: Add an option to disable tests
Thibault Saunier [Tue, 14 Sep 2021 21:25:46 +0000 (18:25 -0300)]
python: Add an option to disable tests

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1093>

2 years agoci: Build introspection support on static builds
Thibault Saunier [Wed, 13 Oct 2021 02:28:57 +0000 (23:28 -0300)]
ci: Build introspection support on static builds

But disable python in GES as it is not supported on static builds

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1093>

2 years agoges:docs: Ignore GESImageSource as it is plain useless now
Thibault Saunier [Wed, 13 Oct 2021 02:25:40 +0000 (23:25 -0300)]
ges:docs: Ignore GESImageSource as it is plain useless now

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1093>

2 years agomeson: Add info about 'gstreamer-full'
Thibault Saunier [Wed, 13 Oct 2021 00:29:00 +0000 (21:29 -0300)]
meson: Add info about 'gstreamer-full'

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1093>

2 years agomeson: Streamline the way we detect when to build documentation
Thibault Saunier [Tue, 12 Oct 2021 18:52:48 +0000 (15:52 -0300)]
meson: Streamline the way we detect when to build documentation

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1093>

2 years agotests: Simple test to use gst-full in python
Thibault Saunier [Fri, 8 Oct 2021 01:34:38 +0000 (22:34 -0300)]
tests: Simple test to use gst-full in python

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1093>

2 years agovalidate:build: Disable static building validate tracer
Thibault Saunier [Sat, 2 Oct 2021 14:54:00 +0000 (11:54 -0300)]
validate:build: Disable static building validate tracer

It introduce duplication of symbols and we need to rework the way we implement it

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1093>

2 years agobuild: Expose ges symbols in gst-full
Thibault Saunier [Tue, 14 Sep 2021 11:57:15 +0000 (08:57 -0300)]
build: Expose ges symbols in gst-full

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1093>

2 years agoges:build: Disable python modules when statically building
Thibault Saunier [Mon, 13 Sep 2021 21:33:01 +0000 (18:33 -0300)]
ges:build: Disable python modules when statically building

Introspection fails otherwise

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1093>

2 years agoUse new `libraries` subprojects variables to statically link then
Thibault Saunier [Mon, 13 Sep 2021 21:20:11 +0000 (18:20 -0300)]
Use new `libraries` subprojects variables to statically link then

And also build the girs against `gstreamer-full` when possible. Also
making `gst_init_static_plugins` available from the bindings.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1093>

2 years agomeson: List libraries and their corresponding gir definition
Thibault Saunier [Sat, 27 Jun 2020 04:39:00 +0000 (00:39 -0400)]
meson: List libraries and their corresponding gir definition

Introduces a `libraries` variable that contains all libraries in a
list with the following format:

``` meson
libraries = [
    [pkg_name, {
        'lib': library_object
        'gir': [ {full gir definition in a dict } ]
    ],
    ....
]
```

It therefore refactors the way we build the gir so that we can reuse the
same information to build them against 'gstreamer-full' in gst-build
when linking statically

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1093>

2 years agomeson: Mark files as files()
Thibault Saunier [Sat, 27 Jun 2020 04:37:39 +0000 (00:37 -0400)]
meson: Mark files as files()

Making it more robust and future proof

And fix issues that it creates

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1093>

2 years agobad:audio: Add generated files sources in declare_dependency
Thibault Saunier [Mon, 13 Sep 2021 20:53:12 +0000 (17:53 -0300)]
bad:audio: Add generated files sources in declare_dependency

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1093>

2 years agopython: Fix using overrides when not building PyGObject
Thibault Saunier [Thu, 14 Oct 2021 20:01:01 +0000 (17:01 -0300)]
python: Fix using overrides when not building PyGObject

Since 547570cd790f2b2e390edc1dfb5df4c7a33de45c we do not always build
PyGObject and our development environment is broken when trying to use
GStreamer python when built against system PyGObject with the following
error importing Gst in there:

```
12345678** (gst-plugin-scanner:710617): CRITICAL **: 11:45:02.343: can't find gi.repository.Gst
Traceback (most recent call last):
  File "/usr/lib/python3.9/site-packages/gi/repository/__init__.py", line 23, in <module>
    from ..importer import DynamicImporter
  File "/usr/lib64/python3.9/site-packages/gi/importer.py", line 33, in <module>
    from .overrides import load_overrides
ImportError: cannot import name 'load_overrides' from 'gi.overrides' (/var/home/thiblahute/devel/gstreamer/gstreamer/subprojects/gst-editing-services/bindings/python/gi/overrides/__init__.py)
Factory Details:
```

The approach to fixing it is to implement override `gi` in
`gst-python/gi/` which we add to `PYTHONPATH`) and in there reset the
`gi` module to the right place and we get overrides from paths from
`_GI_OVERRIDES_PATH` we set in `gst-env.py` which points to all the
overrides that will be installed.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1155>

2 years agomediafoundation: Fix various string constness handling
Seungha Yang [Fri, 15 Oct 2021 14:18:41 +0000 (23:18 +0900)]
mediafoundation: Fix various string constness handling

... with fixing typo (g_strup -> g_strdup)

Constness needs to be explicit in C++ world otherwise compiler
would complain about that.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1164>

2 years agogstreamer/gst/gstconfig.h.in: Add support for ARC64 architecture
Veronika Kremneva [Fri, 8 Oct 2021 10:56:02 +0000 (13:56 +0300)]
gstreamer/gst/gstconfig.h.in: Add support for ARC64 architecture

Signed-off-by: Veronika Kremneva <kremneva@synopsys.com>
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1161>

2 years agomissing transceiver unref in WebRTC renegotiation example
Rob Agar [Fri, 15 Oct 2021 09:03:46 +0000 (10:03 +0100)]
missing transceiver unref in WebRTC renegotiation example

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1160>

2 years agoDocs: Fix a typo for Intel's vaapi driver name.
He Junyan [Thu, 14 Oct 2021 16:33:39 +0000 (00:33 +0800)]
Docs: Fix a typo for Intel's vaapi driver name.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1151>

2 years agowraps:ffmpeg: Move to 4.4
Thibault Saunier [Fri, 15 Oct 2021 00:00:59 +0000 (21:00 -0300)]
wraps:ffmpeg: Move to 4.4

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1156>

2 years agotests:va: Fix null ptr dereference in multi-vpp
Mengkejiergeli Ba [Wed, 13 Oct 2021 09:17:44 +0000 (17:17 +0800)]
tests:va: Fix null ptr dereference in multi-vpp

Dereference the pointer err before null check, which raised a null
pointer dereference issue by Coverity. Modify it to do the null check
of err first, then dereference it.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1143>

2 years agova: Fix null ptr dereference for vadeocder
Mengkejiergeli Ba [Wed, 13 Oct 2021 07:58:29 +0000 (15:58 +0800)]
va: Fix null ptr dereference for vadeocder

Making a null check in gst_va_decode_picture_free () indicates pic->buffers or pic->slices
can be null, then in _destroy_buffers () the pointers are dereferenced, which is detected
as dereference after null check by Coverity. Thus, modify the code to do null check in
_detroy_buffers ().

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1143>

2 years agoPin all wrap files to closest tag or commit sha1
Xavier Claessens [Thu, 14 Oct 2021 17:01:41 +0000 (13:01 -0400)]
Pin all wrap files to closest tag or commit sha1

Tracking branches, especially master, can cause regressions at any time.
We should try to use as much stable release tags as possible in the
future.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1152>

2 years agotsdemux: Handle delayed seek events
Vivia Nikolaidou [Mon, 5 Apr 2021 07:29:37 +0000 (10:29 +0300)]
tsdemux: Handle delayed seek events

Store the event in case it cannot be processed immediately and process
it after the first segment has been produced.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/980>

2 years agotsdemux: Protect demux->segment_event with a mutex
Vivia Nikolaidou [Mon, 5 Apr 2021 07:28:51 +0000 (10:28 +0300)]
tsdemux: Protect demux->segment_event with a mutex

Would otherwise cause weird issues when processing a delayed seek event

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/980>

2 years agovideo-converter: Fix v210->I420 last line conversion
Piotrek Brzeziński [Wed, 13 Oct 2021 19:28:58 +0000 (21:28 +0200)]
video-converter: Fix v210->I420 last line conversion

Last line would not be converted correctly if height was an odd number.
Fixed by accounting for data type (8bit vs. 16bit) differences between
respective packing and unpacking functions.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/973>

2 years agovideo-format: Clean up v210 packing code
Piotrek Brzeziński [Wed, 13 Oct 2021 14:53:41 +0000 (16:53 +0200)]
video-format: Clean up v210 packing code

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/973>

2 years agovideo-converter: Add fast paths from I420/YV12, UYVY, Y42B and YUY2 to v210
Piotrek Brzeziński [Wed, 13 Oct 2021 15:25:41 +0000 (17:25 +0200)]
video-converter: Add fast paths from I420/YV12, UYVY, Y42B and YUY2 to v210

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/973>