platform/upstream/gst-plugins-bad.git
3 years agoAdd webrtcsendrecv test app to tests/example/webrtc 94/231994/14
Hyunil [Mon, 27 Apr 2020 07:58:52 +0000 (16:58 +0900)]
Add webrtcsendrecv test app to tests/example/webrtc

 - Answerer logic is added
 - Add call stack log
 - Add use-camera-mic feature to use camera and mic
 - Add use-proxy feature to use proxy server
 - Add build define for webrtctest

Change-Id: Ide51737b4ef5a87ec853b4f8c1920ddab39dd502
Signed-off-by: Hyunil <hyunil46.park@samsung.com>
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
4 years agofixup! Enable opusparse plugin 59/231559/2 accepted/tizen/unified/20200423.054557 submit/tizen/20200422.053831
Jeongmo Yang [Wed, 22 Apr 2020 10:57:30 +0000 (19:57 +0900)]
fixup! Enable opusparse plugin

- The explicit build dependency should be added after correct spec file of gst-plugins-base package.

[Version] 1.16.2-2
[Profile] Common
[Issue Type] Bug fix

Change-Id: I6adcea6a2d2d7c4af6dc74912918707b2aeff3b1
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
4 years agoEnable opusparse plugin 77/230777/1 accepted/tizen/unified/20200417.152749 submit/tizen/20200416.021254
Jeongmo Yang [Tue, 14 Apr 2020 06:08:24 +0000 (15:08 +0900)]
Enable opusparse plugin

- This patch should be merged with opus enabled gst-plugins-base package.

[Version] 1.16.2-1
[Profile] Common
[Issue Type] Update

Change-Id: Iefa7deceff196974151e10fe4e820d52e93c7b02
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
4 years agosrtp: enable plugins 86/229486/2 accepted/tizen/unified/20200414.034752 submit/tizen/20200413.061815
Hyunil [Wed, 1 Apr 2020 09:08:32 +0000 (18:08 +0900)]
srtp: enable plugins

Change-Id: I3fc2b995862f194d63f84919635b5c31f1f62f97
Signed-off-by: Hyunil <hyunil46.park@samsung.com>
4 years agoMerge "Remove unrecognized configure options" into tizen accepted/tizen/unified/20200403.034458 submit/tizen/20200401.043141
Gilbok Lee [Tue, 31 Mar 2020 04:55:15 +0000 (04:55 +0000)]
Merge "Remove unrecognized configure options" into tizen

4 years agoRemove unrecognized configure options 99/229199/1
Gilbok Lee [Mon, 30 Mar 2020 08:20:28 +0000 (17:20 +0900)]
Remove unrecognized configure options

Change-Id: I3b2c18c417567ccd00edf50267769df8ddbeb213

4 years agosctp: enable sctpdec and sctpenc plugins 40/228040/2 accepted/tizen/unified/20200331.113953 submit/tizen/20200330.071150 submit/tizen/20200331.035513
Hyunil [Wed, 18 Mar 2020 09:15:55 +0000 (18:15 +0900)]
sctp: enable sctpdec and sctpenc plugins

Change-Id: Ifcd70387b5d3f36dcc980f5ee5a99f335440dc31
Signed-off-by: Hyunil <hyunil46.park@samsung.com>
4 years agodtls: enable plugins 45/227845/2 accepted/tizen/unified/20200319.131222 submit/tizen/20200319.040207
Hyunil [Tue, 17 Mar 2020 01:00:25 +0000 (10:00 +0900)]
dtls: enable plugins

Change-Id: Ia8c157ce48f59448eb600d84e3da2d3138c2a153
Signed-off-by: Hyunil <hyunil46.park@samsung.com>
4 years agowebrtc: modify to allow installation of webrtc plugin 34/227334/2 submit/tizen/20200316.053051
Hyunil [Wed, 11 Mar 2020 08:35:38 +0000 (17:35 +0900)]
webrtc: modify to allow installation of webrtc plugin

Change-Id: I84a51559a4504ff0d73f9b4617906e51d57c5e42
Signed-off-by: Hyunil <hyunil46.park@samsung.com>
4 years agosoundtouch: fix coverity issue 08/227008/1 accepted/tizen/unified/20200311.130844 submit/tizen/20200309.044950 submit/tizen/20200309.101910 submit/tizen/20200310.083131
Eunhye Choi [Mon, 9 Mar 2020 04:45:03 +0000 (13:45 +0900)]
soundtouch: fix coverity issue

Change-Id: I7290f22c61ffda3f27ea77e5232d332be9d5c3d4

4 years agoMerge branch 'tizen_gst_1.16.2' into tizen 94/225594/1 accepted/tizen/unified/20200304.124000 submit/tizen/20200221.064623 submit/tizen/20200302.032418
Gilbok Lee [Fri, 21 Feb 2020 06:24:41 +0000 (15:24 +0900)]
Merge branch 'tizen_gst_1.16.2' into tizen

Change-Id: Icf2e38c593ba1f1e4a74ddb1bd1559af6d123676

4 years agopitch: add audio meta 51/225051/3 tizen_gst_1.16.2
Eunhye Choi [Fri, 14 Feb 2020 07:59:05 +0000 (16:59 +0900)]
pitch: add audio meta

- add audio meta info in case of non-interleaved layout
  which is required when it is converted to interleaved.

Change-Id: I8a7c03b9a40f9093e6f0416e53b75f14086d6b88

4 years agoMerge branch 'upstream/1.16' into tizen_gst_1.16.2 52/223352/1
Gilbok Lee [Thu, 23 Jan 2020 02:18:14 +0000 (11:18 +0900)]
Merge branch 'upstream/1.16' into tizen_gst_1.16.2

Change-Id: Ib1a717363ad97f1695fb888bc2caa3c2ccff8ee2

4 years agoRelease 1.16.2 upstream/1.16 1.16.2
Tim-Philipp Müller [Tue, 3 Dec 2019 11:12:59 +0000 (11:12 +0000)]
Release 1.16.2

4 years agoUpdate docs
Tim-Philipp Müller [Tue, 3 Dec 2019 11:12:58 +0000 (11:12 +0000)]
Update docs

4 years agoUpdate translations
Tim-Philipp Müller [Tue, 3 Dec 2019 11:12:56 +0000 (11:12 +0000)]
Update translations

4 years agoavfvideosrc: Explicitly request device video permissions for macOS 10.14+
o0Ignition0o [Sat, 30 Nov 2019 13:08:06 +0000 (14:08 +0100)]
avfvideosrc: Explicitly request device video permissions for macOS 10.14+

Since macOS Mojave (10.14), video permissions have to be explicitly
granted by a user in order to open a video device such as a camera.
This commit adds a check for the current permission status, and tries
to request for permission if applicable.

4 years agoopenexr: Fix check for when to pass -std=c++98
Nirbheek Chauhan [Sun, 1 Dec 2019 11:34:05 +0000 (17:04 +0530)]
openexr: Fix check for when to pass -std=c++98

commit 6adfb120ab0e1bb0b3439ad725a362cfe4fbe733 added this flag to fix
builds with `-Werror`, and afterwards it was changed to use a version
check when newer versions of openexr moved over to C++11.

However, some distros have backported patches to older openexr
versions which make it require C++11, which makes the version check
incorrect and causes an error because we passed `-Werror -std=c++98`.

Instead, directly check when usage of the header requires `-std=c++98`
with `-Werror` and override the `cpp_std` setting on the target.

Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/1117

4 years agowasapisrc: Correctly handle BUFFERFLAGS_SILENT
Nirbheek Chauhan [Tue, 26 Nov 2019 06:09:32 +0000 (11:39 +0530)]
wasapisrc: Correctly handle BUFFERFLAGS_SILENT

We need to ignore the data we get from WASAPI in this case and write
out silence (zeroes).

Initially reported at https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/808

4 years agowasapisrc: Try harder to avoid debug output in the hot loop
Nirbheek Chauhan [Mon, 25 Nov 2019 15:55:43 +0000 (21:25 +0530)]
wasapisrc: Try harder to avoid debug output in the hot loop

The whole `src_read()` function is a hot loop since the ringbuffer
thread is waiting on us, and printing to the console from inside it
can easily cause us to miss our deadline.

F.ex., if you had GST_DEBUG=3 and we accidentally missed a device
period, we'd trigger the "reported glitch" warning, which would cause
us to miss another device period, and so on. Let's reduce the log
level so that GST_DEBUG=3 is more usable, and only print buffer flag
info when it's actually relevant.

4 years agowasapisrc: Fix capturing from some buggy audio drivers
Nirbheek Chauhan [Mon, 25 Nov 2019 15:49:59 +0000 (21:19 +0530)]
wasapisrc: Fix capturing from some buggy audio drivers

Some audio drivers return varying amounts of data per ::GetBuffer
call, instead of following the device period that they've told us
about in `src_prepare()`.

Previously, we would just drop those extra buffers hoping that the
extra buffers were temporary (f.ex., a startup 'burst' of audio data).
However, it seems that some audio drivers, particularly on older
Windows versions (such as Windows 10 1703 and older) consistently
return varying amounts of data.

Use GstAdapter to smooth that out, and hope that the audio driver is
locally varying but globally periodic.

Initially reported in https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/808

4 years agowasapisrc: Clarify that nBlockAlign is actually bpf
Nirbheek Chauhan [Mon, 25 Nov 2019 15:46:05 +0000 (21:16 +0530)]
wasapisrc: Clarify that nBlockAlign is actually bpf

bpf = bytes per frame.

4 years agowasapisrc: Fix glitching and clock skew issues
Nirbheek Chauhan [Mon, 25 Nov 2019 15:30:14 +0000 (21:00 +0530)]
wasapisrc: Fix glitching and clock skew issues

We were miscalculating the device period, i.e. the number of frames
we'll get from WASAPI in each IAudioClient::GetBuffer call, due to
a calculation mistake (truncate instead of round).

For example, on my machine when the aux input is set to 44.1KHz, the
reported device period is 101587, which comes out to 447.998 frames
per ::GetBuffer call. In reality we will, of course, get 448 frames
per call, but we were truncating, so we expected 447 and were
discarding one frame every time. This led to glitching, and skew over
time.

Interestingly, I can only see this with 44.1Khz. 48Khz/96Khz are fine,
because the device period is a more 'even' number.

Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/806

4 years agowasapi: Move to CoInitializeEx for COM initialization
Nirbheek Chauhan [Tue, 13 Aug 2019 17:24:42 +0000 (22:54 +0530)]
wasapi: Move to CoInitializeEx for COM initialization

CoInitialize is not allowed when targeting UWP and causes a Windows
Application Certification Kit (WACK) error.

4 years agowaylandsink: Commit the parent after creating subsurface
Jeffy Chen [Mon, 25 Nov 2019 11:08:48 +0000 (19:08 +0800)]
waylandsink: Commit the parent after creating subsurface

We should commit the parent to activate new subsurface, this is
documented in the protocol.

Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
4 years agomsdkdec: fix surface leak in msdkdec_handle_frame
Julien Isorce [Mon, 18 Nov 2019 22:26:31 +0000 (14:26 -0800)]
msdkdec: fix surface leak in msdkdec_handle_frame

Can be reproduced with:
  videotestsrc ! x264enc key-int-max=$N ! \
  h264parse ! msdkh264dec ! fakesink sync=1

It happens with any gop size but the smaller is the distance N
between key frames, the quicker it is leaking.

Fixes #1023

4 years agotsmux: Fix copying of buffer region
Kyrylo Polezhaiev [Thu, 5 Sep 2019 01:16:28 +0000 (03:16 +0200)]
tsmux: Fix copying of buffer region

4 years agotsdemux: Handle continuity mismatch in more cases
Edward Hervey [Wed, 6 Nov 2019 13:22:07 +0000 (14:22 +0100)]
tsdemux: Handle continuity mismatch in more cases

Packets of a given PID are meant to have sequential continuity counters
(modulo 16). If there are not sequential, this is the sign of a broken
stream, which we then consider as a discontinuity.

But if that new packet is a frame start (PUSI is true), then we can resume
from that packet without any damage.

4 years agotsdemux: Always issue a DTS even when it's equal to PTS
Vivia Nikolaidou [Fri, 11 Oct 2019 14:25:04 +0000 (17:25 +0300)]
tsdemux: Always issue a DTS even when it's equal to PTS

Currently tsdemux timestamps only the PTS, and only issues the DTS if
it's different. In that case, parsers tend to estimate the next DTS
based on the previous DTS and the duration, which can accumulate
rounding errors.

4 years agoopenexr: fix compilation with openexr >= 2.4.0 in autotools
Tim-Philipp Müller [Mon, 11 Nov 2019 13:03:22 +0000 (13:03 +0000)]
openexr: fix compilation with openexr >= 2.4.0 in autotools

Only pass -std=c++98 for openexr 2.3.x.

4 years agoopenexr: Fix compilation with OpenEXR 2.4
Jan Alexander Steffens (heftig) [Sat, 2 Nov 2019 15:51:09 +0000 (16:51 +0100)]
openexr: Fix compilation with OpenEXR 2.4

It uses modern C++; adding -std=c++98 breaks the build.

4 years agoccextractor: Remove unused set/get_property() functions
Sebastian Dröge [Mon, 28 Oct 2019 09:25:15 +0000 (11:25 +0200)]
ccextractor: Remove unused set/get_property() functions

4 years agoccextractor: Always forward all sticky events to the caption pad
Sebastian Dröge [Mon, 28 Oct 2019 09:22:06 +0000 (11:22 +0200)]
ccextractor: Always forward all sticky events to the caption pad

And only update the caps and stream-start event accordingly. This
ensures that we'll always forward sticky events that arrive after the
caption pad was created, and especially updates to existing sticky
events like the segment event.

Also create a proper stream id based on the upstream stream id for the
stream-start event, and make sure that all the sticky events we know are
already on the caption pad at the time it is added to the element.

4 years agopnmdec: Return early on ::finish() if we have no actual data to parse
Sebastian Dröge [Tue, 22 Oct 2019 06:30:34 +0000 (09:30 +0300)]
pnmdec: Return early on ::finish() if we have no actual data to parse

Otherwise we'd be working with a NULL buffer and cause various critical
warnings along the way.

Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/1104

4 years agowasapi: Fix build warnings
Seungha Yang [Tue, 17 Sep 2019 11:32:18 +0000 (20:32 +0900)]
wasapi: Fix build warnings

gstwasapiutil.c(173) : warning C4715: 'gst_wasapi_device_role_to_erole': not all control paths return a value
gstwasapiutil.c(188) : warning C4715: 'gst_wasapi_erole_to_device_role': not all control paths return a value

4 years agowasapi: Don't cast GstDeviceProvider to GstElement
Seungha Yang [Tue, 17 Sep 2019 11:29:03 +0000 (20:29 +0900)]
wasapi: Don't cast GstDeviceProvider to GstElement

The GstDeviceProvider isn't subclass of GstElement.

(gst-device-monitor-1.0:49356): GLib-GObject-WARNING **: 20:21:18.651:
invalid cast from 'GstWasapiDeviceProvider' to 'GstElement'

4 years agoass: avoid infinite unref loop with bad data
Matthew Waters [Sun, 6 Oct 2019 13:05:08 +0000 (00:05 +1100)]
ass: avoid infinite unref loop with bad data

A classic case of not updating the next item to iterate after deleting
it from the singly linked list.

Only ever hit with a text buffer with GST_CLOCK_TIME_NONE for either the
timestamp or duration.

4 years agofluidsynth: add sf3 to soundfont search path
Fabian Greffrath [Tue, 24 Sep 2019 18:29:21 +0000 (20:29 +0200)]
fluidsynth: add sf3 to soundfont search path

In Debian, soundfonts in SF3 format (i.e. the same as SF2 format but
with Ogg/Vorbis-compressed samples) are installed into
/usr/share/sounds/sf3. Soundfonts in SF3 format are supported since
FluidSynth 1.1.7 (released in Feb 2018).

4 years agoRelease 1.16.1
Tim-Philipp Müller [Mon, 23 Sep 2019 10:14:45 +0000 (11:14 +0100)]
Release 1.16.1

4 years agoUpdate docs
Tim-Philipp Müller [Mon, 23 Sep 2019 10:14:44 +0000 (11:14 +0100)]
Update docs

4 years agoUpdate translations
Tim-Philipp Müller [Mon, 23 Sep 2019 10:14:41 +0000 (11:14 +0100)]
Update translations

4 years agoRemove gles20 dependency for headless 83/213783/4 accepted/tizen_5.5_unified_mobile_hotfix tizen_5.5_mobile_hotfix tizen_5.5_tv accepted/tizen/5.5/unified/20191031.005245 accepted/tizen/5.5/unified/mobile/hotfix/20201027.062158 accepted/tizen/unified/20190917.034127 accepted/tizen/unified/20190918.010331 submit/tizen/20190917.001550 submit/tizen/20190917.100430 submit/tizen_5.5/20191031.000006 submit/tizen_5.5_mobile_hotfix/20201026.185106 tizen_5.5.m2_release
Hyunil [Wed, 11 Sep 2019 07:53:48 +0000 (16:53 +0900)]
Remove gles20 dependency for headless

Change-Id: I6e40914194de856c5078d19e7e93d396f0639ba6
Signed-off-by: Hyunil <hyunil46.park@samsung.com>
4 years agohls: Make crypto dependency optional when hls-crypto is auto
Seungha Yang [Tue, 9 Apr 2019 11:07:05 +0000 (20:07 +0900)]
hls: Make crypto dependency optional when hls-crypto is auto

crypto libraries are not required for hlssink and hlssink2.
Also, hlsdemux with nonencrypted stream can work without crpyto.

Make an error only when users set "hls-crpyto" with non-auto option explicitly,
but no crpyto library was found.

4 years agogst-player: fix bug with changing playback direction
Askar Safin [Wed, 4 Sep 2019 09:54:17 +0000 (12:54 +0300)]
gst-player: fix bug with changing playback direction

Fix gst_event_new_seek call in gst-libs/gst/player/gstplayer.c

If rate >= 0.0, then previous code doesn't set end of segment. So, the end of segment
will be in place where previous seek put it. This is not neccesary end of media file
(in case of reverse playback). So if we play video backward for some time and then
switched to forward playing, we will get EOS somewhere in the middle of media file.
This commit always sets end of segment, thus fixing this bug

4 years agodecklinkaudiosink: Drop late buffers
Matthew Waters [Wed, 21 Aug 2019 11:35:30 +0000 (06:35 -0500)]
decklinkaudiosink: Drop late buffers

Asking decklink to render audio data seems to be based entirely on
the sample counts which completely disregards the timestamps
we pass to decklink.  As a result, we need to explicitly check
for late buffers and drop them ourselves.

4 years agodecklink: Allow VANC to be used for all modes
Sebastian Dröge [Mon, 22 Apr 2019 12:42:12 +0000 (15:42 +0300)]
decklink: Allow VANC to be used for all modes

4 years agodecklinkvideosrc: Also set the INTERLACED buffer flag on non-TFF buffers
Sebastian Dröge [Wed, 7 Aug 2019 09:58:03 +0000 (12:58 +0300)]
decklinkvideosrc: Also set the INTERLACED buffer flag on non-TFF buffers

4 years agodecklinkvideosrc: Retrieve mode of the ancillary data from the frame
Sebastian Dröge [Fri, 16 Aug 2019 08:55:22 +0000 (11:55 +0300)]
decklinkvideosrc: Retrieve mode of the ancillary data from the frame

Instead of using the information we stored ourselves for the video frame
itself. Which was also the wrong one: it was the mode from the property,
not the autodetected one.

This fixes vanc extraction with mode=auto

4 years agosrt: Set latency property on SRT socket
Olivier Crête [Fri, 23 Aug 2019 22:40:49 +0000 (18:40 -0400)]
srt: Set latency property on SRT socket

4 years agosrt: Add sender side statistics
Olivier Crête [Fri, 23 Aug 2019 21:54:49 +0000 (17:54 -0400)]
srt: Add sender side statistics

4 years agosrtobject: Remove pointless GMainLoop
Olivier Crête [Fri, 23 Aug 2019 20:21:47 +0000 (16:21 -0400)]
srtobject: Remove pointless GMainLoop

Just use srt's blocking epoll function and fix locking while we're at it.

4 years agodshowsrcwrapper: fix regression on device selection
gla [Tue, 20 Aug 2019 10:44:44 +0000 (12:44 +0200)]
dshowsrcwrapper: fix regression on device selection

Do not take device_name if a device has been specified. Do not take device_index into account if a device or a device name has been specified.

4 years agotsdemux: Limit the maximum PES payload size
Jan Schmidt [Fri, 28 Jun 2019 05:04:29 +0000 (15:04 +1000)]
tsdemux: Limit the maximum PES payload size

PES packets with size 0 are unbounded, and
could therefore overflow the 32-bit size
accumulator.

Add a 32MB limit, which is larger than
any PES packet should ever get. If one does,
then output a 32MB chunk and continue.

4 years agoiqa: fix leak of map_meta.data
Mathieu Duponchelle [Fri, 16 Aug 2019 13:22:26 +0000 (15:22 +0200)]
iqa: fix leak of map_meta.data

4 years agoext/wayland: Define libdrm_dep in meson.build
Thomas Coldrick [Wed, 14 Aug 2019 10:24:19 +0000 (11:24 +0100)]
ext/wayland: Define libdrm_dep in meson.build

4 years agosctp: Fix crash on free() when using the MSVC binaries
Nirbheek Chauhan [Tue, 20 Aug 2019 08:51:17 +0000 (14:21 +0530)]
sctp: Fix crash on free() when using the MSVC binaries

On Windows, if libusrsctp and gstreamer are built with different
C runtimes (CRT), we cannot free memory allocated inside libusrsctp
with the `free()` function from gstreamer's CRT.

`usrsctp_freedumpbuffer()` simply calls `free()`, but because of the
way DLLs work on Windows, it will always call the free function from
the correct CRT.

4 years agowebrtc: Fix signals documentation
Niels De Graef [Thu, 9 May 2019 12:08:31 +0000 (14:08 +0200)]
webrtc: Fix signals documentation

Some GIR annotations were incorrect or even missing. The former isn't
good for bindings, while the latter is especially annoying for signal
handlers, as that means your arguments will get the wrong names in the
rendered documentation.

4 years agoh264parse: don't critical on VUI parameters > 2^31
Matthew Waters [Wed, 14 Aug 2019 12:08:34 +0000 (22:08 +1000)]
h264parse: don't critical on VUI parameters > 2^31

A guint32 greater than 2^31 would be interpreted as negative by
gst_util_uint64_scale_int() and critical. Use the 64-bit integer version
of the function instead.

4 years agortmp: Fix crash inside free() with MSVC on Windows
Nirbheek Chauhan [Mon, 19 Aug 2019 19:00:04 +0000 (00:30 +0530)]
rtmp: Fix crash inside free() with MSVC on Windows

librtmp is always built with MinGW in Cerbero, so if the plugin is
built with MSVC and it frees memory allocated by librtmp, that leads
to a crash since the CRT used by MinGW and MSVC are different.

This is fixed in master by switching to a newer GCC toolchain which
has been configured to use the same CRT as newer versions of Visual
Studio, so there's no cross-CRT memory alloc/free issues.

See: https://gitlab.freedesktop.org/gstreamer/cerbero/issues/164

4 years agod3dvideosink: Fix crash on WinProc handler
Seungha Yang [Thu, 15 Aug 2019 08:49:12 +0000 (17:49 +0900)]
d3dvideosink: Fix crash on WinProc handler

... caused by null pointer dereference. The d3dvideosink object might
not available yet on the handler.

4 years agoamc: Fix crash when a sync_meta survives its sink
Xavier Claessens [Wed, 14 Aug 2019 15:21:30 +0000 (11:21 -0400)]
amc: Fix crash when a sync_meta survives its sink

_amc_gl_free() could be called after the GstAmcVideoDec has been
finalized, in the case downstream still has a ref to a buffer.

4 years agopitch: Fix race between putSamples() and setting soundtouch parameters
Doug Nazar [Fri, 9 Aug 2019 06:41:51 +0000 (02:41 -0400)]
pitch: Fix race between putSamples() and setting soundtouch parameters

The various soundtouch set*() functions may cause buffer (re)allocations
which interferes with inputting the audio data.

4 years agowebrtc: fix type of max-retransmits, make it work
David Gunzinger [Tue, 13 Aug 2019 10:10:54 +0000 (12:10 +0200)]
webrtc: fix type of max-retransmits, make it work

4 years agomxfdemux: Also allow picture essence element type 0x05 for VC-3
Sebastian Dröge [Mon, 12 Aug 2019 17:26:51 +0000 (20:26 +0300)]
mxfdemux: Also allow picture essence element type 0x05 for VC-3

It's found like this in various files out there even if it does not
conform to SMPTE 2019-4.

4 years agodecklinkaudiosrc/decklinkvideosrc: Do nothing in BaseSrc::negotiate() and always...
Sebastian Dröge [Tue, 6 Aug 2019 18:44:35 +0000 (21:44 +0300)]
decklinkaudiosrc/decklinkvideosrc: Do nothing in BaseSrc::negotiate() and always set caps in ::create()

We don't support negotiation with downstream but simply set caps based
on the buffers we receive. This prevents renegotiation to other formats,
and negotiation to NTSC in mode=auto in the beginning until the first
buffer is received.

As side-effect of this, also remove various other caps handling code
that was working around the behaviour of the default
BaseSrc::negotiate().

4 years agowasapi: fix symbol redefinition build error
Ignacio Casal Quinteiro [Tue, 6 Aug 2019 15:42:15 +0000 (17:42 +0200)]
wasapi: fix symbol redefinition build error

4 years agoRevert "dtls: fix generated cert dtls agent leak"
Tim-Philipp Müller [Mon, 12 Aug 2019 07:10:42 +0000 (08:10 +0100)]
Revert "dtls: fix generated cert dtls agent leak"

This reverts commit 6c8831bd1e6e6641534b4b129100661dd8f472b0 from !588

This fix was wrong and also reverted in master.`

4 years agosiren: fix a global buffer overflow spotted by asan
Fabrice Bellet [Mon, 22 Jul 2019 08:00:00 +0000 (08:00 +0000)]
siren: fix a global buffer overflow spotted by asan

This patch just enforces boudaries for the access to the
standard_deviation array (64 floats). Such case can be
seen with a corrupted stream, where there's no hope to
obtain a valid decoded frame anyway.

https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/1002

4 years agoext/hls/meson.build: fix dependency logic
Adam Duskett [Wed, 29 May 2019 18:33:02 +0000 (18:33 +0000)]
ext/hls/meson.build: fix dependency logic

Currently, if one was to set -Dhls-crypto to either libgcrypt or openssl
instead of auto, the following lines would fail because hls_crypto_dep is not
yet set:

if not hls_crypto_dep.found() and ['auto', 'libgcrypt'].contains(hls_crypto)
if not hls_crypto_dep.found() and ['auto', 'openssl'].contains(hls_crypto)

Instead, change "if not hls_crypto_dep.found()" to "if not have_hls_crypto"
which fixes the error.

4 years agowebrtc: Add various Since markers to new types after 1.14.0
Sebastian Dröge [Tue, 21 May 2019 09:15:55 +0000 (12:15 +0300)]
webrtc: Add various Since markers to new types after 1.14.0

4 years agodtlsagent: Do not overwrite openssl locking callbacks
Jose Antonio Santos Cadenas [Tue, 14 May 2019 07:36:15 +0000 (07:36 +0000)]
dtlsagent: Do not overwrite openssl locking callbacks

4 years agoFixed segtotal value being always 2 due to an unused variable
Marcos Kintschner [Wed, 1 May 2019 00:25:12 +0000 (21:25 -0300)]
Fixed segtotal value being always 2 due to an unused variable

The 'MAX' expression used to set segtotal always returned 2 because
the unused and uninitialized variable buffer_frame_count was always 0

4 years agoadaptivedemux: remove some deadlocks using webkitwebsrc.
Charlie Turner [Tue, 2 Jul 2019 11:27:40 +0000 (12:27 +0100)]
adaptivedemux: remove some deadlocks using webkitwebsrc.

WebKit's websrc depends on the main-thread for download completion
rendezvous. This exposed a number of deadlocks in adaptivedemux due to
it holding the MANIFEST_LOCK during network requests, and also needing
to hold it to change_state and resolve queries, which frequently occur
during these download windows.

Make demux->running MT-safe so that it can be accessed without using the
MANIFEST_LOCK. In case a source is downloading and requires a MT-thread
notification for completion of the fragment download, a state change
during this download window will deadlock unless we cancel the downloads
and ensure they are not restarted before we finish the state-change.

Also make demux->priv->have_manifest MT-safe. A duration query happening
in the window described above can deadlock for the same reason. Other
src queries (like SEEKING) that happen in this window also could
deadlock, but I haven't hit this scenario.

Increase granularity of API_LOCK'ing in change_state as well. We need to
cancel downloads before trying to take this lock, since sink events
(EOS) will hold it before starting a fragment download.

4 years agowebrtcbin: fix GInetAddress leak
Ilya Smelykh [Mon, 29 Jul 2019 07:56:16 +0000 (14:56 +0700)]
webrtcbin: fix GInetAddress leak

4 years agodtls: fix generated cert dtls agent leak
Ilya Smelykh [Thu, 25 Jul 2019 13:03:02 +0000 (20:03 +0700)]
dtls: fix generated cert dtls agent leak

The generated certificate dtls agent was refed two times on the first call.

4 years agodtls: fix dtls connection object leak
Ilya Smelykh [Thu, 25 Jul 2019 10:00:14 +0000 (10:00 +0000)]
dtls: fix dtls connection object leak

4 years agokmssink: Fix implicit declaration build error
Seungha Yang [Tue, 16 Jul 2019 16:05:32 +0000 (01:05 +0900)]
kmssink: Fix implicit declaration build error

ffs() and strcmp() require string.h

gstkmssink.c:255:28: error: implicit declaration of function ‘ffs’ [-Werror=implicit-function-declaration]
       crtc_id = res->crtcs[ffs (crtcs_for_connector) - 1];
                            ^~~

gstkmssink.c:590:10: error: implicit declaration of function ‘strcmp’ [-Werror=implicit-function-declaration]
     if (!strcmp (property->name, prop_name)) {
          ^~~~~~

4 years agoFix -Werror=return-type error in configure.
Martin Liska [Mon, 15 Jul 2019 14:05:05 +0000 (16:05 +0200)]
Fix -Werror=return-type error in configure.

4 years agoaiff: Fix infinite loop in header parsing.
Martin Theriault [Mon, 15 Jul 2019 19:48:08 +0000 (15:48 -0400)]
aiff: Fix infinite loop in header parsing.

4 years agonvdec: Fix possible frame drop on EOS
Seungha Yang [Thu, 20 Dec 2018 03:37:43 +0000 (12:37 +0900)]
nvdec: Fix possible frame drop on EOS

On eos, baseclass videoencoder call finish() vfunc instead of drain()

4 years agosrt: Remove msg-size property
Olivier Crête [Mon, 8 Jul 2019 19:51:43 +0000 (15:51 -0400)]
srt: Remove msg-size property

Remove the now unused property

4 years agosrtsrc: Receive one frame per gstbuffer
Olivier Crête [Mon, 8 Jul 2019 19:50:59 +0000 (15:50 -0400)]
srtsrc: Receive one frame per gstbuffer

Don't aggregate the received data, just receive it one packet at a
time. So it keeps the packetization boundaries

4 years agosrt: Fix listener crash if no URI is specified
Nicolas Dufresne [Sat, 6 Jul 2019 20:15:40 +0000 (16:15 -0400)]
srt: Fix listener crash if no URI is specified

4 years agosrt: Use macro instead of duplicating a default value
Nicolas Dufresne [Sat, 6 Jul 2019 19:53:26 +0000 (15:53 -0400)]
srt: Use macro instead of duplicating a default value

4 years agosrt: Fix confusing typo in FIXME comment
Nicolas Dufresne [Sat, 6 Jul 2019 19:45:20 +0000 (15:45 -0400)]
srt: Fix confusing typo in FIXME comment

SRT does not support IPv6, but the comment said IPv4 which was the
opposite of the following code.

4 years agodtlsagent: Clear the certificate upon finalize
Juan Navarro [Tue, 25 Jun 2019 18:37:57 +0000 (20:37 +0200)]
dtlsagent: Clear the certificate upon finalize

Cleaning this up was likely just forgotten

4 years agodtlsdec: Avoid duplicate ref when passing certificate property
Juan Navarro [Tue, 25 Jun 2019 18:37:38 +0000 (20:37 +0200)]
dtlsdec: Avoid duplicate ref when passing certificate property

The agent itself will take a ref on the property setter, so we'll be
left with two references to the certificate object, when actually there
should be only one

4 years agomeson: bluez: Early terminate configure on Windows
Seungha Yang [Mon, 20 May 2019 14:19:19 +0000 (23:19 +0900)]
meson: bluez: Early terminate configure on Windows

This plugin is for linux bluetooth stack. So the early termination can save
configure time on Windows (i.e., we can avoid glib subproject fallback)

4 years agodecklink: Correctly ensure >=16 byte alignment for the buffers we allocate
Sebastian Dröge [Thu, 20 Jun 2019 05:59:22 +0000 (08:59 +0300)]
decklink: Correctly ensure >=16 byte alignment for the buffers we allocate

We'll ensure at least 64 byte alignment for AVX2 but 16 byte alignment
is what is required by the decklink SDK.

Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/986

4 years agowebrtcbin: fix DTLS when receivebin is set to DROP
Mathieu Duponchelle [Wed, 19 Jun 2019 17:43:14 +0000 (19:43 +0200)]
webrtcbin: fix DTLS when receivebin is set to DROP

Regression introduced by b4bdcf15b7237eb5c5943c4f746701a477333000

This commit prevents the handshake from reaching dtlsdec when
the receive state of the receive bin is set to DROP (for example
when transceivers are sendonly).

This preserves the intent of the commit, by blocking the bin
at its sinks until the receive state is no longer BLOCK, but
makes sure the handshake still goes through, by only dropping
data at the src pads, as was the case before.

4 years agozbar: Include running-time, stream-time and duration in the messages
Sebastian Dröge [Wed, 19 Jun 2019 10:31:39 +0000 (13:31 +0300)]
zbar: Include running-time, stream-time and duration in the messages

The timestamp/PTS alone is meaningless without the segment and usually
applications care about the running-time or stream-time.

This also keeps the messages in sync with the spectrum and level
elements.

4 years agouvch264src: Make sure we set our segment
Thibault Saunier [Tue, 11 Jun 2019 16:10:13 +0000 (12:10 -0400)]
uvch264src: Make sure we set our segment

We were not setting self->segment and we are using it
when notifying downstream that we handled a REQUEST_KEY_UNIT
event, leading to all sort of criticals.

4 years agoavwait: Allow start and end timecode to be set back to NULL
Sebastian Dröge [Wed, 5 Jun 2019 08:46:49 +0000 (11:46 +0300)]
avwait: Allow start and end timecode to be set back to NULL

And check everywhere if they're NULL before accessing them.

4 years agoavwait: Don't print warnings for every buffer passed
Vivia Nikolaidou [Tue, 2 Oct 2018 08:25:14 +0000 (11:25 +0300)]
avwait: Don't print warnings for every buffer passed

4 years agowaylandsink: Workaround gnome-shell bug
Nicolas Dufresne [Fri, 24 May 2019 00:24:40 +0000 (20:24 -0400)]
waylandsink: Workaround gnome-shell bug

Use a timeout to limit that amount of time we wait after the compositor
for the initial configure event. Compositor are support to emit a
configure event before any wl_buffer can be attached. The problem is
that Weston strongly enforce this, while gnome-shell simply does not
emit such an event.

4 years agoavwait: Protect properties and some other code with the mutex
Sebastian Dröge [Mon, 20 May 2019 13:15:08 +0000 (16:15 +0300)]
avwait: Protect properties and some other code with the mutex

These variables are all accessed from multiple threads.

Also fix some minor leaks in error code paths.

4 years agoavwait: Insert some empty lines to give the code some space to breath
Sebastian Dröge [Mon, 20 May 2019 12:45:50 +0000 (15:45 +0300)]
avwait: Insert some empty lines to give the code some space to breath

4 years agoavwait: Allow setting start timecode after end timecode and the other way around
Sebastian Dröge [Mon, 20 May 2019 12:30:28 +0000 (15:30 +0300)]
avwait: Allow setting start timecode after end timecode and the other way around

This might be necessary temporarily for changing the previous settings.
Make it an actual error if the settings are like this while processing a
buffer.

4 years agowayland/wlbuffer: just return if used_by_compositor is true when attach
Haihua Hu [Thu, 18 Oct 2018 05:35:04 +0000 (13:35 +0800)]
wayland/wlbuffer: just return if used_by_compositor is true when attach

When buffer is used by compositor, we don't need attach it and hold one
more reference. Just check used_by_compositor, just return if it is true.
Assert error log is not need, this is normal behavior.

4 years agoproxy: Forward queries/events sent directly to the element correctly
Sebastian Dröge [Tue, 21 May 2019 13:17:40 +0000 (16:17 +0300)]
proxy: Forward queries/events sent directly to the element correctly