From c485eb9314c70c3e5bc3f2eb87bd9d3edea8ae45 Mon Sep 17 00:00:00 2001 From: Daniel Kolesa Date: Fri, 7 Jan 2022 06:47:04 +0100 Subject: [PATCH] openssl: explicitly NULL initialize PKCS8_PRIV_KEY_INFO Otherwise, PKCS8_PRIV_KEY_INFO_free will be called on an uninitialized value if `!openssl->key` is true. This results in WebKit TLS being broken at least with OpenSSL 3.x and libsoup3. Change-Id: I6cd3977f0c15c08a71600329de06f29081d66681 Part-of: --- tls/openssl/gtlscertificate-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tls/openssl/gtlscertificate-openssl.c b/tls/openssl/gtlscertificate-openssl.c index f3afc3d..7357c10 100644 --- a/tls/openssl/gtlscertificate-openssl.c +++ b/tls/openssl/gtlscertificate-openssl.c @@ -144,7 +144,7 @@ export_privkey_to_der (GTlsCertificateOpenssl *openssl, guint8 **output_data, long *output_size) { - PKCS8_PRIV_KEY_INFO *pkcs8; + PKCS8_PRIV_KEY_INFO *pkcs8 = NULL; BIO *bio = NULL; const guint8 *data; -- 2.7.4